Completed
Push — master ( e4c19d...24af62 )
by
unknown
05:16
created
includes/Serializer/ComparisonResultSerializer.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $dataValueSerializer
24 24
 	 */
25
-	public function __construct( Serializer $dataValueSerializer ) {
25
+	public function __construct(Serializer $dataValueSerializer) {
26 26
 		$this->dataValueSerializer = $dataValueSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ComparisonResult;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ComparisonResult $comparisonResult ) {
59
+	private function getSerialized(ComparisonResult $comparisonResult) {
60 60
 		$dataValueSerializer = $this->dataValueSerializer;
61 61
 		$externalValues = array_map(
62
-			function ( $dataValue ) use ( $dataValueSerializer ) {
63
-				return $dataValueSerializer->serialize( $dataValue );
62
+			function($dataValue) use ($dataValueSerializer) {
63
+				return $dataValueSerializer->serialize($dataValue);
64 64
 			},
65 65
 			$comparisonResult->getExternalValues()
66 66
 		);
67
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
67
+		$this->setIndexedTagName($externalValues, 'dataValue');
68 68
 
69 69
 		return array(
70
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
70
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
71 71
 			'externalValues' => $externalValues,
72 72
 			'result' => $comparisonResult->getStatus()
73 73
 		);
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultListSerializer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $crossCheckResultSerializer
24 24
 	 */
25
-	public function __construct( Serializer $crossCheckResultSerializer ) {
25
+	public function __construct(Serializer $crossCheckResultSerializer) {
26 26
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof CrossCheckResultList;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( CrossCheckResultList $resultList ) {
59
+	private function getSerialized(CrossCheckResultList $resultList) {
60 60
 		$serialization = array();
61
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
61
+		$this->setKeyAttributeName($serialization, 'property', 'id');
62 62
 
63
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
63
+		foreach ($resultList->getPropertyIds() as $propertyId) {
64 64
 			$id = $propertyId->getSerialization();
65 65
 			$resultSerialization = array();
66 66
 
67
-			$this->setIndexedTagName( $resultSerialization, 'result' );
67
+			$this->setIndexedTagName($resultSerialization, 'result');
68 68
 
69
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
70
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
69
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
70
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
71 71
 			}
72 72
 
73 73
 			$serialization[$id] = $resultSerialization;
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultSerializer.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * @param Serializer $comparisonResultSerializer
35 35
 	 * @param Serializer $referenceResultSerializer
36 36
 	 */
37
-	public function __construct( Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer ) {
37
+	public function __construct(Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer) {
38 38
 		$this->dumpMetaInformationSerializer = $dumpMetaInformationSerializer;
39 39
 		$this->comparisonResultSerializer = $comparisonResultSerializer;
40 40
 		$this->referenceResultSerializer = $referenceResultSerializer;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	 *
48 48
 	 * @return bool
49 49
 	 */
50
-	public function isSerializerFor( $object ) {
50
+	public function isSerializerFor($object) {
51 51
 		return $object instanceof CrossCheckResult;
52 52
 	}
53 53
 
@@ -59,25 +59,25 @@  discard block
 block discarded – undo
59 59
 	 * @return array
60 60
 	 * @throws UnsupportedObjectException
61 61
 	 */
62
-	public function serialize( $object ) {
63
-		if ( !$this->isSerializerFor( $object ) ) {
62
+	public function serialize($object) {
63
+		if (!$this->isSerializerFor($object)) {
64 64
 			throw new UnsupportedObjectException(
65 65
 				$object,
66 66
 				'CrossCheckResultSerializer can only serialize CrossCheckResult objects.'
67 67
 			);
68 68
 		}
69 69
 
70
-		return $this->getSerialized( $object );
70
+		return $this->getSerialized($object);
71 71
 	}
72 72
 
73
-	private function getSerialized( CrossCheckResult $crossCheckResult ) {
73
+	private function getSerialized(CrossCheckResult $crossCheckResult) {
74 74
 		return array(
75 75
 			'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(),
76 76
 			'claimGuid' => $crossCheckResult->getClaimGuid(),
77 77
 			'externalId' => $crossCheckResult->getExternalId(),
78
-			'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ),
79
-			'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ),
80
-			'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() )
78
+			'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()),
79
+			'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()),
80
+			'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult())
81 81
 		);
82 82
 	}
83 83
 
Please login to merge, or discard this patch.
includes/Serializer/IndexedTagsSerializer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@  discard block
 block discarded – undo
20 20
 	 * @param array &$arr
21 21
 	 * @param string $tag
22 22
 	 */
23
-	protected function setIndexedTagName( array &$arr, $tag ) {
24
-		ApiResult::setIndexedTagName( $arr, $tag );
23
+	protected function setIndexedTagName(array &$arr, $tag) {
24
+		ApiResult::setIndexedTagName($arr, $tag);
25 25
 	}
26 26
 
27 27
 	/**
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
 	 * @param string $tagName
34 34
 	 * @param string $idAttribute
35 35
 	 */
36
-	protected function setKeyAttributeName( array &$arr, $tagName, $idAttribute ) {
37
-		ApiResult::setArrayType( $arr, 'kvp', $idAttribute );
38
-		ApiResult::setIndexedTagName( $arr, $tagName );
36
+	protected function setKeyAttributeName(array &$arr, $tagName, $idAttribute) {
37
+		ApiResult::setArrayType($arr, 'kvp', $idAttribute);
38
+		ApiResult::setIndexedTagName($arr, $tagName);
39 39
 	}
40 40
 
41 41
 }
Please login to merge, or discard this patch.
includes/Serializer/ReferenceResultSerializer.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $referenceSerializer
24 24
 	 */
25
-	public function __construct( Serializer $referenceSerializer ) {
25
+	public function __construct(Serializer $referenceSerializer) {
26 26
 		$this->referenceSerializer = $referenceSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ReferenceResult;
38 38
 	}
39 39
 
@@ -45,20 +45,20 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ReferenceResult $referenceResult ) {
59
+	private function getSerialized(ReferenceResult $referenceResult) {
60 60
 		return array(
61
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
61
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
62 62
 			'status' => $referenceResult->getStatus()
63 63
 		);
64 64
 	}
Please login to merge, or discard this patch.
includes/Serializer/SerializerFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 * @param Serializer $dataValueSerializer
26 26
 	 * @param Serializer $referenceSerializer
27 27
 	 */
28
-	public function __construct( Serializer $dataValueSerializer, Serializer $referenceSerializer ) {
28
+	public function __construct(Serializer $dataValueSerializer, Serializer $referenceSerializer) {
29 29
 		$this->dataValueSerializer = $dataValueSerializer;
30 30
 		$this->referenceSerializer = $referenceSerializer;
31 31
 	}
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	 * @return Serializer
48 48
 	 */
49 49
 	public function newComparisonResultSerializer() {
50
-		return new ComparisonResultSerializer( $this->dataValueSerializer );
50
+		return new ComparisonResultSerializer($this->dataValueSerializer);
51 51
 	}
52 52
 
53 53
 	/**
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	 * @return Serializer
79 79
 	 */
80 80
 	public function newReferenceResultSerializer() {
81
-		return new ReferenceResultSerializer( $this->referenceSerializer );
81
+		return new ReferenceResultSerializer($this->referenceSerializer);
82 82
 	}
83 83
 
84 84
 }
Please login to merge, or discard this patch.
includes/UpdateExternalData/CsvImportSettings.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -43,11 +43,11 @@
 block discarded – undo
43 43
 	 * @param int $batchSize
44 44
 	 * @param bool $quiet
45 45
 	 */
46
-	public function __construct( $externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false ) {
47
-		Assert::parameterType( 'string', $externalValuesFilePath, '$externalValuesFilePath' );
48
-		Assert::parameterType( 'string', $dumpInformationFilePath, '$dumpInformationFilePath' );
49
-		Assert::parameterType( 'integer', $batchSize, '$batchSize' );
50
-		Assert::parameterType( 'boolean', $quiet, '$quiet' );
46
+	public function __construct($externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false) {
47
+		Assert::parameterType('string', $externalValuesFilePath, '$externalValuesFilePath');
48
+		Assert::parameterType('string', $dumpInformationFilePath, '$dumpInformationFilePath');
49
+		Assert::parameterType('integer', $batchSize, '$batchSize');
50
+		Assert::parameterType('boolean', $quiet, '$quiet');
51 51
 
52 52
 		$this->externalValuesFilePath = $externalValuesFilePath;
53 53
 		$this->dumpInformationFilePath = $dumpInformationFilePath;
Please login to merge, or discard this patch.
includes/UpdateExternalData/ExternalDataImporter.php 1 patch
Spacing   +41 added lines, -41 removed lines patch added patch discarded remove patch
@@ -51,13 +51,13 @@  discard block
 block discarded – undo
51 51
 	public function import() {
52 52
 		$dumpIds = $this->insertMetaInformation();
53 53
 
54
-		$this->log( "\nDelete old database entries...\n" );
54
+		$this->log("\nDelete old database entries...\n");
55 55
 
56
-		foreach ( $dumpIds as $dumpId ) {
57
-			$this->externalDataRepo->deleteOfDump( $dumpId, $this->importSettings->getBatchSize() );
56
+		foreach ($dumpIds as $dumpId) {
57
+			$this->externalDataRepo->deleteOfDump($dumpId, $this->importSettings->getBatchSize());
58 58
 		}
59 59
 
60
-		$this->log( "\n" );
60
+		$this->log("\n");
61 61
 
62 62
 		$this->insertExternalValues();
63 63
 	}
@@ -68,54 +68,54 @@  discard block
 block discarded – undo
68 68
 	 * @return array
69 69
 	 */
70 70
 	protected function insertMetaInformation() {
71
-		$this->log( "Insert new dump meta information\n" );
71
+		$this->log("Insert new dump meta information\n");
72 72
 
73
-		$csvFile = fopen( $this->importSettings->getDumpInformationFilePath(), 'rb' );
74
-		if( !$csvFile ) {
75
-			exit( 'Error while reading CSV file.' );
73
+		$csvFile = fopen($this->importSettings->getDumpInformationFilePath(), 'rb');
74
+		if (!$csvFile) {
75
+			exit('Error while reading CSV file.');
76 76
 		}
77 77
 
78 78
 		$i = 0;
79 79
 		$dumpIds = array();
80
-		while ( $data = fgetcsv( $csvFile ) ) {
80
+		while ($data = fgetcsv($csvFile)) {
81 81
 			$identifierPropertyIds = array_map(
82
-				function ( $propertyId ) {
83
-					return new PropertyId( $propertyId );
82
+				function($propertyId) {
83
+					return new PropertyId($propertyId);
84 84
 				},
85
-				json_decode( $data[2] )
85
+				json_decode($data[2])
86 86
 			);
87 87
 			try {
88 88
 				$dumpMetaInformation = new DumpMetaInformation(
89 89
 					$data[0],
90
-					new ItemId( $data[1] ),
90
+					new ItemId($data[1]),
91 91
 					$identifierPropertyIds,
92 92
 					$data[3],
93 93
 					$data[4],
94 94
 					$data[5],
95
-					intval( $data[6] ),
96
-					new ItemId( $data[7] )
95
+					intval($data[6]),
96
+					new ItemId($data[7])
97 97
 				);
98 98
 			}
99
-			catch( \InvalidArgumentException $e ) {
100
-				exit( 'Input file has bad formatted values.' );
99
+			catch (\InvalidArgumentException $e) {
100
+				exit('Input file has bad formatted values.');
101 101
 			}
102 102
 			$dumpIds[] = $dumpMetaInformation->getDumpId();
103 103
 
104 104
 			try {
105
-				$this->dumpMetaInformationStore->save( $dumpMetaInformation );
105
+				$this->dumpMetaInformationStore->save($dumpMetaInformation);
106 106
 			}
107
-			catch( \DBError $e ) {
108
-				exit( 'Unknown database error occurred.' );
107
+			catch (\DBError $e) {
108
+				exit('Unknown database error occurred.');
109 109
 			}
110 110
 
111 111
 			$i++;
112
-			$this->log( "\r\033[K" );
113
-			$this->log( "$i rows inserted or updated" );
112
+			$this->log("\r\033[K");
113
+			$this->log("$i rows inserted or updated");
114 114
 		}
115 115
 
116
-		fclose( $csvFile );
116
+		fclose($csvFile);
117 117
 
118
-		$this->log( "\n" );
118
+		$this->log("\n");
119 119
 
120 120
 		return $dumpIds;
121 121
 	}
@@ -124,32 +124,32 @@  discard block
 block discarded – undo
124 124
 	 * Inserts external values stored in csv file into database
125 125
 	 */
126 126
 	private function insertExternalValues() {
127
-		$this->log( "Insert new data values\n" );
127
+		$this->log("Insert new data values\n");
128 128
 
129
-		$csvFile = fopen( $this->importSettings->getExternalValuesFilePath(), 'rb' );
130
-		if( !$csvFile ) {
131
-			exit( 'Error while reading CSV file.' );
129
+		$csvFile = fopen($this->importSettings->getExternalValuesFilePath(), 'rb');
130
+		if (!$csvFile) {
131
+			exit('Error while reading CSV file.');
132 132
 		}
133 133
 
134 134
 		$i = 0;
135 135
 		$accumulator = array();
136
-		while ( true ) {
137
-			$data = fgetcsv( $csvFile );
138
-			if ( $data === false || ++$i % $this->importSettings->getBatchSize() === 0 ) {
136
+		while (true) {
137
+			$data = fgetcsv($csvFile);
138
+			if ($data === false || ++$i % $this->importSettings->getBatchSize() === 0) {
139 139
 				try {
140
-					$this->externalDataRepo->insertBatch( $accumulator );
140
+					$this->externalDataRepo->insertBatch($accumulator);
141 141
 				}
142
-				catch( \DBError $e ) {
143
-					exit( 'Unknown database error occurred.' );
142
+				catch (\DBError $e) {
143
+					exit('Unknown database error occurred.');
144 144
 				}
145 145
 				wfWaitForSlaves();
146 146
 
147
-				$this->log( "\r\033[K" );
148
-				$this->log( "$i rows inserted" );
147
+				$this->log("\r\033[K");
148
+				$this->log("$i rows inserted");
149 149
 
150 150
 				$accumulator = array();
151 151
 
152
-				if ( $data === false ) {
152
+				if ($data === false) {
153 153
 					break;
154 154
 				}
155 155
 			}
@@ -157,16 +157,16 @@  discard block
 block discarded – undo
157 157
 			$accumulator[] = $data;
158 158
 		}
159 159
 
160
-		fclose( $csvFile );
160
+		fclose($csvFile);
161 161
 
162
-		$this->log( "\n" );
162
+		$this->log("\n");
163 163
 	}
164 164
 
165 165
 	/**
166 166
 	 * @param string $text
167 167
 	 */
168
-	private function log( $text ) {
169
-		if ( !$this->importSettings->isQuiet() ) {
168
+	private function log($text) {
169
+		if (!$this->importSettings->isQuiet()) {
170 170
 			print $text;
171 171
 		}
172 172
 	}
Please login to merge, or discard this patch.
includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -28,14 +28,14 @@  discard block
 block discarded – undo
28 28
 	 * @return DumpMetaInformation
29 29
 	 * @throws InvalidArgumentException
30 30
 	 */
31
-	public function getWithId( $dumpId ) {
32
-		if ( !is_string( $dumpId ) ) {
33
-			throw new InvalidArgumentException( '$dumpId must be string.' );
31
+	public function getWithId($dumpId) {
32
+		if (!is_string($dumpId)) {
33
+			throw new InvalidArgumentException('$dumpId must be string.');
34 34
 		}
35 35
 
36
-		$dumpMetaInformation = $this->getWithIds( array( $dumpId ) );
36
+		$dumpMetaInformation = $this->getWithIds(array($dumpId));
37 37
 
38
-		return reset( $dumpMetaInformation );
38
+		return reset($dumpMetaInformation);
39 39
 	}
40 40
 
41 41
 	/**
@@ -46,15 +46,15 @@  discard block
 block discarded – undo
46 46
 	 * @return DumpMetaInformation[]
47 47
 	 * @throws InvalidArgumentException
48 48
 	 */
49
-	public function getWithIds( array $dumpIds ) {
50
-		foreach ( $dumpIds as $dumpId ) {
51
-			if ( !is_string( $dumpId ) ) {
52
-				throw new InvalidArgumentException( '$dumpIds must contain only strings.' );
49
+	public function getWithIds(array $dumpIds) {
50
+		foreach ($dumpIds as $dumpId) {
51
+			if (!is_string($dumpId)) {
52
+				throw new InvalidArgumentException('$dumpIds must contain only strings.');
53 53
 			}
54 54
 		}
55 55
 
56
-		if( count( $dumpIds ) > 0 ) {
57
-			$db = wfGetDB( DB_SLAVE );
56
+		if (count($dumpIds) > 0) {
57
+			$db = wfGetDB(DB_SLAVE);
58 58
 			$result = $db->select(
59 59
 				array(
60 60
 					self::META_TABLE_NAME,
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 				)
75 75
 			);
76 76
 
77
-			return $this->buildDumpMetaInformationFromResult( $result );
77
+			return $this->buildDumpMetaInformationFromResult($result);
78 78
 		}
79 79
 
80 80
 		return array();
@@ -89,17 +89,17 @@  discard block
 block discarded – undo
89 89
 	 * @throws InvalidArgumentException
90 90
 	 * @return DumpMetaInformation[]
91 91
 	 */
92
-	public function getWithIdentifierProperties( array $identifierPropertyIds ) {
93
-		foreach ( $identifierPropertyIds as $propertyId ) {
94
-			if ( !( $propertyId instanceof PropertyId ) ) {
95
-				throw new InvalidArgumentException( '$identifierProperties must contain only PropertyIds.' );
92
+	public function getWithIdentifierProperties(array $identifierPropertyIds) {
93
+		foreach ($identifierPropertyIds as $propertyId) {
94
+			if (!($propertyId instanceof PropertyId)) {
95
+				throw new InvalidArgumentException('$identifierProperties must contain only PropertyIds.');
96 96
 			}
97 97
 		}
98 98
 
99
-		if( count( $identifierPropertyIds ) > 0 ) {
100
-			$db = wfGetDB( DB_SLAVE );
99
+		if (count($identifierPropertyIds) > 0) {
100
+			$db = wfGetDB(DB_SLAVE);
101 101
 			$identifierPropertyIds = array_map(
102
-				function( PropertyId $id ) {
102
+				function(PropertyId $id) {
103 103
 					return $id->getSerialization();
104 104
 				},
105 105
 				$identifierPropertyIds
@@ -112,13 +112,13 @@  discard block
 block discarded – undo
112 112
 				)
113 113
 			);
114 114
 			$dumpIds = array();
115
-			foreach ( $result as $row ) {
116
-				if ( !in_array( $row->dump_id, $dumpIds ) ) {
115
+			foreach ($result as $row) {
116
+				if (!in_array($row->dump_id, $dumpIds)) {
117 117
 					$dumpIds[] = $row->dump_id;
118 118
 				}
119 119
 			}
120 120
 
121
-			return $this->getWithIds( $dumpIds );
121
+			return $this->getWithIds($dumpIds);
122 122
 		}
123 123
 
124 124
 		return array();
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 	 * @return ItemId[]
131 131
 	 */
132 132
 	public function getSourceItemIds() {
133
-		$db = wfGetDB( DB_SLAVE );
133
+		$db = wfGetDB(DB_SLAVE);
134 134
 		$result = $db->selectFieldValues(
135 135
 			self::META_TABLE_NAME,
136 136
 			'source_qid',
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 	 * @return DumpMetaInformation[]
156 156
 	 */
157 157
 	public function getAll() {
158
-		$db = wfGetDB( DB_SLAVE );
158
+		$db = wfGetDB(DB_SLAVE);
159 159
 		$result = $db->select(
160 160
 			array(
161 161
 				self::META_TABLE_NAME,
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 			)
174 174
 		);
175 175
 
176
-		return $this->buildDumpMetaInformationFromResult( $result );
176
+		return $this->buildDumpMetaInformationFromResult($result);
177 177
 	}
178 178
 
179 179
 	/**
@@ -181,34 +181,34 @@  discard block
 block discarded – undo
181 181
 	 * @return null|array
182 182
 	 * @throws UnexpectedValueException
183 183
 	 */
184
-	private function buildDumpMetaInformationFromResult( ResultWrapper $result ) {
184
+	private function buildDumpMetaInformationFromResult(ResultWrapper $result) {
185 185
 		$aggregatedRows = array();
186
-		foreach ( $result as $row ) {
187
-			if ( array_key_exists( $row->id, $aggregatedRows ) ) {
188
-				$propertyId = new PropertyId( $row->identifier_pid );
186
+		foreach ($result as $row) {
187
+			if (array_key_exists($row->id, $aggregatedRows)) {
188
+				$propertyId = new PropertyId($row->identifier_pid);
189 189
 				$aggregatedRows[$row->id]->identifier_pid[] = $propertyId;
190 190
 			} else {
191
-				if ( $row->identifier_pid !== null ) {
192
-					$propertyId = new PropertyId( $row->identifier_pid );
193
-					$row->identifier_pid = array( $propertyId );
191
+				if ($row->identifier_pid !== null) {
192
+					$propertyId = new PropertyId($row->identifier_pid);
193
+					$row->identifier_pid = array($propertyId);
194 194
 				}
195 195
 				$aggregatedRows[$row->id] = $row;
196 196
 			}
197 197
 		}
198 198
 
199 199
 		$dumpMetaInformation = array();
200
-		foreach ( $aggregatedRows as $row ) {
200
+		foreach ($aggregatedRows as $row) {
201 201
 			$dumpId = $row->id;
202
-			$sourceItemId = new ItemId( $row->source_qid );
203
-			$importDate = wfTimestamp( TS_MW, $row->import_date );
202
+			$sourceItemId = new ItemId($row->source_qid);
203
+			$importDate = wfTimestamp(TS_MW, $row->import_date);
204 204
 			$language = $row->language;
205 205
 			$sourceUrl = $row->source_url;
206 206
 			$size = (int)$row->size;
207
-			$licenseItemId = new ItemId( $row->license_qid );
207
+			$licenseItemId = new ItemId($row->license_qid);
208 208
 			$identifierPropertyIds = $row->identifier_pid;
209 209
 
210 210
 			$dumpMetaInformation[$row->dump_id] =
211
-				new DumpMetaInformation( $dumpId,
211
+				new DumpMetaInformation($dumpId,
212 212
 					$sourceItemId,
213 213
 					$identifierPropertyIds,
214 214
 					$importDate,
@@ -227,22 +227,22 @@  discard block
 block discarded – undo
227 227
 	 *
228 228
 	 * @param DumpMetaInformation $dumpMetaInformation
229 229
 	 */
230
-	public function save( DumpMetaInformation $dumpMetaInformation ) {
231
-		$db = wfGetDB( DB_SLAVE );
230
+	public function save(DumpMetaInformation $dumpMetaInformation) {
231
+		$db = wfGetDB(DB_SLAVE);
232 232
 		$dumpId = $dumpMetaInformation->getDumpId();
233
-		$accumulator = $this->getDumpInformationFields( $db, $dumpMetaInformation );
233
+		$accumulator = $this->getDumpInformationFields($db, $dumpMetaInformation);
234 234
 
235 235
 		$existing = $db->selectRow(
236 236
 			self::META_TABLE_NAME,
237
-			array( 'id' ),
238
-			array( 'id' => $dumpId )
237
+			array('id'),
238
+			array('id' => $dumpId)
239 239
 		);
240 240
 
241
-		if ( $existing ) {
241
+		if ($existing) {
242 242
 			$db->update(
243 243
 				self::META_TABLE_NAME,
244 244
 				$accumulator,
245
-				array( 'id' => $dumpId )
245
+				array('id' => $dumpId)
246 246
 			);
247 247
 		} else {
248 248
 			$db->insert(
@@ -253,12 +253,12 @@  discard block
 block discarded – undo
253 253
 
254 254
 		$db->delete(
255 255
 			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
256
-			array( 'dump_id' => $dumpId )
256
+			array('dump_id' => $dumpId)
257 257
 		);
258 258
 		$db->insert(
259 259
 			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
260 260
 			array_map(
261
-				function ( PropertyId $identifierPropertyId ) use ( $dumpId ) {
261
+				function(PropertyId $identifierPropertyId) use ($dumpId) {
262 262
 					return array(
263 263
 						'dump_id' => $dumpId,
264 264
 						'identifier_pid' => $identifierPropertyId->getSerialization()
@@ -273,11 +273,11 @@  discard block
 block discarded – undo
273 273
 	 * @param DumpMetaInformation $dumpMetaInformation *
274 274
 	 * @return array
275 275
 	 */
276
-	private function getDumpInformationFields( DatabaseBase $db,  DumpMetaInformation $dumpMetaInformation ) {
276
+	private function getDumpInformationFields(DatabaseBase $db, DumpMetaInformation $dumpMetaInformation) {
277 277
 		return array(
278 278
 			'id' => $dumpMetaInformation->getDumpId(),
279 279
 			'source_qid' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
280
-			'import_date' => $db->timestamp( $dumpMetaInformation->getImportDate() ),
280
+			'import_date' => $db->timestamp($dumpMetaInformation->getImportDate()),
281 281
 			'language' => $dumpMetaInformation->getLanguageCode(),
282 282
 			'source_url' => $dumpMetaInformation->getSourceUrl(),
283 283
 			'size' => $dumpMetaInformation->getSize(),
Please login to merge, or discard this patch.