wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

api/RunCrossCheck.php

Doc Comments +1 added lines, -1 removed lines

@@ -162,7 +162,7 @@
 	/**
 	 * Writes output for CrossCheckResultList
 	 *
-	 * @param array $resultLists
+	 * @param \WikibaseQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultList[] $resultLists
 	 *
 	 * @return array
 	 */

includes/CrossCheck/CrossCheckInteractor.php

Doc Comments +1 added lines, -1 removed lines

@@ -288,7 +288,7 @@
 	}
 
 	/**
-	 * @param array $strings
+	 * @param string[] $strings
 	 * @param string $parameterName
 	 *
 	 * @throws InvalidArgumentException

includes/CrossCheck/CrossChecker.php

Braces +2 added lines, -4 removed lines

@@ -283,8 +283,7 @@ 
 				$result = ComparisonResult::STATUS_MISMATCH;
 				if( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
 					$result = ComparisonResult::STATUS_MATCH;
-				}
-				elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
+				} elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 				}
 
@@ -314,8 +313,7 @@ 
 				if( $parsedValue ) {
 					$parsedValues[] = $parsedValue;
 				}
-			}
-			catch( ParseException $e ) {}
+			} catch( ParseException $e ) {}
 		}
 
 		return $parsedValues;

includes/ExternalDataRepo.php

Braces +1 added lines, -2 removed lines

@@ -102,8 +102,7 @@
 			$db->begin();
 			$result = $db->insert( self::TABLE_NAME, $accumulator );
 			$db->commit();
-		}
-		catch( DBError $ex ) {
+		} catch( DBError $ex ) {
 			$db->rollback();
 			throw $ex;
 		}

specials/SpecialCrossCheck.php

Doc Comments +2 added lines, -2 removed lines

@@ -306,7 +306,7 @@ 
 	/**
 	 * Builds summary from given results
 	 *
-	 * @param CrossCheckResult[]|CrossCheckResultList $results
+	 * @param CrossCheckResultList $results
 	 *
 	 * @return string HTML
 	 */
@@ -396,7 +396,7 @@ 
 	}
 
 	/**
-	 * @param CrossCheckResult[]|CrossCheckResultList $results
+	 * @param CrossCheckResultList $results
 	 *
 	 * @return string HTML
 	 */

includes/UpdateExternalData/ExternalDataImporter.php

Braces +3 added lines, -6 removed lines

@@ -95,16 +95,14 @@ 
 					intval( $data[6] ),
 					new ItemId( $data[7] )
 				);
-			}
-			catch( \InvalidArgumentException $e ) {
+			} catch( \InvalidArgumentException $e ) {
 				exit( 'Input file has bad formatted values.' );
 			}
 			$dumpIds[] = $dumpMetaInformation->getDumpId();
 
 			try {
 				$this->dumpMetaInformationStore->save( $dumpMetaInformation );
-			}
-			catch( \DBError $e ) {
+			} catch( \DBError $e ) {
 				exit( 'Unknown database error occurred.' );
 			}
 
@@ -138,8 +136,7 @@ 
 			if ( $data === false || ++$i % $this->importSettings->getBatchSize() === 0 ) {
 				try {
 					$this->externalDataRepo->insertBatch( $accumulator );
-				}
-				catch( \DBError $e ) {
+				} catch( \DBError $e ) {
 					exit( 'Unknown database error occurred.' );
 				}
 				wfGetLBFactory()->waitForReplication();