wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/Serializer/CrossCheckResultListSerializer.php

Spacing +11 added lines, -11 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param Serializer $crossCheckResultSerializer
 	 */
-	public function __construct( Serializer $crossCheckResultSerializer ) {
+	public function __construct(Serializer $crossCheckResultSerializer) {
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
 	}
 
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResultList;
 	}
 
@@ -45,29 +45,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResultList $resultList ) {
+	private function getSerialized(CrossCheckResultList $resultList) {
 		$serialization = array();
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
+		$this->setKeyAttributeName($serialization, 'property', 'id');
 
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
+		foreach ($resultList->getPropertyIds() as $propertyId) {
 			$id = $propertyId->getSerialization();
 			$resultSerialization = array();
 
-			$this->setIndexedTagName( $resultSerialization, 'result' );
+			$this->setIndexedTagName($resultSerialization, 'result');
 
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
 			}
 
 			$serialization[$id] = $resultSerialization;

includes/Serializer/IndexedTagsSerializer.php

Spacing +5 added lines, -5 removed lines

@@ -20,8 +20,8 @@ 
 	 * @param array &$arr
 	 * @param string $tag
 	 */
-	protected function setIndexedTagName( array &$arr, $tag ) {
-		ApiResult::setIndexedTagName( $arr, $tag );
+	protected function setIndexedTagName(array &$arr, $tag) {
+		ApiResult::setIndexedTagName($arr, $tag);
 	}
 
 	/**
@@ -33,9 +33,9 @@ 
 	 * @param string $tagName
 	 * @param string $idAttribute
 	 */
-	protected function setKeyAttributeName( array &$arr, $tagName, $idAttribute ) {
-		ApiResult::setArrayType( $arr, 'kvp', $idAttribute );
-		ApiResult::setIndexedTagName( $arr, $tagName );
+	protected function setKeyAttributeName(array &$arr, $tagName, $idAttribute) {
+		ApiResult::setArrayType($arr, 'kvp', $idAttribute);
+		ApiResult::setIndexedTagName($arr, $tagName);
 	}
 
 }

includes/Serializer/ReferenceResultSerializer.php

Spacing +7 added lines, -7 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param Serializer $referenceSerializer
 	 */
-	public function __construct( Serializer $referenceSerializer ) {
+	public function __construct(Serializer $referenceSerializer) {
 		$this->referenceSerializer = $referenceSerializer;
 	}
 
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ReferenceResult;
 	}
 
@@ -45,20 +45,20 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ReferenceResult $referenceResult ) {
+	private function getSerialized(ReferenceResult $referenceResult) {
 		return array(
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
 			'status' => $referenceResult->getStatus()
 		);
 	}

includes/Serializer/SerializerFactory.php

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
 	 * @param Serializer $dataValueSerializer
 	 * @param Serializer $referenceSerializer
 	 */
-	public function __construct( Serializer $dataValueSerializer, Serializer $referenceSerializer ) {
+	public function __construct(Serializer $dataValueSerializer, Serializer $referenceSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 		$this->referenceSerializer = $referenceSerializer;
 	}
@@ -47,7 +47,7 @@ 
 	 * @return Serializer
 	 */
 	public function newComparisonResultSerializer() {
-		return new ComparisonResultSerializer( $this->dataValueSerializer );
+		return new ComparisonResultSerializer($this->dataValueSerializer);
 	}
 
 	/**
@@ -78,7 +78,7 @@ 
 	 * @return Serializer
 	 */
 	public function newReferenceResultSerializer() {
-		return new ReferenceResultSerializer( $this->referenceSerializer );
+		return new ReferenceResultSerializer($this->referenceSerializer);
 	}
 
 }

includes/UpdateExternalData/CsvImportSettings.php

Spacing +5 added lines, -5 removed lines

@@ -43,11 +43,11 @@
 	 * @param int $batchSize
 	 * @param bool $quiet
 	 */
-	public function __construct( $externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false ) {
-		Assert::parameterType( 'string', $externalValuesFilePath, '$externalValuesFilePath' );
-		Assert::parameterType( 'string', $dumpInformationFilePath, '$dumpInformationFilePath' );
-		Assert::parameterType( 'integer', $batchSize, '$batchSize' );
-		Assert::parameterType( 'boolean', $quiet, '$quiet' );
+	public function __construct($externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false) {
+		Assert::parameterType('string', $externalValuesFilePath, '$externalValuesFilePath');
+		Assert::parameterType('string', $dumpInformationFilePath, '$dumpInformationFilePath');
+		Assert::parameterType('integer', $batchSize, '$batchSize');
+		Assert::parameterType('boolean', $quiet, '$quiet');
 
 		$this->externalValuesFilePath = $externalValuesFilePath;
 		$this->dumpInformationFilePath = $dumpInformationFilePath;

includes/Serializer/DumpMetaInformationSerializer.php

Spacing +8 added lines, -8 removed lines

@@ -21,7 +21,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof DumpMetaInformation;
 	}
 
@@ -33,32 +33,32 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'DumpMetaInformationSerializer can only serialize DumpMetaInformation objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( DumpMetaInformation $dumpMetaInformation ) {
+	private function getSerialized(DumpMetaInformation $dumpMetaInformation) {
 		$identifierPropertyIds = array_map(
-			function( PropertyId $id ) {
+			function(PropertyId $id) {
 				return $id->getSerialization();
 			},
 			$dumpMetaInformation->getIdentifierPropertyIds()
 		);
 
-		$this->setIndexedTagName( $identifierPropertyIds, 'propertyId' );
+		$this->setIndexedTagName($identifierPropertyIds, 'propertyId');
 
 		return array(
 			'dumpId' => $dumpMetaInformation->getDumpId(),
 			'sourceItemId' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
 			'identifierPropertyIds' => $identifierPropertyIds,
-			'importDate' => wfTimestamp( TS_ISO_8601, $dumpMetaInformation->getImportDate() ),
+			'importDate' => wfTimestamp(TS_ISO_8601, $dumpMetaInformation->getImportDate()),
 			'language' => $dumpMetaInformation->getLanguageCode(),
 			'sourceUrl' => $dumpMetaInformation->getSourceUrl(),
 			'size' => $dumpMetaInformation->getSize(),

specials/SpecialCrossCheck.php

Doc Comments +2 added lines, -2 removed lines

@@ -306,7 +306,7 @@ 
 	/**
 	 * Builds summary from given results
 	 *
-	 * @param CrossCheckResult[]|CrossCheckResultList $results
+	 * @param CrossCheckResultList $results
 	 *
 	 * @return string HTML
 	 */
@@ -396,7 +396,7 @@ 
 	}
 
 	/**
-	 * @param CrossCheckResult[]|CrossCheckResultList $results
+	 * @param CrossCheckResultList $results
 	 *
 	 * @return string HTML
 	 */

Spacing +100 added lines, -100 removed lines

@@ -103,18 +103,18 @@ 
 		OutputFormatValueFormatterFactory $valueFormatterFactory,
 		CrossCheckInteractor $crossCheckInteractor
 	) {
-		parent::__construct( 'CrossCheck' );
+		parent::__construct('CrossCheck');
 
 		$this->entityLookup = $entityLookup;
 		$this->entityIdParser = $entityIdParser;
 
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $this->getLanguage()->getCode() );
-		$this->dataValueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $this->getLanguage()->getCode());
+		$this->dataValueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
 
-		$labelLookup = new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() );
-		$this->entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $labelLookup );
-		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $labelLookup );
+		$labelLookup = new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode());
+		$this->entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($labelLookup);
+		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($labelLookup);
 
 		$this->crossCheckInteractor = $crossCheckInteractor;
 	}
@@ -134,7 +134,7 @@ 
 	 * @return string (plain text)
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqev-crosscheck' )->text();
+		return $this->msg('wbqev-crosscheck')->text();
 	}
 
 	/**
@@ -146,55 +146,55 @@ 
 	 * @throws EntityIdParsingException
 	 * @throws UnexpectedValueException
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
-		if ( $postRequest ) {
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
+		if ($postRequest) {
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
 			return;
 		}
 
-		$out->addModules( 'SpecialCrossCheckPage' );
+		$out->addModules('SpecialCrossCheckPage');
 
 		$this->setHeaders();
 
-		$out->addHTML( $this->buildInfoBox() );
+		$out->addHTML($this->buildInfoBox());
 		$this->buildEntityIdForm();
 
-		if ( $subPage ) {
-			$this->buildResult( $subPage );
+		if ($subPage) {
+			$this->buildResult($subPage);
 		}
 	}
 
 	/**
 	 * @param string $idSerialization
 	 */
-	private function buildResult( $idSerialization ) {
+	private function buildResult($idSerialization) {
 		$out = $this->getOutput();
 
 		try {
-			$entityId = $this->entityIdParser->parse( $idSerialization );
-		} catch ( EntityIdParsingException $ex ) {
-			$out->addHTML( $this->buildNotice( 'wbqev-crosscheck-invalid-entity-id', true ) );
+			$entityId = $this->entityIdParser->parse($idSerialization);
+		} catch (EntityIdParsingException $ex) {
+			$out->addHTML($this->buildNotice('wbqev-crosscheck-invalid-entity-id', true));
 			return;
 		}
 
-		$out->addHTML( $this->buildResultHeader( $entityId ) );
+		$out->addHTML($this->buildResultHeader($entityId));
 
-		$entity = $this->entityLookup->getEntity( $entityId );
-		if ( $entity === null ) {
-			$out->addHTML( $this->buildNotice( 'wbqev-crosscheck-not-existent-entity', true ) );
+		$entity = $this->entityLookup->getEntity($entityId);
+		if ($entity === null) {
+			$out->addHTML($this->buildNotice('wbqev-crosscheck-not-existent-entity', true));
 			return;
 		}
 
-		$results = $this->getCrossCheckResultsFromEntity( $entity );
+		$results = $this->getCrossCheckResultsFromEntity($entity);
 
-		if ( $results === null || $results->toArray() === array() ) {
-			$out->addHTML( $this->buildNotice( 'wbqev-crosscheck-empty-result' ) );
+		if ($results === null || $results->toArray() === array()) {
+			$out->addHTML($this->buildNotice('wbqev-crosscheck-empty-result'));
 		} else {
 			$out->addHTML(
-				$this->buildSummary( $results )
-				. $this->buildResultTable( $results )
+				$this->buildSummary($results)
+				. $this->buildResultTable($results)
 			);
 		}
 	}
@@ -204,9 +204,9 @@ 
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	private function getCrossCheckResultsFromEntity( EntityDocument $entity ) {
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckInteractor->crossCheckStatements( $entity->getStatements() );
+	private function getCrossCheckResultsFromEntity(EntityDocument $entity) {
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckInteractor->crossCheckStatements($entity->getStatements());
 		}
 
 		return null;
@@ -223,15 +223,15 @@ 
 				'name' => 'entityid',
 				'label-message' => 'wbqev-crosscheck-form-entityid-label',
 				'cssclass' => 'wbqev-crosscheck-form-entity-id',
-				'placeholder' => $this->msg( 'wbqev-crosscheck-form-entityid-placeholder' )->escaped()
+				'placeholder' => $this->msg('wbqev-crosscheck-form-entityid-placeholder')->escaped()
 			)
 		);
-		$htmlForm = new HTMLForm( $formDescriptor, $this->getContext(), 'wbqev-crosscheck-form' );
-		$htmlForm->setSubmitText( $this->msg( 'wbqev-crosscheck-form-submit-label' )->escaped() );
-		$htmlForm->setSubmitCallback( function() {
+		$htmlForm = new HTMLForm($formDescriptor, $this->getContext(), 'wbqev-crosscheck-form');
+		$htmlForm->setSubmitText($this->msg('wbqev-crosscheck-form-submit-label')->escaped());
+		$htmlForm->setSubmitCallback(function() {
 			return false;
 		} );
-		$htmlForm->setMethod( 'post' );
+		$htmlForm->setMethod('post');
 		$htmlForm->show();
 	}
 
@@ -241,18 +241,18 @@ 
 	 * @return string HTML
 	 */
 	private function buildInfoBox() {
-		$externalDbLink = Linker::specialLink( 'ExternalDatabases', 'wbqev-externaldbs' );
+		$externalDbLink = Linker::specialLink('ExternalDatabases', 'wbqev-externaldbs');
 		$infoBox =
 			Html::openElement(
 				'div',
-				array( 'class' => 'wbqev-infobox' )
+				array('class' => 'wbqev-infobox')
 			)
-			. $this->msg( 'wbqev-crosscheck-explanation-general' )->parse()
-			. sprintf( ' %s.', $externalDbLink )
-			. Html::element( 'br' )
-			. Html::element( 'br' )
-			. $this->msg( 'wbqev-crosscheck-explanation-detail' )->parse()
-			. Html::closeElement( 'div' );
+			. $this->msg('wbqev-crosscheck-explanation-general')->parse()
+			. sprintf(' %s.', $externalDbLink)
+			. Html::element('br')
+			. Html::element('br')
+			. $this->msg('wbqev-crosscheck-explanation-detail')->parse()
+			. Html::closeElement('div');
 
 		return $infoBox;
 	}
@@ -267,17 +267,17 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildNotice( $messageKey, $error = false ) {
+	private function buildNotice($messageKey, $error = false) {
 		$cssClasses = 'wbqev-crosscheck-notice';
-		if ( $error ) {
+		if ($error) {
 			$cssClasses .= ' wbqev-crosscheck-notice-error';
 		}
 
 		return
 			Html::element(
 				'p',
-				array( 'class' => $cssClasses ),
-				$this->msg( $messageKey )->text()
+				array('class' => $cssClasses),
+				$this->msg($messageKey)->text()
 			);
 	}
 
@@ -288,18 +288,18 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildResultHeader( EntityId $entityId ) {
+	private function buildResultHeader(EntityId $entityId) {
 		$entityLink = sprintf(
 			'%s (%s)',
-			$this->entityIdLinkFormatter->formatEntityId( $entityId ),
-			htmlspecialchars( $entityId->getSerialization() )
+			$this->entityIdLinkFormatter->formatEntityId($entityId),
+			htmlspecialchars($entityId->getSerialization())
 		);
 
 		return
 			Html::rawElement(
 				'h3',
 				array(),
-				sprintf( '%s %s', $this->msg( 'wbqev-crosscheck-result-headline' )->escaped(), $entityLink )
+				sprintf('%s %s', $this->msg('wbqev-crosscheck-result-headline')->escaped(), $entityLink)
 			);
 	}
 
@@ -310,11 +310,11 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildSummary( $results ) {
+	private function buildSummary($results) {
 		$statuses = array();
-		foreach ( $results as $result ) {
-			$status = strtolower( $result->getComparisonResult()->getStatus() );
-			if ( array_key_exists( $status, $statuses ) ) {
+		foreach ($results as $result) {
+			$status = strtolower($result->getComparisonResult()->getStatus());
+			if (array_key_exists($status, $statuses)) {
 				$statuses[$status]++;
 			} else {
 				$statuses[$status] = 1;
@@ -322,15 +322,15 @@ 
 		}
 
 		$statusElements = array();
-		foreach ( $statuses as $status => $count ) {
-			if ( $count > 0 ) {
-				$statusElements[] = $this->formatStatus( $status ) . ': ' . $count;
+		foreach ($statuses as $status => $count) {
+			if ($count > 0) {
+				$statusElements[] = $this->formatStatus($status).': '.$count;
 			}
 		}
 		$summary =
-			Html::openElement( 'p' )
-			. implode( ', ', $statusElements )
-			. Html::closeElement( 'p' );
+			Html::openElement('p')
+			. implode(', ', $statusElements)
+			. Html::closeElement('p');
 
 		return $summary;
 	}
@@ -344,16 +344,16 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatStatus( $status ) {
-		$messageKey = 'wbqev-crosscheck-status-' . strtolower( $status );
+	private function formatStatus($status) {
+		$messageKey = 'wbqev-crosscheck-status-'.strtolower($status);
 
 		$formattedStatus =
 			Html::element(
 				'span',
-				array (
-					'class' => 'wbqev-status wbqev-status-' . htmlspecialchars( $status )
+				array(
+					'class' => 'wbqev-status wbqev-status-'.htmlspecialchars($status)
 				),
-				$this->msg( $messageKey )->text()
+				$this->msg($messageKey)->text()
 			);
 
 		return $formattedStatus;
@@ -370,29 +370,29 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatDataValues( $dataValues, $linking = true, $separator = null ) {
-		if ( $dataValues instanceof DataValue ) {
-			$dataValues = array( $dataValues );
+	private function formatDataValues($dataValues, $linking = true, $separator = null) {
+		if ($dataValues instanceof DataValue) {
+			$dataValues = array($dataValues);
 		}
 
 		$formattedDataValues = array();
-		foreach ( $dataValues as $dataValue ) {
-			if ( $dataValue instanceof EntityIdValue ) {
-				if ( $linking ) {
-					$formattedDataValues[] = $this->entityIdLinkFormatter->formatEntityId( $dataValue->getEntityId() );
+		foreach ($dataValues as $dataValue) {
+			if ($dataValue instanceof EntityIdValue) {
+				if ($linking) {
+					$formattedDataValues[] = $this->entityIdLinkFormatter->formatEntityId($dataValue->getEntityId());
 				} else {
-					$formattedDataValues[] = $this->entityIdLabelFormatter->formatEntityId( $dataValue->getEntityId() );
+					$formattedDataValues[] = $this->entityIdLabelFormatter->formatEntityId($dataValue->getEntityId());
 				}
 			} else {
-				$formattedDataValues[] = $this->dataValueFormatter->format( $dataValue );
+				$formattedDataValues[] = $this->dataValueFormatter->format($dataValue);
 			}
 		}
 
-		if ( $separator ) {
-			return implode( $separator, $formattedDataValues );
+		if ($separator) {
+			return implode($separator, $formattedDataValues);
 		}
 
-		return $this->getLanguage()->commaList( $formattedDataValues );
+		return $this->getLanguage()->commaList($formattedDataValues);
 	}
 
 	/**
@@ -400,31 +400,31 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildResultTable( $results ) {
+	private function buildResultTable($results) {
 		$table = new HtmlTableBuilder(
 			array(
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqev-crosscheck-result-table-header-status' )->escaped(),
+					$this->msg('wbqev-crosscheck-result-table-header-status')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'datatypes-type-wikibase-property' )->escaped(),
+					$this->msg('datatypes-type-wikibase-property')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqev-crosscheck-result-table-header-local-value' )->escaped()
+					$this->msg('wbqev-crosscheck-result-table-header-local-value')->escaped()
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqev-crosscheck-result-table-header-external-value' )->escaped()
+					$this->msg('wbqev-crosscheck-result-table-header-external-value')->escaped()
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqev-crosscheck-result-table-header-references' )->escaped(),
+					$this->msg('wbqev-crosscheck-result-table-header-references')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
 					Linker::linkKnown(
-						self::getTitleFor( 'ExternalDatabases' ),
-						$this->msg( 'wbqev-crosscheck-result-table-header-external-source' )->escaped()
+						self::getTitleFor('ExternalDatabases'),
+						$this->msg('wbqev-crosscheck-result-table-header-external-source')->escaped()
 					),
 					true,
 					true
@@ -433,28 +433,28 @@ 
 			true
 		);
 
-		foreach ( $results as $result ) {
-			$status = $this->formatStatus( $result->getComparisonResult()->getStatus() );
-			$propertyId = $this->entityIdLinkFormatter->formatEntityId( $result->getPropertyId() );
-			$localValue = $this->formatDataValues( $result->getComparisonResult()->getLocalValue() );
+		foreach ($results as $result) {
+			$status = $this->formatStatus($result->getComparisonResult()->getStatus());
+			$propertyId = $this->entityIdLinkFormatter->formatEntityId($result->getPropertyId());
+			$localValue = $this->formatDataValues($result->getComparisonResult()->getLocalValue());
 			$externalValue = $this->formatDataValues(
 				$result->getComparisonResult()->getExternalValues(),
 				true,
-				Html::element( 'br' )
+				Html::element('br')
 			);
 			$referenceStatus = $this->msg(
-				'wbqev-crosscheck-status-' . $result->getReferenceResult()->getStatus()
+				'wbqev-crosscheck-status-'.$result->getReferenceResult()->getStatus()
 			)->text();
-			$dataSource = $this->entityIdLinkFormatter->formatEntityId( $result->getDumpMetaInformation()->getSourceItemId() );
+			$dataSource = $this->entityIdLinkFormatter->formatEntityId($result->getDumpMetaInformation()->getSourceItemId());
 
 			$table->appendRow(
 				array(
-					new HtmlTableCellBuilder( $status, array(), true ),
-					new HtmlTableCellBuilder( $propertyId, array(), true ),
-					new HtmlTableCellBuilder( $localValue, array(), true ),
-					new HtmlTableCellBuilder( $externalValue, array(), true ),
-					new HtmlTableCellBuilder( $referenceStatus, array() ),
-					new HtmlTableCellBuilder( $dataSource, array(), true )
+					new HtmlTableCellBuilder($status, array(), true),
+					new HtmlTableCellBuilder($propertyId, array(), true),
+					new HtmlTableCellBuilder($localValue, array(), true),
+					new HtmlTableCellBuilder($externalValue, array(), true),
+					new HtmlTableCellBuilder($referenceStatus, array()),
+					new HtmlTableCellBuilder($dataSource, array(), true)
 				)
 			);
 		}

includes/CrossCheck/Result/CrossCheckResultList.php

Spacing +13 added lines, -13 removed lines

@@ -26,8 +26,8 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( array $results = array() ) {
-		Assert::parameterElementType( CrossCheckResult::class, $results, '$results' );
+	public function __construct(array $results = array()) {
+		Assert::parameterElementType(CrossCheckResult::class, $results, '$results');
 
 		$this->results = $results;
 	}
@@ -37,7 +37,7 @@ 
 	 *
 	 * @param CrossCheckResult $result
 	 */
-	public function add( CrossCheckResult $result ) {
+	public function add(CrossCheckResult $result) {
 		$this->results[] = $result;
 	}
 
@@ -46,8 +46,8 @@ 
 	 *
 	 * @param self $resultList
 	 */
-	public function merge( self $resultList ) {
-		$this->results = array_merge( $this->results, $resultList->results );
+	public function merge(self $resultList) {
+		$this->results = array_merge($this->results, $resultList->results);
 	}
 
 	/**
@@ -58,9 +58,9 @@ 
 	public function getPropertyIds() {
 		$propertyIds = array();
 
-		foreach ( $this->results as $result ) {
+		foreach ($this->results as $result) {
 			$propertyId = $result->getPropertyId();
-			if ( !in_array( $propertyId, $propertyIds ) ) {
+			if (!in_array($propertyId, $propertyIds)) {
 				$propertyIds[] = $propertyId;
 			}
 		}
@@ -75,16 +75,16 @@ 
 	 *
 	 * @return self
 	 */
-	public function getByPropertyId( PropertyId $propertyId ) {
+	public function getByPropertyId(PropertyId $propertyId) {
 		$results = array();
 
-		foreach ( $this->results as $result ) {
-			if ( $result->getPropertyId()->equals( $propertyId ) ) {
+		foreach ($this->results as $result) {
+			if ($result->getPropertyId()->equals($propertyId)) {
 				$results[] = $result;
 			}
 		}
 
-		return new self( $results );
+		return new self($results);
 	}
 
 	/**
@@ -103,7 +103,7 @@ 
 	 * @codeCoverageIgnore
 	 */
 	public function getIterator() {
-		return new ArrayIterator( $this->results );
+		return new ArrayIterator($this->results);
 	}
 
 	/**
@@ -112,7 +112,7 @@ 
 	 * @return int
 	 */
 	public function count() {
-		return count( $this->results );
+		return count($this->results);
 	}
 
 }

includes/CrossCheck/Result/ComparisonResult.php

Spacing +8 added lines, -8 removed lines

@@ -45,12 +45,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( DataValue $localValue, array $externalValues, $status ) {
-		Assert::parameterElementType( DataValue::class, $externalValues, '$externalValues' );
+	public function __construct(DataValue $localValue, array $externalValues, $status) {
+		Assert::parameterElementType(DataValue::class, $externalValues, '$externalValues');
 
 		$this->localValue = $localValue;
 		$this->externalValues = $externalValues;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -79,14 +79,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			array( self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH )
+			array(self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH)
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;