wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/CrossCheckInteractor.php

Spacing +62 added lines, -62 removed lines

@@ -43,7 +43,7 @@ 
 	 * @param StatementGuidParser $statementGuidParser
 	 * @param CrossChecker $crossChecker
 	 */
-	public function __construct( EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker ) {
+	public function __construct(EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker) {
 		$this->entityLookup = $entityLookup;
 		$this->statementGuidParser = $statementGuidParser;
 		$this->crossChecker = $crossChecker;
@@ -56,11 +56,11 @@ 
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	public function crossCheckEntityById( EntityId $entityId ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	public function crossCheckEntityById(EntityId $entityId) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatements( $entity->getStatements() );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatements($entity->getStatements());
 		}
 
 		return null;
@@ -73,12 +73,12 @@ 
 	 *
 	 * @return CrossCheckResultList[]
 	 */
-	public function crossCheckEntitiesByIds( array $entityIds ) {
-		Assert::parameterElementType( EntityId::class,  $entityIds, '$entityIds' );
+	public function crossCheckEntitiesByIds(array $entityIds) {
+		Assert::parameterElementType(EntityId::class, $entityIds, '$entityIds');
 
 		$results = array();
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityById( $entityId );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityById($entityId);
 		}
 
 		return $results;
@@ -91,8 +91,8 @@ 
 	 *
 	 * @return CrossCheckResultList
 	 */
-	public function crossCheckStatements( StatementList $statements ) {
-		return $this->crossChecker->crossCheckStatements( $statements, $statements );
+	public function crossCheckStatements(StatementList $statements) {
+		return $this->crossChecker->crossCheckStatements($statements, $statements);
 	}
 
 	/**
@@ -103,14 +103,14 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntities( array $entities ) {
-		Assert::parameterElementType( EntityDocument::class,  $entities, '$entities' );
+	public function crossCheckEntities(array $entities) {
+		Assert::parameterElementType(EntityDocument::class, $entities, '$entities');
 
 		$results = array();
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
-				$results[$entityId] = $this->crossCheckStatements( $entity->getStatements() );
+			if ($entity instanceof StatementListProvider) {
+				$results[$entityId] = $this->crossCheckStatements($entity->getStatements());
 			}
 		}
 
@@ -126,13 +126,13 @@ 
 	 * @return CrossCheckResultList|null
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntityByIdWithProperties( EntityId $entityId, array $propertyIds ) {
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntityByIdWithProperties(EntityId $entityId, array $propertyIds) {
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
-		$entity = $this->entityLookup->getEntity( $entityId );
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatementsWithProperties( $entity->getStatements(), $propertyIds );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatementsWithProperties($entity->getStatements(), $propertyIds);
 		}
 
 		return null;
@@ -147,13 +147,13 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesByIdWithProperties( array $entityIds, array $propertyIds ) {
-		Assert::parameterElementType( EntityId::class,  $entityIds, '$entityIds' );
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesByIdWithProperties(array $entityIds, array $propertyIds) {
+		Assert::parameterElementType(EntityId::class, $entityIds, '$entityIds');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$results = array();
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties( $entityId, $propertyIds );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties($entityId, $propertyIds);
 		}
 
 		return $results;
@@ -168,17 +168,17 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsWithProperties( StatementList $entityStatements, array $propertyIds ) {
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckStatementsWithProperties(StatementList $entityStatements, array $propertyIds) {
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$statements = new StatementList();
-		foreach ( $entityStatements->toArray() as $statement ) {
-			if ( in_array( $statement->getPropertyId(), $propertyIds ) ) {
-				$statements->addStatement( $statement );
+		foreach ($entityStatements->toArray() as $statement) {
+			if (in_array($statement->getPropertyId(), $propertyIds)) {
+				$statements->addStatement($statement);
 			}
 		}
 
-		return $this->crossChecker->crossCheckStatements( $entityStatements, $statements );
+		return $this->crossChecker->crossCheckStatements($entityStatements, $statements);
 	}
 
 	/**
@@ -190,14 +190,14 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesWithProperties( array $entities, array $propertyIds ) {
-		Assert::parameterElementType( EntityDocument::class,  $entities, '$entities' );
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesWithProperties(array $entities, array $propertyIds) {
+		Assert::parameterElementType(EntityDocument::class, $entities, '$entities');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$results = array();
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
+			if ($entity instanceof StatementListProvider) {
 				$results[$entityId] = $this->crossCheckStatementsWithProperties(
 					$entity->getStatements(),
 					$propertyIds
@@ -216,12 +216,12 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementByGuid( $guid ) {
-		$this->assertIsString( $guid, '$guid' );
+	public function crossCheckStatementByGuid($guid) {
+		$this->assertIsString($guid, '$guid');
 
-		$resultList = $this->crossCheckStatementsByGuids( array( $guid ) );
+		$resultList = $this->crossCheckStatementsByGuids(array($guid));
 
-		return reset( $resultList );
+		return reset($resultList);
 	}
 
 	/**
@@ -232,21 +232,21 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsByGuids( array $guids ) {
-		$this->assertIsArrayOfStrings( $guids, '$guids' );
+	public function crossCheckStatementsByGuids(array $guids) {
+		$this->assertIsArrayOfStrings($guids, '$guids');
 
 		$entityIds = array();
 		$groupedStatementGuids = array();
-		foreach ( $guids as $guid ) {
-			$serializedEntityId = $this->statementGuidParser->parse( $guid )->getEntityId();
+		foreach ($guids as $guid) {
+			$serializedEntityId = $this->statementGuidParser->parse($guid)->getEntityId();
 			$entityIds[$serializedEntityId->getSerialization()] = $serializedEntityId;
 			$groupedStatementGuids[$serializedEntityId->getSerialization()][] = $guid;
 		}
 
 		$resultLists = array();
-		foreach ( $groupedStatementGuids as $serializedEntityId => $guidsOfEntity ) {
-			$entityId = $entityIds[ $serializedEntityId ];
-			$resultLists[ $serializedEntityId ] = $this->crossCheckClaimsOfEntity( $entityId, $guidsOfEntity );
+		foreach ($groupedStatementGuids as $serializedEntityId => $guidsOfEntity) {
+			$entityId = $entityIds[$serializedEntityId];
+			$resultLists[$serializedEntityId] = $this->crossCheckClaimsOfEntity($entityId, $guidsOfEntity);
 		}
 
 		return $resultLists;
@@ -258,18 +258,18 @@ 
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	private function crossCheckClaimsOfEntity( EntityId $entityId, array $guids ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	private function crossCheckClaimsOfEntity(EntityId $entityId, array $guids) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
+		if ($entity instanceof StatementListProvider) {
 			$statements = new StatementList();
-			foreach ( $entity->getStatements()->toArray() as $statement ) {
-				if ( in_array( $statement->getGuid(), $guids ) ) {
-					$statements->addStatement( $statement );
+			foreach ($entity->getStatements()->toArray() as $statement) {
+				if (in_array($statement->getGuid(), $guids)) {
+					$statements->addStatement($statement);
 				}
 			}
 
-			return $this->crossChecker->crossCheckStatements( $entity->getStatements(), $statements );
+			return $this->crossChecker->crossCheckStatements($entity->getStatements(), $statements);
 		}
 
 		return null;
@@ -281,9 +281,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsString( $string, $parameterName ) {
-		if ( !is_string( $string ) ) {
-			throw new InvalidArgumentException( "$parameterName must be string." );
+	private function assertIsString($string, $parameterName) {
+		if (!is_string($string)) {
+			throw new InvalidArgumentException("$parameterName must be string.");
 		}
 	}
 
@@ -293,10 +293,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsArrayOfStrings( array $strings, $parameterName ) {
-		foreach ( $strings as $string ) {
-			if ( !is_string( $string ) ) {
-				throw new InvalidArgumentException( "Each element of $parameterName must be string." );
+	private function assertIsArrayOfStrings(array $strings, $parameterName) {
+		foreach ($strings as $string) {
+			if (!is_string($string)) {
+				throw new InvalidArgumentException("Each element of $parameterName must be string.");
 			}
 		}
 	}

includes/DumpMetaInformation/DumpMetaInformation.php

Spacing +30 added lines, -30 removed lines

@@ -83,27 +83,27 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $dumpId,
+	public function __construct($dumpId,
 								 ItemId $sourceItemId,
 								 array $identifierPropertyIds,
 								 $importDate,
 								 $languageCode,
 								 $sourceUrl,
 								 $size,
-								 ItemId $licenseItemId ) {
+								 ItemId $licenseItemId) {
 		Assert::parameterElementType(
 			PropertyId::class,
 			$identifierPropertyIds,
 			'$identifierPropertyIds'
 		);
 
-		$this->setDumpId( $dumpId );
+		$this->setDumpId($dumpId);
 		$this->sourceItemId = $sourceItemId;
 		$this->identifierPropertyIds = $identifierPropertyIds;
-		$this->setImportDate( $importDate );
-		$this->setLanguageCode( $languageCode );
-		$this->setSourceUrl( $sourceUrl );
-		$this->setSize( $size );
+		$this->setImportDate($importDate);
+		$this->setLanguageCode($languageCode);
+		$this->setSourceUrl($sourceUrl);
+		$this->setSize($size);
 		$this->licenseItemId = $licenseItemId;
 	}
 
@@ -168,10 +168,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setDumpId( $dumpId ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		$length = strlen( $dumpId );
-		if ( $length < 1 || $length > 25 ) {
+	private function setDumpId($dumpId) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		$length = strlen($dumpId);
+		if ($length < 1 || $length > 25) {
 			throw new InvalidArgumentException('$dumpId must be between 1 and 25 characters.');
 		}
 
@@ -183,10 +183,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setLanguageCode( $languageCode ) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
-		if( !Language::isValidCode( $languageCode ) ) {
-			throw new InvalidArgumentException( '$languageCode is not valid.' );
+	private function setLanguageCode($languageCode) {
+		Assert::parameterType('string', $languageCode, '$languageCode');
+		if (!Language::isValidCode($languageCode)) {
+			throw new InvalidArgumentException('$languageCode is not valid.');
 		}
 
 		$this->languageCode = $languageCode;
@@ -197,12 +197,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setImportDate( $importDate ) {
-		Assert::parameterType( 'string', $importDate, '$importDate' );
+	private function setImportDate($importDate) {
+		Assert::parameterType('string', $importDate, '$importDate');
 
-		$timestamp = wfTimestamp( TS_MW, $importDate );
-		if( !$timestamp ) {
-			throw new InvalidArgumentException( '$updatedAt has invalid timestamp format.' );
+		$timestamp = wfTimestamp(TS_MW, $importDate);
+		if (!$timestamp) {
+			throw new InvalidArgumentException('$updatedAt has invalid timestamp format.');
 		}
 
 		$this->importDate = $importDate;
@@ -213,13 +213,13 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSourceUrl( $sourceUrl ) {
-		Assert::parameterType( 'string', $sourceUrl, '$sourceUrl' );
-		if( strlen( $sourceUrl ) > 300 ) {
-			throw new InvalidArgumentException( '$sourceUrl must not be longer than 300 characters.' );
+	private function setSourceUrl($sourceUrl) {
+		Assert::parameterType('string', $sourceUrl, '$sourceUrl');
+		if (strlen($sourceUrl) > 300) {
+			throw new InvalidArgumentException('$sourceUrl must not be longer than 300 characters.');
 		}
-		if( !filter_var($sourceUrl, FILTER_VALIDATE_URL) ) {
-			throw new InvalidArgumentException( '$sourceUrl is not a valid url.' );
+		if (!filter_var($sourceUrl, FILTER_VALIDATE_URL)) {
+			throw new InvalidArgumentException('$sourceUrl is not a valid url.');
 		}
 
 		$this->sourceUrl = $sourceUrl;
@@ -230,10 +230,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSize( $size ){
-		Assert::parameterType( 'integer', $size, '$size' );
-		if( $size <= 0 ) {
-			throw new InvalidArgumentException( '$size must be positive integer.' );
+	private function setSize($size) {
+		Assert::parameterType('integer', $size, '$size');
+		if ($size <= 0) {
+			throw new InvalidArgumentException('$size must be positive integer.');
 		}
 
 		$this->size = $size;

WikibaseQualityExternalValidationHooks.php

Spacing +6 added lines, -6 removed lines

@@ -7,16 +7,16 @@
 	 *
 	 * @return bool
 	 */
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
-		$updater->addExtensionTable( 'wbqev_dump_information', __DIR__ . '/sql/create_wbqev_dump_information.sql' );
-		$updater->addExtensionTable( 'wbqev_external_data', __DIR__ . '/sql/create_wbqev_external_data.sql' );
-		$updater->addExtensionTable( 'wbqev_identifier_properties', __DIR__ . '/sql/create_wbqev_identifier_properties.sql' );
+	public static function onCreateSchema(DatabaseUpdater $updater) {
+		$updater->addExtensionTable('wbqev_dump_information', __DIR__.'/sql/create_wbqev_dump_information.sql');
+		$updater->addExtensionTable('wbqev_external_data', __DIR__.'/sql/create_wbqev_external_data.sql');
+		$updater->addExtensionTable('wbqev_identifier_properties', __DIR__.'/sql/create_wbqev_identifier_properties.sql');
 
 		return true;
 	}
 
-	public static function onUnitTestsList( &$paths ) {
-		$paths[] = __DIR__ . '/tests/phpunit';
+	public static function onUnitTestsList(&$paths) {
+		$paths[] = __DIR__.'/tests/phpunit';
 		return true;
 	}
 

includes/CrossCheck/Comparer/TimeValueComparer.php

Spacing +23 added lines, -23 removed lines

@@ -30,9 +30,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -42,38 +42,38 @@ 
 
 		$result = ComparisonResult::STATUS_MISMATCH;
 
-		if ( !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches )
-			|| !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches )
+		if (!preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches)
+			|| !preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches)
 		) {
 			return ComparisonResult::STATUS_MISMATCH;
 		}
-		list( , $localSign, $localYearHigh, $localMwTime, $localYearLow ) = $localMatches;
-		list( , $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow ) = $externalMatches;
-		if ( $localSign !== $externalSign && ( $localYearHigh . $localYearLow !== '0000'
-				|| $externalYearHigh . $externalYearLow !== '0000' )
+		list(, $localSign, $localYearHigh, $localMwTime, $localYearLow) = $localMatches;
+		list(, $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow) = $externalMatches;
+		if ($localSign !== $externalSign && ($localYearHigh.$localYearLow !== '0000'
+				|| $externalYearHigh.$externalYearLow !== '0000')
 		) {
 			return ComparisonResult::STATUS_MISMATCH;
 		}
 
 		try {
-			$localTimestamp = new MWTimestamp( $localMwTime );
-			$externalTimestamp = new MWTimestamp( $externalMwTime );
-			$diff = $localTimestamp->diff( $externalTimestamp );
-			$diff->y += abs( $localYearHigh - $externalYearHigh ) * 10000;
+			$localTimestamp = new MWTimestamp($localMwTime);
+			$externalTimestamp = new MWTimestamp($externalMwTime);
+			$diff = $localTimestamp->diff($externalTimestamp);
+			$diff->y += abs($localYearHigh - $externalYearHigh) * 10000;
 
-			if ( $value->getPrecision() === $comparativeValue->getPrecision()
-				&& $this->resultOfDiffWithPrecision( $diff, $value->getPrecision() )
+			if ($value->getPrecision() === $comparativeValue->getPrecision()
+				&& $this->resultOfDiffWithPrecision($diff, $value->getPrecision())
 			) {
 				$result = ComparisonResult::STATUS_MATCH;
 			} elseif (
 				$this->resultOfDiffWithPrecision(
 					$diff,
-					min( $value->getPrecision(), $comparativeValue->getPrecision() )
+					min($value->getPrecision(), $comparativeValue->getPrecision())
 				)
 			) {
 				$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 			}
-		} catch ( TimestampException $ex ) {
+		} catch (TimestampException $ex) {
 		}
 
 		return $result;
@@ -87,10 +87,10 @@ 
 	 *
 	 * @return bool
 	 */
-	private function resultOfDiffWithPrecision( DateInterval $diff, $precision ) {
+	private function resultOfDiffWithPrecision(DateInterval $diff, $precision) {
 		$result = true;
 
-		switch ( $precision ) {
+		switch ($precision) {
 			case TimeValue::PRECISION_SECOND:
 				$result = $diff->s === 0;
 				// Fall through with no break/return. This is critical for this algorithm.
@@ -134,10 +134,10 @@ 
 	 *
 	 * @return ValueParser
 	 */
-	protected function getExternalValueParser( DumpMetaInformation $dumpMetaInformation ) {
+	protected function getExternalValueParser(DumpMetaInformation $dumpMetaInformation) {
 		$parserOptions = new ParserOptions();
-		$parserOptions->setOption( ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode() );
-		$timeParserFactory = new TimeParserFactory( $parserOptions );
+		$parserOptions->setOption(ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode());
+		$timeParserFactory = new TimeParserFactory($parserOptions);
 
 		return $timeParserFactory->getTimeParser();
 	}
@@ -150,7 +150,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof TimeValue && $comparativeValue instanceof TimeValue;
 	}
 

includes/ExternalDataRepo.php

Spacing +31 added lines, -31 removed lines

@@ -24,23 +24,23 @@ 
 	 * @param PropertyId[] $propertyIds
 	 * @return array
 	 */
-	public function getExternalData( array $dumpIds, array $externalIds, array $propertyIds ) {
-		Assert::parameterElementType( 'string', $dumpIds, '$dumpIds' );
-		Assert::parameterElementType( 'string', $externalIds, '$externalIds' );
-		Assert::parameterElementType( PropertyId::class, $propertyIds, '$propertyIds' );
-		Assert::parameter( count( $dumpIds ) > 0, '$dumpIds', '$dumpIds has to contain at least one element.' );
-		Assert::parameter( count( $externalIds ) > 0, '$externalIds', '$externalIds has to contain at least one element.' );
+	public function getExternalData(array $dumpIds, array $externalIds, array $propertyIds) {
+		Assert::parameterElementType('string', $dumpIds, '$dumpIds');
+		Assert::parameterElementType('string', $externalIds, '$externalIds');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
+		Assert::parameter(count($dumpIds) > 0, '$dumpIds', '$dumpIds has to contain at least one element.');
+		Assert::parameter(count($externalIds) > 0, '$externalIds', '$externalIds has to contain at least one element.');
 
 		$conditions = array(
 			'dump_id' => $dumpIds,
 			'external_id' => $externalIds
 		);
-		if ( $propertyIds ) {
+		if ($propertyIds) {
 			$conditions['pid'] = $propertyIds;
 		}
 
 		$externalData = array();
-		$db = wfGetDB( DB_SLAVE );
+		$db = wfGetDB(DB_SLAVE);
 		$result = $db->select(
 			self::TABLE_NAME,
 			array(
@@ -52,7 +52,7 @@ 
 			$conditions
 		);
 
-		foreach ( $result as $row ) {
+		foreach ($result as $row) {
 			$externalData[$row->dump_id][$row->external_id][$row->pid][] = $row->external_value;
 		}
 
@@ -68,13 +68,13 @@ 
 	 * @param string $externalValue
 	 * @return bool
 	 */
-	public function insert( $dumpId, $externalId, PropertyId $propertyId, $externalValue ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
-		Assert::parameterType( 'string', $externalValue, '$externalValue' );
+	public function insert($dumpId, $externalId, PropertyId $propertyId, $externalValue) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		Assert::parameterType('string', $externalId, '$externalId');
+		Assert::parameterType('string', $externalValue, '$externalValue');
 
-		$externalDataBatch = array( func_get_args() );
-		return $this->insertBatch( $externalDataBatch );
+		$externalDataBatch = array(func_get_args());
+		return $this->insertBatch($externalDataBatch);
 	}
 
 	/**
@@ -84,10 +84,10 @@ 
 	 * @throws DBError
 	 * @return bool
 	 */
-	public function insertBatch( array $externalDataBatch ) {
-		$db = wfGetDB( DB_MASTER );
+	public function insertBatch(array $externalDataBatch) {
+		$db = wfGetDB(DB_MASTER);
 		$accumulator = array_map(
-			function ( $externalData ) use ( $db ) {
+			function($externalData) use ($db) {
 				return array(
 					'dump_id' => $externalData[0],
 					'external_id' => $externalData[1],
@@ -100,10 +100,10 @@ 
 
 		try {
 			$db->begin();
-			$result = $db->insert( self::TABLE_NAME, $accumulator );
+			$result = $db->insert(self::TABLE_NAME, $accumulator);
 			$db->commit();
 		}
-		catch( DBError $ex ) {
+		catch (DBError $ex) {
 			$db->rollback();
 			throw $ex;
 		}
@@ -118,21 +118,21 @@ 
 	 * @param int $batchSize
 	 * @throws \DBUnexpectedError
 	 */
-	public function deleteOfDump( $dumpId, $batchSize = 1000 ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		Assert::parameterType( 'integer', $batchSize, 'batchSize' );
+	public function deleteOfDump($dumpId, $batchSize = 1000) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		Assert::parameterType('integer', $batchSize, 'batchSize');
 
-		$db = wfGetDB( DB_MASTER );
-		if ( $db->getType() === 'sqlite' ) {
-			$db->delete( self::TABLE_NAME, array( 'dump_id' => $dumpId ) );
+		$db = wfGetDB(DB_MASTER);
+		if ($db->getType() === 'sqlite') {
+			$db->delete(self::TABLE_NAME, array('dump_id' => $dumpId));
 		} else {
 			do {
-				$db->commit( __METHOD__, 'flush' );
+				$db->commit(__METHOD__, 'flush');
 				wfGetLBFactory()->waitForReplication();
-				$table = $db->tableName( self::TABLE_NAME );
-				$condition = 'dump_id = ' . $db->addQuotes( $dumpId );
-				$db->query( sprintf( 'DELETE FROM %s WHERE %s LIMIT %s', $table, $condition, $batchSize ) );
-			} while ( $db->affectedRows() > 0 );
+				$table = $db->tableName(self::TABLE_NAME);
+				$condition = 'dump_id = '.$db->addQuotes($dumpId);
+				$db->query(sprintf('DELETE FROM %s WHERE %s LIMIT %s', $table, $condition, $batchSize));
+			} while ($db->affectedRows() > 0);
 		}
 	}
 

maintenance/UpdateExternalData.php

Spacing +10 added lines, -10 removed lines

@@ -7,10 +7,10 @@ 
 use WikibaseQuality\ExternalValidation\UpdateExternalData\CsvImportSettings;
 use WikibaseQuality\ExternalValidation\UpdateExternalData\ExternalDataImporter;
 
-$basePath = getenv( 'MW_INSTALL_PATH' ) !== false
-	? getenv( 'MW_INSTALL_PATH' )
-	: __DIR__ . '/../../..';
-require_once $basePath . '/maintenance/Maintenance.php';
+$basePath = getenv('MW_INSTALL_PATH') !== false
+	? getenv('MW_INSTALL_PATH')
+	: __DIR__.'/../../..';
+require_once $basePath.'/maintenance/Maintenance.php';
 
 /**
  * Maintenance script that evokes updates of wbqev_external_data, wbqev_dump_information, wbqev_identifier_properties
@@ -25,16 +25,16 @@ 
 	public function __construct() {
 		parent::__construct();
 
-		$this->addDescription( "Imports external entities from given CSV files into the local database. CSV files can be generated using the DumpConverter." );
-		$this->addOption( 'external-values-file', 'CSV file containing external values for import.', true, true );
-		$this->addOption( 'dump-information-file', 'CSV file containing dump meta information for import.', true, true );
-		$this->setBatchSize( 1000 );
+		$this->addDescription("Imports external entities from given CSV files into the local database. CSV files can be generated using the DumpConverter.");
+		$this->addOption('external-values-file', 'CSV file containing external values for import.', true, true);
+		$this->addOption('dump-information-file', 'CSV file containing dump meta information for import.', true, true);
+		$this->setBatchSize(1000);
 	}
 
 	public function execute() {
 		$context = new CsvImportSettings(
-			$this->getOption( 'external-values-file' ),
-			$this->getOption( 'dump-information-file' ),
+			$this->getOption('external-values-file'),
+			$this->getOption('dump-information-file'),
 			$this->mBatchSize,
 			$this->isQuiet()
 		);

WikibaseQualityExternalValidation.php

Spacing +13 added lines, -13 removed lines

@@ -1,10 +1,10 @@ 
 <?php
 
-if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
-	require_once __DIR__ . '/vendor/autoload.php';
+if (is_readable(__DIR__.'/vendor/autoload.php')) {
+	require_once __DIR__.'/vendor/autoload.php';
 }
 
-call_user_func( function () {
+call_user_func(function() {
 	// Set credits
 	$GLOBALS['wgExtensionCredits']['specialpage'][] = array(
 		'path' => __FILE__,
@@ -17,8 +17,8 @@ 
 	);
 
 	// Initialize localization and aliases
-	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__ . '/i18n';
-	$GLOBALS['wgExtensionMessagesFiles']['WikibaseQualityExternalValidationAlias'] = __DIR__ . '/WikibaseQualityExternalValidation.alias.php';
+	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__.'/i18n';
+	$GLOBALS['wgExtensionMessagesFiles']['WikibaseQualityExternalValidationAlias'] = __DIR__.'/WikibaseQualityExternalValidation.alias.php';
 
 	// Initalize hooks for creating database tables
 	$GLOBALS['wgHooks']['LoadExtensionSchemaUpdates'][] = 'WikibaseQualityExternalValidationHooks::onCreateSchema';
@@ -33,8 +33,8 @@ 
 	// Define API modules
 	$GLOBALS['wgAPIModules']['wbqevcrosscheck'] = array(
 		'class' => 'WikibaseQuality\ExternalValidation\Api\RunCrossCheck',
-		'factory' => function( ApiMain $main, $action ) {
-			return \WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState( $main, $action );
+		'factory' => function(ApiMain $main, $action) {
+			return \WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState($main, $action);
 		}
 	);
 
@@ -46,13 +46,13 @@ 
 	);
 
 	// Ids of certain Wikidata entities
-	if( !defined( 'INSTANCE_OF_PID' ) ) {
-		define( 'INSTANCE_OF_PID', 'P31' );
+	if (!defined('INSTANCE_OF_PID')) {
+		define('INSTANCE_OF_PID', 'P31');
 	}
-	if( !defined( 'IDENTIFIER_PROPERTY_QID' ) ) {
-		define( 'IDENTIFIER_PROPERTY_QID', 'Q19847637' );
+	if (!defined('IDENTIFIER_PROPERTY_QID')) {
+		define('IDENTIFIER_PROPERTY_QID', 'Q19847637');
 	}
-	if( !defined( 'STATED_IN_PID' ) ) {
-		define( 'STATED_IN_PID', 'P248' );
+	if (!defined('STATED_IN_PID')) {
+		define('STATED_IN_PID', 'P248');
 	}
 } );

WikibaseQualityExternalValidation.alias.php

Spacing +2 added lines, -2 removed lines

@@ -11,6 +11,6 @@
 
 /** English (English) */
 $specialPageAliases['en'] = array(
-	'CrossCheck' => array( 'CrossCheck', 'Cross Check' ),
-	'ExternalDatabases' => array( 'ExternalDatabases', 'ExternalDbs', 'External Dbs' ),
+	'CrossCheck' => array('CrossCheck', 'Cross Check'),
+	'ExternalDatabases' => array('ExternalDatabases', 'ExternalDbs', 'External Dbs'),
 );
\ No newline at end of file

specials/SpecialExternalDatabases.php

Spacing +38 added lines, -38 removed lines

@@ -54,10 +54,10 @@ 
 		TermLookup $termLookup,
 		EntityIdHtmlLinkFormatterFactory $entityIdHtmlLinkFormatterFactory,
 		DumpMetaInformationLookup $dumpMetaInformationRepo ) {
-		parent::__construct( 'ExternalDatabases' );
+		parent::__construct('ExternalDatabases');
 
 		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter(
-			new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() )
+			new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode())
 		);
 
 		$this->dumpMetaInformationRepo = $dumpMetaInformationRepo;
@@ -78,7 +78,7 @@ 
 	 * @return string
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqev-externaldbs' )->text();
+		return $this->msg('wbqev-externaldbs')->text();
 	}
 
 	/**
@@ -86,51 +86,51 @@ 
 	 *
 	 * @param string|null $subPage
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
 		$this->setHeaders();
 
 		$out->addHTML(
-			Html::openElement( 'p' )
-			. $this->msg( 'wbqev-externaldbs-instructions' )->parse()
-			. Html::closeElement( 'p' )
-			. Html::openElement( 'h3' )
-			. $this->msg( 'wbqev-externaldbs-overview-headline' )->parse()
-			. Html::closeElement( 'h3' )
+			Html::openElement('p')
+			. $this->msg('wbqev-externaldbs-instructions')->parse()
+			. Html::closeElement('p')
+			. Html::openElement('h3')
+			. $this->msg('wbqev-externaldbs-overview-headline')->parse()
+			. Html::closeElement('h3')
 		);
 
 		$dumps = $this->dumpMetaInformationRepo->getAll();
-		if ( count( $dumps ) > 0 ) {
+		if (count($dumps) > 0) {
 			$groupedDumpMetaInformation = array();
-			foreach ( $dumps as $dump ) {
+			foreach ($dumps as $dump) {
 				$sourceItemId = $dump->getSourceItemId()->getSerialization();
 				$groupedDumpMetaInformation[$sourceItemId][] = $dump;
 			}
 
 			$table = new HtmlTableBuilder(
 				array(
-					$this->msg( 'wbqev-externaldbs-name' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-id' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-import-date' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-language' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-source-urls' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-size' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-license' )->escaped()
+					$this->msg('wbqev-externaldbs-name')->escaped(),
+					$this->msg('wbqev-externaldbs-id')->escaped(),
+					$this->msg('wbqev-externaldbs-import-date')->escaped(),
+					$this->msg('wbqev-externaldbs-language')->escaped(),
+					$this->msg('wbqev-externaldbs-source-urls')->escaped(),
+					$this->msg('wbqev-externaldbs-size')->escaped(),
+					$this->msg('wbqev-externaldbs-license')->escaped()
 				),
 				true
 			);
 
-			foreach ( $groupedDumpMetaInformation as $dumpMetaInformation ) {
-				$table->appendRows( $this->getRowGroup( $dumpMetaInformation ) );
+			foreach ($groupedDumpMetaInformation as $dumpMetaInformation) {
+				$table->appendRows($this->getRowGroup($dumpMetaInformation));
 			}
 
-			$out->addHTML( $table->toHtml() );
+			$out->addHTML($table->toHtml());
 		} else {
 			$out->addHTML(
-				Html::openElement( 'p' )
-				. $this->msg( 'wbqev-externaldbs-no-databases' )->escaped()
-				. Html::closeElement( 'p' )
+				Html::openElement('p')
+				. $this->msg('wbqev-externaldbs-no-databases')->escaped()
+				. Html::closeElement('p')
 			);
 		}
 	}
@@ -142,12 +142,12 @@ 
 	 *
 	 * @return array
 	 */
-	private function getRowGroup( array $dumpMetaInformationGroup ) {
+	private function getRowGroup(array $dumpMetaInformationGroup) {
 		$rows = array();
 
-		foreach ( $dumpMetaInformationGroup as $dumpMetaInformation ) {
+		foreach ($dumpMetaInformationGroup as $dumpMetaInformation) {
 			$dumpId = $dumpMetaInformation->getDumpId();
-			$importDate = $this->getLanguage()->timeanddate( $dumpMetaInformation->getImportDate() );
+			$importDate = $this->getLanguage()->timeanddate($dumpMetaInformation->getImportDate());
 			$language = Language::fetchLanguageName(
 				$dumpMetaInformation->getLanguageCode(),
 				$this->getLanguage()->getCode()
@@ -156,23 +156,23 @@ 
 				$dumpMetaInformation->getSourceUrl(),
 				$dumpMetaInformation->getSourceUrl()
 			);
-			$size = $this->getLanguage()->formatSize( $dumpMetaInformation->getSize() );
-			$license = $this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformation->getLicenseItemId() );
+			$size = $this->getLanguage()->formatSize($dumpMetaInformation->getSize());
+			$license = $this->entityIdLinkFormatter->formatEntityId($dumpMetaInformation->getLicenseItemId());
 			$rows[] = array(
-				new HtmlTableCellBuilder( $dumpId ),
-				new HtmlTableCellBuilder( $importDate ),
-				new HtmlTableCellBuilder( $language ),
-				new HtmlTableCellBuilder( $sourceUrl, array(), true ),
-				new HtmlTableCellBuilder( $size ),
-				new HtmlTableCellBuilder( $license, array(), true )
+				new HtmlTableCellBuilder($dumpId),
+				new HtmlTableCellBuilder($importDate),
+				new HtmlTableCellBuilder($language),
+				new HtmlTableCellBuilder($sourceUrl, array(), true),
+				new HtmlTableCellBuilder($size),
+				new HtmlTableCellBuilder($license, array(), true)
 			);
 		}
 
 		array_unshift(
 			$rows[0],
 			new HtmlTableCellBuilder(
-				$this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformationGroup[0]->getSourceItemId() ),
-				array( 'rowspan' => (string)count( $dumpMetaInformationGroup ) ),
+				$this->entityIdLinkFormatter->formatEntityId($dumpMetaInformationGroup[0]->getSourceItemId()),
+				array('rowspan' => (string)count($dumpMetaInformationGroup)),
 				true
 			)
 		);