Completed
Push — master ( 517e4f...0d0d38 )
by
unknown
02:47
created
includes/CrossCheck/Result/CrossCheckResultList.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
26 26
 	 *
27 27
 	 * @throws InvalidArgumentException
28 28
 	 */
29
-	public function __construct( array $results = array() ) {
30
-		Assert::parameterElementType( CrossCheckResult::class, $results, '$results' );
29
+	public function __construct(array $results = array()) {
30
+		Assert::parameterElementType(CrossCheckResult::class, $results, '$results');
31 31
 
32 32
 		$this->results = $results;
33 33
 	}
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 *
38 38
 	 * @param CrossCheckResult $result
39 39
 	 */
40
-	public function add( CrossCheckResult $result ) {
40
+	public function add(CrossCheckResult $result) {
41 41
 		$this->results[] = $result;
42 42
 	}
43 43
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 	 *
47 47
 	 * @param self $resultList
48 48
 	 */
49
-	public function merge( self $resultList ) {
50
-		$this->results = array_merge( $this->results, $resultList->results );
49
+	public function merge(self $resultList) {
50
+		$this->results = array_merge($this->results, $resultList->results);
51 51
 	}
52 52
 
53 53
 	/**
@@ -58,9 +58,9 @@  discard block
 block discarded – undo
58 58
 	public function getPropertyIds() {
59 59
 		$propertyIds = array();
60 60
 
61
-		foreach ( $this->results as $result ) {
61
+		foreach ($this->results as $result) {
62 62
 			$propertyId = $result->getPropertyId();
63
-			if ( !in_array( $propertyId, $propertyIds ) ) {
63
+			if (!in_array($propertyId, $propertyIds)) {
64 64
 				$propertyIds[] = $propertyId;
65 65
 			}
66 66
 		}
@@ -75,16 +75,16 @@  discard block
 block discarded – undo
75 75
 	 *
76 76
 	 * @return self
77 77
 	 */
78
-	public function getByPropertyId( PropertyId $propertyId ) {
78
+	public function getByPropertyId(PropertyId $propertyId) {
79 79
 		$results = array();
80 80
 
81
-		foreach ( $this->results as $result ) {
82
-			if ( $result->getPropertyId()->equals( $propertyId ) ) {
81
+		foreach ($this->results as $result) {
82
+			if ($result->getPropertyId()->equals($propertyId)) {
83 83
 				$results[] = $result;
84 84
 			}
85 85
 		}
86 86
 
87
-		return new self( $results );
87
+		return new self($results);
88 88
 	}
89 89
 
90 90
 	/**
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 	 * @codeCoverageIgnore
104 104
 	 */
105 105
 	public function getIterator() {
106
-		return new ArrayIterator( $this->results );
106
+		return new ArrayIterator($this->results);
107 107
 	}
108 108
 
109 109
 	/**
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	 * @return int
113 113
 	 */
114 114
 	public function count() {
115
-		return count( $this->results );
115
+		return count($this->results);
116 116
 	}
117 117
 
118 118
 }
Please login to merge, or discard this patch.
includes/CrossCheck/Result/ComparisonResult.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @throws InvalidArgumentException
47 47
 	 */
48
-	public function __construct( DataValue $localValue, array $externalValues, $status ) {
49
-		Assert::parameterElementType( DataValue::class, $externalValues, '$externalValues' );
48
+	public function __construct(DataValue $localValue, array $externalValues, $status) {
49
+		Assert::parameterElementType(DataValue::class, $externalValues, '$externalValues');
50 50
 
51 51
 		$this->localValue = $localValue;
52 52
 		$this->externalValues = $externalValues;
53
-		$this->setStatus( $status );
53
+		$this->setStatus($status);
54 54
 	}
55 55
 
56 56
 	/**
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
79 79
 	 *
80 80
 	 * @throws InvalidArgumentException
81 81
 	 */
82
-	private function setStatus( $status ) {
83
-		Assert::parameterType( 'string', $status, '$status' );
84
-		if ( !in_array(
82
+	private function setStatus($status) {
83
+		Assert::parameterType('string', $status, '$status');
84
+		if (!in_array(
85 85
 			$status,
86
-			array( self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH )
86
+			array(self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH)
87 87
 		)
88 88
 		) {
89
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
89
+			throw new InvalidArgumentException('$status must be one of the status constants.');
90 90
 		}
91 91
 
92 92
 		$this->status = $status;
Please login to merge, or discard this patch.
includes/CrossCheck/Comparer/EntityIdValueComparer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	 * @param TermIndex $termIndex
33 33
 	 * @param StringComparer $stringComparer
34 34
 	 */
35
-	public function __construct( TermIndex $termIndex, StringComparer $stringComparer ) {
35
+	public function __construct(TermIndex $termIndex, StringComparer $stringComparer) {
36 36
 		$this->termIndex = $termIndex;
37 37
 		$this->stringComparer = $stringComparer;
38 38
 	}
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
47 47
 	 */
48
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
49
-		Assert::parameterType( EntityIdValue::class, $value, '$value' );
50
-		Assert::parameterType( MonolingualTextValue::class, $comparativeValue, '$comparativeValue' );
48
+	public function compare(DataValue $value, DataValue $comparativeValue) {
49
+		Assert::parameterType(EntityIdValue::class, $value, '$value');
50
+		Assert::parameterType(MonolingualTextValue::class, $comparativeValue, '$comparativeValue');
51 51
 
52 52
 		/**
53 53
 		 * @var EntityIdValue $value
@@ -56,10 +56,10 @@  discard block
 block discarded – undo
56 56
 
57 57
 		$entityId = $value->getEntityId();
58 58
 		$language = $comparativeValue->getLanguageCode();
59
-		$terms = $this->getTerms( $entityId, $language );
59
+		$terms = $this->getTerms($entityId, $language);
60 60
 
61
-		if ( $terms ) {
62
-			return $this->stringComparer->compareWithArray( $comparativeValue->getText(), $terms );
61
+		if ($terms) {
62
+			return $this->stringComparer->compareWithArray($comparativeValue->getText(), $terms);
63 63
 		}
64 64
 
65 65
 		return null;
@@ -73,18 +73,18 @@  discard block
 block discarded – undo
73 73
 	 *
74 74
 	 * @return array
75 75
 	 */
76
-	private function getTerms( EntityId $entityId, $language ) {
76
+	private function getTerms(EntityId $entityId, $language) {
77 77
 		$terms = $this->termIndex->getTermsOfEntity(
78 78
 			$entityId,
79 79
 			array(
80 80
 				TermIndexEntry::TYPE_LABEL,
81 81
 				TermIndexEntry::TYPE_ALIAS
82 82
 			),
83
-			array( $language )
83
+			array($language)
84 84
 		);
85 85
 
86 86
 		return array_map(
87
-			function( TermIndexEntry $term ) {
87
+			function(TermIndexEntry $term) {
88 88
 				return $term->getText();
89 89
 			},
90 90
 			$terms
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 * @param DataValue $comparativeValue
99 99
 	 * @return bool
100 100
 	 */
101
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
101
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
102 102
 		return $value instanceof EntityIdValue && $comparativeValue instanceof MonolingualTextValue;
103 103
 	}
104 104
 
Please login to merge, or discard this patch.
includes/DumpMetaInformation/DumpMetaInformation.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -83,27 +83,27 @@  discard block
 block discarded – undo
83 83
 	 *
84 84
 	 * @throws InvalidArgumentException
85 85
 	 */
86
-	public function __construct( $dumpId,
86
+	public function __construct($dumpId,
87 87
 								 ItemId $sourceItemId,
88 88
 								 array $identifierPropertyIds,
89 89
 								 $importDate,
90 90
 								 $languageCode,
91 91
 								 $sourceUrl,
92 92
 								 $size,
93
-								 ItemId $licenseItemId ) {
93
+								 ItemId $licenseItemId) {
94 94
 		Assert::parameterElementType(
95 95
 			PropertyId::class,
96 96
 			$identifierPropertyIds,
97 97
 			'$identifierPropertyIds'
98 98
 		);
99 99
 
100
-		$this->setDumpId( $dumpId );
100
+		$this->setDumpId($dumpId);
101 101
 		$this->sourceItemId = $sourceItemId;
102 102
 		$this->identifierPropertyIds = $identifierPropertyIds;
103
-		$this->setImportDate( $importDate );
104
-		$this->setLanguageCode( $languageCode );
105
-		$this->setSourceUrl( $sourceUrl );
106
-		$this->setSize( $size );
103
+		$this->setImportDate($importDate);
104
+		$this->setLanguageCode($languageCode);
105
+		$this->setSourceUrl($sourceUrl);
106
+		$this->setSize($size);
107 107
 		$this->licenseItemId = $licenseItemId;
108 108
 	}
109 109
 
@@ -168,10 +168,10 @@  discard block
 block discarded – undo
168 168
 	 *
169 169
 	 * @throws InvalidArgumentException
170 170
 	 */
171
-	private function setDumpId( $dumpId ) {
172
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
173
-		$length = strlen( $dumpId );
174
-		if ( $length < 1 || $length > 25 ) {
171
+	private function setDumpId($dumpId) {
172
+		Assert::parameterType('string', $dumpId, '$dumpId');
173
+		$length = strlen($dumpId);
174
+		if ($length < 1 || $length > 25) {
175 175
 			throw new InvalidArgumentException('$dumpId must be between 1 and 25 characters.');
176 176
 		}
177 177
 
@@ -183,10 +183,10 @@  discard block
 block discarded – undo
183 183
 	 *
184 184
 	 * @throws InvalidArgumentException
185 185
 	 */
186
-	private function setLanguageCode( $languageCode ) {
187
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
188
-		if( !Language::isValidCode( $languageCode ) ) {
189
-			throw new InvalidArgumentException( '$languageCode is not valid.' );
186
+	private function setLanguageCode($languageCode) {
187
+		Assert::parameterType('string', $languageCode, '$languageCode');
188
+		if (!Language::isValidCode($languageCode)) {
189
+			throw new InvalidArgumentException('$languageCode is not valid.');
190 190
 		}
191 191
 
192 192
 		$this->languageCode = $languageCode;
@@ -197,12 +197,12 @@  discard block
 block discarded – undo
197 197
 	 *
198 198
 	 * @throws InvalidArgumentException
199 199
 	 */
200
-	private function setImportDate( $importDate ) {
201
-		Assert::parameterType( 'string', $importDate, '$importDate' );
200
+	private function setImportDate($importDate) {
201
+		Assert::parameterType('string', $importDate, '$importDate');
202 202
 
203
-		$timestamp = wfTimestamp( TS_MW, $importDate );
204
-		if( !$timestamp ) {
205
-			throw new InvalidArgumentException( '$updatedAt has invalid timestamp format.' );
203
+		$timestamp = wfTimestamp(TS_MW, $importDate);
204
+		if (!$timestamp) {
205
+			throw new InvalidArgumentException('$updatedAt has invalid timestamp format.');
206 206
 		}
207 207
 
208 208
 		$this->importDate = $importDate;
@@ -213,13 +213,13 @@  discard block
 block discarded – undo
213 213
 	 *
214 214
 	 * @throws InvalidArgumentException
215 215
 	 */
216
-	private function setSourceUrl( $sourceUrl ) {
217
-		Assert::parameterType( 'string', $sourceUrl, '$sourceUrl' );
218
-		if( strlen( $sourceUrl ) > 300 ) {
219
-			throw new InvalidArgumentException( '$sourceUrl must not be longer than 300 characters.' );
216
+	private function setSourceUrl($sourceUrl) {
217
+		Assert::parameterType('string', $sourceUrl, '$sourceUrl');
218
+		if (strlen($sourceUrl) > 300) {
219
+			throw new InvalidArgumentException('$sourceUrl must not be longer than 300 characters.');
220 220
 		}
221
-		if( !filter_var($sourceUrl, FILTER_VALIDATE_URL) ) {
222
-			throw new InvalidArgumentException( '$sourceUrl is not a valid url.' );
221
+		if (!filter_var($sourceUrl, FILTER_VALIDATE_URL)) {
222
+			throw new InvalidArgumentException('$sourceUrl is not a valid url.');
223 223
 		}
224 224
 
225 225
 		$this->sourceUrl = $sourceUrl;
@@ -230,10 +230,10 @@  discard block
 block discarded – undo
230 230
 	 *
231 231
 	 * @throws InvalidArgumentException
232 232
 	 */
233
-	private function setSize( $size ){
234
-		Assert::parameterType( 'integer', $size, '$size' );
235
-		if( $size <= 0 ) {
236
-			throw new InvalidArgumentException( '$size must be positive integer.' );
233
+	private function setSize($size) {
234
+		Assert::parameterType('integer', $size, '$size');
235
+		if ($size <= 0) {
236
+			throw new InvalidArgumentException('$size must be positive integer.');
237 237
 		}
238 238
 
239 239
 		$this->size = $size;
Please login to merge, or discard this patch.