wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/UpdateExternalData/ExternalDataImporter.php

Spacing +41 added lines, -41 removed lines

@@ -51,13 +51,13 @@ 
 	public function import() {
 		$dumpIds = $this->insertMetaInformation();
 
-		$this->log( "\nDelete old database entries...\n" );
+		$this->log("\nDelete old database entries...\n");
 
-		foreach ( $dumpIds as $dumpId ) {
-			$this->externalDataRepo->deleteOfDump( $dumpId, $this->importSettings->getBatchSize() );
+		foreach ($dumpIds as $dumpId) {
+			$this->externalDataRepo->deleteOfDump($dumpId, $this->importSettings->getBatchSize());
 		}
 
-		$this->log( "\n" );
+		$this->log("\n");
 
 		$this->insertExternalValues();
 	}
@@ -68,54 +68,54 @@ 
 	 * @return array
 	 */
 	protected function insertMetaInformation() {
-		$this->log( "Insert new dump meta information\n" );
+		$this->log("Insert new dump meta information\n");
 
-		$csvFile = fopen( $this->importSettings->getDumpInformationFilePath(), 'rb' );
-		if( !$csvFile ) {
-			exit( 'Error while reading CSV file.' );
+		$csvFile = fopen($this->importSettings->getDumpInformationFilePath(), 'rb');
+		if (!$csvFile) {
+			exit('Error while reading CSV file.');
 		}
 
 		$i = 0;
 		$dumpIds = array();
-		while ( $data = fgetcsv( $csvFile ) ) {
+		while ($data = fgetcsv($csvFile)) {
 			$identifierPropertyIds = array_map(
-				function ( $propertyId ) {
-					return new PropertyId( $propertyId );
+				function($propertyId) {
+					return new PropertyId($propertyId);
 				},
-				json_decode( $data[2] )
+				json_decode($data[2])
 			);
 			try {
 				$dumpMetaInformation = new DumpMetaInformation(
 					$data[0],
-					new ItemId( $data[1] ),
+					new ItemId($data[1]),
 					$identifierPropertyIds,
 					$data[3],
 					$data[4],
 					$data[5],
-					intval( $data[6] ),
-					new ItemId( $data[7] )
+					intval($data[6]),
+					new ItemId($data[7])
 				);
 			}
-			catch( \InvalidArgumentException $e ) {
-				exit( 'Input file has bad formatted values.' );
+			catch (\InvalidArgumentException $e) {
+				exit('Input file has bad formatted values.');
 			}
 			$dumpIds[] = $dumpMetaInformation->getDumpId();
 
 			try {
-				$this->dumpMetaInformationStore->save( $dumpMetaInformation );
+				$this->dumpMetaInformationStore->save($dumpMetaInformation);
 			}
-			catch( \DBError $e ) {
-				exit( 'Unknown database error occurred.' );
+			catch (\DBError $e) {
+				exit('Unknown database error occurred.');
 			}
 
 			$i++;
-			$this->log( "\r\033[K" );
-			$this->log( "$i rows inserted or updated" );
+			$this->log("\r\033[K");
+			$this->log("$i rows inserted or updated");
 		}
 
-		fclose( $csvFile );
+		fclose($csvFile);
 
-		$this->log( "\n" );
+		$this->log("\n");
 
 		return $dumpIds;
 	}
@@ -124,32 +124,32 @@ 
 	 * Inserts external values stored in csv file into database
 	 */
 	private function insertExternalValues() {
-		$this->log( "Insert new data values\n" );
+		$this->log("Insert new data values\n");
 
-		$csvFile = fopen( $this->importSettings->getExternalValuesFilePath(), 'rb' );
-		if( !$csvFile ) {
-			exit( 'Error while reading CSV file.' );
+		$csvFile = fopen($this->importSettings->getExternalValuesFilePath(), 'rb');
+		if (!$csvFile) {
+			exit('Error while reading CSV file.');
 		}
 
 		$i = 0;
 		$accumulator = array();
-		while ( true ) {
-			$data = fgetcsv( $csvFile );
-			if ( $data === false || ++$i % $this->importSettings->getBatchSize() === 0 ) {
+		while (true) {
+			$data = fgetcsv($csvFile);
+			if ($data === false || ++$i % $this->importSettings->getBatchSize() === 0) {
 				try {
-					$this->externalDataRepo->insertBatch( $accumulator );
+					$this->externalDataRepo->insertBatch($accumulator);
 				}
-				catch( \DBError $e ) {
-					exit( 'Unknown database error occurred.' );
+				catch (\DBError $e) {
+					exit('Unknown database error occurred.');
 				}
 				wfGetLBFactory()->waitForReplication();
 
-				$this->log( "\r\033[K" );
-				$this->log( "$i rows inserted" );
+				$this->log("\r\033[K");
+				$this->log("$i rows inserted");
 
 				$accumulator = array();
 
-				if ( $data === false ) {
+				if ($data === false) {
 					break;
 				}
 			}
@@ -157,16 +157,16 @@ 
 			$accumulator[] = $data;
 		}
 
-		fclose( $csvFile );
+		fclose($csvFile);
 
-		$this->log( "\n" );
+		$this->log("\n");
 	}
 
 	/**
 	 * @param string $text
 	 */
-	private function log( $text ) {
-		if ( !$this->importSettings->isQuiet() ) {
+	private function log($text) {
+		if (!$this->importSettings->isQuiet()) {
 			print $text;
 		}
 	}

includes/CrossCheck/CrossChecker.php

Spacing +56 added lines, -56 removed lines

@@ -95,22 +95,22 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatements( StatementList $entityStatements, StatementList $statements ) {
+	public function crossCheckStatements(StatementList $entityStatements, StatementList $statements) {
 		$statementsOfEntity = $entityStatements->toArray();
 
-		foreach ( $statements as $statement ) {
-			if ( !in_array( $statement, $statementsOfEntity ) ) {
-				throw new InvalidArgumentException( 'All statements in $statements must belong to the entity.' );
+		foreach ($statements as $statement) {
+			if (!in_array($statement, $statementsOfEntity)) {
+				throw new InvalidArgumentException('All statements in $statements must belong to the entity.');
 			}
 		}
 
 		$resultList = new CrossCheckResultList();
-		if ( $statements->count() > 0 ) {
-			$applicableDumps = $this->getApplicableDumps( $entityStatements );
-			foreach ( $applicableDumps as $identifierPropertyId => $dumpMetaInformationList ) {
-				$identifierPropertyId = new PropertyId( $identifierPropertyId );
+		if ($statements->count() > 0) {
+			$applicableDumps = $this->getApplicableDumps($entityStatements);
+			foreach ($applicableDumps as $identifierPropertyId => $dumpMetaInformationList) {
+				$identifierPropertyId = new PropertyId($identifierPropertyId);
 
-				if( $this->isIdentifierProperty( $identifierPropertyId ) ) {
+				if ($this->isIdentifierProperty($identifierPropertyId)) {
 					$resultList->merge(
 						$this->crossCheckStatementsWithIdentifier(
 							$entityStatements,
@@ -133,17 +133,17 @@ 
 	 *
 	 * @return array[]
 	 */
-	private function getApplicableDumps( StatementList $statements ) {
+	private function getApplicableDumps(StatementList $statements) {
 		$applicableDumps = array();
 		$identifierPropertyIds = $statements->getPropertyIds();
 		$dumpMetaInformation = $this->dumpMetaInformationLookup->getWithIdentifierProperties(
 			$identifierPropertyIds
 		);
 
-		foreach ( $dumpMetaInformation as $dump ) {
-			foreach ( $dump->getIdentifierPropertyIds() as $identifierPropertyId ) {
+		foreach ($dumpMetaInformation as $dump) {
+			foreach ($dump->getIdentifierPropertyIds() as $identifierPropertyId) {
 				$serialization = $identifierPropertyId->getSerialization();
-				$applicableDumps[ $serialization ][ $dump->getDumpId() ] = $dump;
+				$applicableDumps[$serialization][$dump->getDumpId()] = $dump;
 			}
 		}
 
@@ -168,36 +168,36 @@ 
 	) {
 		$resultList = new CrossCheckResultList();
 
-		$externalIds = $this->getExternalIds( $entityStatements, $identifierPropertyId );
-		if( !$externalIds ) {
+		$externalIds = $this->getExternalIds($entityStatements, $identifierPropertyId);
+		if (!$externalIds) {
 			return $resultList;
 		}
 
 		$dumpIds = array_map(
-			function ( DumpMetaInformation $dumpMetaInformation ) {
+			function(DumpMetaInformation $dumpMetaInformation) {
 				return $dumpMetaInformation->getDumpId();
 			},
 			$dumpMetaInformationList
 		);
-		$externalData = $this->externalDataRepo->getExternalData( $dumpIds, $externalIds, $statements->getPropertyIds() );
+		$externalData = $this->externalDataRepo->getExternalData($dumpIds, $externalIds, $statements->getPropertyIds());
 
-		foreach ( $externalData as $dumpId => $externalDataPerDump ) {
-			$dumpMetaInformation = $dumpMetaInformationList[ $dumpId ];
+		foreach ($externalData as $dumpId => $externalDataPerDump) {
+			$dumpMetaInformation = $dumpMetaInformationList[$dumpId];
 			$comparativeValueParser = $this->valueParserFactory->newComparativeValueParser(
 				$dumpMetaInformation->getLanguageCode()
 			);
 
-			foreach ( $externalDataPerDump as $externalId => $externalDataPerId ) {
+			foreach ($externalDataPerDump as $externalId => $externalDataPerId) {
 				$externalId = (string)$externalId;
-				foreach ( $externalDataPerId as $propertyId => $externalValues ) {
-					$propertyId = new PropertyId( $propertyId );
+				foreach ($externalDataPerId as $propertyId => $externalValues) {
+					$propertyId = new PropertyId($propertyId);
 					$resultList->merge(
 						$this->crossCheckExternalValues(
 							$dumpMetaInformation,
 							$identifierPropertyId,
 							$externalId,
 							$externalValues,
-							$statements->getByPropertyId( $propertyId ),
+							$statements->getByPropertyId($propertyId),
 							$comparativeValueParser
 						)
 					);
@@ -228,10 +228,10 @@ 
 	) {
 		$resultList = new CrossCheckResultList();
 
-		foreach ( $statements->toArray() as $statement ) {
-			$comparisonResult = $this->compareStatement( $statement, $externalValues, $comparativeValueParser );
+		foreach ($statements->toArray() as $statement) {
+			$comparisonResult = $this->compareStatement($statement, $externalValues, $comparativeValueParser);
 
-			if ( $comparisonResult ) {
+			if ($comparisonResult) {
 				$referencesResult = $this->referenceHandler->checkForReferences(
 					$statement,
 					$identifierPropertyId,
@@ -265,32 +265,32 @@ 
 	 * @return ComparisonResult|bool
 	 */
 	private function compareStatement(
-		Statement $statement,array $externalValues,
+		Statement $statement, array $externalValues,
 		ComparativeValueParser $comparativeValueParser
 	) {
 		$mainSnak = $statement->getMainSnak();
-		if ( $mainSnak instanceof PropertyValueSnak ) {
+		if ($mainSnak instanceof PropertyValueSnak) {
 			$dataValue = $mainSnak->getDataValue();
 
 			$results = array();
-			$comparativeValues = $this->parseExternalValues( $dataValue, $externalValues, $comparativeValueParser );
-			foreach ( $comparativeValues as $comparativeValue ) {
-				$result = $this->dataValueComparer->compare( $dataValue, $comparativeValue );
-				if( $result ) {
+			$comparativeValues = $this->parseExternalValues($dataValue, $externalValues, $comparativeValueParser);
+			foreach ($comparativeValues as $comparativeValue) {
+				$result = $this->dataValueComparer->compare($dataValue, $comparativeValue);
+				if ($result) {
 					$results[] = $result;
 				}
 			}
 
-			if( $results ) {
+			if ($results) {
 				$result = ComparisonResult::STATUS_MISMATCH;
-				if( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
+				if (in_array(ComparisonResult::STATUS_MATCH, $results)) {
 					$result = ComparisonResult::STATUS_MATCH;
 				}
-				elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
+				elseif (in_array(ComparisonResult::STATUS_PARTIAL_MATCH, $results)) {
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 				}
 
-				return new ComparisonResult( $dataValue, $comparativeValues, $result );
+				return new ComparisonResult($dataValue, $comparativeValues, $result);
 			}
 		}
 
@@ -310,14 +310,14 @@ 
 		ComparativeValueParser $comparativeValueParser
 	) {
 		$parsedValues = array();
-		foreach ( $externalValues as $externalValue ) {
+		foreach ($externalValues as $externalValue) {
 			try {
-				$parsedValue = $comparativeValueParser->parse( $externalValue, $dataValue->getType() );
-				if( $parsedValue ) {
+				$parsedValue = $comparativeValueParser->parse($externalValue, $dataValue->getType());
+				if ($parsedValue) {
 					$parsedValues[] = $parsedValue;
 				}
 			}
-			catch( ParseException $e ) {}
+			catch (ParseException $e) {}
 		}
 
 		return $parsedValues;
@@ -331,12 +331,12 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function getExternalIds( StatementList $statements, PropertyId $identifierPropertyId ) {
+	private function getExternalIds(StatementList $statements, PropertyId $identifierPropertyId) {
 		$externalIds = array();
-		$identifierStatements = $statements->getByPropertyId( $identifierPropertyId );
-		$values = $this->getDataValues( $identifierStatements );
-		foreach ( $values as $value ) {
-			if ( $value instanceof StringValue ) {
+		$identifierStatements = $statements->getByPropertyId($identifierPropertyId);
+		$values = $this->getDataValues($identifierStatements);
+		foreach ($values as $value) {
+			if ($value instanceof StringValue) {
 				$externalIds[] = $value->getValue();
 			}
 		}
@@ -348,16 +348,16 @@ 
 	 * @param PropertyId $identifierPropertyId
 	 * @return bool
 	 */
-	private function isIdentifierProperty( PropertyId $identifierPropertyId ) {
+	private function isIdentifierProperty(PropertyId $identifierPropertyId) {
 		global $wgWBQEVInstanceOfPID, $wgWBQEVIdentifierPropertyQID;
 		/** @var Property $property */
-		$property = $this->entityLookup->getEntity( $identifierPropertyId );
-		$instanceOfPropertyId = new PropertyId( $wgWBQEVInstanceOfPID );
-		$statements = $property->getStatements()->getByPropertyId( $instanceOfPropertyId );
-		$values = $this->getDataValues( $statements );
-		foreach ( $values as $value ) {
-			if( $value instanceof EntityIdValue ) {
-				if( $value->getEntityId()->getSerialization() === $wgWBQEVIdentifierPropertyQID ) {
+		$property = $this->entityLookup->getEntity($identifierPropertyId);
+		$instanceOfPropertyId = new PropertyId($wgWBQEVInstanceOfPID);
+		$statements = $property->getStatements()->getByPropertyId($instanceOfPropertyId);
+		$values = $this->getDataValues($statements);
+		foreach ($values as $value) {
+			if ($value instanceof EntityIdValue) {
+				if ($value->getEntityId()->getSerialization() === $wgWBQEVIdentifierPropertyQID) {
 					return true;
 				}
 			}
@@ -372,12 +372,12 @@ 
 	 * @param StatementList $statementList
 	 * @return DataValue[]
 	 */
-	private function getDataValues( StatementList $statementList ){
+	private function getDataValues(StatementList $statementList) {
 		$dataValues = array();
 
-		foreach ( $statementList->toArray() as $statement ) {
+		foreach ($statementList->toArray() as $statement) {
 			$mainSnak = $statement->getMainSnak();
-			if ( $mainSnak instanceof PropertyValueSnak ) {
+			if ($mainSnak instanceof PropertyValueSnak) {
 				$dataValues[] = $mainSnak->getDataValue();
 			}
 		}

includes/CrossCheck/ReferenceChecker.php

Spacing +9 added lines, -9 removed lines

@@ -34,17 +34,17 @@ 
 	 * @throws InvalidArgumentException
 	 * @return ReferenceResult
 	 */
-	public function checkForReferences( Statement $statement, PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+	public function checkForReferences(Statement $statement, PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
+		Assert::parameterType('string', $externalId, '$externalId');
 
-		if ( count( $statement->getReferences() ) === 0 ) {
+		if (count($statement->getReferences()) === 0) {
 			$status = ReferenceResult::STATUS_REFERENCES_MISSING;
 		} else {
 			$status = ReferenceResult::STATUS_REFERENCES_STATED;
 		}
 
-		$externalReference = $this->buildReference( $identifierPropertyId, $externalId, $dumpMetaInformation );
-		return new ReferenceResult( $status, $externalReference );
+		$externalReference = $this->buildReference($identifierPropertyId, $externalId, $dumpMetaInformation);
+		return new ReferenceResult($status, $externalReference);
 	}
 
 	/**
@@ -55,17 +55,17 @@ 
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 * @return Reference
 	 */
-	private function buildReference( PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
+	private function buildReference(PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
 		global $wgWBQEVStatedInPID;
 
 		$sourceItemId = $dumpMetaInformation->getSourceItemId();
 		$statedInAuthoritySnak = new PropertyValueSnak(
-			new PropertyId( $wgWBQEVStatedInPID ),
-			new EntityIdValue( $sourceItemId )
+			new PropertyId($wgWBQEVStatedInPID),
+			new EntityIdValue($sourceItemId)
 		);
 		$authorityWithExternalIdSnak = new PropertyValueSnak(
 			$identifierPropertyId,
-			new StringValue( $externalId )
+			new StringValue($externalId)
 		);
 
 		return new Reference(

WikibaseQualityExternalValidation.php

Spacing +7 added lines, -7 removed lines

@@ -1,10 +1,10 @@ 
 <?php
 
-if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
-	require_once __DIR__ . '/vendor/autoload.php';
+if (is_readable(__DIR__.'/vendor/autoload.php')) {
+	require_once __DIR__.'/vendor/autoload.php';
 }
 
-call_user_func( function () {
+call_user_func(function() {
 	// Set credits
 	$GLOBALS['wgExtensionCredits']['wikibase'][] = array(
 		'path' => __FILE__,
@@ -17,8 +17,8 @@ 
 	);
 
 	// Initialize localization and aliases
-	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__ . '/i18n';
-	$GLOBALS['wgExtensionMessagesFiles']['WikibaseQualityExternalValidationAlias'] = __DIR__ . '/WikibaseQualityExternalValidation.alias.php';
+	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__.'/i18n';
+	$GLOBALS['wgExtensionMessagesFiles']['WikibaseQualityExternalValidationAlias'] = __DIR__.'/WikibaseQualityExternalValidation.alias.php';
 
 	// Initalize hooks for creating database tables
 	$GLOBALS['wgHooks']['LoadExtensionSchemaUpdates'][] = 'WikibaseQualityExternalValidationHooks::onCreateSchema';
@@ -33,8 +33,8 @@ 
 	// Define API modules
 	$GLOBALS['wgAPIModules']['wbqevcrosscheck'] = array(
 		'class' => 'WikibaseQuality\ExternalValidation\Api\RunCrossCheck',
-		'factory' => function( ApiMain $main, $action ) {
-			return \WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState( $main, $action );
+		'factory' => function(ApiMain $main, $action) {
+			return \WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState($main, $action);
 		}
 	);