wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Result/CrossCheckResult.php

Spacing +4 added lines, -4 removed lines

@@ -65,14 +65,14 @@
 	 * @param ReferenceResult $referenceResult
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( PropertyId $propertyId,
+	public function __construct(PropertyId $propertyId,
 								 $claimGuid,
 								 $externalId,
 								 DumpMetaInformation $dumpMetaInformation,
 								 ComparisonResult $comparisonResult,
-								 ReferenceResult $referenceResult ) {
-		Assert::parameterType( 'string', $claimGuid, '$claimGuid' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+								 ReferenceResult $referenceResult) {
+		Assert::parameterType('string', $claimGuid, '$claimGuid');
+		Assert::parameterType('string', $externalId, '$externalId');
 
 		$this->propertyId = $propertyId;
 		$this->claimGuid = $claimGuid;

includes/CrossCheck/Result/ReferenceResult.php

Spacing +7 added lines, -7 removed lines

@@ -36,10 +36,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $status, Reference $reference ) {
+	public function __construct($status, Reference $reference) {
 
 		$this->reference = $reference;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -61,14 +61,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			array( self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED )
+			array(self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED)
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;

includes/CrossCheck/ValueParser/ComparativeValueParser.php

Spacing +9 added lines, -9 removed lines

@@ -38,7 +38,7 @@ 
 		ValueParserFactory $comparativeValueParserFactory,
 		$languageCode
 	) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
+		Assert::parameterType('string', $languageCode, '$languageCode');
 
 		$this->comparativeValueParserFactory = $comparativeValueParserFactory;
 		$this->languageCode = $languageCode;
@@ -52,11 +52,11 @@ 
 	 *
 	 * @return DataValue
 	 */
-	public function parse( $value, $propertyType ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterType( 'string', $propertyType, '$propertyType' );
+	public function parse($value, $propertyType) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterType('string', $propertyType, '$propertyType');
 
-		return $this->getValueParser( $propertyType )->parse( $value );
+		return $this->getValueParser($propertyType)->parse($value);
 	}
 
 	/**
@@ -64,8 +64,8 @@ 
 	 *
 	 * @return ValueParser
 	 */
-	private function getValueParser( $type ) {
-		if( !array_key_exists( $type, $this->valueParsers ) ) {
+	private function getValueParser($type) {
+		if (!array_key_exists($type, $this->valueParsers)) {
 			$parserOptions = $this->getParserOptions();
 			$this->valueParsers[$type] = $this->comparativeValueParserFactory->newParser(
 				$type,
@@ -81,8 +81,8 @@ 
 	 */
 	private function getParserOptions() {
 		$options = new ParserOptions();
-		$options->setOption( 'valuelang', $this->languageCode );
-		$options->setOption( ValueParser::OPT_LANG, $this->languageCode );
+		$options->setOption('valuelang', $this->languageCode);
+		$options->setOption(ValueParser::OPT_LANG, $this->languageCode);
 
 		return $options;
 	}

includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php

Spacing +10 added lines, -10 removed lines

@@ -43,7 +43,7 @@ 
 	) {
 		$dataTypeIds = $dataTypeDefinitions->getTypeIds();
 
-		if ( !in_array( 'monolingualtext', $dataTypeIds ) ) {
+		if (!in_array('monolingualtext', $dataTypeIds)) {
 			throw new InvalidArgumentException(
 				'monolingualtext must be defined in the DataTypeDefinitions.'
 			);
@@ -58,21 +58,21 @@ 
 	 *
 	 * @return MultilingualTextValueParser
 	 */
-	public function newMultilingualTextValueParser( ParserOptions $options = null ) {
+	public function newMultilingualTextValueParser(ParserOptions $options = null) {
 		$options = $options ?: new ParserOptions();
 		$monolingualTextValueParser = $this->getValueParserFactory()->newParser(
 			'monolingualtext',
 			$options
 		);
 
-		return new MultilingualTextValueParser( $monolingualTextValueParser );
+		return new MultilingualTextValueParser($monolingualTextValueParser);
 	}
 
 	/**
 	 * @return StringValueParser
 	 */
 	public function newStringValueParser() {
-		return new StringValueParser( $this->stringNormalizer );
+		return new StringValueParser($this->stringNormalizer);
 	}
 
 	/**
@@ -80,8 +80,8 @@ 
 	 *
 	 * @return ComparativeValueParser
 	 */
-	public function newComparativeValueParser( $languageCode ) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
+	public function newComparativeValueParser($languageCode) {
+		Assert::parameterType('string', $languageCode, '$languageCode');
 
 		return new ComparativeValueParser(
 			$this->getValueParserFactory(),
@@ -100,14 +100,14 @@ 
 	 * @return ValueParserFactory
 	 */
 	private function getValueParserFactory() {
-		if ( $this->valueParserFactory === null ) {
+		if ($this->valueParserFactory === null) {
 			$callbacks = $this->dataTypeDefinitions->getParserFactoryCallbacks();
 
-			$callbacks['string'] = array( $this, 'newStringValueParser' );
-			$callbacks['multilingualtext'] = array( $this, 'newMultilingualTextValueParser' );
+			$callbacks['string'] = array($this, 'newStringValueParser');
+			$callbacks['multilingualtext'] = array($this, 'newMultilingualTextValueParser');
 			$callbacks['wikibase-entityid'] = $callbacks['monolingualtext'];
 
-			$this->valueParserFactory = new ValueParserFactory( $callbacks );
+			$this->valueParserFactory = new ValueParserFactory($callbacks);
 		}
 
 		return $this->valueParserFactory;

includes/CrossCheck/ValueParser/MultilingualTextValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
 	/**
 	 * @param ValueParser $monolingualTextValueParser
 	 */
-	public function __construct( ValueParser $monolingualTextValueParser ) {
+	public function __construct(ValueParser $monolingualTextValueParser) {
 		$this->monolingualTextValueParser = $monolingualTextValueParser;
 	}
 
@@ -32,11 +32,11 @@ 
 	 *
 	 * @return MultilingualTextValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
 		return new MultilingualTextValue(
-			array( $this->monolingualTextValueParser->parse( $value ) )
+			array($this->monolingualTextValueParser->parse($value))
 		);
 	}
 

includes/CrossCheck/ValueParser/StringValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
 	/**
 	 * @param StringNormalizer $stringNormalizer
 	 */
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -28,10 +28,10 @@ 
 	 *
 	 * @return StringValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
-		return new StringValue( $this->stringNormalizer->trimToNFC( $value ) );
+		return new StringValue($this->stringNormalizer->trimToNFC($value));
 	}
 
 }

includes/DumpMetaInformation/DumpMetaInformationStore.php

Spacing +1 added lines, -1 removed lines

@@ -15,6 +15,6 @@
 	 *
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 */
-	public function save( DumpMetaInformation $dumpMetaInformation );
+	public function save(DumpMetaInformation $dumpMetaInformation);
 
 }

includes/ExternalDataRepo.php

Braces +1 added lines, -2 removed lines

@@ -102,8 +102,7 @@
 			$db->begin();
 			$result = $db->insert( self::TABLE_NAME, $accumulator );
 			$db->commit();
-		}
-		catch( DBError $ex ) {
+		} catch( DBError $ex ) {
 			$db->rollback();
 			throw $ex;
 		}

Spacing +31 added lines, -31 removed lines

@@ -24,23 +24,23 @@ 
 	 * @param PropertyId[] $propertyIds
 	 * @return array
 	 */
-	public function getExternalData( array $dumpIds, array $externalIds, array $propertyIds ) {
-		Assert::parameterElementType( 'string', $dumpIds, '$dumpIds' );
-		Assert::parameterElementType( 'string', $externalIds, '$externalIds' );
-		Assert::parameterElementType( PropertyId::class, $propertyIds, '$propertyIds' );
-		Assert::parameter( count( $dumpIds ) > 0, '$dumpIds', '$dumpIds has to contain at least one element.' );
-		Assert::parameter( count( $externalIds ) > 0, '$externalIds', '$externalIds has to contain at least one element.' );
+	public function getExternalData(array $dumpIds, array $externalIds, array $propertyIds) {
+		Assert::parameterElementType('string', $dumpIds, '$dumpIds');
+		Assert::parameterElementType('string', $externalIds, '$externalIds');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
+		Assert::parameter(count($dumpIds) > 0, '$dumpIds', '$dumpIds has to contain at least one element.');
+		Assert::parameter(count($externalIds) > 0, '$externalIds', '$externalIds has to contain at least one element.');
 
 		$conditions = array(
 			'dump_id' => $dumpIds,
 			'external_id' => $externalIds
 		);
-		if ( $propertyIds ) {
+		if ($propertyIds) {
 			$conditions['pid'] = $propertyIds;
 		}
 
 		$externalData = array();
-		$db = wfGetDB( DB_REPLICA );
+		$db = wfGetDB(DB_REPLICA);
 		$result = $db->select(
 			self::TABLE_NAME,
 			array(
@@ -52,7 +52,7 @@ 
 			$conditions
 		);
 
-		foreach ( $result as $row ) {
+		foreach ($result as $row) {
 			$externalData[$row->dump_id][$row->external_id][$row->pid][] = $row->external_value;
 		}
 
@@ -68,13 +68,13 @@ 
 	 * @param string $externalValue
 	 * @return bool
 	 */
-	public function insert( $dumpId, $externalId, PropertyId $propertyId, $externalValue ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
-		Assert::parameterType( 'string', $externalValue, '$externalValue' );
+	public function insert($dumpId, $externalId, PropertyId $propertyId, $externalValue) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		Assert::parameterType('string', $externalId, '$externalId');
+		Assert::parameterType('string', $externalValue, '$externalValue');
 
-		$externalDataBatch = array( func_get_args() );
-		return $this->insertBatch( $externalDataBatch );
+		$externalDataBatch = array(func_get_args());
+		return $this->insertBatch($externalDataBatch);
 	}
 
 	/**
@@ -84,10 +84,10 @@ 
 	 * @throws DBError
 	 * @return bool
 	 */
-	public function insertBatch( array $externalDataBatch ) {
-		$db = wfGetDB( DB_MASTER );
+	public function insertBatch(array $externalDataBatch) {
+		$db = wfGetDB(DB_MASTER);
 		$accumulator = array_map(
-			function ( $externalData ) use ( $db ) {
+			function($externalData) use ($db) {
 				return array(
 					'dump_id' => $externalData[0],
 					'external_id' => $externalData[1],
@@ -100,10 +100,10 @@ 
 
 		try {
 			$db->begin();
-			$result = $db->insert( self::TABLE_NAME, $accumulator );
+			$result = $db->insert(self::TABLE_NAME, $accumulator);
 			$db->commit();
 		}
-		catch( DBError $ex ) {
+		catch (DBError $ex) {
 			$db->rollback();
 			throw $ex;
 		}
@@ -118,21 +118,21 @@ 
 	 * @param int $batchSize
 	 * @throws \DBUnexpectedError
 	 */
-	public function deleteOfDump( $dumpId, $batchSize = 1000 ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		Assert::parameterType( 'integer', $batchSize, 'batchSize' );
+	public function deleteOfDump($dumpId, $batchSize = 1000) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		Assert::parameterType('integer', $batchSize, 'batchSize');
 
-		$db = wfGetDB( DB_MASTER );
-		if ( $db->getType() === 'sqlite' ) {
-			$db->delete( self::TABLE_NAME, array( 'dump_id' => $dumpId ) );
+		$db = wfGetDB(DB_MASTER);
+		if ($db->getType() === 'sqlite') {
+			$db->delete(self::TABLE_NAME, array('dump_id' => $dumpId));
 		} else {
 			do {
-				$db->commit( __METHOD__, 'flush' );
+				$db->commit(__METHOD__, 'flush');
 				wfGetLBFactory()->waitForReplication();
-				$table = $db->tableName( self::TABLE_NAME );
-				$condition = 'dump_id = ' . $db->addQuotes( $dumpId );
-				$db->query( sprintf( 'DELETE FROM %s WHERE %s LIMIT %d', $table, $condition, $batchSize ) );
-			} while ( $db->affectedRows() > 0 );
+				$table = $db->tableName(self::TABLE_NAME);
+				$condition = 'dump_id = '.$db->addQuotes($dumpId);
+				$db->query(sprintf('DELETE FROM %s WHERE %s LIMIT %d', $table, $condition, $batchSize));
+			} while ($db->affectedRows() > 0);
 		}
 	}
 

includes/ExternalValidationServices.php

Spacing +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @fixme inject specific things needed here instead of the WikibaseRepo factory. (T112105)
 	 */
-	public function __construct( WikibaseRepo $wikibaseRepo ) {
+	public function __construct(WikibaseRepo $wikibaseRepo) {
 		$this->wikibaseRepo = $wikibaseRepo;
 	}
 
@@ -88,7 +88,7 @@ 
 		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 
-			$instance = new self( $wikibaseRepo );
+			$instance = new self($wikibaseRepo);
 		}
 
 		return $instance;