wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Comparer/MultilingualTextValueComparer.php

Spacing +11 added lines, -11 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -31,9 +31,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -43,21 +43,21 @@ 
 
 		$texts = $value->getTexts();
 		$comparativeTexts = $comparativeValue->getTexts();
-		$commonLanguages = array_intersect( array_keys( $texts ), array_keys( $comparativeTexts ) );
+		$commonLanguages = array_intersect(array_keys($texts), array_keys($comparativeTexts));
 
-		if ( $commonLanguages ) {
+		if ($commonLanguages) {
 			$totalResult = ComparisonResult::STATUS_MISMATCH;
 
-			foreach ( $commonLanguages as $language ) {
+			foreach ($commonLanguages as $language) {
 				$monolingualText = $texts[$language];
 				$comparativeMonolingualText = $comparativeTexts[$language];
 
-				$result = $this->stringComparer->compare( $monolingualText->getText(), $comparativeMonolingualText->getText() );
-				if ( $result !== ComparisonResult::STATUS_MISMATCH ) {
+				$result = $this->stringComparer->compare($monolingualText->getText(), $comparativeMonolingualText->getText());
+				if ($result !== ComparisonResult::STATUS_MISMATCH) {
 					$totalResult = $result;
 
 					// FIXME: This reports a partial match in a single language as a full match!
-					if ( $result === ComparisonResult::STATUS_MATCH ) {
+					if ($result === ComparisonResult::STATUS_MATCH) {
 						break;
 					}
 				}
@@ -76,7 +76,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MultilingualTextValue && $comparativeValue instanceof MultilingualTextValue;
 	}
 

includes/CrossCheck/Comparer/StringComparer.php

Spacing +40 added lines, -40 removed lines

@@ -22,7 +22,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -33,16 +33,16 @@ 
 	 * @param string $comparativeValue
 	 * @return string
 	 */
-	public function compare( $value, $comparativeValue ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterType( 'string', $comparativeValue, '$comparativeValue' );
+	public function compare($value, $comparativeValue) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterType('string', $comparativeValue, '$comparativeValue');
 
-		$value = $this->cleanDataString( $value );
-		$comparativeValue = $this->cleanDataString( $comparativeValue );
+		$value = $this->cleanDataString($value);
+		$comparativeValue = $this->cleanDataString($comparativeValue);
 
-		if ( $value === $comparativeValue ) {
+		if ($value === $comparativeValue) {
 			return ComparisonResult::STATUS_MATCH;
-		} elseif ( $this->checkSimilarity( $value, $comparativeValue ) ) {
+		} elseif ($this->checkSimilarity($value, $comparativeValue)) {
 			return ComparisonResult::STATUS_PARTIAL_MATCH;
 		} else {
 			return ComparisonResult::STATUS_MISMATCH;
@@ -56,19 +56,19 @@ 
 	 * @param array $comparativeValues
 	 * @return string
 	 */
-	public function compareWithArray( $value, array $comparativeValues ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterElementType( 'string', $comparativeValues, '$comparativeValues' );
+	public function compareWithArray($value, array $comparativeValues) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterElementType('string', $comparativeValues, '$comparativeValues');
 
-		$value = $this->cleanDataString( $value );
-		$comparativeValues = $this->cleanDataArray( $comparativeValues );
+		$value = $this->cleanDataString($value);
+		$comparativeValues = $this->cleanDataArray($comparativeValues);
 
-		if ( in_array( $value, $comparativeValues ) ) {
+		if (in_array($value, $comparativeValues)) {
 			return ComparisonResult::STATUS_MATCH;
 		}
 
-		foreach ( $comparativeValues as $comparativeValue ) {
-			if ( $this->checkSimilarity( $comparativeValue, $value ) ) {
+		foreach ($comparativeValues as $comparativeValue) {
+			if ($this->checkSimilarity($comparativeValue, $value)) {
 				return ComparisonResult::STATUS_PARTIAL_MATCH;
 			}
 		}
@@ -83,11 +83,11 @@ 
 	 * @param string $comparativeValue
 	 * @return bool
 	 */
-	private function checkSimilarity( $value, $comparativeValue ) {
+	private function checkSimilarity($value, $comparativeValue) {
 		return
-			$this->percentagePrefixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
-			$this->percentageSuffixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
-			$this->percentageLevenshteinDistance( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD;
+			$this->percentagePrefixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
+			$this->percentageSuffixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
+			$this->percentageLevenshteinDistance($value, $comparativeValue) > self::SIMILARITY_THRESHOLD;
 	}
 
 	/**
@@ -97,10 +97,10 @@ 
 	 *
 	 * @return string
 	 */
-	private function cleanDataString( $value ) {
-		$value = $this->stringNormalizer->trimToNFC( $value );
+	private function cleanDataString($value) {
+		$value = $this->stringNormalizer->trimToNFC($value);
 
-		return mb_strtolower( $value );
+		return mb_strtolower($value);
 	}
 
 	/**
@@ -110,10 +110,10 @@ 
 	 *
 	 * @return array
 	 */
-	private function cleanDataArray( array $array ) {
+	private function cleanDataArray(array $array) {
 
 		return array_map(
-			[ $this, 'cleanDataString' ],
+			[$this, 'cleanDataString'],
 			$array );
 	}
 
@@ -125,19 +125,19 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentagePrefixSimilarity( $value, $comparativeValue ) {
+	private function percentagePrefixSimilarity($value, $comparativeValue) {
 		$prefixLength = 0; // common prefix length
-		$localLength = strlen( $value );
-		$externalLength = strlen( $comparativeValue );
-		while ( $prefixLength < min( $localLength, $externalLength ) ) {
+		$localLength = strlen($value);
+		$externalLength = strlen($comparativeValue);
+		while ($prefixLength < min($localLength, $externalLength)) {
 			$c = $value[$prefixLength];
-			if ( $externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c ) {
+			if ($externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c) {
 				break;
 			}
 			$prefixLength++;
 		}
 
-		return $prefixLength / max( $localLength, $externalLength );
+		return $prefixLength / max($localLength, $externalLength);
 	}
 
 	/**
@@ -148,19 +148,19 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentageSuffixSimilarity( $value, $comparativeValue ) {
+	private function percentageSuffixSimilarity($value, $comparativeValue) {
 		$suffixLength = 0; // common suffix length
-		$localLength = strlen( $value );
-		$externalLength = strlen( $comparativeValue );
-		while ( $suffixLength < min( $localLength, $externalLength ) ) {
+		$localLength = strlen($value);
+		$externalLength = strlen($comparativeValue);
+		while ($suffixLength < min($localLength, $externalLength)) {
 			$c = $value[$localLength - 1 - $suffixLength];
-			if ( $externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c ) {
+			if ($externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c) {
 				break;
 			}
 			$suffixLength++;
 		}
 
-		return $suffixLength / max( $localLength, $externalLength );
+		return $suffixLength / max($localLength, $externalLength);
 	}
 
 	/**
@@ -171,9 +171,9 @@ 
 	 *
 	 * @return float
 	 */
-	private function percentageLevenshteinDistance( $value, $comparativeValue ) {
-		$distance = levenshtein( $value, $comparativeValue );
-		$percentage = 1.0 - $distance / max( strlen( $value ), strlen( $comparativeValue ) );
+	private function percentageLevenshteinDistance($value, $comparativeValue) {
+		$distance = levenshtein($value, $comparativeValue);
+		$percentage = 1.0 - $distance / max(strlen($value), strlen($comparativeValue));
 
 		return $percentage;
 	}

includes/CrossCheck/Comparer/DataValueComparerFactory.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( TermIndex $termIndex, StringNormalizer $stringNormalizer ) {
+	public function __construct(TermIndex $termIndex, StringNormalizer $stringNormalizer) {
 		$this->termIndex = $termIndex;
 		$this->stringNormalizer = $stringNormalizer;
 	}
@@ -63,7 +63,7 @@ 
 	 * @return StringComparer
 	 */
 	private function newStringComparer() {
-		return new StringComparer( $this->stringNormalizer );
+		return new StringComparer($this->stringNormalizer);
 	}
 
 	/**

includes/CrossCheck/ValueParser/StringValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -29,10 +29,10 @@ 
 	 *
 	 * @return StringValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
-		return new StringValue( $this->stringNormalizer->trimToNFC( $value ) );
+		return new StringValue($this->stringNormalizer->trimToNFC($value));
 	}
 
 }

includes/CrossCheck/ValueParser/MultilingualTextValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
 	 */
 	private $monolingualTextValueParser;
 
-	public function __construct( ValueParser $monolingualTextValueParser ) {
+	public function __construct(ValueParser $monolingualTextValueParser) {
 		$this->monolingualTextValueParser = $monolingualTextValueParser;
 	}
 
@@ -28,11 +28,11 @@ 
 	 *
 	 * @return MultilingualTextValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
 		return new MultilingualTextValue(
-			[ $this->monolingualTextValueParser->parse( $value ) ]
+			[$this->monolingualTextValueParser->parse($value)]
 		);
 	}
 

includes/Serializer/SerializerFactory.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
 	 */
 	private $referenceSerializer;
 
-	public function __construct( Serializer $dataValueSerializer, Serializer $referenceSerializer ) {
+	public function __construct(Serializer $dataValueSerializer, Serializer $referenceSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 		$this->referenceSerializer = $referenceSerializer;
 	}
@@ -42,7 +42,7 @@ 
 	 * @return Serializer
 	 */
 	public function newComparisonResultSerializer() {
-		return new ComparisonResultSerializer( $this->dataValueSerializer );
+		return new ComparisonResultSerializer($this->dataValueSerializer);
 	}
 
 	/**
@@ -73,7 +73,7 @@ 
 	 * @return Serializer
 	 */
 	public function newReferenceResultSerializer() {
-		return new ReferenceResultSerializer( $this->referenceSerializer );
+		return new ReferenceResultSerializer($this->referenceSerializer);
 	}
 
 }

includes/Serializer/ComparisonResultSerializer.php

Spacing +10 added lines, -10 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $dataValueSerializer;
 
-	public function __construct( Serializer $dataValueSerializer ) {
+	public function __construct(Serializer $dataValueSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 	}
 
@@ -29,7 +29,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ComparisonResult;
 	}
 
@@ -41,29 +41,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ComparisonResult $comparisonResult ) {
+	private function getSerialized(ComparisonResult $comparisonResult) {
 		$dataValueSerializer = $this->dataValueSerializer;
 		$externalValues = array_map(
-			function ( $dataValue ) use ( $dataValueSerializer ) {
-				return $dataValueSerializer->serialize( $dataValue );
+			function($dataValue) use ($dataValueSerializer) {
+				return $dataValueSerializer->serialize($dataValue);
 			},
 			$comparisonResult->getExternalValues()
 		);
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
+		$this->setIndexedTagName($externalValues, 'dataValue');
 
 		return [
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
 			'externalValues' => $externalValues,
 			'result' => $comparisonResult->getStatus()
 		];

includes/Serializer/CrossCheckResultListSerializer.php

Spacing +11 added lines, -11 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $crossCheckResultSerializer;
 
-	public function __construct( Serializer $crossCheckResultSerializer ) {
+	public function __construct(Serializer $crossCheckResultSerializer) {
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
 	}
 
@@ -29,7 +29,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResultList;
 	}
 
@@ -41,29 +41,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResultList $resultList ) {
+	private function getSerialized(CrossCheckResultList $resultList) {
 		$serialization = [];
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
+		$this->setKeyAttributeName($serialization, 'property', 'id');
 
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
+		foreach ($resultList->getPropertyIds() as $propertyId) {
 			$id = $propertyId->getSerialization();
 			$resultSerialization = [];
 
-			$this->setIndexedTagName( $resultSerialization, 'result' );
+			$this->setIndexedTagName($resultSerialization, 'result');
 
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
 			}
 
 			$serialization[$id] = $resultSerialization;

includes/Serializer/ReferenceResultSerializer.php

Spacing +7 added lines, -7 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $referenceSerializer;
 
-	public function __construct( Serializer $referenceSerializer ) {
+	public function __construct(Serializer $referenceSerializer) {
 		$this->referenceSerializer = $referenceSerializer;
 	}
 
@@ -29,7 +29,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ReferenceResult;
 	}
 
@@ -41,20 +41,20 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ReferenceResult $referenceResult ) {
+	private function getSerialized(ReferenceResult $referenceResult) {
 		return [
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
 			'status' => $referenceResult->getStatus()
 		];
 	}