wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Comparer/DispatchingDataValueComparer.php

Spacing +12 added lines, -12 removed lines

@@ -20,8 +20,8 @@ 
 	/**
 	 * @param DataValueComparer[] $dataValueComparers
 	 */
-	public function __construct( array $dataValueComparers = [] ) {
-		$this->assertAreDataValueComparer( $dataValueComparers );
+	public function __construct(array $dataValueComparers = []) {
+		$this->assertAreDataValueComparer($dataValueComparers);
 		$this->dataValueComparers = $dataValueComparers;
 	}
 
@@ -30,9 +30,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	protected function assertAreDataValueComparer( array $dataValueComparers ) {
-		foreach ( $dataValueComparers as $dataValueComparer ) {
-			if ( !is_object( $dataValueComparer ) || !( $dataValueComparer instanceof DataValueComparer ) ) {
+	protected function assertAreDataValueComparer(array $dataValueComparers) {
+		foreach ($dataValueComparers as $dataValueComparer) {
+			if (!is_object($dataValueComparer) || !($dataValueComparer instanceof DataValueComparer)) {
 				throw new InvalidArgumentException(
 					'All $dataValueComparers need to implement the DataValueComparer interface'
 				);
@@ -48,9 +48,9 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
+		foreach ($this->dataValueComparers as $dataValueComparer) {
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
 				return true;
 			}
 		}
@@ -67,10 +67,10 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
-				return $dataValueComparer->compare( $value, $comparativeValue );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		foreach ($this->dataValueComparers as $dataValueComparer) {
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
+				return $dataValueComparer->compare($value, $comparativeValue);
 			}
 		}
 

includes/DumpMetaInformation/DumpMetaInformation.php

Spacing +29 added lines, -29 removed lines

@@ -99,13 +99,13 @@ 
 			'$identifierPropertyIds'
 		);
 
-		$this->setDumpId( $dumpId );
+		$this->setDumpId($dumpId);
 		$this->sourceItemId = $sourceItemId;
 		$this->identifierPropertyIds = $identifierPropertyIds;
-		$this->setImportDate( $importDate );
-		$this->setLanguageCode( $languageCode );
-		$this->setSourceUrl( $sourceUrl );
-		$this->setSize( $size );
+		$this->setImportDate($importDate);
+		$this->setLanguageCode($languageCode);
+		$this->setSourceUrl($sourceUrl);
+		$this->setSize($size);
 		$this->licenseItemId = $licenseItemId;
 	}
 
@@ -170,11 +170,11 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setDumpId( $dumpId ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		$length = strlen( $dumpId );
-		if ( $length < 1 || $length > 25 ) {
-			throw new InvalidArgumentException( '$dumpId must be between 1 and 25 characters.' );
+	private function setDumpId($dumpId) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		$length = strlen($dumpId);
+		if ($length < 1 || $length > 25) {
+			throw new InvalidArgumentException('$dumpId must be between 1 and 25 characters.');
 		}
 
 		$this->dumpId = $dumpId;
@@ -185,10 +185,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setLanguageCode( $languageCode ) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
-		if ( !Language::isValidCode( $languageCode ) ) {
-			throw new InvalidArgumentException( '$languageCode is not valid.' );
+	private function setLanguageCode($languageCode) {
+		Assert::parameterType('string', $languageCode, '$languageCode');
+		if (!Language::isValidCode($languageCode)) {
+			throw new InvalidArgumentException('$languageCode is not valid.');
 		}
 
 		$this->languageCode = $languageCode;
@@ -199,12 +199,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setImportDate( $importDate ) {
-		Assert::parameterType( 'string', $importDate, '$importDate' );
+	private function setImportDate($importDate) {
+		Assert::parameterType('string', $importDate, '$importDate');
 
-		$timestamp = wfTimestamp( TS_MW, $importDate );
-		if ( !$timestamp ) {
-			throw new InvalidArgumentException( '$updatedAt has invalid timestamp format.' );
+		$timestamp = wfTimestamp(TS_MW, $importDate);
+		if (!$timestamp) {
+			throw new InvalidArgumentException('$updatedAt has invalid timestamp format.');
 		}
 
 		$this->importDate = $importDate;
@@ -215,13 +215,13 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSourceUrl( $sourceUrl ) {
-		Assert::parameterType( 'string', $sourceUrl, '$sourceUrl' );
-		if ( strlen( $sourceUrl ) > 300 ) {
-			throw new InvalidArgumentException( '$sourceUrl must not be longer than 300 characters.' );
+	private function setSourceUrl($sourceUrl) {
+		Assert::parameterType('string', $sourceUrl, '$sourceUrl');
+		if (strlen($sourceUrl) > 300) {
+			throw new InvalidArgumentException('$sourceUrl must not be longer than 300 characters.');
 		}
-		if ( !filter_var( $sourceUrl, FILTER_VALIDATE_URL ) ) {
-			throw new InvalidArgumentException( '$sourceUrl is not a valid url.' );
+		if (!filter_var($sourceUrl, FILTER_VALIDATE_URL)) {
+			throw new InvalidArgumentException('$sourceUrl is not a valid url.');
 		}
 
 		$this->sourceUrl = $sourceUrl;
@@ -232,10 +232,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSize( $size ) {
-		Assert::parameterType( 'integer', $size, '$size' );
-		if ( $size <= 0 ) {
-			throw new InvalidArgumentException( '$size must be positive integer.' );
+	private function setSize($size) {
+		Assert::parameterType('integer', $size, '$size');
+		if ($size <= 0) {
+			throw new InvalidArgumentException('$size must be positive integer.');
 		}
 
 		$this->size = $size;

includes/CrossCheck/Result/CrossCheckResult.php

Spacing +2 added lines, -2 removed lines

@@ -73,8 +73,8 @@
 		ComparisonResult $comparisonResult,
 		ReferenceResult $referenceResult
 	) {
-		Assert::parameterType( 'string', $claimGuid, '$claimGuid' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+		Assert::parameterType('string', $claimGuid, '$claimGuid');
+		Assert::parameterType('string', $externalId, '$externalId');
 
 		$this->propertyId = $propertyId;
 		$this->claimGuid = $claimGuid;

includes/ExternalValidationServices.php

Spacing +12 added lines, -12 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @fixme inject specific things needed here instead of the WikibaseRepo factory. (T112105)
 	 */
-	public function __construct( WikibaseRepo $wikibaseRepo ) {
+	public function __construct(WikibaseRepo $wikibaseRepo) {
 		$this->wikibaseRepo = $wikibaseRepo;
 	}
 
@@ -85,10 +85,10 @@ 
 	public static function getDefaultInstance() {
 		static $instance = null;
 
-		if ( $instance === null ) {
+		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 
-			$instance = new self( $wikibaseRepo );
+			$instance = new self($wikibaseRepo);
 		}
 
 		return $instance;
@@ -98,7 +98,7 @@ 
 	 * @return CrossChecker
 	 */
 	public function getCrossChecker() {
-		if ( $this->crossChecker === null ) {
+		if ($this->crossChecker === null) {
 			$this->crossChecker = new CrossChecker(
 				$this->wikibaseRepo->getEntityLookup(),
 				$this->getComparativeValueParserFactory(),
@@ -116,7 +116,7 @@ 
 	 * @return CrossCheckInteractor
 	 */
 	public function getCrossCheckInteractor() {
-		if ( $this->crossCheckInteractor === null ) {
+		if ($this->crossCheckInteractor === null) {
 			$this->crossCheckInteractor = new CrossCheckInteractor(
 				$this->wikibaseRepo->getEntityLookup(),
 				$this->wikibaseRepo->getStatementGuidParser(),
@@ -131,7 +131,7 @@ 
 	 * @return ComparativeValueParserFactory
 	 */
 	public function getComparativeValueParserFactory() {
-		if ( $this->comparativeValueParserFactory === null ) {
+		if ($this->comparativeValueParserFactory === null) {
 			$this->comparativeValueParserFactory = new ComparativeValueParserFactory(
 				$this->wikibaseRepo->getDataTypeDefinitions(),
 				new StringNormalizer()
@@ -145,7 +145,7 @@ 
 	 * @return DataValueComparerFactory
 	 */
 	public function getDataValueComparerFactory() {
-		if ( $this->dataValueComparerFactory === null ) {
+		if ($this->dataValueComparerFactory === null) {
 			$this->dataValueComparerFactory = new DataValueComparerFactory(
 				$this->wikibaseRepo->getStore()->getTermIndex(),
 				$this->wikibaseRepo->getStringNormalizer()
@@ -159,7 +159,7 @@ 
 	 * @return DumpMetaInformationLookup
 	 */
 	public function getDumpMetaInformationLookup() {
-		if ( $this->dumpMetaInformationLookup === null ) {
+		if ($this->dumpMetaInformationLookup === null) {
 			$this->dumpMetaInformationLookup = new SqlDumpMetaInformationRepo();
 		}
 
@@ -170,7 +170,7 @@ 
 	 * @return DumpMetaInformationStore
 	 */
 	public function getDumpMetaInformationStore() {
-		if ( $this->dumpMetaInformationStore === null ) {
+		if ($this->dumpMetaInformationStore === null) {
 			$this->dumpMetaInformationStore = new SqlDumpMetaInformationRepo();
 		}
 
@@ -181,7 +181,7 @@ 
 	 * @return ExternalDataRepo
 	 */
 	public function getExternalDataRepo() {
-		if ( $this->externalDataRepo === null ) {
+		if ($this->externalDataRepo === null) {
 			$this->externalDataRepo = new ExternalDataRepo();
 		}
 
@@ -192,9 +192,9 @@ 
 	 * @return SerializerFactory
 	 */
 	public function getSerializerFactory() {
-		if ( $this->serializerFactory === null ) {
+		if ($this->serializerFactory === null) {
 			$dataValueSerializer = new DataValueSerializer();
-			$dataModelSerializerFactory = new \Wikibase\DataModel\SerializerFactory( $dataValueSerializer );
+			$dataModelSerializerFactory = new \Wikibase\DataModel\SerializerFactory($dataValueSerializer);
 			$this->serializerFactory = new SerializerFactory(
 				$dataValueSerializer,
 				$dataModelSerializerFactory->newReferenceSerializer()

api/RunCrossCheck.php

Spacing +31 added lines, -31 removed lines

@@ -65,7 +65,7 @@ 
 	 *
 	 * @return self
 	 */
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
 		$repo = WikibaseRepo::getDefaultInstance();
 		$externalValidationServices = ExternalValidationServices::getDefaultInstance();
 
@@ -77,7 +77,7 @@ 
 			$repo->getStatementGuidValidator(),
 			$externalValidationServices->getCrossCheckInteractor(),
 			$externalValidationServices->getSerializerFactory(),
-			$repo->getApiHelperFactory( RequestContext::getMain() )
+			$repo->getApiHelperFactory(RequestContext::getMain())
 		);
 	}
 
@@ -101,14 +101,14 @@ 
 		SerializerFactory $serializerFactory,
 		ApiHelperFactory $apiHelperFactory
 	) {
-		parent::__construct( $main, $name, $prefix );
+		parent::__construct($main, $name, $prefix);
 
 		$this->entityIdParser = $entityIdParser;
 		$this->statementGuidValidator = $statementGuidValidator;
 		$this->crossCheckInteractor = $crossCheckInteractor;
 		$this->serializerFactory = $serializerFactory;
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
 	}
 
 	/**
@@ -117,34 +117,34 @@ 
 	public function execute() {
 		$params = $this->extractRequestParams();
 
-		if ( $params['entities'] && $params['claims'] ) {
+		if ($params['entities'] && $params['claims']) {
 			$this->errorReporter->dieError(
 				'Either provide the ids of entities or ids of claims, that should be cross-checked.',
 				'param-invalid'
 			);
 			throw new LogicException();
-		} elseif ( $params['entities'] ) {
-			$entityIds = $this->parseEntityIds( $params['entities'] );
-			if ( $params['properties'] ) {
-				$propertyIds = $this->parseEntityIds( $params['properties'] );
-				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIdWithProperties( $entityIds, $propertyIds );
+		} elseif ($params['entities']) {
+			$entityIds = $this->parseEntityIds($params['entities']);
+			if ($params['properties']) {
+				$propertyIds = $this->parseEntityIds($params['properties']);
+				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIdWithProperties($entityIds, $propertyIds);
 			} else {
-				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIds( $entityIds );
+				$resultLists = $this->crossCheckInteractor->crossCheckEntitiesByIds($entityIds);
 			}
-		} elseif ( $params['claims'] ) {
+		} elseif ($params['claims']) {
 			$guids = $params['claims'];
-			$this->assertAreValidClaimGuids( $guids );
-			$resultLists = $this->crossCheckInteractor->crossCheckStatementsByGuids( $guids );
+			$this->assertAreValidClaimGuids($guids);
+			$resultLists = $this->crossCheckInteractor->crossCheckStatementsByGuids($guids);
 		} else {
 			$this->errorReporter->dieWithError(
-				[ 'wikibase-api-param-missing', 'entities|claims' ],
+				['wikibase-api-param-missing', 'entities|claims'],
 				'param-missing'
 			);
 			throw new LogicException();
 		}
 
 		// Print result lists
-		$this->writeResultOutput( $resultLists );
+		$this->writeResultOutput($resultLists);
 	}
 
 	/**
@@ -152,9 +152,9 @@ 
 	 *
 	 * @return EntityId[]
 	 */
-	private function parseEntityIds( array $entityIds ) {
+	private function parseEntityIds(array $entityIds) {
 		return array_map(
-			[ $this->entityIdParser, 'parse' ],
+			[$this->entityIdParser, 'parse'],
 			$entityIds
 		);
 	}
@@ -162,10 +162,10 @@ 
 	/**
 	 * @param string[] $guids
 	 */
-	private function assertAreValidClaimGuids( array $guids ) {
-		foreach ( $guids as $guid ) {
-			if ( $this->statementGuidValidator->validateFormat( $guid ) === false ) {
-				$this->errorReporter->dieError( 'Invalid claim guid.', 'invalid-guid' );
+	private function assertAreValidClaimGuids(array $guids) {
+		foreach ($guids as $guid) {
+			if ($this->statementGuidValidator->validateFormat($guid) === false) {
+				$this->errorReporter->dieError('Invalid claim guid.', 'invalid-guid');
 			}
 		}
 	}
@@ -177,13 +177,13 @@ 
 	 *
 	 * @return array
 	 */
-	private function writeResultOutput( array $resultLists ) {
+	private function writeResultOutput(array $resultLists) {
 		$serializer = $this->serializerFactory->newCrossCheckResultListSerializer();
 
 		$output = [];
-		foreach ( $resultLists as $entityId => $resultList ) {
-			if ( $resultList ) {
-				$serializedResultList = $serializer->serialize( $resultList );
+		foreach ($resultLists as $entityId => $resultList) {
+			if ($resultList) {
+				$serializedResultList = $serializer->serialize($resultList);
 
 				$output[$entityId] = $serializedResultList;
 			} else {
@@ -193,10 +193,10 @@ 
 			}
 		}
 
-		$this->getResult()->setIndexedTagName( $output, 'entity' );
-		$this->getResult()->setArrayType( $output, 'kvp', 'id' );
-		$this->getResult()->addValue( null, 'results', $output );
-		$this->resultBuilder->markSuccess( 1 );
+		$this->getResult()->setIndexedTagName($output, 'entity');
+		$this->getResult()->setArrayType($output, 'kvp', 'id');
+		$this->getResult()->addValue(null, 'results', $output);
+		$this->resultBuilder->markSuccess(1);
 	}
 
 	/**

WikibaseQualityExternalValidation.php

Spacing +7 added lines, -7 removed lines

@@ -1,10 +1,10 @@ 
 <?php
 
-if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
-	require_once __DIR__ . '/vendor/autoload.php';
+if (is_readable(__DIR__.'/vendor/autoload.php')) {
+	require_once __DIR__.'/vendor/autoload.php';
 }
 
-call_user_func( function () {
+call_user_func(function() {
 	// Set credits
 	$GLOBALS['wgExtensionCredits']['wikibase'][] = [
 		'path' => __FILE__,
@@ -17,9 +17,9 @@ 
 	];
 
 	// Initialize localization and aliases
-	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__ . '/i18n';
+	$GLOBALS['wgMessagesDirs']['WikibaseQualityExternalValidation'] = __DIR__.'/i18n';
 	$GLOBALS['wgExtensionMessagesFiles']['WikibaseQualityExternalValidationAlias'] =
-		__DIR__ . '/WikibaseQualityExternalValidation.alias.php';
+		__DIR__.'/WikibaseQualityExternalValidation.alias.php';
 
 	// Initalize hooks for creating database tables
 	$GLOBALS['wgHooks']['LoadExtensionSchemaUpdates'][] =
@@ -38,8 +38,8 @@ 
 	// Define API modules
 	$GLOBALS['wgAPIModules']['wbqevcrosscheck'] = [
 		'class' => WikibaseQuality\ExternalValidation\Api\RunCrossCheck::class,
-		'factory' => function( ApiMain $main, $action ) {
-			return WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState( $main, $action );
+		'factory' => function(ApiMain $main, $action) {
+			return WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState($main, $action);
 		}
 	];
 

includes/CrossCheck/CrossCheckInteractor.php

Spacing +62 added lines, -62 removed lines

@@ -37,7 +37,7 @@ 
 	 */
 	private $crossChecker;
 
-	public function __construct( EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker ) {
+	public function __construct(EntityLookup $entityLookup, StatementGuidParser $statementGuidParser, CrossChecker $crossChecker) {
 		$this->entityLookup = $entityLookup;
 		$this->statementGuidParser = $statementGuidParser;
 		$this->crossChecker = $crossChecker;
@@ -50,11 +50,11 @@ 
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	public function crossCheckEntityById( EntityId $entityId ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	public function crossCheckEntityById(EntityId $entityId) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatements( $entity->getStatements() );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatements($entity->getStatements());
 		}
 
 		return null;
@@ -67,12 +67,12 @@ 
 	 *
 	 * @return CrossCheckResultList[]
 	 */
-	public function crossCheckEntitiesByIds( array $entityIds ) {
-		Assert::parameterElementType( EntityId::class,  $entityIds, '$entityIds' );
+	public function crossCheckEntitiesByIds(array $entityIds) {
+		Assert::parameterElementType(EntityId::class, $entityIds, '$entityIds');
 
 		$results = [];
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityById( $entityId );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityById($entityId);
 		}
 
 		return $results;
@@ -85,8 +85,8 @@ 
 	 *
 	 * @return CrossCheckResultList
 	 */
-	public function crossCheckStatements( StatementList $statements ) {
-		return $this->crossChecker->crossCheckStatements( $statements, $statements );
+	public function crossCheckStatements(StatementList $statements) {
+		return $this->crossChecker->crossCheckStatements($statements, $statements);
 	}
 
 	/**
@@ -97,14 +97,14 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntities( array $entities ) {
-		Assert::parameterElementType( EntityDocument::class,  $entities, '$entities' );
+	public function crossCheckEntities(array $entities) {
+		Assert::parameterElementType(EntityDocument::class, $entities, '$entities');
 
 		$results = [];
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
-				$results[$entityId] = $this->crossCheckStatements( $entity->getStatements() );
+			if ($entity instanceof StatementListProvider) {
+				$results[$entityId] = $this->crossCheckStatements($entity->getStatements());
 			}
 		}
 
@@ -120,13 +120,13 @@ 
 	 * @return CrossCheckResultList|null
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntityByIdWithProperties( EntityId $entityId, array $propertyIds ) {
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntityByIdWithProperties(EntityId $entityId, array $propertyIds) {
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
-		$entity = $this->entityLookup->getEntity( $entityId );
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
-			return $this->crossCheckStatementsWithProperties( $entity->getStatements(), $propertyIds );
+		if ($entity instanceof StatementListProvider) {
+			return $this->crossCheckStatementsWithProperties($entity->getStatements(), $propertyIds);
 		}
 
 		return null;
@@ -141,13 +141,13 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesByIdWithProperties( array $entityIds, array $propertyIds ) {
-		Assert::parameterElementType( EntityId::class,  $entityIds, '$entityIds' );
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesByIdWithProperties(array $entityIds, array $propertyIds) {
+		Assert::parameterElementType(EntityId::class, $entityIds, '$entityIds');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$results = [];
-		foreach ( $entityIds as $entityId ) {
-			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties( $entityId, $propertyIds );
+		foreach ($entityIds as $entityId) {
+			$results[$entityId->getSerialization()] = $this->crossCheckEntityByIdWithProperties($entityId, $propertyIds);
 		}
 
 		return $results;
@@ -162,17 +162,17 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsWithProperties( StatementList $entityStatements, array $propertyIds ) {
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckStatementsWithProperties(StatementList $entityStatements, array $propertyIds) {
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$statements = new StatementList();
-		foreach ( $entityStatements->toArray() as $statement ) {
-			if ( in_array( $statement->getPropertyId(), $propertyIds ) ) {
-				$statements->addStatement( $statement );
+		foreach ($entityStatements->toArray() as $statement) {
+			if (in_array($statement->getPropertyId(), $propertyIds)) {
+				$statements->addStatement($statement);
 			}
 		}
 
-		return $this->crossChecker->crossCheckStatements( $entityStatements, $statements );
+		return $this->crossChecker->crossCheckStatements($entityStatements, $statements);
 	}
 
 	/**
@@ -184,14 +184,14 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckEntitiesWithProperties( array $entities, array $propertyIds ) {
-		Assert::parameterElementType( EntityDocument::class,  $entities, '$entities' );
-		Assert::parameterElementType( PropertyId::class,  $propertyIds, '$propertyIds' );
+	public function crossCheckEntitiesWithProperties(array $entities, array $propertyIds) {
+		Assert::parameterElementType(EntityDocument::class, $entities, '$entities');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
 
 		$results = [];
-		foreach ( $entities as $entity ) {
+		foreach ($entities as $entity) {
 			$entityId = $entity->getId()->getSerialization();
-			if ( $entity instanceof StatementListProvider ) {
+			if ($entity instanceof StatementListProvider) {
 				$results[$entityId] = $this->crossCheckStatementsWithProperties(
 					$entity->getStatements(),
 					$propertyIds
@@ -210,12 +210,12 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementByGuid( $guid ) {
-		$this->assertIsString( $guid, '$guid' );
+	public function crossCheckStatementByGuid($guid) {
+		$this->assertIsString($guid, '$guid');
 
-		$resultList = $this->crossCheckStatementsByGuids( [ $guid ] );
+		$resultList = $this->crossCheckStatementsByGuids([$guid]);
 
-		return reset( $resultList );
+		return reset($resultList);
 	}
 
 	/**
@@ -226,21 +226,21 @@ 
 	 * @return CrossCheckResultList[]
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatementsByGuids( array $guids ) {
-		$this->assertIsArrayOfStrings( $guids, '$guids' );
+	public function crossCheckStatementsByGuids(array $guids) {
+		$this->assertIsArrayOfStrings($guids, '$guids');
 
 		$entityIds = [];
 		$groupedStatementGuids = [];
-		foreach ( $guids as $guid ) {
-			$serializedEntityId = $this->statementGuidParser->parse( $guid )->getEntityId();
+		foreach ($guids as $guid) {
+			$serializedEntityId = $this->statementGuidParser->parse($guid)->getEntityId();
 			$entityIds[$serializedEntityId->getSerialization()] = $serializedEntityId;
 			$groupedStatementGuids[$serializedEntityId->getSerialization()][] = $guid;
 		}
 
 		$resultLists = [];
-		foreach ( $groupedStatementGuids as $serializedEntityId => $guidsOfEntity ) {
-			$entityId = $entityIds[ $serializedEntityId ];
-			$resultLists[ $serializedEntityId ] = $this->crossCheckClaimsOfEntity( $entityId, $guidsOfEntity );
+		foreach ($groupedStatementGuids as $serializedEntityId => $guidsOfEntity) {
+			$entityId = $entityIds[$serializedEntityId];
+			$resultLists[$serializedEntityId] = $this->crossCheckClaimsOfEntity($entityId, $guidsOfEntity);
 		}
 
 		return $resultLists;
@@ -252,18 +252,18 @@ 
 	 *
 	 * @return CrossCheckResultList|null
 	 */
-	private function crossCheckClaimsOfEntity( EntityId $entityId, array $guids ) {
-		$entity = $this->entityLookup->getEntity( $entityId );
+	private function crossCheckClaimsOfEntity(EntityId $entityId, array $guids) {
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvider ) {
+		if ($entity instanceof StatementListProvider) {
 			$statements = new StatementList();
-			foreach ( $entity->getStatements()->toArray() as $statement ) {
-				if ( in_array( $statement->getGuid(), $guids ) ) {
-					$statements->addStatement( $statement );
+			foreach ($entity->getStatements()->toArray() as $statement) {
+				if (in_array($statement->getGuid(), $guids)) {
+					$statements->addStatement($statement);
 				}
 			}
 
-			return $this->crossChecker->crossCheckStatements( $entity->getStatements(), $statements );
+			return $this->crossChecker->crossCheckStatements($entity->getStatements(), $statements);
 		}
 
 		return null;
@@ -275,9 +275,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsString( $string, $parameterName ) {
-		if ( !is_string( $string ) ) {
-			throw new InvalidArgumentException( "$parameterName must be string." );
+	private function assertIsString($string, $parameterName) {
+		if (!is_string($string)) {
+			throw new InvalidArgumentException("$parameterName must be string.");
 		}
 	}
 
@@ -287,10 +287,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function assertIsArrayOfStrings( array $strings, $parameterName ) {
-		foreach ( $strings as $string ) {
-			if ( !is_string( $string ) ) {
-				throw new InvalidArgumentException( "Each element of $parameterName must be string." );
+	private function assertIsArrayOfStrings(array $strings, $parameterName) {
+		foreach ($strings as $string) {
+			if (!is_string($string)) {
+				throw new InvalidArgumentException("Each element of $parameterName must be string.");
 			}
 		}
 	}

includes/CrossCheck/Comparer/StringValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -17,7 +17,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -30,12 +30,12 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
-		return $this->stringComparer->compare( $value->getValue(), $comparativeValue->getValue() );
+		return $this->stringComparer->compare($value->getValue(), $comparativeValue->getValue());
 	}
 
 	/**
@@ -45,7 +45,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof StringValue && $comparativeValue instanceof StringValue;
 	}
 

includes/CrossCheck/Comparer/EntityIdValueComparer.php

Spacing +11 added lines, -11 removed lines

@@ -27,7 +27,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( TermIndex $termIndex, StringComparer $stringComparer ) {
+	public function __construct(TermIndex $termIndex, StringComparer $stringComparer) {
 		$this->termIndex = $termIndex;
 		$this->stringComparer = $stringComparer;
 	}
@@ -40,9 +40,9 @@ 
 	 *
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		Assert::parameterType( EntityIdValue::class, $value, '$value' );
-		Assert::parameterType( MonolingualTextValue::class, $comparativeValue, '$comparativeValue' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		Assert::parameterType(EntityIdValue::class, $value, '$value');
+		Assert::parameterType(MonolingualTextValue::class, $comparativeValue, '$comparativeValue');
 
 		/**
 		 * @var EntityIdValue $value
@@ -51,10 +51,10 @@ 
 
 		$entityId = $value->getEntityId();
 		$language = $comparativeValue->getLanguageCode();
-		$terms = $this->getTerms( $entityId, $language );
+		$terms = $this->getTerms($entityId, $language);
 
-		if ( $terms ) {
-			return $this->stringComparer->compareWithArray( $comparativeValue->getText(), $terms );
+		if ($terms) {
+			return $this->stringComparer->compareWithArray($comparativeValue->getText(), $terms);
 		}
 
 		return null;
@@ -68,18 +68,18 @@ 
 	 *
 	 * @return array
 	 */
-	private function getTerms( EntityId $entityId, $language ) {
+	private function getTerms(EntityId $entityId, $language) {
 		$terms = $this->termIndex->getTermsOfEntity(
 			$entityId,
 			[
 				TermIndexEntry::TYPE_LABEL,
 				TermIndexEntry::TYPE_ALIAS
 			],
-			[ $language ]
+			[$language]
 		);
 
 		return array_map(
-			function( TermIndexEntry $term ) {
+			function(TermIndexEntry $term) {
 				return $term->getText();
 			},
 			$terms
@@ -93,7 +93,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof EntityIdValue && $comparativeValue instanceof MonolingualTextValue;
 	}