wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Comparer/MultilingualTextValueComparer.php

Spacing +11 added lines, -11 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $stringComparer;
 
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -31,9 +31,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -43,21 +43,21 @@ 
 
 		$texts = $value->getTexts();
 		$comparativeTexts = $comparativeValue->getTexts();
-		$commonLanguages = array_intersect( array_keys( $texts ), array_keys( $comparativeTexts ) );
+		$commonLanguages = array_intersect(array_keys($texts), array_keys($comparativeTexts));
 
-		if ( $commonLanguages ) {
+		if ($commonLanguages) {
 			$totalResult = ComparisonResult::STATUS_MISMATCH;
 
-			foreach ( $commonLanguages as $language ) {
+			foreach ($commonLanguages as $language) {
 				$monolingualText = $texts[$language];
 				$comparativeMonolingualText = $comparativeTexts[$language];
 
-				$result = $this->stringComparer->compare( $monolingualText->getText(), $comparativeMonolingualText->getText() );
-				if ( $result !== ComparisonResult::STATUS_MISMATCH ) {
+				$result = $this->stringComparer->compare($monolingualText->getText(), $comparativeMonolingualText->getText());
+				if ($result !== ComparisonResult::STATUS_MISMATCH) {
 					$totalResult = $result;
 
 					// FIXME: This reports a partial match in a single language as a full match!
-					if ( $result === ComparisonResult::STATUS_MATCH ) {
+					if ($result === ComparisonResult::STATUS_MATCH) {
 						break;
 					}
 				}
@@ -76,7 +76,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof MultilingualTextValue && $comparativeValue instanceof MultilingualTextValue;
 	}
 

includes/CrossCheck/Comparer/DataValueComparerFactory.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( TermIndex $termIndex, StringNormalizer $stringNormalizer ) {
+	public function __construct(TermIndex $termIndex, StringNormalizer $stringNormalizer) {
 		$this->termIndex = $termIndex;
 		$this->stringNormalizer = $stringNormalizer;
 	}
@@ -63,7 +63,7 @@ 
 	 * @return StringComparer
 	 */
 	private function newStringComparer() {
-		return new StringComparer( $this->stringNormalizer );
+		return new StringComparer($this->stringNormalizer);
 	}
 
 	/**

includes/CrossCheck/ValueParser/StringValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $stringNormalizer;
 
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -29,10 +29,10 @@ 
 	 *
 	 * @return StringValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
-		return new StringValue( $this->stringNormalizer->trimToNFC( $value ) );
+		return new StringValue($this->stringNormalizer->trimToNFC($value));
 	}
 
 }

includes/CrossCheck/ValueParser/MultilingualTextValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
 	 */
 	private $monolingualTextValueParser;
 
-	public function __construct( ValueParser $monolingualTextValueParser ) {
+	public function __construct(ValueParser $monolingualTextValueParser) {
 		$this->monolingualTextValueParser = $monolingualTextValueParser;
 	}
 
@@ -28,11 +28,11 @@ 
 	 *
 	 * @return MultilingualTextValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
 		return new MultilingualTextValue(
-			[ $this->monolingualTextValueParser->parse( $value ) ]
+			[$this->monolingualTextValueParser->parse($value)]
 		);
 	}
 

includes/Serializer/SerializerFactory.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
 	 */
 	private $referenceSerializer;
 
-	public function __construct( Serializer $dataValueSerializer, Serializer $referenceSerializer ) {
+	public function __construct(Serializer $dataValueSerializer, Serializer $referenceSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 		$this->referenceSerializer = $referenceSerializer;
 	}
@@ -42,7 +42,7 @@ 
 	 * @return Serializer
 	 */
 	public function newComparisonResultSerializer() {
-		return new ComparisonResultSerializer( $this->dataValueSerializer );
+		return new ComparisonResultSerializer($this->dataValueSerializer);
 	}
 
 	/**
@@ -73,7 +73,7 @@ 
 	 * @return Serializer
 	 */
 	public function newReferenceResultSerializer() {
-		return new ReferenceResultSerializer( $this->referenceSerializer );
+		return new ReferenceResultSerializer($this->referenceSerializer);
 	}
 
 }

includes/Serializer/ComparisonResultSerializer.php

Spacing +10 added lines, -10 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $dataValueSerializer;
 
-	public function __construct( Serializer $dataValueSerializer ) {
+	public function __construct(Serializer $dataValueSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 	}
 
@@ -29,7 +29,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ComparisonResult;
 	}
 
@@ -41,29 +41,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ComparisonResult $comparisonResult ) {
+	private function getSerialized(ComparisonResult $comparisonResult) {
 		$dataValueSerializer = $this->dataValueSerializer;
 		$externalValues = array_map(
-			function ( $dataValue ) use ( $dataValueSerializer ) {
-				return $dataValueSerializer->serialize( $dataValue );
+			function($dataValue) use ($dataValueSerializer) {
+				return $dataValueSerializer->serialize($dataValue);
 			},
 			$comparisonResult->getExternalValues()
 		);
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
+		$this->setIndexedTagName($externalValues, 'dataValue');
 
 		return [
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
 			'externalValues' => $externalValues,
 			'result' => $comparisonResult->getStatus()
 		];

includes/Serializer/CrossCheckResultListSerializer.php

Spacing +11 added lines, -11 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $crossCheckResultSerializer;
 
-	public function __construct( Serializer $crossCheckResultSerializer ) {
+	public function __construct(Serializer $crossCheckResultSerializer) {
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
 	}
 
@@ -29,7 +29,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResultList;
 	}
 
@@ -41,29 +41,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResultList $resultList ) {
+	private function getSerialized(CrossCheckResultList $resultList) {
 		$serialization = [];
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
+		$this->setKeyAttributeName($serialization, 'property', 'id');
 
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
+		foreach ($resultList->getPropertyIds() as $propertyId) {
 			$id = $propertyId->getSerialization();
 			$resultSerialization = [];
 
-			$this->setIndexedTagName( $resultSerialization, 'result' );
+			$this->setIndexedTagName($resultSerialization, 'result');
 
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
 			}
 
 			$serialization[$id] = $resultSerialization;

includes/Serializer/ReferenceResultSerializer.php

Spacing +7 added lines, -7 removed lines

@@ -18,7 +18,7 @@ 
 	 */
 	private $referenceSerializer;
 
-	public function __construct( Serializer $referenceSerializer ) {
+	public function __construct(Serializer $referenceSerializer) {
 		$this->referenceSerializer = $referenceSerializer;
 	}
 
@@ -29,7 +29,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ReferenceResult;
 	}
 
@@ -41,20 +41,20 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ReferenceResult $referenceResult ) {
+	private function getSerialized(ReferenceResult $referenceResult) {
 		return [
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
 			'status' => $referenceResult->getStatus()
 		];
 	}

specials/SpecialExternalDatabases.php

Spacing +38 added lines, -38 removed lines

@@ -53,10 +53,10 @@ 
 		EntityIdHtmlLinkFormatterFactory $entityIdHtmlLinkFormatterFactory,
 		DumpMetaInformationLookup $dumpMetaInformationRepo
 	) {
-		parent::__construct( 'ExternalDatabases' );
+		parent::__construct('ExternalDatabases');
 
 		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter(
-			new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() )
+			new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode())
 		);
 
 		$this->dumpMetaInformationRepo = $dumpMetaInformationRepo;
@@ -77,7 +77,7 @@ 
 	 * @return string
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqev-externaldbs' )->text();
+		return $this->msg('wbqev-externaldbs')->text();
 	}
 
 	/**
@@ -85,51 +85,51 @@ 
 	 *
 	 * @param string|null $subPage
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
 		$this->setHeaders();
 
 		$out->addHTML(
-			Html::openElement( 'p' )
-			. $this->msg( 'wbqev-externaldbs-instructions' )->parse()
-			. Html::closeElement( 'p' )
-			. Html::openElement( 'h3' )
-			. $this->msg( 'wbqev-externaldbs-overview-headline' )->parse()
-			. Html::closeElement( 'h3' )
+			Html::openElement('p')
+			. $this->msg('wbqev-externaldbs-instructions')->parse()
+			. Html::closeElement('p')
+			. Html::openElement('h3')
+			. $this->msg('wbqev-externaldbs-overview-headline')->parse()
+			. Html::closeElement('h3')
 		);
 
 		$dumps = $this->dumpMetaInformationRepo->getAll();
-		if ( count( $dumps ) > 0 ) {
+		if (count($dumps) > 0) {
 			$groupedDumpMetaInformation = [];
-			foreach ( $dumps as $dump ) {
+			foreach ($dumps as $dump) {
 				$sourceItemId = $dump->getSourceItemId()->getSerialization();
 				$groupedDumpMetaInformation[$sourceItemId][] = $dump;
 			}
 
 			$table = new HtmlTableBuilder(
 				[
-					$this->msg( 'wbqev-externaldbs-name' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-id' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-import-date' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-language' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-source-urls' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-size' )->escaped(),
-					$this->msg( 'wbqev-externaldbs-license' )->escaped()
+					$this->msg('wbqev-externaldbs-name')->escaped(),
+					$this->msg('wbqev-externaldbs-id')->escaped(),
+					$this->msg('wbqev-externaldbs-import-date')->escaped(),
+					$this->msg('wbqev-externaldbs-language')->escaped(),
+					$this->msg('wbqev-externaldbs-source-urls')->escaped(),
+					$this->msg('wbqev-externaldbs-size')->escaped(),
+					$this->msg('wbqev-externaldbs-license')->escaped()
 				],
 				true
 			);
 
-			foreach ( $groupedDumpMetaInformation as $dumpMetaInformation ) {
-				$table->appendRows( $this->getRowGroup( $dumpMetaInformation ) );
+			foreach ($groupedDumpMetaInformation as $dumpMetaInformation) {
+				$table->appendRows($this->getRowGroup($dumpMetaInformation));
 			}
 
-			$out->addHTML( $table->toHtml() );
+			$out->addHTML($table->toHtml());
 		} else {
 			$out->addHTML(
-				Html::openElement( 'p' )
-				. $this->msg( 'wbqev-externaldbs-no-databases' )->escaped()
-				. Html::closeElement( 'p' )
+				Html::openElement('p')
+				. $this->msg('wbqev-externaldbs-no-databases')->escaped()
+				. Html::closeElement('p')
 			);
 		}
 	}
@@ -141,12 +141,12 @@ 
 	 *
 	 * @return array
 	 */
-	private function getRowGroup( array $dumpMetaInformationGroup ) {
+	private function getRowGroup(array $dumpMetaInformationGroup) {
 		$rows = [];
 
-		foreach ( $dumpMetaInformationGroup as $dumpMetaInformation ) {
+		foreach ($dumpMetaInformationGroup as $dumpMetaInformation) {
 			$dumpId = $dumpMetaInformation->getDumpId();
-			$importDate = $this->getLanguage()->timeanddate( $dumpMetaInformation->getImportDate() );
+			$importDate = $this->getLanguage()->timeanddate($dumpMetaInformation->getImportDate());
 			$language = Language::fetchLanguageName(
 				$dumpMetaInformation->getLanguageCode(),
 				$this->getLanguage()->getCode()
@@ -155,23 +155,23 @@ 
 				$dumpMetaInformation->getSourceUrl(),
 				$dumpMetaInformation->getSourceUrl()
 			);
-			$size = $this->getLanguage()->formatSize( $dumpMetaInformation->getSize() );
-			$license = $this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformation->getLicenseItemId() );
+			$size = $this->getLanguage()->formatSize($dumpMetaInformation->getSize());
+			$license = $this->entityIdLinkFormatter->formatEntityId($dumpMetaInformation->getLicenseItemId());
 			$rows[] = [
-				new HtmlTableCellBuilder( $dumpId ),
-				new HtmlTableCellBuilder( $importDate ),
-				new HtmlTableCellBuilder( $language ),
-				new HtmlTableCellBuilder( $sourceUrl, [], true ),
-				new HtmlTableCellBuilder( $size ),
-				new HtmlTableCellBuilder( $license, [], true )
+				new HtmlTableCellBuilder($dumpId),
+				new HtmlTableCellBuilder($importDate),
+				new HtmlTableCellBuilder($language),
+				new HtmlTableCellBuilder($sourceUrl, [], true),
+				new HtmlTableCellBuilder($size),
+				new HtmlTableCellBuilder($license, [], true)
 			];
 		}
 
 		array_unshift(
 			$rows[0],
 			new HtmlTableCellBuilder(
-				$this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformationGroup[0]->getSourceItemId() ),
-				[ 'rowspan' => (string)count( $dumpMetaInformationGroup ) ],
+				$this->entityIdLinkFormatter->formatEntityId($dumpMetaInformationGroup[0]->getSourceItemId()),
+				['rowspan' => (string)count($dumpMetaInformationGroup)],
 				true
 			)
 		);