Issues in SqlDumpMetaInformationRepo.php - New Issues - Inspection of "Fix/adjust RunCrossCheckTest for change in api err..." - wikimedia/mediawiki-extensions-WikibaseQualityExternalValidation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 26f8aa...e860de )

unknown

created 2016-02-16 15:14 UTC

DumpMetaInformation/SqlDumpMetaInformationRepo.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace WikibaseQuality\ExternalValidation\DumpMetaInformation;

use DatabaseBase;
use InvalidArgumentException;
use UnexpectedValueException;
use ResultWrapper;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\PropertyId;

/**
 * Implements access to the actual database table that stores the dump information.
 *
 * @package WikibaseQuality\ExternalValidation\DumpMetaInformation
 * @author BP2014N1
 * @license GNU GPL v2+
 */
class SqlDumpMetaInformationRepo implements DumpMetaInformationLookup, DumpMetaInformationStore {

	const META_TABLE_NAME = 'wbqev_dump_information';
	const IDENTIFIER_PROPERTIES_TABLE_NAME = 'wbqev_identifier_properties';

	/**
	 * Gets DumpMetaInformation for specific dump id from database.
	 *
	 * @param $dumpId
	 * @return DumpMetaInformation
	 * @throws InvalidArgumentException
	 */
	public function getWithId( $dumpId ) {
		if ( !is_string( $dumpId ) ) {
			throw new InvalidArgumentException( '$dumpId must be string.' );
		}

		$dumpMetaInformation = $this->getWithIds( array( $dumpId ) );

		return reset( $dumpMetaInformation );

	}

	/**
	 * Gets DumpMetaInformation for specific dump ids from database
	 * Returns array in the form 'dumpId' => DumpMetaInformation
	 *
	 * @param string[] $dumpIds
	 * @return DumpMetaInformation[]
	 * @throws InvalidArgumentException
	 */
	public function getWithIds( array $dumpIds ) {
		foreach ( $dumpIds as $dumpId ) {
			if ( !is_string( $dumpId ) ) {
				throw new InvalidArgumentException( '$dumpIds must contain only strings.' );
			}
		}

		if( count( $dumpIds ) > 0 ) {
			$db = wfGetDB( DB_SLAVE );
			$result = $db->select(
				array(
					self::META_TABLE_NAME,
					self::IDENTIFIER_PROPERTIES_TABLE_NAME
				),
				'*',
				array(
					'id' => $dumpIds
				),
				__METHOD__,
				array(),
				array(
					self::IDENTIFIER_PROPERTIES_TABLE_NAME => array(
						'LEFT JOIN',
						'dump_id = id'
					)
				)
			);

			return $this->buildDumpMetaInformationFromResult( $result );
		}

		return array();
	}

	/**
	 * Gets DumpMetaInformation for specific identifier properties from database
	 * Returns array in the form 'dumpId' => DumpMetaInformation
	 *
	 * @param PropertyId[] $identifierPropertyIds
	 *
	 * @throws InvalidArgumentException
	 * @return DumpMetaInformation[]
	 */
	public function getWithIdentifierProperties( array $identifierPropertyIds ) {
		foreach ( $identifierPropertyIds as $propertyId ) {
			if ( !( $propertyId instanceof PropertyId ) ) {
				throw new InvalidArgumentException( '$identifierProperties must contain only PropertyIds.' );
			}
		}

		if( count( $identifierPropertyIds ) > 0 ) {
			$db = wfGetDB( DB_SLAVE );
			$identifierPropertyIds = array_map(
				function( PropertyId $id ) {
					return $id->getSerialization();
				},
				$identifierPropertyIds
			);
			$result = $db->select(
				self::IDENTIFIER_PROPERTIES_TABLE_NAME,
				'dump_id',
				array(
					'identifier_pid' => $identifierPropertyIds
				)
			);
			$dumpIds = array();
			foreach ( $result as $row ) {
				if ( !in_array( $row->dump_id, $dumpIds ) ) {
					$dumpIds[] = $row->dump_id;
				}
			}

			return $this->getWithIds( $dumpIds );
		}

		return array();
	}

	/**
	 * Gets id of item that represents the data source for each dump.
	 *
	 * @return ItemId[]
	 */
	public function getSourceItemIds() {
		$db = wfGetDB( DB_SLAVE );
		$result = $db->selectFieldValues(
			self::META_TABLE_NAME,
			'source_qid',
			array(),
			__METHOD__,
			'DISTINCT'
		);

		$sourceItemIds = $result; // TODO: Parse as ItemId, when ItemIds are used in violation table
		/*$sourceItemIds = array();

		foreach ( $result as $itemId ) {
			$sourceItemIds = new ItemId( $itemId );
		}*/

		return $sourceItemIds;
	}

	/**
	 * Gets all DumpMetaInformation from database
	 * Returns array in the form 'dumpId' => DumpMetaInformation
	 *
	 * @return DumpMetaInformation[]
	 */
	public function getAll() {
		$db = wfGetDB( DB_SLAVE );
		$result = $db->select(
			array(
				self::META_TABLE_NAME,
				self::IDENTIFIER_PROPERTIES_TABLE_NAME
			),
			'*',
			array(),
			__METHOD__,
			array(),
			array(
				self::IDENTIFIER_PROPERTIES_TABLE_NAME => array(
					'LEFT JOIN',
					'dump_id = id'
				)
			)
		);

		return $this->buildDumpMetaInformationFromResult( $result );
	}

	/**
	 * @param ResultWrapper $result
	 * @return null|array
	 * @throws UnexpectedValueException
	 */
	private function buildDumpMetaInformationFromResult( ResultWrapper $result ) {
		$aggregatedRows = array();
		foreach ( $result as $row ) {
			if ( array_key_exists( $row->id, $aggregatedRows ) ) {
				$propertyId = new PropertyId( $row->identifier_pid );
				$aggregatedRows[$row->id]->identifier_pid[] = $propertyId;
			} else {
				if ( $row->identifier_pid !== null ) {
					$propertyId = new PropertyId( $row->identifier_pid );
					$row->identifier_pid = array( $propertyId );
				}
				$aggregatedRows[$row->id] = $row;
			}
		}

		$dumpMetaInformation = array();
		foreach ( $aggregatedRows as $row ) {
			$dumpId = $row->id;
			$sourceItemId = new ItemId( $row->source_qid );
			$importDate = wfTimestamp( TS_MW, $row->import_date );
			$language = $row->language;
			$sourceUrl = $row->source_url;
			$size = (int)$row->size;
			$licenseItemId = new ItemId( $row->license_qid );
			$identifierPropertyIds = $row->identifier_pid;

			$dumpMetaInformation[$row->dump_id] =
				new DumpMetaInformation( $dumpId,
					$sourceItemId,
					$identifierPropertyIds,
					$importDate,
					$language,
					$sourceUrl,
					$size,
					$licenseItemId
				);
		}

		return $dumpMetaInformation;
	}

	/**
	 * Inserts or updates given dump meta information to database
	 *
	 * @param DumpMetaInformation $dumpMetaInformation
	 */
	public function save( DumpMetaInformation $dumpMetaInformation ) {
		$db = wfGetDB( DB_SLAVE );
		$dumpId = $dumpMetaInformation->getDumpId();
		$accumulator = $this->getDumpInformationFields( $db, $dumpMetaInformation );

		$existing = $db->selectRow(
			self::META_TABLE_NAME,
			array( 'id' ),
			array( 'id' => $dumpId )
		);

		if ( $existing ) {
			$db->update(
				self::META_TABLE_NAME,
				$accumulator,
				array( 'id' => $dumpId )
			);
		} else {
			$db->insert(
				self::META_TABLE_NAME,
				$accumulator
			);
		}

		$db->delete(
			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
			array( 'dump_id' => $dumpId )
		);
		$db->insert(
			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
			array_map(
				function ( PropertyId $identifierPropertyId ) use ( $dumpId ) {
					return array(
						'dump_id' => $dumpId,
						'identifier_pid' => $identifierPropertyId->getSerialization()
					);
				},
				$dumpMetaInformation->getIdentifierPropertyIds()
			)
		);
	}

	/**
	 * @param DumpMetaInformation $dumpMetaInformation *
	 * @return array
	 */
	private function getDumpInformationFields( DatabaseBase $db,  DumpMetaInformation $dumpMetaInformation ) {
		return array(
			'id' => $dumpMetaInformation->getDumpId(),
			'source_qid' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
			'import_date' => $db->timestamp( $dumpMetaInformation->getImportDate() ),
			'language' => $dumpMetaInformation->getLanguageCode(),
			'source_url' => $dumpMetaInformation->getSourceUrl(),
			'size' => $dumpMetaInformation->getSize(),
			'license_qid' => $dumpMetaInformation->getLicenseItemId()->getSerialization()
		);
	}

}


1			<?php
2
3			namespace WikibaseQuality\ExternalValidation\DumpMetaInformation;
4
5			use DatabaseBase;
6			use InvalidArgumentException;
7			use UnexpectedValueException;
8			use ResultWrapper;
9			use Wikibase\DataModel\Entity\ItemId;
10			use Wikibase\DataModel\Entity\PropertyId;
11
12			/**
13			* Implements access to the actual database table that stores the dump information.
14			*
15			* @package WikibaseQuality\ExternalValidation\DumpMetaInformation
16			* @author BP2014N1
17			* @license GNU GPL v2+
18			*/
19			class SqlDumpMetaInformationRepo implements DumpMetaInformationLookup, DumpMetaInformationStore {
20
21			const META_TABLE_NAME = 'wbqev_dump_information';
22			const IDENTIFIER_PROPERTIES_TABLE_NAME = 'wbqev_identifier_properties';
23
24			/**
25			* Gets DumpMetaInformation for specific dump id from database.
26			*
27			* @param $dumpId
28			* @return DumpMetaInformation
29			* @throws InvalidArgumentException
30			*/
31			public function getWithId( $dumpId ) {
32			if ( !is_string( $dumpId ) ) {
33			throw new InvalidArgumentException( '$dumpId must be string.' );
34			}
35
36			$dumpMetaInformation = $this->getWithIds( array( $dumpId ) );
37
38			return reset( $dumpMetaInformation );
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-02-16 15:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `reset($dumpMetaInformation);` of type `WikibaseQuality\External...mpMetaInformation\|false` adds `false` to the return on line 38 which is incompatible with the return type declared by the interface `WikibaseQuality\External...mationLookup::getWithId` of type `WikibaseQuality\External...ion\DumpMetaInformation`. It seems like you forgot to handle an error condition. Loading history...
39			}
40
41			/**
42			* Gets DumpMetaInformation for specific dump ids from database
43			* Returns array in the form 'dumpId' => DumpMetaInformation
44			*
45			* @param string[] $dumpIds
46			* @return DumpMetaInformation[]
47			* @throws InvalidArgumentException
48			*/
49			public function getWithIds( array $dumpIds ) {
50			foreach ( $dumpIds as $dumpId ) {
51			if ( !is_string( $dumpId ) ) {
52			throw new InvalidArgumentException( '$dumpIds must contain only strings.' );
53			}
54			}
55
56			if( count( $dumpIds ) > 0 ) {
57			$db = wfGetDB( DB_SLAVE );
58			$result = $db->select(
59			array(
60			self::META_TABLE_NAME,
61			self::IDENTIFIER_PROPERTIES_TABLE_NAME
62			),
63			'*',
64			array(
65			'id' => $dumpIds
66			),
67			__METHOD__,
68			array(),
69			array(
70			self::IDENTIFIER_PROPERTIES_TABLE_NAME => array(
71			'LEFT JOIN',
72			'dump_id = id'
73			)
74			)
75			);
76
77			return $this->buildDumpMetaInformationFromResult( $result );
78			}
79
80			return array();
81			}
82
83			/**
84			* Gets DumpMetaInformation for specific identifier properties from database
85			* Returns array in the form 'dumpId' => DumpMetaInformation
86			*
87			* @param PropertyId[] $identifierPropertyIds
88			*
89			* @throws InvalidArgumentException
90			* @return DumpMetaInformation[]
91			*/
92			public function getWithIdentifierProperties( array $identifierPropertyIds ) {
93			foreach ( $identifierPropertyIds as $propertyId ) {
94			if ( !( $propertyId instanceof PropertyId ) ) {
95			throw new InvalidArgumentException( '$identifierProperties must contain only PropertyIds.' );
96			}
97			}
98
99			if( count( $identifierPropertyIds ) > 0 ) {
100			$db = wfGetDB( DB_SLAVE );
101			$identifierPropertyIds = array_map(
102			function( PropertyId $id ) {
103			return $id->getSerialization();
104			},
105			$identifierPropertyIds
106			);
107			$result = $db->select(
108			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
109			'dump_id',
110			array(
111			'identifier_pid' => $identifierPropertyIds
112			)
113			);
114			$dumpIds = array();
115			foreach ( $result as $row ) {
116			if ( !in_array( $row->dump_id, $dumpIds ) ) {
117			$dumpIds[] = $row->dump_id;
118			}
119			}
120
121			return $this->getWithIds( $dumpIds );
122			}
123
124			return array();
125			}
126
127			/**
128			* Gets id of item that represents the data source for each dump.
129			*
130			* @return ItemId[]
131			*/
132			public function getSourceItemIds() {
133			$db = wfGetDB( DB_SLAVE );
134			$result = $db->selectFieldValues(
135			self::META_TABLE_NAME,
136			'source_qid',
137			array(),
138			__METHOD__,
139			'DISTINCT'
140			);
141
142			$sourceItemIds = $result; // TODO: Parse as ItemId, when ItemIds are used in violation table
143			/*$sourceItemIds = array();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-16 15:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
144			foreach ( $result as $itemId ) {
145			$sourceItemIds = new ItemId( $itemId );
146			}*/
147
148			return $sourceItemIds;
149			}
150
151			/**
152			* Gets all DumpMetaInformation from database
153			* Returns array in the form 'dumpId' => DumpMetaInformation
154			*
155			* @return DumpMetaInformation[]
156			*/
157			public function getAll() {
158			$db = wfGetDB( DB_SLAVE );
159			$result = $db->select(
160			array(
161			self::META_TABLE_NAME,
162			self::IDENTIFIER_PROPERTIES_TABLE_NAME
163			),
164			'*',
165			array(),
166			__METHOD__,
167			array(),
168			array(
169			self::IDENTIFIER_PROPERTIES_TABLE_NAME => array(
170			'LEFT JOIN',
171			'dump_id = id'
172			)
173			)
174			);
175
176			return $this->buildDumpMetaInformationFromResult( $result );
177			}
178
179			/**
180			* @param ResultWrapper $result
181			* @return null\|array
182			* @throws UnexpectedValueException
183			*/
184			private function buildDumpMetaInformationFromResult( ResultWrapper $result ) {
185			$aggregatedRows = array();
186			foreach ( $result as $row ) {
187			if ( array_key_exists( $row->id, $aggregatedRows ) ) {
188			$propertyId = new PropertyId( $row->identifier_pid );
189			$aggregatedRows[$row->id]->identifier_pid[] = $propertyId;
190			} else {
191			if ( $row->identifier_pid !== null ) {
192			$propertyId = new PropertyId( $row->identifier_pid );
193			$row->identifier_pid = array( $propertyId );
194			}
195			$aggregatedRows[$row->id] = $row;
196			}
197			}
198
199			$dumpMetaInformation = array();
200			foreach ( $aggregatedRows as $row ) {
201			$dumpId = $row->id;
202			$sourceItemId = new ItemId( $row->source_qid );
203			$importDate = wfTimestamp( TS_MW, $row->import_date );
204			$language = $row->language;
205			$sourceUrl = $row->source_url;
206			$size = (int)$row->size;
207			$licenseItemId = new ItemId( $row->license_qid );
208			$identifierPropertyIds = $row->identifier_pid;
209
210			$dumpMetaInformation[$row->dump_id] =
211			new DumpMetaInformation( $dumpId,
212			$sourceItemId,
213			$identifierPropertyIds,
214			$importDate,
215			$language,
216			$sourceUrl,
217			$size,
218			$licenseItemId
219			);
220			}
221
222			return $dumpMetaInformation;
223			}
224
225			/**
226			* Inserts or updates given dump meta information to database
227			*
228			* @param DumpMetaInformation $dumpMetaInformation
229			*/
230			public function save( DumpMetaInformation $dumpMetaInformation ) {
231			$db = wfGetDB( DB_SLAVE );
232			$dumpId = $dumpMetaInformation->getDumpId();
233			$accumulator = $this->getDumpInformationFields( $db, $dumpMetaInformation );
234
235			$existing = $db->selectRow(
236			self::META_TABLE_NAME,
237			array( 'id' ),
238			array( 'id' => $dumpId )
239			);
240
241			if ( $existing ) {
242			$db->update(
243			self::META_TABLE_NAME,
244			$accumulator,
245			array( 'id' => $dumpId )
246			);
247			} else {
248			$db->insert(
249			self::META_TABLE_NAME,
250			$accumulator
251			);
252			}
253
254			$db->delete(
255			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
256			array( 'dump_id' => $dumpId )
257			);
258			$db->insert(
259			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
260			array_map(
261			function ( PropertyId $identifierPropertyId ) use ( $dumpId ) {
262			return array(
263			'dump_id' => $dumpId,
264			'identifier_pid' => $identifierPropertyId->getSerialization()
265			);
266			},
267			$dumpMetaInformation->getIdentifierPropertyIds()
268			)
269			);
270			}
271
272			/**
273			* @param DumpMetaInformation $dumpMetaInformation *
274			* @return array
275			*/
276			private function getDumpInformationFields( DatabaseBase $db, DumpMetaInformation $dumpMetaInformation ) {
277			return array(
278			'id' => $dumpMetaInformation->getDumpId(),
279			'source_qid' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
280			'import_date' => $db->timestamp( $dumpMetaInformation->getImportDate() ),
281			'language' => $dumpMetaInformation->getLanguageCode(),
282			'source_url' => $dumpMetaInformation->getSourceUrl(),
283			'size' => $dumpMetaInformation->getSize(),
284			'license_qid' => $dumpMetaInformation->getLicenseItemId()->getSerialization()
285			);
286			}
287
288			}
289

wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

Push — master ( 26f8aa...e860de )

DumpMetaInformation/SqlDumpMetaInformationRepo.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like