Completed
Push — master ( 907177...1de753 )
by
unknown
03:47
created
api/RunCrossCheck.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
 	/**
163 163
 	 * Writes output for CrossCheckResultList
164 164
 	 *
165
-	 * @param array $resultLists
165
+	 * @param \WikibaseQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultList[] $resultLists
166 166
 	 *
167 167
 	 * @return array
168 168
 	 */
Please login to merge, or discard this patch.
includes/CrossCheck/CrossCheckInteractor.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@
 block discarded – undo
288 288
 	}
289 289
 
290 290
 	/**
291
-	 * @param array $strings
291
+	 * @param string[] $strings
292 292
 	 * @param string $parameterName
293 293
 	 *
294 294
 	 * @throws InvalidArgumentException
Please login to merge, or discard this patch.
includes/CrossCheck/CrossChecker.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -283,8 +283,7 @@  discard block
 block discarded – undo
283 283
 				$result = ComparisonResult::STATUS_MISMATCH;
284 284
 				if( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
285 285
 					$result = ComparisonResult::STATUS_MATCH;
286
-				}
287
-				elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
286
+				} elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
288 287
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
289 288
 				}
290 289
 
@@ -314,8 +313,7 @@  discard block
 block discarded – undo
314 313
 				if( $parsedValue ) {
315 314
 					$parsedValues[] = $parsedValue;
316 315
 				}
317
-			}
318
-			catch( ParseException $e ) {}
316
+			} catch( ParseException $e ) {}
319 317
 		}
320 318
 
321 319
 		return $parsedValues;
Please login to merge, or discard this patch.
includes/ExternalDataRepo.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -102,8 +102,7 @@
 block discarded – undo
102 102
 			$db->begin();
103 103
 			$result = $db->insert( self::TABLE_NAME, $accumulator );
104 104
 			$db->commit();
105
-		}
106
-		catch( DBError $ex ) {
105
+		} catch( DBError $ex ) {
107 106
 			$db->rollback();
108 107
 			throw $ex;
109 108
 		}
Please login to merge, or discard this patch.
includes/UpdateExternalData/ExternalDataImporter.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -95,16 +95,14 @@  discard block
 block discarded – undo
95 95
 					intval( $data[6] ),
96 96
 					new ItemId( $data[7] )
97 97
 				);
98
-			}
99
-			catch( \InvalidArgumentException $e ) {
98
+			} catch( \InvalidArgumentException $e ) {
100 99
 				exit( 'Input file has bad formatted values.' );
101 100
 			}
102 101
 			$dumpIds[] = $dumpMetaInformation->getDumpId();
103 102
 
104 103
 			try {
105 104
 				$this->dumpMetaInformationStore->save( $dumpMetaInformation );
106
-			}
107
-			catch( \DBError $e ) {
105
+			} catch( \DBError $e ) {
108 106
 				exit( 'Unknown database error occurred.' );
109 107
 			}
110 108
 
@@ -138,8 +136,7 @@  discard block
 block discarded – undo
138 136
 			if ( $data === false || ++$i % $this->importSettings->getBatchSize() === 0 ) {
139 137
 				try {
140 138
 					$this->externalDataRepo->insertBatch( $accumulator );
141
-				}
142
-				catch( \DBError $e ) {
139
+				} catch( \DBError $e ) {
143 140
 					exit( 'Unknown database error occurred.' );
144 141
 				}
145 142
 				wfWaitForSlaves();
Please login to merge, or discard this patch.
specials/SpecialCrossCheck.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 	/**
307 307
 	 * Builds summary from given results
308 308
 	 *
309
-	 * @param CrossCheckResult[]|CrossCheckResultList $results
309
+	 * @param CrossCheckResultList $results
310 310
 	 *
311 311
 	 * @return string HTML
312 312
 	 */
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 	}
397 397
 
398 398
 	/**
399
-	 * @param CrossCheckResult[]|CrossCheckResultList $results
399
+	 * @param CrossCheckResultList $results
400 400
 	 *
401 401
 	 * @return string HTML
402 402
 	 */
Please login to merge, or discard this patch.