wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Comparer/StringValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -21,7 +21,7 @@ 
 	/**
 	 * @param StringComparer $stringComparer
 	 */
-	public function __construct( StringComparer $stringComparer ) {
+	public function __construct(StringComparer $stringComparer) {
 		$this->stringComparer = $stringComparer;
 	}
 
@@ -34,12 +34,12 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
-		return $this->stringComparer->compare( $value->getValue(), $comparativeValue->getValue() );
+		return $this->stringComparer->compare($value->getValue(), $comparativeValue->getValue());
 	}
 
 	/**
@@ -49,7 +49,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof StringValue && $comparativeValue instanceof StringValue;
 	}
 

includes/CrossCheck/CrossChecker.php

Braces +2 added lines, -4 removed lines

@@ -283,8 +283,7 @@ 
 				$result = ComparisonResult::STATUS_MISMATCH;
 				if( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
 					$result = ComparisonResult::STATUS_MATCH;
-				}
-				elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
+				} elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 				}
 
@@ -314,8 +313,7 @@ 
 				if( $parsedValue ) {
 					$parsedValues[] = $parsedValue;
 				}
-			}
-			catch( ParseException $e ) {}
+			} catch( ParseException $e ) {}
 		}
 
 		return $parsedValues;

Spacing +56 added lines, -56 removed lines

@@ -95,22 +95,22 @@ 
 	 * @return CrossCheckResultList
 	 * @throws InvalidArgumentException
 	 */
-	public function crossCheckStatements( StatementList $entityStatements, StatementList $statements ) {
+	public function crossCheckStatements(StatementList $entityStatements, StatementList $statements) {
 		$statementsOfEntity = $entityStatements->toArray();
 
-		foreach ( $statements as $statement ) {
-			if ( !in_array( $statement, $statementsOfEntity ) ) {
-				throw new InvalidArgumentException( 'All statements in $statements must belong to the entity.' );
+		foreach ($statements as $statement) {
+			if (!in_array($statement, $statementsOfEntity)) {
+				throw new InvalidArgumentException('All statements in $statements must belong to the entity.');
 			}
 		}
 
 		$resultList = new CrossCheckResultList();
-		if ( $statements->count() > 0 ) {
-			$applicableDumps = $this->getApplicableDumps( $entityStatements );
-			foreach ( $applicableDumps as $identifierPropertyId => $dumpMetaInformationList ) {
-				$identifierPropertyId = new PropertyId( $identifierPropertyId );
+		if ($statements->count() > 0) {
+			$applicableDumps = $this->getApplicableDumps($entityStatements);
+			foreach ($applicableDumps as $identifierPropertyId => $dumpMetaInformationList) {
+				$identifierPropertyId = new PropertyId($identifierPropertyId);
 
-				if( $this->isIdentifierProperty( $identifierPropertyId ) ) {
+				if ($this->isIdentifierProperty($identifierPropertyId)) {
 					$resultList->merge(
 						$this->crossCheckStatementsWithIdentifier(
 							$entityStatements,
@@ -133,17 +133,17 @@ 
 	 *
 	 * @return array[]
 	 */
-	private function getApplicableDumps( StatementList $statements ) {
+	private function getApplicableDumps(StatementList $statements) {
 		$applicableDumps = array();
 		$identifierPropertyIds = $statements->getPropertyIds();
 		$dumpMetaInformation = $this->dumpMetaInformationLookup->getWithIdentifierProperties(
 			$identifierPropertyIds
 		);
 
-		foreach ( $dumpMetaInformation as $dump ) {
-			foreach ( $dump->getIdentifierPropertyIds() as $identifierPropertyId ) {
+		foreach ($dumpMetaInformation as $dump) {
+			foreach ($dump->getIdentifierPropertyIds() as $identifierPropertyId) {
 				$serialization = $identifierPropertyId->getSerialization();
-				$applicableDumps[ $serialization ][ $dump->getDumpId() ] = $dump;
+				$applicableDumps[$serialization][$dump->getDumpId()] = $dump;
 			}
 		}
 
@@ -168,36 +168,36 @@ 
 	) {
 		$resultList = new CrossCheckResultList();
 
-		$externalIds = $this->getExternalIds( $entityStatements, $identifierPropertyId );
-		if( !$externalIds ) {
+		$externalIds = $this->getExternalIds($entityStatements, $identifierPropertyId);
+		if (!$externalIds) {
 			return $resultList;
 		}
 
 		$dumpIds = array_map(
-			function ( DumpMetaInformation $dumpMetaInformation ) {
+			function(DumpMetaInformation $dumpMetaInformation) {
 				return $dumpMetaInformation->getDumpId();
 			},
 			$dumpMetaInformationList
 		);
-		$externalData = $this->externalDataRepo->getExternalData( $dumpIds, $externalIds, $statements->getPropertyIds() );
+		$externalData = $this->externalDataRepo->getExternalData($dumpIds, $externalIds, $statements->getPropertyIds());
 
-		foreach ( $externalData as $dumpId => $externalDataPerDump ) {
-			$dumpMetaInformation = $dumpMetaInformationList[ $dumpId ];
+		foreach ($externalData as $dumpId => $externalDataPerDump) {
+			$dumpMetaInformation = $dumpMetaInformationList[$dumpId];
 			$comparativeValueParser = $this->valueParserFactory->newComparativeValueParser(
 				$dumpMetaInformation->getLanguageCode()
 			);
 
-			foreach ( $externalDataPerDump as $externalId => $externalDataPerId ) {
+			foreach ($externalDataPerDump as $externalId => $externalDataPerId) {
 				$externalId = (string)$externalId;
-				foreach ( $externalDataPerId as $propertyId => $externalValues ) {
-					$propertyId = new PropertyId( $propertyId );
+				foreach ($externalDataPerId as $propertyId => $externalValues) {
+					$propertyId = new PropertyId($propertyId);
 					$resultList->merge(
 						$this->crossCheckExternalValues(
 							$dumpMetaInformation,
 							$identifierPropertyId,
 							$externalId,
 							$externalValues,
-							$statements->getByPropertyId( $propertyId ),
+							$statements->getByPropertyId($propertyId),
 							$comparativeValueParser
 						)
 					);
@@ -228,10 +228,10 @@ 
 	) {
 		$resultList = new CrossCheckResultList();
 
-		foreach ( $statements->toArray() as $statement ) {
-			$comparisonResult = $this->compareStatement( $statement, $externalValues, $comparativeValueParser );
+		foreach ($statements->toArray() as $statement) {
+			$comparisonResult = $this->compareStatement($statement, $externalValues, $comparativeValueParser);
 
-			if ( $comparisonResult ) {
+			if ($comparisonResult) {
 				$referencesResult = $this->referenceHandler->checkForReferences(
 					$statement,
 					$identifierPropertyId,
@@ -265,32 +265,32 @@ 
 	 * @return ComparisonResult|bool
 	 */
 	private function compareStatement(
-		Statement $statement,array $externalValues,
+		Statement $statement, array $externalValues,
 		ComparativeValueParser $comparativeValueParser
 	) {
 		$mainSnak = $statement->getMainSnak();
-		if ( $mainSnak instanceof PropertyValueSnak ) {
+		if ($mainSnak instanceof PropertyValueSnak) {
 			$dataValue = $mainSnak->getDataValue();
 
 			$results = array();
-			$comparativeValues = $this->parseExternalValues( $dataValue, $externalValues, $comparativeValueParser );
-			foreach ( $comparativeValues as $comparativeValue ) {
-				$result = $this->dataValueComparer->compare( $dataValue, $comparativeValue );
-				if( $result ) {
+			$comparativeValues = $this->parseExternalValues($dataValue, $externalValues, $comparativeValueParser);
+			foreach ($comparativeValues as $comparativeValue) {
+				$result = $this->dataValueComparer->compare($dataValue, $comparativeValue);
+				if ($result) {
 					$results[] = $result;
 				}
 			}
 
-			if( $results ) {
+			if ($results) {
 				$result = ComparisonResult::STATUS_MISMATCH;
-				if( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
+				if (in_array(ComparisonResult::STATUS_MATCH, $results)) {
 					$result = ComparisonResult::STATUS_MATCH;
 				}
-				elseif( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
+				elseif (in_array(ComparisonResult::STATUS_PARTIAL_MATCH, $results)) {
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 				}
 
-				return new ComparisonResult( $dataValue, $comparativeValues, $result );
+				return new ComparisonResult($dataValue, $comparativeValues, $result);
 			}
 		}
 
@@ -310,14 +310,14 @@ 
 		ComparativeValueParser $comparativeValueParser
 	) {
 		$parsedValues = array();
-		foreach ( $externalValues as $externalValue ) {
+		foreach ($externalValues as $externalValue) {
 			try {
-				$parsedValue = $comparativeValueParser->parse( $externalValue, $dataValue->getType() );
-				if( $parsedValue ) {
+				$parsedValue = $comparativeValueParser->parse($externalValue, $dataValue->getType());
+				if ($parsedValue) {
 					$parsedValues[] = $parsedValue;
 				}
 			}
-			catch( ParseException $e ) {}
+			catch (ParseException $e) {}
 		}
 
 		return $parsedValues;
@@ -331,12 +331,12 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function getExternalIds( StatementList $statements, PropertyId $identifierPropertyId ) {
+	private function getExternalIds(StatementList $statements, PropertyId $identifierPropertyId) {
 		$externalIds = array();
-		$identifierStatements = $statements->getByPropertyId( $identifierPropertyId );
-		$values = $this->getDataValues( $identifierStatements );
-		foreach ( $values as $value ) {
-			if ( $value instanceof StringValue ) {
+		$identifierStatements = $statements->getByPropertyId($identifierPropertyId);
+		$values = $this->getDataValues($identifierStatements);
+		foreach ($values as $value) {
+			if ($value instanceof StringValue) {
 				$externalIds[] = $value->getValue();
 			}
 		}
@@ -348,15 +348,15 @@ 
 	 * @param PropertyId $identifierPropertyId
 	 * @return bool
 	 */
-	private function isIdentifierProperty( PropertyId $identifierPropertyId ) {
+	private function isIdentifierProperty(PropertyId $identifierPropertyId) {
 		/** @var Property $property */
-		$property = $this->entityLookup->getEntity( $identifierPropertyId );
-		$instanceOfPropertyId = new PropertyId( INSTANCE_OF_PID );
-		$statements = $property->getStatements()->getByPropertyId( $instanceOfPropertyId );
-		$values = $this->getDataValues( $statements );
-		foreach ( $values as $value ) {
-			if( $value instanceof EntityIdValue ) {
-				if( $value->getEntityId()->getSerialization() === IDENTIFIER_PROPERTY_QID ) {
+		$property = $this->entityLookup->getEntity($identifierPropertyId);
+		$instanceOfPropertyId = new PropertyId(INSTANCE_OF_PID);
+		$statements = $property->getStatements()->getByPropertyId($instanceOfPropertyId);
+		$values = $this->getDataValues($statements);
+		foreach ($values as $value) {
+			if ($value instanceof EntityIdValue) {
+				if ($value->getEntityId()->getSerialization() === IDENTIFIER_PROPERTY_QID) {
 					return true;
 				}
 			}
@@ -371,12 +371,12 @@ 
 	 * @param StatementList $statementList
 	 * @return DataValue[]
 	 */
-	private function getDataValues( StatementList $statementList ){
+	private function getDataValues(StatementList $statementList) {
 		$dataValues = array();
 
-		foreach ( $statementList->toArray() as $statement ) {
+		foreach ($statementList->toArray() as $statement) {
 			$mainSnak = $statement->getMainSnak();
-			if ( $mainSnak instanceof PropertyValueSnak ) {
+			if ($mainSnak instanceof PropertyValueSnak) {
 				$dataValues[] = $mainSnak->getDataValue();
 			}
 		}

includes/CrossCheck/ReferenceChecker.php

Spacing +9 added lines, -9 removed lines

@@ -34,17 +34,17 @@ 
 	 * @throws InvalidArgumentException
 	 * @return ReferenceResult
 	 */
-	public function checkForReferences( Statement $statement, PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+	public function checkForReferences(Statement $statement, PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
+		Assert::parameterType('string', $externalId, '$externalId');
 
-		if ( count( $statement->getReferences() ) === 0 ) {
+		if (count($statement->getReferences()) === 0) {
 			$status = ReferenceResult::STATUS_REFERENCES_MISSING;
 		} else {
 			$status = ReferenceResult::STATUS_REFERENCES_STATED;
 		}
 
-		$externalReference = $this->buildReference( $identifierPropertyId, $externalId, $dumpMetaInformation );
-		return new ReferenceResult( $status, $externalReference );
+		$externalReference = $this->buildReference($identifierPropertyId, $externalId, $dumpMetaInformation);
+		return new ReferenceResult($status, $externalReference);
 	}
 
 	/**
@@ -55,15 +55,15 @@ 
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 * @return Reference
 	 */
-	private function buildReference( PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
+	private function buildReference(PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
 		$sourceItemId = $dumpMetaInformation->getSourceItemId();
 		$statedInAuthoritySnak = new PropertyValueSnak(
-			new PropertyId( STATED_IN_PID ),
-			new EntityIdValue( $sourceItemId )
+			new PropertyId(STATED_IN_PID),
+			new EntityIdValue($sourceItemId)
 		);
 		$authorityWithExternalIdSnak = new PropertyValueSnak(
 			$identifierPropertyId,
-			new StringValue( $externalId )
+			new StringValue($externalId)
 		);
 
 		return new Reference(

includes/CrossCheck/Result/CrossCheckResult.php

Spacing +4 added lines, -4 removed lines

@@ -65,14 +65,14 @@
 	 * @param ReferenceResult $referenceResult
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( PropertyId $propertyId,
+	public function __construct(PropertyId $propertyId,
 								 $claimGuid,
 								 $externalId,
 								 DumpMetaInformation $dumpMetaInformation,
 								 ComparisonResult $comparisonResult,
-								 ReferenceResult $referenceResult ) {
-		Assert::parameterType( 'string', $claimGuid, '$claimGuid' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+								 ReferenceResult $referenceResult) {
+		Assert::parameterType('string', $claimGuid, '$claimGuid');
+		Assert::parameterType('string', $externalId, '$externalId');
 
 		$this->propertyId = $propertyId;
 		$this->claimGuid = $claimGuid;

includes/CrossCheck/Result/ReferenceResult.php

Spacing +7 added lines, -7 removed lines

@@ -36,10 +36,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $status, Reference $reference ) {
+	public function __construct($status, Reference $reference) {
 
 		$this->reference = $reference;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -61,14 +61,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			array( self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED )
+			array(self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED)
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;

includes/CrossCheck/ValueParser/ComparativeValueParser.php

Spacing +9 added lines, -9 removed lines

@@ -38,7 +38,7 @@ 
 		ValueParserFactory $comparativeValueParserFactory,
 		$languageCode
 	) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
+		Assert::parameterType('string', $languageCode, '$languageCode');
 
 		$this->comparativeValueParserFactory = $comparativeValueParserFactory;
 		$this->languageCode = $languageCode;
@@ -52,11 +52,11 @@ 
 	 *
 	 * @return DataValue
 	 */
-	public function parse( $value, $propertyType ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterType( 'string', $propertyType, '$propertyType' );
+	public function parse($value, $propertyType) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterType('string', $propertyType, '$propertyType');
 
-		return $this->getValueParser( $propertyType )->parse( $value );
+		return $this->getValueParser($propertyType)->parse($value);
 	}
 
 	/**
@@ -64,8 +64,8 @@ 
 	 *
 	 * @return ValueParser
 	 */
-	private function getValueParser( $type ) {
-		if( !array_key_exists( $type, $this->valueParsers ) ) {
+	private function getValueParser($type) {
+		if (!array_key_exists($type, $this->valueParsers)) {
 			$parserOptions = $this->getParserOptions();
 			$this->valueParsers[$type] = $this->comparativeValueParserFactory->newParser(
 				$type,
@@ -81,8 +81,8 @@ 
 	 */
 	private function getParserOptions() {
 		$options = new ParserOptions();
-		$options->setOption( 'valuelang', $this->languageCode );
-		$options->setOption( ValueParser::OPT_LANG, $this->languageCode );
+		$options->setOption('valuelang', $this->languageCode);
+		$options->setOption(ValueParser::OPT_LANG, $this->languageCode);
 
 		return $options;
 	}

includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php

Spacing +10 added lines, -10 removed lines

@@ -43,7 +43,7 @@ 
 	) {
 		$dataTypeIds = $dataTypeDefinitions->getTypeIds();
 
-		if ( !in_array( 'monolingualtext', $dataTypeIds ) ) {
+		if (!in_array('monolingualtext', $dataTypeIds)) {
 			throw new InvalidArgumentException(
 				'monolingualtext must be defined in the DataTypeDefinitions.'
 			);
@@ -58,21 +58,21 @@ 
 	 *
 	 * @return MultilingualTextValueParser
 	 */
-	public function newMultilingualTextValueParser( ParserOptions $options = null ) {
+	public function newMultilingualTextValueParser(ParserOptions $options = null) {
 		$options = $options ?: new ParserOptions();
 		$monolingualTextValueParser = $this->getValueParserFactory()->newParser(
 			'monolingualtext',
 			$options
 		);
 
-		return new MultilingualTextValueParser( $monolingualTextValueParser );
+		return new MultilingualTextValueParser($monolingualTextValueParser);
 	}
 
 	/**
 	 * @return StringValueParser
 	 */
 	public function newStringValueParser() {
-		return new StringValueParser( $this->stringNormalizer );
+		return new StringValueParser($this->stringNormalizer);
 	}
 
 	/**
@@ -80,8 +80,8 @@ 
 	 *
 	 * @return ComparativeValueParser
 	 */
-	public function newComparativeValueParser( $languageCode ) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
+	public function newComparativeValueParser($languageCode) {
+		Assert::parameterType('string', $languageCode, '$languageCode');
 
 		return new ComparativeValueParser(
 			$this->getValueParserFactory(),
@@ -100,14 +100,14 @@ 
 	 * @return ValueParserFactory
 	 */
 	private function getValueParserFactory() {
-		if ( $this->valueParserFactory === null ) {
+		if ($this->valueParserFactory === null) {
 			$callbacks = $this->dataTypeDefinitions->getParserFactoryCallbacks();
 
-			$callbacks['string'] = array( $this, 'newStringValueParser' );
-			$callbacks['multilingualtext'] = array( $this, 'newMultilingualTextValueParser' );
+			$callbacks['string'] = array($this, 'newStringValueParser');
+			$callbacks['multilingualtext'] = array($this, 'newMultilingualTextValueParser');
 			$callbacks['wikibase-entityid'] = $callbacks['monolingualtext'];
 
-			$this->valueParserFactory = new ValueParserFactory( $callbacks );
+			$this->valueParserFactory = new ValueParserFactory($callbacks);
 		}
 
 		return $this->valueParserFactory;

includes/CrossCheck/ValueParser/MultilingualTextValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
 	/**
 	 * @param ValueParser $monolingualTextValueParser
 	 */
-	public function __construct( ValueParser $monolingualTextValueParser ) {
+	public function __construct(ValueParser $monolingualTextValueParser) {
 		$this->monolingualTextValueParser = $monolingualTextValueParser;
 	}
 
@@ -32,11 +32,11 @@ 
 	 *
 	 * @return MultilingualTextValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
 		return new MultilingualTextValue(
-			array( $this->monolingualTextValueParser->parse( $value ) )
+			array($this->monolingualTextValueParser->parse($value))
 		);
 	}
 

includes/CrossCheck/ValueParser/StringValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
 	/**
 	 * @param StringNormalizer $stringNormalizer
 	 */
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -28,10 +28,10 @@ 
 	 *
 	 * @return StringValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
-		return new StringValue( $this->stringNormalizer->trimToNFC( $value ) );
+		return new StringValue($this->stringNormalizer->trimToNFC($value));
 	}
 
 }