wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/ValueParser/MultilingualTextValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
 	/**
 	 * @param ValueParser $monolingualTextValueParser
 	 */
-	public function __construct( ValueParser $monolingualTextValueParser ) {
+	public function __construct(ValueParser $monolingualTextValueParser) {
 		$this->monolingualTextValueParser = $monolingualTextValueParser;
 	}
 
@@ -32,11 +32,11 @@ 
 	 *
 	 * @return MultilingualTextValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
 		return new MultilingualTextValue(
-			array( $this->monolingualTextValueParser->parse( $value ) )
+			array($this->monolingualTextValueParser->parse($value))
 		);
 	}
 

includes/CrossCheck/ValueParser/StringValueParser.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
 	/**
 	 * @param StringNormalizer $stringNormalizer
 	 */
-	public function __construct( StringNormalizer $stringNormalizer ) {
+	public function __construct(StringNormalizer $stringNormalizer) {
 		$this->stringNormalizer = $stringNormalizer;
 	}
 
@@ -28,10 +28,10 @@ 
 	 *
 	 * @return StringValue
 	 */
-	public function parse( $value ) {
-		Assert::parameterType( 'string', $value, '$value' );
+	public function parse($value) {
+		Assert::parameterType('string', $value, '$value');
 
-		return new StringValue( $this->stringNormalizer->trimToNFC( $value ) );
+		return new StringValue($this->stringNormalizer->trimToNFC($value));
 	}
 
 }

includes/DumpMetaInformation/DumpMetaInformationLookup.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
 	 * @return DumpMetaInformation
 	 * @throws \InvalidArgumentException
 	 */
-	public function getWithId( $dumpId );
+	public function getWithId($dumpId);
 
 	/**
 	 * Gets DumpMetaInformation for specific dump ids from database
@@ -30,7 +30,7 @@ 
 	 * @return DumpMetaInformation[]
 	 * @throws \InvalidArgumentException
 	 */
-	public function getWithIds( array $dumpIds );
+	public function getWithIds(array $dumpIds);
 
 	/**
 	 * Gets DumpMetaInformation for specific identifier properties from database
@@ -40,7 +40,7 @@ 
 	 *
 	 * @return DumpMetaInformation[]
 	 */
-	public function getWithIdentifierProperties( array $identifierPropertyIds );
+	public function getWithIdentifierProperties(array $identifierPropertyIds);
 
 	/**
 	 * Gets id of item that represents the data source for each dump.

includes/DumpMetaInformation/DumpMetaInformationStore.php

Spacing +1 added lines, -1 removed lines

@@ -15,6 +15,6 @@
 	 *
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 */
-	public function save( DumpMetaInformation $dumpMetaInformation );
+	public function save(DumpMetaInformation $dumpMetaInformation);
 
 }

includes/ExternalDataRepo.php

Braces +1 added lines, -2 removed lines

@@ -102,8 +102,7 @@
 			$db->begin();
 			$result = $db->insert( self::TABLE_NAME, $accumulator );
 			$db->commit();
-		}
-		catch( DBError $ex ) {
+		} catch( DBError $ex ) {
 			$db->rollback();
 			throw $ex;
 		}

Spacing +31 added lines, -31 removed lines

@@ -24,23 +24,23 @@ 
 	 * @param PropertyId[] $propertyIds
 	 * @return array
 	 */
-	public function getExternalData( array $dumpIds, array $externalIds, array $propertyIds ) {
-		Assert::parameterElementType( 'string', $dumpIds, '$dumpIds' );
-		Assert::parameterElementType( 'string', $externalIds, '$externalIds' );
-		Assert::parameterElementType( PropertyId::class, $propertyIds, '$propertyIds' );
-		Assert::parameter( count( $dumpIds ) > 0, '$dumpIds', '$dumpIds has to contain at least one element.' );
-		Assert::parameter( count( $externalIds ) > 0, '$externalIds', '$externalIds has to contain at least one element.' );
+	public function getExternalData(array $dumpIds, array $externalIds, array $propertyIds) {
+		Assert::parameterElementType('string', $dumpIds, '$dumpIds');
+		Assert::parameterElementType('string', $externalIds, '$externalIds');
+		Assert::parameterElementType(PropertyId::class, $propertyIds, '$propertyIds');
+		Assert::parameter(count($dumpIds) > 0, '$dumpIds', '$dumpIds has to contain at least one element.');
+		Assert::parameter(count($externalIds) > 0, '$externalIds', '$externalIds has to contain at least one element.');
 
 		$conditions = array(
 			'dump_id' => $dumpIds,
 			'external_id' => $externalIds
 		);
-		if ( $propertyIds ) {
+		if ($propertyIds) {
 			$conditions['pid'] = $propertyIds;
 		}
 
 		$externalData = array();
-		$db = wfGetDB( DB_SLAVE );
+		$db = wfGetDB(DB_SLAVE);
 		$result = $db->select(
 			self::TABLE_NAME,
 			array(
@@ -52,7 +52,7 @@ 
 			$conditions
 		);
 
-		foreach ( $result as $row ) {
+		foreach ($result as $row) {
 			$externalData[$row->dump_id][$row->external_id][$row->pid][] = $row->external_value;
 		}
 
@@ -68,13 +68,13 @@ 
 	 * @param string $externalValue
 	 * @return bool
 	 */
-	public function insert( $dumpId, $externalId, PropertyId $propertyId, $externalValue ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
-		Assert::parameterType( 'string', $externalValue, '$externalValue' );
+	public function insert($dumpId, $externalId, PropertyId $propertyId, $externalValue) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		Assert::parameterType('string', $externalId, '$externalId');
+		Assert::parameterType('string', $externalValue, '$externalValue');
 
-		$externalDataBatch = array( func_get_args() );
-		return $this->insertBatch( $externalDataBatch );
+		$externalDataBatch = array(func_get_args());
+		return $this->insertBatch($externalDataBatch);
 	}
 
 	/**
@@ -84,10 +84,10 @@ 
 	 * @throws DBError
 	 * @return bool
 	 */
-	public function insertBatch( array $externalDataBatch ) {
-		$db = wfGetDB( DB_MASTER );
+	public function insertBatch(array $externalDataBatch) {
+		$db = wfGetDB(DB_MASTER);
 		$accumulator = array_map(
-			function ( $externalData ) use ( $db ) {
+			function($externalData) use ($db) {
 				return array(
 					'dump_id' => $externalData[0],
 					'external_id' => $externalData[1],
@@ -100,10 +100,10 @@ 
 
 		try {
 			$db->begin();
-			$result = $db->insert( self::TABLE_NAME, $accumulator );
+			$result = $db->insert(self::TABLE_NAME, $accumulator);
 			$db->commit();
 		}
-		catch( DBError $ex ) {
+		catch (DBError $ex) {
 			$db->rollback();
 			throw $ex;
 		}
@@ -118,21 +118,21 @@ 
 	 * @param int $batchSize
 	 * @throws \DBUnexpectedError
 	 */
-	public function deleteOfDump( $dumpId, $batchSize = 1000 ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		Assert::parameterType( 'integer', $batchSize, 'batchSize' );
+	public function deleteOfDump($dumpId, $batchSize = 1000) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		Assert::parameterType('integer', $batchSize, 'batchSize');
 
-		$db = wfGetDB( DB_MASTER );
-		if ( $db->getType() === 'sqlite' ) {
-			$db->delete( self::TABLE_NAME, array( 'dump_id' => $dumpId ) );
+		$db = wfGetDB(DB_MASTER);
+		if ($db->getType() === 'sqlite') {
+			$db->delete(self::TABLE_NAME, array('dump_id' => $dumpId));
 		} else {
 			do {
-				$db->commit( __METHOD__, 'flush' );
+				$db->commit(__METHOD__, 'flush');
 				wfWaitForSlaves();
-				$table = $db->tableName( self::TABLE_NAME );
-				$condition = 'dump_id = ' . $db->addQuotes( $dumpId );
-				$db->query( sprintf( 'DELETE FROM %s WHERE %s LIMIT %s', $table, $condition, $batchSize ) );
-			} while ( $db->affectedRows() > 0 );
+				$table = $db->tableName(self::TABLE_NAME);
+				$condition = 'dump_id = ' . $db->addQuotes($dumpId);
+				$db->query(sprintf('DELETE FROM %s WHERE %s LIMIT %s', $table, $condition, $batchSize));
+			} while ($db->affectedRows() > 0);
 		}
 	}
 

includes/ExternalValidationServices.php

Spacing +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @fixme inject specific things needed here instead of the WikibaseRepo factory. (T112105)
 	 */
-	public function __construct( WikibaseRepo $wikibaseRepo ) {
+	public function __construct(WikibaseRepo $wikibaseRepo) {
 		$this->wikibaseRepo = $wikibaseRepo;
 	}
 
@@ -88,7 +88,7 @@ 
 		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 
-			$instance = new self( $wikibaseRepo );
+			$instance = new self($wikibaseRepo);
 		}
 
 		return $instance;

includes/Serializer/ComparisonResultSerializer.php

Spacing +10 added lines, -10 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param Serializer $dataValueSerializer
 	 */
-	public function __construct( Serializer $dataValueSerializer ) {
+	public function __construct(Serializer $dataValueSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 	}
 
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ComparisonResult;
 	}
 
@@ -45,29 +45,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ComparisonResult $comparisonResult ) {
+	private function getSerialized(ComparisonResult $comparisonResult) {
 		$dataValueSerializer = $this->dataValueSerializer;
 		$externalValues = array_map(
-			function ( $dataValue ) use ( $dataValueSerializer ) {
-				return $dataValueSerializer->serialize( $dataValue );
+			function($dataValue) use ($dataValueSerializer) {
+				return $dataValueSerializer->serialize($dataValue);
 			},
 			$comparisonResult->getExternalValues()
 		);
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
+		$this->setIndexedTagName($externalValues, 'dataValue');
 
 		return array(
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
 			'externalValues' => $externalValues,
 			'result' => $comparisonResult->getStatus()
 		);

includes/Serializer/CrossCheckResultListSerializer.php

Spacing +11 added lines, -11 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param Serializer $crossCheckResultSerializer
 	 */
-	public function __construct( Serializer $crossCheckResultSerializer ) {
+	public function __construct(Serializer $crossCheckResultSerializer) {
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
 	}
 
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResultList;
 	}
 
@@ -45,29 +45,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResultList $resultList ) {
+	private function getSerialized(CrossCheckResultList $resultList) {
 		$serialization = array();
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
+		$this->setKeyAttributeName($serialization, 'property', 'id');
 
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
+		foreach ($resultList->getPropertyIds() as $propertyId) {
 			$id = $propertyId->getSerialization();
 			$resultSerialization = array();
 
-			$this->setIndexedTagName( $resultSerialization, 'result' );
+			$this->setIndexedTagName($resultSerialization, 'result');
 
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
 			}
 
 			$serialization[$id] = $resultSerialization;

includes/Serializer/CrossCheckResultSerializer.php

Spacing +9 added lines, -9 removed lines

@@ -34,7 +34,7 @@ 
 	 * @param Serializer $comparisonResultSerializer
 	 * @param Serializer $referenceResultSerializer
 	 */
-	public function __construct( Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer ) {
+	public function __construct(Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer) {
 		$this->dumpMetaInformationSerializer = $dumpMetaInformationSerializer;
 		$this->comparisonResultSerializer = $comparisonResultSerializer;
 		$this->referenceResultSerializer = $referenceResultSerializer;
@@ -47,7 +47,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResult;
 	}
 
@@ -59,25 +59,25 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultSerializer can only serialize CrossCheckResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResult $crossCheckResult ) {
+	private function getSerialized(CrossCheckResult $crossCheckResult) {
 		return array(
 			'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(),
 			'claimGuid' => $crossCheckResult->getClaimGuid(),
 			'externalId' => $crossCheckResult->getExternalId(),
-			'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ),
-			'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ),
-			'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() )
+			'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()),
+			'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()),
+			'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult())
 		);
 	}