Completed
Push — master ( 0d0d38...426f9c )
by
unknown
03:10
created
includes/DumpMetaInformation/DumpMetaInformationLookup.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	 * @return DumpMetaInformation
21 21
 	 * @throws \InvalidArgumentException
22 22
 	 */
23
-	public function getWithId( $dumpId );
23
+	public function getWithId($dumpId);
24 24
 
25 25
 	/**
26 26
 	 * Gets DumpMetaInformation for specific dump ids from database
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 	 * @return DumpMetaInformation[]
31 31
 	 * @throws \InvalidArgumentException
32 32
 	 */
33
-	public function getWithIds( array $dumpIds );
33
+	public function getWithIds(array $dumpIds);
34 34
 
35 35
 	/**
36 36
 	 * Gets DumpMetaInformation for specific identifier properties from database
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 *
41 41
 	 * @return DumpMetaInformation[]
42 42
 	 */
43
-	public function getWithIdentifierProperties( array $identifierPropertyIds );
43
+	public function getWithIdentifierProperties(array $identifierPropertyIds);
44 44
 
45 45
 	/**
46 46
 	 * Gets id of item that represents the data source for each dump.
Please login to merge, or discard this patch.
includes/DumpMetaInformation/DumpMetaInformationStore.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,6 +15,6 @@
 block discarded – undo
15 15
 	 *
16 16
 	 * @param DumpMetaInformation $dumpMetaInformation
17 17
 	 */
18
-	public function save( DumpMetaInformation $dumpMetaInformation );
18
+	public function save(DumpMetaInformation $dumpMetaInformation);
19 19
 
20 20
 }
Please login to merge, or discard this patch.
includes/ExternalValidationServices.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 *
73 73
 	 * @fixme inject specific things needed here instead of the WikibaseRepo factory. (T112105)
74 74
 	 */
75
-	public function __construct( WikibaseRepo $wikibaseRepo ) {
75
+	public function __construct(WikibaseRepo $wikibaseRepo) {
76 76
 		$this->wikibaseRepo = $wikibaseRepo;
77 77
 	}
78 78
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 		if ($instance === null) {
89 89
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
90 90
 
91
-			$instance = new self( $wikibaseRepo );
91
+			$instance = new self($wikibaseRepo);
92 92
 		}
93 93
 
94 94
 		return $instance;
Please login to merge, or discard this patch.
includes/Serializer/ComparisonResultSerializer.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $dataValueSerializer
24 24
 	 */
25
-	public function __construct( Serializer $dataValueSerializer ) {
25
+	public function __construct(Serializer $dataValueSerializer) {
26 26
 		$this->dataValueSerializer = $dataValueSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ComparisonResult;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ComparisonResult $comparisonResult ) {
59
+	private function getSerialized(ComparisonResult $comparisonResult) {
60 60
 		$dataValueSerializer = $this->dataValueSerializer;
61 61
 		$externalValues = array_map(
62
-			function ( $dataValue ) use ( $dataValueSerializer ) {
63
-				return $dataValueSerializer->serialize( $dataValue );
62
+			function($dataValue) use ($dataValueSerializer) {
63
+				return $dataValueSerializer->serialize($dataValue);
64 64
 			},
65 65
 			$comparisonResult->getExternalValues()
66 66
 		);
67
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
67
+		$this->setIndexedTagName($externalValues, 'dataValue');
68 68
 
69 69
 		return array(
70
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
70
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
71 71
 			'externalValues' => $externalValues,
72 72
 			'result' => $comparisonResult->getStatus()
73 73
 		);
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultListSerializer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $crossCheckResultSerializer
24 24
 	 */
25
-	public function __construct( Serializer $crossCheckResultSerializer ) {
25
+	public function __construct(Serializer $crossCheckResultSerializer) {
26 26
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof CrossCheckResultList;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( CrossCheckResultList $resultList ) {
59
+	private function getSerialized(CrossCheckResultList $resultList) {
60 60
 		$serialization = array();
61
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
61
+		$this->setKeyAttributeName($serialization, 'property', 'id');
62 62
 
63
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
63
+		foreach ($resultList->getPropertyIds() as $propertyId) {
64 64
 			$id = $propertyId->getSerialization();
65 65
 			$resultSerialization = array();
66 66
 
67
-			$this->setIndexedTagName( $resultSerialization, 'result' );
67
+			$this->setIndexedTagName($resultSerialization, 'result');
68 68
 
69
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
70
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
69
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
70
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
71 71
 			}
72 72
 
73 73
 			$serialization[$id] = $resultSerialization;
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultSerializer.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * @param Serializer $comparisonResultSerializer
35 35
 	 * @param Serializer $referenceResultSerializer
36 36
 	 */
37
-	public function __construct( Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer ) {
37
+	public function __construct(Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer) {
38 38
 		$this->dumpMetaInformationSerializer = $dumpMetaInformationSerializer;
39 39
 		$this->comparisonResultSerializer = $comparisonResultSerializer;
40 40
 		$this->referenceResultSerializer = $referenceResultSerializer;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	 *
48 48
 	 * @return bool
49 49
 	 */
50
-	public function isSerializerFor( $object ) {
50
+	public function isSerializerFor($object) {
51 51
 		return $object instanceof CrossCheckResult;
52 52
 	}
53 53
 
@@ -59,25 +59,25 @@  discard block
 block discarded – undo
59 59
 	 * @return array
60 60
 	 * @throws UnsupportedObjectException
61 61
 	 */
62
-	public function serialize( $object ) {
63
-		if ( !$this->isSerializerFor( $object ) ) {
62
+	public function serialize($object) {
63
+		if (!$this->isSerializerFor($object)) {
64 64
 			throw new UnsupportedObjectException(
65 65
 				$object,
66 66
 				'CrossCheckResultSerializer can only serialize CrossCheckResult objects.'
67 67
 			);
68 68
 		}
69 69
 
70
-		return $this->getSerialized( $object );
70
+		return $this->getSerialized($object);
71 71
 	}
72 72
 
73
-	private function getSerialized( CrossCheckResult $crossCheckResult ) {
73
+	private function getSerialized(CrossCheckResult $crossCheckResult) {
74 74
 		return array(
75 75
 			'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(),
76 76
 			'claimGuid' => $crossCheckResult->getClaimGuid(),
77 77
 			'externalId' => $crossCheckResult->getExternalId(),
78
-			'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ),
79
-			'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ),
80
-			'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() )
78
+			'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()),
79
+			'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()),
80
+			'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult())
81 81
 		);
82 82
 	}
83 83
 
Please login to merge, or discard this patch.
includes/Serializer/IndexedTagsSerializer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@  discard block
 block discarded – undo
20 20
 	 * @param array &$arr
21 21
 	 * @param string $tag
22 22
 	 */
23
-	protected function setIndexedTagName( array &$arr, $tag ) {
24
-		ApiResult::setIndexedTagName( $arr, $tag );
23
+	protected function setIndexedTagName(array &$arr, $tag) {
24
+		ApiResult::setIndexedTagName($arr, $tag);
25 25
 	}
26 26
 
27 27
 	/**
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
 	 * @param string $tagName
34 34
 	 * @param string $idAttribute
35 35
 	 */
36
-	protected function setKeyAttributeName( array &$arr, $tagName, $idAttribute ) {
37
-		ApiResult::setArrayType( $arr, 'kvp', $idAttribute );
38
-		ApiResult::setIndexedTagName( $arr, $tagName );
36
+	protected function setKeyAttributeName(array &$arr, $tagName, $idAttribute) {
37
+		ApiResult::setArrayType($arr, 'kvp', $idAttribute);
38
+		ApiResult::setIndexedTagName($arr, $tagName);
39 39
 	}
40 40
 
41 41
 }
Please login to merge, or discard this patch.
includes/Serializer/ReferenceResultSerializer.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $referenceSerializer
24 24
 	 */
25
-	public function __construct( Serializer $referenceSerializer ) {
25
+	public function __construct(Serializer $referenceSerializer) {
26 26
 		$this->referenceSerializer = $referenceSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ReferenceResult;
38 38
 	}
39 39
 
@@ -45,20 +45,20 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ReferenceResult $referenceResult ) {
59
+	private function getSerialized(ReferenceResult $referenceResult) {
60 60
 		return array(
61
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
61
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
62 62
 			'status' => $referenceResult->getStatus()
63 63
 		);
64 64
 	}
Please login to merge, or discard this patch.
includes/Serializer/SerializerFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 * @param Serializer $dataValueSerializer
26 26
 	 * @param Serializer $referenceSerializer
27 27
 	 */
28
-	public function __construct( Serializer $dataValueSerializer, Serializer $referenceSerializer ) {
28
+	public function __construct(Serializer $dataValueSerializer, Serializer $referenceSerializer) {
29 29
 		$this->dataValueSerializer = $dataValueSerializer;
30 30
 		$this->referenceSerializer = $referenceSerializer;
31 31
 	}
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	 * @return Serializer
48 48
 	 */
49 49
 	public function newComparisonResultSerializer() {
50
-		return new ComparisonResultSerializer( $this->dataValueSerializer );
50
+		return new ComparisonResultSerializer($this->dataValueSerializer);
51 51
 	}
52 52
 
53 53
 	/**
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	 * @return Serializer
79 79
 	 */
80 80
 	public function newReferenceResultSerializer() {
81
-		return new ReferenceResultSerializer( $this->referenceSerializer );
81
+		return new ReferenceResultSerializer($this->referenceSerializer);
82 82
 	}
83 83
 
84 84
 }
Please login to merge, or discard this patch.