wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/Serializer/DumpMetaInformationSerializer.php

Spacing +8 added lines, -8 removed lines

@@ -21,7 +21,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof DumpMetaInformation;
 	}
 
@@ -33,32 +33,32 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'DumpMetaInformationSerializer can only serialize DumpMetaInformation objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( DumpMetaInformation $dumpMetaInformation ) {
+	private function getSerialized(DumpMetaInformation $dumpMetaInformation) {
 		$identifierPropertyIds = array_map(
-			function( PropertyId $id ) {
+			function(PropertyId $id) {
 				return $id->getSerialization();
 			},
 			$dumpMetaInformation->getIdentifierPropertyIds()
 		);
 
-		$this->setIndexedTagName( $identifierPropertyIds, 'propertyId' );
+		$this->setIndexedTagName($identifierPropertyIds, 'propertyId');
 
 		return [
 			'dumpId' => $dumpMetaInformation->getDumpId(),
 			'sourceItemId' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
 			'identifierPropertyIds' => $identifierPropertyIds,
-			'importDate' => wfTimestamp( TS_ISO_8601, $dumpMetaInformation->getImportDate() ),
+			'importDate' => wfTimestamp(TS_ISO_8601, $dumpMetaInformation->getImportDate()),
 			'language' => $dumpMetaInformation->getLanguageCode(),
 			'sourceUrl' => $dumpMetaInformation->getSourceUrl(),
 			'size' => $dumpMetaInformation->getSize(),

includes/Serializer/CrossCheckResultSerializer.php

Spacing +8 added lines, -8 removed lines

@@ -51,7 +51,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResult;
 	}
 
@@ -63,25 +63,25 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultSerializer can only serialize CrossCheckResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResult $crossCheckResult ) {
+	private function getSerialized(CrossCheckResult $crossCheckResult) {
 		return [
 			'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(),
 			'claimGuid' => $crossCheckResult->getClaimGuid(),
 			'externalId' => $crossCheckResult->getExternalId(),
-			'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ),
-			'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ),
-			'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() )
+			'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()),
+			'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()),
+			'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult())
 		];
 	}
 

includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php

Spacing +10 added lines, -10 removed lines

@@ -43,7 +43,7 @@ 
 	) {
 		$dataTypeIds = $dataTypeDefinitions->getTypeIds();
 
-		if ( !in_array( 'monolingualtext', $dataTypeIds ) ) {
+		if (!in_array('monolingualtext', $dataTypeIds)) {
 			throw new InvalidArgumentException(
 				'monolingualtext must be defined in the DataTypeDefinitions.'
 			);
@@ -58,21 +58,21 @@ 
 	 *
 	 * @return MultilingualTextValueParser
 	 */
-	public function newMultilingualTextValueParser( ParserOptions $options = null ) {
+	public function newMultilingualTextValueParser(ParserOptions $options = null) {
 		$options = $options ?: new ParserOptions();
 		$monolingualTextValueParser = $this->getValueParserFactory()->newParser(
 			'monolingualtext',
 			$options
 		);
 
-		return new MultilingualTextValueParser( $monolingualTextValueParser );
+		return new MultilingualTextValueParser($monolingualTextValueParser);
 	}
 
 	/**
 	 * @return StringValueParser
 	 */
 	public function newStringValueParser() {
-		return new StringValueParser( $this->stringNormalizer );
+		return new StringValueParser($this->stringNormalizer);
 	}
 
 	/**
@@ -80,8 +80,8 @@ 
 	 *
 	 * @return ComparativeValueParser
 	 */
-	public function newComparativeValueParser( $languageCode ) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
+	public function newComparativeValueParser($languageCode) {
+		Assert::parameterType('string', $languageCode, '$languageCode');
 
 		return new ComparativeValueParser(
 			$this->getValueParserFactory(),
@@ -100,14 +100,14 @@ 
 	 * @return ValueParserFactory
 	 */
 	private function getValueParserFactory() {
-		if ( $this->valueParserFactory === null ) {
+		if ($this->valueParserFactory === null) {
 			$callbacks = $this->dataTypeDefinitions->getParserFactoryCallbacks();
 
-			$callbacks['string'] = [ $this, 'newStringValueParser' ];
-			$callbacks['multilingualtext'] = [ $this, 'newMultilingualTextValueParser' ];
+			$callbacks['string'] = [$this, 'newStringValueParser'];
+			$callbacks['multilingualtext'] = [$this, 'newMultilingualTextValueParser'];
 			$callbacks['wikibase-entityid'] = $callbacks['monolingualtext'];
 
-			$this->valueParserFactory = new ValueParserFactory( $callbacks );
+			$this->valueParserFactory = new ValueParserFactory($callbacks);
 		}
 
 		return $this->valueParserFactory;

includes/CrossCheck/Result/ComparisonResult.php

Spacing +8 added lines, -8 removed lines

@@ -45,12 +45,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( DataValue $localValue, array $externalValues, $status ) {
-		Assert::parameterElementType( DataValue::class, $externalValues, '$externalValues' );
+	public function __construct(DataValue $localValue, array $externalValues, $status) {
+		Assert::parameterElementType(DataValue::class, $externalValues, '$externalValues');
 
 		$this->localValue = $localValue;
 		$this->externalValues = $externalValues;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -79,14 +79,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			[ self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH ]
+			[self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH]
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;

includes/CrossCheck/Result/ReferenceResult.php

Spacing +7 added lines, -7 removed lines

@@ -36,10 +36,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $status, Reference $reference ) {
+	public function __construct($status, Reference $reference) {
 
 		$this->reference = $reference;
-		$this->setStatus( $status );
+		$this->setStatus($status);
 	}
 
 	/**
@@ -61,14 +61,14 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setStatus( $status ) {
-		Assert::parameterType( 'string', $status, '$status' );
-		if ( !in_array(
+	private function setStatus($status) {
+		Assert::parameterType('string', $status, '$status');
+		if (!in_array(
 			$status,
-			[ self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED ]
+			[self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED]
 		)
 		) {
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
+			throw new InvalidArgumentException('$status must be one of the status constants.');
 		}
 
 		$this->status = $status;

includes/CrossCheck/Result/CrossCheckResultList.php

Spacing +13 added lines, -13 removed lines

@@ -26,8 +26,8 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( array $results = [] ) {
-		Assert::parameterElementType( CrossCheckResult::class, $results, '$results' );
+	public function __construct(array $results = []) {
+		Assert::parameterElementType(CrossCheckResult::class, $results, '$results');
 
 		$this->results = $results;
 	}
@@ -37,7 +37,7 @@ 
 	 *
 	 * @param CrossCheckResult $result
 	 */
-	public function add( CrossCheckResult $result ) {
+	public function add(CrossCheckResult $result) {
 		$this->results[] = $result;
 	}
 
@@ -46,8 +46,8 @@ 
 	 *
 	 * @param self $resultList
 	 */
-	public function merge( self $resultList ) {
-		$this->results = array_merge( $this->results, $resultList->results );
+	public function merge(self $resultList) {
+		$this->results = array_merge($this->results, $resultList->results);
 	}
 
 	/**
@@ -58,9 +58,9 @@ 
 	public function getPropertyIds() {
 		$propertyIds = [];
 
-		foreach ( $this->results as $result ) {
+		foreach ($this->results as $result) {
 			$propertyId = $result->getPropertyId();
-			if ( !in_array( $propertyId, $propertyIds ) ) {
+			if (!in_array($propertyId, $propertyIds)) {
 				$propertyIds[] = $propertyId;
 			}
 		}
@@ -75,16 +75,16 @@ 
 	 *
 	 * @return self
 	 */
-	public function getByPropertyId( PropertyId $propertyId ) {
+	public function getByPropertyId(PropertyId $propertyId) {
 		$results = [];
 
-		foreach ( $this->results as $result ) {
-			if ( $result->getPropertyId()->equals( $propertyId ) ) {
+		foreach ($this->results as $result) {
+			if ($result->getPropertyId()->equals($propertyId)) {
 				$results[] = $result;
 			}
 		}
 
-		return new self( $results );
+		return new self($results);
 	}
 
 	/**
@@ -103,7 +103,7 @@ 
 	 * @codeCoverageIgnore
 	 */
 	public function getIterator() {
-		return new ArrayIterator( $this->results );
+		return new ArrayIterator($this->results);
 	}
 
 	/**
@@ -112,7 +112,7 @@ 
 	 * @return int
 	 */
 	public function count() {
-		return count( $this->results );
+		return count($this->results);
 	}
 
 }

includes/CrossCheck/Comparer/DispatchingDataValueComparer.php

Spacing +12 added lines, -12 removed lines

@@ -20,8 +20,8 @@ 
 	/**
 	 * @param DataValueComparer[] $dataValueComparers
 	 */
-	public function __construct( array $dataValueComparers = [] ) {
-		$this->assertAreDataValueComparer( $dataValueComparers );
+	public function __construct(array $dataValueComparers = []) {
+		$this->assertAreDataValueComparer($dataValueComparers);
 		$this->dataValueComparers = $dataValueComparers;
 	}
 
@@ -30,9 +30,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	protected function assertAreDataValueComparer( array $dataValueComparers ) {
-		foreach ( $dataValueComparers as $dataValueComparer ) {
-			if ( !is_object( $dataValueComparer ) || !( $dataValueComparer instanceof DataValueComparer ) ) {
+	protected function assertAreDataValueComparer(array $dataValueComparers) {
+		foreach ($dataValueComparers as $dataValueComparer) {
+			if (!is_object($dataValueComparer) || !($dataValueComparer instanceof DataValueComparer)) {
 				throw new InvalidArgumentException(
 					'All $dataValueComparers need to implement the DataValueComparer interface'
 				);
@@ -48,9 +48,9 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
+		foreach ($this->dataValueComparers as $dataValueComparer) {
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
 				return true;
 			}
 		}
@@ -67,10 +67,10 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
-				return $dataValueComparer->compare( $value, $comparativeValue );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		foreach ($this->dataValueComparers as $dataValueComparer) {
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
+				return $dataValueComparer->compare($value, $comparativeValue);
 			}
 		}
 

includes/DumpMetaInformation/DumpMetaInformation.php

Spacing +29 added lines, -29 removed lines

@@ -99,13 +99,13 @@ 
 			'$identifierPropertyIds'
 		);
 
-		$this->setDumpId( $dumpId );
+		$this->setDumpId($dumpId);
 		$this->sourceItemId = $sourceItemId;
 		$this->identifierPropertyIds = $identifierPropertyIds;
-		$this->setImportDate( $importDate );
-		$this->setLanguageCode( $languageCode );
-		$this->setSourceUrl( $sourceUrl );
-		$this->setSize( $size );
+		$this->setImportDate($importDate);
+		$this->setLanguageCode($languageCode);
+		$this->setSourceUrl($sourceUrl);
+		$this->setSize($size);
 		$this->licenseItemId = $licenseItemId;
 	}
 
@@ -170,11 +170,11 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setDumpId( $dumpId ) {
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
-		$length = strlen( $dumpId );
-		if ( $length < 1 || $length > 25 ) {
-			throw new InvalidArgumentException( '$dumpId must be between 1 and 25 characters.' );
+	private function setDumpId($dumpId) {
+		Assert::parameterType('string', $dumpId, '$dumpId');
+		$length = strlen($dumpId);
+		if ($length < 1 || $length > 25) {
+			throw new InvalidArgumentException('$dumpId must be between 1 and 25 characters.');
 		}
 
 		$this->dumpId = $dumpId;
@@ -185,10 +185,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setLanguageCode( $languageCode ) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
-		if ( !Language::isValidCode( $languageCode ) ) {
-			throw new InvalidArgumentException( '$languageCode is not valid.' );
+	private function setLanguageCode($languageCode) {
+		Assert::parameterType('string', $languageCode, '$languageCode');
+		if (!Language::isValidCode($languageCode)) {
+			throw new InvalidArgumentException('$languageCode is not valid.');
 		}
 
 		$this->languageCode = $languageCode;
@@ -199,12 +199,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setImportDate( $importDate ) {
-		Assert::parameterType( 'string', $importDate, '$importDate' );
+	private function setImportDate($importDate) {
+		Assert::parameterType('string', $importDate, '$importDate');
 
-		$timestamp = wfTimestamp( TS_MW, $importDate );
-		if ( !$timestamp ) {
-			throw new InvalidArgumentException( '$updatedAt has invalid timestamp format.' );
+		$timestamp = wfTimestamp(TS_MW, $importDate);
+		if (!$timestamp) {
+			throw new InvalidArgumentException('$updatedAt has invalid timestamp format.');
 		}
 
 		$this->importDate = $importDate;
@@ -215,13 +215,13 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSourceUrl( $sourceUrl ) {
-		Assert::parameterType( 'string', $sourceUrl, '$sourceUrl' );
-		if ( strlen( $sourceUrl ) > 300 ) {
-			throw new InvalidArgumentException( '$sourceUrl must not be longer than 300 characters.' );
+	private function setSourceUrl($sourceUrl) {
+		Assert::parameterType('string', $sourceUrl, '$sourceUrl');
+		if (strlen($sourceUrl) > 300) {
+			throw new InvalidArgumentException('$sourceUrl must not be longer than 300 characters.');
 		}
-		if ( !filter_var( $sourceUrl, FILTER_VALIDATE_URL ) ) {
-			throw new InvalidArgumentException( '$sourceUrl is not a valid url.' );
+		if (!filter_var($sourceUrl, FILTER_VALIDATE_URL)) {
+			throw new InvalidArgumentException('$sourceUrl is not a valid url.');
 		}
 
 		$this->sourceUrl = $sourceUrl;
@@ -232,10 +232,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function setSize( $size ) {
-		Assert::parameterType( 'integer', $size, '$size' );
-		if ( $size <= 0 ) {
-			throw new InvalidArgumentException( '$size must be positive integer.' );
+	private function setSize($size) {
+		Assert::parameterType('integer', $size, '$size');
+		if ($size <= 0) {
+			throw new InvalidArgumentException('$size must be positive integer.');
 		}
 
 		$this->size = $size;

includes/CrossCheck/Result/CrossCheckResult.php

Spacing +2 added lines, -2 removed lines

@@ -73,8 +73,8 @@
 		ComparisonResult $comparisonResult,
 		ReferenceResult $referenceResult
 	) {
-		Assert::parameterType( 'string', $claimGuid, '$claimGuid' );
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+		Assert::parameterType('string', $claimGuid, '$claimGuid');
+		Assert::parameterType('string', $externalId, '$externalId');
 
 		$this->propertyId = $propertyId;
 		$this->claimGuid = $claimGuid;