Completed
Push — master ( 070114...d7d5ea )
by
unknown
05:40
created
includes/CrossCheck/Result/CrossCheckResultList.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
26 26
 	 *
27 27
 	 * @throws InvalidArgumentException
28 28
 	 */
29
-	public function __construct( array $results = array() ) {
30
-		Assert::parameterElementType( CrossCheckResult::class, $results, '$results' );
29
+	public function __construct(array $results = array()) {
30
+		Assert::parameterElementType(CrossCheckResult::class, $results, '$results');
31 31
 
32 32
 		$this->results = $results;
33 33
 	}
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 *
38 38
 	 * @param CrossCheckResult $result
39 39
 	 */
40
-	public function add( CrossCheckResult $result ) {
40
+	public function add(CrossCheckResult $result) {
41 41
 		$this->results[] = $result;
42 42
 	}
43 43
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 	 *
47 47
 	 * @param self $resultList
48 48
 	 */
49
-	public function merge( self $resultList ) {
50
-		$this->results = array_merge( $this->results, $resultList->results );
49
+	public function merge(self $resultList) {
50
+		$this->results = array_merge($this->results, $resultList->results);
51 51
 	}
52 52
 
53 53
 	/**
@@ -58,9 +58,9 @@  discard block
 block discarded – undo
58 58
 	public function getPropertyIds() {
59 59
 		$propertyIds = array();
60 60
 
61
-		foreach ( $this->results as $result ) {
61
+		foreach ($this->results as $result) {
62 62
 			$propertyId = $result->getPropertyId();
63
-			if ( !in_array( $propertyId, $propertyIds ) ) {
63
+			if (!in_array($propertyId, $propertyIds)) {
64 64
 				$propertyIds[] = $propertyId;
65 65
 			}
66 66
 		}
@@ -75,16 +75,16 @@  discard block
 block discarded – undo
75 75
 	 *
76 76
 	 * @return self
77 77
 	 */
78
-	public function getByPropertyId( PropertyId $propertyId ) {
78
+	public function getByPropertyId(PropertyId $propertyId) {
79 79
 		$results = array();
80 80
 
81
-		foreach ( $this->results as $result ) {
82
-			if ( $result->getPropertyId()->equals( $propertyId ) ) {
81
+		foreach ($this->results as $result) {
82
+			if ($result->getPropertyId()->equals($propertyId)) {
83 83
 				$results[] = $result;
84 84
 			}
85 85
 		}
86 86
 
87
-		return new self( $results );
87
+		return new self($results);
88 88
 	}
89 89
 
90 90
 	/**
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 	 * @codeCoverageIgnore
104 104
 	 */
105 105
 	public function getIterator() {
106
-		return new ArrayIterator( $this->results );
106
+		return new ArrayIterator($this->results);
107 107
 	}
108 108
 
109 109
 	/**
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	 * @return int
113 113
 	 */
114 114
 	public function count() {
115
-		return count( $this->results );
115
+		return count($this->results);
116 116
 	}
117 117
 
118 118
 }
Please login to merge, or discard this patch.
includes/CrossCheck/Result/ComparisonResult.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @throws InvalidArgumentException
47 47
 	 */
48
-	public function __construct( DataValue $localValue, array $externalValues, $status ) {
49
-		Assert::parameterElementType( DataValue::class, $externalValues, '$externalValues' );
48
+	public function __construct(DataValue $localValue, array $externalValues, $status) {
49
+		Assert::parameterElementType(DataValue::class, $externalValues, '$externalValues');
50 50
 
51 51
 		$this->localValue = $localValue;
52 52
 		$this->externalValues = $externalValues;
53
-		$this->setStatus( $status );
53
+		$this->setStatus($status);
54 54
 	}
55 55
 
56 56
 	/**
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
79 79
 	 *
80 80
 	 * @throws InvalidArgumentException
81 81
 	 */
82
-	private function setStatus( $status ) {
83
-		Assert::parameterType( 'string', $status, '$status' );
84
-		if ( !in_array(
82
+	private function setStatus($status) {
83
+		Assert::parameterType('string', $status, '$status');
84
+		if (!in_array(
85 85
 			$status,
86
-			array( self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH )
86
+			array(self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH)
87 87
 		)
88 88
 		) {
89
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
89
+			throw new InvalidArgumentException('$status must be one of the status constants.');
90 90
 		}
91 91
 
92 92
 		$this->status = $status;
Please login to merge, or discard this patch.
includes/CrossCheck/Comparer/EntityIdValueComparer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	 * @param TermIndex $termIndex
33 33
 	 * @param StringComparer $stringComparer
34 34
 	 */
35
-	public function __construct( TermIndex $termIndex, StringComparer $stringComparer ) {
35
+	public function __construct(TermIndex $termIndex, StringComparer $stringComparer) {
36 36
 		$this->termIndex = $termIndex;
37 37
 		$this->stringComparer = $stringComparer;
38 38
 	}
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
47 47
 	 */
48
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
49
-		Assert::parameterType( EntityIdValue::class, $value, '$value' );
50
-		Assert::parameterType( MonolingualTextValue::class, $comparativeValue, '$comparativeValue' );
48
+	public function compare(DataValue $value, DataValue $comparativeValue) {
49
+		Assert::parameterType(EntityIdValue::class, $value, '$value');
50
+		Assert::parameterType(MonolingualTextValue::class, $comparativeValue, '$comparativeValue');
51 51
 
52 52
 		/**
53 53
 		 * @var EntityIdValue $value
@@ -56,10 +56,10 @@  discard block
 block discarded – undo
56 56
 
57 57
 		$entityId = $value->getEntityId();
58 58
 		$language = $comparativeValue->getLanguageCode();
59
-		$terms = $this->getTerms( $entityId, $language );
59
+		$terms = $this->getTerms($entityId, $language);
60 60
 
61
-		if ( $terms ) {
62
-			return $this->stringComparer->compareWithArray( $comparativeValue->getText(), $terms );
61
+		if ($terms) {
62
+			return $this->stringComparer->compareWithArray($comparativeValue->getText(), $terms);
63 63
 		}
64 64
 
65 65
 		return null;
@@ -73,18 +73,18 @@  discard block
 block discarded – undo
73 73
 	 *
74 74
 	 * @return array
75 75
 	 */
76
-	private function getTerms( EntityId $entityId, $language ) {
76
+	private function getTerms(EntityId $entityId, $language) {
77 77
 		$terms = $this->termIndex->getTermsOfEntity(
78 78
 			$entityId,
79 79
 			array(
80 80
 				TermIndexEntry::TYPE_LABEL,
81 81
 				TermIndexEntry::TYPE_ALIAS
82 82
 			),
83
-			array( $language )
83
+			array($language)
84 84
 		);
85 85
 
86 86
 		return array_map(
87
-			function( TermIndexEntry $term ) {
87
+			function(TermIndexEntry $term) {
88 88
 				return $term->getText();
89 89
 			},
90 90
 			$terms
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 * @param DataValue $comparativeValue
99 99
 	 * @return bool
100 100
 	 */
101
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
101
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
102 102
 		return $value instanceof EntityIdValue && $comparativeValue instanceof MonolingualTextValue;
103 103
 	}
104 104
 
Please login to merge, or discard this patch.
includes/DumpMetaInformation/DumpMetaInformation.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -83,27 +83,27 @@  discard block
 block discarded – undo
83 83
 	 *
84 84
 	 * @throws InvalidArgumentException
85 85
 	 */
86
-	public function __construct( $dumpId,
86
+	public function __construct($dumpId,
87 87
 								 ItemId $sourceItemId,
88 88
 								 array $identifierPropertyIds,
89 89
 								 $importDate,
90 90
 								 $languageCode,
91 91
 								 $sourceUrl,
92 92
 								 $size,
93
-								 ItemId $licenseItemId ) {
93
+								 ItemId $licenseItemId) {
94 94
 		Assert::parameterElementType(
95 95
 			PropertyId::class,
96 96
 			$identifierPropertyIds,
97 97
 			'$identifierPropertyIds'
98 98
 		);
99 99
 
100
-		$this->setDumpId( $dumpId );
100
+		$this->setDumpId($dumpId);
101 101
 		$this->sourceItemId = $sourceItemId;
102 102
 		$this->identifierPropertyIds = $identifierPropertyIds;
103
-		$this->setImportDate( $importDate );
104
-		$this->setLanguageCode( $languageCode );
105
-		$this->setSourceUrl( $sourceUrl );
106
-		$this->setSize( $size );
103
+		$this->setImportDate($importDate);
104
+		$this->setLanguageCode($languageCode);
105
+		$this->setSourceUrl($sourceUrl);
106
+		$this->setSize($size);
107 107
 		$this->licenseItemId = $licenseItemId;
108 108
 	}
109 109
 
@@ -168,10 +168,10 @@  discard block
 block discarded – undo
168 168
 	 *
169 169
 	 * @throws InvalidArgumentException
170 170
 	 */
171
-	private function setDumpId( $dumpId ) {
172
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
173
-		$length = strlen( $dumpId );
174
-		if ( $length < 1 || $length > 25 ) {
171
+	private function setDumpId($dumpId) {
172
+		Assert::parameterType('string', $dumpId, '$dumpId');
173
+		$length = strlen($dumpId);
174
+		if ($length < 1 || $length > 25) {
175 175
 			throw new InvalidArgumentException('$dumpId must be between 1 and 25 characters.');
176 176
 		}
177 177
 
@@ -183,10 +183,10 @@  discard block
 block discarded – undo
183 183
 	 *
184 184
 	 * @throws InvalidArgumentException
185 185
 	 */
186
-	private function setLanguageCode( $languageCode ) {
187
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
188
-		if( !Language::isValidCode( $languageCode ) ) {
189
-			throw new InvalidArgumentException( '$languageCode is not valid.' );
186
+	private function setLanguageCode($languageCode) {
187
+		Assert::parameterType('string', $languageCode, '$languageCode');
188
+		if (!Language::isValidCode($languageCode)) {
189
+			throw new InvalidArgumentException('$languageCode is not valid.');
190 190
 		}
191 191
 
192 192
 		$this->languageCode = $languageCode;
@@ -197,12 +197,12 @@  discard block
 block discarded – undo
197 197
 	 *
198 198
 	 * @throws InvalidArgumentException
199 199
 	 */
200
-	private function setImportDate( $importDate ) {
201
-		Assert::parameterType( 'string', $importDate, '$importDate' );
200
+	private function setImportDate($importDate) {
201
+		Assert::parameterType('string', $importDate, '$importDate');
202 202
 
203
-		$timestamp = wfTimestamp( TS_MW, $importDate );
204
-		if( !$timestamp ) {
205
-			throw new InvalidArgumentException( '$updatedAt has invalid timestamp format.' );
203
+		$timestamp = wfTimestamp(TS_MW, $importDate);
204
+		if (!$timestamp) {
205
+			throw new InvalidArgumentException('$updatedAt has invalid timestamp format.');
206 206
 		}
207 207
 
208 208
 		$this->importDate = $importDate;
@@ -213,13 +213,13 @@  discard block
 block discarded – undo
213 213
 	 *
214 214
 	 * @throws InvalidArgumentException
215 215
 	 */
216
-	private function setSourceUrl( $sourceUrl ) {
217
-		Assert::parameterType( 'string', $sourceUrl, '$sourceUrl' );
218
-		if( strlen( $sourceUrl ) > 300 ) {
219
-			throw new InvalidArgumentException( '$sourceUrl must not be longer than 300 characters.' );
216
+	private function setSourceUrl($sourceUrl) {
217
+		Assert::parameterType('string', $sourceUrl, '$sourceUrl');
218
+		if (strlen($sourceUrl) > 300) {
219
+			throw new InvalidArgumentException('$sourceUrl must not be longer than 300 characters.');
220 220
 		}
221
-		if( !filter_var($sourceUrl, FILTER_VALIDATE_URL) ) {
222
-			throw new InvalidArgumentException( '$sourceUrl is not a valid url.' );
221
+		if (!filter_var($sourceUrl, FILTER_VALIDATE_URL)) {
222
+			throw new InvalidArgumentException('$sourceUrl is not a valid url.');
223 223
 		}
224 224
 
225 225
 		$this->sourceUrl = $sourceUrl;
@@ -230,10 +230,10 @@  discard block
 block discarded – undo
230 230
 	 *
231 231
 	 * @throws InvalidArgumentException
232 232
 	 */
233
-	private function setSize( $size ){
234
-		Assert::parameterType( 'integer', $size, '$size' );
235
-		if( $size <= 0 ) {
236
-			throw new InvalidArgumentException( '$size must be positive integer.' );
233
+	private function setSize($size) {
234
+		Assert::parameterType('integer', $size, '$size');
235
+		if ($size <= 0) {
236
+			throw new InvalidArgumentException('$size must be positive integer.');
237 237
 		}
238 238
 
239 239
 		$this->size = $size;
Please login to merge, or discard this patch.
WikibaseQualityExternalValidationHooks.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -7,16 +7,16 @@
 block discarded – undo
7 7
 	 *
8 8
 	 * @return bool
9 9
 	 */
10
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
11
-		$updater->addExtensionTable( 'wbqev_dump_information', __DIR__ . '/sql/create_wbqev_dump_information.sql' );
12
-		$updater->addExtensionTable( 'wbqev_external_data', __DIR__ . '/sql/create_wbqev_external_data.sql' );
13
-		$updater->addExtensionTable( 'wbqev_identifier_properties', __DIR__ . '/sql/create_wbqev_identifier_properties.sql' );
10
+	public static function onCreateSchema(DatabaseUpdater $updater) {
11
+		$updater->addExtensionTable('wbqev_dump_information', __DIR__.'/sql/create_wbqev_dump_information.sql');
12
+		$updater->addExtensionTable('wbqev_external_data', __DIR__.'/sql/create_wbqev_external_data.sql');
13
+		$updater->addExtensionTable('wbqev_identifier_properties', __DIR__.'/sql/create_wbqev_identifier_properties.sql');
14 14
 
15 15
 		return true;
16 16
 	}
17 17
 
18
-	public static function onUnitTestsList( &$paths ) {
19
-		$paths[] = __DIR__ . '/tests/phpunit';
18
+	public static function onUnitTestsList(&$paths) {
19
+		$paths[] = __DIR__.'/tests/phpunit';
20 20
 		return true;
21 21
 	}
22 22
 
Please login to merge, or discard this patch.
includes/CrossCheck/Comparer/TimeValueComparer.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 	 * @throws InvalidArgumentException
31 31
 	 * @return string One of the ComparisonResult::STATUS_... constants.
32 32
 	 */
33
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
34
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
35
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
33
+	public function compare(DataValue $value, DataValue $comparativeValue) {
34
+		if (!$this->canCompare($value, $comparativeValue)) {
35
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
36 36
 		}
37 37
 
38 38
 		/**
@@ -42,38 +42,38 @@  discard block
 block discarded – undo
42 42
 
43 43
 		$result = ComparisonResult::STATUS_MISMATCH;
44 44
 
45
-		if ( !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches )
46
-			|| !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches )
45
+		if (!preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches)
46
+			|| !preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches)
47 47
 		) {
48 48
 			return ComparisonResult::STATUS_MISMATCH;
49 49
 		}
50
-		list( , $localSign, $localYearHigh, $localMwTime, $localYearLow ) = $localMatches;
51
-		list( , $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow ) = $externalMatches;
52
-		if ( $localSign !== $externalSign && ( $localYearHigh . $localYearLow !== '0000'
53
-				|| $externalYearHigh . $externalYearLow !== '0000' )
50
+		list(, $localSign, $localYearHigh, $localMwTime, $localYearLow) = $localMatches;
51
+		list(, $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow) = $externalMatches;
52
+		if ($localSign !== $externalSign && ($localYearHigh.$localYearLow !== '0000'
53
+				|| $externalYearHigh.$externalYearLow !== '0000')
54 54
 		) {
55 55
 			return ComparisonResult::STATUS_MISMATCH;
56 56
 		}
57 57
 
58 58
 		try {
59
-			$localTimestamp = new MWTimestamp( $localMwTime );
60
-			$externalTimestamp = new MWTimestamp( $externalMwTime );
61
-			$diff = $localTimestamp->diff( $externalTimestamp );
62
-			$diff->y += abs( $localYearHigh - $externalYearHigh ) * 10000;
59
+			$localTimestamp = new MWTimestamp($localMwTime);
60
+			$externalTimestamp = new MWTimestamp($externalMwTime);
61
+			$diff = $localTimestamp->diff($externalTimestamp);
62
+			$diff->y += abs($localYearHigh - $externalYearHigh) * 10000;
63 63
 
64
-			if ( $value->getPrecision() === $comparativeValue->getPrecision()
65
-				&& $this->resultOfDiffWithPrecision( $diff, $value->getPrecision() )
64
+			if ($value->getPrecision() === $comparativeValue->getPrecision()
65
+				&& $this->resultOfDiffWithPrecision($diff, $value->getPrecision())
66 66
 			) {
67 67
 				$result = ComparisonResult::STATUS_MATCH;
68 68
 			} elseif (
69 69
 				$this->resultOfDiffWithPrecision(
70 70
 					$diff,
71
-					min( $value->getPrecision(), $comparativeValue->getPrecision() )
71
+					min($value->getPrecision(), $comparativeValue->getPrecision())
72 72
 				)
73 73
 			) {
74 74
 				$result = ComparisonResult::STATUS_PARTIAL_MATCH;
75 75
 			}
76
-		} catch ( TimestampException $ex ) {
76
+		} catch (TimestampException $ex) {
77 77
 		}
78 78
 
79 79
 		return $result;
@@ -87,10 +87,10 @@  discard block
 block discarded – undo
87 87
 	 *
88 88
 	 * @return bool
89 89
 	 */
90
-	private function resultOfDiffWithPrecision( DateInterval $diff, $precision ) {
90
+	private function resultOfDiffWithPrecision(DateInterval $diff, $precision) {
91 91
 		$result = true;
92 92
 
93
-		switch ( $precision ) {
93
+		switch ($precision) {
94 94
 			case TimeValue::PRECISION_SECOND:
95 95
 				$result = $diff->s === 0;
96 96
 				// Fall through with no break/return. This is critical for this algorithm.
@@ -134,10 +134,10 @@  discard block
 block discarded – undo
134 134
 	 *
135 135
 	 * @return ValueParser
136 136
 	 */
137
-	protected function getExternalValueParser( DumpMetaInformation $dumpMetaInformation ) {
137
+	protected function getExternalValueParser(DumpMetaInformation $dumpMetaInformation) {
138 138
 		$parserOptions = new ParserOptions();
139
-		$parserOptions->setOption( ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode() );
140
-		$timeParserFactory = new TimeParserFactory( $parserOptions );
139
+		$parserOptions->setOption(ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode());
140
+		$timeParserFactory = new TimeParserFactory($parserOptions);
141 141
 
142 142
 		return $timeParserFactory->getTimeParser();
143 143
 	}
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 	 *
151 151
 	 * @return bool
152 152
 	 */
153
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
153
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
154 154
 		return $value instanceof TimeValue && $comparativeValue instanceof TimeValue;
155 155
 	}
156 156
 
Please login to merge, or discard this patch.
maintenance/UpdateExternalData.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -7,10 +7,10 @@  discard block
 block discarded – undo
7 7
 use WikibaseQuality\ExternalValidation\UpdateExternalData\CsvImportSettings;
8 8
 use WikibaseQuality\ExternalValidation\UpdateExternalData\ExternalDataImporter;
9 9
 
10
-$basePath = getenv( 'MW_INSTALL_PATH' ) !== false
11
-	? getenv( 'MW_INSTALL_PATH' )
12
-	: __DIR__ . '/../../..';
13
-require_once $basePath . '/maintenance/Maintenance.php';
10
+$basePath = getenv('MW_INSTALL_PATH') !== false
11
+	? getenv('MW_INSTALL_PATH')
12
+	: __DIR__.'/../../..';
13
+require_once $basePath.'/maintenance/Maintenance.php';
14 14
 
15 15
 /**
16 16
  * Maintenance script that evokes updates of wbqev_external_data, wbqev_dump_information, wbqev_identifier_properties
@@ -25,16 +25,16 @@  discard block
 block discarded – undo
25 25
 	public function __construct() {
26 26
 		parent::__construct();
27 27
 
28
-		$this->addDescription( "Imports external entities from given CSV files into the local database. CSV files can be generated using the DumpConverter." );
29
-		$this->addOption( 'external-values-file', 'CSV file containing external values for import.', true, true );
30
-		$this->addOption( 'dump-information-file', 'CSV file containing dump meta information for import.', true, true );
31
-		$this->setBatchSize( 1000 );
28
+		$this->addDescription("Imports external entities from given CSV files into the local database. CSV files can be generated using the DumpConverter.");
29
+		$this->addOption('external-values-file', 'CSV file containing external values for import.', true, true);
30
+		$this->addOption('dump-information-file', 'CSV file containing dump meta information for import.', true, true);
31
+		$this->setBatchSize(1000);
32 32
 	}
33 33
 
34 34
 	public function execute() {
35 35
 		$context = new CsvImportSettings(
36
-			$this->getOption( 'external-values-file' ),
37
-			$this->getOption( 'dump-information-file' ),
36
+			$this->getOption('external-values-file'),
37
+			$this->getOption('dump-information-file'),
38 38
 			$this->mBatchSize,
39 39
 			$this->isQuiet()
40 40
 		);
Please login to merge, or discard this patch.
WikibaseQualityExternalValidation.alias.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,6 +11,6 @@
 block discarded – undo
11 11
 
12 12
 /** English (English) */
13 13
 $specialPageAliases['en'] = array(
14
-	'CrossCheck' => array( 'CrossCheck', 'Cross Check' ),
15
-	'ExternalDatabases' => array( 'ExternalDatabases', 'ExternalDbs', 'External Dbs' ),
14
+	'CrossCheck' => array('CrossCheck', 'Cross Check'),
15
+	'ExternalDatabases' => array('ExternalDatabases', 'ExternalDbs', 'External Dbs'),
16 16
 );
17 17
\ No newline at end of file
Please login to merge, or discard this patch.
specials/SpecialExternalDatabases.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -54,10 +54,10 @@  discard block
 block discarded – undo
54 54
 		TermLookup $termLookup,
55 55
 		EntityIdHtmlLinkFormatterFactory $entityIdHtmlLinkFormatterFactory,
56 56
 		DumpMetaInformationLookup $dumpMetaInformationRepo ) {
57
-		parent::__construct( 'ExternalDatabases' );
57
+		parent::__construct('ExternalDatabases');
58 58
 
59 59
 		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter(
60
-			new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() )
60
+			new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode())
61 61
 		);
62 62
 
63 63
 		$this->dumpMetaInformationRepo = $dumpMetaInformationRepo;
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	 * @return string
79 79
 	 */
80 80
 	public function getDescription() {
81
-		return $this->msg( 'wbqev-externaldbs' )->text();
81
+		return $this->msg('wbqev-externaldbs')->text();
82 82
 	}
83 83
 
84 84
 	/**
@@ -86,51 +86,51 @@  discard block
 block discarded – undo
86 86
 	 *
87 87
 	 * @param string|null $subPage
88 88
 	 */
89
-	public function execute( $subPage ) {
89
+	public function execute($subPage) {
90 90
 		$out = $this->getOutput();
91 91
 
92 92
 		$this->setHeaders();
93 93
 
94 94
 		$out->addHTML(
95
-			Html::openElement( 'p' )
96
-			. $this->msg( 'wbqev-externaldbs-instructions' )->parse()
97
-			. Html::closeElement( 'p' )
98
-			. Html::openElement( 'h3' )
99
-			. $this->msg( 'wbqev-externaldbs-overview-headline' )->parse()
100
-			. Html::closeElement( 'h3' )
95
+			Html::openElement('p')
96
+			. $this->msg('wbqev-externaldbs-instructions')->parse()
97
+			. Html::closeElement('p')
98
+			. Html::openElement('h3')
99
+			. $this->msg('wbqev-externaldbs-overview-headline')->parse()
100
+			. Html::closeElement('h3')
101 101
 		);
102 102
 
103 103
 		$dumps = $this->dumpMetaInformationRepo->getAll();
104
-		if ( count( $dumps ) > 0 ) {
104
+		if (count($dumps) > 0) {
105 105
 			$groupedDumpMetaInformation = array();
106
-			foreach ( $dumps as $dump ) {
106
+			foreach ($dumps as $dump) {
107 107
 				$sourceItemId = $dump->getSourceItemId()->getSerialization();
108 108
 				$groupedDumpMetaInformation[$sourceItemId][] = $dump;
109 109
 			}
110 110
 
111 111
 			$table = new HtmlTableBuilder(
112 112
 				array(
113
-					$this->msg( 'wbqev-externaldbs-name' )->escaped(),
114
-					$this->msg( 'wbqev-externaldbs-id' )->escaped(),
115
-					$this->msg( 'wbqev-externaldbs-import-date' )->escaped(),
116
-					$this->msg( 'wbqev-externaldbs-language' )->escaped(),
117
-					$this->msg( 'wbqev-externaldbs-source-urls' )->escaped(),
118
-					$this->msg( 'wbqev-externaldbs-size' )->escaped(),
119
-					$this->msg( 'wbqev-externaldbs-license' )->escaped()
113
+					$this->msg('wbqev-externaldbs-name')->escaped(),
114
+					$this->msg('wbqev-externaldbs-id')->escaped(),
115
+					$this->msg('wbqev-externaldbs-import-date')->escaped(),
116
+					$this->msg('wbqev-externaldbs-language')->escaped(),
117
+					$this->msg('wbqev-externaldbs-source-urls')->escaped(),
118
+					$this->msg('wbqev-externaldbs-size')->escaped(),
119
+					$this->msg('wbqev-externaldbs-license')->escaped()
120 120
 				),
121 121
 				true
122 122
 			);
123 123
 
124
-			foreach ( $groupedDumpMetaInformation as $dumpMetaInformation ) {
125
-				$table->appendRows( $this->getRowGroup( $dumpMetaInformation ) );
124
+			foreach ($groupedDumpMetaInformation as $dumpMetaInformation) {
125
+				$table->appendRows($this->getRowGroup($dumpMetaInformation));
126 126
 			}
127 127
 
128
-			$out->addHTML( $table->toHtml() );
128
+			$out->addHTML($table->toHtml());
129 129
 		} else {
130 130
 			$out->addHTML(
131
-				Html::openElement( 'p' )
132
-				. $this->msg( 'wbqev-externaldbs-no-databases' )->escaped()
133
-				. Html::closeElement( 'p' )
131
+				Html::openElement('p')
132
+				. $this->msg('wbqev-externaldbs-no-databases')->escaped()
133
+				. Html::closeElement('p')
134 134
 			);
135 135
 		}
136 136
 	}
@@ -142,12 +142,12 @@  discard block
 block discarded – undo
142 142
 	 *
143 143
 	 * @return array
144 144
 	 */
145
-	private function getRowGroup( array $dumpMetaInformationGroup ) {
145
+	private function getRowGroup(array $dumpMetaInformationGroup) {
146 146
 		$rows = array();
147 147
 
148
-		foreach ( $dumpMetaInformationGroup as $dumpMetaInformation ) {
148
+		foreach ($dumpMetaInformationGroup as $dumpMetaInformation) {
149 149
 			$dumpId = $dumpMetaInformation->getDumpId();
150
-			$importDate = $this->getLanguage()->timeanddate( $dumpMetaInformation->getImportDate() );
150
+			$importDate = $this->getLanguage()->timeanddate($dumpMetaInformation->getImportDate());
151 151
 			$language = Language::fetchLanguageName(
152 152
 				$dumpMetaInformation->getLanguageCode(),
153 153
 				$this->getLanguage()->getCode()
@@ -156,23 +156,23 @@  discard block
 block discarded – undo
156 156
 				$dumpMetaInformation->getSourceUrl(),
157 157
 				$dumpMetaInformation->getSourceUrl()
158 158
 			);
159
-			$size = $this->getLanguage()->formatSize( $dumpMetaInformation->getSize() );
160
-			$license = $this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformation->getLicenseItemId() );
159
+			$size = $this->getLanguage()->formatSize($dumpMetaInformation->getSize());
160
+			$license = $this->entityIdLinkFormatter->formatEntityId($dumpMetaInformation->getLicenseItemId());
161 161
 			$rows[] = array(
162
-				new HtmlTableCellBuilder( $dumpId ),
163
-				new HtmlTableCellBuilder( $importDate ),
164
-				new HtmlTableCellBuilder( $language ),
165
-				new HtmlTableCellBuilder( $sourceUrl, array(), true ),
166
-				new HtmlTableCellBuilder( $size ),
167
-				new HtmlTableCellBuilder( $license, array(), true )
162
+				new HtmlTableCellBuilder($dumpId),
163
+				new HtmlTableCellBuilder($importDate),
164
+				new HtmlTableCellBuilder($language),
165
+				new HtmlTableCellBuilder($sourceUrl, array(), true),
166
+				new HtmlTableCellBuilder($size),
167
+				new HtmlTableCellBuilder($license, array(), true)
168 168
 			);
169 169
 		}
170 170
 
171 171
 		array_unshift(
172 172
 			$rows[0],
173 173
 			new HtmlTableCellBuilder(
174
-				$this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformationGroup[0]->getSourceItemId() ),
175
-				array( 'rowspan' => (string)count( $dumpMetaInformationGroup ) ),
174
+				$this->entityIdLinkFormatter->formatEntityId($dumpMetaInformationGroup[0]->getSourceItemId()),
175
+				array('rowspan' => (string)count($dumpMetaInformationGroup)),
176 176
 				true
177 177
 			)
178 178
 		);
Please login to merge, or discard this patch.