wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/UpdateExternalData/CsvImportSettings.php

Spacing +5 added lines, -5 removed lines

@@ -43,11 +43,11 @@
 	 * @param int $batchSize
 	 * @param bool $quiet
 	 */
-	public function __construct( $externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false ) {
-		Assert::parameterType( 'string', $externalValuesFilePath, '$externalValuesFilePath' );
-		Assert::parameterType( 'string', $dumpInformationFilePath, '$dumpInformationFilePath' );
-		Assert::parameterType( 'integer', $batchSize, '$batchSize' );
-		Assert::parameterType( 'boolean', $quiet, '$quiet' );
+	public function __construct($externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false) {
+		Assert::parameterType('string', $externalValuesFilePath, '$externalValuesFilePath');
+		Assert::parameterType('string', $dumpInformationFilePath, '$dumpInformationFilePath');
+		Assert::parameterType('integer', $batchSize, '$batchSize');
+		Assert::parameterType('boolean', $quiet, '$quiet');
 
 		$this->externalValuesFilePath = $externalValuesFilePath;
 		$this->dumpInformationFilePath = $dumpInformationFilePath;

WikibaseQualityExternalValidationHooks.php

Spacing +6 added lines, -6 removed lines

@@ -7,16 +7,16 @@
 	 *
 	 * @return bool
 	 */
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
-		$updater->addExtensionTable( 'wbqev_dump_information', __DIR__ . '/sql/create_wbqev_dump_information.sql' );
-		$updater->addExtensionTable( 'wbqev_external_data', __DIR__ . '/sql/create_wbqev_external_data.sql' );
-		$updater->addExtensionTable( 'wbqev_identifier_properties', __DIR__ . '/sql/create_wbqev_identifier_properties.sql' );
+	public static function onCreateSchema(DatabaseUpdater $updater) {
+		$updater->addExtensionTable('wbqev_dump_information', __DIR__.'/sql/create_wbqev_dump_information.sql');
+		$updater->addExtensionTable('wbqev_external_data', __DIR__.'/sql/create_wbqev_external_data.sql');
+		$updater->addExtensionTable('wbqev_identifier_properties', __DIR__.'/sql/create_wbqev_identifier_properties.sql');
 
 		return true;
 	}
 
-	public static function onUnitTestsList( &$paths ) {
-		$paths[] = __DIR__ . '/tests/phpunit';
+	public static function onUnitTestsList(&$paths) {
+		$paths[] = __DIR__.'/tests/phpunit';
 		return true;
 	}
 

includes/CrossCheck/Comparer/TimeValueComparer.php

Spacing +23 added lines, -23 removed lines

@@ -30,9 +30,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -42,38 +42,38 @@ 
 
 		$result = ComparisonResult::STATUS_MISMATCH;
 
-		if ( !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches )
-			|| !preg_match( '/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches )
+		if (!preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $value->getTime(), $localMatches)
+			|| !preg_match('/^([-+]?)(\d*)((\d{4}\b).*)/', $comparativeValue->getTime(), $externalMatches)
 		) {
 			return ComparisonResult::STATUS_MISMATCH;
 		}
-		list( , $localSign, $localYearHigh, $localMwTime, $localYearLow ) = $localMatches;
-		list( , $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow ) = $externalMatches;
-		if ( $localSign !== $externalSign && ( $localYearHigh . $localYearLow !== '0000'
-				|| $externalYearHigh . $externalYearLow !== '0000' )
+		list(, $localSign, $localYearHigh, $localMwTime, $localYearLow) = $localMatches;
+		list(, $externalSign, $externalYearHigh, $externalMwTime, $externalYearLow) = $externalMatches;
+		if ($localSign !== $externalSign && ($localYearHigh.$localYearLow !== '0000'
+				|| $externalYearHigh.$externalYearLow !== '0000')
 		) {
 			return ComparisonResult::STATUS_MISMATCH;
 		}
 
 		try {
-			$localTimestamp = new MWTimestamp( $localMwTime );
-			$externalTimestamp = new MWTimestamp( $externalMwTime );
-			$diff = $localTimestamp->diff( $externalTimestamp );
-			$diff->y += abs( $localYearHigh - $externalYearHigh ) * 10000;
+			$localTimestamp = new MWTimestamp($localMwTime);
+			$externalTimestamp = new MWTimestamp($externalMwTime);
+			$diff = $localTimestamp->diff($externalTimestamp);
+			$diff->y += abs($localYearHigh - $externalYearHigh) * 10000;
 
-			if ( $value->getPrecision() === $comparativeValue->getPrecision()
-				&& $this->resultOfDiffWithPrecision( $diff, $value->getPrecision() )
+			if ($value->getPrecision() === $comparativeValue->getPrecision()
+				&& $this->resultOfDiffWithPrecision($diff, $value->getPrecision())
 			) {
 				$result = ComparisonResult::STATUS_MATCH;
 			} elseif (
 				$this->resultOfDiffWithPrecision(
 					$diff,
-					min( $value->getPrecision(), $comparativeValue->getPrecision() )
+					min($value->getPrecision(), $comparativeValue->getPrecision())
 				)
 			) {
 				$result = ComparisonResult::STATUS_PARTIAL_MATCH;
 			}
-		} catch ( TimestampException $ex ) {
+		} catch (TimestampException $ex) {
 		}
 
 		return $result;
@@ -87,10 +87,10 @@ 
 	 *
 	 * @return bool
 	 */
-	private function resultOfDiffWithPrecision( DateInterval $diff, $precision ) {
+	private function resultOfDiffWithPrecision(DateInterval $diff, $precision) {
 		$result = true;
 
-		switch ( $precision ) {
+		switch ($precision) {
 			case TimeValue::PRECISION_SECOND:
 				$result = $diff->s === 0;
 				// Fall through with no break/return. This is critical for this algorithm.
@@ -134,10 +134,10 @@ 
 	 *
 	 * @return ValueParser
 	 */
-	protected function getExternalValueParser( DumpMetaInformation $dumpMetaInformation ) {
+	protected function getExternalValueParser(DumpMetaInformation $dumpMetaInformation) {
 		$parserOptions = new ParserOptions();
-		$parserOptions->setOption( ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode() );
-		$timeParserFactory = new TimeParserFactory( $parserOptions );
+		$parserOptions->setOption(ValueParser::OPT_LANG, $dumpMetaInformation->getLanguageCode());
+		$timeParserFactory = new TimeParserFactory($parserOptions);
 
 		return $timeParserFactory->getTimeParser();
 	}
@@ -150,7 +150,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof TimeValue && $comparativeValue instanceof TimeValue;
 	}
 

includes/DumpMetaInformation/DumpMetaInformationLookup.php

Spacing +2 added lines, -2 removed lines

@@ -20,7 +20,7 @@ 
 	 * @return DumpMetaInformation[]
 	 * @throws \InvalidArgumentException
 	 */
-	public function getWithIds( array $dumpIds );
+	public function getWithIds(array $dumpIds);
 
 	/**
 	 * Gets DumpMetaInformation for specific identifier properties from database
@@ -30,7 +30,7 @@ 
 	 *
 	 * @return DumpMetaInformation[]
 	 */
-	public function getWithIdentifierProperties( array $identifierPropertyIds );
+	public function getWithIdentifierProperties(array $identifierPropertyIds);
 
 	/**
 	 * Gets all DumpMetaInformation from database

maintenance/UpdateExternalData.php

Spacing +11 added lines, -11 removed lines

@@ -7,10 +7,10 @@ 
 use WikibaseQuality\ExternalValidation\UpdateExternalData\CsvImportSettings;
 use WikibaseQuality\ExternalValidation\UpdateExternalData\ExternalDataImporter;
 
-$basePath = getenv( 'MW_INSTALL_PATH' ) !== false
-	? getenv( 'MW_INSTALL_PATH' )
-	: __DIR__ . '/../../..';
-require_once $basePath . '/maintenance/Maintenance.php';
+$basePath = getenv('MW_INSTALL_PATH') !== false
+	? getenv('MW_INSTALL_PATH')
+	: __DIR__.'/../../..';
+require_once $basePath.'/maintenance/Maintenance.php';
 
 /**
  * Maintenance script that evokes updates of wbqev_external_data, wbqev_dump_information, wbqev_identifier_properties
@@ -25,17 +25,17 @@ 
 	public function __construct() {
 		parent::__construct();
 
-		$this->addDescription( 'Imports external entities from given CSV files into the local '
-			. 'database. CSV files can be generated using the DumpConverter.' );
-		$this->addOption( 'external-values-file', 'CSV file containing external values for import.', true, true );
-		$this->addOption( 'dump-information-file', 'CSV file containing dump meta information for import.', true, true );
-		$this->setBatchSize( 1000 );
+		$this->addDescription('Imports external entities from given CSV files into the local '
+			. 'database. CSV files can be generated using the DumpConverter.');
+		$this->addOption('external-values-file', 'CSV file containing external values for import.', true, true);
+		$this->addOption('dump-information-file', 'CSV file containing dump meta information for import.', true, true);
+		$this->setBatchSize(1000);
 	}
 
 	public function execute() {
 		$context = new CsvImportSettings(
-			$this->getOption( 'external-values-file' ),
-			$this->getOption( 'dump-information-file' ),
+			$this->getOption('external-values-file'),
+			$this->getOption('dump-information-file'),
 			$this->mBatchSize,
 			$this->isQuiet()
 		);

includes/CrossCheck/Comparer/QuantityValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -23,9 +23,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -33,8 +33,8 @@ 
 		 * @var QuantityValue $comparativeValue
 		 */
 
-		if ( $comparativeValue->getLowerBound()->compare( $value->getUpperBound() ) <= 0 &&
-			$comparativeValue->getUpperBound()->compare( $value->getLowerBound() ) >= 0
+		if ($comparativeValue->getLowerBound()->compare($value->getUpperBound()) <= 0 &&
+			$comparativeValue->getUpperBound()->compare($value->getLowerBound()) >= 0
 		) {
 			return ComparisonResult::STATUS_MATCH;
 		}
@@ -50,7 +50,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof QuantityValue && $comparativeValue instanceof QuantityValue;
 	}
 

includes/CrossCheck/ReferenceChecker.php

Spacing +8 added lines, -8 removed lines

@@ -40,16 +40,16 @@ 
 		$externalId,
 		DumpMetaInformation $dumpMetaInformation
 	) {
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+		Assert::parameterType('string', $externalId, '$externalId');
 
-		if ( count( $statement->getReferences() ) === 0 ) {
+		if (count($statement->getReferences()) === 0) {
 			$status = ReferenceResult::STATUS_REFERENCES_MISSING;
 		} else {
 			$status = ReferenceResult::STATUS_REFERENCES_STATED;
 		}
 
-		$externalReference = $this->buildReference( $identifierPropertyId, $externalId, $dumpMetaInformation );
-		return new ReferenceResult( $status, $externalReference );
+		$externalReference = $this->buildReference($identifierPropertyId, $externalId, $dumpMetaInformation);
+		return new ReferenceResult($status, $externalReference);
 	}
 
 	/**
@@ -60,17 +60,17 @@ 
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 * @return Reference
 	 */
-	private function buildReference( PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
+	private function buildReference(PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
 		global $wgWBQEVStatedInPID;
 
 		$sourceItemId = $dumpMetaInformation->getSourceItemId();
 		$statedInAuthoritySnak = new PropertyValueSnak(
-			new PropertyId( $wgWBQEVStatedInPID ),
-			new EntityIdValue( $sourceItemId )
+			new PropertyId($wgWBQEVStatedInPID),
+			new EntityIdValue($sourceItemId)
 		);
 		$authorityWithExternalIdSnak = new PropertyValueSnak(
 			$identifierPropertyId,
-			new StringValue( $externalId )
+			new StringValue($externalId)
 		);
 
 		return new Reference(

includes/CrossCheck/ValueParser/ComparativeValueParser.php

Spacing +9 added lines, -9 removed lines

@@ -38,7 +38,7 @@ 
 		ValueParserFactory $comparativeValueParserFactory,
 		$languageCode
 	) {
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
+		Assert::parameterType('string', $languageCode, '$languageCode');
 
 		$this->comparativeValueParserFactory = $comparativeValueParserFactory;
 		$this->languageCode = $languageCode;
@@ -52,11 +52,11 @@ 
 	 *
 	 * @return DataValue
 	 */
-	public function parse( $value, $propertyType ) {
-		Assert::parameterType( 'string', $value, '$value' );
-		Assert::parameterType( 'string', $propertyType, '$propertyType' );
+	public function parse($value, $propertyType) {
+		Assert::parameterType('string', $value, '$value');
+		Assert::parameterType('string', $propertyType, '$propertyType');
 
-		return $this->getValueParser( $propertyType )->parse( $value );
+		return $this->getValueParser($propertyType)->parse($value);
 	}
 
 	/**
@@ -64,8 +64,8 @@ 
 	 *
 	 * @return ValueParser
 	 */
-	private function getValueParser( $type ) {
-		if ( !array_key_exists( $type, $this->valueParsers ) ) {
+	private function getValueParser($type) {
+		if (!array_key_exists($type, $this->valueParsers)) {
 			$parserOptions = $this->getParserOptions();
 			$this->valueParsers[$type] = $this->comparativeValueParserFactory->newParser(
 				$type,
@@ -81,8 +81,8 @@ 
 	 */
 	private function getParserOptions() {
 		$options = new ParserOptions();
-		$options->setOption( 'valuelang', $this->languageCode );
-		$options->setOption( ValueParser::OPT_LANG, $this->languageCode );
+		$options->setOption('valuelang', $this->languageCode);
+		$options->setOption(ValueParser::OPT_LANG, $this->languageCode);
 
 		return $options;
 	}

WikibaseQualityExternalValidation.alias.php

Spacing +2 added lines, -2 removed lines

@@ -10,6 +10,6 @@
 
 /** English (English) */
 $specialPageAliases['en'] = [
-	'CrossCheck' => [ 'CrossCheck', 'Cross Check' ],
-	'ExternalDatabases' => [ 'ExternalDatabases', 'ExternalDbs', 'External Dbs' ],
+	'CrossCheck' => ['CrossCheck', 'Cross Check'],
+	'ExternalDatabases' => ['ExternalDatabases', 'ExternalDbs', 'External Dbs'],
 ];