Inspection of "Merge "Use ResultsSource instead of ResultsBuilder..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( af1662...d5f822 )

unknown

created 2018-03-26 12:53 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -36,16 +36,16 @@
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_STATEMENT ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_STATEMENT) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-valueOnly');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ReferenceChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -36,16 +36,16 @@
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-reference');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -55,9 +55,9 @@  discard block
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$propertyId = $context->getSnak()->getPropertyId();
@@ -69,18 +69,18 @@  discard block
 block discarded – undo
 			$propertyId
 		);
 
-		if ( $propertyCount > 1 ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-single-value' );
+		if ($propertyCount > 1) {
+			$message = new ViolationMessage('wbqc-violation-message-single-value');
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/MandatoryQualifiersChecker.php 1 patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -71,40 +71,40 @@
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-			->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
+		$message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
+			->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+			->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
 		$status = CheckResult::STATUS_VIOLATION;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
-			if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
+			if ($propertyId->equals($qualifier->getPropertyId())) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/QualifiersChecker.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -71,53 +71,53 @@
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$properties = $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
+		$properties = $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
 		$parameters['property'] = $properties;
 
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
 		/** @var Snak $qualifier */
-		foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
+		foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
 			$allowedQualifier = false;
-			foreach ( $properties as $property ) {
-				if ( $qualifier->getPropertyId()->equals( $property ) ) {
+			foreach ($properties as $property) {
+				if ($qualifier->getPropertyId()->equals($property)) {
 					$allowedQualifier = true;
 					break;
 				}
 			}
-			if ( !$allowedQualifier ) {
-				if ( empty( $properties ) || $properties === [ '' ] ) {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+			if (!$allowedQualifier) {
+				if (empty($properties) || $properties === ['']) {
+					$message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 				} else {
-					$message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-						->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
-						->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
+					$message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+						->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
+						->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
 				}
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/UniqueValueChecker.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -74,22 +74,22 @@  discard block
 block discarded – undo
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
-		if ( $this->sparqlHelper !== null ) {
-			if ( $context->getType() === 'statement' ) {
+		if ($this->sparqlHelper !== null) {
+			if ($context->getType() === 'statement') {
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
 					$context->getSnakStatement(),
 					true // ignore deprecated statements
 				);
 			} else {
-				if ( $context->getSnak()->getType() !== 'value' ) {
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+				if ($context->getSnak()->getType() !== 'value') {
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -102,27 +102,27 @@  discard block
 block discarded – undo
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

@@ -87,18 +87,18 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		/*
@@ -106,15 +106,15 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$context->getEntity()->getStatements(),
 				$propertyId
 			);
-			if ( $offendingStatement !== null ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE );
+			if ($offendingStatement !== null) {
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -126,12 +126,12 @@  discard block
 block discarded – undo
 				$propertyId,
 				$items
 			);
-			if ( $offendingStatement !== null ) {
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE )
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
+			if ($offendingStatement !== null) {
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE)
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -139,20 +139,20 @@  discard block
 block discarded – undo
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/OneOfChecker.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -68,41 +68,41 @@
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
 		$parameters['item'] = $items;
 
 		$snak = $context->getSnak();
 
-		$message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) )
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-			->withItemIdSnakValueList( $items, Role::OBJECT );
+		$message = (new ViolationMessage('wbqc-violation-message-one-of'))
+			->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+			->withItemIdSnakValueList($items, Role::OBJECT);
 		$status = CheckResult::STATUS_VIOLATION;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ItemChecker.php 1 patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -86,18 +86,18 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		/*
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$context->getEntity()->getStatements(),
 				$propertyId
@@ -118,31 +118,31 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

		@@ -71,40 +71,40 @@
		block discarded – undo
71	71	* @throws ConstraintParameterException
72	72	* @return CheckResult
73	73	*/
74		- public function checkConstraint( Context $context, Constraint $constraint ) {
75		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	74	+ public function checkConstraint(Context $context, Constraint $constraint) {
	75	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	76	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77	77	}
78	78
79	79	$parameters = [];
80	80	$constraintParameters = $constraint->getConstraintParameters();
81	81
82		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
83		- $parameters['property'] = [ $propertyId ];
	82	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	83	+ $parameters['property'] = [$propertyId];
84	84
85		- $message = ( new ViolationMessage( 'wbqc-violation-message-mandatory-qualifier' ) )
86		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
87		- ->withEntityId( $propertyId, Role::QUALIFIER_PREDICATE );
	85	+ $message = (new ViolationMessage('wbqc-violation-message-mandatory-qualifier'))
	86	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	87	+ ->withEntityId($propertyId, Role::QUALIFIER_PREDICATE);
88	88	$status = CheckResult::STATUS_VIOLATION;
89	89
90	90	/** @var Snak $qualifier */
91		- foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
92		- if ( $propertyId->equals( $qualifier->getPropertyId() ) ) {
	91	+ foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
	92	+ if ($propertyId->equals($qualifier->getPropertyId())) {
93	93	$message = null;
94	94	$status = CheckResult::STATUS_COMPLIANCE;
95	95	break;
96	96	}
97	97	}
98	98
99		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	99	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
100	100	}
101	101
102		- public function checkConstraintParameters( Constraint $constraint ) {
	102	+ public function checkConstraintParameters(Constraint $constraint) {
103	103	$constraintParameters = $constraint->getConstraintParameters();
104	104	$exceptions = [];
105	105	try {
106		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
107		- } catch ( ConstraintParameterException $e ) {
	106	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	107	+ } catch (ConstraintParameterException $e) {
108	108	$exceptions[] = $e;
109	109	}
110	110	return $exceptions;

		@@ -71,53 +71,53 @@
		block discarded – undo
71	71	* @throws ConstraintParameterException
72	72	* @return CheckResult
73	73	*/
74		- public function checkConstraint( Context $context, Constraint $constraint ) {
75		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
76		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	74	+ public function checkConstraint(Context $context, Constraint $constraint) {
	75	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	76	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
77	77	}
78	78
79	79	$parameters = [];
80	80	$constraintParameters = $constraint->getConstraintParameters();
81	81
82		- $properties = $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
	82	+ $properties = $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
83	83	$parameters['property'] = $properties;
84	84
85	85	$message = null;
86	86	$status = CheckResult::STATUS_COMPLIANCE;
87	87
88	88	/** @var Snak $qualifier */
89		- foreach ( $context->getSnakStatement()->getQualifiers() as $qualifier ) {
	89	+ foreach ($context->getSnakStatement()->getQualifiers() as $qualifier) {
90	90	$allowedQualifier = false;
91		- foreach ( $properties as $property ) {
92		- if ( $qualifier->getPropertyId()->equals( $property ) ) {
	91	+ foreach ($properties as $property) {
	92	+ if ($qualifier->getPropertyId()->equals($property)) {
93	93	$allowedQualifier = true;
94	94	break;
95	95	}
96	96	}
97		- if ( !$allowedQualifier ) {
98		- if ( empty( $properties ) \|\| $properties === [ '' ] ) {
99		- $message = ( new ViolationMessage( 'wbqc-violation-message-no-qualifiers' ) )
100		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	97	+ if (!$allowedQualifier) {
	98	+ if (empty($properties) \|\| $properties === ['']) {
	99	+ $message = (new ViolationMessage('wbqc-violation-message-no-qualifiers'))
	100	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
101	101	} else {
102		- $message = ( new ViolationMessage( 'wbqc-violation-message-qualifiers' ) )
103		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
104		- ->withEntityId( $qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE )
105		- ->withEntityIdList( $properties, Role::QUALIFIER_PREDICATE );
	102	+ $message = (new ViolationMessage('wbqc-violation-message-qualifiers'))
	103	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	104	+ ->withEntityId($qualifier->getPropertyId(), Role::QUALIFIER_PREDICATE)
	105	+ ->withEntityIdList($properties, Role::QUALIFIER_PREDICATE);
106	106	}
107	107	$status = CheckResult::STATUS_VIOLATION;
108	108	break;
109	109	}
110	110	}
111	111
112		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	112	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
113	113	}
114	114
115		- public function checkConstraintParameters( Constraint $constraint ) {
	115	+ public function checkConstraintParameters(Constraint $constraint) {
116	116	$constraintParameters = $constraint->getConstraintParameters();
117	117	$exceptions = [];
118	118	try {
119		- $this->constraintParameterParser->parsePropertiesParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
120		- } catch ( ConstraintParameterException $e ) {
	119	+ $this->constraintParameterParser->parsePropertiesParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	120	+ } catch (ConstraintParameterException $e) {
121	121	$exceptions[] = $e;
122	122	}
123	123	return $exceptions;

		@@ -74,22 +74,22 @@ discard block
		block discarded – undo
74	74	* @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
75	75	* @return CheckResult
76	76	*/
77		- public function checkConstraint( Context $context, Constraint $constraint ) {
78		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
79		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	77	+ public function checkConstraint(Context $context, Constraint $constraint) {
	78	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	79	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
80	80	}
81	81
82	82	$parameters = [];
83	83
84		- if ( $this->sparqlHelper !== null ) {
85		- if ( $context->getType() === 'statement' ) {
	84	+ if ($this->sparqlHelper !== null) {
	85	+ if ($context->getType() === 'statement') {
86	86	$result = $this->sparqlHelper->findEntitiesWithSameStatement(
87	87	$context->getSnakStatement(),
88	88	true // ignore deprecated statements
89	89	);
90	90	} else {
91		- if ( $context->getSnak()->getType() !== 'value' ) {
92		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	91	+ if ($context->getSnak()->getType() !== 'value') {
	92	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
93	93	}
94	94	$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
95	95	$context->getEntity()->getId(),
		@@ -102,27 +102,27 @@ discard block
		block discarded – undo
102	102	$otherEntities = $result->getArray();
103	103	$metadata = $result->getMetadata();
104	104
105		- if ( $otherEntities === [] ) {
	105	+ if ($otherEntities === []) {
106	106	$status = CheckResult::STATUS_COMPLIANCE;
107	107	$message = null;
108	108	} else {
109		- $otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
	109	+ $otherEntities = array_values(array_filter($otherEntities)); // remove nulls
110	110	$status = CheckResult::STATUS_VIOLATION;
111		- $message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
112		- ->withEntityIdList( $otherEntities, Role::SUBJECT );
	111	+ $message = (new ViolationMessage('wbqc-violation-message-unique-value'))
	112	+ ->withEntityIdList($otherEntities, Role::SUBJECT);
113	113	}
114	114	} else {
115	115	$status = CheckResult::STATUS_TODO;
116		- $message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
117		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
	116	+ $message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
	117	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
118	118	$metadata = Metadata::blank();
119	119	}
120	120
121		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
122		- ->withMetadata( $metadata );
	121	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	122	+ ->withMetadata($metadata);
123	123	}
124	124
125		- public function checkConstraintParameters( Constraint $constraint ) {
	125	+ public function checkConstraintParameters(Constraint $constraint) {
126	126	// no parameters
127	127	return [];
128	128	}

		@@ -87,18 +87,18 @@ discard block
		block discarded – undo
87	87	* @throws ConstraintParameterException
88	88	* @return CheckResult
89	89	*/
90		- public function checkConstraint( Context $context, Constraint $constraint ) {
91		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
92		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	90	+ public function checkConstraint(Context $context, Constraint $constraint) {
	91	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	92	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
93	93	}
94	94
95	95	$parameters = [];
96	96	$constraintParameters = $constraint->getConstraintParameters();
97	97
98		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
99		- $parameters['property'] = [ $propertyId ];
	98	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	99	+ $parameters['property'] = [$propertyId];
100	100
101		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
	101	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
102	102	$parameters['items'] = $items;
103	103
104	104	/*
		@@ -106,15 +106,15 @@ discard block
		block discarded – undo
106	106	* a) a property only
107	107	* b) a property and a number of items (each combination of property and item forming an individual claim)
108	108	*/
109		- if ( $items === [] ) {
	109	+ if ($items === []) {
110	110	$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
111	111	$context->getEntity()->getStatements(),
112	112	$propertyId
113	113	);
114		- if ( $offendingStatement !== null ) {
115		- $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
116		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
117		- ->withEntityId( $propertyId, Role::PREDICATE );
	114	+ if ($offendingStatement !== null) {
	115	+ $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
	116	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	117	+ ->withEntityId($propertyId, Role::PREDICATE);
118	118	$status = CheckResult::STATUS_VIOLATION;
119	119	} else {
120	120	$message = null;
		@@ -126,12 +126,12 @@ discard block
		block discarded – undo
126	126	$propertyId,
127	127	$items
128	128	);
129		- if ( $offendingStatement !== null ) {
130		- $offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
131		- $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
132		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
133		- ->withEntityId( $propertyId, Role::PREDICATE )
134		- ->withItemIdSnakValue( $offendingValue, Role::OBJECT );
	129	+ if ($offendingStatement !== null) {
	130	+ $offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
	131	+ $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
	132	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	133	+ ->withEntityId($propertyId, Role::PREDICATE)
	134	+ ->withItemIdSnakValue($offendingValue, Role::OBJECT);
135	135	$status = CheckResult::STATUS_VIOLATION;
136	136	} else {
137	137	$message = null;
		@@ -139,20 +139,20 @@ discard block
		block discarded – undo
139	139	}
140	140	}
141	141
142		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	142	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
143	143	}
144	144
145		- public function checkConstraintParameters( Constraint $constraint ) {
	145	+ public function checkConstraintParameters(Constraint $constraint) {
146	146	$constraintParameters = $constraint->getConstraintParameters();
147	147	$exceptions = [];
148	148	try {
149		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
150		- } catch ( ConstraintParameterException $e ) {
	149	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	150	+ } catch (ConstraintParameterException $e) {
151	151	$exceptions[] = $e;
152	152	}
153	153	try {
154		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
155		- } catch ( ConstraintParameterException $e ) {
	154	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
	155	+ } catch (ConstraintParameterException $e) {
156	156	$exceptions[] = $e;
157	157	}
158	158	return $exceptions;

		@@ -86,18 +86,18 @@ discard block
		block discarded – undo
86	86	* @throws ConstraintParameterException
87	87	* @return CheckResult
88	88	*/
89		- public function checkConstraint( Context $context, Constraint $constraint ) {
90		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
91		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	89	+ public function checkConstraint(Context $context, Constraint $constraint) {
	90	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	91	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
92	92	}
93	93
94	94	$parameters = [];
95	95	$constraintParameters = $constraint->getConstraintParameters();
96	96
97		- $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
98		- $parameters['property'] = [ $propertyId ];
	97	+ $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	98	+ $parameters['property'] = [$propertyId];
99	99
100		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
	100	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
101	101	$parameters['items'] = $items;
102	102
103	103	/*
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	* a) a property only
106	106	* b) a property and a number of items (each combination of property and item forming an individual claim)
107	107	*/
108		- if ( $items === [] ) {
	108	+ if ($items === []) {
109	109	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
110	110	$context->getEntity()->getStatements(),
111	111	$propertyId
		@@ -118,31 +118,31 @@ discard block
		block discarded – undo
118	118	);
119	119	}
120	120
121		- if ( $requiredStatement !== null ) {
	121	+ if ($requiredStatement !== null) {
122	122	$status = CheckResult::STATUS_COMPLIANCE;
123	123	$message = null;
124	124	} else {
125	125	$status = CheckResult::STATUS_VIOLATION;
126		- $message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
127		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
128		- ->withEntityId( $propertyId, Role::PREDICATE )
129		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	126	+ $message = (new ViolationMessage('wbqc-violation-message-item'))
	127	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	128	+ ->withEntityId($propertyId, Role::PREDICATE)
	129	+ ->withItemIdSnakValueList($items, Role::OBJECT);
130	130	}
131	131
132		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	132	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
133	133	}
134	134
135		- public function checkConstraintParameters( Constraint $constraint ) {
	135	+ public function checkConstraintParameters(Constraint $constraint) {
136	136	$constraintParameters = $constraint->getConstraintParameters();
137	137	$exceptions = [];
138	138	try {
139		- $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
140		- } catch ( ConstraintParameterException $e ) {
	139	+ $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
	140	+ } catch (ConstraintParameterException $e) {
141	141	$exceptions[] = $e;
142	142	}
143	143	try {
144		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
145		- } catch ( ConstraintParameterException $e ) {
	144	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
	145	+ } catch (ConstraintParameterException $e) {
146	146	$exceptions[] = $e;
147	147	}
148	148	return $exceptions;

		@@ -36,16 +36,16 @@
		block discarded – undo
36	36	];
37	37	}
38	38
39		- public function checkConstraint( Context $context, Constraint $constraint ) {
40		- if ( $context->getType() === Context::TYPE_STATEMENT ) {
41		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	39	+ public function checkConstraint(Context $context, Constraint $constraint) {
	40	+ if ($context->getType() === Context::TYPE_STATEMENT) {
	41	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
42	42	} else {
43		- $message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
44		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
	43	+ $message = new ViolationMessage('wbqc-violation-message-valueOnly');
	44	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
45	45	}
46	46	}
47	47
48		- public function checkConstraintParameters( Constraint $constraint ) {
	48	+ public function checkConstraintParameters(Constraint $constraint) {
49	49	// no parameters
50	50	return [];
51	51	}

		@@ -55,9 +55,9 @@ discard block
		block discarded – undo
55	55	*
56	56	* @return CheckResult
57	57	*/
58		- public function checkConstraint( Context $context, Constraint $constraint ) {
59		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
60		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	58	+ public function checkConstraint(Context $context, Constraint $constraint) {
	59	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	60	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
61	61	}
62	62
63	63	$propertyId = $context->getSnak()->getPropertyId();
		@@ -69,18 +69,18 @@ discard block
		block discarded – undo
69	69	$propertyId
70	70	);
71	71
72		- if ( $propertyCount > 1 ) {
73		- $message = new ViolationMessage( 'wbqc-violation-message-single-value' );
	72	+ if ($propertyCount > 1) {
	73	+ $message = new ViolationMessage('wbqc-violation-message-single-value');
74	74	$status = CheckResult::STATUS_VIOLATION;
75	75	} else {
76	76	$message = null;
77	77	$status = CheckResult::STATUS_COMPLIANCE;
78	78	}
79	79
80		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	80	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
81	81	}
82	82
83		- public function checkConstraintParameters( Constraint $constraint ) {
	83	+ public function checkConstraintParameters(Constraint $constraint) {
84	84	// no parameters
85	85	return [];
86	86	}

		@@ -68,41 +68,41 @@
		block discarded – undo
68	68	* @throws ConstraintParameterException
69	69	* @return CheckResult
70	70	*/
71		- public function checkConstraint( Context $context, Constraint $constraint ) {
72		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
73		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	71	+ public function checkConstraint(Context $context, Constraint $constraint) {
	72	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	73	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
74	74	}
75	75
76	76	$parameters = [];
77	77	$constraintParameters = $constraint->getConstraintParameters();
78	78
79		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
	79	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
80	80	$parameters['item'] = $items;
81	81
82	82	$snak = $context->getSnak();
83	83
84		- $message = ( new ViolationMessage( 'wbqc-violation-message-one-of' ) )
85		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
86		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	84	+ $message = (new ViolationMessage('wbqc-violation-message-one-of'))
	85	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
	86	+ ->withItemIdSnakValueList($items, Role::OBJECT);
87	87	$status = CheckResult::STATUS_VIOLATION;
88	88
89		- foreach ( $items as $item ) {
90		- if ( $item->matchesSnak( $snak ) ) {
	89	+ foreach ($items as $item) {
	90	+ if ($item->matchesSnak($snak)) {
91	91	$message = null;
92	92	$status = CheckResult::STATUS_COMPLIANCE;
93	93	break;
94	94	}
95	95	}
96	96
97		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	97	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
98	98	}
99	99
100		- public function checkConstraintParameters( Constraint $constraint ) {
	100	+ public function checkConstraintParameters(Constraint $constraint) {
101	101	$constraintParameters = $constraint->getConstraintParameters();
102	102	$exceptions = [];
103	103	try {
104		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
105		- } catch ( ConstraintParameterException $e ) {
	104	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
	105	+ } catch (ConstraintParameterException $e) {
106	106	$exceptions[] = $e;
107	107	}
108	108	return $exceptions;

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( af1662...d5f822 )

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch