Completed
Push — master ( ad1496...5137f4 )
by
unknown
57s queued 16s
created
src/ConstraintCheck/Checker/QualifierChecker.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -44,16 +44,16 @@
 block discarded – undo
44 44
 	 *
45 45
 	 * @return CheckResult
46 46
 	 */
47
-	public function checkConstraint( Context $context, Constraint $constraint ) {
48
-		if ( $context->getType() === Context::TYPE_QUALIFIER ) {
49
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
47
+	public function checkConstraint(Context $context, Constraint $constraint) {
48
+		if ($context->getType() === Context::TYPE_QUALIFIER) {
49
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
50 50
 		} else {
51
-			$message = new ViolationMessage( 'wbqc-violation-message-qualifier' );
52
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
51
+			$message = new ViolationMessage('wbqc-violation-message-qualifier');
52
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
53 53
 		}
54 54
 	}
55 55
 
56
-	public function checkConstraintParameters( Constraint $constraint ) {
56
+	public function checkConstraintParameters(Constraint $constraint) {
57 57
 		// no parameters
58 58
 		return [];
59 59
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/PropertyScopeChecker.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
47 47
 	}
48 48
 
49
-	public function checkConstraint( Context $context, Constraint $constraint ) {
49
+	public function checkConstraint(Context $context, Constraint $constraint) {
50 50
 		$constraintParameters = $constraint->getConstraintParameters();
51 51
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
52 52
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 			$constraintTypeItemId
56 56
 		);
57 57
 
58
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
58
+		if (in_array($context->getType(), $allowedContextTypes)) {
59 59
 			return new CheckResult(
60 60
 				$context->getCursor(),
61 61
 				$constraint,
@@ -66,15 +66,15 @@  discard block
 block discarded – undo
66 66
 				$context->getCursor(),
67 67
 				$constraint,
68 68
 				CheckResult::STATUS_VIOLATION,
69
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
70
-					->withEntityId( $context->getSnak()->getPropertyId() )
71
-					->withPropertyScope( $context->getType() )
72
-					->withPropertyScopeList( $allowedContextTypes )
69
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
70
+					->withEntityId($context->getSnak()->getPropertyId())
71
+					->withPropertyScope($context->getType())
72
+					->withPropertyScopeList($allowedContextTypes)
73 73
 			);
74 74
 		}
75 75
 	}
76 76
 
77
-	public function checkConstraintParameters( Constraint $constraint ) {
77
+	public function checkConstraintParameters(Constraint $constraint) {
78 78
 		$constraintParameters = $constraint->getConstraintParameters();
79 79
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
80 80
 		$exceptions = [];
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 				$constraintParameters,
84 84
 				$constraintTypeItemId
85 85
 			);
86
-		} catch ( ConstraintParameterException $e ) {
86
+		} catch (ConstraintParameterException $e) {
87 87
 			$exceptions[] = $e;
88 88
 		}
89 89
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -64,9 +64,9 @@  discard block
 block discarded – undo
64 64
 	 * @throws ConstraintParameterException
65 65
 	 * @return CheckResult
66 66
 	 */
67
-	public function checkConstraint( Context $context, Constraint $constraint ) {
68
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
69
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
67
+	public function checkConstraint(Context $context, Constraint $constraint) {
68
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
69
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
70 70
 		}
71 71
 
72 72
 		$separators = $this->constraintParameterParser->parseSeparatorsParameter(
@@ -75,19 +75,19 @@  discard block
 block discarded – undo
75 75
 
76 76
 		$propertyId = $context->getSnak()->getPropertyId();
77 77
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
78
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
78
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
79 79
 			$propertyId
80 80
 		);
81 81
 
82
-		if ( $propertyCount > 1 ) {
83
-			$message = $this->getViolationMessage( $separators, $propertyId );
82
+		if ($propertyCount > 1) {
83
+			$message = $this->getViolationMessage($separators, $propertyId);
84 84
 			$status = CheckResult::STATUS_VIOLATION;
85 85
 		} else {
86 86
 			$message = null;
87 87
 			$status = CheckResult::STATUS_COMPLIANCE;
88 88
 		}
89 89
 
90
-		return new CheckResult( $context, $constraint, $status, $message );
90
+		return new CheckResult($context, $constraint, $status, $message);
91 91
 	}
92 92
 
93 93
 	/**
@@ -95,22 +95,21 @@  discard block
 block discarded – undo
95 95
 	 * @param PropertyId $propertyId
96 96
 	 * @return ViolationMessage
97 97
 	 */
98
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
98
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
99 99
 		$messageKey = $separators === [] ?
100
-			'wbqc-violation-message-single-value' :
101
-			'wbqc-violation-message-single-value-separators';
100
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
102 101
 
103
-		return ( new ViolationMessage( $messageKey ) )
104
-			->withEntityId( $propertyId )
105
-			->withEntityIdList( $separators );
102
+		return (new ViolationMessage($messageKey))
103
+			->withEntityId($propertyId)
104
+			->withEntityIdList($separators);
106 105
 	}
107 106
 
108
-	public function checkConstraintParameters( Constraint $constraint ) {
107
+	public function checkConstraintParameters(Constraint $constraint) {
109 108
 		$constraintParameters = $constraint->getConstraintParameters();
110 109
 		$exceptions = [];
111 110
 		try {
112
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
113
-		} catch ( ConstraintParameterException $e ) {
111
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
112
+		} catch (ConstraintParameterException $e) {
114 113
 			$exceptions[] = $e;
115 114
 		}
116 115
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ReferenceChecker.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -33,16 +33,16 @@
 block discarded – undo
33 33
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
34 34
 	}
35 35
 
36
-	public function checkConstraint( Context $context, Constraint $constraint ) {
37
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
38
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
36
+	public function checkConstraint(Context $context, Constraint $constraint) {
37
+		if ($context->getType() === Context::TYPE_REFERENCE) {
38
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
39 39
 		} else {
40
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
41
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
40
+			$message = new ViolationMessage('wbqc-violation-message-reference');
41
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
42 42
 		}
43 43
 	}
44 44
 
45
-	public function checkConstraintParameters( Constraint $constraint ) {
45
+	public function checkConstraintParameters(Constraint $constraint) {
46 46
 		// no parameters
47 47
 		return [];
48 48
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -76,9 +76,9 @@  discard block
 block discarded – undo
76 76
 	 * @throws ConstraintParameterException
77 77
 	 * @return CheckResult
78 78
 	 */
79
-	public function checkConstraint( Context $context, Constraint $constraint ) {
80
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
81
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
79
+	public function checkConstraint(Context $context, Constraint $constraint) {
80
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
81
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
82 82
 		}
83 83
 
84 84
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -97,22 +97,22 @@  discard block
 block discarded – undo
97 97
 
98 98
 		$statementList = $context->getEntity()
99 99
 			->getStatements()
100
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
100
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
101 101
 
102 102
 		/*
103 103
 		 * 'Conflicts with' can be defined with
104 104
 		 *   a) a property only
105 105
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
106 106
 		 */
107
-		if ( $items === [] ) {
107
+		if ($items === []) {
108 108
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
109 109
 				$statementList,
110 110
 				$propertyId
111 111
 			);
112
-			if ( $offendingStatement !== null ) {
113
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
114
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
115
-					->withEntityId( $propertyId, Role::PREDICATE );
112
+			if ($offendingStatement !== null) {
113
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
114
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
115
+					->withEntityId($propertyId, Role::PREDICATE);
116 116
 				$status = CheckResult::STATUS_VIOLATION;
117 117
 			} else {
118 118
 				$message = null;
@@ -124,12 +124,12 @@  discard block
 block discarded – undo
124 124
 				$propertyId,
125 125
 				$items
126 126
 			);
127
-			if ( $offendingStatement !== null ) {
128
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
129
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
130
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
131
-					->withEntityId( $propertyId, Role::PREDICATE )
132
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
127
+			if ($offendingStatement !== null) {
128
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
129
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
130
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
131
+					->withEntityId($propertyId, Role::PREDICATE)
132
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
133 133
 				$status = CheckResult::STATUS_VIOLATION;
134 134
 			} else {
135 135
 				$message = null;
@@ -137,10 +137,10 @@  discard block
 block discarded – undo
137 137
 			}
138 138
 		}
139 139
 
140
-		return new CheckResult( $context, $constraint, $status, $message );
140
+		return new CheckResult($context, $constraint, $status, $message);
141 141
 	}
142 142
 
143
-	public function checkConstraintParameters( Constraint $constraint ) {
143
+	public function checkConstraintParameters(Constraint $constraint) {
144 144
 		$constraintParameters = $constraint->getConstraintParameters();
145 145
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
146 146
 		$exceptions = [];
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 				$constraintParameters,
150 150
 				$constraintTypeItemId
151 151
 			);
152
-		} catch ( ConstraintParameterException $e ) {
152
+		} catch (ConstraintParameterException $e) {
153 153
 			$exceptions[] = $e;
154 154
 		}
155 155
 		try {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 				$constraintTypeItemId,
159 159
 				false
160 160
 			);
161
-		} catch ( ConstraintParameterException $e ) {
161
+		} catch (ConstraintParameterException $e) {
162 162
 			$exceptions[] = $e;
163 163
 		}
164 164
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/LabelInLanguageChecker.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	 */
23 23
 	private $constraintParameterParser;
24 24
 
25
-	public function __construct( ConstraintParameterParser $constraintParameterParser ) {
25
+	public function __construct(ConstraintParameterParser $constraintParameterParser) {
26 26
 		$this->constraintParameterParser = $constraintParameterParser;
27 27
 	}
28 28
 
@@ -68,9 +68,9 @@  discard block
 block discarded – undo
68 68
 	 * @throws ConstraintParameterException
69 69
 	 * @return CheckResult
70 70
 	 */
71
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
72
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
73
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
71
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
72
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
73
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
74 74
 		}
75 75
 
76 76
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -81,26 +81,26 @@  discard block
 block discarded – undo
81 81
 		);
82 82
 
83 83
 		$status = CheckResult::STATUS_VIOLATION;
84
-		$message = ( new ViolationMessage( 'wbqc-violation-message-label-lacking' ) )
85
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
86
-			->withLanguages( $languages );
84
+		$message = (new ViolationMessage('wbqc-violation-message-label-lacking'))
85
+			->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
86
+			->withLanguages($languages);
87 87
 
88 88
 		/** @var LabelsProvider $entity */
89 89
 		$entity = $context->getEntity();
90 90
 		'@phan-var LabelsProvider $entity';
91 91
 
92
-		foreach ( $languages as $language ) {
93
-			if ( $entity->getLabels()->hasTermForLanguage( $language ) ) {
92
+		foreach ($languages as $language) {
93
+			if ($entity->getLabels()->hasTermForLanguage($language)) {
94 94
 				$message = null;
95 95
 				$status = CheckResult::STATUS_COMPLIANCE;
96 96
 				break;
97 97
 			}
98 98
 		}
99 99
 
100
-		return new CheckResult( $context, $constraint, $status, $message );
100
+		return new CheckResult($context, $constraint, $status, $message);
101 101
 	}
102 102
 
103
-	public function checkConstraintParameters( Constraint $constraint ): array {
103
+	public function checkConstraintParameters(Constraint $constraint): array {
104 104
 		$constraintParameters = $constraint->getConstraintParameters();
105 105
 		$exceptions = [];
106 106
 		try {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 				$constraintParameters,
109 109
 				$constraint->getConstraintTypeItemId()
110 110
 			);
111
-		} catch ( ConstraintParameterException $e ) {
111
+		} catch (ConstraintParameterException $e) {
112 112
 			$exceptions[] = $e;
113 113
 		}
114 114
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/CommonsLinkChecker.php 1 patch
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker;
6 6
 
@@ -74,26 +74,26 @@  discard block
 block discarded – undo
74 74
 	 * @return array first element is the namespace number (default namespace for TitleParser),
75 75
 	 * second element is a string to prepend to the title before giving it to the TitleParser
76 76
 	 */
77
-	private function getCommonsNamespace( string $namespace ): array {
78
-		switch ( $namespace ) {
77
+	private function getCommonsNamespace(string $namespace): array {
78
+		switch ($namespace) {
79 79
 			case '':
80
-				return [ NS_MAIN, '' ];
80
+				return [NS_MAIN, ''];
81 81
 			// extra namespaces, see operations/mediawiki-config.git,
82 82
 			// wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey
83 83
 			case 'Creator':
84
-				return [ 100, '' ];
84
+				return [100, ''];
85 85
 			case 'TimedText':
86
-				return [ 102, '' ];
86
+				return [102, ''];
87 87
 			case 'Sequence':
88
-				return [ 104, '' ];
88
+				return [104, ''];
89 89
 			case 'Institution':
90
-				return [ 106, '' ];
90
+				return [106, ''];
91 91
 			// extension namespace, see mediawiki/extensions/JsonConfig.git,
92 92
 			// extension.json, 'namespaces' key, third element
93 93
 			case 'Data':
94
-				return [ 486, '' ];
94
+				return [486, ''];
95 95
 			default:
96
-				return [ NS_MAIN, $namespace . ':' ];
96
+				return [NS_MAIN, $namespace.':'];
97 97
 		}
98 98
 	}
99 99
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 *
103 103
 	 * @throws ConstraintParameterException
104 104
 	 */
105
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
105
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
106 106
 		$constraintParameters = $constraint->getConstraintParameters();
107 107
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
108 108
 
@@ -113,9 +113,9 @@  discard block
 block discarded – undo
113 113
 
114 114
 		$snak = $context->getSnak();
115 115
 
116
-		if ( !$snak instanceof PropertyValueSnak ) {
116
+		if (!$snak instanceof PropertyValueSnak) {
117 117
 			// nothing to check
118
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
118
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
119 119
 		}
120 120
 
121 121
 		$dataValue = $snak->getDataValue();
@@ -125,52 +125,52 @@  discard block
 block discarded – undo
125 125
 		 *   type of $dataValue for properties with 'Commons link' constraint has to be 'string'
126 126
 		 *   parameter $namespace can be null, works for commons galleries
127 127
 		 */
128
-		if ( $dataValue->getType() !== 'string' ) {
129
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
130
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
131
-				->withDataValueType( 'string' );
132
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
128
+		if ($dataValue->getType() !== 'string') {
129
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
130
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
131
+				->withDataValueType('string');
132
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
133 133
 		}
134 134
 
135 135
 		$commonsLink = $dataValue->getValue();
136
-		if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
137
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
138
-				new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
136
+		if (!$this->commonsLinkIsWellFormed($commonsLink)) {
137
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
138
+				new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
139 139
 		}
140 140
 
141
-		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty( $snak->getPropertyId() );
142
-		switch ( $dataType ) {
141
+		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty($snak->getPropertyId());
142
+		switch ($dataType) {
143 143
 			case 'geo-shape':
144 144
 			case 'tabular-data':
145
-				if ( strpos( $commonsLink, $namespace . ':' ) !== 0 ) {
146
-					return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
147
-						new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
145
+				if (strpos($commonsLink, $namespace.':') !== 0) {
146
+					return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
147
+						new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
148 148
 				}
149 149
 				$pageName = $commonsLink;
150 150
 				break;
151 151
 			default:
152
-				$pageName = $namespace ? $namespace . ':' . $commonsLink : $commonsLink;
152
+				$pageName = $namespace ? $namespace.':'.$commonsLink : $commonsLink;
153 153
 				break;
154 154
 		}
155 155
 
156
-		$prefix = $this->getCommonsNamespace( $namespace )[1];
156
+		$prefix = $this->getCommonsNamespace($namespace)[1];
157 157
 		$normalizedTitle = $this->pageNameNormalizer->normalizePageName(
158 158
 			$pageName,
159 159
 			'https://commons.wikimedia.org/w/api.php'
160 160
 		);
161
-		if ( $normalizedTitle === false ) {
162
-			if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) {
163
-				return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
164
-					new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
161
+		if ($normalizedTitle === false) {
162
+			if ($this->valueIncludesNamespace($commonsLink, $namespace)) {
163
+				return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
164
+					new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
165 165
 			}
166
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
167
-				new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' ) );
166
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
167
+				new ViolationMessage('wbqc-violation-message-commons-link-no-existent'));
168 168
 		}
169 169
 
170
-		return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE, null );
170
+		return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE, null);
171 171
 	}
172 172
 
173
-	public function checkConstraintParameters( Constraint $constraint ): array {
173
+	public function checkConstraintParameters(Constraint $constraint): array {
174 174
 		$constraintParameters = $constraint->getConstraintParameters();
175 175
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
176 176
 		$exceptions = [];
@@ -179,15 +179,15 @@  discard block
 block discarded – undo
179 179
 				$constraintParameters,
180 180
 				$constraintTypeItemId
181 181
 			);
182
-		} catch ( ConstraintParameterException $e ) {
182
+		} catch (ConstraintParameterException $e) {
183 183
 			$exceptions[] = $e;
184 184
 		}
185 185
 		return $exceptions;
186 186
 	}
187 187
 
188
-	private function commonsLinkIsWellFormed( string $commonsLink ): bool {
189
-		$toReplace = [ "_", "%20" ];
190
-		$compareString = trim( str_replace( $toReplace, '', $commonsLink ) );
188
+	private function commonsLinkIsWellFormed(string $commonsLink): bool {
189
+		$toReplace = ["_", "%20"];
190
+		$compareString = trim(str_replace($toReplace, '', $commonsLink));
191 191
 
192 192
 		return $commonsLink === $compareString;
193 193
 	}
@@ -196,9 +196,9 @@  discard block
 block discarded – undo
196 196
 	 * Checks whether the value of the statement already includes the namespace.
197 197
 	 * This special case should be reported as “malformed title” instead of “title does not exist”.
198 198
 	 */
199
-	private function valueIncludesNamespace( string $value, string $namespace ): bool {
199
+	private function valueIncludesNamespace(string $value, string $namespace): bool {
200 200
 		return $namespace !== '' &&
201
-			strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0;
201
+			strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0;
202 202
 	}
203 203
 
204 204
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/DelegatingConstraintChecker.php 1 patch
Spacing   +169 added lines, -169 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck;
6 6
 
@@ -123,10 +123,10 @@  discard block
 block discarded – undo
123 123
 		callable $defaultResultsPerEntity = null
124 124
 	): array {
125 125
 		$checkResults = [];
126
-		$entity = $this->entityLookup->getEntity( $entityId );
126
+		$entity = $this->entityLookup->getEntity($entityId);
127 127
 
128
-		if ( $entity instanceof StatementListProvidingEntity ) {
129
-			$startTime = microtime( true );
128
+		if ($entity instanceof StatementListProvidingEntity) {
129
+			$startTime = microtime(true);
130 130
 
131 131
 			$checkResults = $this->checkEveryStatement(
132 132
 				$entity,
@@ -134,9 +134,9 @@  discard block
 block discarded – undo
134 134
 				$defaultResultsPerContext
135 135
 			);
136 136
 
137
-			$endTime = microtime( true );
137
+			$endTime = microtime(true);
138 138
 
139
-			if ( $constraintIds === null ) { // only log full constraint checks
139
+			if ($constraintIds === null) { // only log full constraint checks
140 140
 				$this->loggingHelper->logConstraintCheckOnEntity(
141 141
 					$entityId,
142 142
 					$checkResults,
@@ -146,11 +146,11 @@  discard block
 block discarded – undo
146 146
 			}
147 147
 		}
148 148
 
149
-		if ( $defaultResultsPerEntity !== null ) {
150
-			$checkResults = array_merge( $defaultResultsPerEntity( $entityId ), $checkResults );
149
+		if ($defaultResultsPerEntity !== null) {
150
+			$checkResults = array_merge($defaultResultsPerEntity($entityId), $checkResults);
151 151
 		}
152 152
 
153
-		return $this->sortResult( $checkResults );
153
+		return $this->sortResult($checkResults);
154 154
 	}
155 155
 
156 156
 	/**
@@ -172,19 +172,19 @@  discard block
 block discarded – undo
172 172
 		callable $defaultResults = null
173 173
 	): array {
174 174
 
175
-		$parsedGuid = $this->statementGuidParser->parse( $guid );
175
+		$parsedGuid = $this->statementGuidParser->parse($guid);
176 176
 		$entityId = $parsedGuid->getEntityId();
177
-		$entity = $this->entityLookup->getEntity( $entityId );
178
-		if ( $entity instanceof StatementListProvidingEntity ) {
179
-			$statement = $entity->getStatements()->getFirstStatementWithGuid( $guid );
180
-			if ( $statement ) {
177
+		$entity = $this->entityLookup->getEntity($entityId);
178
+		if ($entity instanceof StatementListProvidingEntity) {
179
+			$statement = $entity->getStatements()->getFirstStatementWithGuid($guid);
180
+			if ($statement) {
181 181
 				$result = $this->checkStatement(
182 182
 					$entity,
183 183
 					$statement,
184 184
 					$constraintIds,
185 185
 					$defaultResults
186 186
 				);
187
-				$output = $this->sortResult( $result );
187
+				$output = $this->sortResult($result);
188 188
 				return $output;
189 189
 			}
190 190
 		}
@@ -192,8 +192,8 @@  discard block
 block discarded – undo
192 192
 		return [];
193 193
 	}
194 194
 
195
-	private function getValidContextTypes( Constraint $constraint ): array {
196
-		if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
195
+	private function getValidContextTypes(Constraint $constraint): array {
196
+		if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
197 197
 			return [
198 198
 				Context::TYPE_STATEMENT,
199 199
 				Context::TYPE_QUALIFIER,
@@ -201,25 +201,25 @@  discard block
 block discarded – undo
201 201
 			];
202 202
 		}
203 203
 
204
-		return array_keys( array_filter(
204
+		return array_keys(array_filter(
205 205
 			$this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedContextTypes(),
206
-			static function ( $resultStatus ) {
206
+			static function($resultStatus) {
207 207
 				return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE;
208 208
 			}
209
-		) );
209
+		));
210 210
 	}
211 211
 
212
-	private function getValidEntityTypes( Constraint $constraint ): array {
213
-		if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
214
-			return array_keys( ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED );
212
+	private function getValidEntityTypes(Constraint $constraint): array {
213
+		if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
214
+			return array_keys(ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED);
215 215
 		}
216 216
 
217
-		return array_keys( array_filter(
217
+		return array_keys(array_filter(
218 218
 			$this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedEntityTypes(),
219
-			static function ( $resultStatus ) {
219
+			static function($resultStatus) {
220 220
 				return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE;
221 221
 			}
222
-		) );
222
+		));
223 223
 	}
224 224
 
225 225
 	/**
@@ -230,38 +230,38 @@  discard block
 block discarded – undo
230 230
 	 *
231 231
 	 * @return ConstraintParameterException[]
232 232
 	 */
233
-	private function checkCommonConstraintParameters( Constraint $constraint ): array {
233
+	private function checkCommonConstraintParameters(Constraint $constraint): array {
234 234
 		$constraintParameters = $constraint->getConstraintParameters();
235 235
 		try {
236
-			$this->constraintParameterParser->checkError( $constraintParameters );
237
-		} catch ( ConstraintParameterException $e ) {
238
-			return [ $e ];
236
+			$this->constraintParameterParser->checkError($constraintParameters);
237
+		} catch (ConstraintParameterException $e) {
238
+			return [$e];
239 239
 		}
240 240
 
241 241
 		$problems = [];
242 242
 		try {
243
-			$this->constraintParameterParser->parseExceptionParameter( $constraintParameters );
244
-		} catch ( ConstraintParameterException $e ) {
243
+			$this->constraintParameterParser->parseExceptionParameter($constraintParameters);
244
+		} catch (ConstraintParameterException $e) {
245 245
 			$problems[] = $e;
246 246
 		}
247 247
 		try {
248
-			$this->constraintParameterParser->parseConstraintClarificationParameter( $constraintParameters );
249
-		} catch ( ConstraintParameterException $e ) {
248
+			$this->constraintParameterParser->parseConstraintClarificationParameter($constraintParameters);
249
+		} catch (ConstraintParameterException $e) {
250 250
 			$problems[] = $e;
251 251
 		}
252 252
 		try {
253
-			$this->constraintParameterParser->parseConstraintStatusParameter( $constraintParameters );
254
-		} catch ( ConstraintParameterException $e ) {
253
+			$this->constraintParameterParser->parseConstraintStatusParameter($constraintParameters);
254
+		} catch (ConstraintParameterException $e) {
255 255
 			$problems[] = $e;
256 256
 		}
257 257
 		try {
258 258
 			$this->constraintParameterParser->parseConstraintScopeParameters(
259 259
 				$constraintParameters,
260 260
 				$constraint->getConstraintTypeItemId(),
261
-				$this->getValidContextTypes( $constraint ),
262
-				$this->getValidEntityTypes( $constraint )
261
+				$this->getValidContextTypes($constraint),
262
+				$this->getValidEntityTypes($constraint)
263 263
 			);
264
-		} catch ( ConstraintParameterException $e ) {
264
+		} catch (ConstraintParameterException $e) {
265 265
 			$problems[] = $e;
266 266
 		}
267 267
 		return $problems;
@@ -274,16 +274,16 @@  discard block
 block discarded – undo
274 274
 	 * @return ConstraintParameterException[][] first level indexed by constraint ID,
275 275
 	 * second level like checkConstraintParametersOnConstraintId (but without possibility of null)
276 276
 	 */
277
-	public function checkConstraintParametersOnPropertyId( NumericPropertyId $propertyId ): array {
278
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
277
+	public function checkConstraintParametersOnPropertyId(NumericPropertyId $propertyId): array {
278
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
279 279
 		$result = [];
280 280
 
281
-		foreach ( $constraints as $constraint ) {
282
-			$problems = $this->checkCommonConstraintParameters( $constraint );
281
+		foreach ($constraints as $constraint) {
282
+			$problems = $this->checkCommonConstraintParameters($constraint);
283 283
 
284
-			if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
284
+			if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
285 285
 				$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
286
-				$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
286
+				$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
287 287
 			}
288 288
 
289 289
 			$result[$constraint->getConstraintId()] = $problems;
@@ -300,18 +300,18 @@  discard block
 block discarded – undo
300 300
 	 * @return ConstraintParameterException[]|null list of constraint parameter exceptions
301 301
 	 * (empty means all parameters okay), or null if constraint is not found
302 302
 	 */
303
-	public function checkConstraintParametersOnConstraintId( string $constraintId ): ?array {
304
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
303
+	public function checkConstraintParametersOnConstraintId(string $constraintId): ?array {
304
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
305 305
 		'@phan-var NumericPropertyId $propertyId';
306
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
306
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
307 307
 
308
-		foreach ( $constraints as $constraint ) {
309
-			if ( $constraint->getConstraintId() === $constraintId ) {
310
-				$problems = $this->checkCommonConstraintParameters( $constraint );
308
+		foreach ($constraints as $constraint) {
309
+			if ($constraint->getConstraintId() === $constraintId) {
310
+				$problems = $this->checkCommonConstraintParameters($constraint);
311 311
 
312
-				if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
312
+				if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
313 313
 					$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
314
-					$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
314
+					$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
315 315
 				}
316 316
 
317 317
 				return $problems;
@@ -336,14 +336,14 @@  discard block
 block discarded – undo
336 336
 		$result = [];
337 337
 
338 338
 		/** @var Statement $statement */
339
-		foreach ( $entity->getStatements() as $statement ) {
340
-			$result = array_merge( $result,
339
+		foreach ($entity->getStatements() as $statement) {
340
+			$result = array_merge($result,
341 341
 				$this->checkStatement(
342 342
 					$entity,
343 343
 					$statement,
344 344
 					$constraintIds,
345 345
 					$defaultResultsPerContext
346
-				) );
346
+				));
347 347
 		}
348 348
 
349 349
 		return $result;
@@ -365,32 +365,32 @@  discard block
 block discarded – undo
365 365
 	): array {
366 366
 		$result = [];
367 367
 
368
-		$result = array_merge( $result,
368
+		$result = array_merge($result,
369 369
 			$this->checkConstraintsForMainSnak(
370 370
 				$entity,
371 371
 				$statement,
372 372
 				$constraintIds,
373 373
 				$defaultResultsPerContext
374
-			) );
374
+			));
375 375
 
376
-		if ( $this->checkQualifiers ) {
377
-			$result = array_merge( $result,
376
+		if ($this->checkQualifiers) {
377
+			$result = array_merge($result,
378 378
 				$this->checkConstraintsForQualifiers(
379 379
 					$entity,
380 380
 					$statement,
381 381
 					$constraintIds,
382 382
 					$defaultResultsPerContext
383
-				) );
383
+				));
384 384
 		}
385 385
 
386
-		if ( $this->checkReferences ) {
387
-			$result = array_merge( $result,
386
+		if ($this->checkReferences) {
387
+			$result = array_merge($result,
388 388
 				$this->checkConstraintsForReferences(
389 389
 					$entity,
390 390
 					$statement,
391 391
 					$constraintIds,
392 392
 					$defaultResultsPerContext
393
-				) );
393
+				));
394 394
 		}
395 395
 
396 396
 		return $result;
@@ -405,17 +405,17 @@  discard block
 block discarded – undo
405 405
 	 * @param string[]|null $constraintIds
406 406
 	 * @return Constraint[]
407 407
 	 */
408
-	private function getConstraintsToUse( PropertyId $propertyId, ?array $constraintIds ): array {
409
-		if ( !( $propertyId instanceof NumericPropertyId ) ) {
408
+	private function getConstraintsToUse(PropertyId $propertyId, ?array $constraintIds): array {
409
+		if (!($propertyId instanceof NumericPropertyId)) {
410 410
 			throw new InvalidArgumentException(
411
-				'Non-numeric property ID not supported:' . $propertyId->getSerialization()
411
+				'Non-numeric property ID not supported:'.$propertyId->getSerialization()
412 412
 			);
413 413
 		}
414
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
415
-		if ( $constraintIds !== null ) {
414
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
415
+		if ($constraintIds !== null) {
416 416
 			$constraintsToUse = [];
417
-			foreach ( $constraints as $constraint ) {
418
-				if ( in_array( $constraint->getConstraintId(), $constraintIds ) ) {
417
+			foreach ($constraints as $constraint) {
418
+				if (in_array($constraint->getConstraintId(), $constraintIds)) {
419 419
 					$constraintsToUse[] = $constraint;
420 420
 				}
421 421
 			}
@@ -439,18 +439,18 @@  discard block
 block discarded – undo
439 439
 		?array $constraintIds,
440 440
 		?callable $defaultResults
441 441
 	): array {
442
-		$context = new MainSnakContext( $entity, $statement );
442
+		$context = new MainSnakContext($entity, $statement);
443 443
 		$constraints = $this->getConstraintsToUse(
444 444
 			$statement->getPropertyId(),
445 445
 			$constraintIds
446 446
 		);
447
-		$result = $defaultResults !== null ? $defaultResults( $context ) : [];
447
+		$result = $defaultResults !== null ? $defaultResults($context) : [];
448 448
 
449
-		foreach ( $constraints as $constraint ) {
449
+		foreach ($constraints as $constraint) {
450 450
 			$parameters = $constraint->getConstraintParameters();
451 451
 			try {
452
-				$exceptions = $this->constraintParameterParser->parseExceptionParameter( $parameters );
453
-			} catch ( ConstraintParameterException $e ) {
452
+				$exceptions = $this->constraintParameterParser->parseExceptionParameter($parameters);
453
+			} catch (ConstraintParameterException $e) {
454 454
 				$result[] = new CheckResult(
455 455
 					$context,
456 456
 					$constraint,
@@ -460,13 +460,13 @@  discard block
 block discarded – undo
460 460
 				continue;
461 461
 			}
462 462
 
463
-			if ( in_array( $entity->getId(), $exceptions ) ) {
464
-				$message = new ViolationMessage( 'wbqc-violation-message-exception' );
465
-				$result[] = new CheckResult( $context, $constraint, CheckResult::STATUS_EXCEPTION, $message );
463
+			if (in_array($entity->getId(), $exceptions)) {
464
+				$message = new ViolationMessage('wbqc-violation-message-exception');
465
+				$result[] = new CheckResult($context, $constraint, CheckResult::STATUS_EXCEPTION, $message);
466 466
 				continue;
467 467
 			}
468 468
 
469
-			$result[] = $this->getCheckResultFor( $context, $constraint );
469
+			$result[] = $this->getCheckResultFor($context, $constraint);
470 470
 		}
471 471
 
472 472
 		return $result;
@@ -488,24 +488,24 @@  discard block
 block discarded – undo
488 488
 	): array {
489 489
 		$result = [];
490 490
 
491
-		if ( in_array(
491
+		if (in_array(
492 492
 			$statement->getPropertyId()->getSerialization(),
493 493
 			$this->propertiesWithViolatingQualifiers
494
-		) ) {
494
+		)) {
495 495
 			return $result;
496 496
 		}
497 497
 
498
-		foreach ( $statement->getQualifiers() as $qualifier ) {
499
-			$qualifierContext = new QualifierContext( $entity, $statement, $qualifier );
500
-			if ( $defaultResultsPerContext !== null ) {
501
-				$result = array_merge( $result, $defaultResultsPerContext( $qualifierContext ) );
498
+		foreach ($statement->getQualifiers() as $qualifier) {
499
+			$qualifierContext = new QualifierContext($entity, $statement, $qualifier);
500
+			if ($defaultResultsPerContext !== null) {
501
+				$result = array_merge($result, $defaultResultsPerContext($qualifierContext));
502 502
 			}
503 503
 			$qualifierConstraints = $this->getConstraintsToUse(
504 504
 				$qualifierContext->getSnak()->getPropertyId(),
505 505
 				$constraintIds
506 506
 			);
507
-			foreach ( $qualifierConstraints as $qualifierConstraint ) {
508
-				$result[] = $this->getCheckResultFor( $qualifierContext, $qualifierConstraint );
507
+			foreach ($qualifierConstraints as $qualifierConstraint) {
508
+				$result[] = $this->getCheckResultFor($qualifierContext, $qualifierConstraint);
509 509
 			}
510 510
 		}
511 511
 
@@ -529,19 +529,19 @@  discard block
 block discarded – undo
529 529
 		$result = [];
530 530
 
531 531
 		/** @var Reference $reference */
532
-		foreach ( $statement->getReferences() as $reference ) {
533
-			foreach ( $reference->getSnaks() as $snak ) {
532
+		foreach ($statement->getReferences() as $reference) {
533
+			foreach ($reference->getSnaks() as $snak) {
534 534
 				$referenceContext = new ReferenceContext(
535 535
 					$entity, $statement, $reference, $snak
536 536
 				);
537
-				if ( $defaultResultsPerContext !== null ) {
538
-					$result = array_merge( $result, $defaultResultsPerContext( $referenceContext ) );
537
+				if ($defaultResultsPerContext !== null) {
538
+					$result = array_merge($result, $defaultResultsPerContext($referenceContext));
539 539
 				}
540 540
 				$referenceConstraints = $this->getConstraintsToUse(
541 541
 					$referenceContext->getSnak()->getPropertyId(),
542 542
 					$constraintIds
543 543
 				);
544
-				foreach ( $referenceConstraints as $referenceConstraint ) {
544
+				foreach ($referenceConstraints as $referenceConstraint) {
545 545
 					$result[] = $this->getCheckResultFor(
546 546
 						$referenceContext,
547 547
 						$referenceConstraint
@@ -553,50 +553,50 @@  discard block
 block discarded – undo
553 553
 		return $result;
554 554
 	}
555 555
 
556
-	private function getCheckResultFor( Context $context, Constraint $constraint ): CheckResult {
557
-		if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
556
+	private function getCheckResultFor(Context $context, Constraint $constraint): CheckResult {
557
+		if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
558 558
 			$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
559
-			$result = $this->handleScope( $checker, $context, $constraint );
559
+			$result = $this->handleScope($checker, $context, $constraint);
560 560
 
561
-			if ( $result !== null ) {
562
-				$this->addMetadata( $context, $result );
561
+			if ($result !== null) {
562
+				$this->addMetadata($context, $result);
563 563
 				return $result;
564 564
 			}
565 565
 
566
-			$startTime = microtime( true );
566
+			$startTime = microtime(true);
567 567
 			try {
568
-				$result = $checker->checkConstraint( $context, $constraint );
569
-			} catch ( ConstraintParameterException $e ) {
568
+				$result = $checker->checkConstraint($context, $constraint);
569
+			} catch (ConstraintParameterException $e) {
570 570
 				$result = new CheckResult(
571 571
 					$context,
572 572
 					$constraint,
573 573
 					CheckResult::STATUS_BAD_PARAMETERS,
574 574
 					$e->getViolationMessage()
575 575
 				);
576
-			} catch ( SparqlHelperException $e ) {
577
-				$message = new ViolationMessage( 'wbqc-violation-message-sparql-error' );
578
-				$result = new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, $message );
576
+			} catch (SparqlHelperException $e) {
577
+				$message = new ViolationMessage('wbqc-violation-message-sparql-error');
578
+				$result = new CheckResult($context, $constraint, CheckResult::STATUS_TODO, $message);
579 579
 			}
580
-			$endTime = microtime( true );
580
+			$endTime = microtime(true);
581 581
 
582
-			$this->addMetadata( $context, $result );
582
+			$this->addMetadata($context, $result);
583 583
 
584
-			$this->addConstraintClarification( $result );
584
+			$this->addConstraintClarification($result);
585 585
 
586
-			$this->downgradeResultStatus( $result );
586
+			$this->downgradeResultStatus($result);
587 587
 
588 588
 			$this->loggingHelper->logConstraintCheck(
589 589
 				$context,
590 590
 				$constraint,
591 591
 				$result,
592
-				get_class( $checker ),
592
+				get_class($checker),
593 593
 				$endTime - $startTime,
594 594
 				__METHOD__
595 595
 			);
596 596
 
597 597
 			return $result;
598 598
 		} else {
599
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null );
599
+			return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null);
600 600
 		}
601 601
 	}
602 602
 
@@ -605,91 +605,91 @@  discard block
 block discarded – undo
605 605
 		Context $context,
606 606
 		Constraint $constraint
607 607
 	): ?CheckResult {
608
-		$validContextTypes = $this->getValidContextTypes( $constraint );
609
-		$validEntityTypes = $this->getValidEntityTypes( $constraint );
608
+		$validContextTypes = $this->getValidContextTypes($constraint);
609
+		$validEntityTypes = $this->getValidEntityTypes($constraint);
610 610
 		try {
611
-			[ $checkedContextTypes, $checkedEntityTypes ] = $this->constraintParameterParser->parseConstraintScopeParameters(
611
+			[$checkedContextTypes, $checkedEntityTypes] = $this->constraintParameterParser->parseConstraintScopeParameters(
612 612
 				$constraint->getConstraintParameters(),
613 613
 				$constraint->getConstraintTypeItemId(),
614 614
 				$validContextTypes,
615 615
 				$validEntityTypes
616 616
 			);
617
-		} catch ( ConstraintParameterException $e ) {
618
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
617
+		} catch (ConstraintParameterException $e) {
618
+			return new CheckResult($context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
619 619
 		}
620 620
 
621
-		if ( $checkedContextTypes === null ) {
621
+		if ($checkedContextTypes === null) {
622 622
 			$checkedContextTypes = $checker->getDefaultContextTypes();
623 623
 		}
624 624
 		$contextType = $context->getType();
625
-		if ( !in_array( $contextType, $checkedContextTypes ) ) {
626
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null );
625
+		if (!in_array($contextType, $checkedContextTypes)) {
626
+			return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null);
627 627
 		}
628
-		if ( $checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO ) {
629
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null );
628
+		if ($checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO) {
629
+			return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null);
630 630
 		}
631 631
 
632
-		if ( $checkedEntityTypes === null ) {
632
+		if ($checkedEntityTypes === null) {
633 633
 			$checkedEntityTypes = $validEntityTypes;
634 634
 		}
635 635
 		$entityType = $context->getEntity()->getType();
636
-		if ( !in_array( $entityType, $checkedEntityTypes ) ) {
637
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null );
636
+		if (!in_array($entityType, $checkedEntityTypes)) {
637
+			return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null);
638 638
 		}
639
-		if ( $checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO ) {
640
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null );
639
+		if ($checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO) {
640
+			return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null);
641 641
 		}
642 642
 
643 643
 		return null;
644 644
 	}
645 645
 
646
-	private function addMetadata( Context $context, CheckResult $result ): void {
647
-		$result->withMetadata( Metadata::merge( [
646
+	private function addMetadata(Context $context, CheckResult $result): void {
647
+		$result->withMetadata(Metadata::merge([
648 648
 			$result->getMetadata(),
649
-			Metadata::ofDependencyMetadata( DependencyMetadata::merge( [
650
-				DependencyMetadata::ofEntityId( $context->getEntity()->getId() ),
651
-				DependencyMetadata::ofEntityId( $result->getConstraint()->getPropertyId() ),
652
-			] ) ),
653
-		] ) );
649
+			Metadata::ofDependencyMetadata(DependencyMetadata::merge([
650
+				DependencyMetadata::ofEntityId($context->getEntity()->getId()),
651
+				DependencyMetadata::ofEntityId($result->getConstraint()->getPropertyId()),
652
+			])),
653
+		]));
654 654
 	}
655 655
 
656
-	private function addConstraintClarification( CheckResult $result ): void {
656
+	private function addConstraintClarification(CheckResult $result): void {
657 657
 		$constraint = $result->getConstraint();
658 658
 		try {
659 659
 			$constraintClarification = $this->constraintParameterParser
660
-				->parseConstraintClarificationParameter( $constraint->getConstraintParameters() );
661
-			$result->setConstraintClarification( $constraintClarification );
662
-		} catch ( ConstraintParameterException $e ) {
663
-			$result->setStatus( CheckResult::STATUS_BAD_PARAMETERS );
664
-			$result->setMessage( $e->getViolationMessage() );
660
+				->parseConstraintClarificationParameter($constraint->getConstraintParameters());
661
+			$result->setConstraintClarification($constraintClarification);
662
+		} catch (ConstraintParameterException $e) {
663
+			$result->setStatus(CheckResult::STATUS_BAD_PARAMETERS);
664
+			$result->setMessage($e->getViolationMessage());
665 665
 		}
666 666
 	}
667 667
 
668
-	private function downgradeResultStatus( CheckResult $result ): void {
668
+	private function downgradeResultStatus(CheckResult $result): void {
669 669
 		$constraint = $result->getConstraint();
670 670
 		try {
671 671
 			$constraintStatus = $this->constraintParameterParser
672
-				->parseConstraintStatusParameter( $constraint->getConstraintParameters() );
673
-		} catch ( ConstraintParameterException $e ) {
674
-			$result->setStatus( CheckResult::STATUS_BAD_PARAMETERS );
675
-			$result->setMessage( $e->getViolationMessage() );
672
+				->parseConstraintStatusParameter($constraint->getConstraintParameters());
673
+		} catch (ConstraintParameterException $e) {
674
+			$result->setStatus(CheckResult::STATUS_BAD_PARAMETERS);
675
+			$result->setMessage($e->getViolationMessage());
676 676
 			return;
677 677
 		}
678
-		if ( $constraintStatus === null ) {
678
+		if ($constraintStatus === null) {
679 679
 			// downgrade violation to warning
680
-			if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) {
681
-				$result->setStatus( CheckResult::STATUS_WARNING );
680
+			if ($result->getStatus() === CheckResult::STATUS_VIOLATION) {
681
+				$result->setStatus(CheckResult::STATUS_WARNING);
682 682
 			}
683
-		} elseif ( $constraintStatus === 'suggestion' ) {
683
+		} elseif ($constraintStatus === 'suggestion') {
684 684
 			// downgrade violation to suggestion
685
-			if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) {
686
-				$result->setStatus( CheckResult::STATUS_SUGGESTION );
685
+			if ($result->getStatus() === CheckResult::STATUS_VIOLATION) {
686
+				$result->setStatus(CheckResult::STATUS_SUGGESTION);
687 687
 			}
688 688
 		} else {
689
-			if ( $constraintStatus !== 'mandatory' ) {
689
+			if ($constraintStatus !== 'mandatory') {
690 690
 				// @codeCoverageIgnoreStart
691 691
 				throw new LogicException(
692
-					"Unknown constraint status '$constraintStatus', " .
692
+					"Unknown constraint status '$constraintStatus', ".
693 693
 					"only known statuses are 'mandatory' and 'suggestion'"
694 694
 				);
695 695
 				// @codeCoverageIgnoreEnd
@@ -702,12 +702,12 @@  discard block
 block discarded – undo
702 702
 	 *
703 703
 	 * @return CheckResult[]
704 704
 	 */
705
-	private function sortResult( array $result ): array {
706
-		if ( count( $result ) < 2 ) {
705
+	private function sortResult(array $result): array {
706
+		if (count($result) < 2) {
707 707
 			return $result;
708 708
 		}
709 709
 
710
-		$sortFunction = static function ( CheckResult $a, CheckResult $b ) {
710
+		$sortFunction = static function(CheckResult $a, CheckResult $b) {
711 711
 			$orderNum = 0;
712 712
 			$order = [
713 713
 				CheckResult::STATUS_BAD_PARAMETERS => $orderNum++,
@@ -724,55 +724,55 @@  discard block
 block discarded – undo
724 724
 			$statusA = $a->getStatus();
725 725
 			$statusB = $b->getStatus();
726 726
 
727
-			$orderA = array_key_exists( $statusA, $order ) ? $order[ $statusA ] : $order[ 'other' ];
728
-			$orderB = array_key_exists( $statusB, $order ) ? $order[ $statusB ] : $order[ 'other' ];
727
+			$orderA = array_key_exists($statusA, $order) ? $order[$statusA] : $order['other'];
728
+			$orderB = array_key_exists($statusB, $order) ? $order[$statusB] : $order['other'];
729 729
 
730
-			if ( $orderA === $orderB ) {
730
+			if ($orderA === $orderB) {
731 731
 				$cursorA = $a->getContextCursor();
732 732
 				$cursorB = $b->getContextCursor();
733 733
 
734
-				if ( $cursorA instanceof EntityContextCursor ) {
734
+				if ($cursorA instanceof EntityContextCursor) {
735 735
 					return $cursorB instanceof EntityContextCursor ? 0 : -1;
736 736
 				}
737
-				if ( $cursorB instanceof EntityContextCursor ) {
737
+				if ($cursorB instanceof EntityContextCursor) {
738 738
 					return $cursorA instanceof EntityContextCursor ? 0 : 1;
739 739
 				}
740 740
 
741 741
 				$pidA = $cursorA->getSnakPropertyId();
742 742
 				$pidB = $cursorB->getSnakPropertyId();
743 743
 
744
-				if ( $pidA === $pidB ) {
744
+				if ($pidA === $pidB) {
745 745
 					$hashA = $cursorA->getSnakHash();
746 746
 					$hashB = $cursorB->getSnakHash();
747 747
 
748
-					if ( $hashA === $hashB ) {
749
-						if ( $a instanceof NullResult ) {
748
+					if ($hashA === $hashB) {
749
+						if ($a instanceof NullResult) {
750 750
 							return $b instanceof NullResult ? 0 : -1;
751 751
 						}
752
-						if ( $b instanceof NullResult ) {
752
+						if ($b instanceof NullResult) {
753 753
 							return $a instanceof NullResult ? 0 : 1;
754 754
 						}
755 755
 
756 756
 						$typeA = $a->getConstraint()->getConstraintTypeItemId();
757 757
 						$typeB = $b->getConstraint()->getConstraintTypeItemId();
758 758
 
759
-						if ( $typeA == $typeB ) {
759
+						if ($typeA == $typeB) {
760 760
 							return 0;
761 761
 						} else {
762
-							return ( $typeA > $typeB ) ? 1 : -1;
762
+							return ($typeA > $typeB) ? 1 : -1;
763 763
 						}
764 764
 					} else {
765
-						return ( $hashA > $hashB ) ? 1 : -1;
765
+						return ($hashA > $hashB) ? 1 : -1;
766 766
 					}
767 767
 				} else {
768
-					return ( $pidA > $pidB ) ? 1 : -1;
768
+					return ($pidA > $pidB) ? 1 : -1;
769 769
 				}
770 770
 			} else {
771
-				return ( $orderA > $orderB ) ? 1 : -1;
771
+				return ($orderA > $orderB) ? 1 : -1;
772 772
 			}
773 773
 		};
774 774
 
775
-		uasort( $result, $sortFunction );
775
+		uasort($result, $sortFunction);
776 776
 
777 777
 		return $result;
778 778
 	}
Please login to merge, or discard this patch.
src/Specials/SpecialConstraintReport.php 1 patch
Spacing   +82 added lines, -82 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WikibaseQuality\ConstraintReport\Specials;
6 6
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 		Config $config,
91 91
 		IBufferingStatsdDataFactory $dataFactory
92 92
 	) {
93
-		parent::__construct( 'ConstraintReport' );
93
+		parent::__construct('ConstraintReport');
94 94
 
95 95
 		$this->entityLookup = $entityLookup;
96 96
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
 		$this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer(
112 112
 			$language,
113
-			$languageFallbackChainFactory->newFromLanguage( $language ),
113
+			$languageFallbackChainFactory->newFromLanguage($language),
114 114
 			$this->getContext()
115 115
 		);
116 116
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 * @inheritDoc
145 145
 	 */
146 146
 	public function getDescription() {
147
-		return $this->msg( 'wbqc-constraintreport' );
147
+		return $this->msg('wbqc-constraintreport');
148 148
 	}
149 149
 
150 150
 	/**
@@ -156,43 +156,43 @@  discard block
 block discarded – undo
156 156
 	 * @throws EntityIdParsingException
157 157
 	 * @throws UnexpectedValueException
158 158
 	 */
159
-	public function execute( $subPage ) {
159
+	public function execute($subPage) {
160 160
 		$out = $this->getOutput();
161 161
 
162
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
163
-		if ( $postRequest ) {
164
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
162
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
163
+		if ($postRequest) {
164
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
165 165
 			return;
166 166
 		}
167 167
 
168 168
 		$out->enableOOUI();
169
-		$out->addModules( $this->getModules() );
169
+		$out->addModules($this->getModules());
170 170
 
171 171
 		$this->setHeaders();
172 172
 
173
-		$out->addHTML( $this->getExplanationText() );
173
+		$out->addHTML($this->getExplanationText());
174 174
 		$this->buildEntityIdForm();
175 175
 
176
-		if ( !$subPage ) {
176
+		if (!$subPage) {
177 177
 			return;
178 178
 		}
179 179
 
180
-		if ( !is_string( $subPage ) ) {
181
-			throw new InvalidArgumentException( '$subPage must be string.' );
180
+		if (!is_string($subPage)) {
181
+			throw new InvalidArgumentException('$subPage must be string.');
182 182
 		}
183 183
 
184 184
 		try {
185
-			$entityId = $this->entityIdParser->parse( $subPage );
186
-		} catch ( EntityIdParsingException $e ) {
185
+			$entityId = $this->entityIdParser->parse($subPage);
186
+		} catch (EntityIdParsingException $e) {
187 187
 			$out->addHTML(
188
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
188
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
189 189
 			);
190 190
 			return;
191 191
 		}
192 192
 
193
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
193
+		if (!$this->entityLookup->hasEntity($entityId)) {
194 194
 			$out->addHTML(
195
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
195
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
196 196
 			);
197 197
 			return;
198 198
 		}
@@ -200,18 +200,18 @@  discard block
 block discarded – undo
200 200
 		$this->dataFactory->increment(
201 201
 			'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck'
202 202
 		);
203
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
203
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
204 204
 
205
-		if ( $results !== [] ) {
205
+		if ($results !== []) {
206 206
 			$out->addHTML(
207
-				$this->buildResultHeader( $entityId )
208
-				. $this->buildSummary( $results )
209
-				. $this->buildResultTable( $entityId, $results )
207
+				$this->buildResultHeader($entityId)
208
+				. $this->buildSummary($results)
209
+				. $this->buildResultTable($entityId, $results)
210 210
 			);
211 211
 		} else {
212 212
 			$out->addHTML(
213
-				$this->buildResultHeader( $entityId )
214
-				. $this->buildNotice( 'wbqc-constraintreport-empty-result' )
213
+				$this->buildResultHeader($entityId)
214
+				. $this->buildNotice('wbqc-constraintreport-empty-result')
215 215
 			);
216 216
 		}
217 217
 	}
@@ -227,15 +227,15 @@  discard block
 block discarded – undo
227 227
 				'name' => 'entityid',
228 228
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
229 229
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
230
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped(),
230
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped(),
231 231
 			],
232 232
 		];
233
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' );
234
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() );
235
-		$htmlForm->setSubmitCallback( static function () {
233
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form');
234
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped());
235
+		$htmlForm->setSubmitCallback(static function() {
236 236
 			return false;
237 237
 		} );
238
-		$htmlForm->setMethod( 'post' );
238
+		$htmlForm->setMethod('post');
239 239
 		$htmlForm->show();
240 240
 	}
241 241
 
@@ -249,9 +249,9 @@  discard block
 block discarded – undo
249 249
 	 *
250 250
 	 * @return string HTML
251 251
 	 */
252
-	private function buildNotice( string $messageKey, bool $error = false ): string {
252
+	private function buildNotice(string $messageKey, bool $error = false): string {
253 253
 		$cssClasses = 'wbqc-constraintreport-notice';
254
-		if ( $error ) {
254
+		if ($error) {
255 255
 			$cssClasses .= ' wbqc-constraintreport-notice-error';
256 256
 		}
257 257
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
 				[
261 261
 					'class' => $cssClasses,
262 262
 				],
263
-				$this->msg( $messageKey )->escaped()
263
+				$this->msg($messageKey)->escaped()
264 264
 			);
265 265
 	}
266 266
 
@@ -270,16 +270,16 @@  discard block
 block discarded – undo
270 270
 	private function getExplanationText(): string {
271 271
 		return Html::rawElement(
272 272
 			'div',
273
-			[ 'class' => 'wbqc-explanation' ],
273
+			['class' => 'wbqc-explanation'],
274 274
 			Html::rawElement(
275 275
 				'p',
276 276
 				[],
277
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped()
277
+				$this->msg('wbqc-constraintreport-explanation-part-one')->escaped()
278 278
 			)
279 279
 			. Html::rawElement(
280 280
 				'p',
281 281
 				[],
282
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped()
282
+				$this->msg('wbqc-constraintreport-explanation-part-two')->escaped()
283 283
 			)
284 284
 		);
285 285
 	}
@@ -290,31 +290,31 @@  discard block
 block discarded – undo
290 290
 	 *
291 291
 	 * @return string HTML
292 292
 	 */
293
-	private function buildResultTable( EntityId $entityId, array $results ): string {
293
+	private function buildResultTable(EntityId $entityId, array $results): string {
294 294
 		// Set table headers
295 295
 		$table = new HtmlTableBuilder(
296 296
 			[
297 297
 				new HtmlTableHeaderBuilder(
298
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->text(),
298
+					$this->msg('wbqc-constraintreport-result-table-header-status')->text(),
299 299
 					true
300 300
 				),
301 301
 				new HtmlTableHeaderBuilder(
302
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->text(),
302
+					$this->msg('wbqc-constraintreport-result-table-header-property')->text(),
303 303
 					true
304 304
 				),
305 305
 				new HtmlTableHeaderBuilder(
306
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->text(),
306
+					$this->msg('wbqc-constraintreport-result-table-header-message')->text(),
307 307
 					true
308 308
 				),
309 309
 				new HtmlTableHeaderBuilder(
310
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->text(),
310
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->text(),
311 311
 					true
312 312
 				),
313 313
 			]
314 314
 		);
315 315
 
316
-		foreach ( $results as $result ) {
317
-			$table = $this->appendToResultTable( $table, $entityId, $result );
316
+		foreach ($results as $result) {
317
+			$table = $this->appendToResultTable($table, $entityId, $result);
318 318
 		}
319 319
 
320 320
 		return $table->toHtml();
@@ -326,35 +326,35 @@  discard block
 block discarded – undo
326 326
 		CheckResult $result
327 327
 	): HtmlTableBuilder {
328 328
 		$message = $result->getMessage();
329
-		if ( $message === null ) {
329
+		if ($message === null) {
330 330
 			// no row for this result
331 331
 			return $table;
332 332
 		}
333 333
 
334 334
 		// Status column
335
-		$statusColumn = $this->formatStatus( $result->getStatus() );
335
+		$statusColumn = $this->formatStatus($result->getStatus());
336 336
 
337 337
 		// Property column
338
-		$propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() );
338
+		$propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId());
339 339
 		$propertyColumn = $this->getClaimLink(
340 340
 			$entityId,
341 341
 			$propertyId,
342
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
342
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
343 343
 		);
344 344
 
345 345
 		// Message column
346
-		$messageColumn = $this->violationMessageRenderer->render( $message );
346
+		$messageColumn = $this->violationMessageRenderer->render($message);
347 347
 
348 348
 		// Constraint column
349 349
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
350 350
 		try {
351
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
352
-		} catch ( InvalidArgumentException $e ) {
353
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
351
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
352
+		} catch (InvalidArgumentException $e) {
353
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
354 354
 		}
355 355
 		$constraintColumn = $this->getClaimLink(
356 356
 			$propertyId,
357
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
357
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
358 358
 			$constraintTypeLabel
359 359
 		);
360 360
 
@@ -362,16 +362,16 @@  discard block
 block discarded – undo
362 362
 		$table->appendRow(
363 363
 			[
364 364
 				new HtmlTableCellBuilder(
365
-					new HtmlArmor( $statusColumn )
365
+					new HtmlArmor($statusColumn)
366 366
 				),
367 367
 				new HtmlTableCellBuilder(
368
-					new HtmlArmor( $propertyColumn )
368
+					new HtmlArmor($propertyColumn)
369 369
 				),
370 370
 				new HtmlTableCellBuilder(
371
-					new HtmlArmor( $messageColumn )
371
+					new HtmlArmor($messageColumn)
372 372
 				),
373 373
 				new HtmlTableCellBuilder(
374
-					new HtmlArmor( $constraintColumn )
374
+					new HtmlArmor($constraintColumn)
375 375
 				),
376 376
 			]
377 377
 		);
@@ -386,15 +386,15 @@  discard block
 block discarded – undo
386 386
 	 *
387 387
 	 * @return string HTML
388 388
 	 */
389
-	protected function buildResultHeader( EntityId $entityId ): string {
390
-		$entityLink = sprintf( '%s (%s)',
391
-							   $this->entityIdLinkFormatter->formatEntityId( $entityId ),
392
-							   htmlspecialchars( $entityId->getSerialization() ) );
389
+	protected function buildResultHeader(EntityId $entityId): string {
390
+		$entityLink = sprintf('%s (%s)',
391
+							   $this->entityIdLinkFormatter->formatEntityId($entityId),
392
+							   htmlspecialchars($entityId->getSerialization()));
393 393
 
394 394
 		return Html::rawElement(
395 395
 			'h3',
396 396
 			[],
397
-			sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink )
397
+			sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink)
398 398
 		);
399 399
 	}
400 400
 
@@ -405,24 +405,24 @@  discard block
 block discarded – undo
405 405
 	 *
406 406
 	 * @return string HTML
407 407
 	 */
408
-	protected function buildSummary( array $results ): string {
408
+	protected function buildSummary(array $results): string {
409 409
 		$statuses = [];
410
-		foreach ( $results as $result ) {
411
-			$status = strtolower( $result->getStatus() );
412
-			$statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1;
410
+		foreach ($results as $result) {
411
+			$status = strtolower($result->getStatus());
412
+			$statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1;
413 413
 		}
414 414
 
415 415
 		$statusElements = [];
416
-		foreach ( $statuses as $status => $count ) {
417
-			if ( $count > 0 ) {
416
+		foreach ($statuses as $status => $count) {
417
+			if ($count > 0) {
418 418
 				$statusElements[] =
419
-					$this->formatStatus( $status )
419
+					$this->formatStatus($status)
420 420
 					. ': '
421 421
 					. $count;
422 422
 			}
423 423
 		}
424 424
 
425
-		return Html::rawElement( 'p', [], implode( ', ', $statusElements ) );
425
+		return Html::rawElement('p', [], implode(', ', $statusElements));
426 426
 	}
427 427
 
428 428
 	/**
@@ -434,8 +434,8 @@  discard block
 block discarded – undo
434 434
 	 *
435 435
 	 * @return string HTML
436 436
 	 */
437
-	private function formatStatus( string $status ): string {
438
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
437
+	private function formatStatus(string $status): string {
438
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
439 439
 		$statusIcons = [
440 440
 			CheckResult::STATUS_SUGGESTION => [
441 441
 				'icon' => 'suggestion-constraint-violation',
@@ -452,25 +452,25 @@  discard block
 block discarded – undo
452 452
 			],
453 453
 		];
454 454
 
455
-		if ( array_key_exists( $status, $statusIcons ) ) {
456
-			$iconWidget = new IconWidget( $statusIcons[$status] );
457
-			$iconHtml = $iconWidget->toString() . ' ';
455
+		if (array_key_exists($status, $statusIcons)) {
456
+			$iconWidget = new IconWidget($statusIcons[$status]);
457
+			$iconHtml = $iconWidget->toString().' ';
458 458
 		} else {
459 459
 			$iconHtml = '';
460 460
 		}
461 461
 
462
-		$labelWidget = new LabelWidget( [
463
-			'label' => $this->msg( $messageName )->text(),
464
-		] );
462
+		$labelWidget = new LabelWidget([
463
+			'label' => $this->msg($messageName)->text(),
464
+		]);
465 465
 		$labelHtml = $labelWidget->toString();
466 466
 
467 467
 		$formattedStatus =
468 468
 			Html::rawElement(
469 469
 				'span',
470 470
 				[
471
-					'class' => 'wbqc-status wbqc-status-' . $status,
471
+					'class' => 'wbqc-status wbqc-status-'.$status,
472 472
 				],
473
-				$iconHtml . $labelHtml
473
+				$iconHtml.$labelHtml
474 474
 			);
475 475
 
476 476
 		return $formattedStatus;
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
 		return Html::rawElement(
494 494
 			'a',
495 495
 			[
496
-				'href' => $this->getClaimUrl( $entityId, $propertyId ),
496
+				'href' => $this->getClaimUrl($entityId, $propertyId),
497 497
 				'target' => '_blank',
498 498
 			],
499 499
 			$text
@@ -507,8 +507,8 @@  discard block
 block discarded – undo
507 507
 		EntityId $entityId,
508 508
 		NumericPropertyId $propertyId
509 509
 	): string {
510
-		$title = $this->entityTitleLookup->getTitleForId( $entityId );
511
-		$entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() );
510
+		$title = $this->entityTitleLookup->getTitleForId($entityId);
511
+		$entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization());
512 512
 
513 513
 		return $entityUrl;
514 514
 	}
Please login to merge, or discard this patch.