wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/ItemChecker.php

Spacing +18 added lines, -18 removed lines

@@ -86,18 +86,18 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		/*
@@ -105,7 +105,7 @@ 
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$context->getEntity()->getStatements(),
 				$propertyId
@@ -118,31 +118,31 @@ 
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Helper/ConstraintParameterParser.php

Spacing +210 added lines, -210 removed lines

@@ -77,15 +77,15 @@ 
 	 * @param array $parameters
 	 * @throws ConstraintParameterException
 	 */
-	public function checkError( array $parameters ) {
-		if ( array_key_exists( '@error', $parameters ) ) {
+	public function checkError(array $parameters) {
+		if (array_key_exists('@error', $parameters)) {
 			$error = $parameters['@error'];
-			if ( array_key_exists( 'toolong', $error ) && $error['toolong'] ) {
+			if (array_key_exists('toolong', $error) && $error['toolong']) {
 				$msg = 'wbqc-violation-message-parameters-error-toolong';
 			} else {
 				$msg = 'wbqc-violation-message-parameters-error-unknown';
 			}
-			throw new ConstraintParameterException( wfMessage( $msg )->escaped() );
+			throw new ConstraintParameterException(wfMessage($msg)->escaped());
 		}
 	}
 
@@ -95,11 +95,11 @@ 
 	 * @param string $parameterId
 	 * @throws ConstraintParameterException
 	 */
-	private function requireSingleParameter( array $parameters, $parameterId ) {
-		if ( count( $parameters[$parameterId] ) !== 1 ) {
+	private function requireSingleParameter(array $parameters, $parameterId) {
+		if (count($parameters[$parameterId]) !== 1) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-single' )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-single')
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
@@ -112,11 +112,11 @@ 
 	 * @return void
 	 * @throws ConstraintParameterException
 	 */
-	private function requireValueParameter( Snak $snak, $parameterId ) {
-		if ( !( $snak instanceof PropertyValueSnak ) ) {
+	private function requireValueParameter(Snak $snak, $parameterId) {
+		if (!($snak instanceof PropertyValueSnak)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-value' )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-value')
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
@@ -129,18 +129,18 @@ 
 	 * @throws ConstraintParameterException
 	 * @return EntityId
 	 */
-	private function parseEntityIdParameter( array $snakSerialization, $parameterId ) {
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
-		$this->requireValueParameter( $snak, $parameterId );
+	private function parseEntityIdParameter(array $snakSerialization, $parameterId) {
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
+		$this->requireValueParameter($snak, $parameterId);
 		$value = $snak->getDataValue();
-		if ( $value instanceof EntityIdValue ) {
+		if ($value instanceof EntityIdValue) {
 			return $value->getEntityId();
 		} else {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-entity' )
+				wfMessage('wbqc-violation-message-parameter-entity')
 					->rawParams(
-						$this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ),
-						$this->constraintParameterRenderer->formatDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE )
+						$this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY),
+						$this->constraintParameterRenderer->formatDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE)
 					)
 					->escaped()
 			);
@@ -153,21 +153,21 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return string[] class entity ID serializations
 	 */
-	public function parseClassParameter( array $constraintParameters, $constraintTypeItemId ) {
-		$this->checkError( $constraintParameters );
-		$classId = $this->config->get( 'WBQualityConstraintsClassId' );
-		if ( !array_key_exists( $classId, $constraintParameters ) ) {
+	public function parseClassParameter(array $constraintParameters, $constraintTypeItemId) {
+		$this->checkError($constraintParameters);
+		$classId = $this->config->get('WBQualityConstraintsClassId');
+		if (!array_key_exists($classId, $constraintParameters)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-needed' )
-					->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $classId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-needed')
+					->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM))
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($classId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
 
 		$classes = [];
-		foreach ( $constraintParameters[$classId] as $class ) {
-			$classes[] = $this->parseEntityIdParameter( $class, $classId )->getSerialization();
+		foreach ($constraintParameters[$classId] as $class) {
+			$classes[] = $this->parseEntityIdParameter($class, $classId)->getSerialization();
 		}
 		return $classes;
 	}
@@ -178,24 +178,24 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return string 'instance', 'subclass', or 'instanceOrSubclass'
 	 */
-	public function parseRelationParameter( array $constraintParameters, $constraintTypeItemId ) {
-		$this->checkError( $constraintParameters );
-		$relationId = $this->config->get( 'WBQualityConstraintsRelationId' );
-		if ( !array_key_exists( $relationId, $constraintParameters ) ) {
+	public function parseRelationParameter(array $constraintParameters, $constraintTypeItemId) {
+		$this->checkError($constraintParameters);
+		$relationId = $this->config->get('WBQualityConstraintsRelationId');
+		if (!array_key_exists($relationId, $constraintParameters)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-needed' )
-					->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $relationId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-needed')
+					->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM))
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($relationId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
 
-		$this->requireSingleParameter( $constraintParameters, $relationId );
-		$relationEntityId = $this->parseEntityIdParameter( $constraintParameters[$relationId][0], $relationId );
-		$instanceId = $this->config->get( 'WBQualityConstraintsInstanceOfRelationId' );
-		$subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfRelationId' );
-		$instanceOrSubclassId = $this->config->get( 'WBQualityConstraintsInstanceOrSubclassOfRelationId' );
-		switch ( $relationEntityId ) {
+		$this->requireSingleParameter($constraintParameters, $relationId);
+		$relationEntityId = $this->parseEntityIdParameter($constraintParameters[$relationId][0], $relationId);
+		$instanceId = $this->config->get('WBQualityConstraintsInstanceOfRelationId');
+		$subclassId = $this->config->get('WBQualityConstraintsSubclassOfRelationId');
+		$instanceOrSubclassId = $this->config->get('WBQualityConstraintsInstanceOrSubclassOfRelationId');
+		switch ($relationEntityId) {
 			case $instanceId:
 				return 'instance';
 			case $subclassId:
@@ -204,13 +204,13 @@ 
 				return 'instanceOrSubclass';
 			default:
 				throw new ConstraintParameterException(
-					wfMessage( 'wbqc-violation-message-parameter-oneof' )
-						->rawParams( $this->constraintParameterRenderer->formatPropertyId( $relationId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
-						->numParams( 3 )
-						->rawParams( $this->constraintParameterRenderer->formatItemIdList(
-							[ $instanceId, $subclassId, $instanceOrSubclassId ],
+					wfMessage('wbqc-violation-message-parameter-oneof')
+						->rawParams($this->constraintParameterRenderer->formatPropertyId($relationId, Role::CONSTRAINT_PARAMETER_PROPERTY))
+						->numParams(3)
+						->rawParams($this->constraintParameterRenderer->formatItemIdList(
+							[$instanceId, $subclassId, $instanceOrSubclassId],
 							Role::CONSTRAINT_PARAMETER_VALUE
-						) )
+						))
 						->escaped()
 				);
 		}
@@ -223,21 +223,21 @@ 
 	 * @throws ConstraintParameterException
 	 * @return PropertyId
 	 */
-	private function parsePropertyIdParameter( array $snakSerialization, $parameterId ) {
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
-		$this->requireValueParameter( $snak, $parameterId );
+	private function parsePropertyIdParameter(array $snakSerialization, $parameterId) {
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
+		$this->requireValueParameter($snak, $parameterId);
 		$value = $snak->getDataValue();
-		if ( $value instanceof EntityIdValue ) {
+		if ($value instanceof EntityIdValue) {
 			$id = $value->getEntityId();
-			if ( $id instanceof PropertyId ) {
+			if ($id instanceof PropertyId) {
 				return $id;
 			}
 		}
 		throw new ConstraintParameterException(
-			wfMessage( 'wbqc-violation-message-parameter-property' )
+			wfMessage('wbqc-violation-message-parameter-property')
 				->rawParams(
-					$this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ),
-					$this->constraintParameterRenderer->formatDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE )
+					$this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY),
+					$this->constraintParameterRenderer->formatDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE)
 				)
 				->escaped()
 		);
@@ -250,34 +250,34 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return PropertyId
 	 */
-	public function parsePropertyParameter( array $constraintParameters, $constraintTypeItemId ) {
-		$this->checkError( $constraintParameters );
-		$propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' );
-		if ( !array_key_exists( $propertyId, $constraintParameters ) ) {
+	public function parsePropertyParameter(array $constraintParameters, $constraintTypeItemId) {
+		$this->checkError($constraintParameters);
+		$propertyId = $this->config->get('WBQualityConstraintsPropertyId');
+		if (!array_key_exists($propertyId, $constraintParameters)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-needed' )
-					->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-needed')
+					->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM))
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
 
-		$this->requireSingleParameter( $constraintParameters, $propertyId );
-		return $this->parsePropertyIdParameter( $constraintParameters[$propertyId][0], $propertyId );
+		$this->requireSingleParameter($constraintParameters, $propertyId);
+		return $this->parsePropertyIdParameter($constraintParameters[$propertyId][0], $propertyId);
 	}
 
-	private function parseItemIdParameter( PropertyValueSnak $snak, $parameterId ) {
+	private function parseItemIdParameter(PropertyValueSnak $snak, $parameterId) {
 		$dataValue = $snak->getDataValue();
-		if ( $dataValue instanceof EntityIdValue &&
+		if ($dataValue instanceof EntityIdValue &&
 			$dataValue->getEntityId() instanceof ItemId
 		) {
-			return ItemIdSnakValue::fromItemId( $dataValue->getEntityId() );
+			return ItemIdSnakValue::fromItemId($dataValue->getEntityId());
 		} else {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-item' )
+				wfMessage('wbqc-violation-message-parameter-item')
 					->rawParams(
-						$this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ),
-						$this->constraintParameterRenderer->formatDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE )
+						$this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY),
+						$this->constraintParameterRenderer->formatDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE)
 					)
 					->escaped()
 			);
@@ -291,15 +291,15 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return ItemIdSnakValue[] array of values
 	 */
-	public function parseItemsParameter( array $constraintParameters, $constraintTypeItemId, $required ) {
-		$this->checkError( $constraintParameters );
-		$qualifierId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' );
-		if ( !array_key_exists( $qualifierId, $constraintParameters ) ) {
-			if ( $required ) {
+	public function parseItemsParameter(array $constraintParameters, $constraintTypeItemId, $required) {
+		$this->checkError($constraintParameters);
+		$qualifierId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId');
+		if (!array_key_exists($qualifierId, $constraintParameters)) {
+			if ($required) {
 				throw new ConstraintParameterException(
-					wfMessage( 'wbqc-violation-message-parameter-needed' )
-						->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) )
-						->rawParams( $this->constraintParameterRenderer->formatPropertyId( $qualifierId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+					wfMessage('wbqc-violation-message-parameter-needed')
+						->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM))
+						->rawParams($this->constraintParameterRenderer->formatPropertyId($qualifierId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 						->escaped()
 				);
 			} else {
@@ -308,11 +308,11 @@ 
 		}
 
 		$values = [];
-		foreach ( $constraintParameters[$qualifierId] as $parameter ) {
-			$snak = $this->snakDeserializer->deserialize( $parameter );
-			switch ( true ) {
+		foreach ($constraintParameters[$qualifierId] as $parameter) {
+			$snak = $this->snakDeserializer->deserialize($parameter);
+			switch (true) {
 				case $snak instanceof PropertyValueSnak:
-					$values[] = $this->parseItemIdParameter( $snak, $qualifierId );
+					$values[] = $this->parseItemIdParameter($snak, $qualifierId);
 					break;
 				case $snak instanceof PropertySomeValueSnak:
 					$values[] = ItemIdSnakValue::someValue();
@@ -331,28 +331,28 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return PropertyId[]
 	 */
-	public function parsePropertiesParameter( array $constraintParameters, $constraintTypeItemId ) {
-		$this->checkError( $constraintParameters );
-		$propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' );
-		if ( !array_key_exists( $propertyId, $constraintParameters ) ) {
+	public function parsePropertiesParameter(array $constraintParameters, $constraintTypeItemId) {
+		$this->checkError($constraintParameters);
+		$propertyId = $this->config->get('WBQualityConstraintsPropertyId');
+		if (!array_key_exists($propertyId, $constraintParameters)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-needed' )
-					->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-needed')
+					->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM))
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
 
 		$parameters = $constraintParameters[$propertyId];
-		if ( count( $parameters ) === 1 &&
-			$this->snakDeserializer->deserialize( $parameters[0] ) instanceof PropertyNoValueSnak
+		if (count($parameters) === 1 &&
+			$this->snakDeserializer->deserialize($parameters[0]) instanceof PropertyNoValueSnak
 		) {
 			return [];
 		}
 
 		$properties = [];
-		foreach ( $parameters as $parameter ) {
-			$properties[] = $this->parsePropertyIdParameter( $parameter, $propertyId );
+		foreach ($parameters as $parameter) {
+			$properties[] = $this->parsePropertyIdParameter($parameter, $propertyId);
 		}
 		return $properties;
 	}
@@ -363,16 +363,16 @@ 
 	 * @throws ConstraintParameterException
 	 * @return DataValue|null
 	 */
-	private function parseValueOrNoValueParameter( array $snakSerialization, $parameterId ) {
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
-		if ( $snak instanceof PropertyValueSnak ) {
+	private function parseValueOrNoValueParameter(array $snakSerialization, $parameterId) {
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
+		if ($snak instanceof PropertyValueSnak) {
 			return $snak->getDataValue();
-		} elseif ( $snak instanceof PropertyNoValueSnak ) {
+		} elseif ($snak instanceof PropertyNoValueSnak) {
 			return null;
 		} else {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-value-or-novalue' )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-value-or-novalue')
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
@@ -383,13 +383,13 @@ 
 	 * @param string $parameterId
 	 * @return DataValue|null
 	 */
-	private function parseValueOrNoValueOrNowParameter( array $snakSerialization, $parameterId ) {
+	private function parseValueOrNoValueOrNowParameter(array $snakSerialization, $parameterId) {
 		try {
-			return $this->parseValueOrNoValueParameter( $snakSerialization, $parameterId );
-		} catch ( ConstraintParameterException $e ) {
+			return $this->parseValueOrNoValueParameter($snakSerialization, $parameterId);
+		} catch (ConstraintParameterException $e) {
 			// unknown value means “now”
-			$timeParser = ( new TimeParserFactory() )->getTimeParser();
-			return $timeParser->parse( gmdate( '+Y-m-d\T00:00:00\Z' ) );
+			$timeParser = (new TimeParserFactory())->getTimeParser();
+			return $timeParser->parse(gmdate('+Y-m-d\T00:00:00\Z'));
 		}
 	}
 
@@ -400,14 +400,14 @@ 
 	 * @param string $unit
 	 * @return bool
 	 */
-	private function exactlyOneQuantityWithUnit( DataValue $min = null, DataValue $max = null, $unit ) {
-		if ( !( $min instanceof UnboundedQuantityValue ) ||
-			!( $max instanceof UnboundedQuantityValue )
+	private function exactlyOneQuantityWithUnit(DataValue $min = null, DataValue $max = null, $unit) {
+		if (!($min instanceof UnboundedQuantityValue) ||
+			!($max instanceof UnboundedQuantityValue)
 		) {
 			return false;
 		}
 
-		return ( $min->getUnit() === $unit ) !== ( $max->getUnit() === $unit );
+		return ($min->getUnit() === $unit) !== ($max->getUnit() === $unit);
 	}
 
 	/**
@@ -418,9 +418,9 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
 	 */
-	public function parseRangeParameter( array $constraintParameters, $constraintTypeItemId, $type ) {
-		$this->checkError( $constraintParameters );
-		switch ( $type ) {
+	public function parseRangeParameter(array $constraintParameters, $constraintTypeItemId, $type) {
+		$this->checkError($constraintParameters);
+		switch ($type) {
 			case 'quantity':
 				$configKey = 'Quantity';
 				break;
@@ -429,47 +429,47 @@ 
 				break;
 			default:
 				throw new ConstraintParameterException(
-					wfMessage( 'wbqc-violation-message-value-needed-of-types-2' )
+					wfMessage('wbqc-violation-message-value-needed-of-types-2')
 						->rawParams(
-							$this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ),
-							wfMessage( 'datatypes-type-quantity' )->escaped(),
-							wfMessage( 'datatypes-type-time' )->escaped()
+							$this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM),
+							wfMessage('datatypes-type-quantity')->escaped(),
+							wfMessage('datatypes-type-time')->escaped()
 						)
 						->escaped()
 				);
 		}
-		$minimumId = $this->config->get( 'WBQualityConstraintsMinimum' . $configKey . 'Id' );
-		$maximumId = $this->config->get( 'WBQualityConstraintsMaximum' . $configKey . 'Id' );
-		if ( !array_key_exists( $minimumId, $constraintParameters ) ||
-			!array_key_exists( $maximumId, $constraintParameters )
+		$minimumId = $this->config->get('WBQualityConstraintsMinimum'.$configKey.'Id');
+		$maximumId = $this->config->get('WBQualityConstraintsMaximum'.$configKey.'Id');
+		if (!array_key_exists($minimumId, $constraintParameters) ||
+			!array_key_exists($maximumId, $constraintParameters)
 		) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-range-parameters-needed' )
+				wfMessage('wbqc-violation-message-range-parameters-needed')
 					->rawParams(
-						wfMessage( 'datatypes-type-' . $type )->escaped(),
-						$this->constraintParameterRenderer->formatPropertyId( $minimumId, Role::CONSTRAINT_PARAMETER_PROPERTY ),
-						$this->constraintParameterRenderer->formatPropertyId( $maximumId, Role::CONSTRAINT_PARAMETER_PROPERTY )
+						wfMessage('datatypes-type-'.$type)->escaped(),
+						$this->constraintParameterRenderer->formatPropertyId($minimumId, Role::CONSTRAINT_PARAMETER_PROPERTY),
+						$this->constraintParameterRenderer->formatPropertyId($maximumId, Role::CONSTRAINT_PARAMETER_PROPERTY)
 					)
-					->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) )
+					->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM))
 					->escaped()
 			);
 		}
 
-		$this->requireSingleParameter( $constraintParameters, $minimumId );
-		$this->requireSingleParameter( $constraintParameters, $maximumId );
+		$this->requireSingleParameter($constraintParameters, $minimumId);
+		$this->requireSingleParameter($constraintParameters, $maximumId);
 		$parseFunction = $configKey === 'Date' ? 'parseValueOrNoValueOrNowParameter' : 'parseValueOrNoValueParameter';
-		$min = $this->$parseFunction( $constraintParameters[$minimumId][0], $minimumId );
-		$max = $this->$parseFunction( $constraintParameters[$maximumId][0], $maximumId );
+		$min = $this->$parseFunction($constraintParameters[$minimumId][0], $minimumId);
+		$max = $this->$parseFunction($constraintParameters[$maximumId][0], $maximumId);
 
-		$yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' );
-		if ( $this->exactlyOneQuantityWithUnit( $min, $max, $yearUnit ) ) {
+		$yearUnit = $this->config->get('WBQualityConstraintsYearUnit');
+		if ($this->exactlyOneQuantityWithUnit($min, $max, $yearUnit)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-range-parameters-one-year' )
+				wfMessage('wbqc-violation-message-range-parameters-one-year')
 					->escaped()
 			);
 		}
 
-		return [ $min, $max ];
+		return [$min, $max];
 	}
 
 	/**
@@ -479,18 +479,18 @@ 
 	 * @throws ConstraintParameterException
 	 * @return string
 	 */
-	private function parseStringParameter( array $snakSerialization, $parameterId ) {
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
-		$this->requireValueParameter( $snak, $parameterId );
+	private function parseStringParameter(array $snakSerialization, $parameterId) {
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
+		$this->requireValueParameter($snak, $parameterId);
 		$value = $snak->getDataValue();
-		if ( $value instanceof StringValue ) {
+		if ($value instanceof StringValue) {
 			return $value->getValue();
 		} else {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-string' )
+				wfMessage('wbqc-violation-message-parameter-string')
 					->rawParams(
-						$this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ),
-						$this->constraintParameterRenderer->formatDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE )
+						$this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY),
+						$this->constraintParameterRenderer->formatDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE)
 					)
 					->escaped()
 			);
@@ -503,15 +503,15 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return string
 	 */
-	public function parseNamespaceParameter( array $constraintParameters, $constraintTypeItemId ) {
-		$this->checkError( $constraintParameters );
-		$namespaceId = $this->config->get( 'WBQualityConstraintsNamespaceId' );
-		if ( !array_key_exists( $namespaceId, $constraintParameters ) ) {
+	public function parseNamespaceParameter(array $constraintParameters, $constraintTypeItemId) {
+		$this->checkError($constraintParameters);
+		$namespaceId = $this->config->get('WBQualityConstraintsNamespaceId');
+		if (!array_key_exists($namespaceId, $constraintParameters)) {
 			return '';
 		}
 
-		$this->requireSingleParameter( $constraintParameters, $namespaceId );
-		return $this->parseStringParameter( $constraintParameters[$namespaceId][0], $namespaceId );
+		$this->requireSingleParameter($constraintParameters, $namespaceId);
+		return $this->parseStringParameter($constraintParameters[$namespaceId][0], $namespaceId);
 	}
 
 	/**
@@ -520,20 +520,20 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
 	 * @return string
 	 */
-	public function parseFormatParameter( array $constraintParameters, $constraintTypeItemId ) {
-		$this->checkError( $constraintParameters );
-		$formatId = $this->config->get( 'WBQualityConstraintsFormatAsARegularExpressionId' );
-		if ( !array_key_exists( $formatId, $constraintParameters ) ) {
+	public function parseFormatParameter(array $constraintParameters, $constraintTypeItemId) {
+		$this->checkError($constraintParameters);
+		$formatId = $this->config->get('WBQualityConstraintsFormatAsARegularExpressionId');
+		if (!array_key_exists($formatId, $constraintParameters)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-needed' )
-					->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $formatId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
+				wfMessage('wbqc-violation-message-parameter-needed')
+					->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM))
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($formatId, Role::CONSTRAINT_PARAMETER_PROPERTY))
 					->escaped()
 			);
 		}
 
-		$this->requireSingleParameter( $constraintParameters, $formatId );
-		return $this->parseStringParameter( $constraintParameters[$formatId][0], $formatId );
+		$this->requireSingleParameter($constraintParameters, $formatId);
+		return $this->parseStringParameter($constraintParameters[$formatId][0], $formatId);
 	}
 
 	/**
@@ -541,16 +541,16 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid
 	 * @return EntityId[]
 	 */
-	public function parseExceptionParameter( array $constraintParameters ) {
-		$this->checkError( $constraintParameters );
-		$exceptionId = $this->config->get( 'WBQualityConstraintsExceptionToConstraintId' );
-		if ( !array_key_exists( $exceptionId, $constraintParameters ) ) {
+	public function parseExceptionParameter(array $constraintParameters) {
+		$this->checkError($constraintParameters);
+		$exceptionId = $this->config->get('WBQualityConstraintsExceptionToConstraintId');
+		if (!array_key_exists($exceptionId, $constraintParameters)) {
 			return [];
 		}
 
 		return array_map(
-			function( $snakSerialization ) use ( $exceptionId ) {
-				return $this->parseEntityIdParameter( $snakSerialization, $exceptionId );
+			function($snakSerialization) use ($exceptionId) {
+				return $this->parseEntityIdParameter($snakSerialization, $exceptionId);
 			},
 			$constraintParameters[$exceptionId]
 		);
@@ -561,27 +561,27 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid
 	 * @return string|null 'mandatory' or null
 	 */
-	public function parseConstraintStatusParameter( array $constraintParameters ) {
-		$this->checkError( $constraintParameters );
-		$constraintStatusId = $this->config->get( 'WBQualityConstraintsConstraintStatusId' );
-		if ( !array_key_exists( $constraintStatusId, $constraintParameters ) ) {
+	public function parseConstraintStatusParameter(array $constraintParameters) {
+		$this->checkError($constraintParameters);
+		$constraintStatusId = $this->config->get('WBQualityConstraintsConstraintStatusId');
+		if (!array_key_exists($constraintStatusId, $constraintParameters)) {
 			return null;
 		}
 
-		$mandatoryId = $this->config->get( 'WBQualityConstraintsMandatoryConstraintId' );
-		$this->requireSingleParameter( $constraintParameters, $constraintStatusId );
-		$snak = $this->snakDeserializer->deserialize( $constraintParameters[$constraintStatusId][0] );
-		$this->requireValueParameter( $snak, $constraintStatusId );
+		$mandatoryId = $this->config->get('WBQualityConstraintsMandatoryConstraintId');
+		$this->requireSingleParameter($constraintParameters, $constraintStatusId);
+		$snak = $this->snakDeserializer->deserialize($constraintParameters[$constraintStatusId][0]);
+		$this->requireValueParameter($snak, $constraintStatusId);
 		$statusId = $snak->getDataValue()->getEntityId()->getSerialization();
 
-		if ( $statusId === $mandatoryId ) {
+		if ($statusId === $mandatoryId) {
 			return 'mandatory';
 		} else {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-oneof' )
-					->rawParams( $this->constraintParameterRenderer->formatPropertyId( $constraintStatusId, Role::CONSTRAINT_PARAMETER_PROPERTY ) )
-					->numParams( 1 )
-					->rawParams( $this->constraintParameterRenderer->formatItemIdList( [ $mandatoryId ], Role::CONSTRAINT_PARAMETER_VALUE ) )
+				wfMessage('wbqc-violation-message-parameter-oneof')
+					->rawParams($this->constraintParameterRenderer->formatPropertyId($constraintStatusId, Role::CONSTRAINT_PARAMETER_PROPERTY))
+					->numParams(1)
+					->rawParams($this->constraintParameterRenderer->formatItemIdList([$mandatoryId], Role::CONSTRAINT_PARAMETER_VALUE))
 					->escaped()
 			);
 		}
@@ -594,13 +594,13 @@ 
 	 * @return void
 	 * @throws ConstraintParameterException
 	 */
-	private function requireMonolingualTextParameter( DataValue $dataValue, $parameterId ) {
-		if ( !( $dataValue instanceof MonolingualTextValue ) ) {
+	private function requireMonolingualTextParameter(DataValue $dataValue, $parameterId) {
+		if (!($dataValue instanceof MonolingualTextValue)) {
 			throw new ConstraintParameterException(
-				wfMessage( 'wbqc-violation-message-parameter-monolingualtext' )
+				wfMessage('wbqc-violation-message-parameter-monolingualtext')
 					->rawParams(
-						$this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ),
-						$this->constraintParameterRenderer->formatDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE )
+						$this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY),
+						$this->constraintParameterRenderer->formatDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE)
 					)
 					->escaped()
 			);
@@ -615,26 +615,26 @@ 
 	 * @throws ConstraintParameterException if invalid snaks are found or a language has multiple texts
 	 * @return string[]
 	 */
-	private function parseMultilingualTextParameter( array $snakSerializations, $parameterId ) {
+	private function parseMultilingualTextParameter(array $snakSerializations, $parameterId) {
 		$result = [];
 
-		foreach ( $snakSerializations as $snakSerialization ) {
-			$snak = $this->snakDeserializer->deserialize( $snakSerialization );
-			$this->requireValueParameter( $snak, $parameterId );
+		foreach ($snakSerializations as $snakSerialization) {
+			$snak = $this->snakDeserializer->deserialize($snakSerialization);
+			$this->requireValueParameter($snak, $parameterId);
 
 			$value = $snak->getDataValue();
-			$this->requireMonolingualTextParameter( $value, $parameterId );
+			$this->requireMonolingualTextParameter($value, $parameterId);
 			/** @var MonolingualTextValue $value */
 
 			$code = $value->getLanguageCode();
-			if ( array_key_exists( $code, $result ) ) {
+			if (array_key_exists($code, $result)) {
 				throw new ConstraintParameterException(
-					wfMessage( 'wbqc-violation-message-parameter-single-per-language' )
+					wfMessage('wbqc-violation-message-parameter-single-per-language')
 						->rawParams(
-							$this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY )
+							$this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY)
 						)
 						->plaintextParams(
-							Language::fetchLanguageName( $code ),
+							Language::fetchLanguageName($code),
 							$code
 						)
 						->escaped()
@@ -653,23 +653,23 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid
 	 * @return string|null
 	 */
-	public function parseSyntaxClarificationParameter( array $constraintParameters, Language $language ) {
-		$syntaxClarificationId = $this->config->get( 'WBQualityConstraintsSyntaxClarificationId' );
+	public function parseSyntaxClarificationParameter(array $constraintParameters, Language $language) {
+		$syntaxClarificationId = $this->config->get('WBQualityConstraintsSyntaxClarificationId');
 
-		if ( !array_key_exists( $syntaxClarificationId, $constraintParameters ) ) {
+		if (!array_key_exists($syntaxClarificationId, $constraintParameters)) {
 			return null;
 		}
 
 		$languageCodes = $language->getFallbackLanguages();
-		array_unshift( $languageCodes, $language->getCode() );
+		array_unshift($languageCodes, $language->getCode());
 
 		$syntaxClarifications = $this->parseMultilingualTextParameter(
 			$constraintParameters[$syntaxClarificationId],
 			$syntaxClarificationId
 		);
 
-		foreach ( $languageCodes as $languageCode ) {
-			if ( array_key_exists( $languageCode, $syntaxClarifications ) ) {
+		foreach ($languageCodes as $languageCode) {
+			if (array_key_exists($languageCode, $syntaxClarifications)) {
 				return $syntaxClarifications[$languageCode];
 			}
 		}
@@ -685,20 +685,20 @@ 
 	 * @throws ConstraintParameterException if the parameter is invalid
 	 * @return string[]|null Context::TYPE_* constants
 	 */
-	public function parseConstraintScopeParameter( array $constraintParameters, $constraintTypeItemId, array $validScopes = null ) {
-		$constraintScopeId = $this->config->get( 'WBQualityConstraintsConstraintScopeId' );
-		$mainSnakId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnMainValueId' );
-		$qualifiersId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnQualifiersId' );
-		$referencesId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnReferencesId' );
+	public function parseConstraintScopeParameter(array $constraintParameters, $constraintTypeItemId, array $validScopes = null) {
+		$constraintScopeId = $this->config->get('WBQualityConstraintsConstraintScopeId');
+		$mainSnakId = $this->config->get('WBQualityConstraintsConstraintCheckedOnMainValueId');
+		$qualifiersId = $this->config->get('WBQualityConstraintsConstraintCheckedOnQualifiersId');
+		$referencesId = $this->config->get('WBQualityConstraintsConstraintCheckedOnReferencesId');
 
-		if ( !array_key_exists( $constraintScopeId, $constraintParameters ) ) {
+		if (!array_key_exists($constraintScopeId, $constraintParameters)) {
 			return null;
 		}
 
 		$contextTypes = [];
-		foreach ( $constraintParameters[$constraintScopeId] as $snakSerialization ) {
-			$scopeEntityId = $this->parseEntityIdParameter( $snakSerialization, $constraintScopeId );
-			switch ( $scopeEntityId->getSerialization() ) {
+		foreach ($constraintParameters[$constraintScopeId] as $snakSerialization) {
+			$scopeEntityId = $this->parseEntityIdParameter($snakSerialization, $constraintScopeId);
+			switch ($scopeEntityId->getSerialization()) {
 				case $mainSnakId:
 					$contextTypes[] = Context::TYPE_STATEMENT;
 					break;
@@ -710,14 +710,14 @@ 
 					break;
 				default:
 					throw new ConstraintParameterException(
-						wfMessage( 'wbqc-violation-message-parameter-oneof' )
+						wfMessage('wbqc-violation-message-parameter-oneof')
 							->rawParams(
 								$this->constraintParameterRenderer->formatPropertyId(
 									$constraintScopeId,
 									Role::CONSTRAINT_PARAMETER_PROPERTY
 								)
 							)
-							->numParams( 3 )
+							->numParams(3)
 							->rawParams(
 								$this->constraintParameterRenderer->formatItemIdList(
 									[
@@ -733,12 +733,12 @@ 
 			}
 		}
 
-		if ( $validScopes !== null ) {
-			$invalidScopes = array_diff( $contextTypes, $validScopes );
-			if ( $invalidScopes !== [] ) {
-				$invalidScope = array_pop( $invalidScopes );
+		if ($validScopes !== null) {
+			$invalidScopes = array_diff($contextTypes, $validScopes);
+			if ($invalidScopes !== []) {
+				$invalidScope = array_pop($invalidScopes);
 				throw new ConstraintParameterException(
-					wfMessage( 'wbqc-violation-message-invalid-scope' )
+					wfMessage('wbqc-violation-message-invalid-scope')
 						->rawParams(
 							$this->constraintParameterRenderer->formatConstraintScope(
 								$invalidScope,
@@ -749,7 +749,7 @@ 
 								Role::CONSTRAINT_TYPE_ITEM
 							)
 						)
-						->numParams( count( $validScopes ) )
+						->numParams(count($validScopes))
 						->rawParams(
 							$this->constraintParameterRenderer->formatConstraintScopeList(
 								$validScopes,

src/Api/CheckingResultsBuilder.php

Spacing +30 added lines, -31 removed lines

@@ -83,55 +83,54 @@ 
 	) {
 		$response = [];
 		$metadatas = [];
-		$statusesFlipped = array_flip( $statuses );
-		foreach ( $entityIds as $entityId ) {
+		$statusesFlipped = array_flip($statuses);
+		foreach ($entityIds as $entityId) {
 			$results = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId(
 				$entityId,
 				$constraintIds,
-				[ $this, 'defaultResults' ]
+				[$this, 'defaultResults']
 			);
 			/** @var CheckResult[] $results */
-			$results = array_filter( $results, $this->statusSelected( $statusesFlipped ) );
-			foreach ( $results as $result ) {
+			$results = array_filter($results, $this->statusSelected($statusesFlipped));
+			foreach ($results as $result) {
 				$metadatas[] = $result->getMetadata();
-				$resultArray = $this->checkResultToArray( $result );
-				$result->getContext()->storeCheckResultInArray( $resultArray, $response );
+				$resultArray = $this->checkResultToArray($result);
+				$result->getContext()->storeCheckResultInArray($resultArray, $response);
 			}
 		}
-		foreach ( $claimIds as $claimId ) {
+		foreach ($claimIds as $claimId) {
 			$results = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId(
 				$claimId,
 				$constraintIds,
-				[ $this, 'defaultResults' ]
+				[$this, 'defaultResults']
 			);
-			$results = array_filter( $results, $this->statusSelected( $statusesFlipped ) );
-			foreach ( $results as $result ) {
+			$results = array_filter($results, $this->statusSelected($statusesFlipped));
+			foreach ($results as $result) {
 				$metadatas[] = $result->getMetadata();
-				$resultArray = $this->checkResultToArray( $result );
-				$result->getContext()->storeCheckResultInArray( $resultArray, $response );
+				$resultArray = $this->checkResultToArray($result);
+				$result->getContext()->storeCheckResultInArray($resultArray, $response);
 			}
 		}
 		return new CachedCheckConstraintsResponse(
 			$response,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	public function defaultResults( Context $context ) {
+	public function defaultResults(Context $context) {
 		return $context->getType() === Context::TYPE_STATEMENT ?
-			[ new NullResult( $context ) ] :
-			[];
+			[new NullResult($context)] : [];
 	}
 
-	public function statusSelected( array $statusesFlipped ) {
-		return function( CheckResult $result ) use ( $statusesFlipped ) {
-			return array_key_exists( $result->getStatus(), $statusesFlipped ) ||
+	public function statusSelected(array $statusesFlipped) {
+		return function(CheckResult $result) use ($statusesFlipped) {
+			return array_key_exists($result->getStatus(), $statusesFlipped) ||
 				$result instanceof NullResult;
 		};
 	}
 
-	public function checkResultToArray( CheckResult $checkResult ) {
-		if ( $checkResult instanceof NullResult ) {
+	public function checkResultToArray(CheckResult $checkResult) {
+		if ($checkResult instanceof NullResult) {
 			return null;
 		}
 
@@ -139,10 +138,10 @@ 
 		$typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId();
 		$constraintPropertyId = $checkResult->getContext()->getSnak()->getPropertyId();
 
-		$title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId );
-		$typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) );
+		$title = $this->entityTitleLookup->getTitleForId($constraintPropertyId);
+		$typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId));
 		// TODO link to the statement when possible (T169224)
-		$link = $title->getFullURL() . '#' . $this->config->get( 'WBQualityConstraintsPropertyConstraintId' );
+		$link = $title->getFullURL().'#'.$this->config->get('WBQualityConstraintsPropertyConstraintId');
 
 		$constraint = [
 			'id' => $constraintId,
@@ -151,11 +150,11 @@ 
 			'link' => $link,
 			'discussLink' => $title->getTalkPage()->getFullURL(),
 		];
-		if ( $this->config->get( 'WBQualityConstraintsIncludeDetailInApi' ) ) {
+		if ($this->config->get('WBQualityConstraintsIncludeDetailInApi')) {
 			$parameters = $checkResult->getParameters();
 			$constraint += [
 				'detail' => $parameters,
-				'detailHTML' => $this->constraintParameterRenderer->formatParameters( $parameters ),
+				'detailHTML' => $this->constraintParameterRenderer->formatParameters($parameters),
 			];
 		}
 
@@ -165,14 +164,14 @@ 
 			'constraint' => $constraint
 		];
 		$message = $checkResult->getMessage();
-		if ( $message ) {
-			$result['message-html'] = $this->violationMessageRenderer->render( $message );
+		if ($message) {
+			$result['message-html'] = $this->violationMessageRenderer->render($message);
 		}
-		if ( $checkResult->getContext()->getType() === Context::TYPE_STATEMENT ) {
+		if ($checkResult->getContext()->getType() === Context::TYPE_STATEMENT) {
 			$result['claim'] = $checkResult->getContext()->getSnakStatement()->getGuid();
 		}
 		$cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray();
-		if ( $cachingMetadataArray !== null ) {
+		if ($cachingMetadataArray !== null) {
 			$result['cached'] = $cachingMetadataArray;
 		}
 

src/Api/CheckConstraints.php

Spacing +43 added lines, -43 removed lines

@@ -77,21 +77,21 @@ 
 	 *
 	 * @return self
 	 */
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$language = $repo->getUserLanguage();
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
 		$valueFormatterFactory = $repo->getValueFormatterFactory();
-		$valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
+		$valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
 
 		$languageFallbackLabelDescriptionLookupFactory = $repo->getLanguageFallbackLabelDescriptionLookupFactory();
-		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup( $language );
+		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup($language);
 		$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
-		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
+		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
 		$entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory();
-		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
+		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
 		$config = MediaWikiServices::getInstance()->getMainConfig();
 		$titleParser = MediaWikiServices::getInstance()->getTitleParser();
 		$unitConverter = $repo->getUnitConverter();
@@ -124,10 +124,10 @@ 
 			$repo->getEntityTitleLookup(),
 			$entityIdLabelFormatter,
 			$constraintParameterRenderer,
-			new ViolationMessageRenderer( $entityIdHtmlLinkFormatter, $valueFormatter ),
+			new ViolationMessageRenderer($entityIdHtmlLinkFormatter, $valueFormatter),
 			$config
 		);
-		if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+		if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 			$wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
 				$repo->getEntityNamespaceLookup()
 			);
@@ -138,12 +138,12 @@ 
 				ResultsCache::getDefaultInstance(),
 				$wikiPageEntityMetaDataAccessor,
 				$entityIdParser,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
+				$config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
 				[
-					$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
-					$config->get( 'WBQualityConstraintsTypeConstraintId' ),
-					$config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
-					$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
+					$config->get('WBQualityConstraintsCommonsLinkConstraintId'),
+					$config->get('WBQualityConstraintsTypeConstraintId'),
+					$config->get('WBQualityConstraintsValueTypeConstraintId'),
+					$config->get('WBQualityConstraintsDistinctValuesConstraintId'),
 				],
 				$dataFactory
 			);
@@ -155,7 +155,7 @@ 
 			$prefix,
 			$repo->getEntityIdParser(),
 			$repo->getStatementGuidValidator(),
-			$repo->getApiHelperFactory( RequestContext::getMain() ),
+			$repo->getApiHelperFactory(RequestContext::getMain()),
 			$resultsBuilder,
 			$dataFactory
 		);
@@ -181,11 +181,11 @@ 
 		ResultsBuilder $resultsBuilder,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( $main, $name, $prefix );
+		parent::__construct($main, $name, $prefix);
 		$this->entityIdParser = $entityIdParser;
 		$this->statementGuidValidator = $statementGuidValidator;
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->resultsBuilder = $resultsBuilder;
 		$this->dataFactory = $dataFactory;
 	}
@@ -200,9 +200,9 @@ 
 
 		$params = $this->extractRequestParams();
 
-		$this->validateParameters( $params );
-		$entityIds = $this->parseEntityIds( $params );
-		$claimIds = $this->parseClaimIds( $params );
+		$this->validateParameters($params);
+		$entityIds = $this->parseEntityIds($params);
+		$claimIds = $this->parseClaimIds($params);
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
 		$statuses = $params[self::PARAM_STATUS];
 
@@ -217,13 +217,13 @@ 
 			)->getArray()
 		);
 		// ensure that result contains the given entity IDs even if they have no statements
-		foreach ( $entityIds as $entityId ) {
+		foreach ($entityIds as $entityId) {
 			$this->getResult()->addArrayType(
-				[ $this->getModuleName(), $entityId->getSerialization() ],
+				[$this->getModuleName(), $entityId->getSerialization()],
 				'assoc'
 			);
 		}
-		$this->resultBuilder->markSuccess( 1 );
+		$this->resultBuilder->markSuccess(1);
 	}
 
 	/**
@@ -231,24 +231,24 @@ 
 	 *
 	 * @return EntityId[]
 	 */
-	private function parseEntityIds( array $params ) {
+	private function parseEntityIds(array $params) {
 		$ids = $params[self::PARAM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		return array_map( function ( $id ) {
+		return array_map(function($id) {
 			try {
-				return $this->entityIdParser->parse( $id );
-			} catch ( EntityIdParsingException $e ) {
+				return $this->entityIdParser->parse($id);
+			} catch (EntityIdParsingException $e) {
 				$this->errorReporter->dieError(
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
 			}
-		}, $ids );
+		}, $ids);
 	}
 
 	/**
@@ -256,35 +256,35 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function parseClaimIds( array $params ) {
+	private function parseClaimIds(array $params) {
 		$ids = $params[self::PARAM_CLAIM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		foreach ( $ids as $id ) {
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
+		foreach ($ids as $id) {
+			if (!$this->statementGuidValidator->validate($id)) {
 				$this->errorReporter->dieError(
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
 			}
 		}
 
 		return $ids;
 	}
 
-	private function validateParameters( array $params ) {
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
+	private function validateParameters(array $params) {
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
 		) {
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
 			$this->errorReporter->dieError(
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
 		}
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
 			$paramId = self::PARAM_ID;
 			$paramClaimId = self::PARAM_CLAIM_ID;
 			$this->errorReporter->dieError(

src/ConstraintCheck/Message/ViolationMessageRenderer.php

Spacing +61 added lines, -61 removed lines

@@ -54,93 +54,93 @@ 
 	 * (temporarily, pre-rendered strings are allowed and returned without changes)
 	 * @return string
 	 */
-	public function render( $violationMessage ) {
-		if ( is_string( $violationMessage ) ) {
+	public function render($violationMessage) {
+		if (is_string($violationMessage)) {
 			// TODO remove this once all checkers produce ViolationMessage objects
 			return $violationMessage;
 		}
-		$message = new Message( $violationMessage->getMessageKey() );
-		foreach ( $violationMessage->getArguments() as $argument ) {
-			$this->renderArgument( $argument, $message );
+		$message = new Message($violationMessage->getMessageKey());
+		foreach ($violationMessage->getArguments() as $argument) {
+			$this->renderArgument($argument, $message);
 		}
 		return $message->escaped();
 	}
 
-	private function addRole( $value, $role ) {
-		if ( $role === null ) {
+	private function addRole($value, $role) {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' .
-			$value .
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'.
+			$value.
 			'</span>';
 	}
 
-	private function renderArgument( array $argument, Message $message ) {
+	private function renderArgument(array $argument, Message $message) {
 		$type = $argument['type'];
 		$value = $argument['value'];
 		$role = $argument['role'];
-		switch ( $type ) {
+		switch ($type) {
 			case ViolationMessage::TYPE_ENTITY_ID:
-				$params = $this->renderEntityId( $value, $role );
+				$params = $this->renderEntityId($value, $role);
 				break;
 			case ViolationMessage::TYPE_ENTITY_ID_LIST:
-				$params = $this->renderEntityIdList( $value, $role );
+				$params = $this->renderEntityIdList($value, $role);
 				break;
 			case ViolationMessage::TYPE_ITEM_ID_SNAK_VALUE:
-				$params = $this->renderItemIdSnakValue( $value, $role );
+				$params = $this->renderItemIdSnakValue($value, $role);
 				break;
 			case ViolationMessage::TYPE_ITEM_ID_SNAK_VALUE_LIST:
-				$params = $this->renderItemIdSnakValueList( $value, $role );
+				$params = $this->renderItemIdSnakValueList($value, $role);
 				break;
 			case ViolationMessage::TYPE_DATA_VALUE:
-				$params = $this->renderDataValue( $value, $role );
+				$params = $this->renderDataValue($value, $role);
 				break;
 			case ViolationMessage::TYPE_DATA_VALUE_TYPE:
-				$params = $this->renderDataValueType( $value, $role );
+				$params = $this->renderDataValueType($value, $role);
 				break;
 			default:
 				throw new InvalidArgumentException(
-					'Unknown ViolationMessage argument type ' . $type . '!'
+					'Unknown ViolationMessage argument type '.$type.'!'
 				);
 		}
-		$message->params( $params );
+		$message->params($params);
 	}
 
-	private function renderList( array $list, $role, callable $render ) {
-		if ( $list === [] ) {
+	private function renderList(array $list, $role, callable $render) {
+		if ($list === []) {
 			return [
-				Message::numParam( 0 ),
-				Message::rawParam( '<ul></ul>' ),
+				Message::numParam(0),
+				Message::rawParam('<ul></ul>'),
 			];
 		}
 
-		if ( count( $list ) > $this->maxListLength ) {
-			$list = array_slice( $list, 0, $this->maxListLength );
+		if (count($list) > $this->maxListLength) {
+			$list = array_slice($list, 0, $this->maxListLength);
 			$truncated = true;
 		}
 
 		$renderedParams = array_map(
 			$render,
 			$list,
-			array_fill( 0, count( $list ), $role )
+			array_fill(0, count($list), $role)
 		);
 		$renderedElements = array_map(
-			function ( $param ) {
+			function($param) {
 				return $param['raw'];
 			},
 			$renderedParams
 		);
-		if ( isset( $truncated ) ) {
-			$renderedElements[] = wfMessage( 'ellipsis' )->escaped();
+		if (isset($truncated)) {
+			$renderedElements[] = wfMessage('ellipsis')->escaped();
 		}
 
 		return array_merge(
 			[
-				Message::numParam( count( $list ) ),
+				Message::numParam(count($list)),
 				Message::rawParam(
-					'<ul><li>' .
-					implode( '</li><li>', $renderedElements ) .
+					'<ul><li>'.
+					implode('</li><li>', $renderedElements).
 					'</li></ul>'
 				),
 			],
@@ -148,35 +148,35 @@ 
 		);
 	}
 
-	private function renderEntityId( EntityId $entityId, $role ) {
-		return Message::rawParam( $this->addRole(
-			$this->entityIdFormatter->formatEntityId( $entityId ),
+	private function renderEntityId(EntityId $entityId, $role) {
+		return Message::rawParam($this->addRole(
+			$this->entityIdFormatter->formatEntityId($entityId),
 			$role
-		) );
+		));
 	}
 
-	private function renderEntityIdList( array $entityIdList, $role ) {
-		return $this->renderList( $entityIdList, $role, [ $this, 'renderEntityId' ] );
+	private function renderEntityIdList(array $entityIdList, $role) {
+		return $this->renderList($entityIdList, $role, [$this, 'renderEntityId']);
 	}
 
-	private function renderItemIdSnakValue( ItemIdSnakValue $value, $role ) {
-		switch ( true ) {
+	private function renderItemIdSnakValue(ItemIdSnakValue $value, $role) {
+		switch (true) {
 			case $value->isValue():
-				return $this->renderEntityId( $value->getItemId(), $role );
+				return $this->renderEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-somevaluesnak">' .
-						wfMessage( 'wikibase-snakview-snaktypeselector-somevalue' )->escaped() .
+				return Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-somevaluesnak">'.
+						wfMessage('wikibase-snakview-snaktypeselector-somevalue')->escaped().
 						'</span>',
 					$role
-				) );
+				));
 			case $value->isNoValue():
-				return Message::rawParam( $this->addRole(
-					'<span class="wikibase-snakview-variation-novaluesnak">' .
-						wfMessage( 'wikibase-snakview-snaktypeselector-novalue' )->escaped() .
+				return Message::rawParam($this->addRole(
+					'<span class="wikibase-snakview-variation-novaluesnak">'.
+						wfMessage('wikibase-snakview-snaktypeselector-novalue')->escaped().
 						'</span>',
 					$role
-				) );
+				));
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
@@ -186,33 +186,33 @@ 
 		}
 	}
 
-	private function renderItemIdSnakValueList( array $valueList, $role ) {
-		return $this->renderList( $valueList, $role, [ $this, 'renderItemIdSnakValue' ] );
+	private function renderItemIdSnakValueList(array $valueList, $role) {
+		return $this->renderList($valueList, $role, [$this, 'renderItemIdSnakValue']);
 	}
 
-	private function renderDataValue( DataValue $dataValue, $role ) {
-		return Message::rawParam( $this->addRole(
-			$this->dataValueFormatter->format( $dataValue ),
+	private function renderDataValue(DataValue $dataValue, $role) {
+		return Message::rawParam($this->addRole(
+			$this->dataValueFormatter->format($dataValue),
 			$role
-		) );
+		));
 	}
 
-	private function renderDataValueType( $dataValueType, $role ) {
+	private function renderDataValueType($dataValueType, $role) {
 		$messageKeys = [
 			'string' => 'datatypes-type-string',
 			'monolingualtext' => 'datatypes-monolingualtext',
 			'wikibase-entityid' => 'wbqc-dataValueType-wikibase-entityid',
 		];
 
-		if ( array_key_exists( $dataValueType, $messageKeys ) ) {
-			return Message::rawParam( $this->addRole(
-				wfMessage( $messageKeys[$dataValueType] )->escaped(),
+		if (array_key_exists($dataValueType, $messageKeys)) {
+			return Message::rawParam($this->addRole(
+				wfMessage($messageKeys[$dataValueType])->escaped(),
 				$role
-			) );
+			));
 		} else {
 			// @codeCoverageIgnoreStart
 			throw new LogicException(
-				'Unknown data value type ' . $dataValueType
+				'Unknown data value type '.$dataValueType
 			);
 			// @codeCoverageIgnoreEnd
 		}

src/ConstraintCheck/Message/ViolationMessage.php

Spacing +21 added lines, -21 removed lines

@@ -79,17 +79,17 @@ 
 	public function __construct(
 		$messageKey
 	) {
-		if ( strpos( $messageKey, self::MESSAGE_KEY_PREFIX ) !== 0 ) {
+		if (strpos($messageKey, self::MESSAGE_KEY_PREFIX) !== 0) {
 			throw new InvalidArgumentException(
-				'ViolationMessage key ⧼' .
-				$messageKey .
-				'⧽ should start with "' .
-				self::MESSAGE_KEY_PREFIX .
+				'ViolationMessage key ⧼'.
+				$messageKey.
+				'⧽ should start with "'.
+				self::MESSAGE_KEY_PREFIX.
 				'".'
 			);
 		}
 
-		$this->messageKeySuffix = substr( $messageKey, strlen( self::MESSAGE_KEY_PREFIX ) );
+		$this->messageKeySuffix = substr($messageKey, strlen(self::MESSAGE_KEY_PREFIX));
 		$this->arguments = [];
 	}
 
@@ -98,7 +98,7 @@ 
 	 * @return string
 	 */
 	public function getMessageKey() {
-		return self::MESSAGE_KEY_PREFIX . $this->messageKeySuffix;
+		return self::MESSAGE_KEY_PREFIX.$this->messageKeySuffix;
 	}
 
 	/**
@@ -116,9 +116,9 @@ 
 	 * @param mixed $value the value, which should match the $type
 	 * @return ViolationMessage
 	 */
-	private function withArgument( $type, $role, $value ) {
+	private function withArgument($type, $role, $value) {
 		$ret = clone $this;
-		$ret->arguments[] = [ 'type' => $type, 'role' => $role, 'value' => $value ];
+		$ret->arguments[] = ['type' => $type, 'role' => $role, 'value' => $value];
 		return $ret;
 	}
 
@@ -130,8 +130,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withEntityId( EntityId $entityId, $role = null ) {
-		return $this->withArgument( self::TYPE_ENTITY_ID, $role, $entityId );
+	public function withEntityId(EntityId $entityId, $role = null) {
+		return $this->withArgument(self::TYPE_ENTITY_ID, $role, $entityId);
 	}
 
 	/**
@@ -148,8 +148,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withEntityIdList( array $entityIdList, $role = null ) {
-		return $this->withArgument( self::TYPE_ENTITY_ID_LIST, $role, $entityIdList );
+	public function withEntityIdList(array $entityIdList, $role = null) {
+		return $this->withArgument(self::TYPE_ENTITY_ID_LIST, $role, $entityIdList);
 	}
 
 	/**
@@ -160,8 +160,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value );
+	public function withItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value);
 	}
 
 	/**
@@ -178,8 +178,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withItemIdSnakValueList( array $valueList, $role = null ) {
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList );
+	public function withItemIdSnakValueList(array $valueList, $role = null) {
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList);
 	}
 
 	/**
@@ -190,8 +190,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withDataValue( DataValue $dataValue, $role = null ) {
-		return $this->withArgument( self::TYPE_DATA_VALUE, $role, $dataValue );
+	public function withDataValue(DataValue $dataValue, $role = null) {
+		return $this->withArgument(self::TYPE_DATA_VALUE, $role, $dataValue);
 	}
 
 	/**
@@ -206,8 +206,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withDataValueType( $dataValueType, $role = null ) {
-		return $this->withArgument( self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType );
+	public function withDataValueType($dataValueType, $role = null) {
+		return $this->withArgument(self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType);
 	}
 
 }

src/ConstraintCheck/Checker/FormatChecker.php

Spacing +30 added lines, -31 removed lines

@@ -95,26 +95,26 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$format = $this->constraintParameterParser->parseFormatParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['pattern'] = [ $format ];
+		$format = $this->constraintParameterParser->parseFormatParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['pattern'] = [$format];
 
 		$syntaxClarification = $this->constraintParameterParser->parseSyntaxClarificationParameter(
 			$constraintParameters,
 			WikibaseRepo::getDefaultInstance()->getUserLanguage() // TODO make this part of the Context?
 		);
-		if ( $syntaxClarification !== null ) {
-			$parameters['clarification'] = [ $syntaxClarification ];
+		if ($syntaxClarification !== null) {
+			$parameters['clarification'] = [$syntaxClarification];
 		}
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -123,7 +123,7 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Format' constraint has to be 'string' or 'monolingualtext'
 		 */
-		switch ( $dataValue->getType() ) {
+		switch ($dataValue->getType()) {
 			case 'string':
 				$text = $dataValue->getValue();
 				break;
@@ -132,56 +132,55 @@ 
 				$text = $dataValue->getText();
 				break;
 			default:
-				$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
-					->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-					->withDataValueType( 'string' )
-					->withDataValueType( 'monolingualtext' );
-				return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+				$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
+					->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+					->withDataValueType('string')
+					->withDataValueType('monolingualtext');
+				return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
-		if ( $this->sparqlHelper !== null && $this->config->get( 'WBQualityConstraintsCheckFormatConstraint' ) ) {
-			if ( $this->sparqlHelper->matchesRegularExpression( $text, $format ) ) {
+		if ($this->sparqlHelper !== null && $this->config->get('WBQualityConstraintsCheckFormatConstraint')) {
+			if ($this->sparqlHelper->matchesRegularExpression($text, $format)) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 			} else {
 				$message = wfMessage(
 					$syntaxClarification !== null ?
-						'wbqc-violation-message-format-clarification' :
-						'wbqc-violation-message-format'
+						'wbqc-violation-message-format-clarification' : 'wbqc-violation-message-format'
 				)->rawParams(
-					$this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ),
-					$this->constraintParameterRenderer->formatDataValue( new StringValue( $text ), Role::OBJECT ),
-					$this->constraintParameterRenderer->formatByRole( Role::CONSTRAINT_PARAMETER_VALUE,
-						'<code><nowiki>' . htmlspecialchars( $format ) . '</nowiki></code>' )
+					$this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY),
+					$this->constraintParameterRenderer->formatDataValue(new StringValue($text), Role::OBJECT),
+					$this->constraintParameterRenderer->formatByRole(Role::CONSTRAINT_PARAMETER_VALUE,
+						'<code><nowiki>'.htmlspecialchars($format).'</nowiki></code>')
 				);
-				if ( $syntaxClarification !== null ) {
-					$message->params( $syntaxClarification );
+				if ($syntaxClarification !== null) {
+					$message->params($syntaxClarification);
 				}
 				$message = $message->escaped();
 				$status = CheckResult::STATUS_VIOLATION;
 			}
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-security-reason' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-security-reason'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$status = CheckResult::STATUS_TODO;
 		}
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseFormatParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseFormatParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
 			$this->constraintParameterParser->parseSyntaxClarificationParameter(
 				$constraintParameters,
-				Language::factory( 'en' ) // errors are reported independent of language requested
+				Language::factory('en') // errors are reported independent of language requested
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/SymmetricChecker.php

Spacing +23 added lines, -23 removed lines

@@ -81,9 +81,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -91,9 +91,9 @@ 
 		$snak = $context->getSnak();
 		$propertyId = $context->getSnak()->getPropertyId();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -102,19 +102,19 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
 		 */
-		if ( $dataValue->getType() !== 'wikibase-entityid' ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if ($dataValue->getType() !== 'wikibase-entityid') {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityIdValue $dataValue */
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( $targetEntity === null ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if ($targetEntity === null) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -122,23 +122,23 @@ 
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $symmetricStatement !== null ) {
+		if ($symmetricStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/DiffWithinRangeChecker.php

Spacing +43 added lines, -44 removed lines

@@ -84,8 +84,8 @@ 
 	 * @throws ConstraintParameterException
 	 * @return array [ DataValue|null $min, DataValue|null $max, PropertyId $property, array $parameters ]
 	 */
-	private function parseConstraintParameters( Constraint $constraint ) {
-		list( $min, $max ) = $this->constraintParameterParser->parseRangeParameter(
+	private function parseConstraintParameters(Constraint $constraint) {
+		list($min, $max) = $this->constraintParameterParser->parseRangeParameter(
 			$constraint->getConstraintParameters(),
 			$constraint->getConstraintTypeItemId(),
 			'quantity'
@@ -95,15 +95,15 @@ 
 			$constraint->getConstraintTypeItemId()
 		);
 
-		if ( $min !== null ) {
-			$parameters['minimum_quantity'] = [ $min ];
+		if ($min !== null) {
+			$parameters['minimum_quantity'] = [$min];
 		}
-		if ( $max !== null ) {
-			$parameters['maximum_quantity'] = [ $max ];
+		if ($max !== null) {
+			$parameters['maximum_quantity'] = [$max];
 		}
-		$parameters['property'] = [ $property ];
+		$parameters['property'] = [$property];
 
-		return [ $min, $max, $property, $parameters ];
+		return [$min, $max, $property, $parameters];
 	}
 
 	/**
@@ -113,13 +113,13 @@ 
 	 *
 	 * @return bool
 	 */
-	private function rangeInYears( $min, $max ) {
-		$yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' );
+	private function rangeInYears($min, $max) {
+		$yearUnit = $this->config->get('WBQualityConstraintsYearUnit');
 
-		if ( $min !== null && $min->getUnit() === $yearUnit ) {
+		if ($min !== null && $min->getUnit() === $yearUnit) {
 			return true;
 		}
-		if ( $max !== null && $max->getUnit() === $yearUnit ) {
+		if ($max !== null && $max->getUnit() === $yearUnit) {
 			return true;
 		}
 
@@ -135,59 +135,58 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$minuend = $snak->getDataValue();
 
 		/** @var PropertyId $property */
-		list( $min, $max, $property, $parameters ) = $this->parseConstraintParameters( $constraint );
+		list($min, $max, $property, $parameters) = $this->parseConstraintParameters($constraint);
 
 		// checks only the first occurrence of the referenced property (this constraint implies a single value constraint on that property)
-		foreach ( $context->getSnakGroup() as $otherSnak ) {
+		foreach ($context->getSnakGroup() as $otherSnak) {
 			if (
-				!$property->equals( $otherSnak->getPropertyId() ) ||
+				!$property->equals($otherSnak->getPropertyId()) ||
 				!$otherSnak instanceof PropertyValueSnak
 			) {
 				continue;
 			}
 
 			$subtrahend = $otherSnak->getDataValue();
-			if ( $subtrahend->getType() === $minuend->getType() ) {
-				$diff = $this->rangeInYears( $min, $max ) ?
-					$this->rangeCheckerHelper->getDifferenceInYears( $minuend, $subtrahend ) :
-					$this->rangeCheckerHelper->getDifference( $minuend, $subtrahend );
+			if ($subtrahend->getType() === $minuend->getType()) {
+				$diff = $this->rangeInYears($min, $max) ?
+					$this->rangeCheckerHelper->getDifferenceInYears($minuend, $subtrahend) : $this->rangeCheckerHelper->getDifference($minuend, $subtrahend);
 
-				if ( $this->rangeCheckerHelper->getComparison( $min, $diff ) > 0 ||
-					$this->rangeCheckerHelper->getComparison( $diff, $max ) > 0
+				if ($this->rangeCheckerHelper->getComparison($min, $diff) > 0 ||
+					$this->rangeCheckerHelper->getComparison($diff, $max) > 0
 				) {
 					// at least one of $min, $max is set at this point, otherwise there could be no violation
-					$openness = $min !== null ? ( $max !== null ? '' : '-rightopen' ) : '-leftopen';
+					$openness = $min !== null ? ($max !== null ? '' : '-rightopen') : '-leftopen';
 					// possible message keys:
 					// wbqc-violation-message-diff-within-range
 					// wbqc-violation-message-diff-within-range-leftopen
 					// wbqc-violation-message-diff-within-range-rightopen
-					$message = ( new ViolationMessage( "wbqc-violation-message-diff-within-range$openness" ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $minuend, Role::OBJECT )
-						->withEntityId( $otherSnak->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $subtrahend, Role::OBJECT );
-					if ( $min !== null ) {
-						$message = $message->withDataValue( $min, Role::OBJECT );
+					$message = (new ViolationMessage("wbqc-violation-message-diff-within-range$openness"))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+						->withDataValue($minuend, Role::OBJECT)
+						->withEntityId($otherSnak->getPropertyId(), Role::PREDICATE)
+						->withDataValue($subtrahend, Role::OBJECT);
+					if ($min !== null) {
+						$message = $message->withDataValue($min, Role::OBJECT);
 					}
-					if ( $max !== null ) {
-						$message = $message->withDataValue( $max, Role::OBJECT );
+					if ($max !== null) {
+						$message = $message->withDataValue($max, Role::OBJECT);
 					}
 					$status = CheckResult::STATUS_VIOLATION;
 				} else {
@@ -195,19 +194,19 @@ 
 					$status = CheckResult::STATUS_COMPLIANCE;
 				}
 			} else {
-				$message = new ViolationMessage( 'wbqc-violation-message-diff-within-range-must-have-equal-types' );
+				$message = new ViolationMessage('wbqc-violation-message-diff-within-range-must-have-equal-types');
 				$status = CheckResult::STATUS_VIOLATION;
 			}
 
-			return new CheckResult( $context, $constraint, $parameters, $status, $message );
+			return new CheckResult($context, $constraint, $parameters, $status, $message);
 		}
 
-		$message = new ViolationMessage( 'wbqc-violation-message-diff-within-range-property-must-exist' );
+		$message = new ViolationMessage('wbqc-violation-message-diff-within-range-property-must-exist');
 		$status = CheckResult::STATUS_VIOLATION;
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
@@ -216,12 +215,12 @@ 
 				$constraint->getConstraintTypeItemId(),
 				'quantity'
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;