wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/NoneOfChecker.php

Spacing +13 added lines, -13 removed lines

@@ -68,15 +68,15 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
 		$parameters['item'] = $items;
 
 		$snak = $context->getSnak();
@@ -84,25 +84,25 @@ 
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-					->withItemIdSnakValueList( $items, Role::OBJECT );
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+					->withItemIdSnakValueList($items, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Helper/LoggingHelper.php

Spacing +20 added lines, -20 removed lines

@@ -46,8 +46,8 @@ 
 		$this->dataFactory = $dataFactory;
 		$this->logger = $logger;
 		$this->constraintCheckDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'),
 		];
 	}
 
@@ -73,39 +73,39 @@ 
 		$durationSeconds,
 		$method
 	) {
-		$constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 );
+		$constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1);
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
 		$this->dataFactory->timing(
-			'wikibase.quality.constraints.check.timing.' .
-				$constraintTypeItemId . '-' .
+			'wikibase.quality.constraints.check.timing.'.
+				$constraintTypeItemId.'-'.
 				$constraintCheckerClassShortName,
 			$durationSeconds * 1000
 		);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		foreach ( $this->constraintCheckDurationLimits as $level => $limit ) {
+		foreach ($this->constraintCheckDurationLimits as $level => $limit) {
 			if (
 				// duration exceeds this limit
-				isset( $limit ) && $durationSeconds > $limit &&
+				isset($limit) && $durationSeconds > $limit &&
 				// this limit is longer than previous longest limit
-				( !isset( $limitSeconds ) || $limit > $limitSeconds )
+				(!isset($limitSeconds) || $limit > $limitSeconds)
 			) {
 				$limitSeconds = $limit;
 				$logLevel = $level;
 			}
 		}
 
-		if ( !isset( $limitSeconds ) ) {
+		if (!isset($limitSeconds)) {
 			return;
 		}
-		if ( $context->getType() !== Context::TYPE_STATEMENT ) {
+		if ($context->getType() !== Context::TYPE_STATEMENT) {
 			// TODO log less details but still log something
 			return;
 		}
 
 		$resultMessage = $result->getMessage();
-		if ( $resultMessage !== null ) {
+		if ($resultMessage !== null) {
 			$resultMessageKey = $resultMessage->getMessageKey();
 		} else {
 			$resultMessageKey = null;
@@ -113,8 +113,8 @@ 
 
 		$this->logger->log(
 			$logLevel,
-			'Constraint check with {constraintCheckerClassShortName} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Constraint check with {constraintCheckerClassShortName} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -141,7 +141,7 @@ 
 	 *
 	 * @param EntityId $entityId
 	 */
-	public function logCheckConstraintsCacheHit( EntityId $entityId ) {
+	public function logCheckConstraintsCacheHit(EntityId $entityId) {
 		$this->dataFactory->increment(
 			'wikibase.quality.constraints.cache.entity.hit'
 		);
@@ -152,10 +152,10 @@ 
 	 *
 	 * @param EntityId[] $entityIds
 	 */
-	public function logCheckConstraintsCacheMisses( array $entityIds ) {
+	public function logCheckConstraintsCacheMisses(array $entityIds) {
 		$this->dataFactory->updateCount(
 			'wikibase.quality.constraints.cache.entity.miss',
-			count( $entityIds )
+			count($entityIds)
 		);
 	}
 
@@ -182,16 +182,16 @@ 
 	 * @param EntityId[] $entityIds
 	 * @param int $maxRevisionIds
 	 */
-	public function logHugeDependencyMetadata( array $entityIds, $maxRevisionIds ) {
+	public function logHugeDependencyMetadata(array $entityIds, $maxRevisionIds) {
 		$this->logger->log(
 			'warning',
-			'Dependency metadata for constraint check result has huge set of entity IDs ' .
-			'(count ' . count( $entityIds ) . ', limit ' . $maxRevisionIds . '); ' .
+			'Dependency metadata for constraint check result has huge set of entity IDs '.
+			'(count '.count($entityIds).', limit '.$maxRevisionIds.'); '.
 			'caching disabled for this check result.',
 			[
 				'loggingMethod' => __METHOD__,
 				'entityIds' => array_map(
-					function ( EntityId $entityId ) {
+					function(EntityId $entityId) {
 						return $entityId->getSerialization();
 					},
 					$entityIds

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +31 added lines, -31 removed lines

@@ -24,9 +24,9 @@ 
 	 */
 	private $statement;
 
-	public function __construct( EntityDocument $entity, Statement $statement ) {
-		Assert::parameterType( StatementListProvider::class, $entity, '$entity' );
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(EntityDocument $entity, Statement $statement) {
+		Assert::parameterType(StatementListProvider::class, $entity, '$entity');
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -43,21 +43,21 @@ 
 		return $this->statement;
 	}
 
-	public function getSnakGroup( $groupingMode, array $separators = [] ) {
+	public function getSnakGroup($groupingMode, array $separators = []) {
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
-		switch ( $groupingMode ) {
+		switch ($groupingMode) {
 			case Context::GROUP_NON_DEPRECATED:
-				$statements = $statements->getByRank( [
+				$statements = $statements->getByRank([
 					Statement::RANK_NORMAL,
 					Statement::RANK_PREFERRED,
-				] );
+				]);
 				break;
 			case Context::GROUP_BEST_RANK:
-				$statements = $this->getBestStatementsPerPropertyId( $statements );
+				$statements = $this->getBestStatementsPerPropertyId($statements);
 				break;
 			default:
-				throw new LogicException( 'Unknown $groupingMode ' . $groupingMode );
+				throw new LogicException('Unknown $groupingMode '.$groupingMode);
 		}
 		return $this->getStatementsWithSameQualifiersForProperties(
 			$this->statement,
@@ -66,13 +66,13 @@ 
 		)->getMainSnaks();
 	}
 
-	private function getBestStatementsPerPropertyId( StatementList $statements ) {
+	private function getBestStatementsPerPropertyId(StatementList $statements) {
 		$allBestStatements = new StatementList();
-		foreach ( $statements->getPropertyIds() as $propertyId ) {
-			$bestStatements = $statements->getByPropertyId( $propertyId )
+		foreach ($statements->getPropertyIds() as $propertyId) {
+			$bestStatements = $statements->getByPropertyId($propertyId)
 				->getBestStatements();
-			foreach ( $bestStatements as $bestStatement ) {
-				$allBestStatements->addStatement( $bestStatement );
+			foreach ($bestStatements as $bestStatement) {
+				$allBestStatements->addStatement($bestStatement);
 			}
 		}
 		return $allBestStatements;
@@ -94,20 +94,20 @@ 
 		array $qualifierPropertyIds
 	) {
 		$similarStatements = new StatementList();
-		foreach ( $allStatements as $statement ) {
-			if ( $statement === $currentStatement ) {
+		foreach ($allStatements as $statement) {
+			if ($statement === $currentStatement) {
 				// if the statement has an “unknown value” qualifier,
 				// it might be considered different from itself,
 				// so add it explicitly to ensure it’s always included
-				$similarStatements->addStatement( $statement );
+				$similarStatements->addStatement($statement);
 				continue;
 			}
-			foreach ( $qualifierPropertyIds as $qualifierPropertyId ) {
-				if ( !$this->haveSameQualifiers( $currentStatement, $statement, $qualifierPropertyId ) ) {
+			foreach ($qualifierPropertyIds as $qualifierPropertyId) {
+				if (!$this->haveSameQualifiers($currentStatement, $statement, $qualifierPropertyId)) {
 					continue 2;
 				}
 			}
-			$similarStatements->addStatement( $statement );
+			$similarStatements->addStatement($statement);
 		}
 		return $similarStatements;
 	}
@@ -121,19 +121,19 @@ 
 	 * @param PropertyId $propertyId
 	 * @return bool
 	 */
-	private function haveSameQualifiers( Statement $s1, Statement $s2, PropertyId $propertyId ) {
-		$q1 = $this->getSnaksWithPropertyId( $s1->getQualifiers(), $propertyId );
-		$q2 = $this->getSnaksWithPropertyId( $s2->getQualifiers(), $propertyId );
+	private function haveSameQualifiers(Statement $s1, Statement $s2, PropertyId $propertyId) {
+		$q1 = $this->getSnaksWithPropertyId($s1->getQualifiers(), $propertyId);
+		$q2 = $this->getSnaksWithPropertyId($s2->getQualifiers(), $propertyId);
 
-		if ( $q1->count() !== $q2->count() ) {
+		if ($q1->count() !== $q2->count()) {
 			return false;
 		}
 
-		foreach ( $q1 as $qualifier ) {
-			switch ( $qualifier->getType() ) {
+		foreach ($q1 as $qualifier) {
+			switch ($qualifier->getType()) {
 				case 'value':
 				case 'novalue':
-					if ( !$q2->hasSnak( $qualifier ) ) {
+					if (!$q2->hasSnak($qualifier)) {
 						return false;
 					}
 					break;
@@ -155,12 +155,12 @@ 
 	 * @param PropertyId $propertyId
 	 * @return SnakList
 	 */
-	private function getSnaksWithPropertyId( SnakList $allSnaks, PropertyId $propertyId ) {
+	private function getSnaksWithPropertyId(SnakList $allSnaks, PropertyId $propertyId) {
 		$snaks = new SnakList();
 		/** @var Snak $snak */
-		foreach ( $allSnaks as $snak ) {
-			if ( $snak->getPropertyId()->equals( $propertyId ) ) {
-				$snaks->addSnak( $snak );
+		foreach ($allSnaks as $snak) {
+			if ($snak->getPropertyId()->equals($propertyId)) {
+				$snaks->addSnak($snak);
 			}
 		}
 		return $snaks;

src/ConstraintCheck/Context/QualifierContext.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -31,9 +31,9 @@ 
 		return self::TYPE_QUALIFIER;
 	}
 
-	public function getSnakGroup( $groupingMode, array $separators = [] ) {
+	public function getSnakGroup($groupingMode, array $separators = []) {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor() {

src/ConstraintCheck/Context/ReferenceContext.php

Spacing +3 added lines, -3 removed lines

@@ -30,7 +30,7 @@ 
 		Reference $reference,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 		$this->reference = $reference;
 	}
@@ -39,9 +39,9 @@ 
 		return self::TYPE_REFERENCE;
 	}
 
-	public function getSnakGroup( $groupingMode, array $separators = [] ) {
+	public function getSnakGroup($groupingMode, array $separators = []) {
 		$snaks = $this->reference->getSnaks();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor() {

src/ConstraintCheck/Context/Context.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
 	 * @return Snak[] not a SnakList because for a statement context,
 	 * the returned value might contain the same snak several times.
 	 */
-	public function getSnakGroup( $groupingMode, array $separators = [] );
+	public function getSnakGroup($groupingMode, array $separators = []);
 
 	/**
 	 * Get the cursor that can be used to address check results for this context.

src/ConstraintCheck/Checker/SingleBestValueChecker.php

Spacing +16 added lines, -16 removed lines

@@ -66,9 +66,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -80,13 +80,13 @@ 
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$bestRankCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ),
+			$context->getSnakGroup(Context::GROUP_BEST_RANK, $separators),
 			$propertyId
 		);
 
-		if ( $bestRankCount > 1 ) {
+		if ($bestRankCount > 1) {
 			$nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount(
-				$context->getSnakGroup( Context::GROUP_NON_DEPRECATED ),
+				$context->getSnakGroup(Context::GROUP_NON_DEPRECATED),
 				$propertyId
 			);
 			$message = $this->getViolationMessage(
@@ -101,15 +101,15 @@ 
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;
@@ -128,23 +128,23 @@ 
 		$separators,
 		$propertyId
 	) {
-		if ( $bestRankCount === $nonDeprecatedCount ) {
-			if ( $separators === [] ) {
+		if ($bestRankCount === $nonDeprecatedCount) {
+			if ($separators === []) {
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred';
 			} else {
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators';
 			}
 		} else {
-			if ( $separators === [] ) {
+			if ($separators === []) {
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred';
 			} else {
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators';
 			}
 		}
 
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $propertyId )
-			->withEntityIdList( $separators );
+		return (new ViolationMessage($messageKey))
+			->withEntityId($propertyId)
+			->withEntityIdList($separators);
 	}
 
 }

src/ConstraintCheck/Checker/SingleValueChecker.php

Spacing +15 added lines, -16 removed lines

@@ -67,9 +67,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -81,19 +81,19 @@ 
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
 			$propertyId
 		);
 
-		if ( $propertyCount > 1 ) {
-			$message = $this->getViolationMessage( $separators, $propertyId );
+		if ($propertyCount > 1) {
+			$message = $this->getViolationMessage($separators, $propertyId);
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
 	/**
@@ -101,22 +101,21 @@ 
 	 * @param PropertyId $propertyId
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
 		$messageKey = $separators === [] ?
-			'wbqc-violation-message-single-value' :
-			'wbqc-violation-message-single-value-separators';
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
 
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $propertyId )
-			->withEntityIdList( $separators );
+		return (new ViolationMessage($messageKey))
+			->withEntityId($propertyId)
+			->withEntityIdList($separators);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/MultiValueChecker.php

Spacing +14 added lines, -15 removed lines

@@ -65,9 +65,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -79,33 +79,32 @@ 
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
 			$propertyId
 		);
 
-		if ( $propertyCount <= 1 ) {
-			$message = ( new ViolationMessage(
+		if ($propertyCount <= 1) {
+			$message = (new ViolationMessage(
 					$separators === [] ?
-						'wbqc-violation-message-multi-value' :
-						'wbqc-violation-message-multi-value-separators'
-				) )
-				->withEntityId( $propertyId )
-				->withEntityIdList( $separators );
+						'wbqc-violation-message-multi-value' : 'wbqc-violation-message-multi-value-separators'
+				))
+				->withEntityId($propertyId)
+				->withEntityIdList($separators);
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;