wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Api/CachingResultsBuilder.php

Spacing +45 added lines, -46 removed lines

@@ -116,11 +116,11 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds ) ) {
+		if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
 					$this->dataFactory->increment(
 						'wikibase.quality.constraints.cache.entity.hit'
 					);
@@ -129,20 +129,20 @@ 
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
+		if ($entityIds !== [] || $claimIds !== []) {
 			$this->dataFactory->updateCount(
 				'wikibase.quality.constraints.cache.entity.miss',
-				count( $entityIds )
+				count($entityIds)
 			);
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds );
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds);
 			$results += $response->getArray();
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckConstraintsResponse(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -175,17 +175,17 @@ 
 		array $claimIds,
 		array $constraintIds = null
 	) {
-		$results = $this->resultsBuilder->getResults( $entityIds, $claimIds, $constraintIds );
+		$results = $this->resultsBuilder->getResults($entityIds, $claimIds, $constraintIds);
 
-		if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds ) ) {
-			foreach ( $entityIds as $entityId ) {
+		if ($this->canStoreResults($entityIds, $claimIds, $constraintIds)) {
+			foreach ($entityIds as $entityId) {
 				$value = [
 					'results' => $results->getArray()[$entityId->getSerialization()],
 					'latestRevisionIds' => $this->getLatestRevisionIds(
 						$results->getMetadata()->getDependencyMetadata()->getEntityIds()
 					),
 				];
-				$this->cache->set( $entityId, $value, $this->ttlInSeconds );
+				$this->cache->set($entityId, $value, $this->ttlInSeconds);
 			}
 		}
 
@@ -218,45 +218,44 @@ 
 	public function getStoredResults(
 		EntityId $entityId
 	) {
-		$value = $this->cache->get( $entityId, $curTTL, [], $asOf );
-		$now = call_user_func( $this->microtime, true );
+		$value = $this->cache->get($entityId, $curTTL, [], $asOf);
+		$now = call_user_func($this->microtime, true);
 
-		if ( $value === false ) {
+		if ($value === false) {
 			return null;
 		}
 
-		$ageInSeconds = (int)ceil( $now - $asOf );
+		$ageInSeconds = (int) ceil($now - $asOf);
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
 		$cachingMetadata = $ageInSeconds > 0 ?
-			CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-			CachingMetadata::fresh();
+			CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh();
 
-		if ( is_array( $value['results'] ) ) {
-			array_walk( $value['results'], [ $this, 'updateCachingMetadata' ], $cachingMetadata );
+		if (is_array($value['results'])) {
+			array_walk($value['results'], [$this, 'updateCachingMetadata'], $cachingMetadata);
 		}
 
 		return new CachedCheckConstraintsResponse(
-			[ $entityId->getSerialization() => $value['results'] ],
+			[$entityId->getSerialization() => $value['results']],
 			array_reduce(
 				$dependedEntityIds,
-				function( Metadata $metadata, EntityId $entityId ) {
-					return Metadata::merge( [
+				function(Metadata $metadata, EntityId $entityId) {
+					return Metadata::merge([
 						$metadata,
 						Metadata::ofDependencyMetadata(
-							DependencyMetadata::ofEntityId( $entityId )
+							DependencyMetadata::ofEntityId($entityId)
 						)
-					] );
+					]);
 				},
-				Metadata::ofCachingMetadata( $cachingMetadata )
+				Metadata::ofCachingMetadata($cachingMetadata)
 			)
 		);
 	}
@@ -265,39 +264,39 @@ 
 	 * @param EntityId[] $entityIds
 	 * @return int[]
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
+	private function getLatestRevisionIds(array $entityIds) {
 		$revisionInformations = $this->wikiPageEntityMetaDataAccessor->loadRevisionInformation(
 			$entityIds,
 			EntityRevisionLookup::LATEST_FROM_REPLICA
 		);
 		$latestRevisionIds = [];
-		foreach ( $revisionInformations as $serialization => $revisionInformation ) {
+		foreach ($revisionInformations as $serialization => $revisionInformation) {
 			$latestRevisionIds[$serialization] = $revisionInformation->page_latest;
 		}
 		return $latestRevisionIds;
 	}
 
-	public function updateCachingMetadata( &$element, $key, CachingMetadata $cachingMetadata ) {
-		if ( $key === 'cached' ) {
-			$element = CachingMetadata::merge( [
+	public function updateCachingMetadata(&$element, $key, CachingMetadata $cachingMetadata) {
+		if ($key === 'cached') {
+			$element = CachingMetadata::merge([
 				$cachingMetadata,
-				CachingMetadata::ofArray( $element ),
-			] )->toArray();
+				CachingMetadata::ofArray($element),
+			])->toArray();
 		}
 		if (
-			is_array( $element ) &&
-			array_key_exists( 'constraint', $element ) &&
-			in_array( $element['constraint']['type'], $this->possiblyStaleConstraintTypes, true )
+			is_array($element) &&
+			array_key_exists('constraint', $element) &&
+			in_array($element['constraint']['type'], $this->possiblyStaleConstraintTypes, true)
 		) {
-			$element['cached'] = CachingMetadata::merge( [
+			$element['cached'] = CachingMetadata::merge([
 				$cachingMetadata,
 				CachingMetadata::ofArray(
-					array_key_exists( 'cached', $element ) ? $element['cached'] : null
+					array_key_exists('cached', $element) ? $element['cached'] : null
 				),
-			] )->toArray();
+			])->toArray();
 		}
-		if ( is_array( $element ) ) {
-			array_walk( $element, [ $this, __FUNCTION__ ], $cachingMetadata );
+		if (is_array($element)) {
+			array_walk($element, [$this, __FUNCTION__], $cachingMetadata);
 		}
 	}
 
@@ -306,7 +305,7 @@ 
 	 *
 	 * @param callable $microtime
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}
 

src/Api/CheckingResultsBuilder.php

Spacing +23 added lines, -24 removed lines

@@ -73,44 +73,43 @@ 
 	) {
 		$response = [];
 		$metadatas = [];
-		foreach ( $entityIds as $entityId ) {
+		foreach ($entityIds as $entityId) {
 			$results = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId(
 				$entityId,
 				$constraintIds,
-				[ $this, 'defaultResults' ]
+				[$this, 'defaultResults']
 			);
-			foreach ( $results as $result ) {
+			foreach ($results as $result) {
 				$metadatas[] = $result->getMetadata();
-				$resultArray = $this->checkResultToArray( $result );
-				$result->getContext()->storeCheckResultInArray( $resultArray, $response );
+				$resultArray = $this->checkResultToArray($result);
+				$result->getContext()->storeCheckResultInArray($resultArray, $response);
 			}
 		}
-		foreach ( $claimIds as $claimId ) {
+		foreach ($claimIds as $claimId) {
 			$results = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId(
 				$claimId,
 				$constraintIds,
-				[ $this, 'defaultResults' ]
+				[$this, 'defaultResults']
 			);
-			foreach ( $results as $result ) {
+			foreach ($results as $result) {
 				$metadatas[] = $result->getMetadata();
-				$resultArray = $this->checkResultToArray( $result );
-				$result->getContext()->storeCheckResultInArray( $resultArray, $response );
+				$resultArray = $this->checkResultToArray($result);
+				$result->getContext()->storeCheckResultInArray($resultArray, $response);
 			}
 		}
 		return new CachedCheckConstraintsResponse(
 			$response,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	public function defaultResults( Context $context ) {
+	public function defaultResults(Context $context) {
 		return $context->getType() === Context::TYPE_STATEMENT ?
-			[ new NullResult( $context ) ] :
-			[];
+			[new NullResult($context)] : [];
 	}
 
-	public function checkResultToArray( CheckResult $checkResult ) {
-		if ( $checkResult instanceof NullResult ) {
+	public function checkResultToArray(CheckResult $checkResult) {
+		if ($checkResult instanceof NullResult) {
 			return null;
 		}
 
@@ -118,10 +117,10 @@ 
 		$typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId();
 		$constraintPropertyId = $checkResult->getContext()->getSnak()->getPropertyId();
 
-		$title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId );
-		$typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) );
+		$title = $this->entityTitleLookup->getTitleForId($constraintPropertyId);
+		$typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId));
 		// TODO link to the statement when possible (T169224)
-		$link = $title->getFullURL() . '#' . $this->config->get( 'WBQualityConstraintsPropertyConstraintId' );
+		$link = $title->getFullURL().'#'.$this->config->get('WBQualityConstraintsPropertyConstraintId');
 
 		$constraint = [
 			'id' => $constraintId,
@@ -130,11 +129,11 @@ 
 			'link' => $link,
 			'discussLink' => $title->getTalkPage()->getFullURL(),
 		];
-		if ( $this->config->get( 'WBQualityConstraintsIncludeDetailInApi' ) ) {
+		if ($this->config->get('WBQualityConstraintsIncludeDetailInApi')) {
 			$parameters = $checkResult->getParameters();
 			$constraint += [
 				'detail' => $parameters,
-				'detailHTML' => $this->constraintParameterRenderer->formatParameters( $parameters ),
+				'detailHTML' => $this->constraintParameterRenderer->formatParameters($parameters),
 			];
 		}
 
@@ -144,14 +143,14 @@ 
 			'constraint' => $constraint
 		];
 		$message = $checkResult->getMessage();
-		if ( $message ) {
+		if ($message) {
 			$result['message-html'] = $message;
 		}
-		if ( $checkResult->getContext()->getType() === Context::TYPE_STATEMENT ) {
+		if ($checkResult->getContext()->getType() === Context::TYPE_STATEMENT) {
 			$result['claim'] = $checkResult->getContext()->getSnakStatement()->getGuid();
 		}
 		$cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray();
-		if ( $cachingMetadataArray !== null ) {
+		if ($cachingMetadataArray !== null) {
 			$result['cached'] = $cachingMetadataArray;
 		}
 

src/ConstraintCheck/Context/Context.php

Spacing +1 added lines, -1 removed lines

@@ -86,6 +86,6 @@
 	 * @param array|null $result
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( array $result = null, array &$container );
+	public function storeCheckResultInArray(array $result = null, array &$container);
 
 }

src/ConstraintCheck/Context/ApiV2Context.php

Spacing +12 added lines, -12 removed lines

@@ -36,29 +36,29 @@ 
 		$propertyId,
 		$statementGuid
 	) {
-		if ( !array_key_exists( $entityId, $container ) ) {
+		if (!array_key_exists($entityId, $container)) {
 			$container[$entityId] = [];
 		}
 		$entityContainer = &$container[$entityId];
 
-		if ( !array_key_exists( 'claims', $entityContainer ) ) {
+		if (!array_key_exists('claims', $entityContainer)) {
 			$entityContainer['claims'] = [];
 		}
 		$claimsContainer = &$entityContainer['claims'];
 
-		if ( !array_key_exists( $propertyId, $claimsContainer ) ) {
+		if (!array_key_exists($propertyId, $claimsContainer)) {
 			$claimsContainer[$propertyId] = [];
 		}
 		$propertyContainer = &$claimsContainer[$propertyId];
 
-		foreach ( $propertyContainer as &$statement ) {
-			if ( $statement['id'] === $statementGuid ) {
+		foreach ($propertyContainer as &$statement) {
+			if ($statement['id'] === $statementGuid) {
 				$statementArray = &$statement;
 				break;
 			}
 		}
-		if ( !isset( $statementArray ) ) {
-			$statementArray = [ 'id' => $statementGuid ];
+		if (!isset($statementArray)) {
+			$statementArray = ['id' => $statementGuid];
 			$propertyContainer[] = &$statementArray;
 		}
 
@@ -73,19 +73,19 @@ 
 	 * @param array[] &$container
 	 * @return array
 	 */
-	abstract protected function &getMainArray( array &$container );
+	abstract protected function &getMainArray(array &$container);
 
 	/**
 	 * @param array|null $result
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( array $result = null, array &$container ) {
-		$mainArray = &$this->getMainArray( $container );
-		if ( !array_key_exists( 'results', $mainArray ) ) {
+	public function storeCheckResultInArray(array $result = null, array &$container) {
+		$mainArray = &$this->getMainArray($container);
+		if (!array_key_exists('results', $mainArray)) {
 			$mainArray['results'] = [];
 		}
 
-		if ( $result !== null ) {
+		if ($result !== null) {
 			$mainArray['results'][] = $result;
 		}
 	}

src/ConstraintCheck/Cache/CachingMetadata.php

Spacing +11 added lines, -12 removed lines

@@ -29,9 +29,9 @@ 
 	 * @param int $maxAge The maximum age of the cached value (in seconds).
 	 * @return self Indication that a value is possibly outdated by up to this many seconds.
 	 */
-	public static function ofMaximumAgeInSeconds( $maxAge ) {
-		Assert::parameterType( 'integer', $maxAge, '$maxAge' );
-		Assert::parameter( $maxAge > 0, '$maxAge', '$maxage > 0' );
+	public static function ofMaximumAgeInSeconds($maxAge) {
+		Assert::parameterType('integer', $maxAge, '$maxAge');
+		Assert::parameter($maxAge > 0, '$maxAge', '$maxage > 0');
 		$ret = new self;
 		$ret->maxAge = $maxAge;
 		return $ret;
@@ -42,9 +42,9 @@ 
 	 * @param array|null $array As returned by toArray.
 	 * @return self
 	 */
-	public static function ofArray( array $array = null ) {
+	public static function ofArray(array $array = null) {
 		$ret = new self;
-		if ( $array !== null ) {
+		if ($array !== null) {
 			$ret->maxAge = $array['maximumAgeInSeconds'];
 		}
 		return $ret;
@@ -54,11 +54,11 @@ 
 	 * @param self[] $metadatas
 	 * @return self
 	 */
-	public static function merge( array $metadatas ) {
-		Assert::parameterElementType( self::class, $metadatas, '$metadatas' );
+	public static function merge(array $metadatas) {
+		Assert::parameterElementType(self::class, $metadatas, '$metadatas');
 		$ret = new self;
-		foreach ( $metadatas as $metadata ) {
-			$ret->maxAge = max( $ret->maxAge, $metadata->maxAge );
+		foreach ($metadatas as $metadata) {
+			$ret->maxAge = max($ret->maxAge, $metadata->maxAge);
 		}
 		return $ret;
 	}
@@ -76,7 +76,7 @@ 
 	 * For a fresh value, returns 0.
 	 */
 	public function getMaximumAgeInSeconds() {
-		if ( is_int( $this->maxAge ) ) {
+		if (is_int($this->maxAge)) {
 			return $this->maxAge;
 		} else {
 			return 0;
@@ -91,8 +91,7 @@ 
 		return $this->isCached() ?
 			[
 				'maximumAgeInSeconds' => $this->maxAge,
-			] :
-			null;
+			] : null;
 	}
 
 }

src/ConstraintCheck/Checker/RangeChecker.php

Spacing +24 added lines, -24 removed lines

@@ -68,9 +68,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -78,42 +78,42 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE, '' );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE, '');
 		}
 
 		$dataValue = $snak->getDataValue();
 
-		list( $min, $max ) = $this->constraintParameterParser->parseRangeParameter(
+		list($min, $max) = $this->constraintParameterParser->parseRangeParameter(
 			$constraintParameters,
 			$constraint->getConstraintTypeItemId(),
 			$dataValue->getType()
 		);
 		$parameterKey = $dataValue->getType() === 'quantity' ? 'quantity' : 'date';
-		if ( $min !== null ) {
-			$parameters['minimum_' . $parameterKey] = [ $min ];
+		if ($min !== null) {
+			$parameters['minimum_'.$parameterKey] = [$min];
 		}
-		if ( $max !== null ) {
-			$parameters['maximum_' . $parameterKey] = [ $max ];
+		if ($max !== null) {
+			$parameters['maximum_'.$parameterKey] = [$max];
 		}
 
-		if ( $this->rangeCheckerHelper->getComparison( $min, $dataValue ) > 0 ||
-			 $this->rangeCheckerHelper->getComparison( $dataValue, $max ) > 0
+		if ($this->rangeCheckerHelper->getComparison($min, $dataValue) > 0 ||
+			 $this->rangeCheckerHelper->getComparison($dataValue, $max) > 0
 		) {
 			// at least one of $min, $max is set at this point, otherwise there could be no violation
 			$type = $dataValue->getType();
-			$openness = $min !== null ? ( $max !== null ? 'closed' : 'rightopen' ) : 'leftopen';
-			$message = wfMessage( "wbqc-violation-message-range-$type-$openness" );
+			$openness = $min !== null ? ($max !== null ? 'closed' : 'rightopen') : 'leftopen';
+			$message = wfMessage("wbqc-violation-message-range-$type-$openness");
 			$message->rawParams(
-				$this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE ),
-				$this->constraintParameterRenderer->formatDataValue( $dataValue, Role::OBJECT )
+				$this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE),
+				$this->constraintParameterRenderer->formatDataValue($dataValue, Role::OBJECT)
 			);
-			if ( $min !== null ) {
-				$message->rawParams( $this->constraintParameterRenderer->formatDataValue( $min, Role::OBJECT ) );
+			if ($min !== null) {
+				$message->rawParams($this->constraintParameterRenderer->formatDataValue($min, Role::OBJECT));
 			}
-			if ( $max !== null ) {
-				$message->rawParams( $this->constraintParameterRenderer->formatDataValue( $max, Role::OBJECT ) );
+			if ($max !== null) {
+				$message->rawParams($this->constraintParameterRenderer->formatDataValue($max, Role::OBJECT));
 			}
 			$message = $message->escaped();
 			$status = CheckResult::STATUS_VIOLATION;
@@ -122,22 +122,22 @@ 
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
 			// we don’t have a data value here, so get the type from the property instead
 			// (the distinction between data type and data value type is irrelevant for 'quantity' and 'time')
-			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty( $constraint->getPropertyId() );
+			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty($constraint->getPropertyId());
 			$this->constraintParameterParser->parseRangeParameter(
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId(),
 				$type
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/CommonsLinkChecker.php

Spacing +42 added lines, -42 removed lines

@@ -60,22 +60,22 @@ 
 	 * @return array first element is the namespace number (default namespace for TitleParser),
 	 * second element is a string to prepend to the title before giving it to the TitleParser
 	 */
-	private function getCommonsNamespace( $namespace ) {
+	private function getCommonsNamespace($namespace) {
 		// for namespace numbers see mediawiki-config repo, wmf-config/InitialiseSettings.php,
 		// 'wgExtraNamespaces' key, 'commonswiki' subkey
-		switch ( $namespace ) {
+		switch ($namespace) {
 			case '':
-				return [ NS_MAIN, '' ];
+				return [NS_MAIN, ''];
 			case 'Creator':
-				return [ 100, '' ];
+				return [100, ''];
 			case 'TimedText':
-				return [ 102, '' ];
+				return [102, ''];
 			case 'Sequence':
-				return [ 104, '' ];
+				return [104, ''];
 			case 'Institution':
-				return [ 106, '' ];
+				return [106, ''];
 			default:
-				return [ NS_MAIN, $namespace . ':' ];
+				return [NS_MAIN, $namespace.':'];
 		}
 	}
 
@@ -88,17 +88,17 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
-		$namespace = $this->constraintParameterParser->parseNamespaceParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['namespace'] = [ $namespace ];
+		$namespace = $this->constraintParameterParser->parseNamespaceParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['namespace'] = [$namespace];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE, '' );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE, '');
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -108,49 +108,49 @@ 
 		 *   type of $dataValue for properties with 'Commons link' constraint has to be 'string'
 		 *   parameter $namespace can be null, works for commons galleries
 		 */
-		if ( $dataValue->getType() !== 'string' ) {
-			$message = wfMessage( "wbqc-violation-message-value-needed-of-type" )
+		if ($dataValue->getType() !== 'string') {
+			$message = wfMessage("wbqc-violation-message-value-needed-of-type")
 					 ->rawParams(
-						 $this->constraintParameterRenderer->formatItemId( $constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM ),
-						 wfMessage( 'datatypes-type-string' )->escaped()
+						 $this->constraintParameterRenderer->formatItemId($constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM),
+						 wfMessage('datatypes-type-string')->escaped()
 					 )
 					 ->escaped();
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$commonsLink = $dataValue->getValue();
 
 		try {
-			if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
-				throw new MalformedTitleException( 'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); // caught below
+			if (!$this->commonsLinkIsWellFormed($commonsLink)) {
+				throw new MalformedTitleException('wbqc-violation-message-commons-link-not-well-formed', $commonsLink); // caught below
 			}
-			list ( $defaultNamespace, $prefix ) = $this->getCommonsNamespace( $namespace );
-			$title = $this->titleParser->parseTitle( $prefix . $commonsLink, $defaultNamespace );
-			if ( $this->pageExists( $title ) ) {
+			list ($defaultNamespace, $prefix) = $this->getCommonsNamespace($namespace);
+			$title = $this->titleParser->parseTitle($prefix.$commonsLink, $defaultNamespace);
+			if ($this->pageExists($title)) {
 				$message = '';
 				$status = CheckResult::STATUS_COMPLIANCE;
 			} else {
-				if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) {
-					throw new MalformedTitleException( 'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); // caught below
+				if ($this->valueIncludesNamespace($commonsLink, $namespace)) {
+					throw new MalformedTitleException('wbqc-violation-message-commons-link-not-well-formed', $commonsLink); // caught below
 				} else {
-					$message = wfMessage( "wbqc-violation-message-commons-link-no-existent" )->escaped();
+					$message = wfMessage("wbqc-violation-message-commons-link-no-existent")->escaped();
 					$status = CheckResult::STATUS_VIOLATION;
 				}
 			}
-		} catch ( MalformedTitleException $e ) {
-			$message = wfMessage( "wbqc-violation-message-commons-link-not-well-formed" )->escaped();
+		} catch (MalformedTitleException $e) {
+			$message = wfMessage("wbqc-violation-message-commons-link-not-well-formed")->escaped();
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseNamespaceParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseNamespaceParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;
@@ -161,19 +161,19 @@ 
 	 *
 	 * @return bool
 	 */
-	private function pageExists( TitleValue $title ) {
+	private function pageExists(TitleValue $title) {
 		$commonsWikiId = 'commonswiki';
-		if ( defined( 'MW_PHPUNIT_TEST' ) ) {
+		if (defined('MW_PHPUNIT_TEST')) {
 			$commonsWikiId = false;
 		}
 
-		$dbLoadBalancer = wfGetLB( $commonsWikiId );
+		$dbLoadBalancer = wfGetLB($commonsWikiId);
 		$dbConnection = $dbLoadBalancer->getConnection(
 			DB_REPLICA, false, $commonsWikiId );
-		$row = $dbConnection->selectRow( 'page', '*', [
+		$row = $dbConnection->selectRow('page', '*', [
 			'page_title' => $title->getDBkey(),
 			'page_namespace' => $title->getNamespace()
-		] );
+		]);
 
 		return $row !== false;
 	}
@@ -183,9 +183,9 @@ 
 	 *
 	 * @return bool
 	 */
-	private function commonsLinkIsWellFormed( $commonsLink ) {
-		$toReplace = [ "_", "%20" ];
-		$compareString = trim( str_replace( $toReplace, '', $commonsLink ) );
+	private function commonsLinkIsWellFormed($commonsLink) {
+		$toReplace = ["_", "%20"];
+		$compareString = trim(str_replace($toReplace, '', $commonsLink));
 		return $commonsLink === $compareString;
 	}
 
@@ -198,9 +198,9 @@ 
 	 *
 	 * @return bool
 	 */
-	private function valueIncludesNamespace( $value, $namespace ) {
+	private function valueIncludesNamespace($value, $namespace) {
 		return $namespace !== '' &&
-			strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0;
+			strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0;
 	}
 
 }

src/ConstraintCheck/Checker/OneOfChecker.php

Spacing +14 added lines, -14 removed lines

@@ -49,43 +49,43 @@
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
 		$parameters['item'] = $items;
 
 		$snak = $context->getSnak();
 
-		$message = wfMessage( 'wbqc-violation-message-one-of' );
-		$message->rawParams( $this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE ) );
-		$message->numParams( count( $items ) );
-		$message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
+		$message = wfMessage('wbqc-violation-message-one-of');
+		$message->rawParams($this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE));
+		$message->numParams(count($items));
+		$message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
 		$message = $message->escaped();
 		$status = CheckResult::STATUS_VIOLATION;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
 				$message = '';
 				$status = CheckResult::STATUS_COMPLIANCE;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php

Spacing +31 added lines, -31 removed lines

@@ -71,25 +71,25 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['property'] = [ $propertyId ];
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['property'] = [$propertyId];
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
 		$parameters['items'] = $items;
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE, '' );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE, '');
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -98,22 +98,22 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
 		 */
-		if ( $dataValue->getType() !== 'wikibase-entityid' ) {
-			$message = wfMessage( "wbqc-violation-message-value-needed-of-type" )
+		if ($dataValue->getType() !== 'wikibase-entityid') {
+			$message = wfMessage("wbqc-violation-message-value-needed-of-type")
 				->rawParams(
-					$this->constraintParameterRenderer->formatItemId( $constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM ),
+					$this->constraintParameterRenderer->formatItemId($constraint->getConstraintTypeItemId(), Role::CONSTRAINT_TYPE_ITEM),
 					'wikibase-entityid' // TODO is there a message for this type so we can localize it?
 				)
 				->escaped();
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityIdValue $dataValue */
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( $targetEntity === null ) {
-			$message = wfMessage( "wbqc-violation-message-target-entity-must-exist" )->escaped();
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if ($targetEntity === null) {
+			$message = wfMessage("wbqc-violation-message-target-entity-must-exist")->escaped();
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/*
@@ -121,7 +121,7 @@ 
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$targetEntity->getStatements(),
 				$propertyId
@@ -134,37 +134,37 @@ 
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = '';
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = wfMessage( 'wbqc-violation-message-target-required-claim' );
+			$message = wfMessage('wbqc-violation-message-target-required-claim');
 			$message->rawParams(
-				$this->constraintParameterRenderer->formatEntityId( $targetEntityId, Role::SUBJECT ),
-				$this->constraintParameterRenderer->formatEntityId( $propertyId, Role::PREDICATE )
+				$this->constraintParameterRenderer->formatEntityId($targetEntityId, Role::SUBJECT),
+				$this->constraintParameterRenderer->formatEntityId($propertyId, Role::PREDICATE)
 			);
-			$message->numParams( count( $items ) );
-			$message->rawParams( $this->constraintParameterRenderer->formatItemIdSnakValueList( $items, Role::OBJECT ) );
+			$message->numParams(count($items));
+			$message->rawParams($this->constraintParameterRenderer->formatItemIdSnakValueList($items, Role::OBJECT));
 			$message = $message->escaped();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;