Inspection of "Merge "Introduce ConstraintChecker::getSupportedEn..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d48b91...d3e045 )

unknown

created 2021-09-01 11:29 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 			$constraintTypeItemId
 		);
 
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
+		if (in_array($context->getType(), $allowedContextTypes)) {
 			return new CheckResult(
 				$context->getCursor(),
 				$constraint,
@@ -76,15 +76,15 @@  discard block
 block discarded – undo
 				$constraint,
 				[],
 				CheckResult::STATUS_VIOLATION,
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
-					->withEntityId( $context->getSnak()->getPropertyId() )
-					->withPropertyScope( $context->getType() )
-					->withPropertyScopeList( $allowedContextTypes )
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
+					->withEntityId($context->getSnak()->getPropertyId())
+					->withPropertyScope($context->getType())
+					->withPropertyScopeList($allowedContextTypes)
 			);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ContemporaryChecker.php 1 patch

Spacing +42 added lines, -43 removed lines patch added patch discarded remove patch

@@ -79,7 +79,7 @@  discard block
 block discarded – undo
 	 * @codeCoverageIgnore This method is purely declarative.
 	 */
 	public function getDefaultContextTypes() {
-		return [ Context::TYPE_STATEMENT ];
+		return [Context::TYPE_STATEMENT];
 	}
 
 	/** @codeCoverageIgnore This method is purely declarative. */
@@ -96,31 +96,31 @@  discard block
 block discarded – undo
 	 * @return CheckResult
 	 * @throws \ConfigException
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 		$snak = $context->getSnak();
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
-		if ( !$dataValue instanceof EntityIdValue ) {
+		if (!$dataValue instanceof EntityIdValue) {
 			// wrong data type
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$objectId = $dataValue->getEntityId();
-		$objectItem = $this->entityLookup->getEntity( $objectId );
-		if ( !( $objectItem instanceof StatementListProvider ) ) {
+		$objectItem = $this->entityLookup->getEntity($objectId);
+		if (!($objectItem instanceof StatementListProvider)) {
 			// object was deleted/doesn't exist
-			$message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var Statement[] $objectStatements */
 		$objectStatements = $objectItem->getStatements()->toArray();
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
 		$subjectId = $context->getEntity()->getId();
 		$subjectStatements = $context->getEntity()->getStatements()->toArray();
 		/** @var String[] $startPropertyIds */
-		$startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
+		$startPropertyIds = $this->config->get(self::CONFIG_VARIABLE_START_PROPERTY_IDS);
 		/** @var String[] $endPropertyIds */
-		$endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );
+		$endPropertyIds = $this->config->get(self::CONFIG_VARIABLE_END_PROPERTY_IDS);
 		$subjectStartValue = $this->getExtremeValue(
 			$startPropertyIds,
 			$subjectStatements,
@@ -152,15 +152,15 @@  discard block
 block discarded – undo
 			'end'
 		);
 		if (
-			$this->rangeCheckerHelper->getComparison( $subjectStartValue, $subjectEndValue ) <= 0 &&
-			$this->rangeCheckerHelper->getComparison( $objectStartValue, $objectEndValue ) <= 0 && (
-				$this->rangeCheckerHelper->getComparison( $subjectEndValue, $objectStartValue ) < 0 ||
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectStartValue ) < 0
+			$this->rangeCheckerHelper->getComparison($subjectStartValue, $subjectEndValue) <= 0 &&
+			$this->rangeCheckerHelper->getComparison($objectStartValue, $objectEndValue) <= 0 && (
+				$this->rangeCheckerHelper->getComparison($subjectEndValue, $objectStartValue) < 0 ||
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectStartValue) < 0
 			)
 		) {
 			if (
 				$subjectEndValue == null ||
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectEndValue ) < 0
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectEndValue) < 0
 			) {
 				$earlierEntityId = $objectId;
 				$minEndValue = $objectEndValue;
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
-		return new CheckResult( $context, $constraint, [], $status, $message );
+		return new CheckResult($context, $constraint, [], $status, $message);
 	}
 
 	/**
@@ -193,19 +193,19 @@  discard block
 block discarded – undo
 	 *
 	 * @return DataValue|null
 	 */
-	private function getExtremeValue( $extremePropertyIds, $statements, $startOrEnd ) {
-		if ( $startOrEnd !== 'start' && $startOrEnd !== 'end' ) {
-			throw new \InvalidArgumentException( '$startOrEnd must be \'start\' or \'end\'.' );
+	private function getExtremeValue($extremePropertyIds, $statements, $startOrEnd) {
+		if ($startOrEnd !== 'start' && $startOrEnd !== 'end') {
+			throw new \InvalidArgumentException('$startOrEnd must be \'start\' or \'end\'.');
 		}
 		$extremeValue = null;
-		foreach ( $extremePropertyIds as $extremePropertyId ) {
-			$statementList = new StatementList( ...$statements );
-			$extremeStatements = $statementList->getByPropertyId( new PropertyId( $extremePropertyId ) );
+		foreach ($extremePropertyIds as $extremePropertyId) {
+			$statementList = new StatementList(...$statements);
+			$extremeStatements = $statementList->getByPropertyId(new PropertyId($extremePropertyId));
 			/** @var Statement $extremeStatement */
-			foreach ( $extremeStatements as $extremeStatement ) {
-				if ( $extremeStatement->getRank() !== Statement::RANK_DEPRECATED ) {
+			foreach ($extremeStatements as $extremeStatement) {
+				if ($extremeStatement->getRank() !== Statement::RANK_DEPRECATED) {
 					$snak = $extremeStatement->getMainSnak();
-					if ( !$snak instanceof PropertyValueSnak ) {
+					if (!$snak instanceof PropertyValueSnak) {
 						return null;
 					} else {
 						$comparison = $this->rangeCheckerHelper->getComparison(
@@ -214,8 +214,8 @@  discard block
 block discarded – undo
 						);
 						if (
 							$extremeValue === null ||
-							( $startOrEnd === 'start' && $comparison < 0 ) ||
-							( $startOrEnd === 'end' && $comparison > 0 )
+							($startOrEnd === 'start' && $comparison < 0) ||
+							($startOrEnd === 'end' && $comparison > 0)
 						) {
 							$extremeValue = $snak->getDataValue();
 						}
@@ -245,17 +245,16 @@  discard block
 block discarded – undo
 		DataValue $maxStartValue
 	) {
 		$messageKey = $earlierEntityId === $subjectId ?
-			'wbqc-violation-message-contemporary-subject-earlier' :
-			'wbqc-violation-message-contemporary-value-earlier';
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $subjectId, Role::SUBJECT )
-			->withEntityId( $propertyId, Role::PREDICATE )
-			->withEntityId( $objectId, Role::OBJECT )
-			->withDataValue( $minEndValue, Role::OBJECT )
-			->withDataValue( $maxStartValue, Role::OBJECT );
+			'wbqc-violation-message-contemporary-subject-earlier' : 'wbqc-violation-message-contemporary-value-earlier';
+		return (new ViolationMessage($messageKey))
+			->withEntityId($subjectId, Role::SUBJECT)
+			->withEntityId($propertyId, Role::PREDICATE)
+			->withEntityId($objectId, Role::OBJECT)
+			->withDataValue($minEndValue, Role::OBJECT)
+			->withDataValue($maxStartValue, Role::OBJECT);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/IntegerChecker.php 1 patch

Spacing +21 added lines, -22 removed lines patch added patch discarded remove patch

@@ -46,23 +46,22 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		}
 
-		$violationMessage = $this->checkSnak( $snak );
+		$violationMessage = $this->checkSnak($snak);
 
 		return new CheckResult(
 			$context,
 			$constraint,
 			[],
 			$violationMessage === null ?
-				CheckResult::STATUS_COMPLIANCE :
-				CheckResult::STATUS_VIOLATION,
+				CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION,
 			$violationMessage
 		);
 	}
@@ -71,23 +70,23 @@  discard block
 block discarded – undo
 	 * @param PropertyValueSnak $snak
 	 * @return ViolationMessage|null
 	 */
-	public function checkSnak( PropertyValueSnak $snak ) {
+	public function checkSnak(PropertyValueSnak $snak) {
 		$dataValue = $snak->getDataValue();
 
-		if ( $dataValue instanceof DecimalValue ) {
-			if ( !$this->isInteger( $dataValue ) ) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
+		if ($dataValue instanceof DecimalValue) {
+			if (!$this->isInteger($dataValue)) {
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
 			}
-		} elseif ( $dataValue instanceof UnboundedQuantityValue ) {
-			if ( !$this->isInteger( $dataValue->getAmount() ) ) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
+		} elseif ($dataValue instanceof UnboundedQuantityValue) {
+			if (!$this->isInteger($dataValue->getAmount())) {
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
 			} elseif (
 				$dataValue instanceof QuantityValue && (
-					!$this->isInteger( $dataValue->getLowerBound() ) ||
-					!$this->isInteger( $dataValue->getUpperBound() )
+					!$this->isInteger($dataValue->getLowerBound()) ||
+					!$this->isInteger($dataValue->getUpperBound())
 				)
 			) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak );
+				return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak);
 			}
 		}
 
@@ -98,7 +97,7 @@  discard block
 block discarded – undo
 	 * @param DecimalValue $decimalValue
 	 * @return bool
 	 */
-	private function isInteger( DecimalValue $decimalValue ) {
+	private function isInteger(DecimalValue $decimalValue) {
 		return $decimalValue->getTrimmed()->getFractionalPart() === '';
 	}
 
@@ -107,13 +106,13 @@  discard block
 block discarded – undo
 	 * @param PropertyValueSnak $snak
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) {
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-			->withDataValue( $snak->getDataValue() );
+	private function getViolationMessage($messageKey, PropertyValueSnak $snak) {
+		return (new ViolationMessage($messageKey))
+			->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+			->withDataValue($snak->getDataValue());
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ReferenceChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -41,16 +41,16 @@
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_REFERENCE ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_REFERENCE) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-reference' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-reference');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/NoBoundsChecker.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -44,17 +44,17 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		}
 
-		if ( $snak->getDataValue() instanceof QuantityValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-noBounds' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+		if ($snak->getDataValue() instanceof QuantityValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-noBounds'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 			return new CheckResult(
 				$context,
 				$constraint,
@@ -64,10 +64,10 @@  discard block
 block discarded – undo
 			);
 		}
 
-		return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/CitationNeededChecker.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 	 * @codeCoverageIgnore This method is purely declarative.
 	 */
 	public function getDefaultContextTypes() {
-		return [ Context::TYPE_STATEMENT ];
+		return [Context::TYPE_STATEMENT];
 	}
 
 	/** @codeCoverageIgnore This method is purely declarative. */
@@ -38,12 +38,12 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$referenceList = $context->getSnakStatement()->getReferences();
 
-		if ( $referenceList->isEmpty() ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-citationNeeded' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+		if ($referenceList->isEmpty()) {
+			$message = (new ViolationMessage('wbqc-violation-message-citationNeeded'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 			return new CheckResult(
 				$context,
 				$constraint,
@@ -53,10 +53,10 @@  discard block
 block discarded – undo
 			);
 		}
 
-		return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/ValueOnlyChecker.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -41,16 +41,16 @@
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getType() === Context::TYPE_STATEMENT ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getType() === Context::TYPE_STATEMENT) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		} else {
-			$message = new ViolationMessage( 'wbqc-violation-message-valueOnly' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-valueOnly');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/EntityTypeChecker.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -56,9 +56,9 @@  discard block
 block discarded – undo
 		return self::ALL_ENTITY_TYPES_SUPPORTED;
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -70,10 +70,10 @@  discard block
 block discarded – undo
 			'item' => $entityTypes->getEntityTypes(),
 		];
 
-		if ( !in_array( $context->getEntity()->getType(), $entityTypes->getEntityTypes() ) ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-entityType' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityIdList( $entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
+		if (!in_array($context->getEntity()->getType(), $entityTypes->getEntityTypes())) {
+			$message = (new ViolationMessage('wbqc-violation-message-entityType'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityIdList($entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
 
 			return new CheckResult(
 				$context,
@@ -84,10 +84,10 @@  discard block
 block discarded – undo
 			);
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId()
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

		@@ -79,7 +79,7 @@ discard block
		block discarded – undo
79	79	* @codeCoverageIgnore This method is purely declarative.
80	80	*/
81	81	public function getDefaultContextTypes() {
82		- return [ Context::TYPE_STATEMENT ];
	82	+ return [Context::TYPE_STATEMENT];
83	83	}
84	84
85	85	/** @codeCoverageIgnore This method is purely declarative. */
		@@ -96,31 +96,31 @@ discard block
		block discarded – undo
96	96	* @return CheckResult
97	97	* @throws \ConfigException
98	98	*/
99		- public function checkConstraint( Context $context, Constraint $constraint ) {
100		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
101		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	99	+ public function checkConstraint(Context $context, Constraint $constraint) {
	100	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	101	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
102	102	}
103	103	$snak = $context->getSnak();
104		- if ( !$snak instanceof PropertyValueSnak ) {
	104	+ if (!$snak instanceof PropertyValueSnak) {
105	105	// nothing to check
106		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	106	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
107	107	}
108	108
109	109	$dataValue = $snak->getDataValue();
110		- if ( !$dataValue instanceof EntityIdValue ) {
	110	+ if (!$dataValue instanceof EntityIdValue) {
111	111	// wrong data type
112		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
113		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
114		- ->withDataValueType( 'wikibase-entityid' );
115		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
	112	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	113	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
	114	+ ->withDataValueType('wikibase-entityid');
	115	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
116	116	}
117	117
118	118	$objectId = $dataValue->getEntityId();
119		- $objectItem = $this->entityLookup->getEntity( $objectId );
120		- if ( !( $objectItem instanceof StatementListProvider ) ) {
	119	+ $objectItem = $this->entityLookup->getEntity($objectId);
	120	+ if (!($objectItem instanceof StatementListProvider)) {
121	121	// object was deleted/doesn't exist
122		- $message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
123		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
	122	+ $message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
	123	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
124	124	}
125	125	/** @var Statement[] $objectStatements */
126	126	$objectStatements = $objectItem->getStatements()->toArray();
		@@ -128,9 +128,9 @@ discard block
		block discarded – undo
128	128	$subjectId = $context->getEntity()->getId();
129	129	$subjectStatements = $context->getEntity()->getStatements()->toArray();
130	130	/** @var String[] $startPropertyIds */
131		- $startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
	131	+ $startPropertyIds = $this->config->get(self::CONFIG_VARIABLE_START_PROPERTY_IDS);
132	132	/** @var String[] $endPropertyIds */
133		- $endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );
	133	+ $endPropertyIds = $this->config->get(self::CONFIG_VARIABLE_END_PROPERTY_IDS);
134	134	$subjectStartValue = $this->getExtremeValue(
135	135	$startPropertyIds,
136	136	$subjectStatements,
		@@ -152,15 +152,15 @@ discard block
		block discarded – undo
152	152	'end'
153	153	);
154	154	if (
155		- $this->rangeCheckerHelper->getComparison( $subjectStartValue, $subjectEndValue ) <= 0 &&
156		- $this->rangeCheckerHelper->getComparison( $objectStartValue, $objectEndValue ) <= 0 && (
157		- $this->rangeCheckerHelper->getComparison( $subjectEndValue, $objectStartValue ) < 0 \|\|
158		- $this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectStartValue ) < 0
	155	+ $this->rangeCheckerHelper->getComparison($subjectStartValue, $subjectEndValue) <= 0 &&
	156	+ $this->rangeCheckerHelper->getComparison($objectStartValue, $objectEndValue) <= 0 && (
	157	+ $this->rangeCheckerHelper->getComparison($subjectEndValue, $objectStartValue) < 0 \|\|
	158	+ $this->rangeCheckerHelper->getComparison($objectEndValue, $subjectStartValue) < 0
159	159	)
160	160	) {
161	161	if (
162	162	$subjectEndValue == null \|\|
163		- $this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectEndValue ) < 0
	163	+ $this->rangeCheckerHelper->getComparison($objectEndValue, $subjectEndValue) < 0
164	164	) {
165	165	$earlierEntityId = $objectId;
166	166	$minEndValue = $objectEndValue;
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	$message = null;
184	184	$status = CheckResult::STATUS_COMPLIANCE;
185	185	}
186		- return new CheckResult( $context, $constraint, [], $status, $message );
	186	+ return new CheckResult($context, $constraint, [], $status, $message);
187	187	}
188	188
189	189	/**
		@@ -193,19 +193,19 @@ discard block
		block discarded – undo
193	193	*
194	194	* @return DataValue\|null
195	195	*/
196		- private function getExtremeValue( $extremePropertyIds, $statements, $startOrEnd ) {
197		- if ( $startOrEnd !== 'start' && $startOrEnd !== 'end' ) {
198		- throw new \InvalidArgumentException( '$startOrEnd must be \'start\' or \'end\'.' );
	196	+ private function getExtremeValue($extremePropertyIds, $statements, $startOrEnd) {
	197	+ if ($startOrEnd !== 'start' && $startOrEnd !== 'end') {
	198	+ throw new \InvalidArgumentException('$startOrEnd must be \'start\' or \'end\'.');
199	199	}
200	200	$extremeValue = null;
201		- foreach ( $extremePropertyIds as $extremePropertyId ) {
202		- $statementList = new StatementList( ...$statements );
203		- $extremeStatements = $statementList->getByPropertyId( new PropertyId( $extremePropertyId ) );
	201	+ foreach ($extremePropertyIds as $extremePropertyId) {
	202	+ $statementList = new StatementList(...$statements);
	203	+ $extremeStatements = $statementList->getByPropertyId(new PropertyId($extremePropertyId));
204	204	/** @var Statement $extremeStatement */
205		- foreach ( $extremeStatements as $extremeStatement ) {
206		- if ( $extremeStatement->getRank() !== Statement::RANK_DEPRECATED ) {
	205	+ foreach ($extremeStatements as $extremeStatement) {
	206	+ if ($extremeStatement->getRank() !== Statement::RANK_DEPRECATED) {
207	207	$snak = $extremeStatement->getMainSnak();
208		- if ( !$snak instanceof PropertyValueSnak ) {
	208	+ if (!$snak instanceof PropertyValueSnak) {
209	209	return null;
210	210	} else {
211	211	$comparison = $this->rangeCheckerHelper->getComparison(
		@@ -214,8 +214,8 @@ discard block
		block discarded – undo
214	214	);
215	215	if (
216	216	$extremeValue === null \|\|
217		- ( $startOrEnd === 'start' && $comparison < 0 ) \|\|
218		- ( $startOrEnd === 'end' && $comparison > 0 )
	217	+ ($startOrEnd === 'start' && $comparison < 0) \|\|
	218	+ ($startOrEnd === 'end' && $comparison > 0)
219	219	) {
220	220	$extremeValue = $snak->getDataValue();
221	221	}
		@@ -245,17 +245,16 @@ discard block
		block discarded – undo
245	245	DataValue $maxStartValue
246	246	) {
247	247	$messageKey = $earlierEntityId === $subjectId ?
248		- 'wbqc-violation-message-contemporary-subject-earlier' :
249		- 'wbqc-violation-message-contemporary-value-earlier';
250		- return ( new ViolationMessage( $messageKey ) )
251		- ->withEntityId( $subjectId, Role::SUBJECT )
252		- ->withEntityId( $propertyId, Role::PREDICATE )
253		- ->withEntityId( $objectId, Role::OBJECT )
254		- ->withDataValue( $minEndValue, Role::OBJECT )
255		- ->withDataValue( $maxStartValue, Role::OBJECT );
	248	+ 'wbqc-violation-message-contemporary-subject-earlier' : 'wbqc-violation-message-contemporary-value-earlier';
	249	+ return (new ViolationMessage($messageKey))
	250	+ ->withEntityId($subjectId, Role::SUBJECT)
	251	+ ->withEntityId($propertyId, Role::PREDICATE)
	252	+ ->withEntityId($objectId, Role::OBJECT)
	253	+ ->withDataValue($minEndValue, Role::OBJECT)
	254	+ ->withDataValue($maxStartValue, Role::OBJECT);
256	255	}
257	256
258		- public function checkConstraintParameters( Constraint $constraint ) {
	257	+ public function checkConstraintParameters(Constraint $constraint) {
259	258	// no parameters
260	259	return [];
261	260	}

		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	return self::ALL_ENTITY_TYPES_SUPPORTED;
55	55	}
56	56
57		- public function checkConstraint( Context $context, Constraint $constraint ) {
	57	+ public function checkConstraint(Context $context, Constraint $constraint) {
58	58	$constraintParameters = $constraint->getConstraintParameters();
59	59	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
60	60
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	$constraintTypeItemId
64	64	);
65	65
66		- if ( in_array( $context->getType(), $allowedContextTypes ) ) {
	66	+ if (in_array($context->getType(), $allowedContextTypes)) {
67	67	return new CheckResult(
68	68	$context->getCursor(),
69	69	$constraint,
		@@ -76,15 +76,15 @@ discard block
		block discarded – undo
76	76	$constraint,
77	77	[],
78	78	CheckResult::STATUS_VIOLATION,
79		- ( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
80		- ->withEntityId( $context->getSnak()->getPropertyId() )
81		- ->withPropertyScope( $context->getType() )
82		- ->withPropertyScopeList( $allowedContextTypes )
	79	+ (new ViolationMessage('wbqc-violation-message-property-scope'))
	80	+ ->withEntityId($context->getSnak()->getPropertyId())
	81	+ ->withPropertyScope($context->getType())
	82	+ ->withPropertyScopeList($allowedContextTypes)
83	83	);
84	84	}
85	85	}
86	86
87		- public function checkConstraintParameters( Constraint $constraint ) {
	87	+ public function checkConstraintParameters(Constraint $constraint) {
88	88	$constraintParameters = $constraint->getConstraintParameters();
89	89	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
90	90	$exceptions = [];
		@@ -93,7 +93,7 @@ discard block
		block discarded – undo
93	93	$constraintParameters,
94	94	$constraintTypeItemId
95	95	);
96		- } catch ( ConstraintParameterException $e ) {
	96	+ } catch (ConstraintParameterException $e) {
97	97	$exceptions[] = $e;
98	98	}
99	99	return $exceptions;

		@@ -46,23 +46,22 @@ discard block
		block discarded – undo
46	46	return self::ALL_ENTITY_TYPES_SUPPORTED;
47	47	}
48	48
49		- public function checkConstraint( Context $context, Constraint $constraint ) {
	49	+ public function checkConstraint(Context $context, Constraint $constraint) {
50	50	$snak = $context->getSnak();
51	51
52		- if ( !$snak instanceof PropertyValueSnak ) {
	52	+ if (!$snak instanceof PropertyValueSnak) {
53	53	// nothing to check
54		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	54	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
55	55	}
56	56
57		- $violationMessage = $this->checkSnak( $snak );
	57	+ $violationMessage = $this->checkSnak($snak);
58	58
59	59	return new CheckResult(
60	60	$context,
61	61	$constraint,
62	62	[],
63	63	$violationMessage === null ?
64		- CheckResult::STATUS_COMPLIANCE :
65		- CheckResult::STATUS_VIOLATION,
	64	+ CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION,
66	65	$violationMessage
67	66	);
68	67	}
		@@ -71,23 +70,23 @@ discard block
		block discarded – undo
71	70	* @param PropertyValueSnak $snak
72	71	* @return ViolationMessage\|null
73	72	*/
74		- public function checkSnak( PropertyValueSnak $snak ) {
	73	+ public function checkSnak(PropertyValueSnak $snak) {
75	74	$dataValue = $snak->getDataValue();
76	75
77		- if ( $dataValue instanceof DecimalValue ) {
78		- if ( !$this->isInteger( $dataValue ) ) {
79		- return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
	76	+ if ($dataValue instanceof DecimalValue) {
	77	+ if (!$this->isInteger($dataValue)) {
	78	+ return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
80	79	}
81		- } elseif ( $dataValue instanceof UnboundedQuantityValue ) {
82		- if ( !$this->isInteger( $dataValue->getAmount() ) ) {
83		- return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
	80	+ } elseif ($dataValue instanceof UnboundedQuantityValue) {
	81	+ if (!$this->isInteger($dataValue->getAmount())) {
	82	+ return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
84	83	} elseif (
85	84	$dataValue instanceof QuantityValue && (
86		- !$this->isInteger( $dataValue->getLowerBound() ) \|\|
87		- !$this->isInteger( $dataValue->getUpperBound() )
	85	+ !$this->isInteger($dataValue->getLowerBound()) \|\|
	86	+ !$this->isInteger($dataValue->getUpperBound())
88	87	)
89	88	) {
90		- return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak );
	89	+ return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak);
91	90	}
92	91	}
93	92
		@@ -98,7 +97,7 @@ discard block
		block discarded – undo
98	97	* @param DecimalValue $decimalValue
99	98	* @return bool
100	99	*/
101		- private function isInteger( DecimalValue $decimalValue ) {
	100	+ private function isInteger(DecimalValue $decimalValue) {
102	101	return $decimalValue->getTrimmed()->getFractionalPart() === '';
103	102	}
104	103
		@@ -107,13 +106,13 @@ discard block
		block discarded – undo
107	106	* @param PropertyValueSnak $snak
108	107	* @return ViolationMessage
109	108	*/
110		- private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) {
111		- return ( new ViolationMessage( $messageKey ) )
112		- ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
113		- ->withDataValue( $snak->getDataValue() );
	109	+ private function getViolationMessage($messageKey, PropertyValueSnak $snak) {
	110	+ return (new ViolationMessage($messageKey))
	111	+ ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	112	+ ->withDataValue($snak->getDataValue());
114	113	}
115	114
116		- public function checkConstraintParameters( Constraint $constraint ) {
	115	+ public function checkConstraintParameters(Constraint $constraint) {
117	116	// no parameters
118	117	return [];
119	118	}

		@@ -41,16 +41,16 @@
		block discarded – undo
41	41	return self::ALL_ENTITY_TYPES_SUPPORTED;
42	42	}
43	43
44		- public function checkConstraint( Context $context, Constraint $constraint ) {
45		- if ( $context->getType() === Context::TYPE_REFERENCE ) {
46		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	44	+ public function checkConstraint(Context $context, Constraint $constraint) {
	45	+ if ($context->getType() === Context::TYPE_REFERENCE) {
	46	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
47	47	} else {
48		- $message = new ViolationMessage( 'wbqc-violation-message-reference' );
49		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
	48	+ $message = new ViolationMessage('wbqc-violation-message-reference');
	49	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
50	50	}
51	51	}
52	52
53		- public function checkConstraintParameters( Constraint $constraint ) {
	53	+ public function checkConstraintParameters(Constraint $constraint) {
54	54	// no parameters
55	55	return [];
56	56	}

		@@ -44,17 +44,17 @@ discard block
		block discarded – undo
44	44	return self::ALL_ENTITY_TYPES_SUPPORTED;
45	45	}
46	46
47		- public function checkConstraint( Context $context, Constraint $constraint ) {
	47	+ public function checkConstraint(Context $context, Constraint $constraint) {
48	48	$snak = $context->getSnak();
49	49
50		- if ( !$snak instanceof PropertyValueSnak ) {
	50	+ if (!$snak instanceof PropertyValueSnak) {
51	51	// nothing to check
52		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	52	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
53	53	}
54	54
55		- if ( $snak->getDataValue() instanceof QuantityValue ) {
56		- $message = ( new ViolationMessage( 'wbqc-violation-message-noBounds' ) )
57		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	55	+ if ($snak->getDataValue() instanceof QuantityValue) {
	56	+ $message = (new ViolationMessage('wbqc-violation-message-noBounds'))
	57	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
58	58	return new CheckResult(
59	59	$context,
60	60	$constraint,
		@@ -64,10 +64,10 @@ discard block
		block discarded – undo
64	64	);
65	65	}
66	66
67		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	67	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
68	68	}
69	69
70		- public function checkConstraintParameters( Constraint $constraint ) {
	70	+ public function checkConstraintParameters(Constraint $constraint) {
71	71	// no parameters
72	72	return [];
73	73	}

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	* @codeCoverageIgnore This method is purely declarative.
31	31	*/
32	32	public function getDefaultContextTypes() {
33		- return [ Context::TYPE_STATEMENT ];
	33	+ return [Context::TYPE_STATEMENT];
34	34	}
35	35
36	36	/** @codeCoverageIgnore This method is purely declarative. */
		@@ -38,12 +38,12 @@ discard block
		block discarded – undo
38	38	return self::ALL_ENTITY_TYPES_SUPPORTED;
39	39	}
40	40
41		- public function checkConstraint( Context $context, Constraint $constraint ) {
	41	+ public function checkConstraint(Context $context, Constraint $constraint) {
42	42	$referenceList = $context->getSnakStatement()->getReferences();
43	43
44		- if ( $referenceList->isEmpty() ) {
45		- $message = ( new ViolationMessage( 'wbqc-violation-message-citationNeeded' ) )
46		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	44	+ if ($referenceList->isEmpty()) {
	45	+ $message = (new ViolationMessage('wbqc-violation-message-citationNeeded'))
	46	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
47	47	return new CheckResult(
48	48	$context,
49	49	$constraint,
		@@ -53,10 +53,10 @@ discard block
		block discarded – undo
53	53	);
54	54	}
55	55
56		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	56	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
57	57	}
58	58
59		- public function checkConstraintParameters( Constraint $constraint ) {
	59	+ public function checkConstraintParameters(Constraint $constraint) {
60	60	// no parameters
61	61	return [];
62	62	}

		@@ -56,9 +56,9 @@ discard block
		block discarded – undo
56	56	return self::ALL_ENTITY_TYPES_SUPPORTED;
57	57	}
58	58
59		- public function checkConstraint( Context $context, Constraint $constraint ) {
60		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
61		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	59	+ public function checkConstraint(Context $context, Constraint $constraint) {
	60	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	61	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
62	62	}
63	63
64	64	$constraintParameters = $constraint->getConstraintParameters();
		@@ -70,10 +70,10 @@ discard block
		block discarded – undo
70	70	'item' => $entityTypes->getEntityTypes(),
71	71	];
72	72
73		- if ( !in_array( $context->getEntity()->getType(), $entityTypes->getEntityTypes() ) ) {
74		- $message = ( new ViolationMessage( 'wbqc-violation-message-entityType' ) )
75		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
76		- ->withEntityIdList( $entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
	73	+ if (!in_array($context->getEntity()->getType(), $entityTypes->getEntityTypes())) {
	74	+ $message = (new ViolationMessage('wbqc-violation-message-entityType'))
	75	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	76	+ ->withEntityIdList($entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
77	77
78	78	return new CheckResult(
79	79	$context,
		@@ -84,10 +84,10 @@ discard block
		block discarded – undo
84	84	);
85	85	}
86	86
87		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	87	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
88	88	}
89	89
90		- public function checkConstraintParameters( Constraint $constraint ) {
	90	+ public function checkConstraintParameters(Constraint $constraint) {
91	91	$constraintParameters = $constraint->getConstraintParameters();
92	92	$exceptions = [];
93	93	try {
		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	$constraintParameters,
96	96	$constraint->getConstraintTypeItemId()
97	97	);
98		- } catch ( ConstraintParameterException $e ) {
	98	+ } catch (ConstraintParameterException $e) {
99	99	$exceptions[] = $e;
100	100	}
101	101	return $exceptions;

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( d48b91...d3e045 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +42 added lines, -43 removed lines patch added patch discarded remove patch

Spacing +21 added lines, -22 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch