wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Context/EntityContextCursor.php

Spacing +11 added lines, -11 removed lines

@@ -35,7 +35,7 @@ 
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getType() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	public function getEntityId() {
@@ -46,35 +46,35 @@ 
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getStatementPropertyId() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getStatementGuid() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getSnakPropertyId() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getSnakHash() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
-	public function &getMainArray( array &$container ) {
-		throw new LogicException( 'EntityContextCursor cannot store check results' );
+	public function &getMainArray(array &$container) {
+		throw new LogicException('EntityContextCursor cannot store check results');
 	}
 
 	/**
@@ -83,14 +83,14 @@ 
 	 * @param array|null $result must be null
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( array $result = null, array &$container ) {
-		if ( $result !== null ) {
-			throw new LogicException( 'EntityContextCursor cannot store check results' );
+	public function storeCheckResultInArray(array $result = null, array &$container) {
+		if ($result !== null) {
+			throw new LogicException('EntityContextCursor cannot store check results');
 		}
 
 		// this ensures that the claims array is present in the $container,
 		// populating it if necessary, even though we ignore the return value
-		$this->getClaimsArray( $container );
+		$this->getClaimsArray($container);
 	}
 
 }

maintenance/ImportConstraintStatements.php

Spacing +18 added lines, -18 removed lines

@@ -9,10 +9,10 @@ 
 use Wikibase\Repo\WikibaseRepo;
 
 // @codeCoverageIgnoreStart
-$basePath = getenv( "MW_INSTALL_PATH" ) !== false
-	? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../..";
+$basePath = getenv("MW_INSTALL_PATH") !== false
+	? getenv("MW_INSTALL_PATH") : __DIR__."/../../..";
 
-require_once $basePath . "/maintenance/Maintenance.php";
+require_once $basePath."/maintenance/Maintenance.php";
 // @codeCoverageIgnoreEnd
 
 /**
@@ -38,39 +38,39 @@ 
 
 	public function __construct() {
 		parent::__construct();
-		$this->newUpdateConstraintsTableJob = function ( $propertyIdSerialization ) {
+		$this->newUpdateConstraintsTableJob = function($propertyIdSerialization) {
 			return UpdateConstraintsTableJob::newFromGlobalState(
 				Title::newMainPage(),
-				[ 'propertyId' => $propertyIdSerialization ]
+				['propertyId' => $propertyIdSerialization]
 			);
 		};
 
-		$this->addDescription( 'Imports property constraints from statements on properties' );
-		$this->requireExtension( 'WikibaseQualityConstraints' );
+		$this->addDescription('Imports property constraints from statements on properties');
+		$this->requireExtension('WikibaseQualityConstraints');
 
 		// Wikibase classes are not yet loaded, so setup services in a callback run in execute
 		// that can be overridden in tests.
-		$this->setupServices = function () {
+		$this->setupServices = function() {
 			$repo = WikibaseRepo::getDefaultInstance();
 			$this->propertyInfoLookup = $repo->getStore()->getPropertyInfoLookup();
 		};
 	}
 
 	public function execute() {
-		( $this->setupServices )();
-		if ( !$this->getConfig()->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) ) {
-			$this->error( 'Constraint statements are not enabled. Aborting.' );
+		($this->setupServices)();
+		if (!$this->getConfig()->get('WBQualityConstraintsEnableConstraintsImportFromStatements')) {
+			$this->error('Constraint statements are not enabled. Aborting.');
 			return;
 		}
 
-		foreach ( $this->propertyInfoLookup->getAllPropertyInfo() as $propertyIdSerialization => $info ) {
-			$this->output( sprintf( 'Importing constraint statements for % 6s... ', $propertyIdSerialization ), $propertyIdSerialization );
-			$startTime = microtime( true );
-			$job = call_user_func( $this->newUpdateConstraintsTableJob, $propertyIdSerialization );
+		foreach ($this->propertyInfoLookup->getAllPropertyInfo() as $propertyIdSerialization => $info) {
+			$this->output(sprintf('Importing constraint statements for % 6s... ', $propertyIdSerialization), $propertyIdSerialization);
+			$startTime = microtime(true);
+			$job = call_user_func($this->newUpdateConstraintsTableJob, $propertyIdSerialization);
 			$job->run();
-			$endTime = microtime( true );
-			$millis = ( $endTime - $startTime ) * 1000;
-			$this->output( sprintf( 'done in % 6.2f ms.', $millis ), $propertyIdSerialization );
+			$endTime = microtime(true);
+			$millis = ($endTime - $startTime) * 1000;
+			$this->output(sprintf('done in % 6.2f ms.', $millis), $propertyIdSerialization);
 		}
 	}
 

src/ConstraintCheck/Helper/TypeCheckerHelper.php

Spacing +36 added lines, -36 removed lines

@@ -80,23 +80,23 @@ 
 	 * @return bool
 	 * @throws OverflowException if $entitiesChecked exceeds the configured limit
 	 */
-	private function isSubclassOf( EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0 ) {
-		$maxEntities = $this->config->get( 'WBQualityConstraintsTypeCheckMaxEntities' );
+	private function isSubclassOf(EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0) {
+		$maxEntities = $this->config->get('WBQualityConstraintsTypeCheckMaxEntities');
 		if ( ++$entitiesChecked > $maxEntities ) {
-			throw new OverflowException( 'Too many entities to check' );
+			throw new OverflowException('Too many entities to check');
 		}
 
-		$item = $this->entityLookup->getEntity( $comparativeClass );
-		if ( !( $item instanceof StatementListProvider ) ) {
+		$item = $this->entityLookup->getEntity($comparativeClass);
+		if (!($item instanceof StatementListProvider)) {
 			return false; // lookup failed, probably because item doesn't exist
 		}
 
-		$subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		$subclassId = $this->config->get('WBQualityConstraintsSubclassOfId');
 		/** @var Statement $statement */
-		foreach ( $item->getStatements()->getByPropertyId( new PropertyId( $subclassId ) ) as $statement ) {
+		foreach ($item->getStatements()->getByPropertyId(new PropertyId($subclassId)) as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !( $this->hasCorrectType( $mainSnak ) ) ) {
+			if (!($this->hasCorrectType($mainSnak))) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -105,11 +105,11 @@ 
 			$dataValue = $mainSnak->getDataValue();
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				return true;
 			}
 
-			if ( $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked ) ) {
+			if ($this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked)) {
 				return true;
 			}
 		}
@@ -130,14 +130,14 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function isSubclassOfWithSparqlFallback( EntityId $comparativeClass, array $classesToCheck ) {
+	public function isSubclassOfWithSparqlFallback(EntityId $comparativeClass, array $classesToCheck) {
 		try {
 			return new CachedBool(
-				$this->isSubclassOf( $comparativeClass, $classesToCheck ),
+				$this->isSubclassOf($comparativeClass, $classesToCheck),
 				Metadata::blank()
 			);
-		} catch ( OverflowException $e ) {
-			if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
+		} catch (OverflowException $e) {
+			if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
 				$this->dataFactory->increment(
 					'wikibase.quality.constraints.sparql.typeFallback'
 				);
@@ -147,7 +147,7 @@ 
 					/* withInstance = */ false
 				);
 			} else {
-				return new CachedBool( false, Metadata::blank() );
+				return new CachedBool(false, Metadata::blank());
 			}
 		}
 	}
@@ -165,13 +165,13 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function hasClassInRelation( StatementList $statements, array $relationIds, array $classesToCheck ) {
+	public function hasClassInRelation(StatementList $statements, array $relationIds, array $classesToCheck) {
 		$metadatas = [];
 
-		foreach ( $this->getStatementsByPropertyIds( $statements, $relationIds ) as $statement ) {
+		foreach ($this->getStatementsByPropertyIds($statements, $relationIds) as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !$this->hasCorrectType( $mainSnak ) ) {
+			if (!$this->hasCorrectType($mainSnak)) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -180,28 +180,28 @@ 
 			$dataValue = $mainSnak->getDataValue();
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				// discard $metadatas, we know this is fresh
-				return new CachedBool( true, Metadata::blank() );
+				return new CachedBool(true, Metadata::blank());
 			}
 
-			$result = $this->isSubclassOfWithSparqlFallback( $comparativeClass, $classesToCheck );
+			$result = $this->isSubclassOfWithSparqlFallback($comparativeClass, $classesToCheck);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getBool() ) {
+			if ($result->getBool()) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	private function hasCorrectType( Snak $mainSnak ) {
+	private function hasCorrectType(Snak $mainSnak) {
 		return $mainSnak instanceof PropertyValueSnak
 			&& $mainSnak->getDataValue()->getType() === 'wikibase-entityid';
 	}
@@ -218,12 +218,12 @@ 
 	) {
 		$statementArrays = [];
 
-		foreach ( $propertyIdSerializations as $propertyIdSerialization ) {
-			$propertyId = new PropertyId( $propertyIdSerialization );
-			$statementArrays[] = $statements->getByPropertyId( $propertyId )->toArray();
+		foreach ($propertyIdSerializations as $propertyIdSerialization) {
+			$propertyId = new PropertyId($propertyIdSerialization);
+			$statementArrays[] = $statements->getByPropertyId($propertyId)->toArray();
 		}
 
-		return call_user_func_array( 'array_merge', $statementArrays );
+		return call_user_func_array('array_merge', $statementArrays);
 	}
 
 	/**
@@ -235,10 +235,10 @@ 
 	 *
 	 * @return ViolationMessage
 	 */
-	public function getViolationMessage( PropertyId $propertyId, EntityId $entityId, array $classes, $checker, $relation ) {
+	public function getViolationMessage(PropertyId $propertyId, EntityId $entityId, array $classes, $checker, $relation) {
 		$classes = array_map(
-			function( $itemIdSerialization ) {
-				return new ItemId( $itemIdSerialization );
+			function($itemIdSerialization) {
+				return new ItemId($itemIdSerialization);
 			},
 			$classes
 		);
@@ -250,10 +250,10 @@ 
 		// wbqc-violation-message-valueType-instance
 		// wbqc-violation-message-valueType-subclass
 		// wbqc-violation-message-valueType-instanceOrSubclass
-		return ( new ViolationMessage( 'wbqc-violation-message-' . $checker . '-' . $relation ) )
-			->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY )
-			->withEntityId( $entityId, Role::SUBJECT )
-			->withEntityIdList( $classes, Role::OBJECT );
+		return (new ViolationMessage('wbqc-violation-message-'.$checker.'-'.$relation))
+			->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY)
+			->withEntityId($entityId, Role::SUBJECT)
+			->withEntityIdList($classes, Role::OBJECT);
 	}
 
 }

src/ConstraintCheck/Helper/DummySparqlHelper.php

Spacing +8 added lines, -8 removed lines

@@ -22,15 +22,15 @@ 
 		// no parent::__construct() call
 	}
 
-	public function hasType( $id, array $classes, $withInstance ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function hasType($id, array $classes, $withInstance) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameStatement(
 		Statement $statement,
 		$ignoreDeprecatedStatements
 	) {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameQualifierOrReference(
@@ -39,15 +39,15 @@ 
 		$type,
 		$ignoreDeprecatedStatements
 	) {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function matchesRegularExpression( $text, $regex ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function matchesRegularExpression($text, $regex) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function runQuery( $query ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function runQuery($query) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 }

src/ConstraintCheck/Checker/UniqueValueChecker.php

Spacing +16 added lines, -16 removed lines

@@ -64,22 +64,22 @@ 
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
-		if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
-			if ( $context->getType() === 'statement' ) {
+		if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
+			if ($context->getType() === 'statement') {
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
 					$context->getSnakStatement(),
 					true // ignore deprecated statements
 				);
 			} else {
-				if ( $context->getSnak()->getType() !== 'value' ) {
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+				if ($context->getSnak()->getType() !== 'value') {
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -92,27 +92,27 @@ 
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/FormatChecker.php

Spacing +26 added lines, -26 removed lines

@@ -85,12 +85,12 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$format = $this->constraintParameterParser->parseFormatParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		$parameters['pattern'] = [ $format ];
+		$format = $this->constraintParameterParser->parseFormatParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		$parameters['pattern'] = [$format];
 
 		$syntaxClarifications = $this->constraintParameterParser->parseSyntaxClarificationParameter(
 			$constraintParameters
@@ -98,9 +98,9 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -109,7 +109,7 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Format' constraint has to be 'string' or 'monolingualtext'
 		 */
-		switch ( $dataValue->getType() ) {
+		switch ($dataValue->getType()) {
 			case 'string':
 				$text = $dataValue->getValue();
 				break;
@@ -118,49 +118,49 @@ 
 				$text = $dataValue->getText();
 				break;
 			default:
-				$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
-					->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-					->withDataValueType( 'string' )
-					->withDataValueType( 'monolingualtext' );
-				return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+				$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
+					->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+					->withDataValueType('string')
+					->withDataValueType('monolingualtext');
+				return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		if (
-			!( $this->sparqlHelper instanceof DummySparqlHelper ) &&
-			$this->config->get( 'WBQualityConstraintsCheckFormatConstraint' )
+			!($this->sparqlHelper instanceof DummySparqlHelper) &&
+			$this->config->get('WBQualityConstraintsCheckFormatConstraint')
 		) {
-			if ( $this->sparqlHelper->matchesRegularExpression( $text, $format ) ) {
+			if ($this->sparqlHelper->matchesRegularExpression($text, $format)) {
 				$message = null;
 				$status = CheckResult::STATUS_COMPLIANCE;
 			} else {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-format-clarification' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withDataValue( new StringValue( $text ), Role::OBJECT )
-					->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE )
-					->withMultilingualText( $syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE );
+				$message = (new ViolationMessage('wbqc-violation-message-format-clarification'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withDataValue(new StringValue($text), Role::OBJECT)
+					->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE)
+					->withMultilingualText($syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE);
 				$status = CheckResult::STATUS_VIOLATION;
 			}
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-security-reason' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-security-reason'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$status = CheckResult::STATUS_TODO;
 		}
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseFormatParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseFormatParameter($constraintParameters, $constraint->getConstraintTypeItemId());
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
 			$this->constraintParameterParser->parseSyntaxClarificationParameter(
 				$constraintParameters
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/WikibaseQualityConstraintsHooks.php

Spacing +39 added lines, -39 removed lines

@@ -31,48 +31,48 @@ 
 	/**
 	 * @param DatabaseUpdater $updater
 	 */
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
+	public static function onCreateSchema(DatabaseUpdater $updater) {
 		$updater->addExtensionTable(
 			'wbqc_constraints',
-			__DIR__ . '/../sql/create_wbqc_constraints.sql'
+			__DIR__.'/../sql/create_wbqc_constraints.sql'
 		);
 		$updater->addExtensionField(
 			'wbqc_constraints',
 			'constraint_id',
-			__DIR__ . '/../sql/patch-wbqc_constraints-constraint_id.sql'
+			__DIR__.'/../sql/patch-wbqc_constraints-constraint_id.sql'
 		);
 		$updater->addExtensionIndex(
 			'wbqc_constraints',
 			'wbqc_constraints_guid_uniq',
-			__DIR__ . '/../sql/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
+			__DIR__.'/../sql/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
 		);
 	}
 
-	public static function onWikibaseChange( Change $change ) {
+	public static function onWikibaseChange(Change $change) {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-			self::isConstraintStatementsChange( $config, $change )
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
+			self::isConstraintStatementsChange($config, $change)
 		) {
 			/** @var EntityChange $change */
 			$title = Title::newMainPage();
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
 			JobQueueGroup::singleton()->push(
-				new JobSpecification( 'constraintsTableUpdate', $params, [], $title )
+				new JobSpecification('constraintsTableUpdate', $params, [], $title)
 			);
 		}
 	}
 
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
-		if ( !( $change instanceof EntityChange ) ||
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
+		if (!($change instanceof EntityChange) ||
 			 $change->getAction() !== EntityChange::UPDATE ||
-			 !( $change->getEntityId() instanceof PropertyId )
+			 !($change->getEntityId() instanceof PropertyId)
 		) {
 			return false;
 		}
 
 		$info = $change->getInfo();
 
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
+		if (!array_key_exists('compactDiff', $info)) {
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
 			// so we only know that the change *might* affect the constraint statements
 			return true;
@@ -81,46 +81,46 @@ 
 		/** @var EntityDiffChangedAspects $aspects */
 		$aspects = $info['compactDiff'];
 
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
 	}
 
-	public static function onArticlePurge( WikiPage $wikiPage ) {
+	public static function onArticlePurge(WikiPage $wikiPage) {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$entityContentFactory = $repo->getEntityContentFactory();
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
-			$entityId = $entityContentFactory->getEntityIdForTitle( $wikiPage->getTitle() );
-			if ( $entityId !== null ) {
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
+			$entityId = $entityContentFactory->getEntityIdForTitle($wikiPage->getTitle());
+			if ($entityId !== null) {
 				$resultsCache = ResultsCache::getDefaultInstance();
-				$resultsCache->delete( $entityId );
+				$resultsCache->delete($entityId);
 			}
 		}
 	}
 
-	public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
+	public static function onBeforePageDisplay(OutputPage $out, Skin $skin) {
 		$repo = WikibaseRepo::getDefaultInstance();
 
 		$lookup = $repo->getEntityNamespaceLookup();
 		$title = $out->getTitle();
-		if ( $title === null ) {
+		if ($title === null) {
 			return;
 		}
 
-		if ( !$lookup->isEntityNamespace( $title->getNamespace() ) ) {
+		if (!$lookup->isEntityNamespace($title->getNamespace())) {
 			return;
 		}
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
 			return;
 		}
 
-		$out->addModules( 'wikibase.quality.constraints.suggestions' );
+		$out->addModules('wikibase.quality.constraints.suggestions');
 
-		if ( !$out->getUser()->isLoggedIn() ) {
+		if (!$out->getUser()->isLoggedIn()) {
 			return;
 		}
 
-		$out->addModules( 'wikibase.quality.constraints.gadget' );
+		$out->addModules('wikibase.quality.constraints.gadget');
 	}
 
 	/**
@@ -129,10 +129,10 @@ 
 	 * @param User $user
 	 * @param array[] &$prefs
 	 */
-	public static function onGetBetaFeaturePreferences( User $user, array &$prefs ) {
+	public static function onGetBetaFeaturePreferences(User $user, array &$prefs) {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		$extensionAssetsPath = $config->get( 'ExtensionAssetsPath' );
-		if ( $config->get( 'WBQualityConstraintsSuggestionsBetaFeature' ) ) {
+		$extensionAssetsPath = $config->get('ExtensionAssetsPath');
+		if ($config->get('WBQualityConstraintsSuggestionsBetaFeature')) {
 			$prefs['constraint-suggestions'] = [
 					'label-message' => 'wbqc-beta-feature-label-message',
 					'desc-message' => 'wbqc-beta-feature-description-message',
@@ -156,20 +156,20 @@ 
 	 * @param array &$vars
 	 * @param OutputPage $out
 	 */
-	public static function addVariables( &$vars, OutputPage $out ) {
+	public static function addVariables(&$vars, OutputPage $out) {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
 
-		$vars['wbQualityConstraintsPropertyConstraintId'] = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		$vars['wbQualityConstraintsOneOfConstraintId'] = $config->get( 'WBQualityConstraintsOneOfConstraintId' );
-		$vars['wbQualityConstraintsAllowedQualifierConstraintId'] = $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' );
-		$vars['wbQualityConstraintsPropertyId'] = $config->get( 'WBQualityConstraintsPropertyId' );
-		$vars['wbQualityConstraintsQualifierOfPropertyConstraintId'] = $config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' );
+		$vars['wbQualityConstraintsPropertyConstraintId'] = $config->get('WBQualityConstraintsPropertyConstraintId');
+		$vars['wbQualityConstraintsOneOfConstraintId'] = $config->get('WBQualityConstraintsOneOfConstraintId');
+		$vars['wbQualityConstraintsAllowedQualifierConstraintId'] = $config->get('WBQualityConstraintsAllowedQualifiersConstraintId');
+		$vars['wbQualityConstraintsPropertyId'] = $config->get('WBQualityConstraintsPropertyId');
+		$vars['wbQualityConstraintsQualifierOfPropertyConstraintId'] = $config->get('WBQualityConstraintsQualifierOfPropertyConstraintId');
 
 		$vars['wbQualityConstraintsSuggestionsGloballyEnabled'] = false;
 
-		if ( $config->get( 'WBQualityConstraintsSuggestionsBetaFeature' ) &&
-			ExtensionRegistry::getInstance()->isLoaded( 'BetaFeatures' ) &&
-			BetaFeatures::isFeatureEnabled( $out->getUser(), 'constraint-suggestions' )
+		if ($config->get('WBQualityConstraintsSuggestionsBetaFeature') &&
+			ExtensionRegistry::getInstance()->isLoaded('BetaFeatures') &&
+			BetaFeatures::isFeatureEnabled($out->getUser(), 'constraint-suggestions')
 			) {
 			$vars['wbQualityConstraintsSuggestionsGloballyEnabled'] = true;
 		}

src/Specials/SpecialConstraintReport.php

Spacing +104 added lines, -104 removed lines

@@ -136,7 +136,7 @@ 
 		Config $config,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( 'ConstraintReport' );
+		parent::__construct('ConstraintReport');
 
 		$this->entityLookup = $entityLookup;
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -145,7 +145,7 @@ 
 		$language = $this->getLanguage();
 
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
 		$this->dataValueFormatter = $valueFormatterFactory->getValueFormatter(
 			SnakFormatter::FORMAT_HTML,
 			$formatterOptions
@@ -205,7 +205,7 @@ 
 	 * @return string
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqc-constraintreport' )->escaped();
+		return $this->msg('wbqc-constraintreport')->escaped();
 	}
 
 	/**
@@ -217,43 +217,43 @@ 
 	 * @throws EntityIdParsingException
 	 * @throws UnexpectedValueException
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
-		if ( $postRequest ) {
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
+		if ($postRequest) {
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
 			return;
 		}
 
 		$out->enableOOUI();
-		$out->addModules( $this->getModules() );
+		$out->addModules($this->getModules());
 
 		$this->setHeaders();
 
-		$out->addHTML( $this->getExplanationText() );
+		$out->addHTML($this->getExplanationText());
 		$this->buildEntityIdForm();
 
-		if ( !$subPage ) {
+		if (!$subPage) {
 			return;
 		}
 
-		if ( !is_string( $subPage ) ) {
-			throw new InvalidArgumentException( '$subPage must be string.' );
+		if (!is_string($subPage)) {
+			throw new InvalidArgumentException('$subPage must be string.');
 		}
 
 		try {
-			$entityId = $this->entityIdParser->parse( $subPage );
-		} catch ( EntityIdParsingException $e ) {
+			$entityId = $this->entityIdParser->parse($subPage);
+		} catch (EntityIdParsingException $e) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
+		if (!$this->entityLookup->hasEntity($entityId)) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
 			);
 			return;
 		}
@@ -261,18 +261,18 @@ 
 		$this->dataFactory->increment(
 			'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck'
 		);
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
 
-		if ( $results !== [] ) {
+		if ($results !== []) {
 			$out->addHTML(
-				$this->buildResultHeader( $entityId )
-				. $this->buildSummary( $results )
-				. $this->buildResultTable( $entityId, $results )
+				$this->buildResultHeader($entityId)
+				. $this->buildSummary($results)
+				. $this->buildResultTable($entityId, $results)
 			);
 		} else {
 			$out->addHTML(
-				$this->buildResultHeader( $entityId )
-				. $this->buildNotice( 'wbqc-constraintreport-empty-result' )
+				$this->buildResultHeader($entityId)
+				. $this->buildNotice('wbqc-constraintreport-empty-result')
 			);
 		}
 	}
@@ -288,15 +288,15 @@ 
 				'name' => 'entityid',
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped()
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped()
 			]
 		];
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' );
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() );
-		$htmlForm->setSubmitCallback( function() {
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form');
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped());
+		$htmlForm->setSubmitCallback(function() {
 			return false;
 		} );
-		$htmlForm->setMethod( 'post' );
+		$htmlForm->setMethod('post');
 		$htmlForm->show();
 	}
 
@@ -310,16 +310,16 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildNotice( $messageKey, $error = false ) {
-		if ( !is_string( $messageKey ) ) {
-			throw new InvalidArgumentException( '$message must be string.' );
+	private function buildNotice($messageKey, $error = false) {
+		if (!is_string($messageKey)) {
+			throw new InvalidArgumentException('$message must be string.');
 		}
-		if ( !is_bool( $error ) ) {
-			throw new InvalidArgumentException( '$error must be bool.' );
+		if (!is_bool($error)) {
+			throw new InvalidArgumentException('$error must be bool.');
 		}
 
 		$cssClasses = 'wbqc-constraintreport-notice';
-		if ( $error ) {
+		if ($error) {
 			$cssClasses .= ' wbqc-constraintreport-notice-error';
 		}
 
@@ -328,7 +328,7 @@ 
 				[
 					'class' => $cssClasses
 				],
-				$this->msg( $messageKey )->escaped()
+				$this->msg($messageKey)->escaped()
 			);
 	}
 
@@ -338,16 +338,16 @@ 
 	private function getExplanationText() {
 		return Html::rawElement(
 			'div',
-			[ 'class' => 'wbqc-explanation' ],
+			['class' => 'wbqc-explanation'],
 			Html::rawElement(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped()
+				$this->msg('wbqc-constraintreport-explanation-part-one')->escaped()
 			)
 			. Html::rawElement(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped()
+				$this->msg('wbqc-constraintreport-explanation-part-two')->escaped()
 			)
 		);
 	}
@@ -358,72 +358,72 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildResultTable( EntityId $entityId, array $results ) {
+	private function buildResultTable(EntityId $entityId, array $results) {
 		// Set table headers
 		$table = new HtmlTableBuilder(
 			[
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-status')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-property')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-message')->escaped(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->escaped(),
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->escaped(),
 					true
 				)
 			]
 		);
 
-		foreach ( $results as $result ) {
-			$table = $this->appendToResultTable( $table, $entityId, $result );
+		foreach ($results as $result) {
+			$table = $this->appendToResultTable($table, $entityId, $result);
 		}
 
 		return $table->toHtml();
 	}
 
-	private function appendToResultTable( HtmlTableBuilder $table, EntityId $entityId, CheckResult $result ) {
+	private function appendToResultTable(HtmlTableBuilder $table, EntityId $entityId, CheckResult $result) {
 		$message = $result->getMessage();
-		if ( $message === null ) {
+		if ($message === null) {
 			// no row for this result
 			return $table;
 		}
 
 		// Status column
-		$statusColumn = $this->formatStatus( $result->getStatus() );
+		$statusColumn = $this->formatStatus($result->getStatus());
 
 		// Property column
-		$propertyId = new PropertyId( $result->getContextCursor()->getSnakPropertyId() );
+		$propertyId = new PropertyId($result->getContextCursor()->getSnakPropertyId());
 		$propertyColumn = $this->getClaimLink(
 			$entityId,
 			$propertyId,
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
 		);
 
 		// Message column
-		$messageColumn = $this->violationMessageRenderer->render( $message );
+		$messageColumn = $this->violationMessageRenderer->render($message);
 
 		// Constraint column
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
 		try {
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
-		} catch ( InvalidArgumentException $e ) {
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
+		} catch (InvalidArgumentException $e) {
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
 		}
 		$constraintLink = $this->getClaimLink(
 			$propertyId,
-			new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
+			new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
 			$constraintTypeLabel
 		);
 		$constraintColumn = $this->buildExpandableElement(
 			$constraintLink,
-			$this->constraintParameterRenderer->formatParameters( $result->getParameters() ),
+			$this->constraintParameterRenderer->formatParameters($result->getParameters()),
 			'[...]'
 		);
 
@@ -463,15 +463,15 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildResultHeader( EntityId $entityId ) {
-		$entityLink = sprintf( '%s (%s)',
-							   $this->entityIdLinkFormatter->formatEntityId( $entityId ),
-							   htmlspecialchars( $entityId->getSerialization() ) );
+	protected function buildResultHeader(EntityId $entityId) {
+		$entityLink = sprintf('%s (%s)',
+							   $this->entityIdLinkFormatter->formatEntityId($entityId),
+							   htmlspecialchars($entityId->getSerialization()));
 
 		return Html::rawElement(
 			'h3',
 			[],
-			sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink )
+			sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink)
 		);
 	}
 
@@ -482,24 +482,24 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildSummary( array $results ) {
+	protected function buildSummary(array $results) {
 		$statuses = [];
-		foreach ( $results as $result ) {
-			$status = strtolower( $result->getStatus() );
-			$statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1;
+		foreach ($results as $result) {
+			$status = strtolower($result->getStatus());
+			$statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1;
 		}
 
 		$statusElements = [];
-		foreach ( $statuses as $status => $count ) {
-			if ( $count > 0 ) {
+		foreach ($statuses as $status => $count) {
+			if ($count > 0) {
 				$statusElements[] =
-					$this->formatStatus( $status )
+					$this->formatStatus($status)
 					. ': '
 					. $count;
 			}
 		}
 
-		return Html::rawElement( 'p', [], implode( ', ', $statusElements ) );
+		return Html::rawElement('p', [], implode(', ', $statusElements));
 	}
 
 	/**
@@ -514,15 +514,15 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildExpandableElement( $content, $expandableContent, $indicator ) {
-		if ( !is_string( $content ) ) {
-			throw new InvalidArgumentException( '$content has to be string.' );
+	protected function buildExpandableElement($content, $expandableContent, $indicator) {
+		if (!is_string($content)) {
+			throw new InvalidArgumentException('$content has to be string.');
 		}
-		if ( $expandableContent && ( !is_string( $expandableContent ) ) ) {
-			throw new InvalidArgumentException( '$tooltipContent, if provided, has to be string.' );
+		if ($expandableContent && (!is_string($expandableContent))) {
+			throw new InvalidArgumentException('$tooltipContent, if provided, has to be string.');
 		}
 
-		if ( empty( $expandableContent ) ) {
+		if (empty($expandableContent)) {
 			return $content;
 		}
 
@@ -542,7 +542,7 @@ 
 			$expandableContent
 		);
 
-		return sprintf( '%s %s %s', $content, $tooltipIndicator, $expandableContent );
+		return sprintf('%s %s %s', $content, $tooltipIndicator, $expandableContent);
 	}
 
 	/**
@@ -554,8 +554,8 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatStatus( $status ) {
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
+	private function formatStatus($status) {
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
 		$statusIcons = [
 			CheckResult::STATUS_WARNING => [
 				'icon' => 'non-mandatory-constraint-violation',
@@ -569,25 +569,25 @@ 
 			],
 		];
 
-		if ( array_key_exists( $status, $statusIcons ) ) {
-			$iconWidget = new IconWidget( $statusIcons[$status] );
-			$iconHtml = $iconWidget->toString() . ' ';
+		if (array_key_exists($status, $statusIcons)) {
+			$iconWidget = new IconWidget($statusIcons[$status]);
+			$iconHtml = $iconWidget->toString().' ';
 		} else {
 			$iconHtml = '';
 		}
 
-		$labelWidget = new LabelWidget( [
-			'label' => $this->msg( $messageName )->text(),
-		] );
+		$labelWidget = new LabelWidget([
+			'label' => $this->msg($messageName)->text(),
+		]);
 		$labelHtml = $labelWidget->toString();
 
 		$formattedStatus =
 			Html::rawElement(
 				'span',
 				[
-					'class' => 'wbqc-status wbqc-status-' . $status
+					'class' => 'wbqc-status wbqc-status-'.$status
 				],
-				$iconHtml . $labelHtml
+				$iconHtml.$labelHtml
 			);
 
 		return $formattedStatus;
@@ -603,26 +603,26 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function formatDataValues( $dataValues, $separator = ', ' ) {
-		if ( $dataValues instanceof DataValue ) {
-			$dataValues = [ $dataValues ];
-		} elseif ( !is_array( $dataValues ) ) {
-			throw new InvalidArgumentException( '$dataValues has to be instance of DataValue or an array of DataValues.' );
+	protected function formatDataValues($dataValues, $separator = ', ') {
+		if ($dataValues instanceof DataValue) {
+			$dataValues = [$dataValues];
+		} elseif (!is_array($dataValues)) {
+			throw new InvalidArgumentException('$dataValues has to be instance of DataValue or an array of DataValues.');
 		}
 
 		$formattedDataValues = [];
-		foreach ( $dataValues as $dataValue ) {
-			if ( !( $dataValue instanceof DataValue ) ) {
-				throw new InvalidArgumentException( '$dataValues has to be instance of DataValue or an array of DataValues.' );
+		foreach ($dataValues as $dataValue) {
+			if (!($dataValue instanceof DataValue)) {
+				throw new InvalidArgumentException('$dataValues has to be instance of DataValue or an array of DataValues.');
 			}
-			if ( $dataValue instanceof EntityIdValue ) {
-				$formattedDataValues[ ] = $this->entityIdLabelFormatter->formatEntityId( $dataValue->getEntityId() );
+			if ($dataValue instanceof EntityIdValue) {
+				$formattedDataValues[] = $this->entityIdLabelFormatter->formatEntityId($dataValue->getEntityId());
 			} else {
-				$formattedDataValues[ ] = $this->dataValueFormatter->format( $dataValue );
+				$formattedDataValues[] = $this->dataValueFormatter->format($dataValue);
 			}
 		}
 
-		return implode( $separator, $formattedDataValues );
+		return implode($separator, $formattedDataValues);
 	}
 
 	/**
@@ -634,11 +634,11 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function getClaimLink( EntityId $entityId, PropertyId $propertyId, $text ) {
+	private function getClaimLink(EntityId $entityId, PropertyId $propertyId, $text) {
 		return Html::rawElement(
 			'a',
 			[
-				'href' => $this->getClaimUrl( $entityId, $propertyId ),
+				'href' => $this->getClaimUrl($entityId, $propertyId),
 				'target' => '_blank'
 			],
 			$text
@@ -653,9 +653,9 @@ 
 	 *
 	 * @return string
 	 */
-	private function getClaimUrl( EntityId $entityId, PropertyId $propertyId ) {
-		$title = $this->entityTitleLookup->getTitleForId( $entityId );
-		$entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() );
+	private function getClaimUrl(EntityId $entityId, PropertyId $propertyId) {
+		$title = $this->entityTitleLookup->getTitleForId($entityId);
+		$entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization());
 
 		return $entityUrl;
 	}

src/Api/CheckConstraintParameters.php

Spacing +52 added lines, -52 removed lines

@@ -74,18 +74,18 @@ 
 	 *
 	 * @return self
 	 */
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
 		$constraintReportFactory = ConstraintReportFactory::getDefaultInstance();
 		$repo = WikibaseRepo::getDefaultInstance();
-		$helperFactory = $repo->getApiHelperFactory( RequestContext::getMain() );
+		$helperFactory = $repo->getApiHelperFactory(RequestContext::getMain());
 		$language = $repo->getUserLanguage();
 
 		$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
-		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $language );
+		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($language);
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
 		$valueFormatterFactory = $repo->getValueFormatterFactory();
-		$dataValueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
+		$dataValueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
 		$config = MediaWikiServices::getInstance()->getMainConfig();
 		$violationMessageRenderer = new MultilingualTextViolationMessageRenderer(
 			$entityIdHtmlLinkFormatter,
@@ -125,9 +125,9 @@ 
 		StatementGuidParser $statementGuidParser,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( $main, $name, $prefix );
+		parent::__construct($main, $name, $prefix);
 
-		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->delegatingConstraintChecker = $delegatingConstraintChecker;
 		$this->violationMessageRenderer = $violationMessageRenderer;
 		$this->statementGuidParser = $statementGuidParser;
@@ -142,39 +142,39 @@ 
 		$params = $this->extractRequestParams();
 		$result = $this->getResult();
 
-		$propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] );
-		$constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] );
+		$propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]);
+		$constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]);
 
-		$this->checkPropertyIds( $propertyIds, $result );
-		$this->checkConstraintIds( $constraintIds, $result );
+		$this->checkPropertyIds($propertyIds, $result);
+		$this->checkConstraintIds($constraintIds, $result);
 
-		$result->addValue( null, 'success', 1 );
+		$result->addValue(null, 'success', 1);
 	}
 
 	/**
 	 * @param array|null $propertyIdSerializations
 	 * @return PropertyId[]
 	 */
-	private function parsePropertyIds( $propertyIdSerializations ) {
-		if ( $propertyIdSerializations === null ) {
+	private function parsePropertyIds($propertyIdSerializations) {
+		if ($propertyIdSerializations === null) {
 			return [];
-		} elseif ( empty( $propertyIdSerializations ) ) {
+		} elseif (empty($propertyIdSerializations)) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function( $propertyIdSerialization ) {
+			function($propertyIdSerialization) {
 				try {
-					return new PropertyId( $propertyIdSerialization );
-				} catch ( InvalidArgumentException $e ) {
+					return new PropertyId($propertyIdSerialization);
+				} catch (InvalidArgumentException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid id: $propertyIdSerialization",
 						'invalid-property-id',
 						0, // default argument
-						[ self::PARAM_PROPERTY_ID => $propertyIdSerialization ]
+						[self::PARAM_PROPERTY_ID => $propertyIdSerialization]
 					);
 				}
 			},
@@ -186,35 +186,35 @@ 
 	 * @param array|null $constraintIds
 	 * @return string[]
 	 */
-	private function parseConstraintIds( $constraintIds ) {
-		if ( $constraintIds === null ) {
+	private function parseConstraintIds($constraintIds) {
+		if ($constraintIds === null) {
 			return [];
-		} elseif ( empty( $constraintIds ) ) {
+		} elseif (empty($constraintIds)) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function( $constraintId ) {
+			function($constraintId) {
 				try {
-					$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-					if ( !$propertyId instanceof PropertyId ) {
+					$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+					if (!$propertyId instanceof PropertyId) {
 						$this->apiErrorReporter->dieError(
 							"Invalid property ID: {$propertyId->getSerialization()}",
 							'invalid-property-id',
 							0, // default argument
-							[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+							[self::PARAM_CONSTRAINT_ID => $constraintId]
 						);
 					}
 					return $constraintId;
-				} catch ( StatementGuidParsingException $e ) {
+				} catch (StatementGuidParsingException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid statement GUID: $constraintId",
 						'invalid-guid',
 						0, // default argument
-						[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+						[self::PARAM_CONSTRAINT_ID => $constraintId]
 					);
 				}
 			},
@@ -226,12 +226,12 @@ 
 	 * @param PropertyId[] $propertyIds
 	 * @param ApiResult $result
 	 */
-	private function checkPropertyIds( array $propertyIds, ApiResult $result ) {
-		foreach ( $propertyIds as $propertyId ) {
-			$result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' );
-			$allConstraintExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnPropertyId( $propertyId );
-			foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) {
-				$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+	private function checkPropertyIds(array $propertyIds, ApiResult $result) {
+		foreach ($propertyIds as $propertyId) {
+			$result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc');
+			$allConstraintExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnPropertyId($propertyId);
+			foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) {
+				$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 			}
 		}
 	}
@@ -240,14 +240,14 @@ 
 	 * @param string[] $constraintIds
 	 * @param ApiResult $result
 	 */
-	private function checkConstraintIds( array $constraintIds, ApiResult $result ) {
-		foreach ( $constraintIds as $constraintId ) {
-			if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) {
+	private function checkConstraintIds(array $constraintIds, ApiResult $result) {
+		foreach ($constraintIds as $constraintId) {
+			if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) {
 				// already checked as part of checkPropertyIds()
 				continue;
 			}
-			$constraintParameterExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnConstraintId( $constraintId );
-			$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+			$constraintParameterExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnConstraintId($constraintId);
+			$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 		}
 	}
 
@@ -255,17 +255,17 @@ 
 	 * @param PropertyId $propertyId
 	 * @return string[]
 	 */
-	private function getResultPathForPropertyId( PropertyId $propertyId ) {
-		return [ $this->getModuleName(), $propertyId->getSerialization() ];
+	private function getResultPathForPropertyId(PropertyId $propertyId) {
+		return [$this->getModuleName(), $propertyId->getSerialization()];
 	}
 
 	/**
 	 * @param string $constraintId
 	 * @return string[]
 	 */
-	private function getResultPathForConstraintId( $constraintId ) {
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-		return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] );
+	private function getResultPathForConstraintId($constraintId) {
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+		return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]);
 	}
 
 	/**
@@ -275,9 +275,9 @@ 
 	 * @param ConstraintParameterException[]|null $constraintParameterExceptions
 	 * @param ApiResult $result
 	 */
-	private function addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, ApiResult $result ) {
-		$path = $this->getResultPathForConstraintId( $constraintId );
-		if ( $constraintParameterExceptions === null ) {
+	private function addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, ApiResult $result) {
+		$path = $this->getResultPathForConstraintId($constraintId);
+		if ($constraintParameterExceptions === null) {
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
@@ -287,12 +287,12 @@ 
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
-				empty( $constraintParameterExceptions ) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY
+				empty($constraintParameterExceptions) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY
 			);
 			$result->addValue(
 				$path,
 				self::KEY_PROBLEMS,
-				array_map( [ $this, 'formatConstraintParameterException' ], $constraintParameterExceptions )
+				array_map([$this, 'formatConstraintParameterException'], $constraintParameterExceptions)
 			);
 		}
 	}
@@ -303,7 +303,7 @@ 
 	 * @param ConstraintParameterException $e
 	 * @return string[]
 	 */
-	private function formatConstraintParameterException( ConstraintParameterException $e ) {
+	private function formatConstraintParameterException(ConstraintParameterException $e) {
 		return [
 			self::KEY_MESSAGE_HTML => $this->violationMessageRenderer->render(
 				$e->getViolationMessage()