wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/ContemporaryChecker.php

Spacing +39 added lines, -40 removed lines

@@ -77,7 +77,7 @@ 
 	 * @codeCoverageIgnore This method is purely declarative.
 	 */
 	public function getDefaultContextTypes() {
-		return [ Context::TYPE_STATEMENT ];
+		return [Context::TYPE_STATEMENT];
 	}
 
 	/**
@@ -89,20 +89,20 @@ 
 	 * @return CheckResult
 	 * @throws \ConfigException
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 		$snak = $context->getSnak();
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
-		} elseif ( $snak->getDataValue()->getType() !== 'wikibase-entityid' ) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
+		} elseif ($snak->getDataValue()->getType() !== 'wikibase-entityid') {
 			// wrong data type
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var EntityId $subjectId */
 		$subjectId = $context->getEntity()->getId();
@@ -111,11 +111,11 @@ 
 		/** @var Statement[] $subjectStatements */
 		$subjectStatements = $context->getEntity()->getStatements()->toArray();
 		/** @var Statement[] $objectStatements */
-		$objectStatements = $this->entityLookup->getEntity( $objectId )->getStatements()->toArray();
+		$objectStatements = $this->entityLookup->getEntity($objectId)->getStatements()->toArray();
 		/** @var String[] $startPropertyIds */
-		$startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
+		$startPropertyIds = $this->config->get(self::CONFIG_VARIABLE_START_PROPERTY_IDS);
 		/** @var String[] $endPropertyIds */
-		$endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );
+		$endPropertyIds = $this->config->get(self::CONFIG_VARIABLE_END_PROPERTY_IDS);
 		$subjectStartValue = $this->getExtremeValue(
 			$startPropertyIds,
 			$subjectStatements,
@@ -137,15 +137,15 @@ 
 			'end'
 		);
 		if (
-			$this->rangeCheckerHelper->getComparison( $subjectStartValue, $subjectEndValue ) <= 0 &&
-			$this->rangeCheckerHelper->getComparison( $objectStartValue, $objectEndValue ) <= 0 && (
-				$this->rangeCheckerHelper->getComparison( $subjectEndValue, $objectStartValue ) < 0 ||
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectStartValue ) < 0
+			$this->rangeCheckerHelper->getComparison($subjectStartValue, $subjectEndValue) <= 0 &&
+			$this->rangeCheckerHelper->getComparison($objectStartValue, $objectEndValue) <= 0 && (
+				$this->rangeCheckerHelper->getComparison($subjectEndValue, $objectStartValue) < 0 ||
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectStartValue) < 0
 			)
 		) {
 			if (
 				$subjectEndValue == null ||
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectEndValue ) < 0
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectEndValue) < 0
 			) {
 				$earlierEntityId = $objectId;
 				$minEndValue = $objectEndValue;
@@ -168,7 +168,7 @@ 
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
-		return new CheckResult( $context, $constraint, [], $status, $message );
+		return new CheckResult($context, $constraint, [], $status, $message);
 	}
 
 	/**
@@ -178,19 +178,19 @@ 
 	 *
 	 * @return DataValue|null
 	 */
-	private function getExtremeValue( $extremePropertyIds, $statements, $startOrEnd ) {
-		if ( $startOrEnd !== 'start' && $startOrEnd !== 'end' ) {
-			throw new \InvalidArgumentException( '$startOrEnd must be \'start\' or \'end\'.' );
+	private function getExtremeValue($extremePropertyIds, $statements, $startOrEnd) {
+		if ($startOrEnd !== 'start' && $startOrEnd !== 'end') {
+			throw new \InvalidArgumentException('$startOrEnd must be \'start\' or \'end\'.');
 		}
 		$extremeValue = null;
-		foreach ( $extremePropertyIds as $extremePropertyId ) {
-			$statementList = new StatementList( $statements );
-			$extremeStatements = $statementList->getByPropertyId( new PropertyId( $extremePropertyId ) );
+		foreach ($extremePropertyIds as $extremePropertyId) {
+			$statementList = new StatementList($statements);
+			$extremeStatements = $statementList->getByPropertyId(new PropertyId($extremePropertyId));
 			/** @var Statement $extremeStatement */
-			foreach ( $extremeStatements as $extremeStatement ) {
-				if ( $extremeStatement->getRank() !== Statement::RANK_DEPRECATED ) {
+			foreach ($extremeStatements as $extremeStatement) {
+				if ($extremeStatement->getRank() !== Statement::RANK_DEPRECATED) {
 					$snak = $extremeStatement->getMainSnak();
-					if ( !$snak instanceof PropertyValueSnak ) {
+					if (!$snak instanceof PropertyValueSnak) {
 						return null;
 					} else {
 						$comparison = $this->rangeCheckerHelper->getComparison(
@@ -199,8 +199,8 @@ 
 						);
 						if (
 							$extremeValue === null ||
-							( $startOrEnd === 'start' && $comparison < 0 ) ||
-							( $startOrEnd === 'end' && $comparison > 0 )
+							($startOrEnd === 'start' && $comparison < 0) ||
+							($startOrEnd === 'end' && $comparison > 0)
 						) {
 							$extremeValue = $snak->getDataValue();
 						}
@@ -230,17 +230,16 @@ 
 		DataValue $maxStartValue
 	) {
 		$messageKey = $earlierEntityId === $subjectId ?
-			'wbqc-violation-message-contemporary-subject-earlier' :
-			'wbqc-violation-message-contemporary-value-earlier';
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $subjectId, Role::SUBJECT )
-			->withEntityId( $propertyId, Role::PREDICATE )
-			->withEntityId( $objectId, Role::OBJECT )
-			->withDataValue( $minEndValue, Role::OBJECT )
-			->withDataValue( $maxStartValue, Role::OBJECT );
+			'wbqc-violation-message-contemporary-subject-earlier' : 'wbqc-violation-message-contemporary-value-earlier';
+		return (new ViolationMessage($messageKey))
+			->withEntityId($subjectId, Role::SUBJECT)
+			->withEntityId($propertyId, Role::PREDICATE)
+			->withEntityId($objectId, Role::OBJECT)
+			->withDataValue($minEndValue, Role::OBJECT)
+			->withDataValue($maxStartValue, Role::OBJECT);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintReportFactory.php

Spacing +47 added lines, -47 removed lines

@@ -137,7 +137,7 @@ 
 	public static function getDefaultInstance() {
 		static $instance = null;
 
-		if ( $instance === null ) {
+		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 			$config = MediaWikiServices::getInstance()->getMainConfig();
 			$titleParser = MediaWikiServices::getInstance()->getTitleParser();
@@ -183,7 +183,7 @@ 
 	 * @return DelegatingConstraintChecker
 	 */
 	public function getConstraintChecker() {
-		if ( $this->delegatingConstraintChecker === null ) {
+		if ($this->delegatingConstraintChecker === null) {
 			$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
 				$this->lookup,
 				$this->getConstraintCheckerMap(),
@@ -191,9 +191,9 @@ 
 				ConstraintsServices::getConstraintParameterParser(),
 				$this->statementGuidParser,
 				ConstraintsServices::getLoggingHelper(),
-				$this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
-				$this->config->get( 'WBQualityConstraintsCheckReferences' ),
-				$this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+				$this->config->get('WBQualityConstraintsCheckQualifiers'),
+				$this->config->get('WBQualityConstraintsCheckReferences'),
+				$this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 			);
 		}
 
@@ -204,126 +204,126 @@ 
 	 * @return ConstraintChecker[]
 	 */
 	private function getConstraintCheckerMap() {
-		if ( $this->constraintCheckerMap === null ) {
+		if ($this->constraintCheckerMap === null) {
 			$this->constraintCheckerMap = [
-				$this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
+				$this->config->get('WBQualityConstraintsConflictsWithConstraintId')
 					=> new ConflictsWithChecker(
 						$this->lookup,
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getConnectionCheckerHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
 					=> new ItemChecker(
 						$this->lookup,
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getConnectionCheckerHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
 					=> new TargetRequiredClaimChecker(
 						$this->lookup,
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getConnectionCheckerHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
+				$this->config->get('WBQualityConstraintsSymmetricConstraintId')
 					=> new SymmetricChecker(
 						$this->lookup,
 						ConstraintsServices::getConnectionCheckerHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsInverseConstraintId' )
+				$this->config->get('WBQualityConstraintsInverseConstraintId')
 					=> new InverseChecker(
 						$this->lookup,
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getConnectionCheckerHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
 					=> new QualifierChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
 					=> new QualifiersChecker(
 						ConstraintsServices::getConstraintParameterParser()
 					),
-				$this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
 					=> new MandatoryQualifiersChecker(
 						ConstraintsServices::getConstraintParameterParser()
 					),
-				$this->config->get( 'WBQualityConstraintsRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsRangeConstraintId')
 					=> new RangeChecker(
 						$this->propertyDataTypeLookup,
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getRangeCheckerHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
 					=> new DiffWithinRangeChecker(
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getRangeCheckerHelper(),
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsTypeConstraintId')
 					=> new TypeChecker(
 						$this->lookup,
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getTypeCheckerHelper(),
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsValueTypeConstraintId')
 					=> new ValueTypeChecker(
 						$this->lookup,
 						ConstraintsServices::getConstraintParameterParser(),
 						ConstraintsServices::getTypeCheckerHelper(),
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
-					=> new SingleValueChecker( ConstraintsServices::getConstraintParameterParser() ),
-				$this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
-					=> new MultiValueChecker( ConstraintsServices::getConstraintParameterParser() ),
-				$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleValueConstraintId')
+					=> new SingleValueChecker(ConstraintsServices::getConstraintParameterParser()),
+				$this->config->get('WBQualityConstraintsMultiValueConstraintId')
+					=> new MultiValueChecker(ConstraintsServices::getConstraintParameterParser()),
+				$this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
 					=> new UniqueValueChecker(
 						ConstraintsServices::getSparqlHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsFormatConstraintId' )
+				$this->config->get('WBQualityConstraintsFormatConstraintId')
 					=> new FormatChecker(
 						ConstraintsServices::getConstraintParameterParser(),
 						$this->config,
 						ConstraintsServices::getSparqlHelper()
 					),
-				$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
+				$this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
 					=> new CommonsLinkChecker(
 						ConstraintsServices::getConstraintParameterParser(),
 						$this->titleParser
 					),
-				$this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsOneOfConstraintId')
 					=> new OneOfChecker(
 						ConstraintsServices::getConstraintParameterParser()
 					),
-				$this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
 					=> new ValueOnlyChecker(),
-				$this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
 					=> new ReferenceChecker(),
-				$this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
+				$this->config->get('WBQualityConstraintsNoBoundsConstraintId')
 					=> new NoBoundsChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
 					=> new AllowedUnitsChecker(
 						ConstraintsServices::getConstraintParameterParser(),
 						$this->unitConverter
 					),
-				$this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
-					=> new SingleBestValueChecker( ConstraintsServices::getConstraintParameterParser() ),
-				$this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
+					=> new SingleBestValueChecker(ConstraintsServices::getConstraintParameterParser()),
+				$this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
 					=> new EntityTypeChecker(
 						ConstraintsServices::getConstraintParameterParser()
 					),
-				$this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsNoneOfConstraintId')
 					=> new NoneOfChecker(
 						ConstraintsServices::getConstraintParameterParser()
 					),
-				$this->config->get( 'WBQualityConstraintsIntegerConstraintId' )
+				$this->config->get('WBQualityConstraintsIntegerConstraintId')
 					=> new IntegerChecker(),
-				$this->config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
+				$this->config->get('WBQualityConstraintsCitationNeededConstraintId')
 					=> new CitationNeededChecker(),
-				$this->config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
+				$this->config->get('WBQualityConstraintsPropertyScopeConstraintId')
 					=> new PropertyScopeChecker(
 						ConstraintsServices::getConstraintParameterParser()
 					),
-				$this->config->get( 'WBQualityConstraintsContemporaryConstraintId' )
+				$this->config->get('WBQualityConstraintsContemporaryConstraintId')
 					=> new ContemporaryChecker(
 						$this->lookup,
 						ConstraintsServices::getRangeCheckerHelper(),
@@ -339,7 +339,7 @@ 
 	 * @return WikiPageEntityMetaDataAccessor
 	 */
 	public function getWikiPageEntityMetaDataAccessor() {
-		if ( $this->wikiPageEntityMetaDataAccessor === null ) {
+		if ($this->wikiPageEntityMetaDataAccessor === null) {
 			$this->wikiPageEntityMetaDataAccessor = new WikiPageEntityMetaDataLookup(
 				$this->entityNamespaceLookup
 			);
@@ -352,12 +352,12 @@ 
 	 * @return ResultsSource
 	 */
 	public function getResultsSource() {
-		if ( $this->resultsSource === null ) {
+		if ($this->resultsSource === null) {
 			$this->resultsSource = new CheckingResultsSource(
 				$this->getConstraintChecker()
 			);
 
-			if ( $this->config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+			if ($this->config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 				$this->resultsSource = new CachingResultsSource(
 					$this->resultsSource,
 					ResultsCache::getDefaultInstance(),
@@ -365,9 +365,9 @@ 
 					ConstraintsServices::getCheckResultDeserializer(),
 					$this->getWikiPageEntityMetaDataAccessor(),
 					$this->entityIdParser,
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
 					$this->getPossiblyStaleConstraintTypes(),
-					$this->config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
+					$this->config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
 					ConstraintsServices::getLoggingHelper()
 				);
 			}
@@ -381,10 +381,10 @@ 
 	 */
 	public function getPossiblyStaleConstraintTypes() {
 		return [
-			$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
-			$this->config->get( 'WBQualityConstraintsTypeConstraintId' ),
-			$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
-			$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
+			$this->config->get('WBQualityConstraintsCommonsLinkConstraintId'),
+			$this->config->get('WBQualityConstraintsTypeConstraintId'),
+			$this->config->get('WBQualityConstraintsValueTypeConstraintId'),
+			$this->config->get('WBQualityConstraintsDistinctValuesConstraintId'),
 		];
 	}
 

src/ConstraintsServices.php

Spacing +31 added lines, -31 removed lines

@@ -38,107 +38,107 @@ 
 	const ENTITY_LOOKUP = 'WBQC_EntityLookup';
 	const PROPERTY_DATA_TYPE_LOOKUP = 'WBQC_PropertyDataTypeLookup';
 
-	private static function getService( MediaWikiServices $services = null, $name ) {
-		if ( $services === null ) {
+	private static function getService(MediaWikiServices $services = null, $name) {
+		if ($services === null) {
 			$services = MediaWikiServices::getInstance();
 		}
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return LoggingHelper
 	 */
-	public static function getLoggingHelper( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::LOGGING_HELPER );
+	public static function getLoggingHelper(MediaWikiServices $services = null) {
+		return self::getService($services, self::LOGGING_HELPER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintRepository
 	 */
-	public static function getConstraintRepository( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONSTRAINT_REPOSITORY );
+	public static function getConstraintRepository(MediaWikiServices $services = null) {
+		return self::getService($services, self::CONSTRAINT_REPOSITORY);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintLookup
 	 */
-	public static function getConstraintLookup( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONSTRAINT_LOOKUP );
+	public static function getConstraintLookup(MediaWikiServices $services = null) {
+		return self::getService($services, self::CONSTRAINT_LOOKUP);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return CheckResultSerializer
 	 */
-	public static function getCheckResultSerializer( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CHECK_RESULT_SERIALIZER );
+	public static function getCheckResultSerializer(MediaWikiServices $services = null) {
+		return self::getService($services, self::CHECK_RESULT_SERIALIZER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return CheckResultDeserializer
 	 */
-	public static function getCheckResultDeserializer( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CHECK_RESULT_DESERIALIZER );
+	public static function getCheckResultDeserializer(MediaWikiServices $services = null) {
+		return self::getService($services, self::CHECK_RESULT_DESERIALIZER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ViolationMessageSerializer
 	 */
-	public static function getViolationMessageSerializer( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER );
+	public static function getViolationMessageSerializer(MediaWikiServices $services = null) {
+		return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ViolationMessageDeserializer
 	 */
-	public static function getViolationMessageDeserializer( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER );
+	public static function getViolationMessageDeserializer(MediaWikiServices $services = null) {
+		return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintParameterParser
 	 */
-	public static function getConstraintParameterParser( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER );
+	public static function getConstraintParameterParser(MediaWikiServices $services = null) {
+		return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConnectionCheckerHelper
 	 */
-	public static function getConnectionCheckerHelper( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONNECTION_CHECKER_HELPER );
+	public static function getConnectionCheckerHelper(MediaWikiServices $services = null) {
+		return self::getService($services, self::CONNECTION_CHECKER_HELPER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return RangeCheckerHelper
 	 */
-	public static function getRangeCheckerHelper( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::RANGE_CHECKER_HELPER );
+	public static function getRangeCheckerHelper(MediaWikiServices $services = null) {
+		return self::getService($services, self::RANGE_CHECKER_HELPER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return SparqlHelper
 	 */
-	public static function getSparqlHelper( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::SPARQL_HELPER );
+	public static function getSparqlHelper(MediaWikiServices $services = null) {
+		return self::getService($services, self::SPARQL_HELPER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return TypeCheckerHelper
 	 */
-	public static function getTypeCheckerHelper( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::TYPE_CHECKER_HELPER );
+	public static function getTypeCheckerHelper(MediaWikiServices $services = null) {
+		return self::getService($services, self::TYPE_CHECKER_HELPER);
 	}
 
 	// the below services really belong in WikibaseRepo, but we need them wired up here for now
@@ -147,16 +147,16 @@ 
 	 * @param MediaWikiServices|null $services
 	 * @return EntityLookup
 	 */
-	public static function getEntityLookup( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ENTITY_LOOKUP );
+	public static function getEntityLookup(MediaWikiServices $services = null) {
+		return self::getService($services, self::ENTITY_LOOKUP);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return PropertyDataTypeLookup
 	 */
-	public static function getPropertyDataTypeLookup( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::PROPERTY_DATA_TYPE_LOOKUP );
+	public static function getPropertyDataTypeLookup(MediaWikiServices $services = null) {
+		return self::getService($services, self::PROPERTY_DATA_TYPE_LOOKUP);
 	}
 
 }

src/ServiceWiring.php

Spacing +23 added lines, -23 removed lines

@@ -20,24 +20,24 @@ 
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
 
 return [
-	ConstraintsServices::LOGGING_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) {
 		return new LoggingHelper(
 			$services->getStatsdDataFactory(),
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_REPOSITORY => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONSTRAINT_REPOSITORY => function(MediaWikiServices $services) {
 		return new ConstraintRepository();
 	},
 
-	ConstraintsServices::CONSTRAINT_LOOKUP => function( MediaWikiServices $services ) {
-		$constraintRepository = ConstraintsServices::getConstraintRepository( $services );
-		return new CachingConstraintLookup( $constraintRepository );
+	ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) {
+		$constraintRepository = ConstraintsServices::getConstraintRepository($services);
+		return new CachingConstraintLookup($constraintRepository);
 	},
 
-	ConstraintsServices::CHECK_RESULT_SERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) {
 		return new CheckResultSerializer(
 			new ConstraintSerializer(
 				false // constraint parameters are not exposed
@@ -48,7 +48,7 @@ 
 		);
 	},
 
-	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) {
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$entityIdParser = $repo->getEntityIdParser();
@@ -65,11 +65,11 @@ 
 		);
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) {
 		return new ViolationMessageSerializer();
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) {
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$entityIdParser = $repo->getEntityIdParser();
@@ -81,7 +81,7 @@ 
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) {
 		// TODO in the future, get DeserializerFactory and concept base URIs from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$deserializerFactory = $repo->getBaseDataModelDeserializerFactory();
@@ -94,11 +94,11 @@ 
 		);
 	},
 
-	ConstraintsServices::CONNECTION_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONNECTION_CHECKER_HELPER => function(MediaWikiServices $services) {
 		return new ConnectionCheckerHelper();
 	},
 
-	ConstraintsServices::RANGE_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::RANGE_CHECKER_HELPER => function(MediaWikiServices $services) {
 		// TODO in the future, get UnitConverter from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$unitConverter = $repo->getUnitConverter();
@@ -109,9 +109,9 @@ 
 		);
 	},
 
-	ConstraintsServices::SPARQL_HELPER => function( MediaWikiServices $services ) {
-		$endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' );
-		if ( $endpoint === '' ) {
+	ConstraintsServices::SPARQL_HELPER => function(MediaWikiServices $services) {
+		$endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint');
+		if ($endpoint === '') {
 			return new DummySparqlHelper();
 		}
 
@@ -127,28 +127,28 @@ 
 			$entityIdParser,
 			$propertyDataTypeLookup,
 			$services->getMainWANObjectCache(),
-			ConstraintsServices::getViolationMessageSerializer( $services ),
-			ConstraintsServices::getViolationMessageDeserializer( $services ),
+			ConstraintsServices::getViolationMessageSerializer($services),
+			ConstraintsServices::getViolationMessageDeserializer($services),
 			$services->getStatsdDataFactory()
 		);
 	},
 
-	ConstraintsServices::TYPE_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::TYPE_CHECKER_HELPER => function(MediaWikiServices $services) {
 		return new TypeCheckerHelper(
-			ConstraintsServices::getEntityLookup( $services ),
+			ConstraintsServices::getEntityLookup($services),
 			$services->getMainConfig(),
-			ConstraintsServices::getSparqlHelper( $services ),
+			ConstraintsServices::getSparqlHelper($services),
 			$services->getStatsdDataFactory()
 		);
 	},
 
 	// the below services really belong in WikibaseRepo, but we need them wired up here for now
 
-	ConstraintsServices::ENTITY_LOOKUP => function( MediaWikiServices $services ) {
+	ConstraintsServices::ENTITY_LOOKUP => function(MediaWikiServices $services) {
 		return WikibaseRepo::getDefaultInstance()->getEntityLookup();
 	},
 
-	ConstraintsServices::PROPERTY_DATA_TYPE_LOOKUP => function( MediaWikiServices $services ) {
+	ConstraintsServices::PROPERTY_DATA_TYPE_LOOKUP => function(MediaWikiServices $services) {
 		return WikibaseRepo::getDefaultInstance()->getPropertyDataTypeLookup();
 	},
 ];