wikimedia /
mediawiki-extensions-WikibaseQualityConstraints
@@ -30,53 +30,53 @@ discard block |
||
| 30 | 30 | use WikiMap; |
| 31 | 31 | |
| 32 | 32 | return [ |
| 33 | - ConstraintsServices::EXPIRY_LOCK => static function ( MediaWikiServices $services ) { |
|
| 34 | - return new ExpiryLock( ObjectCache::getInstance( CACHE_ANYTHING ) ); |
|
| 33 | + ConstraintsServices::EXPIRY_LOCK => static function(MediaWikiServices $services) { |
|
| 34 | + return new ExpiryLock(ObjectCache::getInstance(CACHE_ANYTHING)); |
|
| 35 | 35 | }, |
| 36 | 36 | |
| 37 | - ConstraintsServices::LOGGING_HELPER => static function ( MediaWikiServices $services ) { |
|
| 37 | + ConstraintsServices::LOGGING_HELPER => static function(MediaWikiServices $services) { |
|
| 38 | 38 | return new LoggingHelper( |
| 39 | 39 | $services->getStatsdDataFactory(), |
| 40 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' ), |
|
| 40 | + LoggerFactory::getInstance('WikibaseQualityConstraints'), |
|
| 41 | 41 | $services->getMainConfig() |
| 42 | 42 | ); |
| 43 | 43 | }, |
| 44 | 44 | |
| 45 | - ConstraintsServices::CONSTRAINT_STORE => static function ( MediaWikiServices $services ) { |
|
| 46 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
| 47 | - $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE ); |
|
| 48 | - if ( $propertySource === null ) { |
|
| 49 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' ); |
|
| 45 | + ConstraintsServices::CONSTRAINT_STORE => static function(MediaWikiServices $services) { |
|
| 46 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
| 47 | + $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE); |
|
| 48 | + if ($propertySource === null) { |
|
| 49 | + throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.'); |
|
| 50 | 50 | } |
| 51 | 51 | |
| 52 | - $localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName(); |
|
| 53 | - if ( $propertySource->getSourceName() !== $localEntitySourceName ) { |
|
| 54 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for a non local entity source.' ); |
|
| 52 | + $localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName(); |
|
| 53 | + if ($propertySource->getSourceName() !== $localEntitySourceName) { |
|
| 54 | + throw new RuntimeException('Can\'t get a ConstraintStore for a non local entity source.'); |
|
| 55 | 55 | } |
| 56 | 56 | |
| 57 | 57 | $dbName = $propertySource->getDatabaseName(); |
| 58 | 58 | return new ConstraintRepositoryStore( |
| 59 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
| 59 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
| 60 | 60 | $dbName |
| 61 | 61 | ); |
| 62 | 62 | }, |
| 63 | 63 | |
| 64 | - ConstraintsServices::CONSTRAINT_LOOKUP => static function ( MediaWikiServices $services ) { |
|
| 65 | - $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
| 66 | - $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType( Property::ENTITY_TYPE ); |
|
| 67 | - if ( $propertySource === null ) { |
|
| 68 | - throw new RuntimeException( 'Can\'t get a ConstraintStore for properties not stored in a database.' ); |
|
| 64 | + ConstraintsServices::CONSTRAINT_LOOKUP => static function(MediaWikiServices $services) { |
|
| 65 | + $sourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
| 66 | + $propertySource = $sourceDefinitions->getDatabaseSourceForEntityType(Property::ENTITY_TYPE); |
|
| 67 | + if ($propertySource === null) { |
|
| 68 | + throw new RuntimeException('Can\'t get a ConstraintStore for properties not stored in a database.'); |
|
| 69 | 69 | } |
| 70 | 70 | |
| 71 | 71 | $dbName = $propertySource->getDatabaseName(); |
| 72 | 72 | $rawLookup = new ConstraintRepositoryLookup( |
| 73 | - $services->getDBLoadBalancerFactory()->getMainLB( $dbName ), |
|
| 73 | + $services->getDBLoadBalancerFactory()->getMainLB($dbName), |
|
| 74 | 74 | $dbName |
| 75 | 75 | ); |
| 76 | - return new CachingConstraintLookup( $rawLookup ); |
|
| 76 | + return new CachingConstraintLookup($rawLookup); |
|
| 77 | 77 | }, |
| 78 | 78 | |
| 79 | - ConstraintsServices::CHECK_RESULT_SERIALIZER => static function ( MediaWikiServices $services ) { |
|
| 79 | + ConstraintsServices::CHECK_RESULT_SERIALIZER => static function(MediaWikiServices $services) { |
|
| 80 | 80 | return new CheckResultSerializer( |
| 81 | 81 | new ConstraintSerializer( |
| 82 | 82 | false // constraint parameters are not exposed |
@@ -87,9 +87,9 @@ discard block |
||
| 87 | 87 | ); |
| 88 | 88 | }, |
| 89 | 89 | |
| 90 | - ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function ( MediaWikiServices $services ) { |
|
| 91 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
| 92 | - $dataValueFactory = WikibaseRepo::getDataValueFactory( $services ); |
|
| 90 | + ConstraintsServices::CHECK_RESULT_DESERIALIZER => static function(MediaWikiServices $services) { |
|
| 91 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
| 92 | + $dataValueFactory = WikibaseRepo::getDataValueFactory($services); |
|
| 93 | 93 | |
| 94 | 94 | return new CheckResultDeserializer( |
| 95 | 95 | new ConstraintDeserializer(), |
@@ -102,13 +102,13 @@ discard block |
||
| 102 | 102 | ); |
| 103 | 103 | }, |
| 104 | 104 | |
| 105 | - ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function ( MediaWikiServices $services ) { |
|
| 105 | + ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => static function(MediaWikiServices $services) { |
|
| 106 | 106 | return new ViolationMessageSerializer(); |
| 107 | 107 | }, |
| 108 | 108 | |
| 109 | - ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function ( MediaWikiServices $services ) { |
|
| 110 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
| 111 | - $dataValueFactory = WikibaseRepo::getDataValueFactory( $services ); |
|
| 109 | + ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => static function(MediaWikiServices $services) { |
|
| 110 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
| 111 | + $dataValueFactory = WikibaseRepo::getDataValueFactory($services); |
|
| 112 | 112 | |
| 113 | 113 | return new ViolationMessageDeserializer( |
| 114 | 114 | $entityIdParser, |
@@ -116,37 +116,37 @@ discard block |
||
| 116 | 116 | ); |
| 117 | 117 | }, |
| 118 | 118 | |
| 119 | - ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function ( MediaWikiServices $services ) { |
|
| 120 | - $deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory( $services ); |
|
| 121 | - $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions( $services ); |
|
| 119 | + ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => static function(MediaWikiServices $services) { |
|
| 120 | + $deserializerFactory = WikibaseRepo::getBaseDataModelDeserializerFactory($services); |
|
| 121 | + $entitySourceDefinitions = WikibaseRepo::getEntitySourceDefinitions($services); |
|
| 122 | 122 | |
| 123 | 123 | return new ConstraintParameterParser( |
| 124 | 124 | $services->getMainConfig(), |
| 125 | 125 | $deserializerFactory, |
| 126 | - $entitySourceDefinitions->getDatabaseSourceForEntityType( 'item' )->getConceptBaseUri() |
|
| 126 | + $entitySourceDefinitions->getDatabaseSourceForEntityType('item')->getConceptBaseUri() |
|
| 127 | 127 | ); |
| 128 | 128 | }, |
| 129 | 129 | |
| 130 | - ConstraintsServices::CONNECTION_CHECKER_HELPER => static function ( MediaWikiServices $services ) { |
|
| 130 | + ConstraintsServices::CONNECTION_CHECKER_HELPER => static function(MediaWikiServices $services) { |
|
| 131 | 131 | return new ConnectionCheckerHelper(); |
| 132 | 132 | }, |
| 133 | 133 | |
| 134 | - ConstraintsServices::RANGE_CHECKER_HELPER => static function ( MediaWikiServices $services ) { |
|
| 134 | + ConstraintsServices::RANGE_CHECKER_HELPER => static function(MediaWikiServices $services) { |
|
| 135 | 135 | return new RangeCheckerHelper( |
| 136 | 136 | $services->getMainConfig(), |
| 137 | - WikibaseRepo::getUnitConverter( $services ) |
|
| 137 | + WikibaseRepo::getUnitConverter($services) |
|
| 138 | 138 | ); |
| 139 | 139 | }, |
| 140 | 140 | |
| 141 | - ConstraintsServices::SPARQL_HELPER => static function ( MediaWikiServices $services ) { |
|
| 142 | - $endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' ); |
|
| 143 | - if ( $endpoint === '' ) { |
|
| 141 | + ConstraintsServices::SPARQL_HELPER => static function(MediaWikiServices $services) { |
|
| 142 | + $endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint'); |
|
| 143 | + if ($endpoint === '') { |
|
| 144 | 144 | return new DummySparqlHelper(); |
| 145 | 145 | } |
| 146 | 146 | |
| 147 | - $rdfVocabulary = WikibaseRepo::getRdfVocabulary( $services ); |
|
| 148 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
| 149 | - $propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup( $services ); |
|
| 147 | + $rdfVocabulary = WikibaseRepo::getRdfVocabulary($services); |
|
| 148 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
| 149 | + $propertyDataTypeLookup = WikibaseRepo::getPropertyDataTypeLookup($services); |
|
| 150 | 150 | |
| 151 | 151 | return new SparqlHelper( |
| 152 | 152 | $services->getMainConfig(), |
@@ -154,126 +154,126 @@ discard block |
||
| 154 | 154 | $entityIdParser, |
| 155 | 155 | $propertyDataTypeLookup, |
| 156 | 156 | $services->getMainWANObjectCache(), |
| 157 | - ConstraintsServices::getViolationMessageSerializer( $services ), |
|
| 158 | - ConstraintsServices::getViolationMessageDeserializer( $services ), |
|
| 157 | + ConstraintsServices::getViolationMessageSerializer($services), |
|
| 158 | + ConstraintsServices::getViolationMessageDeserializer($services), |
|
| 159 | 159 | $services->getStatsdDataFactory(), |
| 160 | - ConstraintsServices::getExpiryLock( $services ), |
|
| 161 | - ConstraintsServices::getLoggingHelper( $services ), |
|
| 162 | - WikiMap::getCurrentWikiId() . ' WikibaseQualityConstraints ' . Http::userAgent(), |
|
| 160 | + ConstraintsServices::getExpiryLock($services), |
|
| 161 | + ConstraintsServices::getLoggingHelper($services), |
|
| 162 | + WikiMap::getCurrentWikiId().' WikibaseQualityConstraints '.Http::userAgent(), |
|
| 163 | 163 | $services->getHttpRequestFactory() |
| 164 | 164 | ); |
| 165 | 165 | }, |
| 166 | 166 | |
| 167 | - ConstraintsServices::TYPE_CHECKER_HELPER => static function ( MediaWikiServices $services ) { |
|
| 167 | + ConstraintsServices::TYPE_CHECKER_HELPER => static function(MediaWikiServices $services) { |
|
| 168 | 168 | return new TypeCheckerHelper( |
| 169 | - WikibaseServices::getEntityLookup( $services ), |
|
| 169 | + WikibaseServices::getEntityLookup($services), |
|
| 170 | 170 | $services->getMainConfig(), |
| 171 | - ConstraintsServices::getSparqlHelper( $services ), |
|
| 171 | + ConstraintsServices::getSparqlHelper($services), |
|
| 172 | 172 | $services->getStatsdDataFactory() |
| 173 | 173 | ); |
| 174 | 174 | }, |
| 175 | 175 | |
| 176 | - ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function ( MediaWikiServices $services ) { |
|
| 177 | - $statementGuidParser = WikibaseRepo::getStatementGuidParser( $services ); |
|
| 176 | + ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => static function(MediaWikiServices $services) { |
|
| 177 | + $statementGuidParser = WikibaseRepo::getStatementGuidParser($services); |
|
| 178 | 178 | |
| 179 | 179 | $config = $services->getMainConfig(); |
| 180 | 180 | $checkerMap = [ |
| 181 | - $config->get( 'WBQualityConstraintsConflictsWithConstraintId' ) |
|
| 182 | - => ConstraintCheckerServices::getConflictsWithChecker( $services ), |
|
| 183 | - $config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' ) |
|
| 184 | - => ConstraintCheckerServices::getItemChecker( $services ), |
|
| 185 | - $config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' ) |
|
| 186 | - => ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ), |
|
| 187 | - $config->get( 'WBQualityConstraintsSymmetricConstraintId' ) |
|
| 188 | - => ConstraintCheckerServices::getSymmetricChecker( $services ), |
|
| 189 | - $config->get( 'WBQualityConstraintsInverseConstraintId' ) |
|
| 190 | - => ConstraintCheckerServices::getInverseChecker( $services ), |
|
| 191 | - $config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' ) |
|
| 192 | - => ConstraintCheckerServices::getQualifierChecker( $services ), |
|
| 193 | - $config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' ) |
|
| 194 | - => ConstraintCheckerServices::getQualifiersChecker( $services ), |
|
| 195 | - $config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' ) |
|
| 196 | - => ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ), |
|
| 197 | - $config->get( 'WBQualityConstraintsRangeConstraintId' ) |
|
| 198 | - => ConstraintCheckerServices::getRangeChecker( $services ), |
|
| 199 | - $config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' ) |
|
| 200 | - => ConstraintCheckerServices::getDiffWithinRangeChecker( $services ), |
|
| 201 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ) |
|
| 202 | - => ConstraintCheckerServices::getTypeChecker( $services ), |
|
| 203 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ) |
|
| 204 | - => ConstraintCheckerServices::getValueTypeChecker( $services ), |
|
| 205 | - $config->get( 'WBQualityConstraintsSingleValueConstraintId' ) |
|
| 206 | - => ConstraintCheckerServices::getSingleValueChecker( $services ), |
|
| 207 | - $config->get( 'WBQualityConstraintsMultiValueConstraintId' ) |
|
| 208 | - => ConstraintCheckerServices::getMultiValueChecker( $services ), |
|
| 209 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ) |
|
| 210 | - => ConstraintCheckerServices::getUniqueValueChecker( $services ), |
|
| 211 | - $config->get( 'WBQualityConstraintsFormatConstraintId' ) |
|
| 212 | - => ConstraintCheckerServices::getFormatChecker( $services ), |
|
| 213 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ) |
|
| 214 | - => ConstraintCheckerServices::getCommonsLinkChecker( $services ), |
|
| 215 | - $config->get( 'WBQualityConstraintsOneOfConstraintId' ) |
|
| 216 | - => ConstraintCheckerServices::getOneOfChecker( $services ), |
|
| 217 | - $config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' ) |
|
| 218 | - => ConstraintCheckerServices::getValueOnlyChecker( $services ), |
|
| 219 | - $config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' ) |
|
| 220 | - => ConstraintCheckerServices::getReferenceChecker( $services ), |
|
| 221 | - $config->get( 'WBQualityConstraintsNoBoundsConstraintId' ) |
|
| 222 | - => ConstraintCheckerServices::getNoBoundsChecker( $services ), |
|
| 223 | - $config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' ) |
|
| 224 | - => ConstraintCheckerServices::getAllowedUnitsChecker( $services ), |
|
| 225 | - $config->get( 'WBQualityConstraintsSingleBestValueConstraintId' ) |
|
| 226 | - => ConstraintCheckerServices::getSingleBestValueChecker( $services ), |
|
| 227 | - $config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' ) |
|
| 228 | - => ConstraintCheckerServices::getEntityTypeChecker( $services ), |
|
| 229 | - $config->get( 'WBQualityConstraintsNoneOfConstraintId' ) |
|
| 230 | - => ConstraintCheckerServices::getNoneOfChecker( $services ), |
|
| 231 | - $config->get( 'WBQualityConstraintsIntegerConstraintId' ) |
|
| 232 | - => ConstraintCheckerServices::getIntegerChecker( $services ), |
|
| 233 | - $config->get( 'WBQualityConstraintsCitationNeededConstraintId' ) |
|
| 234 | - => ConstraintCheckerServices::getCitationNeededChecker( $services ), |
|
| 235 | - $config->get( 'WBQualityConstraintsPropertyScopeConstraintId' ) |
|
| 236 | - => ConstraintCheckerServices::getPropertyScopeChecker( $services ), |
|
| 237 | - $config->get( 'WBQualityConstraintsContemporaryConstraintId' ) |
|
| 238 | - => ConstraintCheckerServices::getContemporaryChecker( $services ), |
|
| 239 | - $config->get( 'WBQualityConstraintsLexemeLanguageConstraintId' ) |
|
| 240 | - => ConstraintCheckerServices::getLexemeLanguageChecker( $services ), |
|
| 241 | - $config->get( 'WBQualityConstraintsLabelInLanguageConstraintId' ) |
|
| 242 | - => ConstraintCheckerServices::getLabelInLanguageChecker( $services ), |
|
| 181 | + $config->get('WBQualityConstraintsConflictsWithConstraintId') |
|
| 182 | + => ConstraintCheckerServices::getConflictsWithChecker($services), |
|
| 183 | + $config->get('WBQualityConstraintsItemRequiresClaimConstraintId') |
|
| 184 | + => ConstraintCheckerServices::getItemChecker($services), |
|
| 185 | + $config->get('WBQualityConstraintsValueRequiresClaimConstraintId') |
|
| 186 | + => ConstraintCheckerServices::getTargetRequiredClaimChecker($services), |
|
| 187 | + $config->get('WBQualityConstraintsSymmetricConstraintId') |
|
| 188 | + => ConstraintCheckerServices::getSymmetricChecker($services), |
|
| 189 | + $config->get('WBQualityConstraintsInverseConstraintId') |
|
| 190 | + => ConstraintCheckerServices::getInverseChecker($services), |
|
| 191 | + $config->get('WBQualityConstraintsUsedAsQualifierConstraintId') |
|
| 192 | + => ConstraintCheckerServices::getQualifierChecker($services), |
|
| 193 | + $config->get('WBQualityConstraintsAllowedQualifiersConstraintId') |
|
| 194 | + => ConstraintCheckerServices::getQualifiersChecker($services), |
|
| 195 | + $config->get('WBQualityConstraintsMandatoryQualifierConstraintId') |
|
| 196 | + => ConstraintCheckerServices::getMandatoryQualifiersChecker($services), |
|
| 197 | + $config->get('WBQualityConstraintsRangeConstraintId') |
|
| 198 | + => ConstraintCheckerServices::getRangeChecker($services), |
|
| 199 | + $config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId') |
|
| 200 | + => ConstraintCheckerServices::getDiffWithinRangeChecker($services), |
|
| 201 | + $config->get('WBQualityConstraintsTypeConstraintId') |
|
| 202 | + => ConstraintCheckerServices::getTypeChecker($services), |
|
| 203 | + $config->get('WBQualityConstraintsValueTypeConstraintId') |
|
| 204 | + => ConstraintCheckerServices::getValueTypeChecker($services), |
|
| 205 | + $config->get('WBQualityConstraintsSingleValueConstraintId') |
|
| 206 | + => ConstraintCheckerServices::getSingleValueChecker($services), |
|
| 207 | + $config->get('WBQualityConstraintsMultiValueConstraintId') |
|
| 208 | + => ConstraintCheckerServices::getMultiValueChecker($services), |
|
| 209 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId') |
|
| 210 | + => ConstraintCheckerServices::getUniqueValueChecker($services), |
|
| 211 | + $config->get('WBQualityConstraintsFormatConstraintId') |
|
| 212 | + => ConstraintCheckerServices::getFormatChecker($services), |
|
| 213 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId') |
|
| 214 | + => ConstraintCheckerServices::getCommonsLinkChecker($services), |
|
| 215 | + $config->get('WBQualityConstraintsOneOfConstraintId') |
|
| 216 | + => ConstraintCheckerServices::getOneOfChecker($services), |
|
| 217 | + $config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId') |
|
| 218 | + => ConstraintCheckerServices::getValueOnlyChecker($services), |
|
| 219 | + $config->get('WBQualityConstraintsUsedAsReferenceConstraintId') |
|
| 220 | + => ConstraintCheckerServices::getReferenceChecker($services), |
|
| 221 | + $config->get('WBQualityConstraintsNoBoundsConstraintId') |
|
| 222 | + => ConstraintCheckerServices::getNoBoundsChecker($services), |
|
| 223 | + $config->get('WBQualityConstraintsAllowedUnitsConstraintId') |
|
| 224 | + => ConstraintCheckerServices::getAllowedUnitsChecker($services), |
|
| 225 | + $config->get('WBQualityConstraintsSingleBestValueConstraintId') |
|
| 226 | + => ConstraintCheckerServices::getSingleBestValueChecker($services), |
|
| 227 | + $config->get('WBQualityConstraintsAllowedEntityTypesConstraintId') |
|
| 228 | + => ConstraintCheckerServices::getEntityTypeChecker($services), |
|
| 229 | + $config->get('WBQualityConstraintsNoneOfConstraintId') |
|
| 230 | + => ConstraintCheckerServices::getNoneOfChecker($services), |
|
| 231 | + $config->get('WBQualityConstraintsIntegerConstraintId') |
|
| 232 | + => ConstraintCheckerServices::getIntegerChecker($services), |
|
| 233 | + $config->get('WBQualityConstraintsCitationNeededConstraintId') |
|
| 234 | + => ConstraintCheckerServices::getCitationNeededChecker($services), |
|
| 235 | + $config->get('WBQualityConstraintsPropertyScopeConstraintId') |
|
| 236 | + => ConstraintCheckerServices::getPropertyScopeChecker($services), |
|
| 237 | + $config->get('WBQualityConstraintsContemporaryConstraintId') |
|
| 238 | + => ConstraintCheckerServices::getContemporaryChecker($services), |
|
| 239 | + $config->get('WBQualityConstraintsLexemeLanguageConstraintId') |
|
| 240 | + => ConstraintCheckerServices::getLexemeLanguageChecker($services), |
|
| 241 | + $config->get('WBQualityConstraintsLabelInLanguageConstraintId') |
|
| 242 | + => ConstraintCheckerServices::getLabelInLanguageChecker($services), |
|
| 243 | 243 | ]; |
| 244 | 244 | |
| 245 | 245 | return new DelegatingConstraintChecker( |
| 246 | - WikibaseServices::getEntityLookup( $services ), |
|
| 246 | + WikibaseServices::getEntityLookup($services), |
|
| 247 | 247 | $checkerMap, |
| 248 | - ConstraintsServices::getConstraintLookup( $services ), |
|
| 249 | - ConstraintsServices::getConstraintParameterParser( $services ), |
|
| 248 | + ConstraintsServices::getConstraintLookup($services), |
|
| 249 | + ConstraintsServices::getConstraintParameterParser($services), |
|
| 250 | 250 | $statementGuidParser, |
| 251 | - ConstraintsServices::getLoggingHelper( $services ), |
|
| 252 | - $config->get( 'WBQualityConstraintsCheckQualifiers' ), |
|
| 253 | - $config->get( 'WBQualityConstraintsCheckReferences' ), |
|
| 254 | - $config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' ) |
|
| 251 | + ConstraintsServices::getLoggingHelper($services), |
|
| 252 | + $config->get('WBQualityConstraintsCheckQualifiers'), |
|
| 253 | + $config->get('WBQualityConstraintsCheckReferences'), |
|
| 254 | + $config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers') |
|
| 255 | 255 | ); |
| 256 | 256 | }, |
| 257 | 257 | |
| 258 | - ConstraintsServices::RESULTS_SOURCE => static function ( MediaWikiServices $services ) { |
|
| 258 | + ConstraintsServices::RESULTS_SOURCE => static function(MediaWikiServices $services) { |
|
| 259 | 259 | $config = $services->getMainConfig(); |
| 260 | 260 | $resultsSource = new CheckingResultsSource( |
| 261 | - ConstraintsServices::getDelegatingConstraintChecker( $services ) |
|
| 261 | + ConstraintsServices::getDelegatingConstraintChecker($services) |
|
| 262 | 262 | ); |
| 263 | 263 | |
| 264 | 264 | $cacheCheckConstraintsResults = false; |
| 265 | 265 | |
| 266 | - if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) { |
|
| 266 | + if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) { |
|
| 267 | 267 | $cacheCheckConstraintsResults = true; |
| 268 | 268 | // check that we can use getLocalRepoWikiPageMetaDataAccessor() |
| 269 | 269 | // TODO we should always be able to cache constraint check results (T244726) |
| 270 | - $entitySources = WikibaseRepo::getEntitySourceDefinitions( $services )->getSources(); |
|
| 271 | - $localEntitySourceName = WikibaseRepo::getLocalEntitySource( $services )->getSourceName(); |
|
| 270 | + $entitySources = WikibaseRepo::getEntitySourceDefinitions($services)->getSources(); |
|
| 271 | + $localEntitySourceName = WikibaseRepo::getLocalEntitySource($services)->getSourceName(); |
|
| 272 | 272 | |
| 273 | - foreach ( $entitySources as $entitySource ) { |
|
| 274 | - if ( $entitySource->getSourceName() !== $localEntitySourceName ) { |
|
| 275 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' )->warning( |
|
| 276 | - 'Cannot cache constraint check results for non-local source: ' . |
|
| 273 | + foreach ($entitySources as $entitySource) { |
|
| 274 | + if ($entitySource->getSourceName() !== $localEntitySourceName) { |
|
| 275 | + LoggerFactory::getInstance('WikibaseQualityConstraints')->warning( |
|
| 276 | + 'Cannot cache constraint check results for non-local source: '. |
|
| 277 | 277 | $entitySource->getSourceName() |
| 278 | 278 | ); |
| 279 | 279 | $cacheCheckConstraintsResults = false; |
@@ -282,28 +282,28 @@ discard block |
||
| 282 | 282 | } |
| 283 | 283 | } |
| 284 | 284 | |
| 285 | - if ( $cacheCheckConstraintsResults ) { |
|
| 285 | + if ($cacheCheckConstraintsResults) { |
|
| 286 | 286 | $possiblyStaleConstraintTypes = [ |
| 287 | - $config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ), |
|
| 288 | - $config->get( 'WBQualityConstraintsTypeConstraintId' ), |
|
| 289 | - $config->get( 'WBQualityConstraintsValueTypeConstraintId' ), |
|
| 290 | - $config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ), |
|
| 287 | + $config->get('WBQualityConstraintsCommonsLinkConstraintId'), |
|
| 288 | + $config->get('WBQualityConstraintsTypeConstraintId'), |
|
| 289 | + $config->get('WBQualityConstraintsValueTypeConstraintId'), |
|
| 290 | + $config->get('WBQualityConstraintsDistinctValuesConstraintId'), |
|
| 291 | 291 | ]; |
| 292 | - $entityIdParser = WikibaseRepo::getEntityIdParser( $services ); |
|
| 292 | + $entityIdParser = WikibaseRepo::getEntityIdParser($services); |
|
| 293 | 293 | $wikiPageEntityMetaDataAccessor = WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor( |
| 294 | 294 | $services ); |
| 295 | 295 | |
| 296 | 296 | $resultsSource = new CachingResultsSource( |
| 297 | 297 | $resultsSource, |
| 298 | 298 | ResultsCache::getDefaultInstance(), |
| 299 | - ConstraintsServices::getCheckResultSerializer( $services ), |
|
| 300 | - ConstraintsServices::getCheckResultDeserializer( $services ), |
|
| 299 | + ConstraintsServices::getCheckResultSerializer($services), |
|
| 300 | + ConstraintsServices::getCheckResultDeserializer($services), |
|
| 301 | 301 | $wikiPageEntityMetaDataAccessor, |
| 302 | 302 | $entityIdParser, |
| 303 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ), |
|
| 303 | + $config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'), |
|
| 304 | 304 | $possiblyStaleConstraintTypes, |
| 305 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ), |
|
| 306 | - ConstraintsServices::getLoggingHelper( $services ) |
|
| 305 | + $config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'), |
|
| 306 | + ConstraintsServices::getLoggingHelper($services) |
|
| 307 | 307 | ); |
| 308 | 308 | } |
| 309 | 309 | |
@@ -38,8 +38,8 @@ discard block |
||
| 38 | 38 | */ |
| 39 | 39 | private const BATCH_SIZE = 50; |
| 40 | 40 | |
| 41 | - public static function newFromGlobalState( Title $title, array $params ) { |
|
| 42 | - Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' ); |
|
| 41 | + public static function newFromGlobalState(Title $title, array $params) { |
|
| 42 | + Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]'); |
|
| 43 | 43 | $services = MediaWikiServices::getInstance(); |
| 44 | 44 | return new UpdateConstraintsTableJob( |
| 45 | 45 | $title, |
@@ -49,8 +49,8 @@ discard block |
||
| 49 | 49 | $services->getMainConfig(), |
| 50 | 50 | ConstraintsServices::getConstraintStore(), |
| 51 | 51 | $services->getDBLoadBalancerFactory(), |
| 52 | - WikibaseRepo::getStore()->getEntityRevisionLookup( Store::LOOKUP_CACHING_DISABLED ), |
|
| 53 | - WikibaseRepo::getBaseDataModelSerializerFactory( $services ) |
|
| 52 | + WikibaseRepo::getStore()->getEntityRevisionLookup(Store::LOOKUP_CACHING_DISABLED), |
|
| 53 | + WikibaseRepo::getBaseDataModelSerializerFactory($services) |
|
| 54 | 54 | ->newSnakSerializer() |
| 55 | 55 | ); |
| 56 | 56 | } |
@@ -110,7 +110,7 @@ discard block |
||
| 110 | 110 | EntityRevisionLookup $entityRevisionLookup, |
| 111 | 111 | Serializer $snakSerializer |
| 112 | 112 | ) { |
| 113 | - parent::__construct( 'constraintsTableUpdate', $title, $params ); |
|
| 113 | + parent::__construct('constraintsTableUpdate', $title, $params); |
|
| 114 | 114 | |
| 115 | 115 | $this->propertyId = $propertyId; |
| 116 | 116 | $this->revisionId = $revisionId; |
@@ -121,11 +121,11 @@ discard block |
||
| 121 | 121 | $this->snakSerializer = $snakSerializer; |
| 122 | 122 | } |
| 123 | 123 | |
| 124 | - public function extractParametersFromQualifiers( SnakList $qualifiers ) { |
|
| 124 | + public function extractParametersFromQualifiers(SnakList $qualifiers) { |
|
| 125 | 125 | $parameters = []; |
| 126 | - foreach ( $qualifiers as $qualifier ) { |
|
| 126 | + foreach ($qualifiers as $qualifier) { |
|
| 127 | 127 | $qualifierId = $qualifier->getPropertyId()->getSerialization(); |
| 128 | - $paramSerialization = $this->snakSerializer->serialize( $qualifier ); |
|
| 128 | + $paramSerialization = $this->snakSerializer->serialize($qualifier); |
|
| 129 | 129 | $parameters[$qualifierId][] = $paramSerialization; |
| 130 | 130 | } |
| 131 | 131 | return $parameters; |
@@ -142,7 +142,7 @@ discard block |
||
| 142 | 142 | '@phan-var \Wikibase\DataModel\Entity\EntityIdValue $dataValue'; |
| 143 | 143 | $entityId = $dataValue->getEntityId(); |
| 144 | 144 | $constraintTypeQid = $entityId->getSerialization(); |
| 145 | - $parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() ); |
|
| 145 | + $parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers()); |
|
| 146 | 146 | return new Constraint( |
| 147 | 147 | $constraintId, |
| 148 | 148 | $propertyId, |
@@ -157,25 +157,25 @@ discard block |
||
| 157 | 157 | NumericPropertyId $propertyConstraintPropertyId |
| 158 | 158 | ) { |
| 159 | 159 | $constraintsStatements = $property->getStatements() |
| 160 | - ->getByPropertyId( $propertyConstraintPropertyId ) |
|
| 161 | - ->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] ); |
|
| 160 | + ->getByPropertyId($propertyConstraintPropertyId) |
|
| 161 | + ->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]); |
|
| 162 | 162 | $constraints = []; |
| 163 | - foreach ( $constraintsStatements->getIterator() as $constraintStatement ) { |
|
| 163 | + foreach ($constraintsStatements->getIterator() as $constraintStatement) { |
|
| 164 | 164 | // @phan-suppress-next-line PhanTypeMismatchArgumentSuperType |
| 165 | - $constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement ); |
|
| 166 | - if ( count( $constraints ) >= self::BATCH_SIZE ) { |
|
| 167 | - $constraintStore->insertBatch( $constraints ); |
|
| 165 | + $constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement); |
|
| 166 | + if (count($constraints) >= self::BATCH_SIZE) { |
|
| 167 | + $constraintStore->insertBatch($constraints); |
|
| 168 | 168 | // interrupt transaction and wait for replication |
| 169 | - $connection = $this->lbFactory->getMainLB()->getConnection( DB_PRIMARY ); |
|
| 170 | - $connection->endAtomic( __CLASS__ ); |
|
| 171 | - if ( !$connection->explicitTrxActive() ) { |
|
| 169 | + $connection = $this->lbFactory->getMainLB()->getConnection(DB_PRIMARY); |
|
| 170 | + $connection->endAtomic(__CLASS__); |
|
| 171 | + if (!$connection->explicitTrxActive()) { |
|
| 172 | 172 | $this->lbFactory->waitForReplication(); |
| 173 | 173 | } |
| 174 | - $connection->startAtomic( __CLASS__ ); |
|
| 174 | + $connection->startAtomic(__CLASS__); |
|
| 175 | 175 | $constraints = []; |
| 176 | 176 | } |
| 177 | 177 | } |
| 178 | - $constraintStore->insertBatch( $constraints ); |
|
| 178 | + $constraintStore->insertBatch($constraints); |
|
| 179 | 179 | } |
| 180 | 180 | |
| 181 | 181 | /** |
@@ -186,24 +186,24 @@ discard block |
||
| 186 | 186 | public function run() { |
| 187 | 187 | // TODO in the future: only touch constraints affected by the edit (requires T163465) |
| 188 | 188 | |
| 189 | - $propertyId = new NumericPropertyId( $this->propertyId ); |
|
| 189 | + $propertyId = new NumericPropertyId($this->propertyId); |
|
| 190 | 190 | $propertyRevision = $this->entityRevisionLookup->getEntityRevision( |
| 191 | 191 | $propertyId, |
| 192 | 192 | 0, // latest |
| 193 | 193 | LookupConstants::LATEST_FROM_REPLICA |
| 194 | 194 | ); |
| 195 | 195 | |
| 196 | - if ( $this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId ) { |
|
| 197 | - JobQueueGroup::singleton()->push( $this ); |
|
| 196 | + if ($this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId) { |
|
| 197 | + JobQueueGroup::singleton()->push($this); |
|
| 198 | 198 | return true; |
| 199 | 199 | } |
| 200 | 200 | |
| 201 | - $connection = $this->lbFactory->getMainLB()->getConnection( DB_PRIMARY ); |
|
| 201 | + $connection = $this->lbFactory->getMainLB()->getConnection(DB_PRIMARY); |
|
| 202 | 202 | // start transaction (if not started yet) – using __CLASS__, not __METHOD__, |
| 203 | 203 | // because importConstraintsForProperty() can interrupt the transaction |
| 204 | - $connection->startAtomic( __CLASS__ ); |
|
| 204 | + $connection->startAtomic(__CLASS__); |
|
| 205 | 205 | |
| 206 | - $this->constraintStore->deleteForProperty( $propertyId ); |
|
| 206 | + $this->constraintStore->deleteForProperty($propertyId); |
|
| 207 | 207 | |
| 208 | 208 | /** @var Property $property */ |
| 209 | 209 | $property = $propertyRevision->getEntity(); |
@@ -211,10 +211,10 @@ discard block |
||
| 211 | 211 | $this->importConstraintsForProperty( |
| 212 | 212 | $property, |
| 213 | 213 | $this->constraintStore, |
| 214 | - new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ) |
|
| 214 | + new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')) |
|
| 215 | 215 | ); |
| 216 | 216 | |
| 217 | - $connection->endAtomic( __CLASS__ ); |
|
| 217 | + $connection->endAtomic(__CLASS__); |
|
| 218 | 218 | |
| 219 | 219 | return true; |
| 220 | 220 | } |
