Completed
Push — master ( ca406a...abda46 )
by
unknown
01:56
created

ConstraintRepositoryStore   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 70
Duplicated Lines 12.86 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 5
lcom 1
cbo 2
dl 9
loc 70
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A encodeConstraintParameters() 0 9 2
A insertBatch() 0 16 1
A deleteForProperty() 9 9 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace WikibaseQuality\ConstraintReport;
4
5
use Wikibase\DataModel\Entity\PropertyId;
6
use Wikimedia\Rdbms\DBUnexpectedError;
7
use Wikimedia\Rdbms\ILoadBalancer;
8
9
/**
10
 * @author BP2014N1
11
 * @license GPL-2.0-or-later
12
 */
13
class ConstraintRepositoryStore implements ConstraintStore {
14
15
	/** @var ILoadBalancer */
16
	private $lb;
17
18
	/** @var string|false */
19
	private $dbName;
20
21
	/**
22
	 * @param ILoadBalancer $lb Load balancer for database connections.
23
	 * Must match $dbName, i.e. if $dbName is not false,
24
	 * then using the main DBLoadBalancer service may be incorrect.
25
	 * @param string|false $dbName Database name ($domain for ILoadBalancer methods).
26
	 */
27
	public function __construct( ILoadBalancer $lb, $dbName ) {
28
		$this->lb = $lb;
29
		$this->dbName = $dbName;
30
	}
31
32
	private function encodeConstraintParameters( array $constraintParameters ) {
33
		$json = json_encode( $constraintParameters, JSON_FORCE_OBJECT );
34
35
		if ( strlen( $json ) > 50000 ) {
36
			$json = json_encode( [ '@error' => [ 'toolong' => true ] ] );
37
		}
38
39
		return $json;
40
	}
41
42
	/**
43
	 * @param Constraint[] $constraints
44
	 *
45
	 * @throws DBUnexpectedError
46
	 * @return bool
47
	 */
48
	public function insertBatch( array $constraints ) {
49
		$accumulator = array_map(
50
			function ( Constraint $constraint ) {
51
				return [
52
					'constraint_guid' => $constraint->getConstraintId(),
53
					'pid' => $constraint->getPropertyId()->getNumericId(),
54
					'constraint_type_qid' => $constraint->getConstraintTypeItemId(),
55
					'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() )
56
				];
57
			},
58
			$constraints
59
		);
60
61
		$dbw = $this->lb->getConnection( ILoadBalancer::DB_MASTER, [], $this->dbName );
62
		return $dbw->insert( 'wbqc_constraints', $accumulator );
63
	}
64
65
	/**
66
	 * Delete all constraints for the property ID.
67
	 *
68
	 * @param PropertyId $propertyId
69
	 *
70
	 * @throws DBUnexpectedError
71
	 */
72 View Code Duplication
	public function deleteForProperty( PropertyId $propertyId ) {
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
73
		$dbw = $this->lb->getConnection( ILoadBalancer::DB_MASTER, [], $this->dbName );
74
		$dbw->delete(
75
			'wbqc_constraints',
76
			[
77
				'pid' => $propertyId->getNumericId(),
78
			]
79
		);
80
	}
81
82
}
83