@@ -44,16 +44,16 @@ |
||
44 | 44 | * |
45 | 45 | * @return CheckResult |
46 | 46 | */ |
47 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
48 | - if ( $context->getType() === Context::TYPE_QUALIFIER ) { |
|
49 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE ); |
|
47 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
48 | + if ($context->getType() === Context::TYPE_QUALIFIER) { |
|
49 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE); |
|
50 | 50 | } else { |
51 | - $message = new ViolationMessage( 'wbqc-violation-message-qualifier' ); |
|
52 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
51 | + $message = new ViolationMessage('wbqc-violation-message-qualifier'); |
|
52 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
53 | 53 | } |
54 | 54 | } |
55 | 55 | |
56 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
56 | + public function checkConstraintParameters(Constraint $constraint) { |
|
57 | 57 | // no parameters |
58 | 58 | return []; |
59 | 59 | } |
@@ -46,7 +46,7 @@ discard block |
||
46 | 46 | return self::ALL_ENTITY_TYPES_SUPPORTED; |
47 | 47 | } |
48 | 48 | |
49 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
49 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
50 | 50 | $constraintParameters = $constraint->getConstraintParameters(); |
51 | 51 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
52 | 52 | |
@@ -55,7 +55,7 @@ discard block |
||
55 | 55 | $constraintTypeItemId |
56 | 56 | ); |
57 | 57 | |
58 | - if ( in_array( $context->getType(), $allowedContextTypes ) ) { |
|
58 | + if (in_array($context->getType(), $allowedContextTypes)) { |
|
59 | 59 | return new CheckResult( |
60 | 60 | $context->getCursor(), |
61 | 61 | $constraint, |
@@ -66,15 +66,15 @@ discard block |
||
66 | 66 | $context->getCursor(), |
67 | 67 | $constraint, |
68 | 68 | CheckResult::STATUS_VIOLATION, |
69 | - ( new ViolationMessage( 'wbqc-violation-message-property-scope' ) ) |
|
70 | - ->withEntityId( $context->getSnak()->getPropertyId() ) |
|
71 | - ->withPropertyScope( $context->getType() ) |
|
72 | - ->withPropertyScopeList( $allowedContextTypes ) |
|
69 | + (new ViolationMessage('wbqc-violation-message-property-scope')) |
|
70 | + ->withEntityId($context->getSnak()->getPropertyId()) |
|
71 | + ->withPropertyScope($context->getType()) |
|
72 | + ->withPropertyScopeList($allowedContextTypes) |
|
73 | 73 | ); |
74 | 74 | } |
75 | 75 | } |
76 | 76 | |
77 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
77 | + public function checkConstraintParameters(Constraint $constraint) { |
|
78 | 78 | $constraintParameters = $constraint->getConstraintParameters(); |
79 | 79 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
80 | 80 | $exceptions = []; |
@@ -83,7 +83,7 @@ discard block |
||
83 | 83 | $constraintParameters, |
84 | 84 | $constraintTypeItemId |
85 | 85 | ); |
86 | - } catch ( ConstraintParameterException $e ) { |
|
86 | + } catch (ConstraintParameterException $e) { |
|
87 | 87 | $exceptions[] = $e; |
88 | 88 | } |
89 | 89 | return $exceptions; |
@@ -64,9 +64,9 @@ discard block |
||
64 | 64 | * @throws ConstraintParameterException |
65 | 65 | * @return CheckResult |
66 | 66 | */ |
67 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
68 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
69 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED ); |
|
67 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
68 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
69 | + return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED); |
|
70 | 70 | } |
71 | 71 | |
72 | 72 | $separators = $this->constraintParameterParser->parseSeparatorsParameter( |
@@ -75,19 +75,19 @@ discard block |
||
75 | 75 | |
76 | 76 | $propertyId = $context->getSnak()->getPropertyId(); |
77 | 77 | $propertyCount = $this->valueCountCheckerHelper->getPropertyCount( |
78 | - $context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ), |
|
78 | + $context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators), |
|
79 | 79 | $propertyId |
80 | 80 | ); |
81 | 81 | |
82 | - if ( $propertyCount > 1 ) { |
|
83 | - $message = $this->getViolationMessage( $separators, $propertyId ); |
|
82 | + if ($propertyCount > 1) { |
|
83 | + $message = $this->getViolationMessage($separators, $propertyId); |
|
84 | 84 | $status = CheckResult::STATUS_VIOLATION; |
85 | 85 | } else { |
86 | 86 | $message = null; |
87 | 87 | $status = CheckResult::STATUS_COMPLIANCE; |
88 | 88 | } |
89 | 89 | |
90 | - return new CheckResult( $context, $constraint, $status, $message ); |
|
90 | + return new CheckResult($context, $constraint, $status, $message); |
|
91 | 91 | } |
92 | 92 | |
93 | 93 | /** |
@@ -95,22 +95,21 @@ discard block |
||
95 | 95 | * @param PropertyId $propertyId |
96 | 96 | * @return ViolationMessage |
97 | 97 | */ |
98 | - private function getViolationMessage( array $separators, PropertyId $propertyId ) { |
|
98 | + private function getViolationMessage(array $separators, PropertyId $propertyId) { |
|
99 | 99 | $messageKey = $separators === [] ? |
100 | - 'wbqc-violation-message-single-value' : |
|
101 | - 'wbqc-violation-message-single-value-separators'; |
|
100 | + 'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators'; |
|
102 | 101 | |
103 | - return ( new ViolationMessage( $messageKey ) ) |
|
104 | - ->withEntityId( $propertyId ) |
|
105 | - ->withEntityIdList( $separators ); |
|
102 | + return (new ViolationMessage($messageKey)) |
|
103 | + ->withEntityId($propertyId) |
|
104 | + ->withEntityIdList($separators); |
|
106 | 105 | } |
107 | 106 | |
108 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
107 | + public function checkConstraintParameters(Constraint $constraint) { |
|
109 | 108 | $constraintParameters = $constraint->getConstraintParameters(); |
110 | 109 | $exceptions = []; |
111 | 110 | try { |
112 | - $this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters ); |
|
113 | - } catch ( ConstraintParameterException $e ) { |
|
111 | + $this->constraintParameterParser->parseSeparatorsParameter($constraintParameters); |
|
112 | + } catch (ConstraintParameterException $e) { |
|
114 | 113 | $exceptions[] = $e; |
115 | 114 | } |
116 | 115 | return $exceptions; |
@@ -33,16 +33,16 @@ |
||
33 | 33 | return self::ALL_ENTITY_TYPES_SUPPORTED; |
34 | 34 | } |
35 | 35 | |
36 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
37 | - if ( $context->getType() === Context::TYPE_REFERENCE ) { |
|
38 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE ); |
|
36 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
37 | + if ($context->getType() === Context::TYPE_REFERENCE) { |
|
38 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE); |
|
39 | 39 | } else { |
40 | - $message = new ViolationMessage( 'wbqc-violation-message-reference' ); |
|
41 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
40 | + $message = new ViolationMessage('wbqc-violation-message-reference'); |
|
41 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
42 | 42 | } |
43 | 43 | } |
44 | 44 | |
45 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
45 | + public function checkConstraintParameters(Constraint $constraint) { |
|
46 | 46 | // no parameters |
47 | 47 | return []; |
48 | 48 | } |
@@ -76,9 +76,9 @@ discard block |
||
76 | 76 | * @throws ConstraintParameterException |
77 | 77 | * @return CheckResult |
78 | 78 | */ |
79 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
80 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
81 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED ); |
|
79 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
80 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
81 | + return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED); |
|
82 | 82 | } |
83 | 83 | |
84 | 84 | $constraintParameters = $constraint->getConstraintParameters(); |
@@ -97,22 +97,22 @@ discard block |
||
97 | 97 | |
98 | 98 | $statementList = $context->getEntity() |
99 | 99 | ->getStatements() |
100 | - ->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] ); |
|
100 | + ->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]); |
|
101 | 101 | |
102 | 102 | /* |
103 | 103 | * 'Conflicts with' can be defined with |
104 | 104 | * a) a property only |
105 | 105 | * b) a property and a number of items (each combination of property and item forming an individual claim) |
106 | 106 | */ |
107 | - if ( $items === [] ) { |
|
107 | + if ($items === []) { |
|
108 | 108 | $offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty( |
109 | 109 | $statementList, |
110 | 110 | $propertyId |
111 | 111 | ); |
112 | - if ( $offendingStatement !== null ) { |
|
113 | - $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) ) |
|
114 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
115 | - ->withEntityId( $propertyId, Role::PREDICATE ); |
|
112 | + if ($offendingStatement !== null) { |
|
113 | + $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property')) |
|
114 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
115 | + ->withEntityId($propertyId, Role::PREDICATE); |
|
116 | 116 | $status = CheckResult::STATUS_VIOLATION; |
117 | 117 | } else { |
118 | 118 | $message = null; |
@@ -124,12 +124,12 @@ discard block |
||
124 | 124 | $propertyId, |
125 | 125 | $items |
126 | 126 | ); |
127 | - if ( $offendingStatement !== null ) { |
|
128 | - $offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() ); |
|
129 | - $message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) ) |
|
130 | - ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ) |
|
131 | - ->withEntityId( $propertyId, Role::PREDICATE ) |
|
132 | - ->withItemIdSnakValue( $offendingValue, Role::OBJECT ); |
|
127 | + if ($offendingStatement !== null) { |
|
128 | + $offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak()); |
|
129 | + $message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim')) |
|
130 | + ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY) |
|
131 | + ->withEntityId($propertyId, Role::PREDICATE) |
|
132 | + ->withItemIdSnakValue($offendingValue, Role::OBJECT); |
|
133 | 133 | $status = CheckResult::STATUS_VIOLATION; |
134 | 134 | } else { |
135 | 135 | $message = null; |
@@ -137,10 +137,10 @@ discard block |
||
137 | 137 | } |
138 | 138 | } |
139 | 139 | |
140 | - return new CheckResult( $context, $constraint, $status, $message ); |
|
140 | + return new CheckResult($context, $constraint, $status, $message); |
|
141 | 141 | } |
142 | 142 | |
143 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
143 | + public function checkConstraintParameters(Constraint $constraint) { |
|
144 | 144 | $constraintParameters = $constraint->getConstraintParameters(); |
145 | 145 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
146 | 146 | $exceptions = []; |
@@ -149,7 +149,7 @@ discard block |
||
149 | 149 | $constraintParameters, |
150 | 150 | $constraintTypeItemId |
151 | 151 | ); |
152 | - } catch ( ConstraintParameterException $e ) { |
|
152 | + } catch (ConstraintParameterException $e) { |
|
153 | 153 | $exceptions[] = $e; |
154 | 154 | } |
155 | 155 | try { |
@@ -158,7 +158,7 @@ discard block |
||
158 | 158 | $constraintTypeItemId, |
159 | 159 | false |
160 | 160 | ); |
161 | - } catch ( ConstraintParameterException $e ) { |
|
161 | + } catch (ConstraintParameterException $e) { |
|
162 | 162 | $exceptions[] = $e; |
163 | 163 | } |
164 | 164 | return $exceptions; |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker; |
6 | 6 | |
@@ -74,26 +74,26 @@ discard block |
||
74 | 74 | * @return array first element is the namespace number (default namespace for TitleParser), |
75 | 75 | * second element is a string to prepend to the title before giving it to the TitleParser |
76 | 76 | */ |
77 | - private function getCommonsNamespace( string $namespace ): array { |
|
78 | - switch ( $namespace ) { |
|
77 | + private function getCommonsNamespace(string $namespace): array { |
|
78 | + switch ($namespace) { |
|
79 | 79 | case '': |
80 | - return [ NS_MAIN, '' ]; |
|
80 | + return [NS_MAIN, '']; |
|
81 | 81 | // extra namespaces, see operations/mediawiki-config.git, |
82 | 82 | // wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey |
83 | 83 | case 'Creator': |
84 | - return [ 100, '' ]; |
|
84 | + return [100, '']; |
|
85 | 85 | case 'TimedText': |
86 | - return [ 102, '' ]; |
|
86 | + return [102, '']; |
|
87 | 87 | case 'Sequence': |
88 | - return [ 104, '' ]; |
|
88 | + return [104, '']; |
|
89 | 89 | case 'Institution': |
90 | - return [ 106, '' ]; |
|
90 | + return [106, '']; |
|
91 | 91 | // extension namespace, see mediawiki/extensions/JsonConfig.git, |
92 | 92 | // extension.json, 'namespaces' key, third element |
93 | 93 | case 'Data': |
94 | - return [ 486, '' ]; |
|
94 | + return [486, '']; |
|
95 | 95 | default: |
96 | - return [ NS_MAIN, $namespace . ':' ]; |
|
96 | + return [NS_MAIN, $namespace.':']; |
|
97 | 97 | } |
98 | 98 | } |
99 | 99 | |
@@ -102,7 +102,7 @@ discard block |
||
102 | 102 | * |
103 | 103 | * @throws ConstraintParameterException |
104 | 104 | */ |
105 | - public function checkConstraint( Context $context, Constraint $constraint ): CheckResult { |
|
105 | + public function checkConstraint(Context $context, Constraint $constraint): CheckResult { |
|
106 | 106 | $constraintParameters = $constraint->getConstraintParameters(); |
107 | 107 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
108 | 108 | |
@@ -113,9 +113,9 @@ discard block |
||
113 | 113 | |
114 | 114 | $snak = $context->getSnak(); |
115 | 115 | |
116 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
116 | + if (!$snak instanceof PropertyValueSnak) { |
|
117 | 117 | // nothing to check |
118 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE ); |
|
118 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE); |
|
119 | 119 | } |
120 | 120 | |
121 | 121 | $dataValue = $snak->getDataValue(); |
@@ -125,52 +125,52 @@ discard block |
||
125 | 125 | * type of $dataValue for properties with 'Commons link' constraint has to be 'string' |
126 | 126 | * parameter $namespace can be null, works for commons galleries |
127 | 127 | */ |
128 | - if ( $dataValue->getType() !== 'string' ) { |
|
129 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
130 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
131 | - ->withDataValueType( 'string' ); |
|
132 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
128 | + if ($dataValue->getType() !== 'string') { |
|
129 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
130 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
131 | + ->withDataValueType('string'); |
|
132 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
133 | 133 | } |
134 | 134 | |
135 | 135 | $commonsLink = $dataValue->getValue(); |
136 | - if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) { |
|
137 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
138 | - new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) ); |
|
136 | + if (!$this->commonsLinkIsWellFormed($commonsLink)) { |
|
137 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
138 | + new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed')); |
|
139 | 139 | } |
140 | 140 | |
141 | - $dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty( $snak->getPropertyId() ); |
|
142 | - switch ( $dataType ) { |
|
141 | + $dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty($snak->getPropertyId()); |
|
142 | + switch ($dataType) { |
|
143 | 143 | case 'geo-shape': |
144 | 144 | case 'tabular-data': |
145 | - if ( strpos( $commonsLink, $namespace . ':' ) !== 0 ) { |
|
146 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
147 | - new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) ); |
|
145 | + if (strpos($commonsLink, $namespace.':') !== 0) { |
|
146 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
147 | + new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed')); |
|
148 | 148 | } |
149 | 149 | $pageName = $commonsLink; |
150 | 150 | break; |
151 | 151 | default: |
152 | - $pageName = $namespace ? $namespace . ':' . $commonsLink : $commonsLink; |
|
152 | + $pageName = $namespace ? $namespace.':'.$commonsLink : $commonsLink; |
|
153 | 153 | break; |
154 | 154 | } |
155 | 155 | |
156 | - $prefix = $this->getCommonsNamespace( $namespace )[1]; |
|
156 | + $prefix = $this->getCommonsNamespace($namespace)[1]; |
|
157 | 157 | $normalizedTitle = $this->pageNameNormalizer->normalizePageName( |
158 | 158 | $pageName, |
159 | 159 | 'https://commons.wikimedia.org/w/api.php' |
160 | 160 | ); |
161 | - if ( $normalizedTitle === false ) { |
|
162 | - if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) { |
|
163 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
164 | - new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) ); |
|
161 | + if ($normalizedTitle === false) { |
|
162 | + if ($this->valueIncludesNamespace($commonsLink, $namespace)) { |
|
163 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
164 | + new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed')); |
|
165 | 165 | } |
166 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, |
|
167 | - new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' ) ); |
|
166 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, |
|
167 | + new ViolationMessage('wbqc-violation-message-commons-link-no-existent')); |
|
168 | 168 | } |
169 | 169 | |
170 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE, null ); |
|
170 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE, null); |
|
171 | 171 | } |
172 | 172 | |
173 | - public function checkConstraintParameters( Constraint $constraint ): array { |
|
173 | + public function checkConstraintParameters(Constraint $constraint): array { |
|
174 | 174 | $constraintParameters = $constraint->getConstraintParameters(); |
175 | 175 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
176 | 176 | $exceptions = []; |
@@ -179,15 +179,15 @@ discard block |
||
179 | 179 | $constraintParameters, |
180 | 180 | $constraintTypeItemId |
181 | 181 | ); |
182 | - } catch ( ConstraintParameterException $e ) { |
|
182 | + } catch (ConstraintParameterException $e) { |
|
183 | 183 | $exceptions[] = $e; |
184 | 184 | } |
185 | 185 | return $exceptions; |
186 | 186 | } |
187 | 187 | |
188 | - private function commonsLinkIsWellFormed( string $commonsLink ): bool { |
|
189 | - $toReplace = [ "_", "%20" ]; |
|
190 | - $compareString = trim( str_replace( $toReplace, '', $commonsLink ) ); |
|
188 | + private function commonsLinkIsWellFormed(string $commonsLink): bool { |
|
189 | + $toReplace = ["_", "%20"]; |
|
190 | + $compareString = trim(str_replace($toReplace, '', $commonsLink)); |
|
191 | 191 | |
192 | 192 | return $commonsLink === $compareString; |
193 | 193 | } |
@@ -196,9 +196,9 @@ discard block |
||
196 | 196 | * Checks whether the value of the statement already includes the namespace. |
197 | 197 | * This special case should be reported as “malformed title” instead of “title does not exist”. |
198 | 198 | */ |
199 | - private function valueIncludesNamespace( string $value, string $namespace ): bool { |
|
199 | + private function valueIncludesNamespace(string $value, string $namespace): bool { |
|
200 | 200 | return $namespace !== '' && |
201 | - strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0; |
|
201 | + strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0; |
|
202 | 202 | } |
203 | 203 | |
204 | 204 | } |
@@ -32,9 +32,9 @@ discard block |
||
32 | 32 | /** |
33 | 33 | * @param array $headers |
34 | 34 | */ |
35 | - public function __construct( array $headers ) { |
|
36 | - foreach ( $headers as $header ) { |
|
37 | - $this->addHeader( $header ); |
|
35 | + public function __construct(array $headers) { |
|
36 | + foreach ($headers as $header) { |
|
37 | + $this->addHeader($header); |
|
38 | 38 | } |
39 | 39 | } |
40 | 40 | |
@@ -43,16 +43,16 @@ discard block |
||
43 | 43 | * |
44 | 44 | * @throws InvalidArgumentException |
45 | 45 | */ |
46 | - private function addHeader( $header ) { |
|
47 | - Assert::parameterType( [ 'string', HtmlTableHeaderBuilder::class ], $header, '$header' ); |
|
46 | + private function addHeader($header) { |
|
47 | + Assert::parameterType(['string', HtmlTableHeaderBuilder::class], $header, '$header'); |
|
48 | 48 | |
49 | - if ( is_string( $header ) ) { |
|
50 | - $header = new HtmlTableHeaderBuilder( $header ); |
|
49 | + if (is_string($header)) { |
|
50 | + $header = new HtmlTableHeaderBuilder($header); |
|
51 | 51 | } |
52 | 52 | |
53 | 53 | $this->headers[] = $header; |
54 | 54 | |
55 | - if ( $header->getIsSortable() ) { |
|
55 | + if ($header->getIsSortable()) { |
|
56 | 56 | $this->isSortable = true; |
57 | 57 | } |
58 | 58 | } |
@@ -85,12 +85,12 @@ discard block |
||
85 | 85 | * |
86 | 86 | * @throws InvalidArgumentException |
87 | 87 | */ |
88 | - public function appendRow( array $cells ) { |
|
89 | - foreach ( $cells as $key => $cell ) { |
|
90 | - if ( is_string( $cell ) ) { |
|
91 | - $cells[$key] = new HtmlTableCellBuilder( $cell ); |
|
92 | - } elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) { |
|
93 | - throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' ); |
|
88 | + public function appendRow(array $cells) { |
|
89 | + foreach ($cells as $key => $cell) { |
|
90 | + if (is_string($cell)) { |
|
91 | + $cells[$key] = new HtmlTableCellBuilder($cell); |
|
92 | + } elseif (!($cell instanceof HtmlTableCellBuilder)) { |
|
93 | + throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.'); |
|
94 | 94 | } |
95 | 95 | } |
96 | 96 | |
@@ -104,13 +104,13 @@ discard block |
||
104 | 104 | * |
105 | 105 | * @throws InvalidArgumentException |
106 | 106 | */ |
107 | - public function appendRows( array $rows ) { |
|
108 | - foreach ( $rows as $cells ) { |
|
109 | - if ( !is_array( $cells ) ) { |
|
110 | - throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' ); |
|
107 | + public function appendRows(array $rows) { |
|
108 | + foreach ($rows as $cells) { |
|
109 | + if (!is_array($cells)) { |
|
110 | + throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.'); |
|
111 | 111 | } |
112 | 112 | |
113 | - $this->appendRow( $cells ); |
|
113 | + $this->appendRow($cells); |
|
114 | 114 | } |
115 | 115 | } |
116 | 116 | |
@@ -122,38 +122,38 @@ discard block |
||
122 | 122 | public function toHtml() { |
123 | 123 | // Open table |
124 | 124 | $tableClasses = 'wikitable'; |
125 | - if ( $this->isSortable ) { |
|
125 | + if ($this->isSortable) { |
|
126 | 126 | $tableClasses .= ' sortable'; |
127 | 127 | } |
128 | - $html = Html::openElement( 'table', [ 'class' => $tableClasses ] ); |
|
128 | + $html = Html::openElement('table', ['class' => $tableClasses]); |
|
129 | 129 | |
130 | 130 | // Write headers |
131 | - $html .= Html::openElement( 'thead' ); |
|
132 | - $html .= Html::openElement( 'tr' ); |
|
133 | - foreach ( $this->headers as $header ) { |
|
131 | + $html .= Html::openElement('thead'); |
|
132 | + $html .= Html::openElement('tr'); |
|
133 | + foreach ($this->headers as $header) { |
|
134 | 134 | $html .= $header->toHtml(); |
135 | 135 | } |
136 | - $html .= Html::closeElement( 'tr' ); |
|
137 | - $html .= Html::closeElement( 'thead' ); |
|
138 | - $html .= Html::openElement( 'tbody' ); |
|
136 | + $html .= Html::closeElement('tr'); |
|
137 | + $html .= Html::closeElement('thead'); |
|
138 | + $html .= Html::openElement('tbody'); |
|
139 | 139 | |
140 | 140 | // Write rows |
141 | - foreach ( $this->rows as $row ) { |
|
142 | - $html .= Html::openElement( 'tr' ); |
|
141 | + foreach ($this->rows as $row) { |
|
142 | + $html .= Html::openElement('tr'); |
|
143 | 143 | |
144 | 144 | /** |
145 | 145 | * @var HtmlTableCellBuilder $cell |
146 | 146 | */ |
147 | - foreach ( $row as $cell ) { |
|
147 | + foreach ($row as $cell) { |
|
148 | 148 | $html .= $cell->toHtml(); |
149 | 149 | } |
150 | 150 | |
151 | - $html .= Html::closeElement( 'tr' ); |
|
151 | + $html .= Html::closeElement('tr'); |
|
152 | 152 | } |
153 | 153 | |
154 | 154 | // Close table |
155 | - $html .= Html::closeElement( 'tbody' ); |
|
156 | - $html .= Html::closeElement( 'table' ); |
|
155 | + $html .= Html::closeElement('tbody'); |
|
156 | + $html .= Html::closeElement('table'); |
|
157 | 157 | |
158 | 158 | return $html; |
159 | 159 | } |
@@ -31,8 +31,8 @@ discard block |
||
31 | 31 | * |
32 | 32 | * @throws InvalidArgumentException |
33 | 33 | */ |
34 | - public function __construct( $content, array $attributes = [] ) { |
|
35 | - Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' ); |
|
34 | + public function __construct($content, array $attributes = []) { |
|
35 | + Assert::parameterType(['string', HtmlArmor::class], $content, '$content'); |
|
36 | 36 | |
37 | 37 | $this->content = $content; |
38 | 38 | $this->attributes = $attributes; |
@@ -42,7 +42,7 @@ discard block |
||
42 | 42 | * @return string HTML |
43 | 43 | */ |
44 | 44 | public function getContent() { |
45 | - return HtmlArmor::getHtml( $this->content ); |
|
45 | + return HtmlArmor::getHtml($this->content); |
|
46 | 46 | } |
47 | 47 | |
48 | 48 | /** |
@@ -56,7 +56,7 @@ discard block |
||
56 | 56 | * @return string HTML |
57 | 57 | */ |
58 | 58 | public function toHtml() { |
59 | - return Html::rawElement( 'td', $this->getAttributes(), $this->getContent() ); |
|
59 | + return Html::rawElement('td', $this->getAttributes(), $this->getContent()); |
|
60 | 60 | } |
61 | 61 | |
62 | 62 | } |
@@ -26,8 +26,8 @@ discard block |
||
26 | 26 | BeforePageDisplayHook |
27 | 27 | { |
28 | 28 | |
29 | - public static function onWikibaseChange( Change $change ) { |
|
30 | - if ( !( $change instanceof EntityChange ) ) { |
|
29 | + public static function onWikibaseChange(Change $change) { |
|
30 | + if (!($change instanceof EntityChange)) { |
|
31 | 31 | return; |
32 | 32 | } |
33 | 33 | /** @var EntityChange $change */ |
@@ -38,48 +38,48 @@ discard block |
||
38 | 38 | |
39 | 39 | // If jobs are enabled and the results would be stored in some way run a job. |
40 | 40 | if ( |
41 | - $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) && |
|
42 | - $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) && |
|
41 | + $config->get('WBQualityConstraintsEnableConstraintsCheckJobs') && |
|
42 | + $config->get('WBQualityConstraintsCacheCheckConstraintsResults') && |
|
43 | 43 | self::isSelectedForJobRunBasedOnPercentage() |
44 | 44 | ) { |
45 | - $params = [ 'entityId' => $change->getEntityId()->getSerialization() ]; |
|
45 | + $params = ['entityId' => $change->getEntityId()->getSerialization()]; |
|
46 | 46 | $jobQueueGroup->lazyPush( |
47 | - new JobSpecification( CheckConstraintsJob::COMMAND, $params ) |
|
47 | + new JobSpecification(CheckConstraintsJob::COMMAND, $params) |
|
48 | 48 | ); |
49 | 49 | } |
50 | 50 | |
51 | - if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) && |
|
52 | - self::isConstraintStatementsChange( $config, $change ) |
|
51 | + if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') && |
|
52 | + self::isConstraintStatementsChange($config, $change) |
|
53 | 53 | ) { |
54 | - $params = [ 'propertyId' => $change->getEntityId()->getSerialization() ]; |
|
54 | + $params = ['propertyId' => $change->getEntityId()->getSerialization()]; |
|
55 | 55 | $metadata = $change->getMetadata(); |
56 | - if ( array_key_exists( 'rev_id', $metadata ) ) { |
|
56 | + if (array_key_exists('rev_id', $metadata)) { |
|
57 | 57 | $params['revisionId'] = $metadata['rev_id']; |
58 | 58 | } |
59 | 59 | $jobQueueGroup->push( |
60 | - new JobSpecification( 'constraintsTableUpdate', $params ) |
|
60 | + new JobSpecification('constraintsTableUpdate', $params) |
|
61 | 61 | ); |
62 | 62 | } |
63 | 63 | } |
64 | 64 | |
65 | 65 | private static function isSelectedForJobRunBasedOnPercentage() { |
66 | 66 | $config = MediaWikiServices::getInstance()->getMainConfig(); |
67 | - $percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' ); |
|
67 | + $percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio'); |
|
68 | 68 | |
69 | - return mt_rand( 1, 100 ) <= $percentage; |
|
69 | + return mt_rand(1, 100) <= $percentage; |
|
70 | 70 | } |
71 | 71 | |
72 | - public static function isConstraintStatementsChange( Config $config, Change $change ) { |
|
73 | - if ( !( $change instanceof EntityChange ) || |
|
72 | + public static function isConstraintStatementsChange(Config $config, Change $change) { |
|
73 | + if (!($change instanceof EntityChange) || |
|
74 | 74 | $change->getAction() !== EntityChange::UPDATE || |
75 | - !( $change->getEntityId() instanceof NumericPropertyId ) |
|
75 | + !($change->getEntityId() instanceof NumericPropertyId) |
|
76 | 76 | ) { |
77 | 77 | return false; |
78 | 78 | } |
79 | 79 | |
80 | 80 | $info = $change->getInfo(); |
81 | 81 | |
82 | - if ( !array_key_exists( 'compactDiff', $info ) ) { |
|
82 | + if (!array_key_exists('compactDiff', $info)) { |
|
83 | 83 | // the non-compact diff ($info['diff']) does not contain statement diffs (T110996), |
84 | 84 | // so we only know that the change *might* affect the constraint statements |
85 | 85 | return true; |
@@ -88,50 +88,50 @@ discard block |
||
88 | 88 | /** @var EntityDiffChangedAspects $aspects */ |
89 | 89 | $aspects = $info['compactDiff']; |
90 | 90 | |
91 | - $propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' ); |
|
92 | - return in_array( $propertyConstraintId, $aspects->getStatementChanges() ); |
|
91 | + $propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId'); |
|
92 | + return in_array($propertyConstraintId, $aspects->getStatementChanges()); |
|
93 | 93 | } |
94 | 94 | |
95 | - public function onArticlePurge( $wikiPage ) { |
|
95 | + public function onArticlePurge($wikiPage) { |
|
96 | 96 | $entityContentFactory = WikibaseRepo::getEntityContentFactory(); |
97 | - if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) { |
|
97 | + if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) { |
|
98 | 98 | $entityIdLookup = WikibaseRepo::getEntityIdLookup(); |
99 | - $entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() ); |
|
100 | - if ( $entityId !== null ) { |
|
99 | + $entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle()); |
|
100 | + if ($entityId !== null) { |
|
101 | 101 | $resultsCache = ResultsCache::getDefaultInstance(); |
102 | - $resultsCache->delete( $entityId ); |
|
102 | + $resultsCache->delete($entityId); |
|
103 | 103 | } |
104 | 104 | } |
105 | 105 | } |
106 | 106 | |
107 | - public function onBeforePageDisplay( $out, $skin ): void { |
|
107 | + public function onBeforePageDisplay($out, $skin): void { |
|
108 | 108 | $lookup = WikibaseRepo::getEntityNamespaceLookup(); |
109 | 109 | $title = $out->getTitle(); |
110 | - if ( $title === null ) { |
|
110 | + if ($title === null) { |
|
111 | 111 | return; |
112 | 112 | } |
113 | 113 | |
114 | - if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) { |
|
114 | + if (!$lookup->isNamespaceWithEntities($title->getNamespace())) { |
|
115 | 115 | return; |
116 | 116 | } |
117 | - if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) { |
|
117 | + if (empty($out->getJsConfigVars()['wbIsEditView'])) { |
|
118 | 118 | return; |
119 | 119 | } |
120 | 120 | |
121 | 121 | $services = MediaWikiServices::getInstance(); |
122 | 122 | $config = $services->getMainConfig(); |
123 | 123 | |
124 | - $isMobileView = ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) && |
|
125 | - $services->getService( 'MobileFrontend.Context' )->shouldDisplayMobileView(); |
|
126 | - if ( $isMobileView ) { |
|
124 | + $isMobileView = ExtensionRegistry::getInstance()->isLoaded('MobileFrontend') && |
|
125 | + $services->getService('MobileFrontend.Context')->shouldDisplayMobileView(); |
|
126 | + if ($isMobileView) { |
|
127 | 127 | return; |
128 | 128 | } |
129 | 129 | |
130 | - $out->addModules( 'wikibase.quality.constraints.suggestions' ); |
|
130 | + $out->addModules('wikibase.quality.constraints.suggestions'); |
|
131 | 131 | |
132 | - if ( $config->get( 'WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers' ) |
|
133 | - || $out->getUser()->isRegistered() ) { |
|
134 | - $out->addModules( 'wikibase.quality.constraints.gadget' ); |
|
132 | + if ($config->get('WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers') |
|
133 | + || $out->getUser()->isRegistered()) { |
|
134 | + $out->addModules('wikibase.quality.constraints.gadget'); |
|
135 | 135 | } |
136 | 136 | } |
137 | 137 |