wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Api/CheckConstraints.php

Spacing +30 added lines, -30 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -81,11 +81,11 @@ 
 		CheckResultsRendererFactory $checkResultsRendererFactory,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 		$this->entityIdParser = $entityIdParser;
 		$this->statementGuidValidator = $statementGuidValidator;
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->resultsSource = $resultsSource;
 		$this->checkResultsRendererFactory = $checkResultsRendererFactory;
 		$this->dataFactory = $dataFactory;
@@ -101,14 +101,14 @@ 
 
 		$params = $this->extractRequestParams();
 
-		$this->validateParameters( $params );
-		$entityIds = $this->parseEntityIds( $params );
-		$claimIds = $this->parseClaimIds( $params );
+		$this->validateParameters($params);
+		$entityIds = $this->parseEntityIds($params);
+		$claimIds = $this->parseClaimIds($params);
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
 		$statuses = $params[self::PARAM_STATUS];
 
 		$checkResultsRenderer = $this->checkResultsRendererFactory
-			->getCheckResultsRenderer( $this->getLanguage(), $this );
+			->getCheckResultsRenderer($this->getLanguage(), $this);
 
 		$this->getResult()->addValue(
 			null,
@@ -122,7 +122,7 @@ 
 				)
 			)->getArray()
 		);
-		$this->resultBuilder->markSuccess( 1 );
+		$this->resultBuilder->markSuccess(1);
 	}
 
 	/**
@@ -130,24 +130,24 @@ 
 	 *
 	 * @return EntityId[]
 	 */
-	private function parseEntityIds( array $params ): array {
+	private function parseEntityIds(array $params): array {
 		$ids = $params[self::PARAM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		return array_map( function ( $id ) {
+		return array_map(function($id) {
 			try {
-				return $this->entityIdParser->parse( $id );
-			} catch ( EntityIdParsingException $e ) {
+				return $this->entityIdParser->parse($id);
+			} catch (EntityIdParsingException $e) {
 				$this->errorReporter->dieError(
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
 			}
-		}, $ids );
+		}, $ids);
 	}
 
 	/**
@@ -155,35 +155,35 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function parseClaimIds( array $params ): array {
+	private function parseClaimIds(array $params): array {
 		$ids = $params[self::PARAM_CLAIM_ID];
 
-		if ( $ids === null ) {
+		if ($ids === null) {
 			return [];
-		} elseif ( $ids === [] ) {
+		} elseif ($ids === []) {
 			$this->errorReporter->dieError(
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
 		}
 
-		foreach ( $ids as $id ) {
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
+		foreach ($ids as $id) {
+			if (!$this->statementGuidValidator->validate($id)) {
 				$this->errorReporter->dieError(
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
 			}
 		}
 
 		return $ids;
 	}
 
-	private function validateParameters( array $params ): void {
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
+	private function validateParameters(array $params): void {
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
 		) {
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
 			$this->errorReporter->dieError(
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
 		}
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
 			$paramId = self::PARAM_ID;
 			$paramClaimId = self::PARAM_CLAIM_ID;
 			$this->errorReporter->dieError(
@@ -224,7 +224,7 @@ 
 				],
 				ParamValidator::PARAM_ISMULTI => true,
 				ParamValidator::PARAM_ALL => true,
-				ParamValidator::PARAM_DEFAULT => implode( '|', CachingResultsSource::CACHED_STATUSES ),
+				ParamValidator::PARAM_DEFAULT => implode('|', CachingResultsSource::CACHED_STATUSES),
 				ApiBase::PARAM_HELP_MSG_PER_VALUE => [],
 			],
 		];

src/ConstraintCheck/Message/ViolationMessageRendererFactory.php

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -43,12 +43,12 @@ 
 	): ViolationMessageRenderer {
 		$userLanguageCode = $userLanguage->getCode();
 		$formatterOptions = new FormatterOptions();
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $userLanguageCode );
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $userLanguageCode);
 		return new MultilingualTextViolationMessageRenderer(
 			$this->entityIdHtmlLinkFormatterFactory
-				->getEntityIdFormatter( $userLanguage ),
+				->getEntityIdFormatter($userLanguage),
 			$this->valueFormatterFactory
-				->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ),
+				->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions),
 			$this->languageNameUtils,
 			$userLanguageCode,
 			$languageFallbackChain,

src/Api/ResultsCache.php

Spacing +8 added lines, -8 removed lines

@@ -36,7 +36,7 @@ 
 	 * @param WANObjectCache $cache
 	 * @param string $formatVersion The version of the API response format.
 	 */
-	public function __construct( WANObjectCache $cache, $formatVersion ) {
+	public function __construct(WANObjectCache $cache, $formatVersion) {
 		$this->cache = $cache;
 		$this->formatVersion = $formatVersion;
 	}
@@ -45,7 +45,7 @@ 
 	 * @param EntityId $entityId
 	 * @return string cache key
 	 */
-	public function makeKey( EntityId $entityId ) {
+	public function makeKey(EntityId $entityId) {
 		return $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'checkConstraints', // action
@@ -61,8 +61,8 @@ 
 	 * @param array &$info
 	 * @return mixed
 	 */
-	public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], array &$info = [] ) {
-		return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $info );
+	public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], array &$info = []) {
+		return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $info);
 	}
 
 	/**
@@ -72,16 +72,16 @@ 
 	 * @param array $opts
 	 * @return bool
 	 */
-	public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) {
-		return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts );
+	public function set(EntityId $key, $value, $ttl = 0, array $opts = []) {
+		return $this->cache->set($this->makeKey($key), $value, $ttl, $opts);
 	}
 
 	/**
 	 * @param EntityId $key
 	 * @return bool
 	 */
-	public function delete( EntityId $key ) {
-		return $this->cache->delete( $this->makeKey( $key ) );
+	public function delete(EntityId $key) {
+		return $this->cache->delete($this->makeKey($key));
 	}
 
 }

src/Api/CheckResultsRendererFactory.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -37,12 +37,12 @@ 
 		Language $userLanguage,
 		MessageLocalizer $messageLocalizer
 	): CheckResultsRenderer {
-		$languageFallbackChain = $this->languageFallbackChainFactory->newFromLanguage( $userLanguage );
+		$languageFallbackChain = $this->languageFallbackChainFactory->newFromLanguage($userLanguage);
 
 		return new CheckResultsRenderer(
 			$this->entityTitleLookup,
 			$this->entityIdLabelFormatterFactory
-				->getEntityIdFormatter( $userLanguage ),
+				->getEntityIdFormatter($userLanguage),
 			$languageFallbackChain,
 			$this->violationMessageRendererFactory
 				->getViolationMessageRenderer(

src/ConstraintCheck/Result/CheckResultSerializer.php

Spacing +16 added lines, -16 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result;
 
@@ -60,14 +60,14 @@ 
 		$this->serializeDependencyMetadata = $serializeDependencyMetadata;
 	}
 
-	public function serialize( CheckResult $checkResult ): array {
+	public function serialize(CheckResult $checkResult): array {
 		$contextCursor = $checkResult->getContextCursor();
 
 		$serialization = [
-			self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize( $contextCursor ),
+			self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize($contextCursor),
 		];
 
-		if ( $checkResult instanceof NullResult ) {
+		if ($checkResult instanceof NullResult) {
 			$serialization[self::KEY_NULL_RESULT] = 1;
 		} else {
 			$constraint = $checkResult->getConstraint();
@@ -76,57 +76,57 @@ 
 			$clarification = $checkResult->getConstraintClarification();
 
 			$serialization[self::KEY_CONSTRAINT] =
-				$this->constraintSerializer->serialize( $constraint );
+				$this->constraintSerializer->serialize($constraint);
 			$serialization[self::KEY_CHECK_RESULT_STATUS] =
 				$checkResult->getStatus();
 			$serialization[self::KEY_CACHING_METADATA] =
-				$this->serializeCachingMetadata( $cachingMetadata );
+				$this->serializeCachingMetadata($cachingMetadata);
 
-			if ( $violationMessage !== null ) {
+			if ($violationMessage !== null) {
 				$serialization[self::KEY_VIOLATION_MESSAGE] =
-					$this->violationMessageSerializer->serialize( $violationMessage );
+					$this->violationMessageSerializer->serialize($violationMessage);
 			}
-			if ( $clarification->getTexts() !== [] ) {
+			if ($clarification->getTexts() !== []) {
 				$serialization[self::KEY_CONSTRAINT_CLARIFICATION] =
 					$clarification->getArrayValue();
 			}
 		}
 
-		if ( $this->serializeDependencyMetadata ) {
+		if ($this->serializeDependencyMetadata) {
 			$serialization[self::KEY_DEPENDENCY_METADATA] =
-				$this->serializeDependencyMetadata( $checkResult );
+				$this->serializeDependencyMetadata($checkResult);
 		}
 
 		return $serialization;
 	}
 
-	private function serializeCachingMetadata( CachingMetadata $cachingMetadata ): array {
+	private function serializeCachingMetadata(CachingMetadata $cachingMetadata): array {
 		$maximumAge = $cachingMetadata->getMaximumAgeInSeconds();
 
 		$serialization = [];
 
-		if ( $maximumAge > 0 ) {
+		if ($maximumAge > 0) {
 			$serialization[self::KEY_CACHING_METADATA_MAX_AGE] = $maximumAge;
 		}
 
 		return $serialization;
 	}
 
-	private function serializeDependencyMetadata( CheckResult $checkResult ): array {
+	private function serializeDependencyMetadata(CheckResult $checkResult): array {
 		$dependencyMetadata = $checkResult->getMetadata()->getDependencyMetadata();
 		$entityIds = $dependencyMetadata->getEntityIds();
 		$futureTime = $dependencyMetadata->getFutureTime();
 
 		$serialization = [
 			self::KEY_DEPENDENCY_METADATA_ENTITY_IDS => array_map(
-				static function ( EntityId $entityId ) {
+				static function(EntityId $entityId) {
 					return $entityId->getSerialization();
 				},
 				$entityIds
 			),
 		];
 
-		if ( $futureTime !== null ) {
+		if ($futureTime !== null) {
 			$serialization[self::KEY_DEPENDENCY_METADATA_FUTURE_TIME] =
 				$futureTime->getArrayValue();
 		}

src/Api/CachingResultsSource.php

Spacing +77 added lines, -78 removed lines

@@ -143,14 +143,14 @@ 
 	) {
 		$results = [];
 		$metadatas = [];
-		if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
+		if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) {
 			$storedEntityIds = [];
-			foreach ( $entityIds as $entityId ) {
-				$storedResults = $this->getStoredResults( $entityId );
-				if ( $storedResults !== null ) {
-					$this->loggingHelper->logCheckConstraintsCacheHit( $entityId );
-					foreach ( $storedResults->getArray() as $checkResult ) {
-						if ( $this->statusSelected( $statuses, $checkResult ) ) {
+			foreach ($entityIds as $entityId) {
+				$storedResults = $this->getStoredResults($entityId);
+				if ($storedResults !== null) {
+					$this->loggingHelper->logCheckConstraintsCacheHit($entityId);
+					foreach ($storedResults->getArray() as $checkResult) {
+						if ($this->statusSelected($statuses, $checkResult)) {
 							$results[] = $checkResult;
 						}
 					}
@@ -158,19 +158,19 @@ 
 					$storedEntityIds[] = $entityId;
 				}
 			}
-			$entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) );
+			$entityIds = array_values(array_diff($entityIds, $storedEntityIds));
 		}
-		if ( $entityIds !== [] || $claimIds !== [] ) {
-			if ( $entityIds !== [] ) {
-				$this->loggingHelper->logCheckConstraintsCacheMisses( $entityIds );
+		if ($entityIds !== [] || $claimIds !== []) {
+			if ($entityIds !== []) {
+				$this->loggingHelper->logCheckConstraintsCacheMisses($entityIds);
 			}
-			$response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses );
-			$results = array_merge( $results, $response->getArray() );
+			$response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses);
+			$results = array_merge($results, $response->getArray());
 			$metadatas[] = $response->getMetadata();
 		}
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -193,13 +193,13 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		if ( $claimIds !== [] ) {
+		if ($claimIds !== []) {
 			return false;
 		}
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( array_diff( $statuses, self::CACHED_STATUSES ) !== [] ) {
+		if (array_diff($statuses, self::CACHED_STATUSES) !== []) {
 			return false;
 		}
 		return true;
@@ -214,8 +214,8 @@ 
 	 * @param CheckResult $result
 	 * @return bool
 	 */
-	private function statusSelected( array $statuses, CheckResult $result ) {
-		return in_array( $result->getStatus(), $statuses, true ) ||
+	private function statusSelected(array $statuses, CheckResult $result) {
+		return in_array($result->getStatus(), $statuses, true) ||
 			$result instanceof NullResult;
 	}
 
@@ -232,11 +232,11 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		$results = $this->resultsSource->getResults( $entityIds, $claimIds, $constraintIds, $statuses );
+		$results = $this->resultsSource->getResults($entityIds, $claimIds, $constraintIds, $statuses);
 
-		if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) {
-			foreach ( $entityIds as $entityId ) {
-				$this->storeResults( $entityId, $results );
+		if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) {
+			foreach ($entityIds as $entityId) {
+				$this->storeResults($entityId, $results);
 			}
 		}
 
@@ -267,10 +267,10 @@ 
 		?array $constraintIds,
 		array $statuses
 	) {
-		if ( $constraintIds !== null ) {
+		if ($constraintIds !== null) {
 			return false;
 		}
-		if ( array_diff( self::CACHED_STATUSES, $statuses ) !== [] ) {
+		if (array_diff(self::CACHED_STATUSES, $statuses) !== []) {
 			return false;
 		}
 		return true;
@@ -284,21 +284,21 @@ 
 	 * May include check results for other entity IDs as well,
 	 * or check results with statuses that we’re not interested in caching.
 	 */
-	private function storeResults( EntityId $entityId, CachedCheckResults $results ) {
+	private function storeResults(EntityId $entityId, CachedCheckResults $results) {
 		$latestRevisionIds = $this->getLatestRevisionIds(
 			$results->getMetadata()->getDependencyMetadata()->getEntityIds()
 		);
-		if ( $latestRevisionIds === null ) {
+		if ($latestRevisionIds === null) {
 			return;
 		}
 
 		$resultSerializations = [];
-		foreach ( $results->getArray() as $checkResult ) {
-			if ( $checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization() ) {
+		foreach ($results->getArray() as $checkResult) {
+			if ($checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization()) {
 				continue;
 			}
-			if ( $this->statusSelected( self::CACHED_STATUSES, $checkResult ) ) {
-				$resultSerializations[] = $this->checkResultSerializer->serialize( $checkResult );
+			if ($this->statusSelected(self::CACHED_STATUSES, $checkResult)) {
+				$resultSerializations[] = $this->checkResultSerializer->serialize($checkResult);
 			}
 		}
 
@@ -307,11 +307,11 @@ 
 			'latestRevisionIds' => $latestRevisionIds,
 		];
 		$futureTime = $results->getMetadata()->getDependencyMetadata()->getFutureTime();
-		if ( $futureTime !== null ) {
+		if ($futureTime !== null) {
 			$value['futureTime'] = $futureTime->getArrayValue();
 		}
 
-		$this->cache->set( $entityId, $value, $this->ttlInSeconds );
+		$this->cache->set($entityId, $value, $this->ttlInSeconds);
 	}
 
 	/**
@@ -326,33 +326,32 @@ 
 		$forRevision = 0
 	) {
 		$cacheInfo = WANObjectCache::PASS_BY_REF;
-		$value = $this->cache->get( $entityId, $curTTL, [], $cacheInfo );
-		$now = call_user_func( $this->microtime, true );
+		$value = $this->cache->get($entityId, $curTTL, [], $cacheInfo);
+		$now = call_user_func($this->microtime, true);
 
-		$dependencyMetadata = $this->checkDependencyMetadata( $value,
-			[ $entityId->getSerialization() => $forRevision ] );
-		if ( $dependencyMetadata === null ) {
+		$dependencyMetadata = $this->checkDependencyMetadata($value,
+			[$entityId->getSerialization() => $forRevision]);
+		if ($dependencyMetadata === null) {
 			return null;
 		}
 
 		// @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset False positive
 		$asOf = $cacheInfo[WANObjectCache::KEY_AS_OF];
-		$ageInSeconds = (int)ceil( $now - $asOf );
+		$ageInSeconds = (int) ceil($now - $asOf);
 		$cachingMetadata = $ageInSeconds > 0 ?
-			CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) :
-			CachingMetadata::fresh();
+			CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh();
 
 		$results = [];
-		foreach ( $value['results'] as $resultSerialization ) {
-			$results[] = $this->deserializeCheckResult( $resultSerialization, $cachingMetadata );
+		foreach ($value['results'] as $resultSerialization) {
+			$results[] = $this->deserializeCheckResult($resultSerialization, $cachingMetadata);
 		}
 
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( [
-				Metadata::ofCachingMetadata( $cachingMetadata ),
-				Metadata::ofDependencyMetadata( $dependencyMetadata ),
-			] )
+			Metadata::merge([
+				Metadata::ofCachingMetadata($cachingMetadata),
+				Metadata::ofDependencyMetadata($dependencyMetadata),
+			])
 		);
 	}
 
@@ -368,43 +367,43 @@ 
 	 * @return DependencyMetadata|null the dependency metadata,
 	 * or null if $value should no longer be used
 	 */
-	private function checkDependencyMetadata( $value, $paramRevs ) {
-		if ( $value === false ) {
+	private function checkDependencyMetadata($value, $paramRevs) {
+		if ($value === false) {
 			return null;
 		}
 
-		if ( array_key_exists( 'futureTime', $value ) ) {
-			$futureTime = TimeValue::newFromArray( $value['futureTime'] );
-			if ( !$this->timeValueComparer->isFutureTime( $futureTime ) ) {
+		if (array_key_exists('futureTime', $value)) {
+			$futureTime = TimeValue::newFromArray($value['futureTime']);
+			if (!$this->timeValueComparer->isFutureTime($futureTime)) {
 				return null;
 			}
-			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime );
+			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime);
 		} else {
 			$futureTimeDependencyMetadata = DependencyMetadata::blank();
 		}
 
-		foreach ( $paramRevs as $id => $revision ) {
-			if ( $revision > 0 ) {
-				$value['latestRevisionIds'][$id] = min( $revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX );
+		foreach ($paramRevs as $id => $revision) {
+			if ($revision > 0) {
+				$value['latestRevisionIds'][$id] = min($revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX);
 			}
 		}
 
 		$dependedEntityIds = array_map(
-			[ $this->entityIdParser, "parse" ],
-			array_keys( $value['latestRevisionIds'] )
+			[$this->entityIdParser, "parse"],
+			array_keys($value['latestRevisionIds'])
 		);
 
-		if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) {
+		if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) {
 			return null;
 		}
 
 		return array_reduce(
 			$dependedEntityIds,
-			static function ( DependencyMetadata $metadata, EntityId $entityId ) {
-				return DependencyMetadata::merge( [
+			static function(DependencyMetadata $metadata, EntityId $entityId) {
+				return DependencyMetadata::merge([
 					$metadata,
-					DependencyMetadata::ofEntityId( $entityId ),
-				] );
+					DependencyMetadata::ofEntityId($entityId),
+				]);
 			},
 			$futureTimeDependencyMetadata
 		);
@@ -424,13 +423,13 @@ 
 		array $resultSerialization,
 		CachingMetadata $cachingMetadata
 	) {
-		$result = $this->checkResultDeserializer->deserialize( $resultSerialization );
-		if ( $this->isPossiblyStaleResult( $result ) ) {
+		$result = $this->checkResultDeserializer->deserialize($resultSerialization);
+		if ($this->isPossiblyStaleResult($result)) {
 			$result->withMetadata(
-				Metadata::merge( [
+				Metadata::merge([
 					$result->getMetadata(),
-					Metadata::ofCachingMetadata( $cachingMetadata ),
-				] )
+					Metadata::ofCachingMetadata($cachingMetadata),
+				])
 			);
 		}
 		return $result;
@@ -440,8 +439,8 @@ 
 	 * @param CheckResult $result
 	 * @return bool
 	 */
-	private function isPossiblyStaleResult( CheckResult $result ) {
-		if ( $result instanceof NullResult ) {
+	private function isPossiblyStaleResult(CheckResult $result) {
+		if ($result instanceof NullResult) {
 			return false;
 		}
 
@@ -456,14 +455,14 @@ 
 	 * @return int[]|null array from entity ID serializations to revision ID,
 	 * or null to indicate that not all revision IDs could be loaded
 	 */
-	private function getLatestRevisionIds( array $entityIds ) {
-		if ( $entityIds === [] ) {
+	private function getLatestRevisionIds(array $entityIds) {
+		if ($entityIds === []) {
 			$this->loggingHelper->logEmptyDependencyMetadata();
 			return [];
 		}
-		if ( count( $entityIds ) > $this->maxRevisionIds ) {
+		if (count($entityIds) > $this->maxRevisionIds) {
 			// one of those entities will probably be edited soon, so might as well skip caching
-			$this->loggingHelper->logHugeDependencyMetadata( $entityIds, $this->maxRevisionIds );
+			$this->loggingHelper->logHugeDependencyMetadata($entityIds, $this->maxRevisionIds);
 			return null;
 		}
 
@@ -471,7 +470,7 @@ 
 			$entityIds,
 			LookupConstants::LATEST_FROM_REPLICA
 		);
-		if ( $this->hasFalseElements( $latestRevisionIds ) ) {
+		if ($this->hasFalseElements($latestRevisionIds)) {
 			return null;
 		}
 		return $latestRevisionIds;
@@ -481,8 +480,8 @@ 
 	 * @param array $array
 	 * @return bool
 	 */
-	private function hasFalseElements( array $array ) {
-		return in_array( false, $array, true );
+	private function hasFalseElements(array $array) {
+		return in_array(false, $array, true);
 	}
 
 	/**
@@ -490,7 +489,7 @@ 
 	 *
 	 * @param callable $microtime
 	 */
-	public function setMicrotimeFunction( callable $microtime ) {
+	public function setMicrotimeFunction(callable $microtime) {
 		$this->microtime = $microtime;
 	}
 

src/Api/CheckResultsRenderer.php

Spacing +20 added lines, -20 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -41,11 +41,11 @@ 
 		$this->violationMessageRenderer = $violationMessageRenderer;
 	}
 
-	public function render( CachedCheckResults $checkResults ): CachedCheckConstraintsResponse {
+	public function render(CachedCheckResults $checkResults): CachedCheckConstraintsResponse {
 		$response = [];
-		foreach ( $checkResults->getArray() as $checkResult ) {
-			$resultArray = $this->checkResultToArray( $checkResult );
-			$checkResult->getContextCursor()->storeCheckResultInArray( $resultArray, $response );
+		foreach ($checkResults->getArray() as $checkResult) {
+			$resultArray = $this->checkResultToArray($checkResult);
+			$checkResult->getContextCursor()->storeCheckResultInArray($resultArray, $response);
 		}
 		return new CachedCheckConstraintsResponse(
 			$response,
@@ -53,19 +53,19 @@ 
 		);
 	}
 
-	public function checkResultToArray( CheckResult $checkResult ): ?array {
-		if ( $checkResult instanceof NullResult ) {
+	public function checkResultToArray(CheckResult $checkResult): ?array {
+		if ($checkResult instanceof NullResult) {
 			return null;
 		}
 
 		$constraintId = $checkResult->getConstraint()->getConstraintId();
 		$typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId();
-		$constraintPropertyId = new NumericPropertyId( $checkResult->getContextCursor()->getSnakPropertyId() );
+		$constraintPropertyId = new NumericPropertyId($checkResult->getContextCursor()->getSnakPropertyId());
 
-		$title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId );
+		$title = $this->entityTitleLookup->getTitleForId($constraintPropertyId);
 		$talkTitle = $title->getTalkPageIfDefined();
-		$typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) );
-		$link = $title->getFullURL() . '#' . $constraintId;
+		$typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId));
+		$link = $title->getFullURL().'#'.$constraintId;
 
 		$constraint = [
 			'id' => $constraintId,
@@ -81,28 +81,28 @@ 
 			'constraint' => $constraint,
 		];
 		$message = $checkResult->getMessage();
-		if ( $message ) {
-			$result['message-html'] = $this->violationMessageRenderer->render( $message );
+		if ($message) {
+			$result['message-html'] = $this->violationMessageRenderer->render($message);
 		}
-		$constraintClarification = $this->renderConstraintClarification( $checkResult );
-		if ( $constraintClarification !== null ) {
+		$constraintClarification = $this->renderConstraintClarification($checkResult);
+		if ($constraintClarification !== null) {
 			$result['constraint-clarification'] = $constraintClarification;
 		}
-		if ( $checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT ) {
+		if ($checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT) {
 			$result['claim'] = $checkResult->getContextCursor()->getStatementGuid();
 		}
 		$cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray();
-		if ( $cachingMetadataArray !== null ) {
+		if ($cachingMetadataArray !== null) {
 			$result['cached'] = $cachingMetadataArray;
 		}
 
 		return $result;
 	}
 
-	private function renderConstraintClarification( CheckResult $result ): ?string {
+	private function renderConstraintClarification(CheckResult $result): ?string {
 		$texts = $result->getConstraintClarification()->getTexts();
-		foreach ( $this->languageFallbackChain->getFetchLanguageCodes() as $languageCode ) {
-			if ( array_key_exists( $languageCode, $texts ) ) {
+		foreach ($this->languageFallbackChain->getFetchLanguageCodes() as $languageCode) {
+			if (array_key_exists($languageCode, $texts)) {
 				return $texts[$languageCode]->getText();
 			}
 		}

src/Api/CheckingResultsSource.php

Spacing +20 added lines, -21 removed lines

@@ -44,57 +44,56 @@
 	) {
 		$results = [];
 		$metadatas = [];
-		$statusesFlipped = array_flip( $statuses );
-		foreach ( $entityIds as $entityId ) {
+		$statusesFlipped = array_flip($statuses);
+		foreach ($entityIds as $entityId) {
 			$entityResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnEntityId(
 				$entityId,
 				$constraintIds,
-				[ $this, 'defaultResultsPerContext' ],
-				[ $this, 'defaultResultsPerEntity' ]
+				[$this, 'defaultResultsPerContext'],
+				[$this, 'defaultResultsPerEntity']
 			);
-			foreach ( $entityResults as $result ) {
+			foreach ($entityResults as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
+				if ($this->statusSelected($statusesFlipped, $result)) {
 					$results[] = $result;
 				}
 			}
 		}
-		foreach ( $claimIds as $claimId ) {
+		foreach ($claimIds as $claimId) {
 			$claimResults = $this->delegatingConstraintChecker->checkAgainstConstraintsOnClaimId(
 				$claimId,
 				$constraintIds,
-				[ $this, 'defaultResultsPerContext' ]
+				[$this, 'defaultResultsPerContext']
 			);
-			foreach ( $claimResults as $result ) {
+			foreach ($claimResults as $result) {
 				$metadatas[] = $result->getMetadata();
-				if ( $this->statusSelected( $statusesFlipped, $result ) ) {
+				if ($this->statusSelected($statusesFlipped, $result)) {
 					$results[] = $result;
 				}
 			}
 		}
 		return new CachedCheckResults(
 			$results,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	public function defaultResultsPerContext( Context $context ) {
+	public function defaultResultsPerContext(Context $context) {
 		return $context->getType() === Context::TYPE_STATEMENT ?
-			[ new NullResult( $context->getCursor() ) ] :
-			[];
+			[new NullResult($context->getCursor())] : [];
 	}
 
-	public function defaultResultsPerEntity( EntityId $entityId ) {
+	public function defaultResultsPerEntity(EntityId $entityId) {
 		return [
-			( new NullResult( new EntityContextCursor( $entityId->getSerialization() ) ) )
-				->withMetadata( Metadata::ofDependencyMetadata(
-					DependencyMetadata::ofEntityId( $entityId )
-				) ),
+			(new NullResult(new EntityContextCursor($entityId->getSerialization())))
+				->withMetadata(Metadata::ofDependencyMetadata(
+					DependencyMetadata::ofEntityId($entityId)
+				)),
 		];
 	}
 
-	public function statusSelected( array $statusesFlipped, CheckResult $result ) {
-		return array_key_exists( $result->getStatus(), $statusesFlipped ) ||
+	public function statusSelected(array $statusesFlipped, CheckResult $result) {
+		return array_key_exists($result->getStatus(), $statusesFlipped) ||
 			$result instanceof NullResult;
 	}
 

src/ConstraintCheck/Result/CheckResultDeserializer.php

Spacing +25 added lines, -25 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result;
 
@@ -40,13 +40,13 @@ 
 		$this->entityIdParser = $entityIdParser;
 	}
 
-	public function deserialize( array $serialization ): CheckResult {
+	public function deserialize(array $serialization): CheckResult {
 		$contextCursor = $this->contextCursorDeserializer->deserialize(
 			$serialization[CheckResultSerializer::KEY_CONTEXT_CURSOR]
 		);
 
-		if ( array_key_exists( CheckResultSerializer::KEY_NULL_RESULT, $serialization ) ) {
-			$result = new NullResult( $contextCursor );
+		if (array_key_exists(CheckResultSerializer::KEY_NULL_RESULT, $serialization)) {
+			$result = new NullResult($contextCursor);
 			$cachingMetadata = CachingMetadata::fresh();
 		} else {
 			$constraint = $this->constraintDeserializer->deserialize(
@@ -57,7 +57,7 @@ 
 
 			$status = $serialization[CheckResultSerializer::KEY_CHECK_RESULT_STATUS];
 
-			$violationMessage = $this->getViolationMessageFromSerialization( $serialization );
+			$violationMessage = $this->getViolationMessageFromSerialization($serialization);
 
 			$result = new CheckResult(
 				$contextCursor,
@@ -68,7 +68,7 @@ 
 			);
 
 			$result->setConstraintClarification(
-				$this->getConstraintClarificationFromSerialization( $serialization )
+				$this->getConstraintClarificationFromSerialization($serialization)
 			);
 
 			$cachingMetadata = $this->deserializeCachingMetadata(
@@ -76,18 +76,18 @@ 
 			);
 		}
 
-		$dependencyMetadata = $this->getDependencyMetadataFromSerialization( $serialization );
+		$dependencyMetadata = $this->getDependencyMetadataFromSerialization($serialization);
 
 		return $result->withMetadata(
-			Metadata::merge( [
-				Metadata::ofCachingMetadata( $cachingMetadata ),
-				Metadata::ofDependencyMetadata( $dependencyMetadata ),
-			] )
+			Metadata::merge([
+				Metadata::ofCachingMetadata($cachingMetadata),
+				Metadata::ofDependencyMetadata($dependencyMetadata),
+			])
 		);
 	}
 
-	private function getViolationMessageFromSerialization( array $serialization ): ?ViolationMessage {
-		if ( array_key_exists( CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization ) ) {
+	private function getViolationMessageFromSerialization(array $serialization): ?ViolationMessage {
+		if (array_key_exists(CheckResultSerializer::KEY_VIOLATION_MESSAGE, $serialization)) {
 			return $this->violationMessageDeserializer->deserialize(
 				$serialization[CheckResultSerializer::KEY_VIOLATION_MESSAGE]
 			);
@@ -99,17 +99,17 @@ 
 	private function getConstraintClarificationFromSerialization(
 		array $serialization
 	): MultilingualTextValue {
-		if ( array_key_exists( CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION, $serialization ) ) {
+		if (array_key_exists(CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION, $serialization)) {
 			return MultilingualTextValue::newFromArray(
 				$serialization[CheckResultSerializer::KEY_CONSTRAINT_CLARIFICATION]
 			);
 		} else {
-			return new MultilingualTextValue( [] );
+			return new MultilingualTextValue([]);
 		}
 	}
 
-	private function getDependencyMetadataFromSerialization( array $serialization ): DependencyMetadata {
-		if ( array_key_exists( CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization ) ) {
+	private function getDependencyMetadataFromSerialization(array $serialization): DependencyMetadata {
+		if (array_key_exists(CheckResultSerializer::KEY_DEPENDENCY_METADATA, $serialization)) {
 			return $this->deserializeDependencyMetadata(
 				$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA]
 			);
@@ -118,7 +118,7 @@ 
 		}
 	}
 
-	private function deserializeCachingMetadata( array $serialization ): CachingMetadata {
+	private function deserializeCachingMetadata(array $serialization): CachingMetadata {
 		if (
 			array_key_exists(
 				CheckResultSerializer::KEY_CACHING_METADATA_MAX_AGE,
@@ -133,7 +133,7 @@ 
 		}
 	}
 
-	private function deserializeDependencyMetadata( array $serialization ): DependencyMetadata {
+	private function deserializeDependencyMetadata(array $serialization): DependencyMetadata {
 		if (
 			array_key_exists(
 				CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME,
@@ -143,20 +143,20 @@ 
 			$futureTime = TimeValue::newFromArray(
 				$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_FUTURE_TIME]
 			);
-			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime );
+			$futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime);
 		} else {
 			$futureTimeDependencyMetadata = DependencyMetadata::blank();
 		}
 
 		$dependencyMetadata = array_reduce(
 			$serialization[CheckResultSerializer::KEY_DEPENDENCY_METADATA_ENTITY_IDS],
-			function ( DependencyMetadata $metadata, $entityIdSerialization ) {
-				$entityId = $this->entityIdParser->parse( $entityIdSerialization );
+			function(DependencyMetadata $metadata, $entityIdSerialization) {
+				$entityId = $this->entityIdParser->parse($entityIdSerialization);
 
-				return DependencyMetadata::merge( [
+				return DependencyMetadata::merge([
 					$metadata,
-					DependencyMetadata::ofEntityId( $entityId ),
-				] );
+					DependencyMetadata::ofEntityId($entityId),
+				]);
 			},
 			$futureTimeDependencyMetadata
 		);