Completed
Push — master ( 515739...696b67 )
by
unknown
04:59 queued 11s
created
src/ConstraintCheck/Context/ReferenceContext.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 		Reference $reference,
31 31
 		Snak $snak
32 32
 	) {
33
-		parent::__construct( $entity, $snak );
33
+		parent::__construct($entity, $snak);
34 34
 		$this->statement = $statement;
35 35
 		$this->reference = $reference;
36 36
 	}
@@ -39,9 +39,9 @@  discard block
 block discarded – undo
39 39
 		return self::TYPE_REFERENCE;
40 40
 	}
41 41
 
42
-	public function getSnakGroup( $groupingMode, array $separators = [] ) {
42
+	public function getSnakGroup($groupingMode, array $separators = []) {
43 43
 		$snaks = $this->reference->getSnaks();
44
-		return array_values( $snaks->getArrayCopy() );
44
+		return array_values($snaks->getArrayCopy());
45 45
 	}
46 46
 
47 47
 	public function getCursor() {
Please login to merge, or discard this patch.
src/ConstraintCheck/Context/Context.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@
 block discarded – undo
109 109
 	 * @return Snak[] not a SnakList because for a statement context,
110 110
 	 * the returned value might contain the same snak several times.
111 111
 	 */
112
-	public function getSnakGroup( $groupingMode, array $separators = [] );
112
+	public function getSnakGroup($groupingMode, array $separators = []);
113 113
 
114 114
 	/**
115 115
 	 * Get the cursor that can be used to address check results for this context.
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleBestValueChecker.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -66,9 +66,9 @@  discard block
 block discarded – undo
66 66
 	 *
67 67
 	 * @return CheckResult
68 68
 	 */
69
-	public function checkConstraint( Context $context, Constraint $constraint ) {
70
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
71
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
69
+	public function checkConstraint(Context $context, Constraint $constraint) {
70
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
71
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
72 72
 		}
73 73
 
74 74
 		$parameters = [];
@@ -80,13 +80,13 @@  discard block
 block discarded – undo
80 80
 
81 81
 		$propertyId = $context->getSnak()->getPropertyId();
82 82
 		$bestRankCount = $this->valueCountCheckerHelper->getPropertyCount(
83
-			$context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ),
83
+			$context->getSnakGroup(Context::GROUP_BEST_RANK, $separators),
84 84
 			$propertyId
85 85
 		);
86 86
 
87
-		if ( $bestRankCount > 1 ) {
87
+		if ($bestRankCount > 1) {
88 88
 			$nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount(
89
-				$context->getSnakGroup( Context::GROUP_NON_DEPRECATED ),
89
+				$context->getSnakGroup(Context::GROUP_NON_DEPRECATED),
90 90
 				$propertyId
91 91
 			);
92 92
 			$message = $this->getViolationMessage(
@@ -101,15 +101,15 @@  discard block
 block discarded – undo
101 101
 			$status = CheckResult::STATUS_COMPLIANCE;
102 102
 		}
103 103
 
104
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
104
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
105 105
 	}
106 106
 
107
-	public function checkConstraintParameters( Constraint $constraint ) {
107
+	public function checkConstraintParameters(Constraint $constraint) {
108 108
 		$constraintParameters = $constraint->getConstraintParameters();
109 109
 		$exceptions = [];
110 110
 		try {
111
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
112
-		} catch ( ConstraintParameterException $e ) {
111
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
112
+		} catch (ConstraintParameterException $e) {
113 113
 			$exceptions[] = $e;
114 114
 		}
115 115
 		return $exceptions;
@@ -128,23 +128,23 @@  discard block
 block discarded – undo
128 128
 		$separators,
129 129
 		$propertyId
130 130
 	) {
131
-		if ( $bestRankCount === $nonDeprecatedCount ) {
132
-			if ( $separators === [] ) {
131
+		if ($bestRankCount === $nonDeprecatedCount) {
132
+			if ($separators === []) {
133 133
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred';
134 134
 			} else {
135 135
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators';
136 136
 			}
137 137
 		} else {
138
-			if ( $separators === [] ) {
138
+			if ($separators === []) {
139 139
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred';
140 140
 			} else {
141 141
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators';
142 142
 			}
143 143
 		}
144 144
 
145
-		return ( new ViolationMessage( $messageKey ) )
146
-			->withEntityId( $propertyId )
147
-			->withEntityIdList( $separators );
145
+		return (new ViolationMessage($messageKey))
146
+			->withEntityId($propertyId)
147
+			->withEntityIdList($separators);
148 148
 	}
149 149
 
150 150
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
 	 * @throws ConstraintParameterException
68 68
 	 * @return CheckResult
69 69
 	 */
70
-	public function checkConstraint( Context $context, Constraint $constraint ) {
71
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
72
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
70
+	public function checkConstraint(Context $context, Constraint $constraint) {
71
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
72
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
73 73
 		}
74 74
 
75 75
 		$parameters = [];
@@ -81,19 +81,19 @@  discard block
 block discarded – undo
81 81
 
82 82
 		$propertyId = $context->getSnak()->getPropertyId();
83 83
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
84
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
84
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
85 85
 			$propertyId
86 86
 		);
87 87
 
88
-		if ( $propertyCount > 1 ) {
89
-			$message = $this->getViolationMessage( $separators, $propertyId );
88
+		if ($propertyCount > 1) {
89
+			$message = $this->getViolationMessage($separators, $propertyId);
90 90
 			$status = CheckResult::STATUS_VIOLATION;
91 91
 		} else {
92 92
 			$message = null;
93 93
 			$status = CheckResult::STATUS_COMPLIANCE;
94 94
 		}
95 95
 
96
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
96
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
97 97
 	}
98 98
 
99 99
 	/**
@@ -101,22 +101,21 @@  discard block
 block discarded – undo
101 101
 	 * @param PropertyId $propertyId
102 102
 	 * @return ViolationMessage
103 103
 	 */
104
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
104
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
105 105
 		$messageKey = $separators === [] ?
106
-			'wbqc-violation-message-single-value' :
107
-			'wbqc-violation-message-single-value-separators';
106
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
108 107
 
109
-		return ( new ViolationMessage( $messageKey ) )
110
-			->withEntityId( $propertyId )
111
-			->withEntityIdList( $separators );
108
+		return (new ViolationMessage($messageKey))
109
+			->withEntityId($propertyId)
110
+			->withEntityIdList($separators);
112 111
 	}
113 112
 
114
-	public function checkConstraintParameters( Constraint $constraint ) {
113
+	public function checkConstraintParameters(Constraint $constraint) {
115 114
 		$constraintParameters = $constraint->getConstraintParameters();
116 115
 		$exceptions = [];
117 116
 		try {
118
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
119
-		} catch ( ConstraintParameterException $e ) {
117
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
118
+		} catch (ConstraintParameterException $e) {
120 119
 			$exceptions[] = $e;
121 120
 		}
122 121
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/MultiValueChecker.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -65,9 +65,9 @@  discard block
 block discarded – undo
65 65
 	 *
66 66
 	 * @return CheckResult
67 67
 	 */
68
-	public function checkConstraint( Context $context, Constraint $constraint ) {
69
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
70
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
68
+	public function checkConstraint(Context $context, Constraint $constraint) {
69
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
70
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
71 71
 		}
72 72
 
73 73
 		$parameters = [];
@@ -79,33 +79,32 @@  discard block
 block discarded – undo
79 79
 
80 80
 		$propertyId = $context->getSnak()->getPropertyId();
81 81
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
82
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
82
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
83 83
 			$propertyId
84 84
 		);
85 85
 
86
-		if ( $propertyCount <= 1 ) {
87
-			$message = ( new ViolationMessage(
86
+		if ($propertyCount <= 1) {
87
+			$message = (new ViolationMessage(
88 88
 					$separators === [] ?
89
-						'wbqc-violation-message-multi-value' :
90
-						'wbqc-violation-message-multi-value-separators'
91
-				) )
92
-				->withEntityId( $propertyId )
93
-				->withEntityIdList( $separators );
89
+						'wbqc-violation-message-multi-value' : 'wbqc-violation-message-multi-value-separators'
90
+				))
91
+				->withEntityId($propertyId)
92
+				->withEntityIdList($separators);
94 93
 			$status = CheckResult::STATUS_VIOLATION;
95 94
 		} else {
96 95
 			$message = null;
97 96
 			$status = CheckResult::STATUS_COMPLIANCE;
98 97
 		}
99 98
 
100
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
99
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
101 100
 	}
102 101
 
103
-	public function checkConstraintParameters( Constraint $constraint ) {
102
+	public function checkConstraintParameters(Constraint $constraint) {
104 103
 		$constraintParameters = $constraint->getConstraintParameters();
105 104
 		$exceptions = [];
106 105
 		try {
107
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
108
-		} catch ( ConstraintParameterException $e ) {
106
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
107
+		} catch (ConstraintParameterException $e) {
109 108
 			$exceptions[] = $e;
110 109
 		}
111 110
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ConflictsWithChecker.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -88,39 +88,39 @@  discard block
 block discarded – undo
88 88
 	 * @throws ConstraintParameterException
89 89
 	 * @return CheckResult
90 90
 	 */
91
-	public function checkConstraint( Context $context, Constraint $constraint ) {
92
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
93
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
91
+	public function checkConstraint(Context $context, Constraint $constraint) {
92
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
93
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
94 94
 		}
95 95
 
96 96
 		$parameters = [];
97 97
 		$constraintParameters = $constraint->getConstraintParameters();
98 98
 
99
-		$propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
100
-		$parameters['property'] = [ $propertyId ];
99
+		$propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
100
+		$parameters['property'] = [$propertyId];
101 101
 
102
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
102
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
103 103
 		$parameters['items'] = $items;
104 104
 
105 105
 		/** @var StatementList $statementList */
106 106
 		$statementList = $context->getEntity()
107 107
 			->getStatements()
108
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
108
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
109 109
 
110 110
 		/*
111 111
 		 * 'Conflicts with' can be defined with
112 112
 		 *   a) a property only
113 113
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
114 114
 		 */
115
-		if ( $items === [] ) {
115
+		if ($items === []) {
116 116
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
117 117
 				$statementList,
118 118
 				$propertyId
119 119
 			);
120
-			if ( $offendingStatement !== null ) {
121
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
122
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
123
-					->withEntityId( $propertyId, Role::PREDICATE );
120
+			if ($offendingStatement !== null) {
121
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
122
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
123
+					->withEntityId($propertyId, Role::PREDICATE);
124 124
 				$status = CheckResult::STATUS_VIOLATION;
125 125
 			} else {
126 126
 				$message = null;
@@ -132,12 +132,12 @@  discard block
 block discarded – undo
132 132
 				$propertyId,
133 133
 				$items
134 134
 			);
135
-			if ( $offendingStatement !== null ) {
136
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
137
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
138
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
139
-					->withEntityId( $propertyId, Role::PREDICATE )
140
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
135
+			if ($offendingStatement !== null) {
136
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
137
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
138
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
139
+					->withEntityId($propertyId, Role::PREDICATE)
140
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
141 141
 				$status = CheckResult::STATUS_VIOLATION;
142 142
 			} else {
143 143
 				$message = null;
@@ -145,20 +145,20 @@  discard block
 block discarded – undo
145 145
 			}
146 146
 		}
147 147
 
148
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
148
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
149 149
 	}
150 150
 
151
-	public function checkConstraintParameters( Constraint $constraint ) {
151
+	public function checkConstraintParameters(Constraint $constraint) {
152 152
 		$constraintParameters = $constraint->getConstraintParameters();
153 153
 		$exceptions = [];
154 154
 		try {
155
-			$this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() );
156
-		} catch ( ConstraintParameterException $e ) {
155
+			$this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId());
156
+		} catch (ConstraintParameterException $e) {
157 157
 			$exceptions[] = $e;
158 158
 		}
159 159
 		try {
160
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false );
161
-		} catch ( ConstraintParameterException $e ) {
160
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false);
161
+		} catch (ConstraintParameterException $e) {
162 162
 			$exceptions[] = $e;
163 163
 		}
164 164
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/IntegerChecker.php 1 patch
Spacing   +21 added lines, -22 removed lines patch added patch discarded remove patch
@@ -41,22 +41,21 @@  discard block
 block discarded – undo
41 41
 		];
42 42
 	}
43 43
 
44
-	public function checkConstraint( Context $context, Constraint $constraint ) {
44
+	public function checkConstraint(Context $context, Constraint $constraint) {
45 45
 		$snak = $context->getSnak();
46 46
 
47
-		if ( $context->getSnak()->getType() !== 'value' ) {
48
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
47
+		if ($context->getSnak()->getType() !== 'value') {
48
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
49 49
 		}
50 50
 
51
-		$violationMessage = $this->checkSnak( $snak );
51
+		$violationMessage = $this->checkSnak($snak);
52 52
 
53 53
 		return new CheckResult(
54 54
 			$context,
55 55
 			$constraint,
56 56
 			[],
57 57
 			$violationMessage === null ?
58
-				CheckResult::STATUS_COMPLIANCE :
59
-				CheckResult::STATUS_VIOLATION,
58
+				CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION,
60 59
 			$violationMessage
61 60
 		);
62 61
 	}
@@ -65,23 +64,23 @@  discard block
 block discarded – undo
65 64
 	 * @param PropertyValueSnak $snak
66 65
 	 * @return ViolationMessage|null
67 66
 	 */
68
-	public function checkSnak( PropertyValueSnak $snak ) {
67
+	public function checkSnak(PropertyValueSnak $snak) {
69 68
 		$dataValue = $snak->getDataValue();
70 69
 
71
-		if ( $dataValue instanceof DecimalValue ) {
72
-			if ( !$this->isInteger( $dataValue ) ) {
73
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
70
+		if ($dataValue instanceof DecimalValue) {
71
+			if (!$this->isInteger($dataValue)) {
72
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
74 73
 			}
75
-		} elseif ( $dataValue instanceof UnboundedQuantityValue ) {
76
-			if ( !$this->isInteger( $dataValue->getAmount() ) ) {
77
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
74
+		} elseif ($dataValue instanceof UnboundedQuantityValue) {
75
+			if (!$this->isInteger($dataValue->getAmount())) {
76
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
78 77
 			} elseif (
79 78
 				$dataValue instanceof QuantityValue && (
80
-					!$this->isInteger( $dataValue->getLowerBound() ) ||
81
-					!$this->isInteger( $dataValue->getUpperBound() )
79
+					!$this->isInteger($dataValue->getLowerBound()) ||
80
+					!$this->isInteger($dataValue->getUpperBound())
82 81
 				)
83 82
 			) {
84
-				return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak );
83
+				return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak);
85 84
 			}
86 85
 		}
87 86
 
@@ -92,7 +91,7 @@  discard block
 block discarded – undo
92 91
 	 * @param DecimalValue $decimalValue
93 92
 	 * @return bool
94 93
 	 */
95
-	private function isInteger( DecimalValue $decimalValue ) {
94
+	private function isInteger(DecimalValue $decimalValue) {
96 95
 		return $decimalValue->getTrimmed()->getFractionalPart() === '';
97 96
 	}
98 97
 
@@ -101,13 +100,13 @@  discard block
 block discarded – undo
101 100
 	 * @param PropertyValueSnak $snak
102 101
 	 * @return ViolationMessage
103 102
 	 */
104
-	private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) {
105
-		return ( new ViolationMessage( $messageKey ) )
106
-			->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
107
-			->withDataValue( $snak->getDataValue() );
103
+	private function getViolationMessage($messageKey, PropertyValueSnak $snak) {
104
+		return (new ViolationMessage($messageKey))
105
+			->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
106
+			->withDataValue($snak->getDataValue());
108 107
 	}
109 108
 
110
-	public function checkConstraintParameters( Constraint $constraint ) {
109
+	public function checkConstraintParameters(Constraint $constraint) {
111 110
 		// no parameters
112 111
 		return [];
113 112
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/CitationNeededChecker.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -30,15 +30,15 @@  discard block
 block discarded – undo
30 30
 	 * @codeCoverageIgnore This method is purely declarative.
31 31
 	 */
32 32
 	public function getDefaultContextTypes() {
33
-		return [ Context::TYPE_STATEMENT ];
33
+		return [Context::TYPE_STATEMENT];
34 34
 	}
35 35
 
36
-	public function checkConstraint( Context $context, Constraint $constraint ) {
36
+	public function checkConstraint(Context $context, Constraint $constraint) {
37 37
 		$referenceList = $context->getSnakStatement()->getReferences();
38 38
 
39
-		if ( $referenceList->isEmpty() ) {
40
-			$message = ( new ViolationMessage( 'wbqc-violation-message-citationNeeded' ) )
41
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
39
+		if ($referenceList->isEmpty()) {
40
+			$message = (new ViolationMessage('wbqc-violation-message-citationNeeded'))
41
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
42 42
 			return new CheckResult(
43 43
 				$context,
44 44
 				$constraint,
@@ -48,10 +48,10 @@  discard block
 block discarded – undo
48 48
 			);
49 49
 		}
50 50
 
51
-		return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
51
+		return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
52 52
 	}
53 53
 
54
-	public function checkConstraintParameters( Constraint $constraint ) {
54
+	public function checkConstraintParameters(Constraint $constraint) {
55 55
 		// no parameters
56 56
 		return [];
57 57
 	}
Please login to merge, or discard this patch.
src/Api/CheckConstraints.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -79,21 +79,21 @@  discard block
 block discarded – undo
79 79
 	 *
80 80
 	 * @return self
81 81
 	 */
82
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
82
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
83 83
 		$repo = WikibaseRepo::getDefaultInstance();
84 84
 
85 85
 		$language = $repo->getUserLanguage();
86 86
 		$formatterOptions = new FormatterOptions();
87
-		$formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() );
87
+		$formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode());
88 88
 		$valueFormatterFactory = $repo->getValueFormatterFactory();
89
-		$valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions );
89
+		$valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions);
90 90
 
91 91
 		$languageFallbackLabelDescriptionLookupFactory = $repo->getLanguageFallbackLabelDescriptionLookupFactory();
92
-		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup( $language );
92
+		$labelDescriptionLookup = $languageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup($language);
93 93
 		$entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory();
94
-		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
94
+		$entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
95 95
 		$entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory();
96
-		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $labelDescriptionLookup );
96
+		$entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($labelDescriptionLookup);
97 97
 		$config = MediaWikiServices::getInstance()->getMainConfig();
98 98
 		$dataFactory = MediaWikiServices::getInstance()->getStatsdDataFactory();
99 99
 		$constraintReportFactory = ConstraintReportFactory::getDefaultInstance();
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 			$prefix,
118 118
 			$repo->getEntityIdParser(),
119 119
 			$repo->getStatementGuidValidator(),
120
-			$repo->getApiHelperFactory( RequestContext::getMain() ),
120
+			$repo->getApiHelperFactory(RequestContext::getMain()),
121 121
 			$resultsSource,
122 122
 			$checkResultsRenderer,
123 123
 			$dataFactory
@@ -146,11 +146,11 @@  discard block
 block discarded – undo
146 146
 		CheckResultsRenderer $checkResultsRenderer,
147 147
 		IBufferingStatsdDataFactory $dataFactory
148 148
 	) {
149
-		parent::__construct( $main, $name, $prefix );
149
+		parent::__construct($main, $name, $prefix);
150 150
 		$this->entityIdParser = $entityIdParser;
151 151
 		$this->statementGuidValidator = $statementGuidValidator;
152
-		$this->resultBuilder = $apiHelperFactory->getResultBuilder( $this );
153
-		$this->errorReporter = $apiHelperFactory->getErrorReporter( $this );
152
+		$this->resultBuilder = $apiHelperFactory->getResultBuilder($this);
153
+		$this->errorReporter = $apiHelperFactory->getErrorReporter($this);
154 154
 		$this->resultsSource = $resultsSource;
155 155
 		$this->checkResultsRenderer = $checkResultsRenderer;
156 156
 		$this->dataFactory = $dataFactory;
@@ -166,9 +166,9 @@  discard block
 block discarded – undo
166 166
 
167 167
 		$params = $this->extractRequestParams();
168 168
 
169
-		$this->validateParameters( $params );
170
-		$entityIds = $this->parseEntityIds( $params );
171
-		$claimIds = $this->parseClaimIds( $params );
169
+		$this->validateParameters($params);
170
+		$entityIds = $this->parseEntityIds($params);
171
+		$claimIds = $this->parseClaimIds($params);
172 172
 		$constraintIDs = $params[self::PARAM_CONSTRAINT_ID];
173 173
 		$statuses = $params[self::PARAM_STATUS];
174 174
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 				)
185 185
 			)->getArray()
186 186
 		);
187
-		$this->resultBuilder->markSuccess( 1 );
187
+		$this->resultBuilder->markSuccess(1);
188 188
 	}
189 189
 
190 190
 	/**
@@ -192,24 +192,24 @@  discard block
 block discarded – undo
192 192
 	 *
193 193
 	 * @return EntityId[]
194 194
 	 */
195
-	private function parseEntityIds( array $params ) {
195
+	private function parseEntityIds(array $params) {
196 196
 		$ids = $params[self::PARAM_ID];
197 197
 
198
-		if ( $ids === null ) {
198
+		if ($ids === null) {
199 199
 			return [];
200
-		} elseif ( $ids === [] ) {
200
+		} elseif ($ids === []) {
201 201
 			$this->errorReporter->dieError(
202
-				'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' );
202
+				'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' );
203 203
 		}
204 204
 
205
-		return array_map( function ( $id ) {
205
+		return array_map(function($id) {
206 206
 			try {
207
-				return $this->entityIdParser->parse( $id );
208
-			} catch ( EntityIdParsingException $e ) {
207
+				return $this->entityIdParser->parse($id);
208
+			} catch (EntityIdParsingException $e) {
209 209
 				$this->errorReporter->dieError(
210
-					"Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] );
210
+					"Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] );
211 211
 			}
212
-		}, $ids );
212
+		}, $ids);
213 213
 	}
214 214
 
215 215
 	/**
@@ -217,35 +217,35 @@  discard block
 block discarded – undo
217 217
 	 *
218 218
 	 * @return string[]
219 219
 	 */
220
-	private function parseClaimIds( array $params ) {
220
+	private function parseClaimIds(array $params) {
221 221
 		$ids = $params[self::PARAM_CLAIM_ID];
222 222
 
223
-		if ( $ids === null ) {
223
+		if ($ids === null) {
224 224
 			return [];
225
-		} elseif ( $ids === [] ) {
225
+		} elseif ($ids === []) {
226 226
 			$this->errorReporter->dieError(
227
-				'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' );
227
+				'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' );
228 228
 		}
229 229
 
230
-		foreach ( $ids as $id ) {
231
-			if ( !$this->statementGuidValidator->validate( $id ) ) {
230
+		foreach ($ids as $id) {
231
+			if (!$this->statementGuidValidator->validate($id)) {
232 232
 				$this->errorReporter->dieError(
233
-					"Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] );
233
+					"Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] );
234 234
 			}
235 235
 		}
236 236
 
237 237
 		return $ids;
238 238
 	}
239 239
 
240
-	private function validateParameters( array $params ) {
241
-		if ( $params[self::PARAM_CONSTRAINT_ID] !== null
242
-			 && empty( $params[self::PARAM_CONSTRAINT_ID] )
240
+	private function validateParameters(array $params) {
241
+		if ($params[self::PARAM_CONSTRAINT_ID] !== null
242
+			 && empty($params[self::PARAM_CONSTRAINT_ID])
243 243
 		) {
244 244
 			$paramConstraintId = self::PARAM_CONSTRAINT_ID;
245 245
 			$this->errorReporter->dieError(
246 246
 				"If $paramConstraintId is specified, it must be nonempty.", 'no-data' );
247 247
 		}
248
-		if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) {
248
+		if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) {
249 249
 			$paramId = self::PARAM_ID;
250 250
 			$paramClaimId = self::PARAM_CLAIM_ID;
251 251
 			$this->errorReporter->dieError(
@@ -285,11 +285,11 @@  discard block
 block discarded – undo
285 285
 				],
286 286
 				ApiBase::PARAM_ISMULTI => true,
287 287
 				ApiBase::PARAM_ALL => true,
288
-				ApiBase::PARAM_DFLT => implode( '|', [
288
+				ApiBase::PARAM_DFLT => implode('|', [
289 289
 					CheckResult::STATUS_VIOLATION,
290 290
 					CheckResult::STATUS_WARNING,
291 291
 					CheckResult::STATUS_BAD_PARAMETERS,
292
-				] ),
292
+				]),
293 293
 				ApiBase::PARAM_HELP_MSG_PER_VALUE => [],
294 294
 			],
295 295
 		];
Please login to merge, or discard this patch.