Completed
Push — master ( a1cc34...aa49b7 )
by
unknown
18s
created
src/ConstraintCheck/Checker/AllowedUnitsChecker.php 1 patch
Spacing   +34 added lines, -35 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 * @throws ConstraintParameterException
76 76
 	 * @return CheckResult
77 77
 	 */
78
-	public function checkConstraint( Context $context, Constraint $constraint ) {
78
+	public function checkConstraint(Context $context, Constraint $constraint) {
79 79
 		$parameters = [];
80 80
 		$constraintParameters = $constraint->getConstraintParameters();
81 81
 		$unitsParameter = $this->constraintParameterParser
@@ -85,50 +85,49 @@  discard block
 block discarded – undo
85 85
 			);
86 86
 
87 87
 		$snak = $context->getSnak();
88
-		if ( !$snak instanceof PropertyValueSnak ) {
88
+		if (!$snak instanceof PropertyValueSnak) {
89 89
 			// nothing to check
90
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
90
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
91 91
 		}
92 92
 
93 93
 		$dataValue = $snak->getDataValue();
94
-		if ( !$dataValue instanceof UnboundedQuantityValue ) {
95
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
96
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
97
-				->withDataValueType( 'quantity' );
98
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
94
+		if (!$dataValue instanceof UnboundedQuantityValue) {
95
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
96
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
97
+				->withDataValueType('quantity');
98
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
99 99
 		}
100 100
 
101
-		if ( $dataValue->getUnit() === '1' ) {
102
-			return $this->checkUnitless( $context, $constraint, $unitsParameter, $snak );
101
+		if ($dataValue->getUnit() === '1') {
102
+			return $this->checkUnitless($context, $constraint, $unitsParameter, $snak);
103 103
 		}
104 104
 
105 105
 		$status = CheckResult::STATUS_VIOLATION;
106
-		$actualUnit = $this->standardize( $dataValue )->getUnit();
107
-		foreach ( $unitsParameter->getUnitQuantities() as $unitQuantity ) {
108
-			$allowedUnit = $this->standardize( $unitQuantity )->getUnit();
109
-			if ( $actualUnit === $allowedUnit ) {
106
+		$actualUnit = $this->standardize($dataValue)->getUnit();
107
+		foreach ($unitsParameter->getUnitQuantities() as $unitQuantity) {
108
+			$allowedUnit = $this->standardize($unitQuantity)->getUnit();
109
+			if ($actualUnit === $allowedUnit) {
110 110
 				$status = CheckResult::STATUS_COMPLIANCE;
111 111
 				break;
112 112
 			}
113 113
 		}
114 114
 
115
-		if ( $status === CheckResult::STATUS_VIOLATION ) {
116
-			if ( $unitsParameter->getUnitItemIds() === [] ) {
117
-				$message = ( new ViolationMessage( 'wbqc-violation-message-units-none' ) )
118
-					->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY );
115
+		if ($status === CheckResult::STATUS_VIOLATION) {
116
+			if ($unitsParameter->getUnitItemIds() === []) {
117
+				$message = (new ViolationMessage('wbqc-violation-message-units-none'))
118
+					->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY);
119 119
 			} else {
120 120
 				$messageKey = $unitsParameter->getUnitlessAllowed() ?
121
-					'wbqc-violation-message-units-or-none' :
122
-					'wbqc-violation-message-units';
123
-				$message = ( new ViolationMessage( $messageKey ) )
124
-					->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
125
-					->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
121
+					'wbqc-violation-message-units-or-none' : 'wbqc-violation-message-units';
122
+				$message = (new ViolationMessage($messageKey))
123
+					->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
124
+					->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
126 125
 			}
127 126
 		} else {
128 127
 			$message = null;
129 128
 		}
130 129
 
131
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
130
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
132 131
 	}
133 132
 
134 133
 	/**
@@ -144,17 +143,17 @@  discard block
 block discarded – undo
144 143
 		UnitsParameter $unitsParameter,
145 144
 		PropertyValueSnak $snak
146 145
 	) {
147
-		if ( $unitsParameter->getUnitlessAllowed() ) {
146
+		if ($unitsParameter->getUnitlessAllowed()) {
148 147
 			$message = null;
149 148
 			$status = CheckResult::STATUS_COMPLIANCE;
150 149
 		} else {
151
-			$message = ( new ViolationMessage( 'wbqc-violation-message-units' ) )
152
-				->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
153
-				->withEntityIdList( $unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
150
+			$message = (new ViolationMessage('wbqc-violation-message-units'))
151
+				->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
152
+				->withEntityIdList($unitsParameter->getUnitItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
154 153
 			$status = CheckResult::STATUS_VIOLATION;
155 154
 		}
156 155
 
157
-		return new CheckResult( $context, $constraint, [], $status, $message );
156
+		return new CheckResult($context, $constraint, [], $status, $message);
158 157
 	}
159 158
 
160 159
 	/**
@@ -163,20 +162,20 @@  discard block
 block discarded – undo
163 162
 	 * @param UnboundedQuantityValue $value
164 163
 	 * @return UnboundedQuantityValue
165 164
 	 */
166
-	private function standardize( UnboundedQuantityValue $value ) {
167
-		if ( $this->unitConverter === null ) {
165
+	private function standardize(UnboundedQuantityValue $value) {
166
+		if ($this->unitConverter === null) {
168 167
 			return $value;
169 168
 		}
170 169
 
171
-		$standard = $this->unitConverter->toStandardUnits( $value );
172
-		if ( $standard !== null ) {
170
+		$standard = $this->unitConverter->toStandardUnits($value);
171
+		if ($standard !== null) {
173 172
 			return $standard;
174 173
 		} else {
175 174
 			return $value;
176 175
 		}
177 176
 	}
178 177
 
179
-	public function checkConstraintParameters( Constraint $constraint ) {
178
+	public function checkConstraintParameters(Constraint $constraint) {
180 179
 		$constraintParameters = $constraint->getConstraintParameters();
181 180
 		$exceptions = [];
182 181
 		try {
@@ -185,7 +184,7 @@  discard block
 block discarded – undo
185 184
 				$constraint->getConstraintTypeItemId(),
186 185
 				true
187 186
 			);
188
-		} catch ( ConstraintParameterException $e ) {
187
+		} catch (ConstraintParameterException $e) {
189 188
 			$exceptions[] = $e;
190 189
 		}
191 190
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleBestValueChecker.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -66,9 +66,9 @@  discard block
 block discarded – undo
66 66
 	 *
67 67
 	 * @return CheckResult
68 68
 	 */
69
-	public function checkConstraint( Context $context, Constraint $constraint ) {
70
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
71
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
69
+	public function checkConstraint(Context $context, Constraint $constraint) {
70
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
71
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
72 72
 		}
73 73
 
74 74
 		$parameters = [];
@@ -80,13 +80,13 @@  discard block
 block discarded – undo
80 80
 
81 81
 		$propertyId = $context->getSnak()->getPropertyId();
82 82
 		$bestRankCount = $this->valueCountCheckerHelper->getPropertyCount(
83
-			$context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ),
83
+			$context->getSnakGroup(Context::GROUP_BEST_RANK, $separators),
84 84
 			$propertyId
85 85
 		);
86 86
 
87
-		if ( $bestRankCount > 1 ) {
87
+		if ($bestRankCount > 1) {
88 88
 			$nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount(
89
-				$context->getSnakGroup( Context::GROUP_NON_DEPRECATED ),
89
+				$context->getSnakGroup(Context::GROUP_NON_DEPRECATED),
90 90
 				$propertyId
91 91
 			);
92 92
 			$message = $this->getViolationMessage(
@@ -101,15 +101,15 @@  discard block
 block discarded – undo
101 101
 			$status = CheckResult::STATUS_COMPLIANCE;
102 102
 		}
103 103
 
104
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
104
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
105 105
 	}
106 106
 
107
-	public function checkConstraintParameters( Constraint $constraint ) {
107
+	public function checkConstraintParameters(Constraint $constraint) {
108 108
 		$constraintParameters = $constraint->getConstraintParameters();
109 109
 		$exceptions = [];
110 110
 		try {
111
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
112
-		} catch ( ConstraintParameterException $e ) {
111
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
112
+		} catch (ConstraintParameterException $e) {
113 113
 			$exceptions[] = $e;
114 114
 		}
115 115
 		return $exceptions;
@@ -128,23 +128,23 @@  discard block
 block discarded – undo
128 128
 		$separators,
129 129
 		$propertyId
130 130
 	) {
131
-		if ( $bestRankCount === $nonDeprecatedCount ) {
132
-			if ( $separators === [] ) {
131
+		if ($bestRankCount === $nonDeprecatedCount) {
132
+			if ($separators === []) {
133 133
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred';
134 134
 			} else {
135 135
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators';
136 136
 			}
137 137
 		} else {
138
-			if ( $separators === [] ) {
138
+			if ($separators === []) {
139 139
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred';
140 140
 			} else {
141 141
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators';
142 142
 			}
143 143
 		}
144 144
 
145
-		return ( new ViolationMessage( $messageKey ) )
146
-			->withEntityId( $propertyId )
147
-			->withEntityIdList( $separators );
145
+		return (new ViolationMessage($messageKey))
146
+			->withEntityId($propertyId)
147
+			->withEntityIdList($separators);
148 148
 	}
149 149
 
150 150
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/SingleValueChecker.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
 	 * @throws ConstraintParameterException
68 68
 	 * @return CheckResult
69 69
 	 */
70
-	public function checkConstraint( Context $context, Constraint $constraint ) {
71
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
72
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
70
+	public function checkConstraint(Context $context, Constraint $constraint) {
71
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
72
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
73 73
 		}
74 74
 
75 75
 		$parameters = [];
@@ -81,19 +81,19 @@  discard block
 block discarded – undo
81 81
 
82 82
 		$propertyId = $context->getSnak()->getPropertyId();
83 83
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
84
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
84
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
85 85
 			$propertyId
86 86
 		);
87 87
 
88
-		if ( $propertyCount > 1 ) {
89
-			$message = $this->getViolationMessage( $separators, $propertyId );
88
+		if ($propertyCount > 1) {
89
+			$message = $this->getViolationMessage($separators, $propertyId);
90 90
 			$status = CheckResult::STATUS_VIOLATION;
91 91
 		} else {
92 92
 			$message = null;
93 93
 			$status = CheckResult::STATUS_COMPLIANCE;
94 94
 		}
95 95
 
96
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
96
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
97 97
 	}
98 98
 
99 99
 	/**
@@ -101,22 +101,21 @@  discard block
 block discarded – undo
101 101
 	 * @param PropertyId $propertyId
102 102
 	 * @return ViolationMessage
103 103
 	 */
104
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
104
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
105 105
 		$messageKey = $separators === [] ?
106
-			'wbqc-violation-message-single-value' :
107
-			'wbqc-violation-message-single-value-separators';
106
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
108 107
 
109
-		return ( new ViolationMessage( $messageKey ) )
110
-			->withEntityId( $propertyId )
111
-			->withEntityIdList( $separators );
108
+		return (new ViolationMessage($messageKey))
109
+			->withEntityId($propertyId)
110
+			->withEntityIdList($separators);
112 111
 	}
113 112
 
114
-	public function checkConstraintParameters( Constraint $constraint ) {
113
+	public function checkConstraintParameters(Constraint $constraint) {
115 114
 		$constraintParameters = $constraint->getConstraintParameters();
116 115
 		$exceptions = [];
117 116
 		try {
118
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
119
-		} catch ( ConstraintParameterException $e ) {
117
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
118
+		} catch (ConstraintParameterException $e) {
120 119
 			$exceptions[] = $e;
121 120
 		}
122 121
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/MultiValueChecker.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -65,9 +65,9 @@  discard block
 block discarded – undo
65 65
 	 *
66 66
 	 * @return CheckResult
67 67
 	 */
68
-	public function checkConstraint( Context $context, Constraint $constraint ) {
69
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
70
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
68
+	public function checkConstraint(Context $context, Constraint $constraint) {
69
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
70
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
71 71
 		}
72 72
 
73 73
 		$parameters = [];
@@ -79,33 +79,32 @@  discard block
 block discarded – undo
79 79
 
80 80
 		$propertyId = $context->getSnak()->getPropertyId();
81 81
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
82
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
82
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
83 83
 			$propertyId
84 84
 		);
85 85
 
86
-		if ( $propertyCount <= 1 ) {
87
-			$message = ( new ViolationMessage(
86
+		if ($propertyCount <= 1) {
87
+			$message = (new ViolationMessage(
88 88
 					$separators === [] ?
89
-						'wbqc-violation-message-multi-value' :
90
-						'wbqc-violation-message-multi-value-separators'
91
-				) )
92
-				->withEntityId( $propertyId )
93
-				->withEntityIdList( $separators );
89
+						'wbqc-violation-message-multi-value' : 'wbqc-violation-message-multi-value-separators'
90
+				))
91
+				->withEntityId($propertyId)
92
+				->withEntityIdList($separators);
94 93
 			$status = CheckResult::STATUS_VIOLATION;
95 94
 		} else {
96 95
 			$message = null;
97 96
 			$status = CheckResult::STATUS_COMPLIANCE;
98 97
 		}
99 98
 
100
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
99
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
101 100
 	}
102 101
 
103
-	public function checkConstraintParameters( Constraint $constraint ) {
102
+	public function checkConstraintParameters(Constraint $constraint) {
104 103
 		$constraintParameters = $constraint->getConstraintParameters();
105 104
 		$exceptions = [];
106 105
 		try {
107
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
108
-		} catch ( ConstraintParameterException $e ) {
106
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
107
+		} catch (ConstraintParameterException $e) {
109 108
 			$exceptions[] = $e;
110 109
 		}
111 110
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/TooManySparqlRequestsException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 class TooManySparqlRequestsException extends SparqlHelperException {
9 9
 
10 10
 	public function __construct() {
11
-		parent::__construct( 'The SPARQL query endpoint reports too many requests.' );
11
+		parent::__construct('The SPARQL query endpoint reports too many requests.');
12 12
 	}
13 13
 
14 14
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/SparqlHelperException.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,8 +9,8 @@
 block discarded – undo
9 9
  */
10 10
 class SparqlHelperException extends RuntimeException {
11 11
 
12
-	public function __construct( $msg = 'The SPARQL query endpoint returned an error.' ) {
13
-		parent::__construct( $msg );
12
+	public function __construct($msg = 'The SPARQL query endpoint returned an error.') {
13
+		parent::__construct($msg);
14 14
 	}
15 15
 
16 16
 }
Please login to merge, or discard this patch.
src/Html/HtmlTableBuilder.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @param array $headers
34 34
 	 */
35
-	public function __construct( array $headers ) {
36
-		foreach ( $headers as $header ) {
37
-			$this->addHeader( $header );
35
+	public function __construct(array $headers) {
36
+		foreach ($headers as $header) {
37
+			$this->addHeader($header);
38 38
 		}
39 39
 	}
40 40
 
@@ -43,16 +43,16 @@  discard block
 block discarded – undo
43 43
 	 *
44 44
 	 * @throws InvalidArgumentException
45 45
 	 */
46
-	private function addHeader( $header ) {
47
-		Assert::parameterType( 'string|' . HtmlTableHeaderBuilder::class, $header, '$header' );
46
+	private function addHeader($header) {
47
+		Assert::parameterType('string|'.HtmlTableHeaderBuilder::class, $header, '$header');
48 48
 
49
-		if ( is_string( $header ) ) {
50
-			$header = new HtmlTableHeaderBuilder( $header );
49
+		if (is_string($header)) {
50
+			$header = new HtmlTableHeaderBuilder($header);
51 51
 		}
52 52
 
53 53
 		$this->headers[] = $header;
54 54
 
55
-		if ( $header->getIsSortable() ) {
55
+		if ($header->getIsSortable()) {
56 56
 			$this->isSortable = true;
57 57
 		}
58 58
 	}
@@ -85,12 +85,12 @@  discard block
 block discarded – undo
85 85
 	 *
86 86
 	 * @throws InvalidArgumentException
87 87
 	 */
88
-	public function appendRow( array $cells ) {
89
-		foreach ( $cells as $key => $cell ) {
90
-			if ( is_string( $cell ) ) {
91
-				$cells[$key] = new HtmlTableCellBuilder( $cell );
92
-			} elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) {
93
-				throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' );
88
+	public function appendRow(array $cells) {
89
+		foreach ($cells as $key => $cell) {
90
+			if (is_string($cell)) {
91
+				$cells[$key] = new HtmlTableCellBuilder($cell);
92
+			} elseif (!($cell instanceof HtmlTableCellBuilder)) {
93
+				throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.');
94 94
 			}
95 95
 		}
96 96
 
@@ -104,13 +104,13 @@  discard block
 block discarded – undo
104 104
 	 *
105 105
 	 * @throws InvalidArgumentException
106 106
 	 */
107
-	public function appendRows( array $rows ) {
108
-		foreach ( $rows as $cells ) {
109
-			if ( !is_array( $cells ) ) {
110
-				throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' );
107
+	public function appendRows(array $rows) {
108
+		foreach ($rows as $cells) {
109
+			if (!is_array($cells)) {
110
+				throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.');
111 111
 			}
112 112
 
113
-			$this->appendRow( $cells );
113
+			$this->appendRow($cells);
114 114
 		}
115 115
 	}
116 116
 
@@ -122,38 +122,38 @@  discard block
 block discarded – undo
122 122
 	public function toHtml() {
123 123
 		// Open table
124 124
 		$tableClasses = 'wikitable';
125
-		if ( $this->isSortable ) {
125
+		if ($this->isSortable) {
126 126
 			$tableClasses .= ' sortable';
127 127
 		}
128
-		$html = Html::openElement( 'table', [ 'class' => $tableClasses ] );
128
+		$html = Html::openElement('table', ['class' => $tableClasses]);
129 129
 
130 130
 		// Write headers
131
-		$html .= Html::openElement( 'thead' );
132
-		$html .= Html::openElement( 'tr' );
133
-		foreach ( $this->headers as $header ) {
131
+		$html .= Html::openElement('thead');
132
+		$html .= Html::openElement('tr');
133
+		foreach ($this->headers as $header) {
134 134
 			$html .= $header->toHtml();
135 135
 		}
136
-		$html .= Html::closeElement( 'tr' );
137
-		$html .= Html::closeElement( 'thead' );
138
-		$html .= Html::openElement( 'tbody' );
136
+		$html .= Html::closeElement('tr');
137
+		$html .= Html::closeElement('thead');
138
+		$html .= Html::openElement('tbody');
139 139
 
140 140
 		// Write rows
141
-		foreach ( $this->rows as $row ) {
142
-			$html .= Html::openElement( 'tr' );
141
+		foreach ($this->rows as $row) {
142
+			$html .= Html::openElement('tr');
143 143
 
144 144
 			/**
145 145
 			 * @var HtmlTableCellBuilder $cell
146 146
 			 */
147
-			foreach ( $row as $cell ) {
147
+			foreach ($row as $cell) {
148 148
 				$html .= $cell->toHtml();
149 149
 			}
150 150
 
151
-			$html .= Html::closeElement( 'tr' );
151
+			$html .= Html::closeElement('tr');
152 152
 		}
153 153
 
154 154
 		// Close table
155
-		$html .= Html::closeElement( 'tbody' );
156
-		$html .= Html::closeElement( 'table' );
155
+		$html .= Html::closeElement('tbody');
156
+		$html .= Html::closeElement('table');
157 157
 
158 158
 		return $html;
159 159
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/NoneOfChecker.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
 	 * @throws ConstraintParameterException
61 61
 	 * @return CheckResult
62 62
 	 */
63
-	public function checkConstraint( Context $context, Constraint $constraint ) {
64
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
65
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
63
+	public function checkConstraint(Context $context, Constraint $constraint) {
64
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
65
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
66 66
 		}
67 67
 
68 68
 		$parameters = [];
@@ -81,20 +81,20 @@  discard block
 block discarded – undo
81 81
 		$message = null;
82 82
 		$status = CheckResult::STATUS_COMPLIANCE;
83 83
 
84
-		foreach ( $items as $item ) {
85
-			if ( $item->matchesSnak( $snak ) ) {
86
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
87
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
88
-					->withItemIdSnakValueList( $items, Role::OBJECT );
84
+		foreach ($items as $item) {
85
+			if ($item->matchesSnak($snak)) {
86
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
87
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
88
+					->withItemIdSnakValueList($items, Role::OBJECT);
89 89
 				$status = CheckResult::STATUS_VIOLATION;
90 90
 				break;
91 91
 			}
92 92
 		}
93 93
 
94
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
94
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
95 95
 	}
96 96
 
97
-	public function checkConstraintParameters( Constraint $constraint ) {
97
+	public function checkConstraintParameters(Constraint $constraint) {
98 98
 		$constraintParameters = $constraint->getConstraintParameters();
99 99
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
100 100
 		$exceptions = [];
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 				$constraintTypeItemId,
105 105
 				true
106 106
 			);
107
-		} catch ( ConstraintParameterException $e ) {
107
+		} catch (ConstraintParameterException $e) {
108 108
 			$exceptions[] = $e;
109 109
 		}
110 110
 		return $exceptions;
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/ItemChecker.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -78,9 +78,9 @@  discard block
 block discarded – undo
78 78
 	 * @throws ConstraintParameterException
79 79
 	 * @return CheckResult
80 80
 	 */
81
-	public function checkConstraint( Context $context, Constraint $constraint ) {
82
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
83
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
81
+	public function checkConstraint(Context $context, Constraint $constraint) {
82
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
83
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
84 84
 		}
85 85
 
86 86
 		$parameters = [];
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 			$constraintParameters,
92 92
 			$constraintTypeItemId
93 93
 		);
94
-		$parameters['property'] = [ $propertyId ];
94
+		$parameters['property'] = [$propertyId];
95 95
 
96 96
 		$items = $this->constraintParameterParser->parseItemsParameter(
97 97
 			$constraintParameters,
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 		 *   a) a property only
106 106
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
107 107
 		 */
108
-		if ( $items === [] ) {
108
+		if ($items === []) {
109 109
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
110 110
 				$context->getEntity()->getStatements(),
111 111
 				$propertyId
@@ -118,21 +118,21 @@  discard block
 block discarded – undo
118 118
 			);
119 119
 		}
120 120
 
121
-		if ( $requiredStatement !== null ) {
121
+		if ($requiredStatement !== null) {
122 122
 			$status = CheckResult::STATUS_COMPLIANCE;
123 123
 			$message = null;
124 124
 		} else {
125 125
 			$status = CheckResult::STATUS_VIOLATION;
126
-			$message = ( new ViolationMessage( 'wbqc-violation-message-item' ) )
127
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
128
-				->withEntityId( $propertyId, Role::PREDICATE )
129
-				->withItemIdSnakValueList( $items, Role::OBJECT );
126
+			$message = (new ViolationMessage('wbqc-violation-message-item'))
127
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
128
+				->withEntityId($propertyId, Role::PREDICATE)
129
+				->withItemIdSnakValueList($items, Role::OBJECT);
130 130
 		}
131 131
 
132
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
132
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
133 133
 	}
134 134
 
135
-	public function checkConstraintParameters( Constraint $constraint ) {
135
+	public function checkConstraintParameters(Constraint $constraint) {
136 136
 		$constraintParameters = $constraint->getConstraintParameters();
137 137
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
138 138
 		$exceptions = [];
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 				$constraintParameters,
142 142
 				$constraintTypeItemId
143 143
 			);
144
-		} catch ( ConstraintParameterException $e ) {
144
+		} catch (ConstraintParameterException $e) {
145 145
 			$exceptions[] = $e;
146 146
 		}
147 147
 		try {
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 				$constraintTypeItemId,
151 151
 				false
152 152
 			);
153
-		} catch ( ConstraintParameterException $e ) {
153
+		} catch (ConstraintParameterException $e) {
154 154
 			$exceptions[] = $e;
155 155
 		}
156 156
 		return $exceptions;
Please login to merge, or discard this patch.