Inspection of "Merge "Add support for Sense and Form in LanguageC..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5411a...4acbd7 )

unknown

created 2021-06-03 12:41 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -38,9 +38,9 @@  discard block
 block discarded – undo
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, array $attributes = [], $isRawContent = false ) {
-		Assert::parameterType( 'string', $content, '$content' );
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
+	public function __construct($content, array $attributes = [], $isRawContent = false) {
+		Assert::parameterType('string', $content, '$content');
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
 
 		$this->content = $content;
 		$this->attributes = $attributes;
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
 	 * @suppress SecurityCheck-DoubleEscaped
 	 */
 	public function toHtml() {
-		if ( $this->isRawContent ) {
-			return Html::rawElement( 'td', $this->getAttributes(), $this->content );
+		if ($this->isRawContent) {
+			return Html::rawElement('td', $this->getAttributes(), $this->content);
 		} else {
-			return Html::element( 'td', $this->getAttributes(), $this->content );
+			return Html::element('td', $this->getAttributes(), $this->content);
 		}
 	}
 

Please login to merge, or discard this patch.

src/Html/HtmlTableHeaderBuilder.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -41,10 +41,10 @@  discard block
 block discarded – undo
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, $isSortable = false, $isRawContent = false ) {
-		Assert::parameterType( 'string', $content, '$content' );
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
+	public function __construct($content, $isSortable = false, $isRawContent = false) {
+		Assert::parameterType('string', $content, '$content');
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
 
 		$this->content = $content;
 		$this->isSortable = $isSortable;
@@ -71,20 +71,20 @@  discard block
 block discarded – undo
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		$attributes = [ 'role' => 'columnheader button' ];
+		$attributes = ['role' => 'columnheader button'];
 
-		if ( !$this->isSortable ) {
+		if (!$this->isSortable) {
 			$attributes['class'] = 'unsortable';
 		}
 
-		if ( !$this->isRawContent ) {
+		if (!$this->isRawContent) {
 			// @phan-suppress-next-line SecurityCheck-DoubleEscaped
-			$content = htmlspecialchars( $this->content );
+			$content = htmlspecialchars($this->content);
 		} else {
 			$content = $this->content;
 		}
 
-		return Html::rawElement( 'th', $attributes, $content );
+		return Html::rawElement('th', $attributes, $content);
 	}
 
 }

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/EntityTypeChecker.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -51,9 +51,9 @@  discard block
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -65,10 +65,10 @@  discard block
 block discarded – undo
 			'item' => $entityTypes->getEntityTypes(),
 		];
 
-		if ( !in_array( $context->getEntity()->getType(), $entityTypes->getEntityTypes() ) ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-entityType' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-				->withEntityIdList( $entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
+		if (!in_array($context->getEntity()->getType(), $entityTypes->getEntityTypes())) {
+			$message = (new ViolationMessage('wbqc-violation-message-entityType'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+				->withEntityIdList($entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
 
 			return new CheckResult(
 				$context,
@@ -79,10 +79,10 @@  discard block
 block discarded – undo
 			);
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId()
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/SymmetricChecker.php 1 patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

@@ -74,9 +74,9 @@  discard block
 block discarded – undo
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
 		$snak = $context->getSnak();
 		$propertyId = $context->getSnak()->getPropertyId();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -95,18 +95,18 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -114,23 +114,23 @@  discard block
 block discarded – undo
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $symmetricStatement !== null ) {
+		if ($symmetricStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/UniqueValueChecker.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -65,24 +65,24 @@  discard block
 block discarded – undo
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
-		if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
-			if ( $context->getType() === 'statement' ) {
+		if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
+			if ($context->getType() === 'statement') {
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
 					$context->getSnakStatement(),
 					true // ignore deprecated statements
 				);
 			} else {
 				$snak = $context->getSnak();
-				if ( !$snak instanceof PropertyValueSnak ) {
+				if (!$snak instanceof PropertyValueSnak) {
 					// nothing to check
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -95,27 +95,27 @@  discard block
 block discarded – undo
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/IntegerChecker.php 1 patch

Spacing +21 added lines, -22 removed lines patch added patch discarded remove patch

@@ -41,23 +41,22 @@  discard block
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		}
 
-		$violationMessage = $this->checkSnak( $snak );
+		$violationMessage = $this->checkSnak($snak);
 
 		return new CheckResult(
 			$context,
 			$constraint,
 			[],
 			$violationMessage === null ?
-				CheckResult::STATUS_COMPLIANCE :
-				CheckResult::STATUS_VIOLATION,
+				CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION,
 			$violationMessage
 		);
 	}
@@ -66,23 +65,23 @@  discard block
 block discarded – undo
 	 * @param PropertyValueSnak $snak
 	 * @return ViolationMessage|null
 	 */
-	public function checkSnak( PropertyValueSnak $snak ) {
+	public function checkSnak(PropertyValueSnak $snak) {
 		$dataValue = $snak->getDataValue();
 
-		if ( $dataValue instanceof DecimalValue ) {
-			if ( !$this->isInteger( $dataValue ) ) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
+		if ($dataValue instanceof DecimalValue) {
+			if (!$this->isInteger($dataValue)) {
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
 			}
-		} elseif ( $dataValue instanceof UnboundedQuantityValue ) {
-			if ( !$this->isInteger( $dataValue->getAmount() ) ) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
+		} elseif ($dataValue instanceof UnboundedQuantityValue) {
+			if (!$this->isInteger($dataValue->getAmount())) {
+				return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
 			} elseif (
 				$dataValue instanceof QuantityValue && (
-					!$this->isInteger( $dataValue->getLowerBound() ) ||
-					!$this->isInteger( $dataValue->getUpperBound() )
+					!$this->isInteger($dataValue->getLowerBound()) ||
+					!$this->isInteger($dataValue->getUpperBound())
 				)
 			) {
-				return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak );
+				return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak);
 			}
 		}
 
@@ -93,7 +92,7 @@  discard block
 block discarded – undo
 	 * @param DecimalValue $decimalValue
 	 * @return bool
 	 */
-	private function isInteger( DecimalValue $decimalValue ) {
+	private function isInteger(DecimalValue $decimalValue) {
 		return $decimalValue->getTrimmed()->getFractionalPart() === '';
 	}
 
@@ -102,13 +101,13 @@  discard block
 block discarded – undo
 	 * @param PropertyValueSnak $snak
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) {
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-			->withDataValue( $snak->getDataValue() );
+	private function getViolationMessage($messageKey, PropertyValueSnak $snak) {
+		return (new ViolationMessage($messageKey))
+			->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+			->withDataValue($snak->getDataValue());
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/NoBoundsChecker.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -39,17 +39,17 @@  discard block
 block discarded – undo
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		}
 
-		if ( $snak->getDataValue() instanceof QuantityValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-noBounds' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+		if ($snak->getDataValue() instanceof QuantityValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-noBounds'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 			return new CheckResult(
 				$context,
 				$constraint,
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
 			);
 		}
 
-		return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/InverseChecker.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -84,9 +84,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
 			$constraintParameters,
 			$constraintTypeItemId
 		);
-		$parameters['property'] = [ $propertyId ];
+		$parameters['property'] = [$propertyId];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -112,18 +112,18 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Inverse' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$inverseStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -131,23 +131,23 @@  discard block
 block discarded – undo
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $inverseStatement !== null ) {
+		if ($inverseStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-inverse' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-inverse'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php 1 patch

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -82,9 +82,9 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
 			$constraintParameters,
 			$constraintTypeItemId
 		);
-		$parameters['property'] = [ $propertyId ];
+		$parameters['property'] = [$propertyId];
 
 		$items = $this->constraintParameterParser->parseItemsParameter(
 			$constraintParameters,
@@ -106,9 +106,9 @@  discard block
 block discarded – undo
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -117,18 +117,18 @@  discard block
 block discarded – undo
 		 * error handling:
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/*
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$targetEntity->getStatements(),
 				$propertyId
@@ -149,23 +149,23 @@  discard block
 block discarded – undo
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

		@@ -38,9 +38,9 @@ discard block
		block discarded – undo
38	38	*
39	39	* @throws InvalidArgumentException
40	40	*/
41		- public function __construct( $content, array $attributes = [], $isRawContent = false ) {
42		- Assert::parameterType( 'string', $content, '$content' );
43		- Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
	41	+ public function __construct($content, array $attributes = [], $isRawContent = false) {
	42	+ Assert::parameterType('string', $content, '$content');
	43	+ Assert::parameterType('boolean', $isRawContent, '$isRawContent');
44	44
45	45	$this->content = $content;
46	46	$this->attributes = $attributes;
		@@ -66,10 +66,10 @@ discard block
		block discarded – undo
66	66	* @suppress SecurityCheck-DoubleEscaped
67	67	*/
68	68	public function toHtml() {
69		- if ( $this->isRawContent ) {
70		- return Html::rawElement( 'td', $this->getAttributes(), $this->content );
	69	+ if ($this->isRawContent) {
	70	+ return Html::rawElement('td', $this->getAttributes(), $this->content);
71	71	} else {
72		- return Html::element( 'td', $this->getAttributes(), $this->content );
	72	+ return Html::element('td', $this->getAttributes(), $this->content);
73	73	}
74	74	}
75	75

		@@ -41,10 +41,10 @@ discard block
		block discarded – undo
41	41	*
42	42	* @throws InvalidArgumentException
43	43	*/
44		- public function __construct( $content, $isSortable = false, $isRawContent = false ) {
45		- Assert::parameterType( 'string', $content, '$content' );
46		- Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
47		- Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
	44	+ public function __construct($content, $isSortable = false, $isRawContent = false) {
	45	+ Assert::parameterType('string', $content, '$content');
	46	+ Assert::parameterType('boolean', $isSortable, '$isSortable');
	47	+ Assert::parameterType('boolean', $isRawContent, '$isRawContent');
48	48
49	49	$this->content = $content;
50	50	$this->isSortable = $isSortable;
		@@ -71,20 +71,20 @@ discard block
		block discarded – undo
71	71	* @return string HTML
72	72	*/
73	73	public function toHtml() {
74		- $attributes = [ 'role' => 'columnheader button' ];
	74	+ $attributes = ['role' => 'columnheader button'];
75	75
76		- if ( !$this->isSortable ) {
	76	+ if (!$this->isSortable) {
77	77	$attributes['class'] = 'unsortable';
78	78	}
79	79
80		- if ( !$this->isRawContent ) {
	80	+ if (!$this->isRawContent) {
81	81	// @phan-suppress-next-line SecurityCheck-DoubleEscaped
82		- $content = htmlspecialchars( $this->content );
	82	+ $content = htmlspecialchars($this->content);
83	83	} else {
84	84	$content = $this->content;
85	85	}
86	86
87		- return Html::rawElement( 'th', $attributes, $content );
	87	+ return Html::rawElement('th', $attributes, $content);
88	88	}
89	89
90	90	}

		@@ -51,9 +51,9 @@ discard block
		block discarded – undo
51	51	];
52	52	}
53	53
54		- public function checkConstraint( Context $context, Constraint $constraint ) {
55		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
56		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	54	+ public function checkConstraint(Context $context, Constraint $constraint) {
	55	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	56	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
57	57	}
58	58
59	59	$constraintParameters = $constraint->getConstraintParameters();
		@@ -65,10 +65,10 @@ discard block
		block discarded – undo
65	65	'item' => $entityTypes->getEntityTypes(),
66	66	];
67	67
68		- if ( !in_array( $context->getEntity()->getType(), $entityTypes->getEntityTypes() ) ) {
69		- $message = ( new ViolationMessage( 'wbqc-violation-message-entityType' ) )
70		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
71		- ->withEntityIdList( $entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE );
	68	+ if (!in_array($context->getEntity()->getType(), $entityTypes->getEntityTypes())) {
	69	+ $message = (new ViolationMessage('wbqc-violation-message-entityType'))
	70	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	71	+ ->withEntityIdList($entityTypes->getEntityTypeItemIds(), Role::CONSTRAINT_PARAMETER_VALUE);
72	72
73	73	return new CheckResult(
74	74	$context,
		@@ -79,10 +79,10 @@ discard block
		block discarded – undo
79	79	);
80	80	}
81	81
82		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	82	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
83	83	}
84	84
85		- public function checkConstraintParameters( Constraint $constraint ) {
	85	+ public function checkConstraintParameters(Constraint $constraint) {
86	86	$constraintParameters = $constraint->getConstraintParameters();
87	87	$exceptions = [];
88	88	try {
		@@ -90,7 +90,7 @@ discard block
		block discarded – undo
90	90	$constraintParameters,
91	91	$constraint->getConstraintTypeItemId()
92	92	);
93		- } catch ( ConstraintParameterException $e ) {
	93	+ } catch (ConstraintParameterException $e) {
94	94	$exceptions[] = $e;
95	95	}
96	96	return $exceptions;

		@@ -74,9 +74,9 @@ discard block
		block discarded – undo
74	74	*
75	75	* @return CheckResult
76	76	*/
77		- public function checkConstraint( Context $context, Constraint $constraint ) {
78		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
79		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	77	+ public function checkConstraint(Context $context, Constraint $constraint) {
	78	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	79	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
80	80	}
81	81
82	82	$parameters = [];
		@@ -84,9 +84,9 @@ discard block
		block discarded – undo
84	84	$snak = $context->getSnak();
85	85	$propertyId = $context->getSnak()->getPropertyId();
86	86
87		- if ( !$snak instanceof PropertyValueSnak ) {
	87	+ if (!$snak instanceof PropertyValueSnak) {
88	88	// nothing to check
89		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	89	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
90	90	}
91	91
92	92	$dataValue = $snak->getDataValue();
		@@ -95,18 +95,18 @@ discard block
		block discarded – undo
95	95	* error handling:
96	96	* type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
97	97	*/
98		- if ( !$dataValue instanceof EntityIdValue ) {
99		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
100		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
101		- ->withDataValueType( 'wikibase-entityid' );
102		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	98	+ if (!$dataValue instanceof EntityIdValue) {
	99	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	100	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
	101	+ ->withDataValueType('wikibase-entityid');
	102	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
103	103	}
104	104
105	105	$targetEntityId = $dataValue->getEntityId();
106		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
107		- if ( !$targetEntity instanceof StatementListProvider ) {
108		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
109		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	106	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	107	+ if (!$targetEntity instanceof StatementListProvider) {
	108	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	109	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
110	110	}
111	111
112	112	$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
		@@ -114,23 +114,23 @@ discard block
		block discarded – undo
114	114	$propertyId,
115	115	$context->getEntity()->getId()
116	116	);
117		- if ( $symmetricStatement !== null ) {
	117	+ if ($symmetricStatement !== null) {
118	118	$message = null;
119	119	$status = CheckResult::STATUS_COMPLIANCE;
120	120	} else {
121		- $message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
122		- ->withEntityId( $targetEntityId, Role::SUBJECT )
123		- ->withEntityId( $propertyId, Role::PREDICATE )
124		- ->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
	121	+ $message = (new ViolationMessage('wbqc-violation-message-symmetric'))
	122	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	123	+ ->withEntityId($propertyId, Role::PREDICATE)
	124	+ ->withEntityId($context->getEntity()->getId(), Role::OBJECT);
125	125	$status = CheckResult::STATUS_VIOLATION;
126	126	}
127	127
128		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
129		- ->withMetadata( Metadata::ofDependencyMetadata(
130		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	128	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	129	+ ->withMetadata(Metadata::ofDependencyMetadata(
	130	+ DependencyMetadata::ofEntityId($targetEntityId) ));
131	131	}
132	132
133		- public function checkConstraintParameters( Constraint $constraint ) {
	133	+ public function checkConstraintParameters(Constraint $constraint) {
134	134	// no parameters
135	135	return [];
136	136	}

		@@ -65,24 +65,24 @@ discard block
		block discarded – undo
65	65	* @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
66	66	* @return CheckResult
67	67	*/
68		- public function checkConstraint( Context $context, Constraint $constraint ) {
69		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
70		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	68	+ public function checkConstraint(Context $context, Constraint $constraint) {
	69	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	70	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
71	71	}
72	72
73	73	$parameters = [];
74	74
75		- if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
76		- if ( $context->getType() === 'statement' ) {
	75	+ if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
	76	+ if ($context->getType() === 'statement') {
77	77	$result = $this->sparqlHelper->findEntitiesWithSameStatement(
78	78	$context->getSnakStatement(),
79	79	true // ignore deprecated statements
80	80	);
81	81	} else {
82	82	$snak = $context->getSnak();
83		- if ( !$snak instanceof PropertyValueSnak ) {
	83	+ if (!$snak instanceof PropertyValueSnak) {
84	84	// nothing to check
85		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	85	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
86	86	}
87	87	$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
88	88	$context->getEntity()->getId(),
		@@ -95,27 +95,27 @@ discard block
		block discarded – undo
95	95	$otherEntities = $result->getArray();
96	96	$metadata = $result->getMetadata();
97	97
98		- if ( $otherEntities === [] ) {
	98	+ if ($otherEntities === []) {
99	99	$status = CheckResult::STATUS_COMPLIANCE;
100	100	$message = null;
101	101	} else {
102		- $otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
	102	+ $otherEntities = array_values(array_filter($otherEntities)); // remove nulls
103	103	$status = CheckResult::STATUS_VIOLATION;
104		- $message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
105		- ->withEntityIdList( $otherEntities, Role::SUBJECT );
	104	+ $message = (new ViolationMessage('wbqc-violation-message-unique-value'))
	105	+ ->withEntityIdList($otherEntities, Role::SUBJECT);
106	106	}
107	107	} else {
108	108	$status = CheckResult::STATUS_TODO;
109		- $message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
110		- ->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
	109	+ $message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
	110	+ ->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
111	111	$metadata = Metadata::blank();
112	112	}
113	113
114		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
115		- ->withMetadata( $metadata );
	114	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	115	+ ->withMetadata($metadata);
116	116	}
117	117
118		- public function checkConstraintParameters( Constraint $constraint ) {
	118	+ public function checkConstraintParameters(Constraint $constraint) {
119	119	// no parameters
120	120	return [];
121	121	}

		@@ -41,23 +41,22 @@ discard block
		block discarded – undo
41	41	];
42	42	}
43	43
44		- public function checkConstraint( Context $context, Constraint $constraint ) {
	44	+ public function checkConstraint(Context $context, Constraint $constraint) {
45	45	$snak = $context->getSnak();
46	46
47		- if ( !$snak instanceof PropertyValueSnak ) {
	47	+ if (!$snak instanceof PropertyValueSnak) {
48	48	// nothing to check
49		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	49	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
50	50	}
51	51
52		- $violationMessage = $this->checkSnak( $snak );
	52	+ $violationMessage = $this->checkSnak($snak);
53	53
54	54	return new CheckResult(
55	55	$context,
56	56	$constraint,
57	57	[],
58	58	$violationMessage === null ?
59		- CheckResult::STATUS_COMPLIANCE :
60		- CheckResult::STATUS_VIOLATION,
	59	+ CheckResult::STATUS_COMPLIANCE : CheckResult::STATUS_VIOLATION,
61	60	$violationMessage
62	61	);
63	62	}
		@@ -66,23 +65,23 @@ discard block
		block discarded – undo
66	65	* @param PropertyValueSnak $snak
67	66	* @return ViolationMessage\|null
68	67	*/
69		- public function checkSnak( PropertyValueSnak $snak ) {
	68	+ public function checkSnak(PropertyValueSnak $snak) {
70	69	$dataValue = $snak->getDataValue();
71	70
72		- if ( $dataValue instanceof DecimalValue ) {
73		- if ( !$this->isInteger( $dataValue ) ) {
74		- return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
	71	+ if ($dataValue instanceof DecimalValue) {
	72	+ if (!$this->isInteger($dataValue)) {
	73	+ return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
75	74	}
76		- } elseif ( $dataValue instanceof UnboundedQuantityValue ) {
77		- if ( !$this->isInteger( $dataValue->getAmount() ) ) {
78		- return $this->getViolationMessage( 'wbqc-violation-message-integer', $snak );
	75	+ } elseif ($dataValue instanceof UnboundedQuantityValue) {
	76	+ if (!$this->isInteger($dataValue->getAmount())) {
	77	+ return $this->getViolationMessage('wbqc-violation-message-integer', $snak);
79	78	} elseif (
80	79	$dataValue instanceof QuantityValue && (
81		- !$this->isInteger( $dataValue->getLowerBound() ) \|\|
82		- !$this->isInteger( $dataValue->getUpperBound() )
	80	+ !$this->isInteger($dataValue->getLowerBound()) \|\|
	81	+ !$this->isInteger($dataValue->getUpperBound())
83	82	)
84	83	) {
85		- return $this->getViolationMessage( 'wbqc-violation-message-integer-bounds', $snak );
	84	+ return $this->getViolationMessage('wbqc-violation-message-integer-bounds', $snak);
86	85	}
87	86	}
88	87
		@@ -93,7 +92,7 @@ discard block
		block discarded – undo
93	92	* @param DecimalValue $decimalValue
94	93	* @return bool
95	94	*/
96		- private function isInteger( DecimalValue $decimalValue ) {
	95	+ private function isInteger(DecimalValue $decimalValue) {
97	96	return $decimalValue->getTrimmed()->getFractionalPart() === '';
98	97	}
99	98
		@@ -102,13 +101,13 @@ discard block
		block discarded – undo
102	101	* @param PropertyValueSnak $snak
103	102	* @return ViolationMessage
104	103	*/
105		- private function getViolationMessage( $messageKey, PropertyValueSnak $snak ) {
106		- return ( new ViolationMessage( $messageKey ) )
107		- ->withEntityId( $snak->getPropertyId(), Role::CONSTRAINT_PROPERTY )
108		- ->withDataValue( $snak->getDataValue() );
	104	+ private function getViolationMessage($messageKey, PropertyValueSnak $snak) {
	105	+ return (new ViolationMessage($messageKey))
	106	+ ->withEntityId($snak->getPropertyId(), Role::CONSTRAINT_PROPERTY)
	107	+ ->withDataValue($snak->getDataValue());
109	108	}
110	109
111		- public function checkConstraintParameters( Constraint $constraint ) {
	110	+ public function checkConstraintParameters(Constraint $constraint) {
112	111	// no parameters
113	112	return [];
114	113	}

		@@ -39,17 +39,17 @@ discard block
		block discarded – undo
39	39	];
40	40	}
41	41
42		- public function checkConstraint( Context $context, Constraint $constraint ) {
	42	+ public function checkConstraint(Context $context, Constraint $constraint) {
43	43	$snak = $context->getSnak();
44	44
45		- if ( !$snak instanceof PropertyValueSnak ) {
	45	+ if (!$snak instanceof PropertyValueSnak) {
46	46	// nothing to check
47		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	47	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
48	48	}
49	49
50		- if ( $snak->getDataValue() instanceof QuantityValue ) {
51		- $message = ( new ViolationMessage( 'wbqc-violation-message-noBounds' ) )
52		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
	50	+ if ($snak->getDataValue() instanceof QuantityValue) {
	51	+ $message = (new ViolationMessage('wbqc-violation-message-noBounds'))
	52	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
53	53	return new CheckResult(
54	54	$context,
55	55	$constraint,
		@@ -59,10 +59,10 @@ discard block
		block discarded – undo
59	59	);
60	60	}
61	61
62		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
	62	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
63	63	}
64	64
65		- public function checkConstraintParameters( Constraint $constraint ) {
	65	+ public function checkConstraintParameters(Constraint $constraint) {
66	66	// no parameters
67	67	return [];
68	68	}

		@@ -84,9 +84,9 @@ discard block
		block discarded – undo
84	84	* @throws ConstraintParameterException
85	85	* @return CheckResult
86	86	*/
87		- public function checkConstraint( Context $context, Constraint $constraint ) {
88		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
89		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	87	+ public function checkConstraint(Context $context, Constraint $constraint) {
	88	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	89	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
90	90	}
91	91
92	92	$parameters = [];
		@@ -97,13 +97,13 @@ discard block
		block discarded – undo
97	97	$constraintParameters,
98	98	$constraintTypeItemId
99	99	);
100		- $parameters['property'] = [ $propertyId ];
	100	+ $parameters['property'] = [$propertyId];
101	101
102	102	$snak = $context->getSnak();
103	103
104		- if ( !$snak instanceof PropertyValueSnak ) {
	104	+ if (!$snak instanceof PropertyValueSnak) {
105	105	// nothing to check
106		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	106	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
107	107	}
108	108
109	109	$dataValue = $snak->getDataValue();
		@@ -112,18 +112,18 @@ discard block
		block discarded – undo
112	112	* error handling:
113	113	* type of $dataValue for properties with 'Inverse' constraint has to be 'wikibase-entityid'
114	114	*/
115		- if ( !$dataValue instanceof EntityIdValue ) {
116		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
117		- ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
118		- ->withDataValueType( 'wikibase-entityid' );
119		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	115	+ if (!$dataValue instanceof EntityIdValue) {
	116	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	117	+ ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
	118	+ ->withDataValueType('wikibase-entityid');
	119	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
120	120	}
121	121
122	122	$targetEntityId = $dataValue->getEntityId();
123		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
124		- if ( !$targetEntity instanceof StatementListProvider ) {
125		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
126		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	123	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	124	+ if (!$targetEntity instanceof StatementListProvider) {
	125	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	126	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
127	127	}
128	128
129	129	$inverseStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
		@@ -131,23 +131,23 @@ discard block
		block discarded – undo
131	131	$propertyId,
132	132	$context->getEntity()->getId()
133	133	);
134		- if ( $inverseStatement !== null ) {
	134	+ if ($inverseStatement !== null) {
135	135	$message = null;
136	136	$status = CheckResult::STATUS_COMPLIANCE;
137	137	} else {
138		- $message = ( new ViolationMessage( 'wbqc-violation-message-inverse' ) )
139		- ->withEntityId( $targetEntityId, Role::SUBJECT )
140		- ->withEntityId( $propertyId, Role::PREDICATE )
141		- ->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
	138	+ $message = (new ViolationMessage('wbqc-violation-message-inverse'))
	139	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	140	+ ->withEntityId($propertyId, Role::PREDICATE)
	141	+ ->withEntityId($context->getEntity()->getId(), Role::OBJECT);
142	142	$status = CheckResult::STATUS_VIOLATION;
143	143	}
144	144
145		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
146		- ->withMetadata( Metadata::ofDependencyMetadata(
147		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	145	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	146	+ ->withMetadata(Metadata::ofDependencyMetadata(
	147	+ DependencyMetadata::ofEntityId($targetEntityId) ));
148	148	}
149	149
150		- public function checkConstraintParameters( Constraint $constraint ) {
	150	+ public function checkConstraintParameters(Constraint $constraint) {
151	151	$constraintParameters = $constraint->getConstraintParameters();
152	152	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
153	153	$exceptions = [];
		@@ -156,7 +156,7 @@ discard block
		block discarded – undo
156	156	$constraintParameters,
157	157	$constraintTypeItemId
158	158	);
159		- } catch ( ConstraintParameterException $e ) {
	159	+ } catch (ConstraintParameterException $e) {
160	160	$exceptions[] = $e;
161	161	}
162	162	return $exceptions;

		@@ -82,9 +82,9 @@ discard block
		block discarded – undo
82	82	* @throws ConstraintParameterException
83	83	* @return CheckResult
84	84	*/
85		- public function checkConstraint( Context $context, Constraint $constraint ) {
86		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
87		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	85	+ public function checkConstraint(Context $context, Constraint $constraint) {
	86	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	87	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
88	88	}
89	89
90	90	$parameters = [];
		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	$constraintParameters,
96	96	$constraintTypeItemId
97	97	);
98		- $parameters['property'] = [ $propertyId ];
	98	+ $parameters['property'] = [$propertyId];
99	99
100	100	$items = $this->constraintParameterParser->parseItemsParameter(
101	101	$constraintParameters,
		@@ -106,9 +106,9 @@ discard block
		block discarded – undo
106	106
107	107	$snak = $context->getSnak();
108	108
109		- if ( !$snak instanceof PropertyValueSnak ) {
	109	+ if (!$snak instanceof PropertyValueSnak) {
110	110	// nothing to check
111		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
	111	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
112	112	}
113	113
114	114	$dataValue = $snak->getDataValue();
		@@ -117,18 +117,18 @@ discard block
		block discarded – undo
117	117	* error handling:
118	118	* type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
119	119	*/
120		- if ( !$dataValue instanceof EntityIdValue ) {
121		- $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
122		- ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
123		- ->withDataValueType( 'wikibase-entityid' );
124		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	120	+ if (!$dataValue instanceof EntityIdValue) {
	121	+ $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
	122	+ ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
	123	+ ->withDataValueType('wikibase-entityid');
	124	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
125	125	}
126	126
127	127	$targetEntityId = $dataValue->getEntityId();
128		- $targetEntity = $this->entityLookup->getEntity( $targetEntityId );
129		- if ( !$targetEntity instanceof StatementListProvider ) {
130		- $message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
131		- return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
	128	+ $targetEntity = $this->entityLookup->getEntity($targetEntityId);
	129	+ if (!$targetEntity instanceof StatementListProvider) {
	130	+ $message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
	131	+ return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
132	132	}
133	133
134	134	/*
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	* a) a property only
137	137	* b) a property and a number of items (each combination forming an individual claim)
138	138	*/
139		- if ( $items === [] ) {
	139	+ if ($items === []) {
140	140	$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
141	141	$targetEntity->getStatements(),
142	142	$propertyId
		@@ -149,23 +149,23 @@ discard block
		block discarded – undo
149	149	);
150	150	}
151	151
152		- if ( $requiredStatement !== null ) {
	152	+ if ($requiredStatement !== null) {
153	153	$status = CheckResult::STATUS_COMPLIANCE;
154	154	$message = null;
155	155	} else {
156	156	$status = CheckResult::STATUS_VIOLATION;
157		- $message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
158		- ->withEntityId( $targetEntityId, Role::SUBJECT )
159		- ->withEntityId( $propertyId, Role::PREDICATE )
160		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	157	+ $message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
	158	+ ->withEntityId($targetEntityId, Role::SUBJECT)
	159	+ ->withEntityId($propertyId, Role::PREDICATE)
	160	+ ->withItemIdSnakValueList($items, Role::OBJECT);
161	161	}
162	162
163		- return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
164		- ->withMetadata( Metadata::ofDependencyMetadata(
165		- DependencyMetadata::ofEntityId( $targetEntityId ) ) );
	163	+ return (new CheckResult($context, $constraint, $parameters, $status, $message))
	164	+ ->withMetadata(Metadata::ofDependencyMetadata(
	165	+ DependencyMetadata::ofEntityId($targetEntityId) ));
166	166	}
167	167
168		- public function checkConstraintParameters( Constraint $constraint ) {
	168	+ public function checkConstraintParameters(Constraint $constraint) {
169	169	$constraintParameters = $constraint->getConstraintParameters();
170	170	$constraintTypeItemId = $constraint->getConstraintTypeItemId();
171	171	$exceptions = [];
		@@ -174,7 +174,7 @@ discard block
		block discarded – undo
174	174	$constraintParameters,
175	175	$constraintTypeItemId
176	176	);
177		- } catch ( ConstraintParameterException $e ) {
	177	+ } catch (ConstraintParameterException $e) {
178	178	$exceptions[] = $e;
179	179	}
180	180	try {
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	$constraintTypeItemId,
184	184	false
185	185	);
186		- } catch ( ConstraintParameterException $e ) {
	186	+ } catch (ConstraintParameterException $e) {
187	187	$exceptions[] = $e;
188	188	}
189	189	return $exceptions;

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( c5411a...4acbd7 )

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +21 added lines, -22 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch