@@ -36,29 +36,29 @@ discard block |
||
36 | 36 | $propertyId, |
37 | 37 | $statementGuid |
38 | 38 | ) { |
39 | - if ( !array_key_exists( $entityId, $container ) ) { |
|
39 | + if (!array_key_exists($entityId, $container)) { |
|
40 | 40 | $container[$entityId] = []; |
41 | 41 | } |
42 | 42 | $entityContainer = &$container[$entityId]; |
43 | 43 | |
44 | - if ( !array_key_exists( 'claims', $entityContainer ) ) { |
|
44 | + if (!array_key_exists('claims', $entityContainer)) { |
|
45 | 45 | $entityContainer['claims'] = []; |
46 | 46 | } |
47 | 47 | $claimsContainer = &$entityContainer['claims']; |
48 | 48 | |
49 | - if ( !array_key_exists( $propertyId, $claimsContainer ) ) { |
|
49 | + if (!array_key_exists($propertyId, $claimsContainer)) { |
|
50 | 50 | $claimsContainer[$propertyId] = []; |
51 | 51 | } |
52 | 52 | $propertyContainer = &$claimsContainer[$propertyId]; |
53 | 53 | |
54 | - foreach ( $propertyContainer as &$statement ) { |
|
55 | - if ( $statement['id'] === $statementGuid ) { |
|
54 | + foreach ($propertyContainer as &$statement) { |
|
55 | + if ($statement['id'] === $statementGuid) { |
|
56 | 56 | $statementArray = &$statement; |
57 | 57 | break; |
58 | 58 | } |
59 | 59 | } |
60 | - if ( !isset( $statementArray ) ) { |
|
61 | - $statementArray = [ 'id' => $statementGuid ]; |
|
60 | + if (!isset($statementArray)) { |
|
61 | + $statementArray = ['id' => $statementGuid]; |
|
62 | 62 | $propertyContainer[] = &$statementArray; |
63 | 63 | } |
64 | 64 | |
@@ -73,19 +73,19 @@ discard block |
||
73 | 73 | * @param array[] &$container |
74 | 74 | * @return array |
75 | 75 | */ |
76 | - abstract protected function &getMainArray( array &$container ); |
|
76 | + abstract protected function &getMainArray(array &$container); |
|
77 | 77 | |
78 | 78 | /** |
79 | 79 | * @param array|null $result |
80 | 80 | * @param array[] &$container |
81 | 81 | */ |
82 | - public function storeCheckResultInArray( array $result = null, array &$container ) { |
|
83 | - $mainArray = &$this->getMainArray( $container ); |
|
84 | - if ( !array_key_exists( 'results', $mainArray ) ) { |
|
82 | + public function storeCheckResultInArray(array $result = null, array &$container) { |
|
83 | + $mainArray = &$this->getMainArray($container); |
|
84 | + if (!array_key_exists('results', $mainArray)) { |
|
85 | 85 | $mainArray['results'] = []; |
86 | 86 | } |
87 | 87 | |
88 | - if ( $result !== null ) { |
|
88 | + if ($result !== null) { |
|
89 | 89 | $mainArray['results'][] = $result; |
90 | 90 | } |
91 | 91 | } |
@@ -29,9 +29,9 @@ discard block |
||
29 | 29 | * @param int $maxAge The maximum age of the cached value (in seconds). |
30 | 30 | * @return self Indication that a value is possibly outdated by up to this many seconds. |
31 | 31 | */ |
32 | - public static function ofMaximumAgeInSeconds( $maxAge ) { |
|
33 | - Assert::parameterType( 'integer', $maxAge, '$maxAge' ); |
|
34 | - Assert::parameter( $maxAge > 0, '$maxAge', '$maxage > 0' ); |
|
32 | + public static function ofMaximumAgeInSeconds($maxAge) { |
|
33 | + Assert::parameterType('integer', $maxAge, '$maxAge'); |
|
34 | + Assert::parameter($maxAge > 0, '$maxAge', '$maxage > 0'); |
|
35 | 35 | $ret = new self; |
36 | 36 | $ret->maxAge = $maxAge; |
37 | 37 | return $ret; |
@@ -42,9 +42,9 @@ discard block |
||
42 | 42 | * @param array|null $array As returned by toArray. |
43 | 43 | * @return self |
44 | 44 | */ |
45 | - public static function ofArray( array $array = null ) { |
|
45 | + public static function ofArray(array $array = null) { |
|
46 | 46 | $ret = new self; |
47 | - if ( $array !== null ) { |
|
47 | + if ($array !== null) { |
|
48 | 48 | $ret->maxAge = $array['maximumAgeInSeconds']; |
49 | 49 | } |
50 | 50 | return $ret; |
@@ -54,11 +54,11 @@ discard block |
||
54 | 54 | * @param self[] $metadatas |
55 | 55 | * @return self |
56 | 56 | */ |
57 | - public static function merge( array $metadatas ) { |
|
58 | - Assert::parameterElementType( self::class, $metadatas, '$metadatas' ); |
|
57 | + public static function merge(array $metadatas) { |
|
58 | + Assert::parameterElementType(self::class, $metadatas, '$metadatas'); |
|
59 | 59 | $ret = new self; |
60 | - foreach ( $metadatas as $metadata ) { |
|
61 | - $ret->maxAge = max( $ret->maxAge, $metadata->maxAge ); |
|
60 | + foreach ($metadatas as $metadata) { |
|
61 | + $ret->maxAge = max($ret->maxAge, $metadata->maxAge); |
|
62 | 62 | } |
63 | 63 | return $ret; |
64 | 64 | } |
@@ -76,7 +76,7 @@ discard block |
||
76 | 76 | * For a fresh value, returns 0. |
77 | 77 | */ |
78 | 78 | public function getMaximumAgeInSeconds() { |
79 | - if ( is_int( $this->maxAge ) ) { |
|
79 | + if (is_int($this->maxAge)) { |
|
80 | 80 | return $this->maxAge; |
81 | 81 | } else { |
82 | 82 | return 0; |
@@ -91,8 +91,7 @@ discard block |
||
91 | 91 | return $this->isCached() ? |
92 | 92 | [ |
93 | 93 | 'maximumAgeInSeconds' => $this->maxAge, |
94 | - ] : |
|
95 | - null; |
|
94 | + ] : null; |
|
96 | 95 | } |
97 | 96 | |
98 | 97 | } |
@@ -64,20 +64,20 @@ discard block |
||
64 | 64 | * |
65 | 65 | * @return string HTML |
66 | 66 | */ |
67 | - public function formatValue( $value ) { |
|
68 | - if ( is_string( $value ) ) { |
|
67 | + public function formatValue($value) { |
|
68 | + if (is_string($value)) { |
|
69 | 69 | // Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as |
70 | 70 | // strings |
71 | - return htmlspecialchars( $value ); |
|
72 | - } elseif ( $value instanceof EntityId ) { |
|
71 | + return htmlspecialchars($value); |
|
72 | + } elseif ($value instanceof EntityId) { |
|
73 | 73 | // Cases like 'Conflicts with' 'property', to which we can link |
74 | - return $this->formatEntityId( $value ); |
|
75 | - } elseif ( $value instanceof ItemIdSnakValue ) { |
|
74 | + return $this->formatEntityId($value); |
|
75 | + } elseif ($value instanceof ItemIdSnakValue) { |
|
76 | 76 | // Cases like EntityId but can also be somevalue or novalue |
77 | - return $this->formatItemIdSnakValue( $value ); |
|
77 | + return $this->formatItemIdSnakValue($value); |
|
78 | 78 | } else { |
79 | 79 | // Cases where we format a DataValue |
80 | - return $this->formatDataValue( $value ); |
|
80 | + return $this->formatDataValue($value); |
|
81 | 81 | } |
82 | 82 | } |
83 | 83 | |
@@ -88,23 +88,23 @@ discard block |
||
88 | 88 | * |
89 | 89 | * @return string HTML |
90 | 90 | */ |
91 | - public function formatParameters( $parameters ) { |
|
92 | - if ( $parameters === null || count( $parameters ) == 0 ) { |
|
91 | + public function formatParameters($parameters) { |
|
92 | + if ($parameters === null || count($parameters) == 0) { |
|
93 | 93 | return null; |
94 | 94 | } |
95 | 95 | |
96 | - $valueFormatter = function ( $value ) { |
|
97 | - return $this->formatValue( $value ); |
|
96 | + $valueFormatter = function($value) { |
|
97 | + return $this->formatValue($value); |
|
98 | 98 | }; |
99 | 99 | |
100 | 100 | $formattedParameters = []; |
101 | - foreach ( $parameters as $parameterName => $parameterValue ) { |
|
102 | - $formattedParameterValues = implode( ', ', |
|
103 | - $this->limitArrayLength( array_map( $valueFormatter, $parameterValue ) ) ); |
|
104 | - $formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues ); |
|
101 | + foreach ($parameters as $parameterName => $parameterValue) { |
|
102 | + $formattedParameterValues = implode(', ', |
|
103 | + $this->limitArrayLength(array_map($valueFormatter, $parameterValue))); |
|
104 | + $formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues); |
|
105 | 105 | } |
106 | 106 | |
107 | - return implode( '; ', $formattedParameters ); |
|
107 | + return implode('; ', $formattedParameters); |
|
108 | 108 | } |
109 | 109 | |
110 | 110 | /** |
@@ -114,10 +114,10 @@ discard block |
||
114 | 114 | * |
115 | 115 | * @return array |
116 | 116 | */ |
117 | - private function limitArrayLength( array $array ) { |
|
118 | - if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) { |
|
119 | - $array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH ); |
|
120 | - array_push( $array, '...' ); |
|
117 | + private function limitArrayLength(array $array) { |
|
118 | + if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) { |
|
119 | + $array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH); |
|
120 | + array_push($array, '...'); |
|
121 | 121 | } |
122 | 122 | |
123 | 123 | return $array; |
@@ -130,12 +130,12 @@ discard block |
||
130 | 130 | * @param string $value HTML |
131 | 131 | * @return string HTML |
132 | 132 | */ |
133 | - public static function formatByRole( $role, $value ) { |
|
134 | - if ( $role === null ) { |
|
133 | + public static function formatByRole($role, $value) { |
|
134 | + if ($role === null) { |
|
135 | 135 | return $value; |
136 | 136 | } |
137 | 137 | |
138 | - return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">' |
|
138 | + return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">' |
|
139 | 139 | . $value |
140 | 140 | . '</span>'; |
141 | 141 | } |
@@ -145,9 +145,9 @@ discard block |
||
145 | 145 | * @param string|null $role one of the Role constants or null |
146 | 146 | * @return string HTML |
147 | 147 | */ |
148 | - public function formatDataValue( DataValue $value, $role = null ) { |
|
149 | - return self::formatByRole( $role, |
|
150 | - $this->dataValueFormatter->format( $value ) ); |
|
148 | + public function formatDataValue(DataValue $value, $role = null) { |
|
149 | + return self::formatByRole($role, |
|
150 | + $this->dataValueFormatter->format($value)); |
|
151 | 151 | } |
152 | 152 | |
153 | 153 | /** |
@@ -155,9 +155,9 @@ discard block |
||
155 | 155 | * @param string|null $role one of the Role constants or null |
156 | 156 | * @return string HTML |
157 | 157 | */ |
158 | - public function formatEntityId( EntityId $entityId, $role = null ) { |
|
159 | - return self::formatByRole( $role, |
|
160 | - $this->entityIdLabelFormatter->formatEntityId( $entityId ) ); |
|
158 | + public function formatEntityId(EntityId $entityId, $role = null) { |
|
159 | + return self::formatByRole($role, |
|
160 | + $this->entityIdLabelFormatter->formatEntityId($entityId)); |
|
161 | 161 | } |
162 | 162 | |
163 | 163 | /** |
@@ -169,18 +169,18 @@ discard block |
||
169 | 169 | * @param string|null $role one of the Role constants or null |
170 | 170 | * @return string HTML |
171 | 171 | */ |
172 | - public function formatPropertyId( $propertyId, $role = null ) { |
|
173 | - if ( $propertyId instanceof PropertyId ) { |
|
174 | - return $this->formatEntityId( $propertyId, $role ); |
|
175 | - } elseif ( is_string( $propertyId ) ) { |
|
172 | + public function formatPropertyId($propertyId, $role = null) { |
|
173 | + if ($propertyId instanceof PropertyId) { |
|
174 | + return $this->formatEntityId($propertyId, $role); |
|
175 | + } elseif (is_string($propertyId)) { |
|
176 | 176 | try { |
177 | - return $this->formatEntityId( new PropertyId( $propertyId ), $role ); |
|
178 | - } catch ( InvalidArgumentException $e ) { |
|
179 | - return self::formatByRole( $role, |
|
180 | - htmlspecialchars( $propertyId ) ); |
|
177 | + return $this->formatEntityId(new PropertyId($propertyId), $role); |
|
178 | + } catch (InvalidArgumentException $e) { |
|
179 | + return self::formatByRole($role, |
|
180 | + htmlspecialchars($propertyId)); |
|
181 | 181 | } |
182 | 182 | } else { |
183 | - throw new InvalidArgumentException( '$propertyId must be either PropertyId or string' ); |
|
183 | + throw new InvalidArgumentException('$propertyId must be either PropertyId or string'); |
|
184 | 184 | } |
185 | 185 | } |
186 | 186 | |
@@ -193,18 +193,18 @@ discard block |
||
193 | 193 | * @param string|null $role one of the Role constants or null |
194 | 194 | * @return string HTML |
195 | 195 | */ |
196 | - public function formatItemId( $itemId, $role = null ) { |
|
197 | - if ( $itemId instanceof ItemId ) { |
|
198 | - return $this->formatEntityId( $itemId, $role ); |
|
199 | - } elseif ( is_string( $itemId ) ) { |
|
196 | + public function formatItemId($itemId, $role = null) { |
|
197 | + if ($itemId instanceof ItemId) { |
|
198 | + return $this->formatEntityId($itemId, $role); |
|
199 | + } elseif (is_string($itemId)) { |
|
200 | 200 | try { |
201 | - return $this->formatEntityId( new ItemId( $itemId ), $role ); |
|
202 | - } catch ( InvalidArgumentException $e ) { |
|
203 | - return self::formatByRole( $role, |
|
204 | - htmlspecialchars( $itemId ) ); |
|
201 | + return $this->formatEntityId(new ItemId($itemId), $role); |
|
202 | + } catch (InvalidArgumentException $e) { |
|
203 | + return self::formatByRole($role, |
|
204 | + htmlspecialchars($itemId)); |
|
205 | 205 | } |
206 | 206 | } else { |
207 | - throw new InvalidArgumentException( '$itemId must be either ItemId or string' ); |
|
207 | + throw new InvalidArgumentException('$itemId must be either ItemId or string'); |
|
208 | 208 | } |
209 | 209 | } |
210 | 210 | |
@@ -215,20 +215,20 @@ discard block |
||
215 | 215 | * @param string|null $role one of the Role constants or null |
216 | 216 | * @return string HTML |
217 | 217 | */ |
218 | - public function formatItemIdSnakValue( ItemIdSnakValue $value, $role = null ) { |
|
219 | - switch ( true ) { |
|
218 | + public function formatItemIdSnakValue(ItemIdSnakValue $value, $role = null) { |
|
219 | + switch (true) { |
|
220 | 220 | case $value->isValue(): |
221 | - return $this->formatEntityId( $value->getItemId(), $role ); |
|
221 | + return $this->formatEntityId($value->getItemId(), $role); |
|
222 | 222 | case $value->isSomeValue(): |
223 | - return self::formatByRole( $role, |
|
223 | + return self::formatByRole($role, |
|
224 | 224 | '<span class="wikibase-snakview-variation-somevaluesnak">' |
225 | - . wfMessage( 'wikibase-snakview-snaktypeselector-somevalue' )->escaped() |
|
226 | - . '</span>' ); |
|
225 | + . wfMessage('wikibase-snakview-snaktypeselector-somevalue')->escaped() |
|
226 | + . '</span>'); |
|
227 | 227 | case $value->isNoValue(): |
228 | - return self::formatByRole( $role, |
|
228 | + return self::formatByRole($role, |
|
229 | 229 | '<span class="wikibase-snakview-variation-novaluesnak">' |
230 | - . wfMessage( 'wikibase-snakview-snaktypeselector-novalue' )->escaped() |
|
231 | - . '</span>' ); |
|
230 | + . wfMessage('wikibase-snakview-snaktypeselector-novalue')->escaped() |
|
231 | + . '</span>'); |
|
232 | 232 | } |
233 | 233 | } |
234 | 234 | |
@@ -239,8 +239,8 @@ discard block |
||
239 | 239 | * @param string|null $role one of the Role constants or null |
240 | 240 | * @return string HTML |
241 | 241 | */ |
242 | - public function formatConstraintScope( $scope, $role = null ) { |
|
243 | - switch ( $scope ) { |
|
242 | + public function formatConstraintScope($scope, $role = null) { |
|
243 | + switch ($scope) { |
|
244 | 244 | case Context::TYPE_STATEMENT: |
245 | 245 | $itemId = $this->config->get( |
246 | 246 | 'WBQualityConstraintsConstraintCheckedOnMainValueId' |
@@ -260,10 +260,10 @@ discard block |
||
260 | 260 | // callers should never let this happen, but if it does happen, |
261 | 261 | // showing “unknown value” seems reasonable |
262 | 262 | // @codeCoverageIgnoreStart |
263 | - return $this->formatItemIdSnakValue( ItemIdSnakValue::someValue(), $role ); |
|
263 | + return $this->formatItemIdSnakValue(ItemIdSnakValue::someValue(), $role); |
|
264 | 264 | // @codeCoverageIgnoreEnd |
265 | 265 | } |
266 | - return $this->formatItemId( $itemId, $role ); |
|
266 | + return $this->formatItemId($itemId, $role); |
|
267 | 267 | } |
268 | 268 | |
269 | 269 | /** |
@@ -276,15 +276,15 @@ discard block |
||
276 | 276 | * @param string|null $role one of the Role constants or null |
277 | 277 | * @return string[] HTML |
278 | 278 | */ |
279 | - public function formatPropertyIdList( array $propertyIds, $role = null ) { |
|
280 | - if ( empty( $propertyIds ) ) { |
|
281 | - return [ '<ul></ul>' ]; |
|
279 | + public function formatPropertyIdList(array $propertyIds, $role = null) { |
|
280 | + if (empty($propertyIds)) { |
|
281 | + return ['<ul></ul>']; |
|
282 | 282 | } |
283 | - $propertyIds = $this->limitArrayLength( $propertyIds ); |
|
284 | - $formattedPropertyIds = array_map( [ $this, "formatPropertyId" ], $propertyIds, array_fill( 0, count( $propertyIds ), $role ) ); |
|
283 | + $propertyIds = $this->limitArrayLength($propertyIds); |
|
284 | + $formattedPropertyIds = array_map([$this, "formatPropertyId"], $propertyIds, array_fill(0, count($propertyIds), $role)); |
|
285 | 285 | array_unshift( |
286 | 286 | $formattedPropertyIds, |
287 | - '<ul><li>' . implode( '</li><li>', $formattedPropertyIds ) . '</li></ul>' |
|
287 | + '<ul><li>'.implode('</li><li>', $formattedPropertyIds).'</li></ul>' |
|
288 | 288 | ); |
289 | 289 | return $formattedPropertyIds; |
290 | 290 | } |
@@ -299,15 +299,15 @@ discard block |
||
299 | 299 | * @param string|null $role one of the Role constants or null |
300 | 300 | * @return string[] HTML |
301 | 301 | */ |
302 | - public function formatItemIdList( array $itemIds, $role = null ) { |
|
303 | - if ( empty( $itemIds ) ) { |
|
304 | - return [ '<ul></ul>' ]; |
|
302 | + public function formatItemIdList(array $itemIds, $role = null) { |
|
303 | + if (empty($itemIds)) { |
|
304 | + return ['<ul></ul>']; |
|
305 | 305 | } |
306 | - $itemIds = $this->limitArrayLength( $itemIds ); |
|
307 | - $formattedItemIds = array_map( [ $this, "formatItemId" ], $itemIds, array_fill( 0, count( $itemIds ), $role ) ); |
|
306 | + $itemIds = $this->limitArrayLength($itemIds); |
|
307 | + $formattedItemIds = array_map([$this, "formatItemId"], $itemIds, array_fill(0, count($itemIds), $role)); |
|
308 | 308 | array_unshift( |
309 | 309 | $formattedItemIds, |
310 | - '<ul><li>' . implode( '</li><li>', $formattedItemIds ) . '</li></ul>' |
|
310 | + '<ul><li>'.implode('</li><li>', $formattedItemIds).'</li></ul>' |
|
311 | 311 | ); |
312 | 312 | return $formattedItemIds; |
313 | 313 | } |
@@ -322,23 +322,23 @@ discard block |
||
322 | 322 | * @param string|null $role one of the Role constants or null |
323 | 323 | * @return string[] HTML |
324 | 324 | */ |
325 | - public function formatEntityIdList( array $entityIds, $role = null ) { |
|
326 | - if ( empty( $entityIds ) ) { |
|
327 | - return [ '<ul></ul>' ]; |
|
325 | + public function formatEntityIdList(array $entityIds, $role = null) { |
|
326 | + if (empty($entityIds)) { |
|
327 | + return ['<ul></ul>']; |
|
328 | 328 | } |
329 | 329 | $formattedEntityIds = []; |
330 | - foreach ( $entityIds as $entityId ) { |
|
331 | - if ( count( $formattedEntityIds ) >= self::MAX_PARAMETER_ARRAY_LENGTH ) { |
|
330 | + foreach ($entityIds as $entityId) { |
|
331 | + if (count($formattedEntityIds) >= self::MAX_PARAMETER_ARRAY_LENGTH) { |
|
332 | 332 | $formattedEntityIds[] = '...'; |
333 | 333 | break; |
334 | 334 | } |
335 | - if ( $entityId !== null ) { |
|
336 | - $formattedEntityIds[] = $this->formatEntityId( $entityId, $role ); |
|
335 | + if ($entityId !== null) { |
|
336 | + $formattedEntityIds[] = $this->formatEntityId($entityId, $role); |
|
337 | 337 | } |
338 | 338 | } |
339 | 339 | array_unshift( |
340 | 340 | $formattedEntityIds, |
341 | - '<ul><li>' . implode( '</li><li>', $formattedEntityIds ) . '</li></ul>' |
|
341 | + '<ul><li>'.implode('</li><li>', $formattedEntityIds).'</li></ul>' |
|
342 | 342 | ); |
343 | 343 | return $formattedEntityIds; |
344 | 344 | } |
@@ -353,24 +353,24 @@ discard block |
||
353 | 353 | * @param string|null $role one of the Role constants or null |
354 | 354 | * @return string[] HTML |
355 | 355 | */ |
356 | - public function formatItemIdSnakValueList( array $values, $role = null ) { |
|
357 | - if ( empty( $values ) ) { |
|
358 | - return [ '<ul></ul>' ]; |
|
356 | + public function formatItemIdSnakValueList(array $values, $role = null) { |
|
357 | + if (empty($values)) { |
|
358 | + return ['<ul></ul>']; |
|
359 | 359 | } |
360 | - $values = $this->limitArrayLength( $values ); |
|
360 | + $values = $this->limitArrayLength($values); |
|
361 | 361 | $formattedValues = array_map( |
362 | - function( $value ) use ( $role ) { |
|
363 | - if ( $value === '...' ) { |
|
362 | + function($value) use ($role) { |
|
363 | + if ($value === '...') { |
|
364 | 364 | return '...'; |
365 | 365 | } else { |
366 | - return $this->formatItemIdSnakValue( $value, $role ); |
|
366 | + return $this->formatItemIdSnakValue($value, $role); |
|
367 | 367 | } |
368 | 368 | }, |
369 | 369 | $values |
370 | 370 | ); |
371 | 371 | array_unshift( |
372 | 372 | $formattedValues, |
373 | - '<ul><li>' . implode( '</li><li>', $formattedValues ) . '</li></ul>' |
|
373 | + '<ul><li>'.implode('</li><li>', $formattedValues).'</li></ul>' |
|
374 | 374 | ); |
375 | 375 | return $formattedValues; |
376 | 376 | } |
@@ -385,24 +385,24 @@ discard block |
||
385 | 385 | * @param string|null $role one of the Role constants or null |
386 | 386 | * @return string[] HTML |
387 | 387 | */ |
388 | - public function formatConstraintScopeList( array $scopes, $role = null ) { |
|
389 | - if ( empty( $scopes ) ) { |
|
390 | - return [ '<ul></ul>' ]; |
|
388 | + public function formatConstraintScopeList(array $scopes, $role = null) { |
|
389 | + if (empty($scopes)) { |
|
390 | + return ['<ul></ul>']; |
|
391 | 391 | } |
392 | - $scopes = $this->limitArrayLength( $scopes ); |
|
392 | + $scopes = $this->limitArrayLength($scopes); |
|
393 | 393 | $formattedScopes = array_map( |
394 | - function( $scope ) use ( $role ) { |
|
395 | - if ( $scope === '...' ) { |
|
394 | + function($scope) use ($role) { |
|
395 | + if ($scope === '...') { |
|
396 | 396 | return '...'; |
397 | 397 | } else { |
398 | - return $this->formatConstraintScope( $scope, $role ); |
|
398 | + return $this->formatConstraintScope($scope, $role); |
|
399 | 399 | } |
400 | 400 | }, |
401 | 401 | $scopes |
402 | 402 | ); |
403 | 403 | array_unshift( |
404 | 404 | $formattedScopes, |
405 | - '<ul><li>' . implode( '</li><li>', $formattedScopes ) . '</li></ul>' |
|
405 | + '<ul><li>'.implode('</li><li>', $formattedScopes).'</li></ul>' |
|
406 | 406 | ); |
407 | 407 | return $formattedScopes; |
408 | 408 | } |
@@ -92,18 +92,18 @@ discard block |
||
92 | 92 | * @throws ConstraintParameterException |
93 | 93 | * @return CheckResult |
94 | 94 | */ |
95 | - public function checkConstraint( Context $context, Constraint $constraint ) { |
|
96 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
97 | - return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED ); |
|
95 | + public function checkConstraint(Context $context, Constraint $constraint) { |
|
96 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
97 | + return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED); |
|
98 | 98 | } |
99 | 99 | |
100 | 100 | $parameters = []; |
101 | 101 | $constraintParameters = $constraint->getConstraintParameters(); |
102 | 102 | |
103 | - $propertyId = $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() ); |
|
104 | - $parameters['property'] = [ $propertyId ]; |
|
103 | + $propertyId = $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId()); |
|
104 | + $parameters['property'] = [$propertyId]; |
|
105 | 105 | |
106 | - $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false ); |
|
106 | + $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false); |
|
107 | 107 | $parameters['items'] = $items; |
108 | 108 | |
109 | 109 | /* |
@@ -111,16 +111,16 @@ discard block |
||
111 | 111 | * a) a property only |
112 | 112 | * b) a property and a number of items (each combination of property and item forming an individual claim) |
113 | 113 | */ |
114 | - if ( $items === [] ) { |
|
114 | + if ($items === []) { |
|
115 | 115 | $offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty( |
116 | 116 | $context->getEntity()->getStatements(), |
117 | 117 | $propertyId |
118 | 118 | ); |
119 | - if ( $offendingStatement !== null ) { |
|
120 | - $message = wfMessage( "wbqc-violation-message-conflicts-with-property" ) |
|
119 | + if ($offendingStatement !== null) { |
|
120 | + $message = wfMessage("wbqc-violation-message-conflicts-with-property") |
|
121 | 121 | ->rawParams( |
122 | - $this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ), |
|
123 | - $this->constraintParameterRenderer->formatEntityId( $propertyId, Role::PREDICATE ) |
|
122 | + $this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY), |
|
123 | + $this->constraintParameterRenderer->formatEntityId($propertyId, Role::PREDICATE) |
|
124 | 124 | ) |
125 | 125 | ->escaped(); |
126 | 126 | $status = CheckResult::STATUS_VIOLATION; |
@@ -134,13 +134,13 @@ discard block |
||
134 | 134 | $propertyId, |
135 | 135 | $items |
136 | 136 | ); |
137 | - if ( $offendingStatement !== null ) { |
|
138 | - $offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() ); |
|
139 | - $message = wfMessage( "wbqc-violation-message-conflicts-with-claim" ) |
|
137 | + if ($offendingStatement !== null) { |
|
138 | + $offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak()); |
|
139 | + $message = wfMessage("wbqc-violation-message-conflicts-with-claim") |
|
140 | 140 | ->rawParams( |
141 | - $this->constraintParameterRenderer->formatEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY ), |
|
142 | - $this->constraintParameterRenderer->formatEntityId( $propertyId, Role::PREDICATE ), |
|
143 | - $this->constraintParameterRenderer->formatItemIdSnakValue( $offendingValue, Role::OBJECT ) |
|
141 | + $this->constraintParameterRenderer->formatEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY), |
|
142 | + $this->constraintParameterRenderer->formatEntityId($propertyId, Role::PREDICATE), |
|
143 | + $this->constraintParameterRenderer->formatItemIdSnakValue($offendingValue, Role::OBJECT) |
|
144 | 144 | ) |
145 | 145 | ->escaped(); |
146 | 146 | $status = CheckResult::STATUS_VIOLATION; |
@@ -150,20 +150,20 @@ discard block |
||
150 | 150 | } |
151 | 151 | } |
152 | 152 | |
153 | - return new CheckResult( $context, $constraint, $parameters, $status, $message ); |
|
153 | + return new CheckResult($context, $constraint, $parameters, $status, $message); |
|
154 | 154 | } |
155 | 155 | |
156 | - public function checkConstraintParameters( Constraint $constraint ) { |
|
156 | + public function checkConstraintParameters(Constraint $constraint) { |
|
157 | 157 | $constraintParameters = $constraint->getConstraintParameters(); |
158 | 158 | $exceptions = []; |
159 | 159 | try { |
160 | - $this->constraintParameterParser->parsePropertyParameter( $constraintParameters, $constraint->getConstraintTypeItemId() ); |
|
161 | - } catch ( ConstraintParameterException $e ) { |
|
160 | + $this->constraintParameterParser->parsePropertyParameter($constraintParameters, $constraint->getConstraintTypeItemId()); |
|
161 | + } catch (ConstraintParameterException $e) { |
|
162 | 162 | $exceptions[] = $e; |
163 | 163 | } |
164 | 164 | try { |
165 | - $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), false ); |
|
166 | - } catch ( ConstraintParameterException $e ) { |
|
165 | + $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), false); |
|
166 | + } catch (ConstraintParameterException $e) { |
|
167 | 167 | $exceptions[] = $e; |
168 | 168 | } |
169 | 169 | return $exceptions; |
@@ -44,7 +44,7 @@ discard block |
||
44 | 44 | * @param ItemId $itemId |
45 | 45 | * @return self |
46 | 46 | */ |
47 | - public static function fromItemId( ItemId $itemId ) { |
|
47 | + public static function fromItemId(ItemId $itemId) { |
|
48 | 48 | $ret = new self; |
49 | 49 | $ret->itemId = $itemId; |
50 | 50 | return $ret; |
@@ -80,14 +80,14 @@ discard block |
||
80 | 80 | * @throws InvalidArgumentException |
81 | 81 | * @return self |
82 | 82 | */ |
83 | - public static function fromSnak( Snak $snak ) { |
|
84 | - switch ( true ) { |
|
83 | + public static function fromSnak(Snak $snak) { |
|
84 | + switch (true) { |
|
85 | 85 | case $snak instanceof PropertyValueSnak: |
86 | 86 | $dataValue = $snak->getDataValue(); |
87 | - if ( $dataValue instanceof EntityIdValue |
|
87 | + if ($dataValue instanceof EntityIdValue |
|
88 | 88 | && $dataValue->getEntityId() instanceof ItemId |
89 | 89 | ) { |
90 | - return self::fromItemId( $dataValue->getEntityId() ); |
|
90 | + return self::fromItemId($dataValue->getEntityId()); |
|
91 | 91 | } |
92 | 92 | break; |
93 | 93 | case $snak instanceof PropertySomeValueSnak: |
@@ -96,7 +96,7 @@ discard block |
||
96 | 96 | return self::noValue(); |
97 | 97 | } |
98 | 98 | |
99 | - throw new InvalidArgumentException( 'Snak must contain item ID value or be a somevalue / novalue snak' ); |
|
99 | + throw new InvalidArgumentException('Snak must contain item ID value or be a somevalue / novalue snak'); |
|
100 | 100 | } |
101 | 101 | |
102 | 102 | /** |
@@ -133,8 +133,8 @@ discard block |
||
133 | 133 | * @return ItemId |
134 | 134 | */ |
135 | 135 | public function getItemId() { |
136 | - if ( ! $this->isValue() ) { |
|
137 | - throw new DomainException( 'This value does not contain an item ID.' ); |
|
136 | + if (!$this->isValue()) { |
|
137 | + throw new DomainException('This value does not contain an item ID.'); |
|
138 | 138 | } |
139 | 139 | return $this->itemId; |
140 | 140 | } |
@@ -146,13 +146,13 @@ discard block |
||
146 | 146 | * @param Snak $snak |
147 | 147 | * @return bool |
148 | 148 | */ |
149 | - public function matchesSnak( Snak $snak ) { |
|
150 | - switch ( true ) { |
|
149 | + public function matchesSnak(Snak $snak) { |
|
150 | + switch (true) { |
|
151 | 151 | case $snak instanceof PropertyValueSnak: |
152 | 152 | return $this->isValue() && |
153 | 153 | $snak->getDataValue() instanceof EntityIdValue && |
154 | 154 | $snak->getDataValue()->getEntityId() instanceof ItemId && |
155 | - $snak->getDataValue()->getEntityId()->equals( $this->getItemId() ); |
|
155 | + $snak->getDataValue()->getEntityId()->equals($this->getItemId()); |
|
156 | 156 | case $snak instanceof PropertySomeValueSnak: |
157 | 157 | return $this->isSomeValue(); |
158 | 158 | case $snak instanceof PropertyNoValueSnak: |
@@ -30,8 +30,8 @@ discard block |
||
30 | 30 | StatementList $statementList, |
31 | 31 | PropertyId $propertyId |
32 | 32 | ) { |
33 | - $statementListByPropertyId = $statementList->getByPropertyId( $propertyId ); |
|
34 | - if ( $statementListByPropertyId->isEmpty() ) { |
|
33 | + $statementListByPropertyId = $statementList->getByPropertyId($propertyId); |
|
34 | + if ($statementListByPropertyId->isEmpty()) { |
|
35 | 35 | return null; |
36 | 36 | } else { |
37 | 37 | return $statementListByPropertyId->toArray()[0]; |
@@ -52,14 +52,14 @@ discard block |
||
52 | 52 | PropertyId $propertyId, |
53 | 53 | EntityId $value |
54 | 54 | ) { |
55 | - $statementListByPropertyId = $statementList->getByPropertyId( $propertyId ); |
|
55 | + $statementListByPropertyId = $statementList->getByPropertyId($propertyId); |
|
56 | 56 | /** @var Statement $statement */ |
57 | - foreach ( $statementListByPropertyId as $statement ) { |
|
57 | + foreach ($statementListByPropertyId as $statement) { |
|
58 | 58 | $snak = $statement->getMainSnak(); |
59 | - if ( $snak instanceof PropertyValueSnak ) { |
|
59 | + if ($snak instanceof PropertyValueSnak) { |
|
60 | 60 | $dataValue = $snak->getDataValue(); |
61 | - if ( $dataValue instanceof EntityIdValue && |
|
62 | - $dataValue->getEntityId()->equals( $value ) |
|
61 | + if ($dataValue instanceof EntityIdValue && |
|
62 | + $dataValue->getEntityId()->equals($value) |
|
63 | 63 | ) { |
64 | 64 | return $statement; |
65 | 65 | } |
@@ -82,12 +82,12 @@ discard block |
||
82 | 82 | PropertyId $propertyId, |
83 | 83 | array $values |
84 | 84 | ) { |
85 | - $statementListByPropertyId = $statementList->getByPropertyId( $propertyId ); |
|
85 | + $statementListByPropertyId = $statementList->getByPropertyId($propertyId); |
|
86 | 86 | /** @var Statement $statement */ |
87 | - foreach ( $statementListByPropertyId as $statement ) { |
|
87 | + foreach ($statementListByPropertyId as $statement) { |
|
88 | 88 | $snak = $statement->getMainSnak(); |
89 | - foreach ( $values as $value ) { |
|
90 | - if ( $value->matchesSnak( $snak ) ) { |
|
89 | + foreach ($values as $value) { |
|
90 | + if ($value->matchesSnak($snak)) { |
|
91 | 91 | return $statement; |
92 | 92 | } |
93 | 93 | } |
@@ -26,8 +26,8 @@ discard block |
||
26 | 26 | |
27 | 27 | const BATCH_SIZE = 10; |
28 | 28 | |
29 | - public static function newFromGlobalState( Title $title, array $params ) { |
|
30 | - Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' ); |
|
29 | + public static function newFromGlobalState(Title $title, array $params) { |
|
30 | + Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]'); |
|
31 | 31 | $repo = WikibaseRepo::getDefaultInstance(); |
32 | 32 | return new UpdateConstraintsTableJob( |
33 | 33 | $title, |
@@ -83,7 +83,7 @@ discard block |
||
83 | 83 | EntityLookup $entityLookup, |
84 | 84 | Serializer $snakSerializer |
85 | 85 | ) { |
86 | - parent::__construct( 'constraintsTableUpdate', $title, $params ); |
|
86 | + parent::__construct('constraintsTableUpdate', $title, $params); |
|
87 | 87 | |
88 | 88 | $this->propertyId = $propertyId; |
89 | 89 | $this->config = $config; |
@@ -92,11 +92,11 @@ discard block |
||
92 | 92 | $this->snakSerializer = $snakSerializer; |
93 | 93 | } |
94 | 94 | |
95 | - public function extractParametersFromQualifiers( SnakList $qualifiers ) { |
|
95 | + public function extractParametersFromQualifiers(SnakList $qualifiers) { |
|
96 | 96 | $parameters = []; |
97 | - foreach ( $qualifiers as $qualifier ) { |
|
97 | + foreach ($qualifiers as $qualifier) { |
|
98 | 98 | $qualifierId = $qualifier->getPropertyId()->getSerialization(); |
99 | - $paramSerialization = $this->snakSerializer->serialize( $qualifier ); |
|
99 | + $paramSerialization = $this->snakSerializer->serialize($qualifier); |
|
100 | 100 | $parameters[$qualifierId][] = $paramSerialization; |
101 | 101 | } |
102 | 102 | return $parameters; |
@@ -108,7 +108,7 @@ discard block |
||
108 | 108 | ) { |
109 | 109 | $constraintId = $constraintStatement->getGuid(); |
110 | 110 | $constraintTypeQid = $constraintStatement->getMainSnak()->getDataValue()->getEntityId()->getSerialization(); |
111 | - $parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() ); |
|
111 | + $parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers()); |
|
112 | 112 | return new Constraint( |
113 | 113 | $constraintId, |
114 | 114 | $propertyId, |
@@ -123,17 +123,17 @@ discard block |
||
123 | 123 | PropertyId $propertyConstraintPropertyId |
124 | 124 | ) { |
125 | 125 | $constraintsStatements = $property->getStatements() |
126 | - ->getByPropertyId( $propertyConstraintPropertyId ) |
|
127 | - ->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] ); |
|
126 | + ->getByPropertyId($propertyConstraintPropertyId) |
|
127 | + ->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]); |
|
128 | 128 | $constraints = []; |
129 | - foreach ( $constraintsStatements->getIterator() as $constraintStatement ) { |
|
130 | - $constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement ); |
|
131 | - if ( count( $constraints ) >= self::BATCH_SIZE ) { |
|
132 | - $constraintRepo->insertBatch( $constraints ); |
|
129 | + foreach ($constraintsStatements->getIterator() as $constraintStatement) { |
|
130 | + $constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement); |
|
131 | + if (count($constraints) >= self::BATCH_SIZE) { |
|
132 | + $constraintRepo->insertBatch($constraints); |
|
133 | 133 | $constraints = []; |
134 | 134 | } |
135 | 135 | } |
136 | - $constraintRepo->insertBatch( $constraints ); |
|
136 | + $constraintRepo->insertBatch($constraints); |
|
137 | 137 | } |
138 | 138 | |
139 | 139 | /** |
@@ -144,15 +144,15 @@ discard block |
||
144 | 144 | public function run() { |
145 | 145 | // TODO in the future: only touch constraints affected by the edit (requires T163465) |
146 | 146 | |
147 | - $propertyId = new PropertyId( $this->propertyId ); |
|
148 | - $this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId( $propertyId ); |
|
147 | + $propertyId = new PropertyId($this->propertyId); |
|
148 | + $this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId($propertyId); |
|
149 | 149 | |
150 | 150 | /** @var Property $property */ |
151 | - $property = $this->entityLookup->getEntity( $propertyId ); |
|
151 | + $property = $this->entityLookup->getEntity($propertyId); |
|
152 | 152 | $this->importConstraintsForProperty( |
153 | 153 | $property, |
154 | 154 | $this->constraintRepo, |
155 | - new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ) |
|
155 | + new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')) |
|
156 | 156 | ); |
157 | 157 | |
158 | 158 | return true; |
@@ -134,11 +134,11 @@ discard block |
||
134 | 134 | ) { |
135 | 135 | $results = []; |
136 | 136 | $metadatas = []; |
137 | - if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) { |
|
137 | + if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) { |
|
138 | 138 | $storedEntityIds = []; |
139 | - foreach ( $entityIds as $entityId ) { |
|
140 | - $storedResults = $this->getStoredResults( $entityId ); |
|
141 | - if ( $storedResults !== null ) { |
|
139 | + foreach ($entityIds as $entityId) { |
|
140 | + $storedResults = $this->getStoredResults($entityId); |
|
141 | + if ($storedResults !== null) { |
|
142 | 142 | $this->dataFactory->increment( |
143 | 143 | 'wikibase.quality.constraints.cache.entity.hit' |
144 | 144 | ); |
@@ -147,20 +147,20 @@ discard block |
||
147 | 147 | $storedEntityIds[] = $entityId; |
148 | 148 | } |
149 | 149 | } |
150 | - $entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) ); |
|
150 | + $entityIds = array_values(array_diff($entityIds, $storedEntityIds)); |
|
151 | 151 | } |
152 | - if ( $entityIds !== [] || $claimIds !== [] ) { |
|
152 | + if ($entityIds !== [] || $claimIds !== []) { |
|
153 | 153 | $this->dataFactory->updateCount( |
154 | 154 | 'wikibase.quality.constraints.cache.entity.miss', |
155 | - count( $entityIds ) |
|
155 | + count($entityIds) |
|
156 | 156 | ); |
157 | - $response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ); |
|
157 | + $response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses); |
|
158 | 158 | $results += $response->getArray(); |
159 | 159 | $metadatas[] = $response->getMetadata(); |
160 | 160 | } |
161 | 161 | return new CachedCheckConstraintsResponse( |
162 | 162 | $results, |
163 | - Metadata::merge( $metadatas ) |
|
163 | + Metadata::merge($metadatas) |
|
164 | 164 | ); |
165 | 165 | } |
166 | 166 | |
@@ -189,13 +189,13 @@ discard block |
||
189 | 189 | array $constraintIds = null, |
190 | 190 | array $statuses |
191 | 191 | ) { |
192 | - if ( $claimIds !== [] ) { |
|
192 | + if ($claimIds !== []) { |
|
193 | 193 | return false; |
194 | 194 | } |
195 | - if ( $constraintIds !== null ) { |
|
195 | + if ($constraintIds !== null) { |
|
196 | 196 | return false; |
197 | 197 | } |
198 | - if ( $statuses != $this->cachedStatuses ) { |
|
198 | + if ($statuses != $this->cachedStatuses) { |
|
199 | 199 | return false; |
200 | 200 | } |
201 | 201 | return true; |
@@ -214,17 +214,17 @@ discard block |
||
214 | 214 | array $constraintIds = null, |
215 | 215 | array $statuses |
216 | 216 | ) { |
217 | - $results = $this->resultsBuilder->getResults( $entityIds, $claimIds, $constraintIds, $statuses ); |
|
217 | + $results = $this->resultsBuilder->getResults($entityIds, $claimIds, $constraintIds, $statuses); |
|
218 | 218 | |
219 | - if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) { |
|
220 | - foreach ( $entityIds as $entityId ) { |
|
219 | + if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) { |
|
220 | + foreach ($entityIds as $entityId) { |
|
221 | 221 | $value = [ |
222 | 222 | 'results' => $results->getArray()[$entityId->getSerialization()], |
223 | 223 | 'latestRevisionIds' => $this->getLatestRevisionIds( |
224 | 224 | $results->getMetadata()->getDependencyMetadata()->getEntityIds() |
225 | 225 | ), |
226 | 226 | ]; |
227 | - $this->cache->set( $entityId, $value, $this->ttlInSeconds ); |
|
227 | + $this->cache->set($entityId, $value, $this->ttlInSeconds); |
|
228 | 228 | } |
229 | 229 | } |
230 | 230 | |
@@ -256,10 +256,10 @@ discard block |
||
256 | 256 | array $constraintIds = null, |
257 | 257 | array $statuses |
258 | 258 | ) { |
259 | - if ( $constraintIds !== null ) { |
|
259 | + if ($constraintIds !== null) { |
|
260 | 260 | return false; |
261 | 261 | } |
262 | - if ( $statuses != $this->cachedStatuses ) { |
|
262 | + if ($statuses != $this->cachedStatuses) { |
|
263 | 263 | return false; |
264 | 264 | } |
265 | 265 | return true; |
@@ -272,45 +272,44 @@ discard block |
||
272 | 272 | public function getStoredResults( |
273 | 273 | EntityId $entityId |
274 | 274 | ) { |
275 | - $value = $this->cache->get( $entityId, $curTTL, [], $asOf ); |
|
276 | - $now = call_user_func( $this->microtime, true ); |
|
275 | + $value = $this->cache->get($entityId, $curTTL, [], $asOf); |
|
276 | + $now = call_user_func($this->microtime, true); |
|
277 | 277 | |
278 | - if ( $value === false ) { |
|
278 | + if ($value === false) { |
|
279 | 279 | return null; |
280 | 280 | } |
281 | 281 | |
282 | - $ageInSeconds = (int)ceil( $now - $asOf ); |
|
282 | + $ageInSeconds = (int) ceil($now - $asOf); |
|
283 | 283 | |
284 | 284 | $dependedEntityIds = array_map( |
285 | - [ $this->entityIdParser, "parse" ], |
|
286 | - array_keys( $value['latestRevisionIds'] ) |
|
285 | + [$this->entityIdParser, "parse"], |
|
286 | + array_keys($value['latestRevisionIds']) |
|
287 | 287 | ); |
288 | 288 | |
289 | - if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) { |
|
289 | + if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) { |
|
290 | 290 | return null; |
291 | 291 | } |
292 | 292 | |
293 | 293 | $cachingMetadata = $ageInSeconds > 0 ? |
294 | - CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) : |
|
295 | - CachingMetadata::fresh(); |
|
294 | + CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh(); |
|
296 | 295 | |
297 | - if ( is_array( $value['results'] ) ) { |
|
298 | - array_walk( $value['results'], [ $this, 'updateCachingMetadata' ], $cachingMetadata ); |
|
296 | + if (is_array($value['results'])) { |
|
297 | + array_walk($value['results'], [$this, 'updateCachingMetadata'], $cachingMetadata); |
|
299 | 298 | } |
300 | 299 | |
301 | 300 | return new CachedCheckConstraintsResponse( |
302 | - [ $entityId->getSerialization() => $value['results'] ], |
|
301 | + [$entityId->getSerialization() => $value['results']], |
|
303 | 302 | array_reduce( |
304 | 303 | $dependedEntityIds, |
305 | - function( Metadata $metadata, EntityId $entityId ) { |
|
306 | - return Metadata::merge( [ |
|
304 | + function(Metadata $metadata, EntityId $entityId) { |
|
305 | + return Metadata::merge([ |
|
307 | 306 | $metadata, |
308 | 307 | Metadata::ofDependencyMetadata( |
309 | - DependencyMetadata::ofEntityId( $entityId ) |
|
308 | + DependencyMetadata::ofEntityId($entityId) |
|
310 | 309 | ) |
311 | - ] ); |
|
310 | + ]); |
|
312 | 311 | }, |
313 | - Metadata::ofCachingMetadata( $cachingMetadata ) |
|
312 | + Metadata::ofCachingMetadata($cachingMetadata) |
|
314 | 313 | ) |
315 | 314 | ); |
316 | 315 | } |
@@ -319,39 +318,39 @@ discard block |
||
319 | 318 | * @param EntityId[] $entityIds |
320 | 319 | * @return int[] |
321 | 320 | */ |
322 | - private function getLatestRevisionIds( array $entityIds ) { |
|
321 | + private function getLatestRevisionIds(array $entityIds) { |
|
323 | 322 | $revisionInformations = $this->wikiPageEntityMetaDataAccessor->loadRevisionInformation( |
324 | 323 | $entityIds, |
325 | 324 | EntityRevisionLookup::LATEST_FROM_REPLICA |
326 | 325 | ); |
327 | 326 | $latestRevisionIds = []; |
328 | - foreach ( $revisionInformations as $serialization => $revisionInformation ) { |
|
327 | + foreach ($revisionInformations as $serialization => $revisionInformation) { |
|
329 | 328 | $latestRevisionIds[$serialization] = $revisionInformation->page_latest; |
330 | 329 | } |
331 | 330 | return $latestRevisionIds; |
332 | 331 | } |
333 | 332 | |
334 | - public function updateCachingMetadata( &$element, $key, CachingMetadata $cachingMetadata ) { |
|
335 | - if ( $key === 'cached' ) { |
|
336 | - $element = CachingMetadata::merge( [ |
|
333 | + public function updateCachingMetadata(&$element, $key, CachingMetadata $cachingMetadata) { |
|
334 | + if ($key === 'cached') { |
|
335 | + $element = CachingMetadata::merge([ |
|
337 | 336 | $cachingMetadata, |
338 | - CachingMetadata::ofArray( $element ), |
|
339 | - ] )->toArray(); |
|
337 | + CachingMetadata::ofArray($element), |
|
338 | + ])->toArray(); |
|
340 | 339 | } |
341 | 340 | if ( |
342 | - is_array( $element ) && |
|
343 | - array_key_exists( 'constraint', $element ) && |
|
344 | - in_array( $element['constraint']['type'], $this->possiblyStaleConstraintTypes, true ) |
|
341 | + is_array($element) && |
|
342 | + array_key_exists('constraint', $element) && |
|
343 | + in_array($element['constraint']['type'], $this->possiblyStaleConstraintTypes, true) |
|
345 | 344 | ) { |
346 | - $element['cached'] = CachingMetadata::merge( [ |
|
345 | + $element['cached'] = CachingMetadata::merge([ |
|
347 | 346 | $cachingMetadata, |
348 | 347 | CachingMetadata::ofArray( |
349 | - array_key_exists( 'cached', $element ) ? $element['cached'] : null |
|
348 | + array_key_exists('cached', $element) ? $element['cached'] : null |
|
350 | 349 | ), |
351 | - ] )->toArray(); |
|
350 | + ])->toArray(); |
|
352 | 351 | } |
353 | - if ( is_array( $element ) ) { |
|
354 | - array_walk( $element, [ $this, __FUNCTION__ ], $cachingMetadata ); |
|
352 | + if (is_array($element)) { |
|
353 | + array_walk($element, [$this, __FUNCTION__], $cachingMetadata); |
|
355 | 354 | } |
356 | 355 | } |
357 | 356 | |
@@ -360,7 +359,7 @@ discard block |
||
360 | 359 | * |
361 | 360 | * @param callable $microtime |
362 | 361 | */ |
363 | - public function setMicrotimeFunction( callable $microtime ) { |
|
362 | + public function setMicrotimeFunction(callable $microtime) { |
|
364 | 363 | $this->microtime = $microtime; |
365 | 364 | } |
366 | 365 |
@@ -77,15 +77,15 @@ discard block |
||
77 | 77 | * @param array $parameters |
78 | 78 | * @throws ConstraintParameterException |
79 | 79 | */ |
80 | - public function checkError( array $parameters ) { |
|
81 | - if ( array_key_exists( '@error', $parameters ) ) { |
|
80 | + public function checkError(array $parameters) { |
|
81 | + if (array_key_exists('@error', $parameters)) { |
|
82 | 82 | $error = $parameters['@error']; |
83 | - if ( array_key_exists( 'toolong', $error ) && $error['toolong'] ) { |
|
83 | + if (array_key_exists('toolong', $error) && $error['toolong']) { |
|
84 | 84 | $msg = 'wbqc-violation-message-parameters-error-toolong'; |
85 | 85 | } else { |
86 | 86 | $msg = 'wbqc-violation-message-parameters-error-unknown'; |
87 | 87 | } |
88 | - throw new ConstraintParameterException( wfMessage( $msg )->escaped() ); |
|
88 | + throw new ConstraintParameterException(wfMessage($msg)->escaped()); |
|
89 | 89 | } |
90 | 90 | } |
91 | 91 | |
@@ -95,11 +95,11 @@ discard block |
||
95 | 95 | * @param string $parameterId |
96 | 96 | * @throws ConstraintParameterException |
97 | 97 | */ |
98 | - private function requireSingleParameter( array $parameters, $parameterId ) { |
|
99 | - if ( count( $parameters[$parameterId] ) !== 1 ) { |
|
98 | + private function requireSingleParameter(array $parameters, $parameterId) { |
|
99 | + if (count($parameters[$parameterId]) !== 1) { |
|
100 | 100 | throw new ConstraintParameterException( |
101 | - wfMessage( 'wbqc-violation-message-parameter-single' ) |
|
102 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
101 | + wfMessage('wbqc-violation-message-parameter-single') |
|
102 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
103 | 103 | ->escaped() |
104 | 104 | ); |
105 | 105 | } |
@@ -112,11 +112,11 @@ discard block |
||
112 | 112 | * @return void |
113 | 113 | * @throws ConstraintParameterException |
114 | 114 | */ |
115 | - private function requireValueParameter( Snak $snak, $parameterId ) { |
|
116 | - if ( !( $snak instanceof PropertyValueSnak ) ) { |
|
115 | + private function requireValueParameter(Snak $snak, $parameterId) { |
|
116 | + if (!($snak instanceof PropertyValueSnak)) { |
|
117 | 117 | throw new ConstraintParameterException( |
118 | - wfMessage( 'wbqc-violation-message-parameter-value' ) |
|
119 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
118 | + wfMessage('wbqc-violation-message-parameter-value') |
|
119 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
120 | 120 | ->escaped() |
121 | 121 | ); |
122 | 122 | } |
@@ -129,18 +129,18 @@ discard block |
||
129 | 129 | * @throws ConstraintParameterException |
130 | 130 | * @return EntityId |
131 | 131 | */ |
132 | - private function parseEntityIdParameter( array $snakSerialization, $parameterId ) { |
|
133 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
134 | - $this->requireValueParameter( $snak, $parameterId ); |
|
132 | + private function parseEntityIdParameter(array $snakSerialization, $parameterId) { |
|
133 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
134 | + $this->requireValueParameter($snak, $parameterId); |
|
135 | 135 | $value = $snak->getDataValue(); |
136 | - if ( $value instanceof EntityIdValue ) { |
|
136 | + if ($value instanceof EntityIdValue) { |
|
137 | 137 | return $value->getEntityId(); |
138 | 138 | } else { |
139 | 139 | throw new ConstraintParameterException( |
140 | - wfMessage( 'wbqc-violation-message-parameter-entity' ) |
|
140 | + wfMessage('wbqc-violation-message-parameter-entity') |
|
141 | 141 | ->rawParams( |
142 | - $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ), |
|
143 | - $this->constraintParameterRenderer->formatDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
142 | + $this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY), |
|
143 | + $this->constraintParameterRenderer->formatDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
144 | 144 | ) |
145 | 145 | ->escaped() |
146 | 146 | ); |
@@ -153,21 +153,21 @@ discard block |
||
153 | 153 | * @throws ConstraintParameterException if the parameter is invalid or missing |
154 | 154 | * @return string[] class entity ID serializations |
155 | 155 | */ |
156 | - public function parseClassParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
157 | - $this->checkError( $constraintParameters ); |
|
158 | - $classId = $this->config->get( 'WBQualityConstraintsClassId' ); |
|
159 | - if ( !array_key_exists( $classId, $constraintParameters ) ) { |
|
156 | + public function parseClassParameter(array $constraintParameters, $constraintTypeItemId) { |
|
157 | + $this->checkError($constraintParameters); |
|
158 | + $classId = $this->config->get('WBQualityConstraintsClassId'); |
|
159 | + if (!array_key_exists($classId, $constraintParameters)) { |
|
160 | 160 | throw new ConstraintParameterException( |
161 | - wfMessage( 'wbqc-violation-message-parameter-needed' ) |
|
162 | - ->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) ) |
|
163 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $classId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
161 | + wfMessage('wbqc-violation-message-parameter-needed') |
|
162 | + ->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM)) |
|
163 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($classId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
164 | 164 | ->escaped() |
165 | 165 | ); |
166 | 166 | } |
167 | 167 | |
168 | 168 | $classes = []; |
169 | - foreach ( $constraintParameters[$classId] as $class ) { |
|
170 | - $classes[] = $this->parseEntityIdParameter( $class, $classId )->getSerialization(); |
|
169 | + foreach ($constraintParameters[$classId] as $class) { |
|
170 | + $classes[] = $this->parseEntityIdParameter($class, $classId)->getSerialization(); |
|
171 | 171 | } |
172 | 172 | return $classes; |
173 | 173 | } |
@@ -178,24 +178,24 @@ discard block |
||
178 | 178 | * @throws ConstraintParameterException if the parameter is invalid or missing |
179 | 179 | * @return string 'instance', 'subclass', or 'instanceOrSubclass' |
180 | 180 | */ |
181 | - public function parseRelationParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
182 | - $this->checkError( $constraintParameters ); |
|
183 | - $relationId = $this->config->get( 'WBQualityConstraintsRelationId' ); |
|
184 | - if ( !array_key_exists( $relationId, $constraintParameters ) ) { |
|
181 | + public function parseRelationParameter(array $constraintParameters, $constraintTypeItemId) { |
|
182 | + $this->checkError($constraintParameters); |
|
183 | + $relationId = $this->config->get('WBQualityConstraintsRelationId'); |
|
184 | + if (!array_key_exists($relationId, $constraintParameters)) { |
|
185 | 185 | throw new ConstraintParameterException( |
186 | - wfMessage( 'wbqc-violation-message-parameter-needed' ) |
|
187 | - ->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) ) |
|
188 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $relationId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
186 | + wfMessage('wbqc-violation-message-parameter-needed') |
|
187 | + ->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM)) |
|
188 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($relationId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
189 | 189 | ->escaped() |
190 | 190 | ); |
191 | 191 | } |
192 | 192 | |
193 | - $this->requireSingleParameter( $constraintParameters, $relationId ); |
|
194 | - $relationEntityId = $this->parseEntityIdParameter( $constraintParameters[$relationId][0], $relationId ); |
|
195 | - $instanceId = $this->config->get( 'WBQualityConstraintsInstanceOfRelationId' ); |
|
196 | - $subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfRelationId' ); |
|
197 | - $instanceOrSubclassId = $this->config->get( 'WBQualityConstraintsInstanceOrSubclassOfRelationId' ); |
|
198 | - switch ( $relationEntityId ) { |
|
193 | + $this->requireSingleParameter($constraintParameters, $relationId); |
|
194 | + $relationEntityId = $this->parseEntityIdParameter($constraintParameters[$relationId][0], $relationId); |
|
195 | + $instanceId = $this->config->get('WBQualityConstraintsInstanceOfRelationId'); |
|
196 | + $subclassId = $this->config->get('WBQualityConstraintsSubclassOfRelationId'); |
|
197 | + $instanceOrSubclassId = $this->config->get('WBQualityConstraintsInstanceOrSubclassOfRelationId'); |
|
198 | + switch ($relationEntityId) { |
|
199 | 199 | case $instanceId: |
200 | 200 | return 'instance'; |
201 | 201 | case $subclassId: |
@@ -204,13 +204,13 @@ discard block |
||
204 | 204 | return 'instanceOrSubclass'; |
205 | 205 | default: |
206 | 206 | throw new ConstraintParameterException( |
207 | - wfMessage( 'wbqc-violation-message-parameter-oneof' ) |
|
208 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $relationId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
209 | - ->numParams( 3 ) |
|
210 | - ->rawParams( $this->constraintParameterRenderer->formatItemIdList( |
|
211 | - [ $instanceId, $subclassId, $instanceOrSubclassId ], |
|
207 | + wfMessage('wbqc-violation-message-parameter-oneof') |
|
208 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($relationId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
209 | + ->numParams(3) |
|
210 | + ->rawParams($this->constraintParameterRenderer->formatItemIdList( |
|
211 | + [$instanceId, $subclassId, $instanceOrSubclassId], |
|
212 | 212 | Role::CONSTRAINT_PARAMETER_VALUE |
213 | - ) ) |
|
213 | + )) |
|
214 | 214 | ->escaped() |
215 | 215 | ); |
216 | 216 | } |
@@ -223,21 +223,21 @@ discard block |
||
223 | 223 | * @throws ConstraintParameterException |
224 | 224 | * @return PropertyId |
225 | 225 | */ |
226 | - private function parsePropertyIdParameter( array $snakSerialization, $parameterId ) { |
|
227 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
228 | - $this->requireValueParameter( $snak, $parameterId ); |
|
226 | + private function parsePropertyIdParameter(array $snakSerialization, $parameterId) { |
|
227 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
228 | + $this->requireValueParameter($snak, $parameterId); |
|
229 | 229 | $value = $snak->getDataValue(); |
230 | - if ( $value instanceof EntityIdValue ) { |
|
230 | + if ($value instanceof EntityIdValue) { |
|
231 | 231 | $id = $value->getEntityId(); |
232 | - if ( $id instanceof PropertyId ) { |
|
232 | + if ($id instanceof PropertyId) { |
|
233 | 233 | return $id; |
234 | 234 | } |
235 | 235 | } |
236 | 236 | throw new ConstraintParameterException( |
237 | - wfMessage( 'wbqc-violation-message-parameter-property' ) |
|
237 | + wfMessage('wbqc-violation-message-parameter-property') |
|
238 | 238 | ->rawParams( |
239 | - $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ), |
|
240 | - $this->constraintParameterRenderer->formatDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
239 | + $this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY), |
|
240 | + $this->constraintParameterRenderer->formatDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
241 | 241 | ) |
242 | 242 | ->escaped() |
243 | 243 | ); |
@@ -250,34 +250,34 @@ discard block |
||
250 | 250 | * @throws ConstraintParameterException if the parameter is invalid or missing |
251 | 251 | * @return PropertyId |
252 | 252 | */ |
253 | - public function parsePropertyParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
254 | - $this->checkError( $constraintParameters ); |
|
255 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
256 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
253 | + public function parsePropertyParameter(array $constraintParameters, $constraintTypeItemId) { |
|
254 | + $this->checkError($constraintParameters); |
|
255 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
256 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
257 | 257 | throw new ConstraintParameterException( |
258 | - wfMessage( 'wbqc-violation-message-parameter-needed' ) |
|
259 | - ->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) ) |
|
260 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
258 | + wfMessage('wbqc-violation-message-parameter-needed') |
|
259 | + ->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM)) |
|
260 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
261 | 261 | ->escaped() |
262 | 262 | ); |
263 | 263 | } |
264 | 264 | |
265 | - $this->requireSingleParameter( $constraintParameters, $propertyId ); |
|
266 | - return $this->parsePropertyIdParameter( $constraintParameters[$propertyId][0], $propertyId ); |
|
265 | + $this->requireSingleParameter($constraintParameters, $propertyId); |
|
266 | + return $this->parsePropertyIdParameter($constraintParameters[$propertyId][0], $propertyId); |
|
267 | 267 | } |
268 | 268 | |
269 | - private function parseItemIdParameter( PropertyValueSnak $snak, $parameterId ) { |
|
269 | + private function parseItemIdParameter(PropertyValueSnak $snak, $parameterId) { |
|
270 | 270 | $dataValue = $snak->getDataValue(); |
271 | - if ( $dataValue instanceof EntityIdValue && |
|
271 | + if ($dataValue instanceof EntityIdValue && |
|
272 | 272 | $dataValue->getEntityId() instanceof ItemId |
273 | 273 | ) { |
274 | - return ItemIdSnakValue::fromItemId( $dataValue->getEntityId() ); |
|
274 | + return ItemIdSnakValue::fromItemId($dataValue->getEntityId()); |
|
275 | 275 | } else { |
276 | 276 | throw new ConstraintParameterException( |
277 | - wfMessage( 'wbqc-violation-message-parameter-item' ) |
|
277 | + wfMessage('wbqc-violation-message-parameter-item') |
|
278 | 278 | ->rawParams( |
279 | - $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ), |
|
280 | - $this->constraintParameterRenderer->formatDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
279 | + $this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY), |
|
280 | + $this->constraintParameterRenderer->formatDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
281 | 281 | ) |
282 | 282 | ->escaped() |
283 | 283 | ); |
@@ -291,15 +291,15 @@ discard block |
||
291 | 291 | * @throws ConstraintParameterException if the parameter is invalid or missing |
292 | 292 | * @return ItemIdSnakValue[] array of values |
293 | 293 | */ |
294 | - public function parseItemsParameter( array $constraintParameters, $constraintTypeItemId, $required ) { |
|
295 | - $this->checkError( $constraintParameters ); |
|
296 | - $qualifierId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
297 | - if ( !array_key_exists( $qualifierId, $constraintParameters ) ) { |
|
298 | - if ( $required ) { |
|
294 | + public function parseItemsParameter(array $constraintParameters, $constraintTypeItemId, $required) { |
|
295 | + $this->checkError($constraintParameters); |
|
296 | + $qualifierId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
297 | + if (!array_key_exists($qualifierId, $constraintParameters)) { |
|
298 | + if ($required) { |
|
299 | 299 | throw new ConstraintParameterException( |
300 | - wfMessage( 'wbqc-violation-message-parameter-needed' ) |
|
301 | - ->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) ) |
|
302 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $qualifierId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
300 | + wfMessage('wbqc-violation-message-parameter-needed') |
|
301 | + ->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM)) |
|
302 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($qualifierId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
303 | 303 | ->escaped() |
304 | 304 | ); |
305 | 305 | } else { |
@@ -308,11 +308,11 @@ discard block |
||
308 | 308 | } |
309 | 309 | |
310 | 310 | $values = []; |
311 | - foreach ( $constraintParameters[$qualifierId] as $parameter ) { |
|
312 | - $snak = $this->snakDeserializer->deserialize( $parameter ); |
|
313 | - switch ( true ) { |
|
311 | + foreach ($constraintParameters[$qualifierId] as $parameter) { |
|
312 | + $snak = $this->snakDeserializer->deserialize($parameter); |
|
313 | + switch (true) { |
|
314 | 314 | case $snak instanceof PropertyValueSnak: |
315 | - $values[] = $this->parseItemIdParameter( $snak, $qualifierId ); |
|
315 | + $values[] = $this->parseItemIdParameter($snak, $qualifierId); |
|
316 | 316 | break; |
317 | 317 | case $snak instanceof PropertySomeValueSnak: |
318 | 318 | $values[] = ItemIdSnakValue::someValue(); |
@@ -331,28 +331,28 @@ discard block |
||
331 | 331 | * @throws ConstraintParameterException if the parameter is invalid or missing |
332 | 332 | * @return PropertyId[] |
333 | 333 | */ |
334 | - public function parsePropertiesParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
335 | - $this->checkError( $constraintParameters ); |
|
336 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
337 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
334 | + public function parsePropertiesParameter(array $constraintParameters, $constraintTypeItemId) { |
|
335 | + $this->checkError($constraintParameters); |
|
336 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
337 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
338 | 338 | throw new ConstraintParameterException( |
339 | - wfMessage( 'wbqc-violation-message-parameter-needed' ) |
|
340 | - ->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) ) |
|
341 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
339 | + wfMessage('wbqc-violation-message-parameter-needed') |
|
340 | + ->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM)) |
|
341 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($propertyId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
342 | 342 | ->escaped() |
343 | 343 | ); |
344 | 344 | } |
345 | 345 | |
346 | 346 | $parameters = $constraintParameters[$propertyId]; |
347 | - if ( count( $parameters ) === 1 && |
|
348 | - $this->snakDeserializer->deserialize( $parameters[0] ) instanceof PropertyNoValueSnak |
|
347 | + if (count($parameters) === 1 && |
|
348 | + $this->snakDeserializer->deserialize($parameters[0]) instanceof PropertyNoValueSnak |
|
349 | 349 | ) { |
350 | 350 | return []; |
351 | 351 | } |
352 | 352 | |
353 | 353 | $properties = []; |
354 | - foreach ( $parameters as $parameter ) { |
|
355 | - $properties[] = $this->parsePropertyIdParameter( $parameter, $propertyId ); |
|
354 | + foreach ($parameters as $parameter) { |
|
355 | + $properties[] = $this->parsePropertyIdParameter($parameter, $propertyId); |
|
356 | 356 | } |
357 | 357 | return $properties; |
358 | 358 | } |
@@ -363,16 +363,16 @@ discard block |
||
363 | 363 | * @throws ConstraintParameterException |
364 | 364 | * @return DataValue|null |
365 | 365 | */ |
366 | - private function parseValueOrNoValueParameter( array $snakSerialization, $parameterId ) { |
|
367 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
368 | - if ( $snak instanceof PropertyValueSnak ) { |
|
366 | + private function parseValueOrNoValueParameter(array $snakSerialization, $parameterId) { |
|
367 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
368 | + if ($snak instanceof PropertyValueSnak) { |
|
369 | 369 | return $snak->getDataValue(); |
370 | - } elseif ( $snak instanceof PropertyNoValueSnak ) { |
|
370 | + } elseif ($snak instanceof PropertyNoValueSnak) { |
|
371 | 371 | return null; |
372 | 372 | } else { |
373 | 373 | throw new ConstraintParameterException( |
374 | - wfMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) |
|
375 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
374 | + wfMessage('wbqc-violation-message-parameter-value-or-novalue') |
|
375 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
376 | 376 | ->escaped() |
377 | 377 | ); |
378 | 378 | } |
@@ -383,13 +383,13 @@ discard block |
||
383 | 383 | * @param string $parameterId |
384 | 384 | * @return DataValue|null |
385 | 385 | */ |
386 | - private function parseValueOrNoValueOrNowParameter( array $snakSerialization, $parameterId ) { |
|
386 | + private function parseValueOrNoValueOrNowParameter(array $snakSerialization, $parameterId) { |
|
387 | 387 | try { |
388 | - return $this->parseValueOrNoValueParameter( $snakSerialization, $parameterId ); |
|
389 | - } catch ( ConstraintParameterException $e ) { |
|
388 | + return $this->parseValueOrNoValueParameter($snakSerialization, $parameterId); |
|
389 | + } catch (ConstraintParameterException $e) { |
|
390 | 390 | // unknown value means “now” |
391 | - $timeParser = ( new TimeParserFactory() )->getTimeParser(); |
|
392 | - return $timeParser->parse( gmdate( '+Y-m-d\T00:00:00\Z' ) ); |
|
391 | + $timeParser = (new TimeParserFactory())->getTimeParser(); |
|
392 | + return $timeParser->parse(gmdate('+Y-m-d\T00:00:00\Z')); |
|
393 | 393 | } |
394 | 394 | } |
395 | 395 | |
@@ -400,14 +400,14 @@ discard block |
||
400 | 400 | * @param string $unit |
401 | 401 | * @return bool |
402 | 402 | */ |
403 | - private function exactlyOneQuantityWithUnit( DataValue $min = null, DataValue $max = null, $unit ) { |
|
404 | - if ( !( $min instanceof UnboundedQuantityValue ) || |
|
405 | - !( $max instanceof UnboundedQuantityValue ) |
|
403 | + private function exactlyOneQuantityWithUnit(DataValue $min = null, DataValue $max = null, $unit) { |
|
404 | + if (!($min instanceof UnboundedQuantityValue) || |
|
405 | + !($max instanceof UnboundedQuantityValue) |
|
406 | 406 | ) { |
407 | 407 | return false; |
408 | 408 | } |
409 | 409 | |
410 | - return ( $min->getUnit() === $unit ) !== ( $max->getUnit() === $unit ); |
|
410 | + return ($min->getUnit() === $unit) !== ($max->getUnit() === $unit); |
|
411 | 411 | } |
412 | 412 | |
413 | 413 | /** |
@@ -418,9 +418,9 @@ discard block |
||
418 | 418 | * @throws ConstraintParameterException if the parameter is invalid or missing |
419 | 419 | * @return DataValue[] a pair of two quantity-type data values, either of which may be null to signify an open range |
420 | 420 | */ |
421 | - public function parseRangeParameter( array $constraintParameters, $constraintTypeItemId, $type ) { |
|
422 | - $this->checkError( $constraintParameters ); |
|
423 | - switch ( $type ) { |
|
421 | + public function parseRangeParameter(array $constraintParameters, $constraintTypeItemId, $type) { |
|
422 | + $this->checkError($constraintParameters); |
|
423 | + switch ($type) { |
|
424 | 424 | case 'quantity': |
425 | 425 | $configKey = 'Quantity'; |
426 | 426 | break; |
@@ -429,46 +429,46 @@ discard block |
||
429 | 429 | break; |
430 | 430 | default: |
431 | 431 | throw new ConstraintParameterException( |
432 | - wfMessage( 'wbqc-violation-message-value-needed-of-types-2' ) |
|
432 | + wfMessage('wbqc-violation-message-value-needed-of-types-2') |
|
433 | 433 | ->rawParams( |
434 | - wfMessage( 'datatypes-type-quantity' )->escaped(), |
|
435 | - wfMessage( 'datatypes-type-time' )->escaped() |
|
434 | + wfMessage('datatypes-type-quantity')->escaped(), |
|
435 | + wfMessage('datatypes-type-time')->escaped() |
|
436 | 436 | ) |
437 | 437 | ->escaped() |
438 | 438 | ); |
439 | 439 | } |
440 | - $minimumId = $this->config->get( 'WBQualityConstraintsMinimum' . $configKey . 'Id' ); |
|
441 | - $maximumId = $this->config->get( 'WBQualityConstraintsMaximum' . $configKey . 'Id' ); |
|
442 | - if ( !array_key_exists( $minimumId, $constraintParameters ) || |
|
443 | - !array_key_exists( $maximumId, $constraintParameters ) |
|
440 | + $minimumId = $this->config->get('WBQualityConstraintsMinimum'.$configKey.'Id'); |
|
441 | + $maximumId = $this->config->get('WBQualityConstraintsMaximum'.$configKey.'Id'); |
|
442 | + if (!array_key_exists($minimumId, $constraintParameters) || |
|
443 | + !array_key_exists($maximumId, $constraintParameters) |
|
444 | 444 | ) { |
445 | 445 | throw new ConstraintParameterException( |
446 | - wfMessage( 'wbqc-violation-message-range-parameters-needed' ) |
|
446 | + wfMessage('wbqc-violation-message-range-parameters-needed') |
|
447 | 447 | ->rawParams( |
448 | - wfMessage( 'datatypes-type-' . $type )->escaped(), |
|
449 | - $this->constraintParameterRenderer->formatPropertyId( $minimumId, Role::CONSTRAINT_PARAMETER_PROPERTY ), |
|
450 | - $this->constraintParameterRenderer->formatPropertyId( $maximumId, Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
448 | + wfMessage('datatypes-type-'.$type)->escaped(), |
|
449 | + $this->constraintParameterRenderer->formatPropertyId($minimumId, Role::CONSTRAINT_PARAMETER_PROPERTY), |
|
450 | + $this->constraintParameterRenderer->formatPropertyId($maximumId, Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
451 | 451 | ) |
452 | - ->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) ) |
|
452 | + ->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM)) |
|
453 | 453 | ->escaped() |
454 | 454 | ); |
455 | 455 | } |
456 | 456 | |
457 | - $this->requireSingleParameter( $constraintParameters, $minimumId ); |
|
458 | - $this->requireSingleParameter( $constraintParameters, $maximumId ); |
|
457 | + $this->requireSingleParameter($constraintParameters, $minimumId); |
|
458 | + $this->requireSingleParameter($constraintParameters, $maximumId); |
|
459 | 459 | $parseFunction = $configKey === 'Date' ? 'parseValueOrNoValueOrNowParameter' : 'parseValueOrNoValueParameter'; |
460 | - $min = $this->$parseFunction( $constraintParameters[$minimumId][0], $minimumId ); |
|
461 | - $max = $this->$parseFunction( $constraintParameters[$maximumId][0], $maximumId ); |
|
460 | + $min = $this->$parseFunction($constraintParameters[$minimumId][0], $minimumId); |
|
461 | + $max = $this->$parseFunction($constraintParameters[$maximumId][0], $maximumId); |
|
462 | 462 | |
463 | - $yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' ); |
|
464 | - if ( $this->exactlyOneQuantityWithUnit( $min, $max, $yearUnit ) ) { |
|
463 | + $yearUnit = $this->config->get('WBQualityConstraintsYearUnit'); |
|
464 | + if ($this->exactlyOneQuantityWithUnit($min, $max, $yearUnit)) { |
|
465 | 465 | throw new ConstraintParameterException( |
466 | - wfMessage( 'wbqc-violation-message-range-parameters-one-year' ) |
|
466 | + wfMessage('wbqc-violation-message-range-parameters-one-year') |
|
467 | 467 | ->escaped() |
468 | 468 | ); |
469 | 469 | } |
470 | 470 | |
471 | - return [ $min, $max ]; |
|
471 | + return [$min, $max]; |
|
472 | 472 | } |
473 | 473 | |
474 | 474 | /** |
@@ -478,18 +478,18 @@ discard block |
||
478 | 478 | * @throws ConstraintParameterException |
479 | 479 | * @return string |
480 | 480 | */ |
481 | - private function parseStringParameter( array $snakSerialization, $parameterId ) { |
|
482 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
483 | - $this->requireValueParameter( $snak, $parameterId ); |
|
481 | + private function parseStringParameter(array $snakSerialization, $parameterId) { |
|
482 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
483 | + $this->requireValueParameter($snak, $parameterId); |
|
484 | 484 | $value = $snak->getDataValue(); |
485 | - if ( $value instanceof StringValue ) { |
|
485 | + if ($value instanceof StringValue) { |
|
486 | 486 | return $value->getValue(); |
487 | 487 | } else { |
488 | 488 | throw new ConstraintParameterException( |
489 | - wfMessage( 'wbqc-violation-message-parameter-string' ) |
|
489 | + wfMessage('wbqc-violation-message-parameter-string') |
|
490 | 490 | ->rawParams( |
491 | - $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ), |
|
492 | - $this->constraintParameterRenderer->formatDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
491 | + $this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY), |
|
492 | + $this->constraintParameterRenderer->formatDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
493 | 493 | ) |
494 | 494 | ->escaped() |
495 | 495 | ); |
@@ -502,15 +502,15 @@ discard block |
||
502 | 502 | * @throws ConstraintParameterException if the parameter is invalid or missing |
503 | 503 | * @return string |
504 | 504 | */ |
505 | - public function parseNamespaceParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
506 | - $this->checkError( $constraintParameters ); |
|
507 | - $namespaceId = $this->config->get( 'WBQualityConstraintsNamespaceId' ); |
|
508 | - if ( !array_key_exists( $namespaceId, $constraintParameters ) ) { |
|
505 | + public function parseNamespaceParameter(array $constraintParameters, $constraintTypeItemId) { |
|
506 | + $this->checkError($constraintParameters); |
|
507 | + $namespaceId = $this->config->get('WBQualityConstraintsNamespaceId'); |
|
508 | + if (!array_key_exists($namespaceId, $constraintParameters)) { |
|
509 | 509 | return ''; |
510 | 510 | } |
511 | 511 | |
512 | - $this->requireSingleParameter( $constraintParameters, $namespaceId ); |
|
513 | - return $this->parseStringParameter( $constraintParameters[$namespaceId][0], $namespaceId ); |
|
512 | + $this->requireSingleParameter($constraintParameters, $namespaceId); |
|
513 | + return $this->parseStringParameter($constraintParameters[$namespaceId][0], $namespaceId); |
|
514 | 514 | } |
515 | 515 | |
516 | 516 | /** |
@@ -519,20 +519,20 @@ discard block |
||
519 | 519 | * @throws ConstraintParameterException if the parameter is invalid or missing |
520 | 520 | * @return string |
521 | 521 | */ |
522 | - public function parseFormatParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
523 | - $this->checkError( $constraintParameters ); |
|
524 | - $formatId = $this->config->get( 'WBQualityConstraintsFormatAsARegularExpressionId' ); |
|
525 | - if ( !array_key_exists( $formatId, $constraintParameters ) ) { |
|
522 | + public function parseFormatParameter(array $constraintParameters, $constraintTypeItemId) { |
|
523 | + $this->checkError($constraintParameters); |
|
524 | + $formatId = $this->config->get('WBQualityConstraintsFormatAsARegularExpressionId'); |
|
525 | + if (!array_key_exists($formatId, $constraintParameters)) { |
|
526 | 526 | throw new ConstraintParameterException( |
527 | - wfMessage( 'wbqc-violation-message-parameter-needed' ) |
|
528 | - ->rawParams( $this->constraintParameterRenderer->formatItemId( $constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM ) ) |
|
529 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $formatId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
527 | + wfMessage('wbqc-violation-message-parameter-needed') |
|
528 | + ->rawParams($this->constraintParameterRenderer->formatItemId($constraintTypeItemId, Role::CONSTRAINT_TYPE_ITEM)) |
|
529 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($formatId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
530 | 530 | ->escaped() |
531 | 531 | ); |
532 | 532 | } |
533 | 533 | |
534 | - $this->requireSingleParameter( $constraintParameters, $formatId ); |
|
535 | - return $this->parseStringParameter( $constraintParameters[$formatId][0], $formatId ); |
|
534 | + $this->requireSingleParameter($constraintParameters, $formatId); |
|
535 | + return $this->parseStringParameter($constraintParameters[$formatId][0], $formatId); |
|
536 | 536 | } |
537 | 537 | |
538 | 538 | /** |
@@ -540,16 +540,16 @@ discard block |
||
540 | 540 | * @throws ConstraintParameterException if the parameter is invalid |
541 | 541 | * @return EntityId[] |
542 | 542 | */ |
543 | - public function parseExceptionParameter( array $constraintParameters ) { |
|
544 | - $this->checkError( $constraintParameters ); |
|
545 | - $exceptionId = $this->config->get( 'WBQualityConstraintsExceptionToConstraintId' ); |
|
546 | - if ( !array_key_exists( $exceptionId, $constraintParameters ) ) { |
|
543 | + public function parseExceptionParameter(array $constraintParameters) { |
|
544 | + $this->checkError($constraintParameters); |
|
545 | + $exceptionId = $this->config->get('WBQualityConstraintsExceptionToConstraintId'); |
|
546 | + if (!array_key_exists($exceptionId, $constraintParameters)) { |
|
547 | 547 | return []; |
548 | 548 | } |
549 | 549 | |
550 | 550 | return array_map( |
551 | - function( $snakSerialization ) use ( $exceptionId ) { |
|
552 | - return $this->parseEntityIdParameter( $snakSerialization, $exceptionId ); |
|
551 | + function($snakSerialization) use ($exceptionId) { |
|
552 | + return $this->parseEntityIdParameter($snakSerialization, $exceptionId); |
|
553 | 553 | }, |
554 | 554 | $constraintParameters[$exceptionId] |
555 | 555 | ); |
@@ -560,27 +560,27 @@ discard block |
||
560 | 560 | * @throws ConstraintParameterException if the parameter is invalid |
561 | 561 | * @return string|null 'mandatory' or null |
562 | 562 | */ |
563 | - public function parseConstraintStatusParameter( array $constraintParameters ) { |
|
564 | - $this->checkError( $constraintParameters ); |
|
565 | - $constraintStatusId = $this->config->get( 'WBQualityConstraintsConstraintStatusId' ); |
|
566 | - if ( !array_key_exists( $constraintStatusId, $constraintParameters ) ) { |
|
563 | + public function parseConstraintStatusParameter(array $constraintParameters) { |
|
564 | + $this->checkError($constraintParameters); |
|
565 | + $constraintStatusId = $this->config->get('WBQualityConstraintsConstraintStatusId'); |
|
566 | + if (!array_key_exists($constraintStatusId, $constraintParameters)) { |
|
567 | 567 | return null; |
568 | 568 | } |
569 | 569 | |
570 | - $mandatoryId = $this->config->get( 'WBQualityConstraintsMandatoryConstraintId' ); |
|
571 | - $this->requireSingleParameter( $constraintParameters, $constraintStatusId ); |
|
572 | - $snak = $this->snakDeserializer->deserialize( $constraintParameters[$constraintStatusId][0] ); |
|
573 | - $this->requireValueParameter( $snak, $constraintStatusId ); |
|
570 | + $mandatoryId = $this->config->get('WBQualityConstraintsMandatoryConstraintId'); |
|
571 | + $this->requireSingleParameter($constraintParameters, $constraintStatusId); |
|
572 | + $snak = $this->snakDeserializer->deserialize($constraintParameters[$constraintStatusId][0]); |
|
573 | + $this->requireValueParameter($snak, $constraintStatusId); |
|
574 | 574 | $statusId = $snak->getDataValue()->getEntityId()->getSerialization(); |
575 | 575 | |
576 | - if ( $statusId === $mandatoryId ) { |
|
576 | + if ($statusId === $mandatoryId) { |
|
577 | 577 | return 'mandatory'; |
578 | 578 | } else { |
579 | 579 | throw new ConstraintParameterException( |
580 | - wfMessage( 'wbqc-violation-message-parameter-oneof' ) |
|
581 | - ->rawParams( $this->constraintParameterRenderer->formatPropertyId( $constraintStatusId, Role::CONSTRAINT_PARAMETER_PROPERTY ) ) |
|
582 | - ->numParams( 1 ) |
|
583 | - ->rawParams( $this->constraintParameterRenderer->formatItemIdList( [ $mandatoryId ], Role::CONSTRAINT_PARAMETER_VALUE ) ) |
|
580 | + wfMessage('wbqc-violation-message-parameter-oneof') |
|
581 | + ->rawParams($this->constraintParameterRenderer->formatPropertyId($constraintStatusId, Role::CONSTRAINT_PARAMETER_PROPERTY)) |
|
582 | + ->numParams(1) |
|
583 | + ->rawParams($this->constraintParameterRenderer->formatItemIdList([$mandatoryId], Role::CONSTRAINT_PARAMETER_VALUE)) |
|
584 | 584 | ->escaped() |
585 | 585 | ); |
586 | 586 | } |
@@ -593,13 +593,13 @@ discard block |
||
593 | 593 | * @return void |
594 | 594 | * @throws ConstraintParameterException |
595 | 595 | */ |
596 | - private function requireMonolingualTextParameter( DataValue $dataValue, $parameterId ) { |
|
597 | - if ( !( $dataValue instanceof MonolingualTextValue ) ) { |
|
596 | + private function requireMonolingualTextParameter(DataValue $dataValue, $parameterId) { |
|
597 | + if (!($dataValue instanceof MonolingualTextValue)) { |
|
598 | 598 | throw new ConstraintParameterException( |
599 | - wfMessage( 'wbqc-violation-message-parameter-monolingualtext' ) |
|
599 | + wfMessage('wbqc-violation-message-parameter-monolingualtext') |
|
600 | 600 | ->rawParams( |
601 | - $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ), |
|
602 | - $this->constraintParameterRenderer->formatDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
601 | + $this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY), |
|
602 | + $this->constraintParameterRenderer->formatDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
603 | 603 | ) |
604 | 604 | ->escaped() |
605 | 605 | ); |
@@ -614,26 +614,26 @@ discard block |
||
614 | 614 | * @throws ConstraintParameterException if invalid snaks are found or a language has multiple texts |
615 | 615 | * @return string[] |
616 | 616 | */ |
617 | - private function parseMultilingualTextParameter( array $snakSerializations, $parameterId ) { |
|
617 | + private function parseMultilingualTextParameter(array $snakSerializations, $parameterId) { |
|
618 | 618 | $result = []; |
619 | 619 | |
620 | - foreach ( $snakSerializations as $snakSerialization ) { |
|
621 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
622 | - $this->requireValueParameter( $snak, $parameterId ); |
|
620 | + foreach ($snakSerializations as $snakSerialization) { |
|
621 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
622 | + $this->requireValueParameter($snak, $parameterId); |
|
623 | 623 | |
624 | 624 | $value = $snak->getDataValue(); |
625 | - $this->requireMonolingualTextParameter( $value, $parameterId ); |
|
625 | + $this->requireMonolingualTextParameter($value, $parameterId); |
|
626 | 626 | /** @var MonolingualTextValue $value */ |
627 | 627 | |
628 | 628 | $code = $value->getLanguageCode(); |
629 | - if ( array_key_exists( $code, $result ) ) { |
|
629 | + if (array_key_exists($code, $result)) { |
|
630 | 630 | throw new ConstraintParameterException( |
631 | - wfMessage( 'wbqc-violation-message-parameter-single-per-language' ) |
|
631 | + wfMessage('wbqc-violation-message-parameter-single-per-language') |
|
632 | 632 | ->rawParams( |
633 | - $this->constraintParameterRenderer->formatPropertyId( $parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
633 | + $this->constraintParameterRenderer->formatPropertyId($parameterId, Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
634 | 634 | ) |
635 | 635 | ->plaintextParams( |
636 | - Language::fetchLanguageName( $code ), |
|
636 | + Language::fetchLanguageName($code), |
|
637 | 637 | $code |
638 | 638 | ) |
639 | 639 | ->escaped() |
@@ -652,23 +652,23 @@ discard block |
||
652 | 652 | * @throws ConstraintParameterException if the parameter is invalid |
653 | 653 | * @return string|null |
654 | 654 | */ |
655 | - public function parseSyntaxClarificationParameter( array $constraintParameters, Language $language ) { |
|
656 | - $syntaxClarificationId = $this->config->get( 'WBQualityConstraintsSyntaxClarificationId' ); |
|
655 | + public function parseSyntaxClarificationParameter(array $constraintParameters, Language $language) { |
|
656 | + $syntaxClarificationId = $this->config->get('WBQualityConstraintsSyntaxClarificationId'); |
|
657 | 657 | |
658 | - if ( !array_key_exists( $syntaxClarificationId, $constraintParameters ) ) { |
|
658 | + if (!array_key_exists($syntaxClarificationId, $constraintParameters)) { |
|
659 | 659 | return null; |
660 | 660 | } |
661 | 661 | |
662 | 662 | $languageCodes = $language->getFallbackLanguages(); |
663 | - array_unshift( $languageCodes, $language->getCode() ); |
|
663 | + array_unshift($languageCodes, $language->getCode()); |
|
664 | 664 | |
665 | 665 | $syntaxClarifications = $this->parseMultilingualTextParameter( |
666 | 666 | $constraintParameters[$syntaxClarificationId], |
667 | 667 | $syntaxClarificationId |
668 | 668 | ); |
669 | 669 | |
670 | - foreach ( $languageCodes as $languageCode ) { |
|
671 | - if ( array_key_exists( $languageCode, $syntaxClarifications ) ) { |
|
670 | + foreach ($languageCodes as $languageCode) { |
|
671 | + if (array_key_exists($languageCode, $syntaxClarifications)) { |
|
672 | 672 | return $syntaxClarifications[$languageCode]; |
673 | 673 | } |
674 | 674 | } |
@@ -684,20 +684,20 @@ discard block |
||
684 | 684 | * @throws ConstraintParameterException if the parameter is invalid |
685 | 685 | * @return string[]|null Context::TYPE_* constants |
686 | 686 | */ |
687 | - public function parseConstraintScopeParameter( array $constraintParameters, $constraintTypeItemId, array $validScopes = null ) { |
|
688 | - $constraintScopeId = $this->config->get( 'WBQualityConstraintsConstraintScopeId' ); |
|
689 | - $mainSnakId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnMainValueId' ); |
|
690 | - $qualifiersId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnQualifiersId' ); |
|
691 | - $referencesId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnReferencesId' ); |
|
687 | + public function parseConstraintScopeParameter(array $constraintParameters, $constraintTypeItemId, array $validScopes = null) { |
|
688 | + $constraintScopeId = $this->config->get('WBQualityConstraintsConstraintScopeId'); |
|
689 | + $mainSnakId = $this->config->get('WBQualityConstraintsConstraintCheckedOnMainValueId'); |
|
690 | + $qualifiersId = $this->config->get('WBQualityConstraintsConstraintCheckedOnQualifiersId'); |
|
691 | + $referencesId = $this->config->get('WBQualityConstraintsConstraintCheckedOnReferencesId'); |
|
692 | 692 | |
693 | - if ( !array_key_exists( $constraintScopeId, $constraintParameters ) ) { |
|
693 | + if (!array_key_exists($constraintScopeId, $constraintParameters)) { |
|
694 | 694 | return null; |
695 | 695 | } |
696 | 696 | |
697 | 697 | $contextTypes = []; |
698 | - foreach ( $constraintParameters[$constraintScopeId] as $snakSerialization ) { |
|
699 | - $scopeEntityId = $this->parseEntityIdParameter( $snakSerialization, $constraintScopeId ); |
|
700 | - switch ( $scopeEntityId->getSerialization() ) { |
|
698 | + foreach ($constraintParameters[$constraintScopeId] as $snakSerialization) { |
|
699 | + $scopeEntityId = $this->parseEntityIdParameter($snakSerialization, $constraintScopeId); |
|
700 | + switch ($scopeEntityId->getSerialization()) { |
|
701 | 701 | case $mainSnakId: |
702 | 702 | $contextTypes[] = Context::TYPE_STATEMENT; |
703 | 703 | break; |
@@ -709,14 +709,14 @@ discard block |
||
709 | 709 | break; |
710 | 710 | default: |
711 | 711 | throw new ConstraintParameterException( |
712 | - wfMessage( 'wbqc-violation-message-parameter-oneof' ) |
|
712 | + wfMessage('wbqc-violation-message-parameter-oneof') |
|
713 | 713 | ->rawParams( |
714 | 714 | $this->constraintParameterRenderer->formatPropertyId( |
715 | 715 | $constraintScopeId, |
716 | 716 | Role::CONSTRAINT_PARAMETER_PROPERTY |
717 | 717 | ) |
718 | 718 | ) |
719 | - ->numParams( 3 ) |
|
719 | + ->numParams(3) |
|
720 | 720 | ->rawParams( |
721 | 721 | $this->constraintParameterRenderer->formatItemIdList( |
722 | 722 | [ |
@@ -732,12 +732,12 @@ discard block |
||
732 | 732 | } |
733 | 733 | } |
734 | 734 | |
735 | - if ( $validScopes !== null ) { |
|
736 | - $invalidScopes = array_diff( $contextTypes, $validScopes ); |
|
737 | - if ( $invalidScopes !== [] ) { |
|
738 | - $invalidScope = array_pop( $invalidScopes ); |
|
735 | + if ($validScopes !== null) { |
|
736 | + $invalidScopes = array_diff($contextTypes, $validScopes); |
|
737 | + if ($invalidScopes !== []) { |
|
738 | + $invalidScope = array_pop($invalidScopes); |
|
739 | 739 | throw new ConstraintParameterException( |
740 | - wfMessage( 'wbqc-violation-message-invalid-scope' ) |
|
740 | + wfMessage('wbqc-violation-message-invalid-scope') |
|
741 | 741 | ->rawParams( |
742 | 742 | $this->constraintParameterRenderer->formatConstraintScope( |
743 | 743 | $invalidScope, |
@@ -748,7 +748,7 @@ discard block |
||
748 | 748 | Role::CONSTRAINT_TYPE_ITEM |
749 | 749 | ) |
750 | 750 | ) |
751 | - ->numParams( count( $validScopes ) ) |
|
751 | + ->numParams(count($validScopes)) |
|
752 | 752 | ->rawParams( |
753 | 753 | $this->constraintParameterRenderer->formatConstraintScopeList( |
754 | 754 | $validScopes, |