Completed
Push — master ( b13dcc...ece800 )
by
unknown
50s
created
src/ConstraintRepositoryLookup.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 * then using the main DBLoadBalancer service may be incorrect.
26 26
 	 * @param string|false $dbName Database name ($domain for ILoadBalancer methods).
27 27
 	 */
28
-	public function __construct( ILoadBalancer $lb, $dbName ) {
28
+	public function __construct(ILoadBalancer $lb, $dbName) {
29 29
 		$this->lb = $lb;
30 30
 		$this->dbName = $dbName;
31 31
 	}
@@ -35,17 +35,17 @@  discard block
 block discarded – undo
35 35
 	 *
36 36
 	 * @return Constraint[]
37 37
 	 */
38
-	public function queryConstraintsForProperty( PropertyId $propertyId ) {
39
-		$dbr = $this->lb->getConnectionRef( ILoadBalancer::DB_REPLICA, [], $this->dbName );
38
+	public function queryConstraintsForProperty(PropertyId $propertyId) {
39
+		$dbr = $this->lb->getConnectionRef(ILoadBalancer::DB_REPLICA, [], $this->dbName);
40 40
 
41 41
 		$results = $dbr->select(
42 42
 			'wbqc_constraints',
43 43
 			'*',
44
-			[ 'pid' => $propertyId->getNumericId() ],
44
+			['pid' => $propertyId->getNumericId()],
45 45
 			__METHOD__
46 46
 		);
47 47
 
48
-		return $this->convertToConstraints( $results );
48
+		return $this->convertToConstraints($results);
49 49
 	}
50 50
 
51 51
 	/**
@@ -53,26 +53,26 @@  discard block
 block discarded – undo
53 53
 	 *
54 54
 	 * @return Constraint[]
55 55
 	 */
56
-	private function convertToConstraints( IResultWrapper $results ) {
56
+	private function convertToConstraints(IResultWrapper $results) {
57 57
 		$constraints = [];
58
-		$logger = LoggerFactory::getInstance( 'WikibaseQualityConstraints' );
59
-		foreach ( $results as $result ) {
58
+		$logger = LoggerFactory::getInstance('WikibaseQualityConstraints');
59
+		foreach ($results as $result) {
60 60
 			$constraintTypeItemId = $result->constraint_type_qid;
61
-			$constraintParameters = json_decode( $result->constraint_parameters, true );
61
+			$constraintParameters = json_decode($result->constraint_parameters, true);
62 62
 
63
-			if ( $constraintParameters === null ) {
63
+			if ($constraintParameters === null) {
64 64
 				// T171295
65
-				$logger->warning( 'Constraint {constraintId} has invalid constraint parameters.', [
65
+				$logger->warning('Constraint {constraintId} has invalid constraint parameters.', [
66 66
 					'method' => __METHOD__,
67 67
 					'constraintId' => $result->constraint_guid,
68 68
 					'constraintParameters' => $result->constraint_parameters,
69
-				] );
70
-				$constraintParameters = [ '@error' => [ /* unknown */ ] ];
69
+				]);
70
+				$constraintParameters = ['@error' => [/* unknown */]];
71 71
 			}
72 72
 
73 73
 			$constraints[] = new Constraint(
74 74
 				$result->constraint_guid,
75
-				PropertyId::newFromNumber( $result->pid ),
75
+				PropertyId::newFromNumber($result->pid),
76 76
 				$constraintTypeItemId,
77 77
 				$constraintParameters
78 78
 			);
Please login to merge, or discard this patch.
src/Job/CheckConstraintsJob.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -37,25 +37,25 @@  discard block
 block discarded – undo
37 37
 	 * @param Title $title
38 38
 	 * @param string[] $params should contain 'entityId' => 'Q1234'
39 39
 	 */
40
-	public function __construct( Title $title, array $params ) {
41
-		parent::__construct( self::COMMAND, $title, $params );
40
+	public function __construct(Title $title, array $params) {
41
+		parent::__construct(self::COMMAND, $title, $params);
42 42
 		$this->removeDuplicates = true;
43 43
 
44
-		Assert::parameterType( 'string', $params['entityId'], '$params[\'entityId\']' );
44
+		Assert::parameterType('string', $params['entityId'], '$params[\'entityId\']');
45 45
 
46
-		$resultSource = ConstraintsServices::getResultsSource( MediaWikiServices::getInstance() );
46
+		$resultSource = ConstraintsServices::getResultsSource(MediaWikiServices::getInstance());
47 47
 		'@phan-var CachingResultsSource $resultSource';
48 48
 		// This job should only ever be used when caching result sources are used.
49
-		$this->setResultsSource( $resultSource );
49
+		$this->setResultsSource($resultSource);
50 50
 
51
-		$this->setEntityIdParser( WikibaseRepo::getEntityIdParser() );
51
+		$this->setEntityIdParser(WikibaseRepo::getEntityIdParser());
52 52
 	}
53 53
 
54
-	public function setResultsSource( CachingResultsSource $resultsSource ) {
54
+	public function setResultsSource(CachingResultsSource $resultsSource) {
55 55
 		$this->resultsSource = $resultsSource;
56 56
 	}
57 57
 
58
-	public function setEntityIdParser( EntityIdParser $parser ) {
58
+	public function setEntityIdParser(EntityIdParser $parser) {
59 59
 		$this->entityIdParser = $parser;
60 60
 	}
61 61
 
@@ -66,19 +66,19 @@  discard block
 block discarded – undo
66 66
 	 */
67 67
 	public function run() {
68 68
 		try {
69
-			$entityId = $this->entityIdParser->parse( $this->params['entityId'] );
70
-		} catch ( EntityIdParsingException $e ) {
69
+			$entityId = $this->entityIdParser->parse($this->params['entityId']);
70
+		} catch (EntityIdParsingException $e) {
71 71
 			return false;
72 72
 		}
73 73
 
74
-		$this->checkConstraints( $entityId );
74
+		$this->checkConstraints($entityId);
75 75
 
76 76
 		return true;
77 77
 	}
78 78
 
79
-	private function checkConstraints( EntityId $entityId ) {
79
+	private function checkConstraints(EntityId $entityId) {
80 80
 		$this->resultsSource->getResults(
81
-			[ $entityId ],
81
+			[$entityId],
82 82
 			[],
83 83
 			null,
84 84
 			[]
Please login to merge, or discard this patch.
src/ConstraintsServices.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -38,87 +38,87 @@
 block discarded – undo
38 38
 	public const RESULTS_SOURCE = 'WBQC_ResultsSource';
39 39
 	public const EXPIRY_LOCK = 'WBQC_ExpiryLock';
40 40
 
41
-	private static function getService( ?MediaWikiServices $services, $name ) {
42
-		if ( $services === null ) {
41
+	private static function getService(?MediaWikiServices $services, $name) {
42
+		if ($services === null) {
43 43
 			$services = MediaWikiServices::getInstance();
44 44
 		}
45
-		return $services->getService( $name );
45
+		return $services->getService($name);
46 46
 	}
47 47
 
48
-	public static function getLoggingHelper( MediaWikiServices $services = null ): LoggingHelper {
49
-		return self::getService( $services, self::LOGGING_HELPER );
48
+	public static function getLoggingHelper(MediaWikiServices $services = null): LoggingHelper {
49
+		return self::getService($services, self::LOGGING_HELPER);
50 50
 	}
51 51
 
52 52
 	public static function getConstraintStore(
53 53
 		MediaWikiServices $services = null
54 54
 	): ConstraintStore {
55
-		return self::getService( $services, self::CONSTRAINT_STORE );
55
+		return self::getService($services, self::CONSTRAINT_STORE);
56 56
 	}
57 57
 
58
-	public static function getConstraintLookup( MediaWikiServices $services = null ): ConstraintLookup {
59
-		return self::getService( $services, self::CONSTRAINT_LOOKUP );
58
+	public static function getConstraintLookup(MediaWikiServices $services = null): ConstraintLookup {
59
+		return self::getService($services, self::CONSTRAINT_LOOKUP);
60 60
 	}
61 61
 
62 62
 	public static function getCheckResultSerializer(
63 63
 		MediaWikiServices $services = null
64 64
 	): CheckResultSerializer {
65
-		return self::getService( $services, self::CHECK_RESULT_SERIALIZER );
65
+		return self::getService($services, self::CHECK_RESULT_SERIALIZER);
66 66
 	}
67 67
 
68 68
 	public static function getCheckResultDeserializer(
69 69
 		MediaWikiServices $services = null
70 70
 	): CheckResultDeserializer {
71
-		return self::getService( $services, self::CHECK_RESULT_DESERIALIZER );
71
+		return self::getService($services, self::CHECK_RESULT_DESERIALIZER);
72 72
 	}
73 73
 
74 74
 	public static function getViolationMessageSerializer(
75 75
 		MediaWikiServices $services = null
76 76
 	): ViolationMessageSerializer {
77
-		return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER );
77
+		return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER);
78 78
 	}
79 79
 
80 80
 	public static function getViolationMessageDeserializer(
81 81
 		MediaWikiServices $services = null
82 82
 	): ViolationMessageDeserializer {
83
-		return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER );
83
+		return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER);
84 84
 	}
85 85
 
86 86
 	public static function getConstraintParameterParser(
87 87
 		MediaWikiServices $services = null
88 88
 	): ConstraintParameterParser {
89
-		return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER );
89
+		return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER);
90 90
 	}
91 91
 
92 92
 	public static function getConnectionCheckerHelper(
93 93
 		MediaWikiServices $services = null
94 94
 	): ConnectionCheckerHelper {
95
-		return self::getService( $services, self::CONNECTION_CHECKER_HELPER );
95
+		return self::getService($services, self::CONNECTION_CHECKER_HELPER);
96 96
 	}
97 97
 
98
-	public static function getRangeCheckerHelper( MediaWikiServices $services = null ): RangeCheckerHelper {
99
-		return self::getService( $services, self::RANGE_CHECKER_HELPER );
98
+	public static function getRangeCheckerHelper(MediaWikiServices $services = null): RangeCheckerHelper {
99
+		return self::getService($services, self::RANGE_CHECKER_HELPER);
100 100
 	}
101 101
 
102
-	public static function getSparqlHelper( MediaWikiServices $services = null ): SparqlHelper {
103
-		return self::getService( $services, self::SPARQL_HELPER );
102
+	public static function getSparqlHelper(MediaWikiServices $services = null): SparqlHelper {
103
+		return self::getService($services, self::SPARQL_HELPER);
104 104
 	}
105 105
 
106
-	public static function getTypeCheckerHelper( MediaWikiServices $services = null ): TypeCheckerHelper {
107
-		return self::getService( $services, self::TYPE_CHECKER_HELPER );
106
+	public static function getTypeCheckerHelper(MediaWikiServices $services = null): TypeCheckerHelper {
107
+		return self::getService($services, self::TYPE_CHECKER_HELPER);
108 108
 	}
109 109
 
110 110
 	public static function getDelegatingConstraintChecker(
111 111
 		MediaWikiServices $services = null
112 112
 	): DelegatingConstraintChecker {
113
-		return self::getService( $services, self::DELEGATING_CONSTRAINT_CHECKER );
113
+		return self::getService($services, self::DELEGATING_CONSTRAINT_CHECKER);
114 114
 	}
115 115
 
116
-	public static function getResultsSource( MediaWikiServices $services = null ): ResultsSource {
117
-		return self::getService( $services, self::RESULTS_SOURCE );
116
+	public static function getResultsSource(MediaWikiServices $services = null): ResultsSource {
117
+		return self::getService($services, self::RESULTS_SOURCE);
118 118
 	}
119 119
 
120
-	public static function getExpiryLock( MediaWikiServices $services = null ): ExpiryLock {
121
-		return self::getService( $services, self::EXPIRY_LOCK );
120
+	public static function getExpiryLock(MediaWikiServices $services = null): ExpiryLock {
121
+		return self::getService($services, self::EXPIRY_LOCK);
122 122
 	}
123 123
 
124 124
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Result/NullResult.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,22 +24,22 @@
 block discarded – undo
24 24
 	 */
25 25
 	private const NULL_PROPERTY_ID = 'P2147483647';
26 26
 
27
-	public function __construct( ContextCursor $contextCursor ) {
27
+	public function __construct(ContextCursor $contextCursor) {
28 28
 		$constraint = new Constraint(
29 29
 			'null',
30
-			new PropertyId( self::NULL_PROPERTY_ID ),
30
+			new PropertyId(self::NULL_PROPERTY_ID),
31 31
 			'none',
32 32
 			[]
33 33
 		);
34
-		parent::__construct( $contextCursor, $constraint );
34
+		parent::__construct($contextCursor, $constraint);
35 35
 	}
36 36
 
37 37
 	public function getConstraint() {
38
-		throw new DomainException( 'NullResult holds no constraint' );
38
+		throw new DomainException('NullResult holds no constraint');
39 39
 	}
40 40
 
41 41
 	public function getConstraintId() {
42
-		throw new DomainException( 'NullResult holds no constraint' );
42
+		throw new DomainException('NullResult holds no constraint');
43 43
 	}
44 44
 
45 45
 }
Please login to merge, or discard this patch.
src/WikibaseServices.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -20,35 +20,35 @@
 block discarded – undo
20 20
 	public const PROPERTY_DATA_TYPE_LOOKUP = 'WBQC_PropertyDataTypeLookup';
21 21
 	public const ENTITY_LOOKUP_WITHOUT_CACHE = 'WBQC_EntityLookupWithoutCache';
22 22
 
23
-	private static function getService( ?MediaWikiServices $services, $name ) {
24
-		if ( $services === null ) {
23
+	private static function getService(?MediaWikiServices $services, $name) {
24
+		if ($services === null) {
25 25
 			$services = MediaWikiServices::getInstance();
26 26
 		}
27
-		return $services->getService( $name );
27
+		return $services->getService($name);
28 28
 	}
29 29
 
30 30
 	/**
31 31
 	 * @param MediaWikiServices|null $services
32 32
 	 * @return EntityLookup
33 33
 	 */
34
-	public static function getEntityLookup( MediaWikiServices $services = null ) {
35
-		return self::getService( $services, self::ENTITY_LOOKUP );
34
+	public static function getEntityLookup(MediaWikiServices $services = null) {
35
+		return self::getService($services, self::ENTITY_LOOKUP);
36 36
 	}
37 37
 
38 38
 	/**
39 39
 	 * @param MediaWikiServices|null $services
40 40
 	 * @return PropertyDataTypeLookup
41 41
 	 */
42
-	public static function getPropertyDataTypeLookup( MediaWikiServices $services = null ) {
43
-		return self::getService( $services, self::PROPERTY_DATA_TYPE_LOOKUP );
42
+	public static function getPropertyDataTypeLookup(MediaWikiServices $services = null) {
43
+		return self::getService($services, self::PROPERTY_DATA_TYPE_LOOKUP);
44 44
 	}
45 45
 
46 46
 	/**
47 47
 	 * @param MediaWikiServices|null $services
48 48
 	 * @return EntityLookup
49 49
 	 */
50
-	public static function getEntityLookupWithoutCache( MediaWikiServices $services = null ) {
51
-		return self::getService( $services, self::ENTITY_LOOKUP_WITHOUT_CACHE );
50
+	public static function getEntityLookupWithoutCache(MediaWikiServices $services = null) {
51
+		return self::getService($services, self::ENTITY_LOOKUP_WITHOUT_CACHE);
52 52
 	}
53 53
 
54 54
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Message/MultilingualTextViolationMessageRenderer.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -54,13 +54,13 @@  discard block
 block discarded – undo
54 54
 	 * @param ViolationMessage $violationMessage
55 55
 	 * @return string
56 56
 	 */
57
-	public function render( ViolationMessage $violationMessage ) {
58
-		if ( !array_key_exists( $violationMessage->getMessageKey(), $this->alternativeMessageKeys ) ) {
59
-			return parent::render( $violationMessage );
57
+	public function render(ViolationMessage $violationMessage) {
58
+		if (!array_key_exists($violationMessage->getMessageKey(), $this->alternativeMessageKeys)) {
59
+			return parent::render($violationMessage);
60 60
 		}
61 61
 
62 62
 		$arguments = $violationMessage->getArguments();
63
-		$multilingualTextArgument = array_pop( $arguments );
63
+		$multilingualTextArgument = array_pop($arguments);
64 64
 		$multilingualTextParams = $this->renderMultilingualText(
65 65
 			// @phan-suppress-next-line PhanTypeArraySuspiciousNullable TODO Ensure this is not an actual issue
66 66
 			$multilingualTextArgument['value'],
@@ -68,22 +68,22 @@  discard block
 block discarded – undo
68 68
 			$multilingualTextArgument['role']
69 69
 		);
70 70
 
71
-		$paramsLists = [ [] ];
72
-		foreach ( $arguments as $argument ) {
73
-			$paramsLists[] = $this->renderArgument( $argument );
71
+		$paramsLists = [[]];
72
+		foreach ($arguments as $argument) {
73
+			$paramsLists[] = $this->renderArgument($argument);
74 74
 		}
75
-		$regularParams = call_user_func_array( 'array_merge', $paramsLists );
75
+		$regularParams = call_user_func_array('array_merge', $paramsLists);
76 76
 
77
-		if ( $multilingualTextParams === null ) {
77
+		if ($multilingualTextParams === null) {
78 78
 			return $this->messageLocalizer
79
-				->msg( $this->alternativeMessageKeys[$violationMessage->getMessageKey()] )
80
-				->params( $regularParams )
79
+				->msg($this->alternativeMessageKeys[$violationMessage->getMessageKey()])
80
+				->params($regularParams)
81 81
 				->escaped();
82 82
 		} else {
83 83
 			return $this->messageLocalizer
84
-				->msg( $violationMessage->getMessageKey() )
85
-				->params( $regularParams )
86
-				->params( $multilingualTextParams )
84
+				->msg($violationMessage->getMessageKey())
85
+				->params($regularParams)
86
+				->params($multilingualTextParams)
87 87
 				->escaped();
88 88
 		}
89 89
 	}
@@ -94,18 +94,18 @@  discard block
 block discarded – undo
94 94
 	 * @return array[]|null list of parameters as accepted by Message::params(),
95 95
 	 * or null if the text is not available in the user’s language
96 96
 	 */
97
-	protected function renderMultilingualText( MultilingualTextValue $text, $role ) {
97
+	protected function renderMultilingualText(MultilingualTextValue $text, $role) {
98 98
 		global $wgLang;
99 99
 		$languageCodes = $wgLang->getFallbackLanguages();
100
-		array_unshift( $languageCodes, $wgLang->getCode() );
100
+		array_unshift($languageCodes, $wgLang->getCode());
101 101
 
102 102
 		$texts = $text->getTexts();
103
-		foreach ( $languageCodes as $languageCode ) {
104
-			if ( array_key_exists( $languageCode, $texts ) ) {
105
-				return [ Message::rawParam( $this->addRole(
106
-					htmlspecialchars( $texts[$languageCode]->getText() ),
103
+		foreach ($languageCodes as $languageCode) {
104
+			if (array_key_exists($languageCode, $texts)) {
105
+				return [Message::rawParam($this->addRole(
106
+					htmlspecialchars($texts[$languageCode]->getText()),
107 107
 					$role
108
-				) ) ];
108
+				))];
109 109
 			}
110 110
 		}
111 111
 
Please login to merge, or discard this patch.
src/Api/ResultsCache.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	 * @param WANObjectCache $cache
37 37
 	 * @param string $formatVersion The version of the API response format.
38 38
 	 */
39
-	public function __construct( WANObjectCache $cache, $formatVersion ) {
39
+	public function __construct(WANObjectCache $cache, $formatVersion) {
40 40
 		$this->cache = $cache;
41 41
 		$this->formatVersion = $formatVersion;
42 42
 	}
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	 * @param EntityId $entityId
46 46
 	 * @return string cache key
47 47
 	 */
48
-	public function makeKey( EntityId $entityId ) {
48
+	public function makeKey(EntityId $entityId) {
49 49
 		return $this->cache->makeKey(
50 50
 			'WikibaseQualityConstraints', // extension
51 51
 			'checkConstraints', // action
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 	 * @param mixed|null &$info
62 62
 	 * @return mixed
63 63
 	 */
64
-	public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], &$info = null ) {
65
-		return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $info );
64
+	public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], &$info = null) {
65
+		return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $info);
66 66
 	}
67 67
 
68 68
 	/**
@@ -72,16 +72,16 @@  discard block
 block discarded – undo
72 72
 	 * @param array $opts
73 73
 	 * @return bool
74 74
 	 */
75
-	public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) {
76
-		return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts );
75
+	public function set(EntityId $key, $value, $ttl = 0, array $opts = []) {
76
+		return $this->cache->set($this->makeKey($key), $value, $ttl, $opts);
77 77
 	}
78 78
 
79 79
 	/**
80 80
 	 * @param EntityId $key
81 81
 	 * @return bool
82 82
 	 */
83
-	public function delete( EntityId $key ) {
84
-		return $this->cache->delete( $this->makeKey( $key ) );
83
+	public function delete(EntityId $key) {
84
+		return $this->cache->delete($this->makeKey($key));
85 85
 	}
86 86
 
87 87
 }
Please login to merge, or discard this patch.
src/WikibaseQualityConstraintsHooks.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -28,27 +28,27 @@  discard block
 block discarded – undo
28 28
 	/**
29 29
 	 * @param DatabaseUpdater $updater
30 30
 	 */
31
-	public static function onCreateSchema( DatabaseUpdater $updater ) {
32
-		$dir = dirname( __DIR__ ) . '/sql/';
31
+	public static function onCreateSchema(DatabaseUpdater $updater) {
32
+		$dir = dirname(__DIR__).'/sql/';
33 33
 
34 34
 		$updater->addExtensionTable(
35 35
 			'wbqc_constraints',
36
-			$dir . "/{$updater->getDB()->getType()}/tables-generated.sql"
36
+			$dir."/{$updater->getDB()->getType()}/tables-generated.sql"
37 37
 		);
38 38
 		$updater->addExtensionField(
39 39
 			'wbqc_constraints',
40 40
 			'constraint_id',
41
-			$dir . '/patch-wbqc_constraints-constraint_id.sql'
41
+			$dir.'/patch-wbqc_constraints-constraint_id.sql'
42 42
 		);
43 43
 		$updater->addExtensionIndex(
44 44
 			'wbqc_constraints',
45 45
 			'wbqc_constraints_guid_uniq',
46
-			$dir . '/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
46
+			$dir.'/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
47 47
 		);
48 48
 	}
49 49
 
50
-	public static function onWikibaseChange( Change $change ) {
51
-		if ( !( $change instanceof EntityChange ) ) {
50
+	public static function onWikibaseChange(Change $change) {
51
+		if (!($change instanceof EntityChange)) {
52 52
 			return;
53 53
 		}
54 54
 
@@ -57,48 +57,48 @@  discard block
 block discarded – undo
57 57
 
58 58
 		// If jobs are enabled and the results would be stored in some way run a job.
59 59
 		if (
60
-			$config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) &&
61
-			$config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) &&
60
+			$config->get('WBQualityConstraintsEnableConstraintsCheckJobs') &&
61
+			$config->get('WBQualityConstraintsCacheCheckConstraintsResults') &&
62 62
 			self::isSelectedForJobRunBasedOnPercentage()
63 63
 		) {
64
-			$params = [ 'entityId' => $change->getEntityId()->getSerialization() ];
64
+			$params = ['entityId' => $change->getEntityId()->getSerialization()];
65 65
 			JobQueueGroup::singleton()->lazyPush(
66
-				new JobSpecification( CheckConstraintsJob::COMMAND, $params )
66
+				new JobSpecification(CheckConstraintsJob::COMMAND, $params)
67 67
 			);
68 68
 		}
69 69
 
70
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
71
-			self::isConstraintStatementsChange( $config, $change )
70
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
71
+			self::isConstraintStatementsChange($config, $change)
72 72
 		) {
73
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
73
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
74 74
 			$metadata = $change->getMetadata();
75
-			if ( array_key_exists( 'rev_id', $metadata ) ) {
75
+			if (array_key_exists('rev_id', $metadata)) {
76 76
 				$params['revisionId'] = $metadata['rev_id'];
77 77
 			}
78 78
 			JobQueueGroup::singleton()->push(
79
-				new JobSpecification( 'constraintsTableUpdate', $params )
79
+				new JobSpecification('constraintsTableUpdate', $params)
80 80
 			);
81 81
 		}
82 82
 	}
83 83
 
84 84
 	private static function isSelectedForJobRunBasedOnPercentage() {
85 85
 		$config = MediaWikiServices::getInstance()->getMainConfig();
86
-		$percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' );
86
+		$percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio');
87 87
 
88
-		return mt_rand( 1, 100 ) <= $percentage;
88
+		return mt_rand(1, 100) <= $percentage;
89 89
 	}
90 90
 
91
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
92
-		if ( !( $change instanceof EntityChange ) ||
91
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
92
+		if (!($change instanceof EntityChange) ||
93 93
 			 $change->getAction() !== EntityChange::UPDATE ||
94
-			 !( $change->getEntityId() instanceof PropertyId )
94
+			 !($change->getEntityId() instanceof PropertyId)
95 95
 		) {
96 96
 			return false;
97 97
 		}
98 98
 
99 99
 		$info = $change->getInfo();
100 100
 
101
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
101
+		if (!array_key_exists('compactDiff', $info)) {
102 102
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
103 103
 			// so we only know that the change *might* affect the constraint statements
104 104
 			return true;
@@ -107,43 +107,43 @@  discard block
 block discarded – undo
107 107
 		/** @var EntityDiffChangedAspects $aspects */
108 108
 		$aspects = $info['compactDiff'];
109 109
 
110
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
111
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
110
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
111
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
112 112
 	}
113 113
 
114
-	public static function onArticlePurge( WikiPage $wikiPage ) {
114
+	public static function onArticlePurge(WikiPage $wikiPage) {
115 115
 		$entityContentFactory = WikibaseRepo::getEntityContentFactory();
116
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
116
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
117 117
 			$entityIdLookup = WikibaseRepo::getEntityIdLookup();
118
-			$entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() );
119
-			if ( $entityId !== null ) {
118
+			$entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle());
119
+			if ($entityId !== null) {
120 120
 				$resultsCache = ResultsCache::getDefaultInstance();
121
-				$resultsCache->delete( $entityId );
121
+				$resultsCache->delete($entityId);
122 122
 			}
123 123
 		}
124 124
 	}
125 125
 
126
-	public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
126
+	public static function onBeforePageDisplay(OutputPage $out, Skin $skin) {
127 127
 		$lookup = WikibaseRepo::getEntityNamespaceLookup();
128 128
 		$title = $out->getTitle();
129
-		if ( $title === null ) {
129
+		if ($title === null) {
130 130
 			return;
131 131
 		}
132 132
 
133
-		if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) {
133
+		if (!$lookup->isNamespaceWithEntities($title->getNamespace())) {
134 134
 			return;
135 135
 		}
136
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
136
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
137 137
 			return;
138 138
 		}
139 139
 
140
-		$out->addModules( 'wikibase.quality.constraints.suggestions' );
140
+		$out->addModules('wikibase.quality.constraints.suggestions');
141 141
 
142
-		if ( !$out->getUser()->isRegistered() ) {
142
+		if (!$out->getUser()->isRegistered()) {
143 143
 			return;
144 144
 		}
145 145
 
146
-		$out->addModules( 'wikibase.quality.constraints.gadget' );
146
+		$out->addModules('wikibase.quality.constraints.gadget');
147 147
 	}
148 148
 
149 149
 }
Please login to merge, or discard this patch.
src/Api/CheckResultsRendererFactory.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare( strict_types = 1 );
3
+declare(strict_types=1);
4 4
 
5 5
 namespace WikibaseQuality\ConstraintReport\Api;
6 6
 
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
33 33
 		$this->violationMessageRendererFactory = $violationMessageRendererFactory;
34 34
 	}
35 35
 
36
-	public function getCheckResultsRenderer( Language $language ): CheckResultsRenderer {
36
+	public function getCheckResultsRenderer(Language $language): CheckResultsRenderer {
37 37
 		return new CheckResultsRenderer(
38 38
 			$this->entityTitleLookup,
39 39
 			$this->entityIdLabelFormatterFactory
40
-				->getEntityIdFormatter( $language ),
40
+				->getEntityIdFormatter($language),
41 41
 			$this->violationMessageRendererFactory
42
-				->getViolationMessageRenderer( $language )
42
+				->getViolationMessageRenderer($language)
43 43
 		);
44 44
 	}
45 45
 
Please login to merge, or discard this patch.