wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Html/HtmlTableHeaderBuilder.php

Spacing +9 added lines, -9 removed lines

@@ -41,10 +41,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, $isSortable = false, $isRawContent = false ) {
-		Assert::parameterType( 'string', $content, '$content' );
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
+	public function __construct($content, $isSortable = false, $isRawContent = false) {
+		Assert::parameterType('string', $content, '$content');
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
 
 		$this->content = $content;
 		$this->isSortable = $isSortable;
@@ -71,20 +71,20 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		$attributes = [ 'role' => 'columnheader button' ];
+		$attributes = ['role' => 'columnheader button'];
 
-		if ( !$this->isSortable ) {
+		if (!$this->isSortable) {
 			$attributes['class'] = 'unsortable';
 		}
 
-		if ( !$this->isRawContent ) {
+		if (!$this->isRawContent) {
 			// @phan-suppress-next-line SecurityCheck-DoubleEscaped
-			$content = htmlspecialchars( $this->content );
+			$content = htmlspecialchars($this->content);
 		} else {
 			$content = $this->content;
 		}
 
-		return Html::rawElement( 'th', $attributes, $content );
+		return Html::rawElement('th', $attributes, $content);
 	}
 
 }

src/ConstraintCheck/Checker/SymmetricChecker.php

Spacing +23 added lines, -23 removed lines

@@ -74,9 +74,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -84,9 +84,9 @@ 
 		$snak = $context->getSnak();
 		$propertyId = $context->getSnak()->getPropertyId();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -95,18 +95,18 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Symmetric' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$symmetricStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -114,23 +114,23 @@ 
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $symmetricStatement !== null ) {
+		if ($symmetricStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-symmetric' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-symmetric'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Checker/InverseChecker.php

Spacing +25 added lines, -25 removed lines

@@ -84,9 +84,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -97,13 +97,13 @@ 
 			$constraintParameters,
 			$constraintTypeItemId
 		);
-		$parameters['property'] = [ $propertyId ];
+		$parameters['property'] = [$propertyId];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -112,18 +112,18 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Inverse' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$inverseStatement = $this->connectionCheckerHelper->findStatementWithPropertyAndEntityIdValue(
@@ -131,23 +131,23 @@ 
 			$propertyId,
 			$context->getEntity()->getId()
 		);
-		if ( $inverseStatement !== null ) {
+		if ($inverseStatement !== null) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-inverse' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withEntityId( $context->getEntity()->getId(), Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-inverse'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withEntityId($context->getEntity()->getId(), Role::OBJECT);
 			$status = CheckResult::STATUS_VIOLATION;
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -156,7 +156,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/TargetRequiredClaimChecker.php

Spacing +27 added lines, -27 removed lines

@@ -82,9 +82,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -95,7 +95,7 @@ 
 			$constraintParameters,
 			$constraintTypeItemId
 		);
-		$parameters['property'] = [ $propertyId ];
+		$parameters['property'] = [$propertyId];
 
 		$items = $this->constraintParameterParser->parseItemsParameter(
 			$constraintParameters,
@@ -106,9 +106,9 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -117,18 +117,18 @@ 
 		 * error handling:
 		 *   type of $dataValue for properties with 'Target required claim' constraint has to be 'wikibase-entityid'
 		 */
-		if ( !$dataValue instanceof EntityIdValue ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		if (!$dataValue instanceof EntityIdValue) {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$targetEntityId = $dataValue->getEntityId();
-		$targetEntity = $this->entityLookup->getEntity( $targetEntityId );
-		if ( !$targetEntity instanceof StatementListProvider ) {
-			$message = new ViolationMessage( 'wbqc-violation-message-target-entity-must-exist' );
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
+		$targetEntity = $this->entityLookup->getEntity($targetEntityId);
+		if (!$targetEntity instanceof StatementListProvider) {
+			$message = new ViolationMessage('wbqc-violation-message-target-entity-must-exist');
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/*
@@ -136,7 +136,7 @@ 
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$requiredStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$targetEntity->getStatements(),
 				$propertyId
@@ -149,23 +149,23 @@ 
 			);
 		}
 
-		if ( $requiredStatement !== null ) {
+		if ($requiredStatement !== null) {
 			$status = CheckResult::STATUS_COMPLIANCE;
 			$message = null;
 		} else {
 			$status = CheckResult::STATUS_VIOLATION;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-target-required-claim' ) )
-				->withEntityId( $targetEntityId, Role::SUBJECT )
-				->withEntityId( $propertyId, Role::PREDICATE )
-				->withItemIdSnakValueList( $items, Role::OBJECT );
+			$message = (new ViolationMessage('wbqc-violation-message-target-required-claim'))
+				->withEntityId($targetEntityId, Role::SUBJECT)
+				->withEntityId($propertyId, Role::PREDICATE)
+				->withItemIdSnakValueList($items, Role::OBJECT);
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( Metadata::ofDependencyMetadata(
-				DependencyMetadata::ofEntityId( $targetEntityId ) ) );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata(Metadata::ofDependencyMetadata(
+				DependencyMetadata::ofEntityId($targetEntityId) ));
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -174,7 +174,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -183,7 +183,7 @@ 
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +30 added lines, -30 removed lines

@@ -22,8 +22,8 @@ 
 	 */
 	private $statement;
 
-	public function __construct( StatementListProvidingEntity $entity, Statement $statement ) {
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(StatementListProvidingEntity $entity, Statement $statement) {
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -40,21 +40,21 @@ 
 		return $this->statement;
 	}
 
-	public function getSnakGroup( $groupingMode, array $separators = [] ) {
+	public function getSnakGroup($groupingMode, array $separators = []) {
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
-		switch ( $groupingMode ) {
+		switch ($groupingMode) {
 			case Context::GROUP_NON_DEPRECATED:
-				$statements = $statements->getByRank( [
+				$statements = $statements->getByRank([
 					Statement::RANK_NORMAL,
 					Statement::RANK_PREFERRED,
-				] );
+				]);
 				break;
 			case Context::GROUP_BEST_RANK:
-				$statements = $this->getBestStatementsPerPropertyId( $statements );
+				$statements = $this->getBestStatementsPerPropertyId($statements);
 				break;
 			default:
-				throw new LogicException( 'Unknown $groupingMode ' . $groupingMode );
+				throw new LogicException('Unknown $groupingMode '.$groupingMode);
 		}
 		return $this->getStatementsWithSameQualifiersForProperties(
 			$this->statement,
@@ -63,13 +63,13 @@ 
 		)->getMainSnaks();
 	}
 
-	private function getBestStatementsPerPropertyId( StatementList $statements ) {
+	private function getBestStatementsPerPropertyId(StatementList $statements) {
 		$allBestStatements = new StatementList();
-		foreach ( $statements->getPropertyIds() as $propertyId ) {
-			$bestStatements = $statements->getByPropertyId( $propertyId )
+		foreach ($statements->getPropertyIds() as $propertyId) {
+			$bestStatements = $statements->getByPropertyId($propertyId)
 				->getBestStatements();
-			foreach ( $bestStatements as $bestStatement ) {
-				$allBestStatements->addStatement( $bestStatement );
+			foreach ($bestStatements as $bestStatement) {
+				$allBestStatements->addStatement($bestStatement);
 			}
 		}
 		return $allBestStatements;
@@ -91,20 +91,20 @@ 
 		array $qualifierPropertyIds
 	) {
 		$similarStatements = new StatementList();
-		foreach ( $allStatements as $statement ) {
-			if ( $statement === $currentStatement ) {
+		foreach ($allStatements as $statement) {
+			if ($statement === $currentStatement) {
 				// if the statement has an “unknown value” qualifier,
 				// it might be considered different from itself,
 				// so add it explicitly to ensure it’s always included
-				$similarStatements->addStatement( $statement );
+				$similarStatements->addStatement($statement);
 				continue;
 			}
-			foreach ( $qualifierPropertyIds as $qualifierPropertyId ) {
-				if ( !$this->haveSameQualifiers( $currentStatement, $statement, $qualifierPropertyId ) ) {
+			foreach ($qualifierPropertyIds as $qualifierPropertyId) {
+				if (!$this->haveSameQualifiers($currentStatement, $statement, $qualifierPropertyId)) {
 					continue 2;
 				}
 			}
-			$similarStatements->addStatement( $statement );
+			$similarStatements->addStatement($statement);
 		}
 		return $similarStatements;
 	}
@@ -118,19 +118,19 @@ 
 	 * @param PropertyId $propertyId
 	 * @return bool
 	 */
-	private function haveSameQualifiers( Statement $s1, Statement $s2, PropertyId $propertyId ) {
-		$q1 = $this->getSnaksWithPropertyId( $s1->getQualifiers(), $propertyId );
-		$q2 = $this->getSnaksWithPropertyId( $s2->getQualifiers(), $propertyId );
+	private function haveSameQualifiers(Statement $s1, Statement $s2, PropertyId $propertyId) {
+		$q1 = $this->getSnaksWithPropertyId($s1->getQualifiers(), $propertyId);
+		$q2 = $this->getSnaksWithPropertyId($s2->getQualifiers(), $propertyId);
 
-		if ( $q1->count() !== $q2->count() ) {
+		if ($q1->count() !== $q2->count()) {
 			return false;
 		}
 
-		foreach ( $q1 as $qualifier ) {
-			switch ( $qualifier->getType() ) {
+		foreach ($q1 as $qualifier) {
+			switch ($qualifier->getType()) {
 				case 'value':
 				case 'novalue':
-					if ( !$q2->hasSnak( $qualifier ) ) {
+					if (!$q2->hasSnak($qualifier)) {
 						return false;
 					}
 					break;
@@ -152,12 +152,12 @@ 
 	 * @param PropertyId $propertyId
 	 * @return SnakList
 	 */
-	private function getSnaksWithPropertyId( SnakList $allSnaks, PropertyId $propertyId ) {
+	private function getSnaksWithPropertyId(SnakList $allSnaks, PropertyId $propertyId) {
 		$snaks = new SnakList();
 		/** @var Snak $snak */
-		foreach ( $allSnaks as $snak ) {
-			if ( $snak->getPropertyId()->equals( $propertyId ) ) {
-				$snaks->addSnak( $snak );
+		foreach ($allSnaks as $snak) {
+			if ($snak->getPropertyId()->equals($propertyId)) {
+				$snaks->addSnak($snak);
 			}
 		}
 		return $snaks;

src/ConstraintCheck/Context/AbstractContext.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 	 */
 	protected $snak;
 
-	public function __construct( StatementListProvidingEntity $entity, Snak $snak ) {
+	public function __construct(StatementListProvidingEntity $entity, Snak $snak) {
 		$this->entity = $entity;
 		$this->snak = $snak;
 	}

src/ConstraintCheck/Checker/ConflictsWithChecker.php

Spacing +20 added lines, -20 removed lines

@@ -71,9 +71,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -84,7 +84,7 @@ 
 			$constraintParameters,
 			$constraintTypeItemId
 		);
-		$parameters['property'] = [ $propertyId ];
+		$parameters['property'] = [$propertyId];
 
 		$items = $this->constraintParameterParser->parseItemsParameter(
 			$constraintParameters,
@@ -95,22 +95,22 @@ 
 
 		$statementList = $context->getEntity()
 			->getStatements()
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 
 		/*
 		 * 'Conflicts with' can be defined with
 		 *   a) a property only
 		 *   b) a property and a number of items (each combination of property and item forming an individual claim)
 		 */
-		if ( $items === [] ) {
+		if ($items === []) {
 			$offendingStatement = $this->connectionCheckerHelper->findStatementWithProperty(
 				$statementList,
 				$propertyId
 			);
-			if ( $offendingStatement !== null ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-property' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE );
+			if ($offendingStatement !== null) {
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-property'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -122,12 +122,12 @@ 
 				$propertyId,
 				$items
 			);
-			if ( $offendingStatement !== null ) {
-				$offendingValue = ItemIdSnakValue::fromSnak( $offendingStatement->getMainSnak() );
-				$message = ( new ViolationMessage( 'wbqc-violation-message-conflicts-with-claim' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY )
-					->withEntityId( $propertyId, Role::PREDICATE )
-					->withItemIdSnakValue( $offendingValue, Role::OBJECT );
+			if ($offendingStatement !== null) {
+				$offendingValue = ItemIdSnakValue::fromSnak($offendingStatement->getMainSnak());
+				$message = (new ViolationMessage('wbqc-violation-message-conflicts-with-claim'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY)
+					->withEntityId($propertyId, Role::PREDICATE)
+					->withItemIdSnakValue($offendingValue, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 			} else {
 				$message = null;
@@ -135,10 +135,10 @@ 
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -147,7 +147,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -156,7 +156,7 @@ 
 				$constraintTypeItemId,
 				false
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Message/ViolationMessageDeserializer.php

Spacing +32 added lines, -32 removed lines

@@ -39,23 +39,23 @@ 
 		$this->dataValueFactory = $dataValueFactory;
 	}
 
-	public function unabbreviateViolationMessageKey( $messageKeySuffix ) {
-		return ViolationMessage::MESSAGE_KEY_PREFIX . $messageKeySuffix;
+	public function unabbreviateViolationMessageKey($messageKeySuffix) {
+		return ViolationMessage::MESSAGE_KEY_PREFIX.$messageKeySuffix;
 	}
 
 	/**
 	 * @param array $serialization
 	 * @return ViolationMessage
 	 */
-	public function deserialize( $serialization ) {
-		Assert::parameterType( 'array', $serialization, '$serialization' );
+	public function deserialize($serialization) {
+		Assert::parameterType('array', $serialization, '$serialization');
 
 		$message = new ViolationMessage(
-			$this->unabbreviateViolationMessageKey( $serialization['k'] )
+			$this->unabbreviateViolationMessageKey($serialization['k'])
 		);
 
-		foreach ( $serialization['a'] as $serializedArgument ) {
-			$message = $this->deserializeArgument( $message, $serializedArgument );
+		foreach ($serialization['a'] as $serializedArgument) {
+			$message = $this->deserializeArgument($message, $serializedArgument);
 		}
 
 		return $message;
@@ -66,7 +66,7 @@ 
 	 * @param array $serializedArgument [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ]
 	 * @return ViolationMessage $message with the deserialized argument appended
 	 */
-	private function deserializeArgument( ViolationMessage $message, array $serializedArgument ) {
+	private function deserializeArgument(ViolationMessage $message, array $serializedArgument) {
 		$methods = [
 			ViolationMessage::TYPE_ENTITY_ID => 'deserializeEntityId',
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'deserializeEntityIdList',
@@ -87,23 +87,23 @@ 
 		$serializedValue = $serializedArgument['v'];
 		$role = $serializedArgument['r'];
 
-		if ( array_key_exists( $type, $methods ) ) {
+		if (array_key_exists($type, $methods)) {
 			$method = $methods[$type];
-			$value = $this->$method( $serializedValue );
+			$value = $this->$method($serializedValue);
 		} else {
 			throw new InvalidArgumentException(
-				'Unknown ViolationMessage argument type ' . $type . '!'
+				'Unknown ViolationMessage argument type '.$type.'!'
 			);
 		}
 
-		return $message->withArgument( $type, $role, $value );
+		return $message->withArgument($type, $role, $value);
 	}
 
 	/**
 	 * @param string $string any value that shall simply be deserialized into itself
 	 * @return string that same value, unchanged
 	 */
-	private function deserializeStringByIdentity( $string ) {
+	private function deserializeStringByIdentity($string) {
 		return $string;
 	}
 
@@ -111,32 +111,32 @@ 
 	 * @param string $entityIdSerialization entity ID serialization
 	 * @return EntityId
 	 */
-	private function deserializeEntityId( $entityIdSerialization ) {
-		return $this->entityIdParser->parse( $entityIdSerialization );
+	private function deserializeEntityId($entityIdSerialization) {
+		return $this->entityIdParser->parse($entityIdSerialization);
 	}
 
 	/**
 	 * @param string[] $entityIdSerializations entity ID serializations
 	 * @return EntityId[]
 	 */
-	private function deserializeEntityIdList( array $entityIdSerializations ) {
-		return array_map( [ $this, 'deserializeEntityId' ], $entityIdSerializations );
+	private function deserializeEntityIdList(array $entityIdSerializations) {
+		return array_map([$this, 'deserializeEntityId'], $entityIdSerializations);
 	}
 
 	/**
 	 * @param string $valueSerialization entity ID serialization, '::somevalue' or '::novalue'
 	 * @return ItemIdSnakValue
 	 */
-	private function deserializeItemIdSnakValue( $valueSerialization ) {
-		switch ( $valueSerialization ) {
+	private function deserializeItemIdSnakValue($valueSerialization) {
+		switch ($valueSerialization) {
 			case '::somevalue':
 				return ItemIdSnakValue::someValue();
 			case '::novalue':
 				return ItemIdSnakValue::noValue();
 			default:
-				$itemId = $this->deserializeEntityId( $valueSerialization );
+				$itemId = $this->deserializeEntityId($valueSerialization);
 				'@phan-var \Wikibase\DataModel\Entity\ItemId $itemId';
-				return ItemIdSnakValue::fromItemId( $itemId );
+				return ItemIdSnakValue::fromItemId($itemId);
 		}
 	}
 
@@ -144,24 +144,24 @@ 
 	 * @param string[] $valueSerializations entity ID serializations, '::somevalue's or '::novalue's
 	 * @return ItemIdSnakValue[]
 	 */
-	private function deserializeItemIdSnakValueList( $valueSerializations ) {
-		return array_map( [ $this, 'deserializeItemIdSnakValue' ], $valueSerializations );
+	private function deserializeItemIdSnakValueList($valueSerializations) {
+		return array_map([$this, 'deserializeItemIdSnakValue'], $valueSerializations);
 	}
 
 	/**
 	 * @param array $dataValueSerialization the data value in array form
 	 * @return DataValue
 	 */
-	private function deserializeDataValue( array $dataValueSerialization ) {
-		return $this->dataValueFactory->newFromArray( $dataValueSerialization );
+	private function deserializeDataValue(array $dataValueSerialization) {
+		return $this->dataValueFactory->newFromArray($dataValueSerialization);
 	}
 
 	/**
 	 * @param string $contextTypeAbbreviation
 	 * @return string one of the Context::TYPE_* constants
 	 */
-	private function deserializeContextType( $contextTypeAbbreviation ) {
-		switch ( $contextTypeAbbreviation ) {
+	private function deserializeContextType($contextTypeAbbreviation) {
+		switch ($contextTypeAbbreviation) {
 			case 's':
 				return Context::TYPE_STATEMENT;
 			case 'q':
@@ -171,7 +171,7 @@ 
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
-					'Unknown context type abbreviation ' . $contextTypeAbbreviation
+					'Unknown context type abbreviation '.$contextTypeAbbreviation
 				);
 				// @codeCoverageIgnoreEnd
 		}
@@ -181,16 +181,16 @@ 
 	 * @param string[] $contextTypeAbbreviations
 	 * @return string[] Context::TYPE_* constants
 	 */
-	private function deserializeContextTypeList( array $contextTypeAbbreviations ) {
-		return array_map( [ $this, 'deserializeContextType' ], $contextTypeAbbreviations );
+	private function deserializeContextTypeList(array $contextTypeAbbreviations) {
+		return array_map([$this, 'deserializeContextType'], $contextTypeAbbreviations);
 	}
 
 	/**
 	 * @param mixed $textSerialization {@see MultilingualTextValue::getArrayValue}
 	 * @return MultilingualTextValue
 	 */
-	private function deserializeMultilingualText( $textSerialization ) {
-		return MultilingualTextValue::newFromArray( $textSerialization );
+	private function deserializeMultilingualText($textSerialization) {
+		return MultilingualTextValue::newFromArray($textSerialization);
 	}
 
 }

src/ConstraintCheck/Checker/DiffWithinRangeChecker.php

Spacing +41 added lines, -42 removed lines

@@ -76,8 +76,8 @@ 
 	 * @throws ConstraintParameterException
 	 * @return array [ DataValue|null $min, DataValue|null $max, PropertyId $property, array $parameters ]
 	 */
-	private function parseConstraintParameters( Constraint $constraint ) {
-		list( $min, $max ) = $this->constraintParameterParser->parseQuantityRangeParameter(
+	private function parseConstraintParameters(Constraint $constraint) {
+		list($min, $max) = $this->constraintParameterParser->parseQuantityRangeParameter(
 			$constraint->getConstraintParameters(),
 			$constraint->getConstraintTypeItemId()
 		);
@@ -87,15 +87,15 @@ 
 		);
 
 		$parameters = [];
-		if ( $min !== null ) {
-			$parameters['minimum_quantity'] = [ $min ];
+		if ($min !== null) {
+			$parameters['minimum_quantity'] = [$min];
 		}
-		if ( $max !== null ) {
-			$parameters['maximum_quantity'] = [ $max ];
+		if ($max !== null) {
+			$parameters['maximum_quantity'] = [$max];
 		}
-		$parameters['property'] = [ $property ];
+		$parameters['property'] = [$property];
 
-		return [ $min, $max, $property, $parameters ];
+		return [$min, $max, $property, $parameters];
 	}
 
 	/**
@@ -105,13 +105,13 @@ 
 	 *
 	 * @return bool
 	 */
-	private function rangeInYears( $min, $max ) {
-		$yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' );
+	private function rangeInYears($min, $max) {
+		$yearUnit = $this->config->get('WBQualityConstraintsYearUnit');
 
-		if ( $min !== null && $min->getUnit() === $yearUnit ) {
+		if ($min !== null && $min->getUnit() === $yearUnit) {
 			return true;
 		}
-		if ( $max !== null && $max->getUnit() === $yearUnit ) {
+		if ($max !== null && $max->getUnit() === $yearUnit) {
 			return true;
 		}
 
@@ -127,30 +127,30 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$minuend = $snak->getDataValue();
 		'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $minuend';
 
 		/** @var PropertyId $property */
-		list( $min, $max, $property, $parameters ) = $this->parseConstraintParameters( $constraint );
+		list($min, $max, $property, $parameters) = $this->parseConstraintParameters($constraint);
 
 		// checks only the first occurrence of the referenced property
-		foreach ( $context->getSnakGroup( Context::GROUP_NON_DEPRECATED ) as $otherSnak ) {
+		foreach ($context->getSnakGroup(Context::GROUP_NON_DEPRECATED) as $otherSnak) {
 			if (
-				!$property->equals( $otherSnak->getPropertyId() ) ||
+				!$property->equals($otherSnak->getPropertyId()) ||
 				!$otherSnak instanceof PropertyValueSnak
 			) {
 				continue;
@@ -158,30 +158,29 @@ 
 
 			$subtrahend = $otherSnak->getDataValue();
 			'@phan-var \DataValues\TimeValue|\DataValues\QuantityValue|\DataValues\UnboundedQuantityValue $subtrahend';
-			if ( $subtrahend->getType() === $minuend->getType() ) {
-				$diff = $this->rangeInYears( $min, $max ) && $minuend->getType() === 'time' ?
-					$this->rangeCheckerHelper->getDifferenceInYears( $minuend, $subtrahend ) :
-					$this->rangeCheckerHelper->getDifference( $minuend, $subtrahend );
+			if ($subtrahend->getType() === $minuend->getType()) {
+				$diff = $this->rangeInYears($min, $max) && $minuend->getType() === 'time' ?
+					$this->rangeCheckerHelper->getDifferenceInYears($minuend, $subtrahend) : $this->rangeCheckerHelper->getDifference($minuend, $subtrahend);
 
-				if ( $this->rangeCheckerHelper->getComparison( $min, $diff ) > 0 ||
-					$this->rangeCheckerHelper->getComparison( $diff, $max ) > 0
+				if ($this->rangeCheckerHelper->getComparison($min, $diff) > 0 ||
+					$this->rangeCheckerHelper->getComparison($diff, $max) > 0
 				) {
 					// at least one of $min, $max is set at this point, otherwise there could be no violation
-					$openness = $min !== null ? ( $max !== null ? '' : '-rightopen' ) : '-leftopen';
+					$openness = $min !== null ? ($max !== null ? '' : '-rightopen') : '-leftopen';
 					// possible message keys:
 					// wbqc-violation-message-diff-within-range
 					// wbqc-violation-message-diff-within-range-leftopen
 					// wbqc-violation-message-diff-within-range-rightopen
-					$message = ( new ViolationMessage( "wbqc-violation-message-diff-within-range$openness" ) )
-						->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $minuend, Role::OBJECT )
-						->withEntityId( $otherSnak->getPropertyId(), Role::PREDICATE )
-						->withDataValue( $subtrahend, Role::OBJECT );
-					if ( $min !== null ) {
-						$message = $message->withDataValue( $min, Role::OBJECT );
+					$message = (new ViolationMessage("wbqc-violation-message-diff-within-range$openness"))
+						->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+						->withDataValue($minuend, Role::OBJECT)
+						->withEntityId($otherSnak->getPropertyId(), Role::PREDICATE)
+						->withDataValue($subtrahend, Role::OBJECT);
+					if ($min !== null) {
+						$message = $message->withDataValue($min, Role::OBJECT);
 					}
-					if ( $max !== null ) {
-						$message = $message->withDataValue( $max, Role::OBJECT );
+					if ($max !== null) {
+						$message = $message->withDataValue($max, Role::OBJECT);
 					}
 					$status = CheckResult::STATUS_VIOLATION;
 				} else {
@@ -189,17 +188,17 @@ 
 					$status = CheckResult::STATUS_COMPLIANCE;
 				}
 			} else {
-				$message = new ViolationMessage( 'wbqc-violation-message-diff-within-range-must-have-equal-types' );
+				$message = new ViolationMessage('wbqc-violation-message-diff-within-range-must-have-equal-types');
 				$status = CheckResult::STATUS_VIOLATION;
 			}
 
-			return new CheckResult( $context, $constraint, $parameters, $status, $message );
+			return new CheckResult($context, $constraint, $parameters, $status, $message);
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -208,7 +207,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		try {
@@ -216,7 +215,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;