@@ -38,90 +38,90 @@ |
||
38 | 38 | const RESULTS_SOURCE = 'WBQC_ResultsSource'; |
39 | 39 | const EXPIRY_LOCK = 'WBQC_ExpiryLock'; |
40 | 40 | |
41 | - private static function getService( ?MediaWikiServices $services, $name ) { |
|
42 | - if ( $services === null ) { |
|
41 | + private static function getService(?MediaWikiServices $services, $name) { |
|
42 | + if ($services === null) { |
|
43 | 43 | $services = MediaWikiServices::getInstance(); |
44 | 44 | } |
45 | - return $services->getService( $name ); |
|
45 | + return $services->getService($name); |
|
46 | 46 | } |
47 | 47 | |
48 | - public static function getLoggingHelper( MediaWikiServices $services = null ): LoggingHelper { |
|
49 | - return self::getService( $services, self::LOGGING_HELPER ); |
|
48 | + public static function getLoggingHelper(MediaWikiServices $services = null): LoggingHelper { |
|
49 | + return self::getService($services, self::LOGGING_HELPER); |
|
50 | 50 | } |
51 | 51 | |
52 | 52 | public static function getConstraintRepository( |
53 | 53 | MediaWikiServices $services = null |
54 | 54 | ): ConstraintRepository { |
55 | - return self::getService( $services, self::CONSTRAINT_REPOSITORY ); |
|
55 | + return self::getService($services, self::CONSTRAINT_REPOSITORY); |
|
56 | 56 | } |
57 | 57 | |
58 | - public static function getConstraintLookup( MediaWikiServices $services = null ): ConstraintLookup { |
|
59 | - return self::getService( $services, self::CONSTRAINT_LOOKUP ); |
|
58 | + public static function getConstraintLookup(MediaWikiServices $services = null): ConstraintLookup { |
|
59 | + return self::getService($services, self::CONSTRAINT_LOOKUP); |
|
60 | 60 | } |
61 | 61 | |
62 | 62 | public static function getCheckResultSerializer( |
63 | 63 | MediaWikiServices $services = null |
64 | 64 | ): CheckResultSerializer { |
65 | - return self::getService( $services, self::CHECK_RESULT_SERIALIZER ); |
|
65 | + return self::getService($services, self::CHECK_RESULT_SERIALIZER); |
|
66 | 66 | } |
67 | 67 | |
68 | 68 | public static function getCheckResultDeserializer( |
69 | 69 | MediaWikiServices $services = null |
70 | 70 | ): CheckResultDeserializer { |
71 | - return self::getService( $services, self::CHECK_RESULT_DESERIALIZER ); |
|
71 | + return self::getService($services, self::CHECK_RESULT_DESERIALIZER); |
|
72 | 72 | } |
73 | 73 | |
74 | 74 | public static function getViolationMessageSerializer( |
75 | 75 | MediaWikiServices $services = null |
76 | 76 | ): ViolationMessageSerializer { |
77 | - return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER ); |
|
77 | + return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER); |
|
78 | 78 | } |
79 | 79 | |
80 | 80 | public static function getViolationMessageDeserializer( |
81 | 81 | MediaWikiServices $services = null |
82 | 82 | ): ViolationMessageDeserializer { |
83 | - return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER ); |
|
83 | + return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER); |
|
84 | 84 | } |
85 | 85 | |
86 | 86 | public static function getConstraintParameterParser( |
87 | 87 | MediaWikiServices $services = null |
88 | 88 | ): ConstraintParameterParser { |
89 | - return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER ); |
|
89 | + return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER); |
|
90 | 90 | } |
91 | 91 | |
92 | 92 | public static function getConnectionCheckerHelper( |
93 | 93 | MediaWikiServices $services = null |
94 | 94 | ): ConnectionCheckerHelper { |
95 | - return self::getService( $services, self::CONNECTION_CHECKER_HELPER ); |
|
95 | + return self::getService($services, self::CONNECTION_CHECKER_HELPER); |
|
96 | 96 | } |
97 | 97 | |
98 | - public static function getRangeCheckerHelper( MediaWikiServices $services = null ): RangeCheckerHelper { |
|
99 | - return self::getService( $services, self::RANGE_CHECKER_HELPER ); |
|
98 | + public static function getRangeCheckerHelper(MediaWikiServices $services = null): RangeCheckerHelper { |
|
99 | + return self::getService($services, self::RANGE_CHECKER_HELPER); |
|
100 | 100 | } |
101 | 101 | |
102 | - public static function getSparqlHelper( MediaWikiServices $services = null ): SparqlHelper { |
|
103 | - return self::getService( $services, self::SPARQL_HELPER ); |
|
102 | + public static function getSparqlHelper(MediaWikiServices $services = null): SparqlHelper { |
|
103 | + return self::getService($services, self::SPARQL_HELPER); |
|
104 | 104 | } |
105 | 105 | |
106 | - public static function getTypeCheckerHelper( MediaWikiServices $services = null ): TypeCheckerHelper { |
|
107 | - return self::getService( $services, self::TYPE_CHECKER_HELPER ); |
|
106 | + public static function getTypeCheckerHelper(MediaWikiServices $services = null): TypeCheckerHelper { |
|
107 | + return self::getService($services, self::TYPE_CHECKER_HELPER); |
|
108 | 108 | } |
109 | 109 | |
110 | 110 | public static function getDelegatingConstraintChecker( |
111 | 111 | MediaWikiServices $services = null |
112 | 112 | ): DelegatingConstraintChecker { |
113 | - return self::getService( $services, self::DELEGATING_CONSTRAINT_CHECKER ); |
|
113 | + return self::getService($services, self::DELEGATING_CONSTRAINT_CHECKER); |
|
114 | 114 | } |
115 | 115 | |
116 | - public static function getResultsSource( MediaWikiServices $services = null ): ResultsSource { |
|
117 | - return self::getService( $services, self::RESULTS_SOURCE ); |
|
116 | + public static function getResultsSource(MediaWikiServices $services = null): ResultsSource { |
|
117 | + return self::getService($services, self::RESULTS_SOURCE); |
|
118 | 118 | } |
119 | 119 | |
120 | 120 | /** |
121 | 121 | * @return ExpiryLock |
122 | 122 | */ |
123 | - public static function getExpiryLock( MediaWikiServices $services = null ) { |
|
124 | - return self::getService( $services, self::EXPIRY_LOCK ); |
|
123 | + public static function getExpiryLock(MediaWikiServices $services = null) { |
|
124 | + return self::getService($services, self::EXPIRY_LOCK); |
|
125 | 125 | } |
126 | 126 | |
127 | 127 | } |
@@ -143,14 +143,14 @@ discard block |
||
143 | 143 | ) { |
144 | 144 | $results = []; |
145 | 145 | $metadatas = []; |
146 | - if ( $this->canUseStoredResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) { |
|
146 | + if ($this->canUseStoredResults($entityIds, $claimIds, $constraintIds, $statuses)) { |
|
147 | 147 | $storedEntityIds = []; |
148 | - foreach ( $entityIds as $entityId ) { |
|
149 | - $storedResults = $this->getStoredResults( $entityId ); |
|
150 | - if ( $storedResults !== null ) { |
|
151 | - $this->loggingHelper->logCheckConstraintsCacheHit( $entityId ); |
|
152 | - foreach ( $storedResults->getArray() as $checkResult ) { |
|
153 | - if ( $this->statusSelected( $statuses, $checkResult ) ) { |
|
148 | + foreach ($entityIds as $entityId) { |
|
149 | + $storedResults = $this->getStoredResults($entityId); |
|
150 | + if ($storedResults !== null) { |
|
151 | + $this->loggingHelper->logCheckConstraintsCacheHit($entityId); |
|
152 | + foreach ($storedResults->getArray() as $checkResult) { |
|
153 | + if ($this->statusSelected($statuses, $checkResult)) { |
|
154 | 154 | $results[] = $checkResult; |
155 | 155 | } |
156 | 156 | } |
@@ -158,19 +158,19 @@ discard block |
||
158 | 158 | $storedEntityIds[] = $entityId; |
159 | 159 | } |
160 | 160 | } |
161 | - $entityIds = array_values( array_diff( $entityIds, $storedEntityIds ) ); |
|
161 | + $entityIds = array_values(array_diff($entityIds, $storedEntityIds)); |
|
162 | 162 | } |
163 | - if ( $entityIds !== [] || $claimIds !== [] ) { |
|
164 | - if ( $entityIds !== [] ) { |
|
165 | - $this->loggingHelper->logCheckConstraintsCacheMisses( $entityIds ); |
|
163 | + if ($entityIds !== [] || $claimIds !== []) { |
|
164 | + if ($entityIds !== []) { |
|
165 | + $this->loggingHelper->logCheckConstraintsCacheMisses($entityIds); |
|
166 | 166 | } |
167 | - $response = $this->getAndStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ); |
|
168 | - $results = array_merge( $results, $response->getArray() ); |
|
167 | + $response = $this->getAndStoreResults($entityIds, $claimIds, $constraintIds, $statuses); |
|
168 | + $results = array_merge($results, $response->getArray()); |
|
169 | 169 | $metadatas[] = $response->getMetadata(); |
170 | 170 | } |
171 | 171 | return new CachedCheckResults( |
172 | 172 | $results, |
173 | - Metadata::merge( $metadatas ) |
|
173 | + Metadata::merge($metadatas) |
|
174 | 174 | ); |
175 | 175 | } |
176 | 176 | |
@@ -193,13 +193,13 @@ discard block |
||
193 | 193 | ?array $constraintIds, |
194 | 194 | array $statuses |
195 | 195 | ) { |
196 | - if ( $claimIds !== [] ) { |
|
196 | + if ($claimIds !== []) { |
|
197 | 197 | return false; |
198 | 198 | } |
199 | - if ( $constraintIds !== null ) { |
|
199 | + if ($constraintIds !== null) { |
|
200 | 200 | return false; |
201 | 201 | } |
202 | - if ( array_diff( $statuses, self::CACHED_STATUSES ) !== [] ) { |
|
202 | + if (array_diff($statuses, self::CACHED_STATUSES) !== []) { |
|
203 | 203 | return false; |
204 | 204 | } |
205 | 205 | return true; |
@@ -214,8 +214,8 @@ discard block |
||
214 | 214 | * @param CheckResult $result |
215 | 215 | * @return bool |
216 | 216 | */ |
217 | - private function statusSelected( array $statuses, CheckResult $result ) { |
|
218 | - return in_array( $result->getStatus(), $statuses, true ) || |
|
217 | + private function statusSelected(array $statuses, CheckResult $result) { |
|
218 | + return in_array($result->getStatus(), $statuses, true) || |
|
219 | 219 | $result instanceof NullResult; |
220 | 220 | } |
221 | 221 | |
@@ -232,11 +232,11 @@ discard block |
||
232 | 232 | ?array $constraintIds, |
233 | 233 | array $statuses |
234 | 234 | ) { |
235 | - $results = $this->resultsSource->getResults( $entityIds, $claimIds, $constraintIds, $statuses ); |
|
235 | + $results = $this->resultsSource->getResults($entityIds, $claimIds, $constraintIds, $statuses); |
|
236 | 236 | |
237 | - if ( $this->canStoreResults( $entityIds, $claimIds, $constraintIds, $statuses ) ) { |
|
238 | - foreach ( $entityIds as $entityId ) { |
|
239 | - $this->storeResults( $entityId, $results ); |
|
237 | + if ($this->canStoreResults($entityIds, $claimIds, $constraintIds, $statuses)) { |
|
238 | + foreach ($entityIds as $entityId) { |
|
239 | + $this->storeResults($entityId, $results); |
|
240 | 240 | } |
241 | 241 | } |
242 | 242 | |
@@ -267,10 +267,10 @@ discard block |
||
267 | 267 | ?array $constraintIds, |
268 | 268 | array $statuses |
269 | 269 | ) { |
270 | - if ( $constraintIds !== null ) { |
|
270 | + if ($constraintIds !== null) { |
|
271 | 271 | return false; |
272 | 272 | } |
273 | - if ( array_diff( self::CACHED_STATUSES, $statuses ) !== [] ) { |
|
273 | + if (array_diff(self::CACHED_STATUSES, $statuses) !== []) { |
|
274 | 274 | return false; |
275 | 275 | } |
276 | 276 | return true; |
@@ -284,21 +284,21 @@ discard block |
||
284 | 284 | * May include check results for other entity IDs as well, |
285 | 285 | * or check results with statuses that we’re not interested in caching. |
286 | 286 | */ |
287 | - private function storeResults( EntityId $entityId, CachedCheckResults $results ) { |
|
287 | + private function storeResults(EntityId $entityId, CachedCheckResults $results) { |
|
288 | 288 | $latestRevisionIds = $this->getLatestRevisionIds( |
289 | 289 | $results->getMetadata()->getDependencyMetadata()->getEntityIds() |
290 | 290 | ); |
291 | - if ( $latestRevisionIds === null ) { |
|
291 | + if ($latestRevisionIds === null) { |
|
292 | 292 | return; |
293 | 293 | } |
294 | 294 | |
295 | 295 | $resultSerializations = []; |
296 | - foreach ( $results->getArray() as $checkResult ) { |
|
297 | - if ( $checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization() ) { |
|
296 | + foreach ($results->getArray() as $checkResult) { |
|
297 | + if ($checkResult->getContextCursor()->getEntityId() !== $entityId->getSerialization()) { |
|
298 | 298 | continue; |
299 | 299 | } |
300 | - if ( $this->statusSelected( self::CACHED_STATUSES, $checkResult ) ) { |
|
301 | - $resultSerializations[] = $this->checkResultSerializer->serialize( $checkResult ); |
|
300 | + if ($this->statusSelected(self::CACHED_STATUSES, $checkResult)) { |
|
301 | + $resultSerializations[] = $this->checkResultSerializer->serialize($checkResult); |
|
302 | 302 | } |
303 | 303 | } |
304 | 304 | |
@@ -307,11 +307,11 @@ discard block |
||
307 | 307 | 'latestRevisionIds' => $latestRevisionIds, |
308 | 308 | ]; |
309 | 309 | $futureTime = $results->getMetadata()->getDependencyMetadata()->getFutureTime(); |
310 | - if ( $futureTime !== null ) { |
|
310 | + if ($futureTime !== null) { |
|
311 | 311 | $value['futureTime'] = $futureTime->getArrayValue(); |
312 | 312 | } |
313 | 313 | |
314 | - $this->cache->set( $entityId, $value, $this->ttlInSeconds ); |
|
314 | + $this->cache->set($entityId, $value, $this->ttlInSeconds); |
|
315 | 315 | } |
316 | 316 | |
317 | 317 | /** |
@@ -325,31 +325,30 @@ discard block |
||
325 | 325 | EntityId $entityId, |
326 | 326 | $forRevision = 0 |
327 | 327 | ) { |
328 | - $value = $this->cache->get( $entityId, $curTTL, [], $asOf ); |
|
329 | - $now = call_user_func( $this->microtime, true ); |
|
328 | + $value = $this->cache->get($entityId, $curTTL, [], $asOf); |
|
329 | + $now = call_user_func($this->microtime, true); |
|
330 | 330 | |
331 | - $dependencyMetadata = $this->checkDependencyMetadata( $value, |
|
332 | - [ $entityId->getSerialization() => $forRevision ] ); |
|
333 | - if ( $dependencyMetadata === null ) { |
|
331 | + $dependencyMetadata = $this->checkDependencyMetadata($value, |
|
332 | + [$entityId->getSerialization() => $forRevision]); |
|
333 | + if ($dependencyMetadata === null) { |
|
334 | 334 | return null; |
335 | 335 | } |
336 | 336 | |
337 | - $ageInSeconds = (int)ceil( $now - $asOf ); |
|
337 | + $ageInSeconds = (int) ceil($now - $asOf); |
|
338 | 338 | $cachingMetadata = $ageInSeconds > 0 ? |
339 | - CachingMetadata::ofMaximumAgeInSeconds( $ageInSeconds ) : |
|
340 | - CachingMetadata::fresh(); |
|
339 | + CachingMetadata::ofMaximumAgeInSeconds($ageInSeconds) : CachingMetadata::fresh(); |
|
341 | 340 | |
342 | 341 | $results = []; |
343 | - foreach ( $value['results'] as $resultSerialization ) { |
|
344 | - $results[] = $this->deserializeCheckResult( $resultSerialization, $cachingMetadata ); |
|
342 | + foreach ($value['results'] as $resultSerialization) { |
|
343 | + $results[] = $this->deserializeCheckResult($resultSerialization, $cachingMetadata); |
|
345 | 344 | } |
346 | 345 | |
347 | 346 | return new CachedCheckResults( |
348 | 347 | $results, |
349 | - Metadata::merge( [ |
|
350 | - Metadata::ofCachingMetadata( $cachingMetadata ), |
|
351 | - Metadata::ofDependencyMetadata( $dependencyMetadata ), |
|
352 | - ] ) |
|
348 | + Metadata::merge([ |
|
349 | + Metadata::ofCachingMetadata($cachingMetadata), |
|
350 | + Metadata::ofDependencyMetadata($dependencyMetadata), |
|
351 | + ]) |
|
353 | 352 | ); |
354 | 353 | } |
355 | 354 | |
@@ -365,43 +364,43 @@ discard block |
||
365 | 364 | * @return DependencyMetadata|null the dependency metadata, |
366 | 365 | * or null if $value should no longer be used |
367 | 366 | */ |
368 | - private function checkDependencyMetadata( $value, $paramRevs ) { |
|
369 | - if ( $value === false ) { |
|
367 | + private function checkDependencyMetadata($value, $paramRevs) { |
|
368 | + if ($value === false) { |
|
370 | 369 | return null; |
371 | 370 | } |
372 | 371 | |
373 | - if ( array_key_exists( 'futureTime', $value ) ) { |
|
374 | - $futureTime = TimeValue::newFromArray( $value['futureTime'] ); |
|
375 | - if ( !$this->timeValueComparer->isFutureTime( $futureTime ) ) { |
|
372 | + if (array_key_exists('futureTime', $value)) { |
|
373 | + $futureTime = TimeValue::newFromArray($value['futureTime']); |
|
374 | + if (!$this->timeValueComparer->isFutureTime($futureTime)) { |
|
376 | 375 | return null; |
377 | 376 | } |
378 | - $futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime( $futureTime ); |
|
377 | + $futureTimeDependencyMetadata = DependencyMetadata::ofFutureTime($futureTime); |
|
379 | 378 | } else { |
380 | 379 | $futureTimeDependencyMetadata = DependencyMetadata::blank(); |
381 | 380 | } |
382 | 381 | |
383 | - foreach ( $paramRevs as $id => $revision ) { |
|
384 | - if ( $revision > 0 ) { |
|
385 | - $value['latestRevisionIds'][$id] = min( $revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX ); |
|
382 | + foreach ($paramRevs as $id => $revision) { |
|
383 | + if ($revision > 0) { |
|
384 | + $value['latestRevisionIds'][$id] = min($revision, $value['latestRevisionIds'][$id] ?? PHP_INT_MAX); |
|
386 | 385 | } |
387 | 386 | } |
388 | 387 | |
389 | 388 | $dependedEntityIds = array_map( |
390 | - [ $this->entityIdParser, "parse" ], |
|
391 | - array_keys( $value['latestRevisionIds'] ) |
|
389 | + [$this->entityIdParser, "parse"], |
|
390 | + array_keys($value['latestRevisionIds']) |
|
392 | 391 | ); |
393 | 392 | |
394 | - if ( $value['latestRevisionIds'] !== $this->getLatestRevisionIds( $dependedEntityIds ) ) { |
|
393 | + if ($value['latestRevisionIds'] !== $this->getLatestRevisionIds($dependedEntityIds)) { |
|
395 | 394 | return null; |
396 | 395 | } |
397 | 396 | |
398 | 397 | return array_reduce( |
399 | 398 | $dependedEntityIds, |
400 | - function( DependencyMetadata $metadata, EntityId $entityId ) { |
|
401 | - return DependencyMetadata::merge( [ |
|
399 | + function(DependencyMetadata $metadata, EntityId $entityId) { |
|
400 | + return DependencyMetadata::merge([ |
|
402 | 401 | $metadata, |
403 | - DependencyMetadata::ofEntityId( $entityId ) |
|
404 | - ] ); |
|
402 | + DependencyMetadata::ofEntityId($entityId) |
|
403 | + ]); |
|
405 | 404 | }, |
406 | 405 | $futureTimeDependencyMetadata |
407 | 406 | ); |
@@ -421,13 +420,13 @@ discard block |
||
421 | 420 | array $resultSerialization, |
422 | 421 | CachingMetadata $cachingMetadata |
423 | 422 | ) { |
424 | - $result = $this->checkResultDeserializer->deserialize( $resultSerialization ); |
|
425 | - if ( $this->isPossiblyStaleResult( $result ) ) { |
|
423 | + $result = $this->checkResultDeserializer->deserialize($resultSerialization); |
|
424 | + if ($this->isPossiblyStaleResult($result)) { |
|
426 | 425 | $result->withMetadata( |
427 | - Metadata::merge( [ |
|
426 | + Metadata::merge([ |
|
428 | 427 | $result->getMetadata(), |
429 | - Metadata::ofCachingMetadata( $cachingMetadata ), |
|
430 | - ] ) |
|
428 | + Metadata::ofCachingMetadata($cachingMetadata), |
|
429 | + ]) |
|
431 | 430 | ); |
432 | 431 | } |
433 | 432 | return $result; |
@@ -437,8 +436,8 @@ discard block |
||
437 | 436 | * @param CheckResult $result |
438 | 437 | * @return bool |
439 | 438 | */ |
440 | - private function isPossiblyStaleResult( CheckResult $result ) { |
|
441 | - if ( $result instanceof NullResult ) { |
|
439 | + private function isPossiblyStaleResult(CheckResult $result) { |
|
440 | + if ($result instanceof NullResult) { |
|
442 | 441 | return false; |
443 | 442 | } |
444 | 443 | |
@@ -453,14 +452,14 @@ discard block |
||
453 | 452 | * @return int[]|null array from entity ID serializations to revision ID, |
454 | 453 | * or null to indicate that not all revision IDs could be loaded |
455 | 454 | */ |
456 | - private function getLatestRevisionIds( array $entityIds ) { |
|
457 | - if ( $entityIds === [] ) { |
|
455 | + private function getLatestRevisionIds(array $entityIds) { |
|
456 | + if ($entityIds === []) { |
|
458 | 457 | $this->loggingHelper->logEmptyDependencyMetadata(); |
459 | 458 | return []; |
460 | 459 | } |
461 | - if ( count( $entityIds ) > $this->maxRevisionIds ) { |
|
460 | + if (count($entityIds) > $this->maxRevisionIds) { |
|
462 | 461 | // one of those entities will probably be edited soon, so might as well skip caching |
463 | - $this->loggingHelper->logHugeDependencyMetadata( $entityIds, $this->maxRevisionIds ); |
|
462 | + $this->loggingHelper->logHugeDependencyMetadata($entityIds, $this->maxRevisionIds); |
|
464 | 463 | return null; |
465 | 464 | } |
466 | 465 | |
@@ -468,7 +467,7 @@ discard block |
||
468 | 467 | $entityIds, |
469 | 468 | EntityRevisionLookup::LATEST_FROM_REPLICA |
470 | 469 | ); |
471 | - if ( $this->hasFalseElements( $latestRevisionIds ) ) { |
|
470 | + if ($this->hasFalseElements($latestRevisionIds)) { |
|
472 | 471 | return null; |
473 | 472 | } |
474 | 473 | return $latestRevisionIds; |
@@ -478,8 +477,8 @@ discard block |
||
478 | 477 | * @param array $array |
479 | 478 | * @return bool |
480 | 479 | */ |
481 | - private function hasFalseElements( array $array ) { |
|
482 | - return in_array( false, $array, true ); |
|
480 | + private function hasFalseElements(array $array) { |
|
481 | + return in_array(false, $array, true); |
|
483 | 482 | } |
484 | 483 | |
485 | 484 | /** |
@@ -487,7 +486,7 @@ discard block |
||
487 | 486 | * |
488 | 487 | * @param callable $microtime |
489 | 488 | */ |
490 | - public function setMicrotimeFunction( callable $microtime ) { |
|
489 | + public function setMicrotimeFunction(callable $microtime) { |
|
491 | 490 | $this->microtime = $microtime; |
492 | 491 | } |
493 | 492 |
@@ -44,7 +44,7 @@ discard block |
||
44 | 44 | * @param ItemId $itemId |
45 | 45 | * @return self |
46 | 46 | */ |
47 | - public static function fromItemId( ItemId $itemId ) { |
|
47 | + public static function fromItemId(ItemId $itemId) { |
|
48 | 48 | $ret = new self; |
49 | 49 | $ret->itemId = $itemId; |
50 | 50 | return $ret; |
@@ -80,14 +80,14 @@ discard block |
||
80 | 80 | * @throws InvalidArgumentException |
81 | 81 | * @return self |
82 | 82 | */ |
83 | - public static function fromSnak( Snak $snak ) { |
|
84 | - switch ( true ) { |
|
83 | + public static function fromSnak(Snak $snak) { |
|
84 | + switch (true) { |
|
85 | 85 | case $snak instanceof PropertyValueSnak: |
86 | 86 | $dataValue = $snak->getDataValue(); |
87 | - if ( $dataValue instanceof EntityIdValue ) { |
|
87 | + if ($dataValue instanceof EntityIdValue) { |
|
88 | 88 | $itemId = $dataValue->getEntityId(); |
89 | - if ( $itemId instanceof ItemId ) { |
|
90 | - return self::fromItemId( $itemId ); |
|
89 | + if ($itemId instanceof ItemId) { |
|
90 | + return self::fromItemId($itemId); |
|
91 | 91 | } |
92 | 92 | } |
93 | 93 | break; |
@@ -97,7 +97,7 @@ discard block |
||
97 | 97 | return self::noValue(); |
98 | 98 | } |
99 | 99 | |
100 | - throw new InvalidArgumentException( 'Snak must contain item ID value or be a somevalue / novalue snak' ); |
|
100 | + throw new InvalidArgumentException('Snak must contain item ID value or be a somevalue / novalue snak'); |
|
101 | 101 | } |
102 | 102 | |
103 | 103 | /** |
@@ -135,8 +135,8 @@ discard block |
||
135 | 135 | * @return ItemId |
136 | 136 | */ |
137 | 137 | public function getItemId() { |
138 | - if ( !$this->isValue() ) { |
|
139 | - throw new DomainException( 'This value does not contain an item ID.' ); |
|
138 | + if (!$this->isValue()) { |
|
139 | + throw new DomainException('This value does not contain an item ID.'); |
|
140 | 140 | } |
141 | 141 | return $this->itemId; |
142 | 142 | } |
@@ -148,14 +148,14 @@ discard block |
||
148 | 148 | * @param Snak $snak |
149 | 149 | * @return bool |
150 | 150 | */ |
151 | - public function matchesSnak( Snak $snak ) { |
|
152 | - switch ( true ) { |
|
151 | + public function matchesSnak(Snak $snak) { |
|
152 | + switch (true) { |
|
153 | 153 | case $snak instanceof PropertyValueSnak: |
154 | 154 | $dataValue = $snak->getDataValue(); |
155 | 155 | return $this->isValue() && |
156 | 156 | $dataValue instanceof EntityIdValue && |
157 | 157 | $dataValue->getEntityId() instanceof ItemId && |
158 | - $dataValue->getEntityId()->equals( $this->getItemId() ); |
|
158 | + $dataValue->getEntityId()->equals($this->getItemId()); |
|
159 | 159 | case $snak instanceof PropertySomeValueSnak: |
160 | 160 | return $this->isSomeValue(); |
161 | 161 | case $snak instanceof PropertyNoValueSnak: |
@@ -37,25 +37,25 @@ discard block |
||
37 | 37 | * @param Title $title |
38 | 38 | * @param string[] $params should contain 'entityId' => 'Q1234' |
39 | 39 | */ |
40 | - public function __construct( Title $title, array $params ) { |
|
41 | - parent::__construct( self::COMMAND, $title, $params ); |
|
40 | + public function __construct(Title $title, array $params) { |
|
41 | + parent::__construct(self::COMMAND, $title, $params); |
|
42 | 42 | $this->removeDuplicates = true; |
43 | 43 | |
44 | - Assert::parameterType( 'string', $params['entityId'], '$params[\'entityId\']' ); |
|
44 | + Assert::parameterType('string', $params['entityId'], '$params[\'entityId\']'); |
|
45 | 45 | |
46 | - $resultSource = ConstraintsServices::getResultsSource( MediaWikiServices::getInstance() ); |
|
46 | + $resultSource = ConstraintsServices::getResultsSource(MediaWikiServices::getInstance()); |
|
47 | 47 | '@phan-var CachingResultsSource $resultSource'; |
48 | 48 | // This job should only ever be used when caching result sources are used. |
49 | - $this->setResultsSource( $resultSource ); |
|
49 | + $this->setResultsSource($resultSource); |
|
50 | 50 | |
51 | - $this->setEntityIdParser( WikibaseRepo::getDefaultInstance()->getEntityIdParser() ); |
|
51 | + $this->setEntityIdParser(WikibaseRepo::getDefaultInstance()->getEntityIdParser()); |
|
52 | 52 | } |
53 | 53 | |
54 | - public function setResultsSource( CachingResultsSource $resultsSource ) { |
|
54 | + public function setResultsSource(CachingResultsSource $resultsSource) { |
|
55 | 55 | $this->resultsSource = $resultsSource; |
56 | 56 | } |
57 | 57 | |
58 | - public function setEntityIdParser( EntityIdParser $parser ) { |
|
58 | + public function setEntityIdParser(EntityIdParser $parser) { |
|
59 | 59 | $this->entityIdParser = $parser; |
60 | 60 | } |
61 | 61 | |
@@ -66,19 +66,19 @@ discard block |
||
66 | 66 | */ |
67 | 67 | public function run() { |
68 | 68 | try { |
69 | - $entityId = $this->entityIdParser->parse( $this->params['entityId'] ); |
|
70 | - } catch ( EntityIdParsingException $e ) { |
|
69 | + $entityId = $this->entityIdParser->parse($this->params['entityId']); |
|
70 | + } catch (EntityIdParsingException $e) { |
|
71 | 71 | return false; |
72 | 72 | } |
73 | 73 | |
74 | - $this->checkConstraints( $entityId ); |
|
74 | + $this->checkConstraints($entityId); |
|
75 | 75 | |
76 | 76 | return true; |
77 | 77 | } |
78 | 78 | |
79 | - private function checkConstraints( EntityId $entityId ) { |
|
79 | + private function checkConstraints(EntityId $entityId) { |
|
80 | 80 | $this->resultsSource->getResults( |
81 | - [ $entityId ], |
|
81 | + [$entityId], |
|
82 | 82 | [], |
83 | 83 | null, |
84 | 84 | [] |
@@ -28,8 +28,8 @@ discard block |
||
28 | 28 | |
29 | 29 | const BATCH_SIZE = 10; |
30 | 30 | |
31 | - public static function newFromGlobalState( Title $title, array $params ) { |
|
32 | - Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' ); |
|
31 | + public static function newFromGlobalState(Title $title, array $params) { |
|
32 | + Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]'); |
|
33 | 33 | $repo = WikibaseRepo::getDefaultInstance(); |
34 | 34 | return new UpdateConstraintsTableJob( |
35 | 35 | $title, |
@@ -38,7 +38,7 @@ discard block |
||
38 | 38 | $params['revisionId'] ?? null, |
39 | 39 | MediaWikiServices::getInstance()->getMainConfig(), |
40 | 40 | ConstraintsServices::getConstraintRepository(), |
41 | - $repo->getEntityRevisionLookup( Store::LOOKUP_CACHING_DISABLED ), |
|
41 | + $repo->getEntityRevisionLookup(Store::LOOKUP_CACHING_DISABLED), |
|
42 | 42 | $repo->getBaseDataModelSerializerFactory()->newSnakSerializer() |
43 | 43 | ); |
44 | 44 | } |
@@ -93,7 +93,7 @@ discard block |
||
93 | 93 | EntityRevisionLookup $entityRevisionLookup, |
94 | 94 | Serializer $snakSerializer |
95 | 95 | ) { |
96 | - parent::__construct( 'constraintsTableUpdate', $title, $params ); |
|
96 | + parent::__construct('constraintsTableUpdate', $title, $params); |
|
97 | 97 | |
98 | 98 | $this->propertyId = $propertyId; |
99 | 99 | $this->revisionId = $revisionId; |
@@ -103,11 +103,11 @@ discard block |
||
103 | 103 | $this->snakSerializer = $snakSerializer; |
104 | 104 | } |
105 | 105 | |
106 | - public function extractParametersFromQualifiers( SnakList $qualifiers ) { |
|
106 | + public function extractParametersFromQualifiers(SnakList $qualifiers) { |
|
107 | 107 | $parameters = []; |
108 | - foreach ( $qualifiers as $qualifier ) { |
|
108 | + foreach ($qualifiers as $qualifier) { |
|
109 | 109 | $qualifierId = $qualifier->getPropertyId()->getSerialization(); |
110 | - $paramSerialization = $this->snakSerializer->serialize( $qualifier ); |
|
110 | + $paramSerialization = $this->snakSerializer->serialize($qualifier); |
|
111 | 111 | $parameters[$qualifierId][] = $paramSerialization; |
112 | 112 | } |
113 | 113 | return $parameters; |
@@ -124,7 +124,7 @@ discard block |
||
124 | 124 | '@phan-var \Wikibase\DataModel\Entity\EntityIdValue $dataValue'; |
125 | 125 | $entityId = $dataValue->getEntityId(); |
126 | 126 | $constraintTypeQid = $entityId->getSerialization(); |
127 | - $parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() ); |
|
127 | + $parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers()); |
|
128 | 128 | return new Constraint( |
129 | 129 | $constraintId, |
130 | 130 | $propertyId, |
@@ -139,17 +139,17 @@ discard block |
||
139 | 139 | PropertyId $propertyConstraintPropertyId |
140 | 140 | ) { |
141 | 141 | $constraintsStatements = $property->getStatements() |
142 | - ->getByPropertyId( $propertyConstraintPropertyId ) |
|
143 | - ->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] ); |
|
142 | + ->getByPropertyId($propertyConstraintPropertyId) |
|
143 | + ->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]); |
|
144 | 144 | $constraints = []; |
145 | - foreach ( $constraintsStatements->getIterator() as $constraintStatement ) { |
|
146 | - $constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement ); |
|
147 | - if ( count( $constraints ) >= self::BATCH_SIZE ) { |
|
148 | - $constraintRepo->insertBatch( $constraints ); |
|
145 | + foreach ($constraintsStatements->getIterator() as $constraintStatement) { |
|
146 | + $constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement); |
|
147 | + if (count($constraints) >= self::BATCH_SIZE) { |
|
148 | + $constraintRepo->insertBatch($constraints); |
|
149 | 149 | $constraints = []; |
150 | 150 | } |
151 | 151 | } |
152 | - $constraintRepo->insertBatch( $constraints ); |
|
152 | + $constraintRepo->insertBatch($constraints); |
|
153 | 153 | } |
154 | 154 | |
155 | 155 | /** |
@@ -160,19 +160,19 @@ discard block |
||
160 | 160 | public function run() { |
161 | 161 | // TODO in the future: only touch constraints affected by the edit (requires T163465) |
162 | 162 | |
163 | - $propertyId = new PropertyId( $this->propertyId ); |
|
163 | + $propertyId = new PropertyId($this->propertyId); |
|
164 | 164 | $propertyRevision = $this->entityRevisionLookup->getEntityRevision( |
165 | 165 | $propertyId, |
166 | 166 | 0, // latest |
167 | 167 | EntityRevisionLookup::LATEST_FROM_REPLICA |
168 | 168 | ); |
169 | 169 | |
170 | - if ( $this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId ) { |
|
171 | - JobQueueGroup::singleton()->push( $this ); |
|
170 | + if ($this->revisionId !== null && $propertyRevision->getRevisionId() < $this->revisionId) { |
|
171 | + JobQueueGroup::singleton()->push($this); |
|
172 | 172 | return true; |
173 | 173 | } |
174 | 174 | |
175 | - $this->constraintRepo->deleteForProperty( $propertyId ); |
|
175 | + $this->constraintRepo->deleteForProperty($propertyId); |
|
176 | 176 | |
177 | 177 | /** @var Property $property */ |
178 | 178 | $property = $propertyRevision->getEntity(); |
@@ -180,7 +180,7 @@ discard block |
||
180 | 180 | $this->importConstraintsForProperty( |
181 | 181 | $property, |
182 | 182 | $this->constraintRepo, |
183 | - new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ) |
|
183 | + new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')) |
|
184 | 184 | ); |
185 | 185 | |
186 | 186 | return true; |
@@ -21,7 +21,7 @@ discard block |
||
21 | 21 | /** @var string|false */ |
22 | 22 | private $dbName; |
23 | 23 | |
24 | - public function __construct( ILoadBalancer $lb, $dbName ) { |
|
24 | + public function __construct(ILoadBalancer $lb, $dbName) { |
|
25 | 25 | $this->lb = $lb; |
26 | 26 | $this->dbName = $dbName; |
27 | 27 | } |
@@ -31,27 +31,27 @@ discard block |
||
31 | 31 | * |
32 | 32 | * @return Constraint[] |
33 | 33 | */ |
34 | - public function queryConstraintsForProperty( PropertyId $propertyId ) { |
|
35 | - $dbr = $this->lb->getConnection( ILoadBalancer::DB_REPLICA, [], $this->dbName ); |
|
34 | + public function queryConstraintsForProperty(PropertyId $propertyId) { |
|
35 | + $dbr = $this->lb->getConnection(ILoadBalancer::DB_REPLICA, [], $this->dbName); |
|
36 | 36 | |
37 | 37 | $results = $dbr->select( |
38 | 38 | 'wbqc_constraints', |
39 | 39 | '*', |
40 | - [ 'pid' => $propertyId->getNumericId() ] |
|
40 | + ['pid' => $propertyId->getNumericId()] |
|
41 | 41 | ); |
42 | 42 | |
43 | - if ( $this->dbName !== false ) { |
|
44 | - $this->lb->reuseConnection( $dbr ); |
|
43 | + if ($this->dbName !== false) { |
|
44 | + $this->lb->reuseConnection($dbr); |
|
45 | 45 | } |
46 | 46 | |
47 | - return $this->convertToConstraints( $results ); |
|
47 | + return $this->convertToConstraints($results); |
|
48 | 48 | } |
49 | 49 | |
50 | - private function encodeConstraintParameters( array $constraintParameters ) { |
|
51 | - $json = json_encode( $constraintParameters, JSON_FORCE_OBJECT ); |
|
50 | + private function encodeConstraintParameters(array $constraintParameters) { |
|
51 | + $json = json_encode($constraintParameters, JSON_FORCE_OBJECT); |
|
52 | 52 | |
53 | - if ( strlen( $json ) > 50000 ) { |
|
54 | - $json = json_encode( [ '@error' => [ 'toolong' => true ] ] ); |
|
53 | + if (strlen($json) > 50000) { |
|
54 | + $json = json_encode(['@error' => ['toolong' => true]]); |
|
55 | 55 | } |
56 | 56 | |
57 | 57 | return $json; |
@@ -63,25 +63,25 @@ discard block |
||
63 | 63 | * @throws DBUnexpectedError |
64 | 64 | * @return bool |
65 | 65 | */ |
66 | - public function insertBatch( array $constraints ) { |
|
67 | - if ( $this->dbName !== false ) { |
|
68 | - throw new LogicException( __METHOD__ . ' should not be called when constraints defined in non-local database.' ); |
|
66 | + public function insertBatch(array $constraints) { |
|
67 | + if ($this->dbName !== false) { |
|
68 | + throw new LogicException(__METHOD__.' should not be called when constraints defined in non-local database.'); |
|
69 | 69 | } |
70 | 70 | |
71 | 71 | $accumulator = array_map( |
72 | - function ( Constraint $constraint ) { |
|
72 | + function(Constraint $constraint) { |
|
73 | 73 | return [ |
74 | 74 | 'constraint_guid' => $constraint->getConstraintId(), |
75 | 75 | 'pid' => $constraint->getPropertyId()->getNumericId(), |
76 | 76 | 'constraint_type_qid' => $constraint->getConstraintTypeItemId(), |
77 | - 'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() ) |
|
77 | + 'constraint_parameters' => $this->encodeConstraintParameters($constraint->getConstraintParameters()) |
|
78 | 78 | ]; |
79 | 79 | }, |
80 | 80 | $constraints |
81 | 81 | ); |
82 | 82 | |
83 | - $dbw = $this->lb->getConnection( ILoadBalancer::DB_MASTER ); |
|
84 | - return $dbw->insert( 'wbqc_constraints', $accumulator ); |
|
83 | + $dbw = $this->lb->getConnection(ILoadBalancer::DB_MASTER); |
|
84 | + return $dbw->insert('wbqc_constraints', $accumulator); |
|
85 | 85 | } |
86 | 86 | |
87 | 87 | /** |
@@ -91,12 +91,12 @@ discard block |
||
91 | 91 | * |
92 | 92 | * @throws DBUnexpectedError |
93 | 93 | */ |
94 | - public function deleteForProperty( PropertyId $propertyId ) { |
|
95 | - if ( $this->dbName !== false ) { |
|
96 | - throw new LogicException( __METHOD__ . ' should not be called when constraints defined in non-local database.' ); |
|
94 | + public function deleteForProperty(PropertyId $propertyId) { |
|
95 | + if ($this->dbName !== false) { |
|
96 | + throw new LogicException(__METHOD__.' should not be called when constraints defined in non-local database.'); |
|
97 | 97 | } |
98 | 98 | |
99 | - $dbw = $this->lb->getConnection( ILoadBalancer::DB_MASTER ); |
|
99 | + $dbw = $this->lb->getConnection(ILoadBalancer::DB_MASTER); |
|
100 | 100 | $dbw->delete( |
101 | 101 | 'wbqc_constraints', |
102 | 102 | [ |
@@ -110,26 +110,26 @@ discard block |
||
110 | 110 | * |
111 | 111 | * @return Constraint[] |
112 | 112 | */ |
113 | - private function convertToConstraints( IResultWrapper $results ) { |
|
113 | + private function convertToConstraints(IResultWrapper $results) { |
|
114 | 114 | $constraints = []; |
115 | - foreach ( $results as $result ) { |
|
115 | + foreach ($results as $result) { |
|
116 | 116 | $constraintTypeItemId = $result->constraint_type_qid; |
117 | - $constraintParameters = json_decode( $result->constraint_parameters, true ); |
|
117 | + $constraintParameters = json_decode($result->constraint_parameters, true); |
|
118 | 118 | |
119 | - if ( $constraintParameters === null ) { |
|
119 | + if ($constraintParameters === null) { |
|
120 | 120 | // T171295 |
121 | - LoggerFactory::getInstance( 'WikibaseQualityConstraints' ) |
|
122 | - ->warning( 'Constraint {constraintId} has invalid constraint parameters.', [ |
|
121 | + LoggerFactory::getInstance('WikibaseQualityConstraints') |
|
122 | + ->warning('Constraint {constraintId} has invalid constraint parameters.', [ |
|
123 | 123 | 'method' => __METHOD__, |
124 | 124 | 'constraintId' => $result->constraint_guid, |
125 | 125 | 'constraintParameters' => $result->constraint_parameters, |
126 | - ] ); |
|
127 | - $constraintParameters = [ '@error' => [ /* unknown */ ] ]; |
|
126 | + ]); |
|
127 | + $constraintParameters = ['@error' => [/* unknown */]]; |
|
128 | 128 | } |
129 | 129 | |
130 | 130 | $constraints[] = new Constraint( |
131 | 131 | $result->constraint_guid, |
132 | - PropertyId::newFromNumber( $result->pid ), |
|
132 | + PropertyId::newFromNumber($result->pid), |
|
133 | 133 | $constraintTypeItemId, |
134 | 134 | $constraintParameters |
135 | 135 | ); |
@@ -75,17 +75,17 @@ discard block |
||
75 | 75 | DelegatingConstraintChecker $delegatingConstraintChecker |
76 | 76 | ): self { |
77 | 77 | $repo = WikibaseRepo::getDefaultInstance(); |
78 | - $helperFactory = $repo->getApiHelperFactory( RequestContext::getMain() ); |
|
78 | + $helperFactory = $repo->getApiHelperFactory(RequestContext::getMain()); |
|
79 | 79 | $language = $repo->getUserLanguage(); |
80 | 80 | |
81 | 81 | $entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory(); |
82 | 82 | $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory |
83 | - ->getEntityIdFormatter( $language ); |
|
83 | + ->getEntityIdFormatter($language); |
|
84 | 84 | $formatterOptions = new FormatterOptions(); |
85 | - $formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() ); |
|
85 | + $formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode()); |
|
86 | 86 | $valueFormatterFactory = $repo->getValueFormatterFactory(); |
87 | 87 | $dataValueFormatter = $valueFormatterFactory |
88 | - ->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ); |
|
88 | + ->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions); |
|
89 | 89 | $violationMessageRenderer = new MultilingualTextViolationMessageRenderer( |
90 | 90 | $entityIdHtmlLinkFormatter, |
91 | 91 | $dataValueFormatter, |
@@ -121,9 +121,9 @@ discard block |
||
121 | 121 | StatementGuidParser $statementGuidParser, |
122 | 122 | IBufferingStatsdDataFactory $dataFactory |
123 | 123 | ) { |
124 | - parent::__construct( $main, $name ); |
|
124 | + parent::__construct($main, $name); |
|
125 | 125 | |
126 | - $this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
126 | + $this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this); |
|
127 | 127 | $this->delegatingConstraintChecker = $delegatingConstraintChecker; |
128 | 128 | $this->violationMessageRenderer = $violationMessageRenderer; |
129 | 129 | $this->statementGuidParser = $statementGuidParser; |
@@ -138,39 +138,39 @@ discard block |
||
138 | 138 | $params = $this->extractRequestParams(); |
139 | 139 | $result = $this->getResult(); |
140 | 140 | |
141 | - $propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] ); |
|
142 | - $constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] ); |
|
141 | + $propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]); |
|
142 | + $constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]); |
|
143 | 143 | |
144 | - $this->checkPropertyIds( $propertyIds, $result ); |
|
145 | - $this->checkConstraintIds( $constraintIds, $result ); |
|
144 | + $this->checkPropertyIds($propertyIds, $result); |
|
145 | + $this->checkConstraintIds($constraintIds, $result); |
|
146 | 146 | |
147 | - $result->addValue( null, 'success', 1 ); |
|
147 | + $result->addValue(null, 'success', 1); |
|
148 | 148 | } |
149 | 149 | |
150 | 150 | /** |
151 | 151 | * @param array|null $propertyIdSerializations |
152 | 152 | * @return PropertyId[] |
153 | 153 | */ |
154 | - private function parsePropertyIds( $propertyIdSerializations ) { |
|
155 | - if ( $propertyIdSerializations === null ) { |
|
154 | + private function parsePropertyIds($propertyIdSerializations) { |
|
155 | + if ($propertyIdSerializations === null) { |
|
156 | 156 | return []; |
157 | - } elseif ( empty( $propertyIdSerializations ) ) { |
|
157 | + } elseif (empty($propertyIdSerializations)) { |
|
158 | 158 | $this->apiErrorReporter->dieError( |
159 | - 'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.', |
|
159 | + 'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.', |
|
160 | 160 | 'no-data' |
161 | 161 | ); |
162 | 162 | } |
163 | 163 | |
164 | 164 | return array_map( |
165 | - function( $propertyIdSerialization ) { |
|
165 | + function($propertyIdSerialization) { |
|
166 | 166 | try { |
167 | - return new PropertyId( $propertyIdSerialization ); |
|
168 | - } catch ( InvalidArgumentException $e ) { |
|
167 | + return new PropertyId($propertyIdSerialization); |
|
168 | + } catch (InvalidArgumentException $e) { |
|
169 | 169 | $this->apiErrorReporter->dieError( |
170 | 170 | "Invalid id: $propertyIdSerialization", |
171 | 171 | 'invalid-property-id', |
172 | 172 | 0, // default argument |
173 | - [ self::PARAM_PROPERTY_ID => $propertyIdSerialization ] |
|
173 | + [self::PARAM_PROPERTY_ID => $propertyIdSerialization] |
|
174 | 174 | ); |
175 | 175 | } |
176 | 176 | }, |
@@ -182,35 +182,35 @@ discard block |
||
182 | 182 | * @param array|null $constraintIds |
183 | 183 | * @return string[] |
184 | 184 | */ |
185 | - private function parseConstraintIds( $constraintIds ) { |
|
186 | - if ( $constraintIds === null ) { |
|
185 | + private function parseConstraintIds($constraintIds) { |
|
186 | + if ($constraintIds === null) { |
|
187 | 187 | return []; |
188 | - } elseif ( empty( $constraintIds ) ) { |
|
188 | + } elseif (empty($constraintIds)) { |
|
189 | 189 | $this->apiErrorReporter->dieError( |
190 | - 'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.', |
|
190 | + 'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.', |
|
191 | 191 | 'no-data' |
192 | 192 | ); |
193 | 193 | } |
194 | 194 | |
195 | 195 | return array_map( |
196 | - function( $constraintId ) { |
|
196 | + function($constraintId) { |
|
197 | 197 | try { |
198 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
199 | - if ( !$propertyId instanceof PropertyId ) { |
|
198 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
199 | + if (!$propertyId instanceof PropertyId) { |
|
200 | 200 | $this->apiErrorReporter->dieError( |
201 | 201 | "Invalid property ID: {$propertyId->getSerialization()}", |
202 | 202 | 'invalid-property-id', |
203 | 203 | 0, // default argument |
204 | - [ self::PARAM_CONSTRAINT_ID => $constraintId ] |
|
204 | + [self::PARAM_CONSTRAINT_ID => $constraintId] |
|
205 | 205 | ); |
206 | 206 | } |
207 | 207 | return $constraintId; |
208 | - } catch ( StatementGuidParsingException $e ) { |
|
208 | + } catch (StatementGuidParsingException $e) { |
|
209 | 209 | $this->apiErrorReporter->dieError( |
210 | 210 | "Invalid statement GUID: $constraintId", |
211 | 211 | 'invalid-guid', |
212 | 212 | 0, // default argument |
213 | - [ self::PARAM_CONSTRAINT_ID => $constraintId ] |
|
213 | + [self::PARAM_CONSTRAINT_ID => $constraintId] |
|
214 | 214 | ); |
215 | 215 | } |
216 | 216 | }, |
@@ -222,12 +222,12 @@ discard block |
||
222 | 222 | * @param PropertyId[] $propertyIds |
223 | 223 | * @param ApiResult $result |
224 | 224 | */ |
225 | - private function checkPropertyIds( array $propertyIds, ApiResult $result ) { |
|
226 | - foreach ( $propertyIds as $propertyId ) { |
|
227 | - $result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' ); |
|
225 | + private function checkPropertyIds(array $propertyIds, ApiResult $result) { |
|
226 | + foreach ($propertyIds as $propertyId) { |
|
227 | + $result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc'); |
|
228 | 228 | $allConstraintExceptions = $this->delegatingConstraintChecker |
229 | - ->checkConstraintParametersOnPropertyId( $propertyId ); |
|
230 | - foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) { |
|
229 | + ->checkConstraintParametersOnPropertyId($propertyId); |
|
230 | + foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) { |
|
231 | 231 | $this->addConstraintParameterExceptionsToResult( |
232 | 232 | $constraintId, |
233 | 233 | $constraintParameterExceptions, |
@@ -241,15 +241,15 @@ discard block |
||
241 | 241 | * @param string[] $constraintIds |
242 | 242 | * @param ApiResult $result |
243 | 243 | */ |
244 | - private function checkConstraintIds( array $constraintIds, ApiResult $result ) { |
|
245 | - foreach ( $constraintIds as $constraintId ) { |
|
246 | - if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) { |
|
244 | + private function checkConstraintIds(array $constraintIds, ApiResult $result) { |
|
245 | + foreach ($constraintIds as $constraintId) { |
|
246 | + if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) { |
|
247 | 247 | // already checked as part of checkPropertyIds() |
248 | 248 | continue; |
249 | 249 | } |
250 | 250 | $constraintParameterExceptions = $this->delegatingConstraintChecker |
251 | - ->checkConstraintParametersOnConstraintId( $constraintId ); |
|
252 | - $this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result ); |
|
251 | + ->checkConstraintParametersOnConstraintId($constraintId); |
|
252 | + $this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result); |
|
253 | 253 | } |
254 | 254 | } |
255 | 255 | |
@@ -257,18 +257,18 @@ discard block |
||
257 | 257 | * @param PropertyId $propertyId |
258 | 258 | * @return string[] |
259 | 259 | */ |
260 | - private function getResultPathForPropertyId( PropertyId $propertyId ) { |
|
261 | - return [ $this->getModuleName(), $propertyId->getSerialization() ]; |
|
260 | + private function getResultPathForPropertyId(PropertyId $propertyId) { |
|
261 | + return [$this->getModuleName(), $propertyId->getSerialization()]; |
|
262 | 262 | } |
263 | 263 | |
264 | 264 | /** |
265 | 265 | * @param string $constraintId |
266 | 266 | * @return string[] |
267 | 267 | */ |
268 | - private function getResultPathForConstraintId( $constraintId ) { |
|
269 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
268 | + private function getResultPathForConstraintId($constraintId) { |
|
269 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
270 | 270 | '@phan-var PropertyId $propertyId'; |
271 | - return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] ); |
|
271 | + return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]); |
|
272 | 272 | } |
273 | 273 | |
274 | 274 | /** |
@@ -283,8 +283,8 @@ discard block |
||
283 | 283 | $constraintParameterExceptions, |
284 | 284 | ApiResult $result |
285 | 285 | ) { |
286 | - $path = $this->getResultPathForConstraintId( $constraintId ); |
|
287 | - if ( $constraintParameterExceptions === null ) { |
|
286 | + $path = $this->getResultPathForConstraintId($constraintId); |
|
287 | + if ($constraintParameterExceptions === null) { |
|
288 | 288 | $result->addValue( |
289 | 289 | $path, |
290 | 290 | self::KEY_STATUS, |
@@ -294,12 +294,12 @@ discard block |
||
294 | 294 | $result->addValue( |
295 | 295 | $path, |
296 | 296 | self::KEY_STATUS, |
297 | - empty( $constraintParameterExceptions ) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY |
|
297 | + empty($constraintParameterExceptions) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY |
|
298 | 298 | ); |
299 | 299 | $result->addValue( |
300 | 300 | $path, |
301 | 301 | self::KEY_PROBLEMS, |
302 | - array_map( [ $this, 'formatConstraintParameterException' ], $constraintParameterExceptions ) |
|
302 | + array_map([$this, 'formatConstraintParameterException'], $constraintParameterExceptions) |
|
303 | 303 | ); |
304 | 304 | } |
305 | 305 | } |
@@ -310,7 +310,7 @@ discard block |
||
310 | 310 | * @param ConstraintParameterException $e |
311 | 311 | * @return string[] |
312 | 312 | */ |
313 | - private function formatConstraintParameterException( ConstraintParameterException $e ) { |
|
313 | + private function formatConstraintParameterException(ConstraintParameterException $e) { |
|
314 | 314 | return [ |
315 | 315 | self::KEY_MESSAGE_HTML => $this->violationMessageRenderer->render( |
316 | 316 | $e->getViolationMessage() |
@@ -343,8 +343,8 @@ discard block |
||
343 | 343 | return [ |
344 | 344 | 'action=wbcheckconstraintparameters&propertyid=P247' |
345 | 345 | => 'apihelp-wbcheckconstraintparameters-example-propertyid-1', |
346 | - 'action=wbcheckconstraintparameters&' . |
|
347 | - 'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|' . |
|
346 | + 'action=wbcheckconstraintparameters&'. |
|
347 | + 'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|'. |
|
348 | 348 | 'P225$cdc71e4a-47a0-12c5-dfb3-3f6fc0b6613f' |
349 | 349 | => 'apihelp-wbcheckconstraintparameters-example-constraintid-2', |
350 | 350 | ]; |
@@ -83,14 +83,14 @@ discard block |
||
83 | 83 | |
84 | 84 | $language = $repo->getUserLanguage(); |
85 | 85 | $formatterOptions = new FormatterOptions(); |
86 | - $formatterOptions->setOption( SnakFormatter::OPT_LANG, $language->getCode() ); |
|
86 | + $formatterOptions->setOption(SnakFormatter::OPT_LANG, $language->getCode()); |
|
87 | 87 | $valueFormatterFactory = $repo->getValueFormatterFactory(); |
88 | - $valueFormatter = $valueFormatterFactory->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ); |
|
88 | + $valueFormatter = $valueFormatterFactory->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions); |
|
89 | 89 | |
90 | 90 | $entityIdHtmlLinkFormatterFactory = $repo->getEntityIdHtmlLinkFormatterFactory(); |
91 | - $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( $language ); |
|
91 | + $entityIdHtmlLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter($language); |
|
92 | 92 | $entityIdLabelFormatterFactory = new EntityIdLabelFormatterFactory(); |
93 | - $entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter( $language ); |
|
93 | + $entityIdLabelFormatter = $entityIdLabelFormatterFactory->getEntityIdFormatter($language); |
|
94 | 94 | |
95 | 95 | $checkResultsRenderer = new CheckResultsRenderer( |
96 | 96 | $repo->getEntityTitleLookup(), |
@@ -108,7 +108,7 @@ discard block |
||
108 | 108 | $name, |
109 | 109 | $repo->getEntityIdParser(), |
110 | 110 | $repo->getStatementGuidValidator(), |
111 | - $repo->getApiHelperFactory( RequestContext::getMain() ), |
|
111 | + $repo->getApiHelperFactory(RequestContext::getMain()), |
|
112 | 112 | $resultsSource, |
113 | 113 | $checkResultsRenderer, |
114 | 114 | $dataFactory |
@@ -135,11 +135,11 @@ discard block |
||
135 | 135 | CheckResultsRenderer $checkResultsRenderer, |
136 | 136 | IBufferingStatsdDataFactory $dataFactory |
137 | 137 | ) { |
138 | - parent::__construct( $main, $name ); |
|
138 | + parent::__construct($main, $name); |
|
139 | 139 | $this->entityIdParser = $entityIdParser; |
140 | 140 | $this->statementGuidValidator = $statementGuidValidator; |
141 | - $this->resultBuilder = $apiHelperFactory->getResultBuilder( $this ); |
|
142 | - $this->errorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
141 | + $this->resultBuilder = $apiHelperFactory->getResultBuilder($this); |
|
142 | + $this->errorReporter = $apiHelperFactory->getErrorReporter($this); |
|
143 | 143 | $this->resultsSource = $resultsSource; |
144 | 144 | $this->checkResultsRenderer = $checkResultsRenderer; |
145 | 145 | $this->dataFactory = $dataFactory; |
@@ -155,9 +155,9 @@ discard block |
||
155 | 155 | |
156 | 156 | $params = $this->extractRequestParams(); |
157 | 157 | |
158 | - $this->validateParameters( $params ); |
|
159 | - $entityIds = $this->parseEntityIds( $params ); |
|
160 | - $claimIds = $this->parseClaimIds( $params ); |
|
158 | + $this->validateParameters($params); |
|
159 | + $entityIds = $this->parseEntityIds($params); |
|
160 | + $claimIds = $this->parseClaimIds($params); |
|
161 | 161 | $constraintIDs = $params[self::PARAM_CONSTRAINT_ID]; |
162 | 162 | $statuses = $params[self::PARAM_STATUS]; |
163 | 163 | |
@@ -173,7 +173,7 @@ discard block |
||
173 | 173 | ) |
174 | 174 | )->getArray() |
175 | 175 | ); |
176 | - $this->resultBuilder->markSuccess( 1 ); |
|
176 | + $this->resultBuilder->markSuccess(1); |
|
177 | 177 | } |
178 | 178 | |
179 | 179 | /** |
@@ -181,24 +181,24 @@ discard block |
||
181 | 181 | * |
182 | 182 | * @return EntityId[] |
183 | 183 | */ |
184 | - private function parseEntityIds( array $params ) { |
|
184 | + private function parseEntityIds(array $params) { |
|
185 | 185 | $ids = $params[self::PARAM_ID]; |
186 | 186 | |
187 | - if ( $ids === null ) { |
|
187 | + if ($ids === null) { |
|
188 | 188 | return []; |
189 | - } elseif ( $ids === [] ) { |
|
189 | + } elseif ($ids === []) { |
|
190 | 190 | $this->errorReporter->dieError( |
191 | - 'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
191 | + 'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
192 | 192 | } |
193 | 193 | |
194 | - return array_map( function ( $id ) { |
|
194 | + return array_map(function($id) { |
|
195 | 195 | try { |
196 | - return $this->entityIdParser->parse( $id ); |
|
197 | - } catch ( EntityIdParsingException $e ) { |
|
196 | + return $this->entityIdParser->parse($id); |
|
197 | + } catch (EntityIdParsingException $e) { |
|
198 | 198 | $this->errorReporter->dieError( |
199 | - "Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] ); |
|
199 | + "Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] ); |
|
200 | 200 | } |
201 | - }, $ids ); |
|
201 | + }, $ids); |
|
202 | 202 | } |
203 | 203 | |
204 | 204 | /** |
@@ -206,36 +206,36 @@ discard block |
||
206 | 206 | * |
207 | 207 | * @return string[] |
208 | 208 | */ |
209 | - private function parseClaimIds( array $params ) { |
|
209 | + private function parseClaimIds(array $params) { |
|
210 | 210 | $ids = $params[self::PARAM_CLAIM_ID]; |
211 | 211 | |
212 | - if ( $ids === null ) { |
|
212 | + if ($ids === null) { |
|
213 | 213 | return []; |
214 | - } elseif ( $ids === [] ) { |
|
214 | + } elseif ($ids === []) { |
|
215 | 215 | $this->errorReporter->dieError( |
216 | - 'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
216 | + 'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
217 | 217 | } |
218 | 218 | |
219 | - foreach ( $ids as $id ) { |
|
220 | - if ( !$this->statementGuidValidator->validate( $id ) ) { |
|
219 | + foreach ($ids as $id) { |
|
220 | + if (!$this->statementGuidValidator->validate($id)) { |
|
221 | 221 | $this->errorReporter->dieError( |
222 | - "Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] ); |
|
222 | + "Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] ); |
|
223 | 223 | } |
224 | 224 | } |
225 | 225 | |
226 | 226 | return $ids; |
227 | 227 | } |
228 | 228 | |
229 | - private function validateParameters( array $params ) { |
|
230 | - if ( $params[self::PARAM_CONSTRAINT_ID] !== null |
|
231 | - && empty( $params[self::PARAM_CONSTRAINT_ID] ) |
|
229 | + private function validateParameters(array $params) { |
|
230 | + if ($params[self::PARAM_CONSTRAINT_ID] !== null |
|
231 | + && empty($params[self::PARAM_CONSTRAINT_ID]) |
|
232 | 232 | ) { |
233 | 233 | $paramConstraintId = self::PARAM_CONSTRAINT_ID; |
234 | 234 | $this->errorReporter->dieError( |
235 | 235 | "If $paramConstraintId is specified, it must be nonempty.", 'no-data' ); |
236 | 236 | } |
237 | 237 | // @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset |
238 | - if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) { |
|
238 | + if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) { |
|
239 | 239 | $paramId = self::PARAM_ID; |
240 | 240 | $paramClaimId = self::PARAM_CLAIM_ID; |
241 | 241 | $this->errorReporter->dieError( |
@@ -276,7 +276,7 @@ discard block |
||
276 | 276 | ], |
277 | 277 | ApiBase::PARAM_ISMULTI => true, |
278 | 278 | ApiBase::PARAM_ALL => true, |
279 | - ApiBase::PARAM_DFLT => implode( '|', CachingResultsSource::CACHED_STATUSES ), |
|
279 | + ApiBase::PARAM_DFLT => implode('|', CachingResultsSource::CACHED_STATUSES), |
|
280 | 280 | ApiBase::PARAM_HELP_MSG_PER_VALUE => [], |
281 | 281 | ], |
282 | 282 | ]; |
@@ -77,15 +77,15 @@ discard block |
||
77 | 77 | * @param array $parameters |
78 | 78 | * @throws ConstraintParameterException |
79 | 79 | */ |
80 | - public function checkError( array $parameters ) { |
|
81 | - if ( array_key_exists( '@error', $parameters ) ) { |
|
80 | + public function checkError(array $parameters) { |
|
81 | + if (array_key_exists('@error', $parameters)) { |
|
82 | 82 | $error = $parameters['@error']; |
83 | - if ( array_key_exists( 'toolong', $error ) && $error['toolong'] ) { |
|
83 | + if (array_key_exists('toolong', $error) && $error['toolong']) { |
|
84 | 84 | $msg = 'wbqc-violation-message-parameters-error-toolong'; |
85 | 85 | } else { |
86 | 86 | $msg = 'wbqc-violation-message-parameters-error-unknown'; |
87 | 87 | } |
88 | - throw new ConstraintParameterException( new ViolationMessage( $msg ) ); |
|
88 | + throw new ConstraintParameterException(new ViolationMessage($msg)); |
|
89 | 89 | } |
90 | 90 | } |
91 | 91 | |
@@ -95,11 +95,11 @@ discard block |
||
95 | 95 | * @param string $parameterId |
96 | 96 | * @throws ConstraintParameterException |
97 | 97 | */ |
98 | - private function requireSingleParameter( array $parameters, $parameterId ) { |
|
99 | - if ( count( $parameters[$parameterId] ) !== 1 ) { |
|
98 | + private function requireSingleParameter(array $parameters, $parameterId) { |
|
99 | + if (count($parameters[$parameterId]) !== 1) { |
|
100 | 100 | throw new ConstraintParameterException( |
101 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-single' ) ) |
|
102 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
101 | + (new ViolationMessage('wbqc-violation-message-parameter-single')) |
|
102 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
103 | 103 | ); |
104 | 104 | } |
105 | 105 | } |
@@ -111,11 +111,11 @@ discard block |
||
111 | 111 | * @return void |
112 | 112 | * @throws ConstraintParameterException |
113 | 113 | */ |
114 | - private function requireValueParameter( Snak $snak, $parameterId ) { |
|
115 | - if ( !( $snak instanceof PropertyValueSnak ) ) { |
|
114 | + private function requireValueParameter(Snak $snak, $parameterId) { |
|
115 | + if (!($snak instanceof PropertyValueSnak)) { |
|
116 | 116 | throw new ConstraintParameterException( |
117 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
118 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
117 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
118 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
119 | 119 | ); |
120 | 120 | } |
121 | 121 | } |
@@ -127,17 +127,17 @@ discard block |
||
127 | 127 | * @throws ConstraintParameterException |
128 | 128 | * @return EntityId |
129 | 129 | */ |
130 | - private function parseEntityIdParameter( array $snakSerialization, $parameterId ) { |
|
131 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
132 | - $this->requireValueParameter( $snak, $parameterId ); |
|
130 | + private function parseEntityIdParameter(array $snakSerialization, $parameterId) { |
|
131 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
132 | + $this->requireValueParameter($snak, $parameterId); |
|
133 | 133 | $value = $snak->getDataValue(); |
134 | - if ( $value instanceof EntityIdValue ) { |
|
134 | + if ($value instanceof EntityIdValue) { |
|
135 | 135 | return $value->getEntityId(); |
136 | 136 | } else { |
137 | 137 | throw new ConstraintParameterException( |
138 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-entity' ) ) |
|
139 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
140 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
138 | + (new ViolationMessage('wbqc-violation-message-parameter-entity')) |
|
139 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
140 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
141 | 141 | ); |
142 | 142 | } |
143 | 143 | } |
@@ -148,20 +148,20 @@ discard block |
||
148 | 148 | * @throws ConstraintParameterException if the parameter is invalid or missing |
149 | 149 | * @return string[] class entity ID serializations |
150 | 150 | */ |
151 | - public function parseClassParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
152 | - $this->checkError( $constraintParameters ); |
|
153 | - $classId = $this->config->get( 'WBQualityConstraintsClassId' ); |
|
154 | - if ( !array_key_exists( $classId, $constraintParameters ) ) { |
|
151 | + public function parseClassParameter(array $constraintParameters, $constraintTypeItemId) { |
|
152 | + $this->checkError($constraintParameters); |
|
153 | + $classId = $this->config->get('WBQualityConstraintsClassId'); |
|
154 | + if (!array_key_exists($classId, $constraintParameters)) { |
|
155 | 155 | throw new ConstraintParameterException( |
156 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
157 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
158 | - ->withEntityId( new PropertyId( $classId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
156 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
157 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
158 | + ->withEntityId(new PropertyId($classId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
159 | 159 | ); |
160 | 160 | } |
161 | 161 | |
162 | 162 | $classes = []; |
163 | - foreach ( $constraintParameters[$classId] as $class ) { |
|
164 | - $classes[] = $this->parseEntityIdParameter( $class, $classId )->getSerialization(); |
|
163 | + foreach ($constraintParameters[$classId] as $class) { |
|
164 | + $classes[] = $this->parseEntityIdParameter($class, $classId)->getSerialization(); |
|
165 | 165 | } |
166 | 166 | return $classes; |
167 | 167 | } |
@@ -172,23 +172,23 @@ discard block |
||
172 | 172 | * @throws ConstraintParameterException if the parameter is invalid or missing |
173 | 173 | * @return string 'instance', 'subclass', or 'instanceOrSubclass' |
174 | 174 | */ |
175 | - public function parseRelationParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
176 | - $this->checkError( $constraintParameters ); |
|
177 | - $relationId = $this->config->get( 'WBQualityConstraintsRelationId' ); |
|
178 | - if ( !array_key_exists( $relationId, $constraintParameters ) ) { |
|
175 | + public function parseRelationParameter(array $constraintParameters, $constraintTypeItemId) { |
|
176 | + $this->checkError($constraintParameters); |
|
177 | + $relationId = $this->config->get('WBQualityConstraintsRelationId'); |
|
178 | + if (!array_key_exists($relationId, $constraintParameters)) { |
|
179 | 179 | throw new ConstraintParameterException( |
180 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
181 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
182 | - ->withEntityId( new PropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
180 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
181 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
182 | + ->withEntityId(new PropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
183 | 183 | ); |
184 | 184 | } |
185 | 185 | |
186 | - $this->requireSingleParameter( $constraintParameters, $relationId ); |
|
187 | - $relationEntityId = $this->parseEntityIdParameter( $constraintParameters[$relationId][0], $relationId ); |
|
188 | - $instanceId = $this->config->get( 'WBQualityConstraintsInstanceOfRelationId' ); |
|
189 | - $subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfRelationId' ); |
|
190 | - $instanceOrSubclassId = $this->config->get( 'WBQualityConstraintsInstanceOrSubclassOfRelationId' ); |
|
191 | - switch ( $relationEntityId ) { |
|
186 | + $this->requireSingleParameter($constraintParameters, $relationId); |
|
187 | + $relationEntityId = $this->parseEntityIdParameter($constraintParameters[$relationId][0], $relationId); |
|
188 | + $instanceId = $this->config->get('WBQualityConstraintsInstanceOfRelationId'); |
|
189 | + $subclassId = $this->config->get('WBQualityConstraintsSubclassOfRelationId'); |
|
190 | + $instanceOrSubclassId = $this->config->get('WBQualityConstraintsInstanceOrSubclassOfRelationId'); |
|
191 | + switch ($relationEntityId) { |
|
192 | 192 | case $instanceId: |
193 | 193 | return 'instance'; |
194 | 194 | case $subclassId: |
@@ -197,13 +197,13 @@ discard block |
||
197 | 197 | return 'instanceOrSubclass'; |
198 | 198 | default: |
199 | 199 | throw new ConstraintParameterException( |
200 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
201 | - ->withEntityId( new PropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
200 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
201 | + ->withEntityId(new PropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
202 | 202 | ->withEntityIdList( |
203 | 203 | [ |
204 | - new ItemId( $instanceId ), |
|
205 | - new ItemId( $subclassId ), |
|
206 | - new ItemId( $instanceOrSubclassId ), |
|
204 | + new ItemId($instanceId), |
|
205 | + new ItemId($subclassId), |
|
206 | + new ItemId($instanceOrSubclassId), |
|
207 | 207 | ], |
208 | 208 | Role::CONSTRAINT_PARAMETER_VALUE |
209 | 209 | ) |
@@ -218,20 +218,20 @@ discard block |
||
218 | 218 | * @throws ConstraintParameterException |
219 | 219 | * @return PropertyId |
220 | 220 | */ |
221 | - private function parsePropertyIdParameter( array $snakSerialization, $parameterId ) { |
|
222 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
223 | - $this->requireValueParameter( $snak, $parameterId ); |
|
221 | + private function parsePropertyIdParameter(array $snakSerialization, $parameterId) { |
|
222 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
223 | + $this->requireValueParameter($snak, $parameterId); |
|
224 | 224 | $value = $snak->getDataValue(); |
225 | - if ( $value instanceof EntityIdValue ) { |
|
225 | + if ($value instanceof EntityIdValue) { |
|
226 | 226 | $id = $value->getEntityId(); |
227 | - if ( $id instanceof PropertyId ) { |
|
227 | + if ($id instanceof PropertyId) { |
|
228 | 228 | return $id; |
229 | 229 | } |
230 | 230 | } |
231 | 231 | throw new ConstraintParameterException( |
232 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-property' ) ) |
|
233 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
234 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
232 | + (new ViolationMessage('wbqc-violation-message-parameter-property')) |
|
233 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
234 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
235 | 235 | ); |
236 | 236 | } |
237 | 237 | |
@@ -242,33 +242,33 @@ discard block |
||
242 | 242 | * @throws ConstraintParameterException if the parameter is invalid or missing |
243 | 243 | * @return PropertyId |
244 | 244 | */ |
245 | - public function parsePropertyParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
246 | - $this->checkError( $constraintParameters ); |
|
247 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
248 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
245 | + public function parsePropertyParameter(array $constraintParameters, $constraintTypeItemId) { |
|
246 | + $this->checkError($constraintParameters); |
|
247 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
248 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
249 | 249 | throw new ConstraintParameterException( |
250 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
251 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
252 | - ->withEntityId( new PropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
250 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
251 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
252 | + ->withEntityId(new PropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
253 | 253 | ); |
254 | 254 | } |
255 | 255 | |
256 | - $this->requireSingleParameter( $constraintParameters, $propertyId ); |
|
257 | - return $this->parsePropertyIdParameter( $constraintParameters[$propertyId][0], $propertyId ); |
|
256 | + $this->requireSingleParameter($constraintParameters, $propertyId); |
|
257 | + return $this->parsePropertyIdParameter($constraintParameters[$propertyId][0], $propertyId); |
|
258 | 258 | } |
259 | 259 | |
260 | - private function parseItemIdParameter( PropertyValueSnak $snak, $parameterId ) { |
|
260 | + private function parseItemIdParameter(PropertyValueSnak $snak, $parameterId) { |
|
261 | 261 | $dataValue = $snak->getDataValue(); |
262 | - if ( $dataValue instanceof EntityIdValue ) { |
|
262 | + if ($dataValue instanceof EntityIdValue) { |
|
263 | 263 | $entityId = $dataValue->getEntityId(); |
264 | - if ( $entityId instanceof ItemId ) { |
|
265 | - return ItemIdSnakValue::fromItemId( $entityId ); |
|
264 | + if ($entityId instanceof ItemId) { |
|
265 | + return ItemIdSnakValue::fromItemId($entityId); |
|
266 | 266 | } |
267 | 267 | } |
268 | 268 | throw new ConstraintParameterException( |
269 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-item' ) ) |
|
270 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
271 | - ->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
269 | + (new ViolationMessage('wbqc-violation-message-parameter-item')) |
|
270 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
271 | + ->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
272 | 272 | ); |
273 | 273 | } |
274 | 274 | |
@@ -286,16 +286,16 @@ discard block |
||
286 | 286 | $required, |
287 | 287 | $parameterId = null |
288 | 288 | ) { |
289 | - $this->checkError( $constraintParameters ); |
|
290 | - if ( $parameterId === null ) { |
|
291 | - $parameterId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
289 | + $this->checkError($constraintParameters); |
|
290 | + if ($parameterId === null) { |
|
291 | + $parameterId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
292 | 292 | } |
293 | - if ( !array_key_exists( $parameterId, $constraintParameters ) ) { |
|
294 | - if ( $required ) { |
|
293 | + if (!array_key_exists($parameterId, $constraintParameters)) { |
|
294 | + if ($required) { |
|
295 | 295 | throw new ConstraintParameterException( |
296 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
297 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
298 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
296 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
297 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
298 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
299 | 299 | ); |
300 | 300 | } else { |
301 | 301 | return []; |
@@ -303,11 +303,11 @@ discard block |
||
303 | 303 | } |
304 | 304 | |
305 | 305 | $values = []; |
306 | - foreach ( $constraintParameters[$parameterId] as $parameter ) { |
|
307 | - $snak = $this->snakDeserializer->deserialize( $parameter ); |
|
308 | - switch ( true ) { |
|
306 | + foreach ($constraintParameters[$parameterId] as $parameter) { |
|
307 | + $snak = $this->snakDeserializer->deserialize($parameter); |
|
308 | + switch (true) { |
|
309 | 309 | case $snak instanceof PropertyValueSnak: |
310 | - $values[] = $this->parseItemIdParameter( $snak, $parameterId ); |
|
310 | + $values[] = $this->parseItemIdParameter($snak, $parameterId); |
|
311 | 311 | break; |
312 | 312 | case $snak instanceof PropertySomeValueSnak: |
313 | 313 | $values[] = ItemIdSnakValue::someValue(); |
@@ -326,27 +326,27 @@ discard block |
||
326 | 326 | * @throws ConstraintParameterException if the parameter is invalid or missing |
327 | 327 | * @return PropertyId[] |
328 | 328 | */ |
329 | - public function parsePropertiesParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
330 | - $this->checkError( $constraintParameters ); |
|
331 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
332 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
329 | + public function parsePropertiesParameter(array $constraintParameters, $constraintTypeItemId) { |
|
330 | + $this->checkError($constraintParameters); |
|
331 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
332 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
333 | 333 | throw new ConstraintParameterException( |
334 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
335 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
336 | - ->withEntityId( new PropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
334 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
335 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
336 | + ->withEntityId(new PropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
337 | 337 | ); |
338 | 338 | } |
339 | 339 | |
340 | 340 | $parameters = $constraintParameters[$propertyId]; |
341 | - if ( count( $parameters ) === 1 && |
|
342 | - $this->snakDeserializer->deserialize( $parameters[0] ) instanceof PropertyNoValueSnak |
|
341 | + if (count($parameters) === 1 && |
|
342 | + $this->snakDeserializer->deserialize($parameters[0]) instanceof PropertyNoValueSnak |
|
343 | 343 | ) { |
344 | 344 | return []; |
345 | 345 | } |
346 | 346 | |
347 | 347 | $properties = []; |
348 | - foreach ( $parameters as $parameter ) { |
|
349 | - $properties[] = $this->parsePropertyIdParameter( $parameter, $propertyId ); |
|
348 | + foreach ($parameters as $parameter) { |
|
349 | + $properties[] = $this->parsePropertyIdParameter($parameter, $propertyId); |
|
350 | 350 | } |
351 | 351 | return $properties; |
352 | 352 | } |
@@ -357,16 +357,16 @@ discard block |
||
357 | 357 | * @throws ConstraintParameterException |
358 | 358 | * @return DataValue|null |
359 | 359 | */ |
360 | - private function parseValueOrNoValueParameter( array $snakSerialization, $parameterId ) { |
|
361 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
362 | - if ( $snak instanceof PropertyValueSnak ) { |
|
360 | + private function parseValueOrNoValueParameter(array $snakSerialization, $parameterId) { |
|
361 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
362 | + if ($snak instanceof PropertyValueSnak) { |
|
363 | 363 | return $snak->getDataValue(); |
364 | - } elseif ( $snak instanceof PropertyNoValueSnak ) { |
|
364 | + } elseif ($snak instanceof PropertyNoValueSnak) { |
|
365 | 365 | return null; |
366 | 366 | } else { |
367 | 367 | throw new ConstraintParameterException( |
368 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) ) |
|
369 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
368 | + (new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue')) |
|
369 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
370 | 370 | ); |
371 | 371 | } |
372 | 372 | } |
@@ -376,10 +376,10 @@ discard block |
||
376 | 376 | * @param string $parameterId |
377 | 377 | * @return DataValue|null |
378 | 378 | */ |
379 | - private function parseValueOrNoValueOrNowParameter( array $snakSerialization, $parameterId ) { |
|
379 | + private function parseValueOrNoValueOrNowParameter(array $snakSerialization, $parameterId) { |
|
380 | 380 | try { |
381 | - return $this->parseValueOrNoValueParameter( $snakSerialization, $parameterId ); |
|
382 | - } catch ( ConstraintParameterException $e ) { |
|
381 | + return $this->parseValueOrNoValueParameter($snakSerialization, $parameterId); |
|
382 | + } catch (ConstraintParameterException $e) { |
|
383 | 383 | // unknown value means “now” |
384 | 384 | return new NowValue(); |
385 | 385 | } |
@@ -392,14 +392,14 @@ discard block |
||
392 | 392 | * @param string $unit |
393 | 393 | * @return bool |
394 | 394 | */ |
395 | - private function exactlyOneQuantityWithUnit( ?DataValue $min, ?DataValue $max, $unit ) { |
|
396 | - if ( !( $min instanceof UnboundedQuantityValue ) || |
|
397 | - !( $max instanceof UnboundedQuantityValue ) |
|
395 | + private function exactlyOneQuantityWithUnit(?DataValue $min, ?DataValue $max, $unit) { |
|
396 | + if (!($min instanceof UnboundedQuantityValue) || |
|
397 | + !($max instanceof UnboundedQuantityValue) |
|
398 | 398 | ) { |
399 | 399 | return false; |
400 | 400 | } |
401 | 401 | |
402 | - return ( $min->getUnit() === $unit ) !== ( $max->getUnit() === $unit ); |
|
402 | + return ($min->getUnit() === $unit) !== ($max->getUnit() === $unit); |
|
403 | 403 | } |
404 | 404 | |
405 | 405 | /** |
@@ -412,42 +412,42 @@ discard block |
||
412 | 412 | * @throws ConstraintParameterException if the parameter is invalid or missing |
413 | 413 | * @return DataValue[] if the parameter is invalid or missing |
414 | 414 | */ |
415 | - private function parseRangeParameter( array $constraintParameters, $minimumId, $maximumId, $constraintTypeItemId, $type ) { |
|
416 | - $this->checkError( $constraintParameters ); |
|
417 | - if ( !array_key_exists( $minimumId, $constraintParameters ) || |
|
418 | - !array_key_exists( $maximumId, $constraintParameters ) |
|
415 | + private function parseRangeParameter(array $constraintParameters, $minimumId, $maximumId, $constraintTypeItemId, $type) { |
|
416 | + $this->checkError($constraintParameters); |
|
417 | + if (!array_key_exists($minimumId, $constraintParameters) || |
|
418 | + !array_key_exists($maximumId, $constraintParameters) |
|
419 | 419 | ) { |
420 | 420 | throw new ConstraintParameterException( |
421 | - ( new ViolationMessage( 'wbqc-violation-message-range-parameters-needed' ) ) |
|
422 | - ->withDataValueType( $type ) |
|
423 | - ->withEntityId( new PropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
424 | - ->withEntityId( new PropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
425 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
421 | + (new ViolationMessage('wbqc-violation-message-range-parameters-needed')) |
|
422 | + ->withDataValueType($type) |
|
423 | + ->withEntityId(new PropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
424 | + ->withEntityId(new PropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
425 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
426 | 426 | ); |
427 | 427 | } |
428 | 428 | |
429 | - $this->requireSingleParameter( $constraintParameters, $minimumId ); |
|
430 | - $this->requireSingleParameter( $constraintParameters, $maximumId ); |
|
429 | + $this->requireSingleParameter($constraintParameters, $minimumId); |
|
430 | + $this->requireSingleParameter($constraintParameters, $maximumId); |
|
431 | 431 | $parseFunction = $type === 'time' ? 'parseValueOrNoValueOrNowParameter' : 'parseValueOrNoValueParameter'; |
432 | - $min = $this->$parseFunction( $constraintParameters[$minimumId][0], $minimumId ); |
|
433 | - $max = $this->$parseFunction( $constraintParameters[$maximumId][0], $maximumId ); |
|
432 | + $min = $this->$parseFunction($constraintParameters[$minimumId][0], $minimumId); |
|
433 | + $max = $this->$parseFunction($constraintParameters[$maximumId][0], $maximumId); |
|
434 | 434 | |
435 | - $yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' ); |
|
436 | - if ( $this->exactlyOneQuantityWithUnit( $min, $max, $yearUnit ) ) { |
|
435 | + $yearUnit = $this->config->get('WBQualityConstraintsYearUnit'); |
|
436 | + if ($this->exactlyOneQuantityWithUnit($min, $max, $yearUnit)) { |
|
437 | 437 | throw new ConstraintParameterException( |
438 | - new ViolationMessage( 'wbqc-violation-message-range-parameters-one-year' ) |
|
438 | + new ViolationMessage('wbqc-violation-message-range-parameters-one-year') |
|
439 | 439 | ); |
440 | 440 | } |
441 | - if ( $min === null && $max === null || |
|
442 | - $min !== null && $max !== null && $min->equals( $max ) ) { |
|
441 | + if ($min === null && $max === null || |
|
442 | + $min !== null && $max !== null && $min->equals($max)) { |
|
443 | 443 | throw new ConstraintParameterException( |
444 | - ( new ViolationMessage( 'wbqc-violation-message-range-parameters-same' ) ) |
|
445 | - ->withEntityId( new PropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
446 | - ->withEntityId( new PropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
444 | + (new ViolationMessage('wbqc-violation-message-range-parameters-same')) |
|
445 | + ->withEntityId(new PropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
446 | + ->withEntityId(new PropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
447 | 447 | ); |
448 | 448 | } |
449 | 449 | |
450 | - return [ $min, $max ]; |
|
450 | + return [$min, $max]; |
|
451 | 451 | } |
452 | 452 | |
453 | 453 | /** |
@@ -457,11 +457,11 @@ discard block |
||
457 | 457 | * @throws ConstraintParameterException if the parameter is invalid or missing |
458 | 458 | * @return DataValue[] a pair of two data values, either of which may be null to signify an open range |
459 | 459 | */ |
460 | - public function parseQuantityRangeParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
460 | + public function parseQuantityRangeParameter(array $constraintParameters, $constraintTypeItemId) { |
|
461 | 461 | return $this->parseRangeParameter( |
462 | 462 | $constraintParameters, |
463 | - $this->config->get( 'WBQualityConstraintsMinimumQuantityId' ), |
|
464 | - $this->config->get( 'WBQualityConstraintsMaximumQuantityId' ), |
|
463 | + $this->config->get('WBQualityConstraintsMinimumQuantityId'), |
|
464 | + $this->config->get('WBQualityConstraintsMaximumQuantityId'), |
|
465 | 465 | $constraintTypeItemId, |
466 | 466 | 'quantity' |
467 | 467 | ); |
@@ -474,11 +474,11 @@ discard block |
||
474 | 474 | * @throws ConstraintParameterException if the parameter is invalid or missing |
475 | 475 | * @return DataValue[] a pair of two data values, either of which may be null to signify an open range |
476 | 476 | */ |
477 | - public function parseTimeRangeParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
477 | + public function parseTimeRangeParameter(array $constraintParameters, $constraintTypeItemId) { |
|
478 | 478 | return $this->parseRangeParameter( |
479 | 479 | $constraintParameters, |
480 | - $this->config->get( 'WBQualityConstraintsMinimumDateId' ), |
|
481 | - $this->config->get( 'WBQualityConstraintsMaximumDateId' ), |
|
480 | + $this->config->get('WBQualityConstraintsMinimumDateId'), |
|
481 | + $this->config->get('WBQualityConstraintsMaximumDateId'), |
|
482 | 482 | $constraintTypeItemId, |
483 | 483 | 'time' |
484 | 484 | ); |
@@ -491,17 +491,17 @@ discard block |
||
491 | 491 | * @throws ConstraintParameterException |
492 | 492 | * @return string |
493 | 493 | */ |
494 | - private function parseStringParameter( array $snakSerialization, $parameterId ) { |
|
495 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
496 | - $this->requireValueParameter( $snak, $parameterId ); |
|
494 | + private function parseStringParameter(array $snakSerialization, $parameterId) { |
|
495 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
496 | + $this->requireValueParameter($snak, $parameterId); |
|
497 | 497 | $value = $snak->getDataValue(); |
498 | - if ( $value instanceof StringValue ) { |
|
498 | + if ($value instanceof StringValue) { |
|
499 | 499 | return $value->getValue(); |
500 | 500 | } else { |
501 | 501 | throw new ConstraintParameterException( |
502 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-string' ) ) |
|
503 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
504 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
502 | + (new ViolationMessage('wbqc-violation-message-parameter-string')) |
|
503 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
504 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
505 | 505 | ); |
506 | 506 | } |
507 | 507 | } |
@@ -512,15 +512,15 @@ discard block |
||
512 | 512 | * @throws ConstraintParameterException if the parameter is invalid or missing |
513 | 513 | * @return string |
514 | 514 | */ |
515 | - public function parseNamespaceParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
516 | - $this->checkError( $constraintParameters ); |
|
517 | - $namespaceId = $this->config->get( 'WBQualityConstraintsNamespaceId' ); |
|
518 | - if ( !array_key_exists( $namespaceId, $constraintParameters ) ) { |
|
515 | + public function parseNamespaceParameter(array $constraintParameters, $constraintTypeItemId) { |
|
516 | + $this->checkError($constraintParameters); |
|
517 | + $namespaceId = $this->config->get('WBQualityConstraintsNamespaceId'); |
|
518 | + if (!array_key_exists($namespaceId, $constraintParameters)) { |
|
519 | 519 | return ''; |
520 | 520 | } |
521 | 521 | |
522 | - $this->requireSingleParameter( $constraintParameters, $namespaceId ); |
|
523 | - return $this->parseStringParameter( $constraintParameters[$namespaceId][0], $namespaceId ); |
|
522 | + $this->requireSingleParameter($constraintParameters, $namespaceId); |
|
523 | + return $this->parseStringParameter($constraintParameters[$namespaceId][0], $namespaceId); |
|
524 | 524 | } |
525 | 525 | |
526 | 526 | /** |
@@ -529,19 +529,19 @@ discard block |
||
529 | 529 | * @throws ConstraintParameterException if the parameter is invalid or missing |
530 | 530 | * @return string |
531 | 531 | */ |
532 | - public function parseFormatParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
533 | - $this->checkError( $constraintParameters ); |
|
534 | - $formatId = $this->config->get( 'WBQualityConstraintsFormatAsARegularExpressionId' ); |
|
535 | - if ( !array_key_exists( $formatId, $constraintParameters ) ) { |
|
532 | + public function parseFormatParameter(array $constraintParameters, $constraintTypeItemId) { |
|
533 | + $this->checkError($constraintParameters); |
|
534 | + $formatId = $this->config->get('WBQualityConstraintsFormatAsARegularExpressionId'); |
|
535 | + if (!array_key_exists($formatId, $constraintParameters)) { |
|
536 | 536 | throw new ConstraintParameterException( |
537 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
538 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
539 | - ->withEntityId( new PropertyId( $formatId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
537 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
538 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
539 | + ->withEntityId(new PropertyId($formatId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
540 | 540 | ); |
541 | 541 | } |
542 | 542 | |
543 | - $this->requireSingleParameter( $constraintParameters, $formatId ); |
|
544 | - return $this->parseStringParameter( $constraintParameters[$formatId][0], $formatId ); |
|
543 | + $this->requireSingleParameter($constraintParameters, $formatId); |
|
544 | + return $this->parseStringParameter($constraintParameters[$formatId][0], $formatId); |
|
545 | 545 | } |
546 | 546 | |
547 | 547 | /** |
@@ -549,16 +549,16 @@ discard block |
||
549 | 549 | * @throws ConstraintParameterException if the parameter is invalid |
550 | 550 | * @return EntityId[] |
551 | 551 | */ |
552 | - public function parseExceptionParameter( array $constraintParameters ) { |
|
553 | - $this->checkError( $constraintParameters ); |
|
554 | - $exceptionId = $this->config->get( 'WBQualityConstraintsExceptionToConstraintId' ); |
|
555 | - if ( !array_key_exists( $exceptionId, $constraintParameters ) ) { |
|
552 | + public function parseExceptionParameter(array $constraintParameters) { |
|
553 | + $this->checkError($constraintParameters); |
|
554 | + $exceptionId = $this->config->get('WBQualityConstraintsExceptionToConstraintId'); |
|
555 | + if (!array_key_exists($exceptionId, $constraintParameters)) { |
|
556 | 556 | return []; |
557 | 557 | } |
558 | 558 | |
559 | 559 | return array_map( |
560 | - function( $snakSerialization ) use ( $exceptionId ) { |
|
561 | - return $this->parseEntityIdParameter( $snakSerialization, $exceptionId ); |
|
560 | + function($snakSerialization) use ($exceptionId) { |
|
561 | + return $this->parseEntityIdParameter($snakSerialization, $exceptionId); |
|
562 | 562 | }, |
563 | 563 | $constraintParameters[$exceptionId] |
564 | 564 | ); |
@@ -569,39 +569,39 @@ discard block |
||
569 | 569 | * @throws ConstraintParameterException if the parameter is invalid |
570 | 570 | * @return string|null 'mandatory', 'suggestion' or null |
571 | 571 | */ |
572 | - public function parseConstraintStatusParameter( array $constraintParameters ) { |
|
573 | - $this->checkError( $constraintParameters ); |
|
574 | - $constraintStatusId = $this->config->get( 'WBQualityConstraintsConstraintStatusId' ); |
|
575 | - if ( !array_key_exists( $constraintStatusId, $constraintParameters ) ) { |
|
572 | + public function parseConstraintStatusParameter(array $constraintParameters) { |
|
573 | + $this->checkError($constraintParameters); |
|
574 | + $constraintStatusId = $this->config->get('WBQualityConstraintsConstraintStatusId'); |
|
575 | + if (!array_key_exists($constraintStatusId, $constraintParameters)) { |
|
576 | 576 | return null; |
577 | 577 | } |
578 | 578 | |
579 | - $mandatoryId = $this->config->get( 'WBQualityConstraintsMandatoryConstraintId' ); |
|
580 | - $supportedStatuses = [ new ItemId( $mandatoryId ) ]; |
|
581 | - if ( $this->config->get( 'WBQualityConstraintsEnableSuggestionConstraintStatus' ) ) { |
|
582 | - $suggestionId = $this->config->get( 'WBQualityConstraintsSuggestionConstraintId' ); |
|
583 | - $supportedStatuses[] = new ItemId( $suggestionId ); |
|
579 | + $mandatoryId = $this->config->get('WBQualityConstraintsMandatoryConstraintId'); |
|
580 | + $supportedStatuses = [new ItemId($mandatoryId)]; |
|
581 | + if ($this->config->get('WBQualityConstraintsEnableSuggestionConstraintStatus')) { |
|
582 | + $suggestionId = $this->config->get('WBQualityConstraintsSuggestionConstraintId'); |
|
583 | + $supportedStatuses[] = new ItemId($suggestionId); |
|
584 | 584 | } else { |
585 | 585 | $suggestionId = null; |
586 | 586 | } |
587 | 587 | |
588 | - $this->requireSingleParameter( $constraintParameters, $constraintStatusId ); |
|
589 | - $snak = $this->snakDeserializer->deserialize( $constraintParameters[$constraintStatusId][0] ); |
|
590 | - $this->requireValueParameter( $snak, $constraintStatusId ); |
|
588 | + $this->requireSingleParameter($constraintParameters, $constraintStatusId); |
|
589 | + $snak = $this->snakDeserializer->deserialize($constraintParameters[$constraintStatusId][0]); |
|
590 | + $this->requireValueParameter($snak, $constraintStatusId); |
|
591 | 591 | '@phan-var \Wikibase\DataModel\Snak\PropertyValueSnak $snak'; |
592 | 592 | $dataValue = $snak->getDataValue(); |
593 | 593 | '@phan-var EntityIdValue $dataValue'; |
594 | 594 | $entityId = $dataValue->getEntityId(); |
595 | 595 | $statusId = $entityId->getSerialization(); |
596 | 596 | |
597 | - if ( $statusId === $mandatoryId ) { |
|
597 | + if ($statusId === $mandatoryId) { |
|
598 | 598 | return 'mandatory'; |
599 | - } elseif ( $statusId === $suggestionId ) { |
|
599 | + } elseif ($statusId === $suggestionId) { |
|
600 | 600 | return 'suggestion'; |
601 | 601 | } else { |
602 | 602 | throw new ConstraintParameterException( |
603 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
604 | - ->withEntityId( new PropertyId( $constraintStatusId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
603 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
604 | + ->withEntityId(new PropertyId($constraintStatusId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
605 | 605 | ->withEntityIdList( |
606 | 606 | $supportedStatuses, |
607 | 607 | Role::CONSTRAINT_PARAMETER_VALUE |
@@ -617,12 +617,12 @@ discard block |
||
617 | 617 | * @return void |
618 | 618 | * @throws ConstraintParameterException |
619 | 619 | */ |
620 | - private function requireMonolingualTextParameter( DataValue $dataValue, $parameterId ) { |
|
621 | - if ( !( $dataValue instanceof MonolingualTextValue ) ) { |
|
620 | + private function requireMonolingualTextParameter(DataValue $dataValue, $parameterId) { |
|
621 | + if (!($dataValue instanceof MonolingualTextValue)) { |
|
622 | 622 | throw new ConstraintParameterException( |
623 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-monolingualtext' ) ) |
|
624 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
625 | - ->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
623 | + (new ViolationMessage('wbqc-violation-message-parameter-monolingualtext')) |
|
624 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
625 | + ->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
626 | 626 | ); |
627 | 627 | } |
628 | 628 | } |
@@ -635,31 +635,31 @@ discard block |
||
635 | 635 | * @throws ConstraintParameterException if invalid snaks are found or a language has multiple texts |
636 | 636 | * @return MultilingualTextValue |
637 | 637 | */ |
638 | - private function parseMultilingualTextParameter( array $snakSerializations, $parameterId ) { |
|
638 | + private function parseMultilingualTextParameter(array $snakSerializations, $parameterId) { |
|
639 | 639 | $result = []; |
640 | 640 | |
641 | - foreach ( $snakSerializations as $snakSerialization ) { |
|
642 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
643 | - $this->requireValueParameter( $snak, $parameterId ); |
|
641 | + foreach ($snakSerializations as $snakSerialization) { |
|
642 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
643 | + $this->requireValueParameter($snak, $parameterId); |
|
644 | 644 | |
645 | 645 | $value = $snak->getDataValue(); |
646 | - $this->requireMonolingualTextParameter( $value, $parameterId ); |
|
646 | + $this->requireMonolingualTextParameter($value, $parameterId); |
|
647 | 647 | /** @var MonolingualTextValue $value */ |
648 | 648 | '@phan-var MonolingualTextValue $value'; |
649 | 649 | |
650 | 650 | $code = $value->getLanguageCode(); |
651 | - if ( array_key_exists( $code, $result ) ) { |
|
651 | + if (array_key_exists($code, $result)) { |
|
652 | 652 | throw new ConstraintParameterException( |
653 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-single-per-language' ) ) |
|
654 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
655 | - ->withLanguage( $code ) |
|
653 | + (new ViolationMessage('wbqc-violation-message-parameter-single-per-language')) |
|
654 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
655 | + ->withLanguage($code) |
|
656 | 656 | ); |
657 | 657 | } |
658 | 658 | |
659 | 659 | $result[$code] = $value; |
660 | 660 | } |
661 | 661 | |
662 | - return new MultilingualTextValue( $result ); |
|
662 | + return new MultilingualTextValue($result); |
|
663 | 663 | } |
664 | 664 | |
665 | 665 | /** |
@@ -667,11 +667,11 @@ discard block |
||
667 | 667 | * @throws ConstraintParameterException if the parameter is invalid |
668 | 668 | * @return MultilingualTextValue |
669 | 669 | */ |
670 | - public function parseSyntaxClarificationParameter( array $constraintParameters ) { |
|
671 | - $syntaxClarificationId = $this->config->get( 'WBQualityConstraintsSyntaxClarificationId' ); |
|
670 | + public function parseSyntaxClarificationParameter(array $constraintParameters) { |
|
671 | + $syntaxClarificationId = $this->config->get('WBQualityConstraintsSyntaxClarificationId'); |
|
672 | 672 | |
673 | - if ( !array_key_exists( $syntaxClarificationId, $constraintParameters ) ) { |
|
674 | - return new MultilingualTextValue( [] ); |
|
673 | + if (!array_key_exists($syntaxClarificationId, $constraintParameters)) { |
|
674 | + return new MultilingualTextValue([]); |
|
675 | 675 | } |
676 | 676 | |
677 | 677 | $syntaxClarifications = $this->parseMultilingualTextParameter( |
@@ -690,9 +690,9 @@ discard block |
||
690 | 690 | * @throws ConstraintParameterException if the parameter is invalid |
691 | 691 | * @return string[]|null Context::TYPE_* constants |
692 | 692 | */ |
693 | - public function parseConstraintScopeParameter( array $constraintParameters, $constraintTypeItemId, array $validScopes = null ) { |
|
693 | + public function parseConstraintScopeParameter(array $constraintParameters, $constraintTypeItemId, array $validScopes = null) { |
|
694 | 694 | $contextTypes = []; |
695 | - $parameterId = $this->config->get( 'WBQualityConstraintsConstraintScopeId' ); |
|
695 | + $parameterId = $this->config->get('WBQualityConstraintsConstraintScopeId'); |
|
696 | 696 | $items = $this->parseItemsParameter( |
697 | 697 | $constraintParameters, |
698 | 698 | $constraintTypeItemId, |
@@ -700,23 +700,23 @@ discard block |
||
700 | 700 | $parameterId |
701 | 701 | ); |
702 | 702 | |
703 | - if ( $items === [] ) { |
|
703 | + if ($items === []) { |
|
704 | 704 | return null; |
705 | 705 | } |
706 | 706 | |
707 | - foreach ( $items as $item ) { |
|
708 | - $contextTypes[] = $this->parseContextTypeItem( $item, 'constraint scope', $parameterId ); |
|
707 | + foreach ($items as $item) { |
|
708 | + $contextTypes[] = $this->parseContextTypeItem($item, 'constraint scope', $parameterId); |
|
709 | 709 | } |
710 | 710 | |
711 | - if ( $validScopes !== null ) { |
|
712 | - $invalidScopes = array_diff( $contextTypes, $validScopes ); |
|
713 | - if ( $invalidScopes !== [] ) { |
|
714 | - $invalidScope = array_pop( $invalidScopes ); |
|
711 | + if ($validScopes !== null) { |
|
712 | + $invalidScopes = array_diff($contextTypes, $validScopes); |
|
713 | + if ($invalidScopes !== []) { |
|
714 | + $invalidScope = array_pop($invalidScopes); |
|
715 | 715 | throw new ConstraintParameterException( |
716 | - ( new ViolationMessage( 'wbqc-violation-message-invalid-scope' ) ) |
|
717 | - ->withConstraintScope( $invalidScope, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
718 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
719 | - ->withConstraintScopeList( $validScopes, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
716 | + (new ViolationMessage('wbqc-violation-message-invalid-scope')) |
|
717 | + ->withConstraintScope($invalidScope, Role::CONSTRAINT_PARAMETER_VALUE) |
|
718 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
719 | + ->withConstraintScopeList($validScopes, Role::CONSTRAINT_PARAMETER_VALUE) |
|
720 | 720 | ); |
721 | 721 | } |
722 | 722 | } |
@@ -730,8 +730,8 @@ discard block |
||
730 | 730 | * @param ItemId $unitId |
731 | 731 | * @return string unit |
732 | 732 | */ |
733 | - private function parseUnitParameter( ItemId $unitId ) { |
|
734 | - return $this->unitItemConceptBaseUri . $unitId->getSerialization(); |
|
733 | + private function parseUnitParameter(ItemId $unitId) { |
|
734 | + return $this->unitItemConceptBaseUri.$unitId->getSerialization(); |
|
735 | 735 | } |
736 | 736 | |
737 | 737 | /** |
@@ -741,23 +741,23 @@ discard block |
||
741 | 741 | * @return UnitsParameter |
742 | 742 | * @throws ConstraintParameterException |
743 | 743 | */ |
744 | - private function parseUnitItem( ItemIdSnakValue $item ) { |
|
745 | - switch ( true ) { |
|
744 | + private function parseUnitItem(ItemIdSnakValue $item) { |
|
745 | + switch (true) { |
|
746 | 746 | case $item->isValue(): |
747 | - $unit = $this->parseUnitParameter( $item->getItemId() ); |
|
747 | + $unit = $this->parseUnitParameter($item->getItemId()); |
|
748 | 748 | return new UnitsParameter( |
749 | - [ $item->getItemId() ], |
|
750 | - [ UnboundedQuantityValue::newFromNumber( 1, $unit ) ], |
|
749 | + [$item->getItemId()], |
|
750 | + [UnboundedQuantityValue::newFromNumber(1, $unit)], |
|
751 | 751 | false |
752 | 752 | ); |
753 | 753 | case $item->isSomeValue(): |
754 | - $qualifierId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
754 | + $qualifierId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
755 | 755 | throw new ConstraintParameterException( |
756 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) ) |
|
757 | - ->withEntityId( new PropertyId( $qualifierId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
756 | + (new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue')) |
|
757 | + ->withEntityId(new PropertyId($qualifierId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
758 | 758 | ); |
759 | 759 | case $item->isNoValue(): |
760 | - return new UnitsParameter( [], [], true ); |
|
760 | + return new UnitsParameter([], [], true); |
|
761 | 761 | } |
762 | 762 | } |
763 | 763 | |
@@ -767,26 +767,26 @@ discard block |
||
767 | 767 | * @throws ConstraintParameterException if the parameter is invalid or missing |
768 | 768 | * @return UnitsParameter |
769 | 769 | */ |
770 | - public function parseUnitsParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
771 | - $items = $this->parseItemsParameter( $constraintParameters, $constraintTypeItemId, true ); |
|
770 | + public function parseUnitsParameter(array $constraintParameters, $constraintTypeItemId) { |
|
771 | + $items = $this->parseItemsParameter($constraintParameters, $constraintTypeItemId, true); |
|
772 | 772 | $unitItems = []; |
773 | 773 | $unitQuantities = []; |
774 | 774 | $unitlessAllowed = false; |
775 | 775 | |
776 | - foreach ( $items as $item ) { |
|
777 | - $unit = $this->parseUnitItem( $item ); |
|
778 | - $unitItems = array_merge( $unitItems, $unit->getUnitItemIds() ); |
|
779 | - $unitQuantities = array_merge( $unitQuantities, $unit->getUnitQuantities() ); |
|
776 | + foreach ($items as $item) { |
|
777 | + $unit = $this->parseUnitItem($item); |
|
778 | + $unitItems = array_merge($unitItems, $unit->getUnitItemIds()); |
|
779 | + $unitQuantities = array_merge($unitQuantities, $unit->getUnitQuantities()); |
|
780 | 780 | $unitlessAllowed = $unitlessAllowed || $unit->getUnitlessAllowed(); |
781 | 781 | } |
782 | 782 | |
783 | - if ( $unitQuantities === [] && !$unitlessAllowed ) { |
|
783 | + if ($unitQuantities === [] && !$unitlessAllowed) { |
|
784 | 784 | throw new LogicException( |
785 | 785 | 'The "units" parameter is required, and yet we seem to be missing any allowed unit' |
786 | 786 | ); |
787 | 787 | } |
788 | 788 | |
789 | - return new UnitsParameter( $unitItems, $unitQuantities, $unitlessAllowed ); |
|
789 | + return new UnitsParameter($unitItems, $unitQuantities, $unitlessAllowed); |
|
790 | 790 | } |
791 | 791 | |
792 | 792 | /** |
@@ -796,53 +796,53 @@ discard block |
||
796 | 796 | * @return EntityTypesParameter |
797 | 797 | * @throws ConstraintParameterException |
798 | 798 | */ |
799 | - private function parseEntityTypeItem( ItemIdSnakValue $item ) { |
|
800 | - $parameterId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
799 | + private function parseEntityTypeItem(ItemIdSnakValue $item) { |
|
800 | + $parameterId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
801 | 801 | |
802 | - if ( !$item->isValue() ) { |
|
802 | + if (!$item->isValue()) { |
|
803 | 803 | throw new ConstraintParameterException( |
804 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
805 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
804 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
805 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
806 | 806 | ); |
807 | 807 | } |
808 | 808 | |
809 | 809 | $itemId = $item->getItemId(); |
810 | - switch ( $itemId->getSerialization() ) { |
|
811 | - case $this->config->get( 'WBQualityConstraintsWikibaseItemId' ): |
|
810 | + switch ($itemId->getSerialization()) { |
|
811 | + case $this->config->get('WBQualityConstraintsWikibaseItemId'): |
|
812 | 812 | $entityType = 'item'; |
813 | 813 | break; |
814 | - case $this->config->get( 'WBQualityConstraintsWikibasePropertyId' ): |
|
814 | + case $this->config->get('WBQualityConstraintsWikibasePropertyId'): |
|
815 | 815 | $entityType = 'property'; |
816 | 816 | break; |
817 | - case $this->config->get( 'WBQualityConstraintsWikibaseLexemeId' ): |
|
817 | + case $this->config->get('WBQualityConstraintsWikibaseLexemeId'): |
|
818 | 818 | $entityType = 'lexeme'; |
819 | 819 | break; |
820 | - case $this->config->get( 'WBQualityConstraintsWikibaseFormId' ): |
|
820 | + case $this->config->get('WBQualityConstraintsWikibaseFormId'): |
|
821 | 821 | $entityType = 'form'; |
822 | 822 | break; |
823 | - case $this->config->get( 'WBQualityConstraintsWikibaseSenseId' ): |
|
823 | + case $this->config->get('WBQualityConstraintsWikibaseSenseId'): |
|
824 | 824 | $entityType = 'sense'; |
825 | 825 | break; |
826 | - case $this->config->get( 'WBQualityConstraintsWikibaseMediaInfoId' ): |
|
826 | + case $this->config->get('WBQualityConstraintsWikibaseMediaInfoId'): |
|
827 | 827 | $entityType = 'mediainfo'; |
828 | 828 | break; |
829 | 829 | default: |
830 | 830 | $allowed = [ |
831 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseItemId' ) ), |
|
832 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibasePropertyId' ) ), |
|
833 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseLexemeId' ) ), |
|
834 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseFormId' ) ), |
|
835 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseSenseId' ) ), |
|
836 | - new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseMediaInfoId' ) ), |
|
831 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseItemId')), |
|
832 | + new ItemId($this->config->get('WBQualityConstraintsWikibasePropertyId')), |
|
833 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseLexemeId')), |
|
834 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseFormId')), |
|
835 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseSenseId')), |
|
836 | + new ItemId($this->config->get('WBQualityConstraintsWikibaseMediaInfoId')), |
|
837 | 837 | ]; |
838 | 838 | throw new ConstraintParameterException( |
839 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
840 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
841 | - ->withEntityIdList( $allowed, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
839 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
840 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
841 | + ->withEntityIdList($allowed, Role::CONSTRAINT_PARAMETER_VALUE) |
|
842 | 842 | ); |
843 | 843 | } |
844 | 844 | |
845 | - return new EntityTypesParameter( [ $entityType ], [ $itemId ] ); |
|
845 | + return new EntityTypesParameter([$entityType], [$itemId]); |
|
846 | 846 | } |
847 | 847 | |
848 | 848 | /** |
@@ -851,27 +851,27 @@ discard block |
||
851 | 851 | * @throws ConstraintParameterException if the parameter is invalid or missing |
852 | 852 | * @return EntityTypesParameter |
853 | 853 | */ |
854 | - public function parseEntityTypesParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
854 | + public function parseEntityTypesParameter(array $constraintParameters, $constraintTypeItemId) { |
|
855 | 855 | $entityTypes = []; |
856 | 856 | $entityTypeItemIds = []; |
857 | - $items = $this->parseItemsParameter( $constraintParameters, $constraintTypeItemId, true ); |
|
857 | + $items = $this->parseItemsParameter($constraintParameters, $constraintTypeItemId, true); |
|
858 | 858 | |
859 | - foreach ( $items as $item ) { |
|
860 | - $entityType = $this->parseEntityTypeItem( $item ); |
|
861 | - $entityTypes = array_merge( $entityTypes, $entityType->getEntityTypes() ); |
|
862 | - $entityTypeItemIds = array_merge( $entityTypeItemIds, $entityType->getEntityTypeItemIds() ); |
|
859 | + foreach ($items as $item) { |
|
860 | + $entityType = $this->parseEntityTypeItem($item); |
|
861 | + $entityTypes = array_merge($entityTypes, $entityType->getEntityTypes()); |
|
862 | + $entityTypeItemIds = array_merge($entityTypeItemIds, $entityType->getEntityTypeItemIds()); |
|
863 | 863 | } |
864 | 864 | |
865 | - if ( empty( $entityTypes ) ) { |
|
865 | + if (empty($entityTypes)) { |
|
866 | 866 | // @codeCoverageIgnoreStart |
867 | 867 | throw new LogicException( |
868 | - 'The "entity types" parameter is required, ' . |
|
868 | + 'The "entity types" parameter is required, '. |
|
869 | 869 | 'and yet we seem to be missing any allowed entity type' |
870 | 870 | ); |
871 | 871 | // @codeCoverageIgnoreEnd |
872 | 872 | } |
873 | 873 | |
874 | - return new EntityTypesParameter( $entityTypes, $entityTypeItemIds ); |
|
874 | + return new EntityTypesParameter($entityTypes, $entityTypeItemIds); |
|
875 | 875 | } |
876 | 876 | |
877 | 877 | /** |
@@ -879,18 +879,18 @@ discard block |
||
879 | 879 | * @throws ConstraintParameterException if the parameter is invalid |
880 | 880 | * @return PropertyId[] |
881 | 881 | */ |
882 | - public function parseSeparatorsParameter( array $constraintParameters ) { |
|
883 | - $separatorId = $this->config->get( 'WBQualityConstraintsSeparatorId' ); |
|
882 | + public function parseSeparatorsParameter(array $constraintParameters) { |
|
883 | + $separatorId = $this->config->get('WBQualityConstraintsSeparatorId'); |
|
884 | 884 | |
885 | - if ( !array_key_exists( $separatorId, $constraintParameters ) ) { |
|
885 | + if (!array_key_exists($separatorId, $constraintParameters)) { |
|
886 | 886 | return []; |
887 | 887 | } |
888 | 888 | |
889 | 889 | $parameters = $constraintParameters[$separatorId]; |
890 | 890 | $separators = []; |
891 | 891 | |
892 | - foreach ( $parameters as $parameter ) { |
|
893 | - $separators[] = $this->parsePropertyIdParameter( $parameter, $separatorId ); |
|
892 | + foreach ($parameters as $parameter) { |
|
893 | + $separators[] = $this->parsePropertyIdParameter($parameter, $separatorId); |
|
894 | 894 | } |
895 | 895 | |
896 | 896 | return $separators; |
@@ -905,26 +905,26 @@ discard block |
||
905 | 905 | * @return string one of the Context::TYPE_* constants |
906 | 906 | * @throws ConstraintParameterException |
907 | 907 | */ |
908 | - private function parseContextTypeItem( ItemIdSnakValue $item, $use, $parameterId ) { |
|
909 | - if ( !$item->isValue() ) { |
|
908 | + private function parseContextTypeItem(ItemIdSnakValue $item, $use, $parameterId) { |
|
909 | + if (!$item->isValue()) { |
|
910 | 910 | throw new ConstraintParameterException( |
911 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
912 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
911 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
912 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
913 | 913 | ); |
914 | 914 | } |
915 | 915 | |
916 | - if ( $use === 'constraint scope' ) { |
|
917 | - $mainSnakId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnMainValueId' ); |
|
918 | - $qualifiersId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnQualifiersId' ); |
|
919 | - $referencesId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnReferencesId' ); |
|
916 | + if ($use === 'constraint scope') { |
|
917 | + $mainSnakId = $this->config->get('WBQualityConstraintsConstraintCheckedOnMainValueId'); |
|
918 | + $qualifiersId = $this->config->get('WBQualityConstraintsConstraintCheckedOnQualifiersId'); |
|
919 | + $referencesId = $this->config->get('WBQualityConstraintsConstraintCheckedOnReferencesId'); |
|
920 | 920 | } else { |
921 | - $mainSnakId = $this->config->get( 'WBQualityConstraintsAsMainValueId' ); |
|
922 | - $qualifiersId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' ); |
|
923 | - $referencesId = $this->config->get( 'WBQualityConstraintsAsReferencesId' ); |
|
921 | + $mainSnakId = $this->config->get('WBQualityConstraintsAsMainValueId'); |
|
922 | + $qualifiersId = $this->config->get('WBQualityConstraintsAsQualifiersId'); |
|
923 | + $referencesId = $this->config->get('WBQualityConstraintsAsReferencesId'); |
|
924 | 924 | } |
925 | 925 | |
926 | 926 | $itemId = $item->getItemId(); |
927 | - switch ( $itemId->getSerialization() ) { |
|
927 | + switch ($itemId->getSerialization()) { |
|
928 | 928 | case $mainSnakId: |
929 | 929 | return Context::TYPE_STATEMENT; |
930 | 930 | case $qualifiersId: |
@@ -932,11 +932,11 @@ discard block |
||
932 | 932 | case $referencesId: |
933 | 933 | return Context::TYPE_REFERENCE; |
934 | 934 | default: |
935 | - $allowed = [ $mainSnakId, $qualifiersId, $referencesId ]; |
|
935 | + $allowed = [$mainSnakId, $qualifiersId, $referencesId]; |
|
936 | 936 | throw new ConstraintParameterException( |
937 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
938 | - ->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
939 | - ->withEntityIdList( $allowed, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
937 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
938 | + ->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
939 | + ->withEntityIdList($allowed, Role::CONSTRAINT_PARAMETER_VALUE) |
|
940 | 940 | ); |
941 | 941 | } |
942 | 942 | } |
@@ -947,9 +947,9 @@ discard block |
||
947 | 947 | * @throws ConstraintParameterException if the parameter is invalid or missing |
948 | 948 | * @return string[] list of Context::TYPE_* constants |
949 | 949 | */ |
950 | - public function parsePropertyScopeParameter( array $constraintParameters, $constraintTypeItemId ) { |
|
950 | + public function parsePropertyScopeParameter(array $constraintParameters, $constraintTypeItemId) { |
|
951 | 951 | $contextTypes = []; |
952 | - $parameterId = $this->config->get( 'WBQualityConstraintsPropertyScopeId' ); |
|
952 | + $parameterId = $this->config->get('WBQualityConstraintsPropertyScopeId'); |
|
953 | 953 | $items = $this->parseItemsParameter( |
954 | 954 | $constraintParameters, |
955 | 955 | $constraintTypeItemId, |
@@ -957,14 +957,14 @@ discard block |
||
957 | 957 | $parameterId |
958 | 958 | ); |
959 | 959 | |
960 | - foreach ( $items as $item ) { |
|
961 | - $contextTypes[] = $this->parseContextTypeItem( $item, 'property scope', $parameterId ); |
|
960 | + foreach ($items as $item) { |
|
961 | + $contextTypes[] = $this->parseContextTypeItem($item, 'property scope', $parameterId); |
|
962 | 962 | } |
963 | 963 | |
964 | - if ( empty( $contextTypes ) ) { |
|
964 | + if (empty($contextTypes)) { |
|
965 | 965 | // @codeCoverageIgnoreStart |
966 | 966 | throw new LogicException( |
967 | - 'The "property scope" parameter is required, ' . |
|
967 | + 'The "property scope" parameter is required, '. |
|
968 | 968 | 'and yet we seem to be missing any allowed scope' |
969 | 969 | ); |
970 | 970 | // @codeCoverageIgnoreEnd |