wikimedia / mediawiki-extensions-WikibaseQualityConstraints

includes/ConstraintLookup.php

Spacing +1 added lines, -1 removed lines

@@ -14,6 +14,6 @@
 	 *
 	 * @return Constraint[]
 	 */
-	public function queryConstraintsForProperty( PropertyId $propertyId );
+	public function queryConstraintsForProperty(PropertyId $propertyId);
 
 }

WikibaseQualityConstraints.php

Spacing +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@ 
 <?php
 
-if ( function_exists( 'wfLoadExtension' ) ) {
-	wfLoadExtension( 'WikibaseQualityConstraints', __DIR__ . '/extension.json' );
+if (function_exists('wfLoadExtension')) {
+	wfLoadExtension('WikibaseQualityConstraints', __DIR__.'/extension.json');
 	// Keep i18n globals so mergeMessageFileList.php doesn't break
-	$wgMessagesDirs['WikibaseQualityConstraints'] = __DIR__ . '/i18n';
-	$wgExtensionMessagesFiles['WikibaseQualityConstraintsAlias'] = __DIR__ . '/WikibaseQualityConstraints.alias.php';
+	$wgMessagesDirs['WikibaseQualityConstraints'] = __DIR__.'/i18n';
+	$wgExtensionMessagesFiles['WikibaseQualityConstraintsAlias'] = __DIR__.'/WikibaseQualityConstraints.alias.php';
 	/* wfWarn(
 		'Deprecated PHP entry point used for WikibaseQualityConstraints extension. ' .
 		'Please use wfLoadExtension instead, ' .
@@ -12,5 +12,5 @@ 
 	); */
 	return;
 } else {
-	die( 'This version of the WikibaseQualityConstraints extension requires MediaWiki 1.25+' );
+	die('This version of the WikibaseQualityConstraints extension requires MediaWiki 1.25+');
 }

includes/CachingConstraintLookup.php

Spacing +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
 	/**
 	 * @var ConstraintLookup $lookup The lookup to which all queries are delegated.
 	 */
-	public function __construct( ConstraintLookup $lookup ) {
+	public function __construct(ConstraintLookup $lookup) {
 		$this->lookup = $lookup;
 	}
 
@@ -35,10 +35,10 @@ 
 	 *
 	 * @return Constraint[]
 	 */
-	public function queryConstraintsForProperty( PropertyId $propertyId ) {
+	public function queryConstraintsForProperty(PropertyId $propertyId) {
 		$id = $propertyId->getSerialization();
-		if ( !array_key_exists( $id, $this->cache ) ) {
-			$this->cache[$id] = $this->lookup->queryConstraintsForProperty( $propertyId );
+		if (!array_key_exists($id, $this->cache)) {
+			$this->cache[$id] = $this->lookup->queryConstraintsForProperty($propertyId);
 		}
 		return $this->cache[$id];
 	}

includes/ConstraintCheck/Helper/ValueCountCheckerHelper.php

Spacing +4 added lines, -4 removed lines

@@ -24,14 +24,14 @@
 	 *
 	 * @return int[]
 	 */
-	public function getPropertyCount( StatementList $statements ) {
-		if ( !isset( $this->propertyCount ) ) {
+	public function getPropertyCount(StatementList $statements) {
+		if (!isset($this->propertyCount)) {
 			$this->propertyCount = [];
 
 			/** @var Statement $statement */
-			foreach ( $statements as $statement ) {
+			foreach ($statements as $statement) {
 				$counter = $statement->getRank() === Statement::RANK_DEPRECATED ? 0 : 1;
-				if ( array_key_exists( $statement->getPropertyId()->getSerialization(), $this->propertyCount ) ) {
+				if (array_key_exists($statement->getPropertyId()->getSerialization(), $this->propertyCount)) {
 					$this->propertyCount[$statement->getPropertyId()->getSerialization()] += $counter;
 				} else {
 					$this->propertyCount[$statement->getPropertyId()->getSerialization()] = $counter;

includes/ConstraintCheck/Helper/ConstraintParameterException.php

Spacing +2 added lines, -2 removed lines

@@ -16,8 +16,8 @@
 	/**
 	 * @param string $message HTML
 	 */
-	public function __construct( $message ) {
-		parent::__construct( $message );
+	public function __construct($message) {
+		parent::__construct($message);
 	}
 
 }

includes/ConstraintCheck/Helper/SparqlHelperException.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
 class SparqlHelperException extends RuntimeException {
 
 	public function __construct() {
-		parent::__construct( 'The SPARQL query endpoint returned an error.' );
+		parent::__construct('The SPARQL query endpoint returned an error.');
 	}
 
 }

WikibaseQualityConstraints.alias.php

Spacing +1 added lines, -1 removed lines

@@ -10,5 +10,5 @@
 
 /** English (English) */
 $specialPageAliases['en'] = [
-	'ConstraintReport' => [ 'ConstraintReport', 'Constraint Report' ],
+	'ConstraintReport' => ['ConstraintReport', 'Constraint Report'],
 ];

api/CheckConstraintParameters.php

Spacing +50 added lines, -50 removed lines

@@ -59,10 +59,10 @@ 
 	 *
 	 * @return self
 	 */
-	public static function newFromGlobalState( ApiMain $main, $name, $prefix = '' ) {
+	public static function newFromGlobalState(ApiMain $main, $name, $prefix = '') {
 		$constraintReportFactory = ConstraintReportFactory::getDefaultInstance();
 		$repo = WikibaseRepo::getDefaultInstance();
-		$helperFactory = $repo->getApiHelperFactory( RequestContext::getMain() );
+		$helperFactory = $repo->getApiHelperFactory(RequestContext::getMain());
 		return new self(
 			$main,
 			$name,
@@ -89,53 +89,53 @@ 
 		DelegatingConstraintChecker $delegatingConstraintChecker,
 		StatementGuidParser $statementGuidParser
 	) {
-		parent::__construct( $main, $name, $prefix );
+		parent::__construct($main, $name, $prefix);
 
-		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->delegatingConstraintChecker = $delegatingConstraintChecker;
 		$this->statementGuidParser = $statementGuidParser;
 	}
 
 	public function execute() {
 		MediaWikiServices::getInstance()->getStatsdDataFactory()
-			->increment( 'wikibase.quality.constraints.api.checkConstraintParameters.execute' );
+			->increment('wikibase.quality.constraints.api.checkConstraintParameters.execute');
 
 		$params = $this->extractRequestParams();
 		$result = $this->getResult();
 
-		$propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] );
-		$constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] );
+		$propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]);
+		$constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]);
 
-		$this->checkPropertyIds( $propertyIds, $result );
-		$this->checkConstraintIds( $constraintIds, $result );
+		$this->checkPropertyIds($propertyIds, $result);
+		$this->checkConstraintIds($constraintIds, $result);
 
-		$result->addValue( null, 'success', 1 );
+		$result->addValue(null, 'success', 1);
 	}
 
 	/**
 	 * @param array|null $propertyIdSerializations
 	 * @return PropertyId[]
 	 */
-	private function parsePropertyIds( $propertyIdSerializations ) {
-		if ( $propertyIdSerializations === null ) {
+	private function parsePropertyIds($propertyIdSerializations) {
+		if ($propertyIdSerializations === null) {
 			return [];
-		} elseif ( empty( $propertyIdSerializations ) ) {
+		} elseif (empty($propertyIdSerializations)) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function( $propertyIdSerialization ) {
+			function($propertyIdSerialization) {
 				try {
-					return new PropertyId( $propertyIdSerialization );
-				} catch ( InvalidArgumentException $e ) {
+					return new PropertyId($propertyIdSerialization);
+				} catch (InvalidArgumentException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid id: $propertyIdSerialization",
 						'invalid-property-id',
 						0, // default argument
-						[ self::PARAM_PROPERTY_ID => $propertyIdSerialization ]
+						[self::PARAM_PROPERTY_ID => $propertyIdSerialization]
 					);
 				}
 			},
@@ -147,35 +147,35 @@ 
 	 * @param array|null $constraintIds
 	 * @return string[]
 	 */
-	private function parseConstraintIds( $constraintIds ) {
-		if ( $constraintIds === null ) {
+	private function parseConstraintIds($constraintIds) {
+		if ($constraintIds === null) {
 			return [];
-		} elseif ( empty( $constraintIds ) ) {
+		} elseif (empty($constraintIds)) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function( $constraintId ) {
+			function($constraintId) {
 				try {
-					$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-					if ( !$propertyId instanceof PropertyId ) {
+					$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+					if (!$propertyId instanceof PropertyId) {
 						$this->apiErrorReporter->dieError(
 							"Invalid property ID: {$propertyId->getSerialization()}",
 							'invalid-property-id',
 							0, // default argument
-							[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+							[self::PARAM_CONSTRAINT_ID => $constraintId]
 						);
 					}
 					return $constraintId;
-				} catch ( StatementGuidParsingException $e ) {
+				} catch (StatementGuidParsingException $e) {
 					$this->apiErrorReporter->dieError(
 						"Invalid statement GUID: $constraintId",
 						'invalid-guid',
 						0, // default argument
-						[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+						[self::PARAM_CONSTRAINT_ID => $constraintId]
 					);
 				}
 			},
@@ -187,12 +187,12 @@ 
 	 * @param PropertyId[] $propertyIds
 	 * @param ApiResult $result
 	 */
-	private function checkPropertyIds( array $propertyIds, ApiResult $result ) {
-		foreach ( $propertyIds as $propertyId ) {
-			$result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' );
-			$allConstraintExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnPropertyId( $propertyId );
-			foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) {
-				$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+	private function checkPropertyIds(array $propertyIds, ApiResult $result) {
+		foreach ($propertyIds as $propertyId) {
+			$result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc');
+			$allConstraintExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnPropertyId($propertyId);
+			foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) {
+				$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 			}
 		}
 	}
@@ -201,14 +201,14 @@ 
 	 * @param string[] $constraintIds
 	 * @param ApiResult $result
 	 */
-	private function checkConstraintIds( array $constraintIds, ApiResult $result ) {
-		foreach ( $constraintIds as $constraintId ) {
-			if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) {
+	private function checkConstraintIds(array $constraintIds, ApiResult $result) {
+		foreach ($constraintIds as $constraintId) {
+			if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) {
 				// already checked as part of checkPropertyIds()
 				continue;
 			}
-			$constraintParameterExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnConstraintId( $constraintId );
-			$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+			$constraintParameterExceptions = $this->delegatingConstraintChecker->checkConstraintParametersOnConstraintId($constraintId);
+			$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 		}
 	}
 
@@ -216,17 +216,17 @@ 
 	 * @param PropertyId $propertyId
 	 * @return string[]
 	 */
-	private function getResultPathForPropertyId( PropertyId $propertyId ) {
-		return [ $this->getModuleName(), $propertyId->getSerialization() ];
+	private function getResultPathForPropertyId(PropertyId $propertyId) {
+		return [$this->getModuleName(), $propertyId->getSerialization()];
 	}
 
 	/**
 	 * @param string $constraintId
 	 * @return string[]
 	 */
-	private function getResultPathForConstraintId( $constraintId ) {
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-		return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] );
+	private function getResultPathForConstraintId($constraintId) {
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+		return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]);
 	}
 
 	/**
@@ -236,9 +236,9 @@ 
 	 * @param ConstraintParameterException[]|null $constraintParameterExceptions
 	 * @param ApiResult $result
 	 */
-	private function addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, ApiResult $result ) {
-		$path = $this->getResultPathForConstraintId( $constraintId );
-		if ( $constraintParameterExceptions === null ) {
+	private function addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, ApiResult $result) {
+		$path = $this->getResultPathForConstraintId($constraintId);
+		if ($constraintParameterExceptions === null) {
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
@@ -248,12 +248,12 @@ 
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
-				empty( $constraintParameterExceptions ) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY
+				empty($constraintParameterExceptions) ? self::STATUS_OKAY : self::STATUS_NOT_OKAY
 			);
 			$result->addValue(
 				$path,
 				self::KEY_PROBLEMS,
-				array_map( [ $this, 'formatConstraintParameterException' ], $constraintParameterExceptions )
+				array_map([$this, 'formatConstraintParameterException'], $constraintParameterExceptions)
 			);
 		}
 	}
@@ -264,7 +264,7 @@ 
 	 * @param ConstraintParameterException $e
 	 * @return array
 	 */
-	private function formatConstraintParameterException( ConstraintParameterException $e ) {
+	private function formatConstraintParameterException(ConstraintParameterException $e) {
 		return [
 			self::KEY_MESSAGE_HTML => $e->getMessage(),
 		];

includes/ConstraintParameterRenderer.php

Spacing +85 added lines, -85 removed lines

@@ -60,20 +60,20 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatValue( $value ) {
-		if ( is_string( $value ) ) {
+	public function formatValue($value) {
+		if (is_string($value)) {
 			// Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as
 			// strings
-			return htmlspecialchars( $value );
-		} elseif ( $value instanceof EntityId ) {
+			return htmlspecialchars($value);
+		} elseif ($value instanceof EntityId) {
 			// Cases like 'Conflicts with' 'property', to which we can link
-			return $this->formatEntityId( $value );
-		} elseif ( $value instanceof ItemIdSnakValue ) {
+			return $this->formatEntityId($value);
+		} elseif ($value instanceof ItemIdSnakValue) {
 			// Cases like EntityId but can also be somevalue or novalue
-			return $this->formatItemIdSnakValue( $value );
+			return $this->formatItemIdSnakValue($value);
 		} else {
 			// Cases where we format a DataValue
-			return $this->formatDataValue( $value );
+			return $this->formatDataValue($value);
 		}
 	}
 
@@ -84,23 +84,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatParameters( $parameters ) {
-		if ( $parameters === null || count( $parameters ) == 0 ) {
+	public function formatParameters($parameters) {
+		if ($parameters === null || count($parameters) == 0) {
 			return null;
 		}
 
-		$valueFormatter = function ( $value ) {
-			return $this->formatValue( $value );
+		$valueFormatter = function($value) {
+			return $this->formatValue($value);
 		};
 
 		$formattedParameters = [];
-		foreach ( $parameters as $parameterName => $parameterValue ) {
-			$formattedParameterValues = implode( ', ',
-				$this->limitArrayLength( array_map( $valueFormatter, $parameterValue ) ) );
-			$formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues );
+		foreach ($parameters as $parameterName => $parameterValue) {
+			$formattedParameterValues = implode(', ',
+				$this->limitArrayLength(array_map($valueFormatter, $parameterValue)));
+			$formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues);
 		}
 
-		return implode( '; ', $formattedParameters );
+		return implode('; ', $formattedParameters);
 	}
 
 	/**
@@ -110,10 +110,10 @@ 
 	 *
 	 * @return array
 	 */
-	private function limitArrayLength( array $array ) {
-		if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) {
-			$array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH );
-			array_push( $array, '...' );
+	private function limitArrayLength(array $array) {
+		if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) {
+			$array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH);
+			array_push($array, '...');
 		}
 
 		return $array;
@@ -126,12 +126,12 @@ 
 	 * @param string $value HTML
 	 * @return string HTML
 	 */
-	public static function formatByRole( $role, $value ) {
-		if ( $role === null ) {
+	public static function formatByRole($role, $value) {
+		if ($role === null) {
 			return $value;
 		}
 
-		return '<span class="wbqc-role wbqc-role-' . htmlspecialchars( $role ) . '">'
+		return '<span class="wbqc-role wbqc-role-'.htmlspecialchars($role).'">'
 			. $value
 			. '</span>';
 	}
@@ -141,9 +141,9 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatDataValue( DataValue $value, $role = null ) {
-		return self::formatByRole( $role,
-			$this->dataValueFormatter->format( $value ) );
+	public function formatDataValue(DataValue $value, $role = null) {
+		return self::formatByRole($role,
+			$this->dataValueFormatter->format($value));
 	}
 
 	/**
@@ -151,9 +151,9 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatEntityId( EntityId $entityId, $role = null ) {
-		return self::formatByRole( $role,
-			$this->entityIdLabelFormatter->formatEntityId( $entityId ) );
+	public function formatEntityId(EntityId $entityId, $role = null) {
+		return self::formatByRole($role,
+			$this->entityIdLabelFormatter->formatEntityId($entityId));
 	}
 
 	/**
@@ -165,18 +165,18 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatPropertyId( $propertyId, $role = null ) {
-		if ( $propertyId instanceof PropertyId ) {
-			return $this->formatEntityId( $propertyId, $role );
-		} elseif ( is_string( $propertyId ) ) {
+	public function formatPropertyId($propertyId, $role = null) {
+		if ($propertyId instanceof PropertyId) {
+			return $this->formatEntityId($propertyId, $role);
+		} elseif (is_string($propertyId)) {
 			try {
-				return $this->formatEntityId( new PropertyId( $propertyId ), $role );
-			} catch ( InvalidArgumentException $e ) {
-				return self::formatByRole( $role,
-					htmlspecialchars( $propertyId ) );
+				return $this->formatEntityId(new PropertyId($propertyId), $role);
+			} catch (InvalidArgumentException $e) {
+				return self::formatByRole($role,
+					htmlspecialchars($propertyId));
 			}
 		} else {
-			throw new InvalidArgumentException( '$propertyId must be either PropertyId or string' );
+			throw new InvalidArgumentException('$propertyId must be either PropertyId or string');
 		}
 	}
 
@@ -189,18 +189,18 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatItemId( $itemId, $role = null ) {
-		if ( $itemId instanceof ItemId ) {
-			return $this->formatEntityId( $itemId, $role );
-		} elseif ( is_string( $itemId ) ) {
+	public function formatItemId($itemId, $role = null) {
+		if ($itemId instanceof ItemId) {
+			return $this->formatEntityId($itemId, $role);
+		} elseif (is_string($itemId)) {
 			try {
-				return $this->formatEntityId( new ItemId( $itemId ), $role );
-			} catch ( InvalidArgumentException $e ) {
-				return self::formatByRole( $role,
-					htmlspecialchars( $itemId ) );
+				return $this->formatEntityId(new ItemId($itemId), $role);
+			} catch (InvalidArgumentException $e) {
+				return self::formatByRole($role,
+					htmlspecialchars($itemId));
 			}
 		} else {
-			throw new InvalidArgumentException( '$itemId must be either ItemId or string' );
+			throw new InvalidArgumentException('$itemId must be either ItemId or string');
 		}
 	}
 
@@ -211,20 +211,20 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string HTML
 	 */
-	public function formatItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
-		switch ( true ) {
+	public function formatItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
+		switch (true) {
 			case $value->isValue():
-				return $this->formatEntityId( $value->getItemId(), $role );
+				return $this->formatEntityId($value->getItemId(), $role);
 			case $value->isSomeValue():
-				return self::formatByRole( $role,
+				return self::formatByRole($role,
 					'<span class="wikibase-snakview-variation-somevaluesnak">'
-						. wfMessage( 'wikibase-snakview-snaktypeselector-somevalue' )->escaped()
-						. '</span>' );
+						. wfMessage('wikibase-snakview-snaktypeselector-somevalue')->escaped()
+						. '</span>');
 			case $value->isNoValue():
-				return self::formatByRole( $role,
+				return self::formatByRole($role,
 					'<span class="wikibase-snakview-variation-novaluesnak">'
-						. wfMessage( 'wikibase-snakview-snaktypeselector-novalue' )->escaped()
-						. '</span>' );
+						. wfMessage('wikibase-snakview-snaktypeselector-novalue')->escaped()
+						. '</span>');
 		}
 	}
 
@@ -238,15 +238,15 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatPropertyIdList( array $propertyIds, $role = null ) {
-		if ( empty( $propertyIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatPropertyIdList(array $propertyIds, $role = null) {
+		if (empty($propertyIds)) {
+			return ['<ul></ul>'];
 		}
-		$propertyIds = $this->limitArrayLength( $propertyIds );
-		$formattedPropertyIds = array_map( [ $this, "formatPropertyId" ], $propertyIds, array_fill( 0, count( $propertyIds ), $role ) );
+		$propertyIds = $this->limitArrayLength($propertyIds);
+		$formattedPropertyIds = array_map([$this, "formatPropertyId"], $propertyIds, array_fill(0, count($propertyIds), $role));
 		array_unshift(
 			$formattedPropertyIds,
-			'<ul><li>' . implode( '</li><li>', $formattedPropertyIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedPropertyIds).'</li></ul>'
 		);
 		return $formattedPropertyIds;
 	}
@@ -261,15 +261,15 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatItemIdList( array $itemIds, $role = null ) {
-		if ( empty( $itemIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatItemIdList(array $itemIds, $role = null) {
+		if (empty($itemIds)) {
+			return ['<ul></ul>'];
 		}
-		$itemIds = $this->limitArrayLength( $itemIds );
-		$formattedItemIds = array_map( [ $this, "formatItemId" ], $itemIds, array_fill( 0, count( $itemIds ), $role ) );
+		$itemIds = $this->limitArrayLength($itemIds);
+		$formattedItemIds = array_map([$this, "formatItemId"], $itemIds, array_fill(0, count($itemIds), $role));
 		array_unshift(
 			$formattedItemIds,
-			'<ul><li>' . implode( '</li><li>', $formattedItemIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedItemIds).'</li></ul>'
 		);
 		return $formattedItemIds;
 	}
@@ -284,23 +284,23 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatEntityIdList( array $entityIds, $role = null ) {
-		if ( empty( $entityIds ) ) {
-			return [ '<ul></ul>' ];
+	public function formatEntityIdList(array $entityIds, $role = null) {
+		if (empty($entityIds)) {
+			return ['<ul></ul>'];
 		}
 		$formattedEntityIds = [];
-		foreach ( $entityIds as $entityId ) {
-			if ( count( $formattedEntityIds ) >= self::MAX_PARAMETER_ARRAY_LENGTH ) {
+		foreach ($entityIds as $entityId) {
+			if (count($formattedEntityIds) >= self::MAX_PARAMETER_ARRAY_LENGTH) {
 				$formattedEntityIds[] = '...';
 				break;
 			}
-			if ( $entityId !== null ) {
-				$formattedEntityIds[] = $this->formatEntityId( $entityId, $role );
+			if ($entityId !== null) {
+				$formattedEntityIds[] = $this->formatEntityId($entityId, $role);
 			}
 		}
 		array_unshift(
 			$formattedEntityIds,
-			'<ul><li>' . implode( '</li><li>', $formattedEntityIds ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedEntityIds).'</li></ul>'
 		);
 		return $formattedEntityIds;
 	}
@@ -315,24 +315,24 @@ 
 	 * @param string|null $role one of the Role constants or null
 	 * @return string[] HTML
 	 */
-	public function formatItemIdSnakValueList( array $values, $role = null ) {
-		if ( empty( $values ) ) {
-			return [ '<ul></ul>' ];
+	public function formatItemIdSnakValueList(array $values, $role = null) {
+		if (empty($values)) {
+			return ['<ul></ul>'];
 		}
-		$values = $this->limitArrayLength( $values );
+		$values = $this->limitArrayLength($values);
 		$formattedValues = array_map(
-			function( $value ) use ( $role ) {
-				if ( $value === '...' ) {
+			function($value) use ($role) {
+				if ($value === '...') {
 					return '...';
 				} else {
-					return $this->formatItemIdSnakValue( $value, $role );
+					return $this->formatItemIdSnakValue($value, $role);
 				}
 			},
 			$values
 		);
 		array_unshift(
 			$formattedValues,
-			'<ul><li>' . implode( '</li><li>', $formattedValues ) . '</li></ul>'
+			'<ul><li>'.implode('</li><li>', $formattedValues).'</li></ul>'
 		);
 		return $formattedValues;
 	}