wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Message/ViolationMessage.php

Spacing +35 added lines, -35 removed lines

@@ -122,17 +122,17 @@ 
 	public function __construct(
 		$messageKey
 	) {
-		if ( strpos( $messageKey, self::MESSAGE_KEY_PREFIX ) !== 0 ) {
+		if (strpos($messageKey, self::MESSAGE_KEY_PREFIX) !== 0) {
 			throw new InvalidArgumentException(
-				'ViolationMessage key ⧼' .
-				$messageKey .
-				'⧽ should start with "' .
-				self::MESSAGE_KEY_PREFIX .
+				'ViolationMessage key ⧼'.
+				$messageKey.
+				'⧽ should start with "'.
+				self::MESSAGE_KEY_PREFIX.
 				'".'
 			);
 		}
 
-		$this->messageKeySuffix = substr( $messageKey, strlen( self::MESSAGE_KEY_PREFIX ) );
+		$this->messageKeySuffix = substr($messageKey, strlen(self::MESSAGE_KEY_PREFIX));
 		$this->arguments = [];
 	}
 
@@ -141,7 +141,7 @@ 
 	 * @return string
 	 */
 	public function getMessageKey() {
-		return self::MESSAGE_KEY_PREFIX . $this->messageKeySuffix;
+		return self::MESSAGE_KEY_PREFIX.$this->messageKeySuffix;
 	}
 
 	/**
@@ -161,9 +161,9 @@ 
 	 * @param mixed $value the value, which should match the $type
 	 * @return ViolationMessage
 	 */
-	public function withArgument( $type, $role, $value ) {
+	public function withArgument($type, $role, $value) {
 		$ret = clone $this;
-		$ret->arguments[] = [ 'type' => $type, 'role' => $role, 'value' => $value ];
+		$ret->arguments[] = ['type' => $type, 'role' => $role, 'value' => $value];
 		return $ret;
 	}
 
@@ -175,8 +175,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withEntityId( EntityId $entityId, $role = null ) {
-		return $this->withArgument( self::TYPE_ENTITY_ID, $role, $entityId );
+	public function withEntityId(EntityId $entityId, $role = null) {
+		return $this->withArgument(self::TYPE_ENTITY_ID, $role, $entityId);
 	}
 
 	/**
@@ -193,8 +193,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withEntityIdList( array $entityIdList, $role = null ) {
-		return $this->withArgument( self::TYPE_ENTITY_ID_LIST, $role, $entityIdList );
+	public function withEntityIdList(array $entityIdList, $role = null) {
+		return $this->withArgument(self::TYPE_ENTITY_ID_LIST, $role, $entityIdList);
 	}
 
 	/**
@@ -205,8 +205,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withItemIdSnakValue( ItemIdSnakValue $value, $role = null ) {
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value );
+	public function withItemIdSnakValue(ItemIdSnakValue $value, $role = null) {
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value);
 	}
 
 	/**
@@ -223,8 +223,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withItemIdSnakValueList( array $valueList, $role = null ) {
-		return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList );
+	public function withItemIdSnakValueList(array $valueList, $role = null) {
+		return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList);
 	}
 
 	/**
@@ -235,8 +235,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withDataValue( DataValue $dataValue, $role = null ) {
-		return $this->withArgument( self::TYPE_DATA_VALUE, $role, $dataValue );
+	public function withDataValue(DataValue $dataValue, $role = null) {
+		return $this->withArgument(self::TYPE_DATA_VALUE, $role, $dataValue);
 	}
 
 	/**
@@ -251,8 +251,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withDataValueType( $dataValueType, $role = null ) {
-		return $this->withArgument( self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType );
+	public function withDataValueType($dataValueType, $role = null) {
+		return $this->withArgument(self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType);
 	}
 
 	/**
@@ -263,8 +263,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withInlineCode( $code, $role = null ) {
-		return $this->withArgument( self::TYPE_INLINE_CODE, $role, $code );
+	public function withInlineCode($code, $role = null) {
+		return $this->withArgument(self::TYPE_INLINE_CODE, $role, $code);
 	}
 
 	/**
@@ -275,8 +275,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withConstraintScope( $scope, $role = null ) {
-		return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE, $role, $scope );
+	public function withConstraintScope($scope, $role = null) {
+		return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE, $role, $scope);
 	}
 
 	/**
@@ -287,8 +287,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withConstraintScopeList( array $scopeList, $role = null ) {
-		return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList );
+	public function withConstraintScopeList(array $scopeList, $role = null) {
+		return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList);
 	}
 
 	/**
@@ -299,8 +299,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withPropertyScope( $scope, $role = null ) {
-		return $this->withArgument( self::TYPE_PROPERTY_SCOPE, $role, $scope );
+	public function withPropertyScope($scope, $role = null) {
+		return $this->withArgument(self::TYPE_PROPERTY_SCOPE, $role, $scope);
 	}
 
 	/**
@@ -311,8 +311,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withPropertyScopeList( array $scopeList, $role = null ) {
-		return $this->withArgument( self::TYPE_PROPERTY_SCOPE_LIST, $role, $scopeList );
+	public function withPropertyScopeList(array $scopeList, $role = null) {
+		return $this->withArgument(self::TYPE_PROPERTY_SCOPE_LIST, $role, $scopeList);
 	}
 
 	/**
@@ -327,8 +327,8 @@ 
 	 * @param string $languageCode
 	 * @return ViolationMessage
 	 */
-	public function withLanguage( $languageCode ) {
-		return $this->withArgument( self::TYPE_LANGUAGE, null, $languageCode );
+	public function withLanguage($languageCode) {
+		return $this->withArgument(self::TYPE_LANGUAGE, null, $languageCode);
 	}
 
 	/**
@@ -343,8 +343,8 @@ 
 	 * @param string|null $role one of the Role::* constants
 	 * @return ViolationMessage
 	 */
-	public function withMultilingualText( MultilingualTextValue $text, $role = null ) {
-		return $this->withArgument( self::TYPE_MULTILINGUAL_TEXT, $role, $text );
+	public function withMultilingualText(MultilingualTextValue $text, $role = null) {
+		return $this->withArgument(self::TYPE_MULTILINGUAL_TEXT, $role, $text);
 	}
 
 }

src/ConstraintCheck/Message/ViolationMessageSerializer.php

Spacing +28 added lines, -28 removed lines

@@ -19,26 +19,26 @@ 
  */
 class ViolationMessageSerializer implements Serializer {
 
-	private function abbreviateViolationMessageKey( $fullMessageKey ) {
-		return substr( $fullMessageKey, strlen( ViolationMessage::MESSAGE_KEY_PREFIX ) );
+	private function abbreviateViolationMessageKey($fullMessageKey) {
+		return substr($fullMessageKey, strlen(ViolationMessage::MESSAGE_KEY_PREFIX));
 	}
 
 	/**
 	 * @param ViolationMessage $object
 	 * @return array
 	 */
-	public function serialize( $object ) {
+	public function serialize($object) {
 		/** @var ViolationMessage $object */
-		Assert::parameterType( ViolationMessage::class, $object, '$object' );
+		Assert::parameterType(ViolationMessage::class, $object, '$object');
 
 		$arguments = $object->getArguments();
 		$serializedArguments = [];
-		foreach ( $arguments as $argument ) {
-			$serializedArguments[] = $this->serializeArgument( $argument );
+		foreach ($arguments as $argument) {
+			$serializedArguments[] = $this->serializeArgument($argument);
 		}
 
 		return [
-			'k' => $this->abbreviateViolationMessageKey( $object->getMessageKey() ),
+			'k' => $this->abbreviateViolationMessageKey($object->getMessageKey()),
 			'a' => $serializedArguments,
 		];
 	}
@@ -47,7 +47,7 @@ 
 	 * @param array $argument element of ViolationMessage::getArguments()
 	 * @return array [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ]
 	 */
-	private function serializeArgument( array $argument ) {
+	private function serializeArgument(array $argument) {
 		$methods = [
 			ViolationMessage::TYPE_ENTITY_ID => 'serializeEntityId',
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'serializeEntityIdList',
@@ -68,12 +68,12 @@ 
 		$value = $argument['value'];
 		$role = $argument['role'];
 
-		if ( array_key_exists( $type, $methods ) ) {
+		if (array_key_exists($type, $methods)) {
 			$method = $methods[$type];
-			$serializedValue = $this->$method( $value );
+			$serializedValue = $this->$method($value);
 		} else {
 			throw new InvalidArgumentException(
-				'Unknown ViolationMessage argument type ' . $type . '!'
+				'Unknown ViolationMessage argument type '.$type.'!'
 			);
 		}
 
@@ -90,8 +90,8 @@ 
 	 * @param string $string any value that shall simply be serialized to itself
 	 * @return string that same value, unchanged
 	 */
-	private function serializeStringByIdentity( $string ) {
-		Assert::parameterType( 'string', $string, '$string' );
+	private function serializeStringByIdentity($string) {
+		Assert::parameterType('string', $string, '$string');
 		return $string;
 	}
 
@@ -99,7 +99,7 @@ 
 	 * @param EntityId $entityId
 	 * @return string entity ID serialization
 	 */
-	private function serializeEntityId( EntityId $entityId ) {
+	private function serializeEntityId(EntityId $entityId) {
 		return $entityId->getSerialization();
 	}
 
@@ -107,8 +107,8 @@ 
 	 * @param EntityId[] $entityIdList
 	 * @return string[] entity ID serializations
 	 */
-	private function serializeEntityIdList( array $entityIdList ) {
-		return array_map( [ $this, 'serializeEntityId' ], $entityIdList );
+	private function serializeEntityIdList(array $entityIdList) {
+		return array_map([$this, 'serializeEntityId'], $entityIdList);
 	}
 
 	/**
@@ -116,10 +116,10 @@ 
 	 * @return string entity ID serialization, '::somevalue', or '::novalue'
 	 * (according to EntityId::PATTERN, entity ID serializations can never begin with two colons)
 	 */
-	private function serializeItemIdSnakValue( ItemIdSnakValue $value ) {
-		switch ( true ) {
+	private function serializeItemIdSnakValue(ItemIdSnakValue $value) {
+		switch (true) {
 			case $value->isValue():
-				return $this->serializeEntityId( $value->getItemId() );
+				return $this->serializeEntityId($value->getItemId());
 			case $value->isSomeValue():
 				return '::somevalue';
 			case $value->isNoValue():
@@ -137,15 +137,15 @@ 
 	 * @param ItemIdSnakValue[] $valueList
 	 * @return string[] array of entity ID serializations, '::somevalue's or '::novalue's
 	 */
-	private function serializeItemIdSnakValueList( array $valueList ) {
-		return array_map( [ $this, 'serializeItemIdSnakValue' ], $valueList );
+	private function serializeItemIdSnakValueList(array $valueList) {
+		return array_map([$this, 'serializeItemIdSnakValue'], $valueList);
 	}
 
 	/**
 	 * @param DataValue $dataValue
 	 * @return array the data value in array form
 	 */
-	private function serializeDataValue( DataValue $dataValue ) {
+	private function serializeDataValue(DataValue $dataValue) {
 		return $dataValue->toArray();
 	}
 
@@ -153,8 +153,8 @@ 
 	 * @param string $contextType one of the Context::TYPE_* constants
 	 * @return string the abbreviated context type
 	 */
-	private function serializeContextType( $contextType ) {
-		switch ( $contextType ) {
+	private function serializeContextType($contextType) {
+		switch ($contextType) {
 			case Context::TYPE_STATEMENT:
 				return 's';
 			case Context::TYPE_QUALIFIER:
@@ -164,7 +164,7 @@ 
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
-					'Unknown context type ' . $contextType
+					'Unknown context type '.$contextType
 				);
 				// @codeCoverageIgnoreEnd
 		}
@@ -174,15 +174,15 @@ 
 	 * @param string[] $contextTypeList Context::TYPE_* constants
 	 * @return string[] abbreviated context types
 	 */
-	private function serializeContextTypeList( array $contextTypeList ) {
-		return array_map( [ $this, 'serializeContextType' ], $contextTypeList );
+	private function serializeContextTypeList(array $contextTypeList) {
+		return array_map([$this, 'serializeContextType'], $contextTypeList);
 	}
 
 	/**
 	 * @param MultilingualTextValue $text
 	 * @return mixed {@see MultilingualTextValue::getArrayValue}
 	 */
-	private function serializeMultilingualText( MultilingualTextValue $text ) {
+	private function serializeMultilingualText(MultilingualTextValue $text) {
 		return $text->getArrayValue();
 	}
 

src/ConstraintParameterRenderer.php

Spacing +30 added lines, -30 removed lines

@@ -71,20 +71,20 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatValue( $value ) {
-		if ( is_string( $value ) ) {
+	public function formatValue($value) {
+		if (is_string($value)) {
 			// Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as
 			// strings
-			return htmlspecialchars( $value );
-		} elseif ( $value instanceof EntityId ) {
+			return htmlspecialchars($value);
+		} elseif ($value instanceof EntityId) {
 			// Cases like 'Conflicts with' 'property', to which we can link
-			return $this->formatEntityId( $value );
-		} elseif ( $value instanceof ItemIdSnakValue ) {
+			return $this->formatEntityId($value);
+		} elseif ($value instanceof ItemIdSnakValue) {
 			// Cases like EntityId but can also be somevalue or novalue
-			return $this->formatItemIdSnakValue( $value );
+			return $this->formatItemIdSnakValue($value);
 		} else {
 			// Cases where we format a DataValue
-			return $this->formatDataValue( $value );
+			return $this->formatDataValue($value);
 		}
 	}
 
@@ -95,23 +95,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatParameters( $parameters ) {
-		if ( $parameters === null || $parameters === [] ) {
+	public function formatParameters($parameters) {
+		if ($parameters === null || $parameters === []) {
 			return null;
 		}
 
-		$valueFormatter = function ( $value ) {
-			return $this->formatValue( $value );
+		$valueFormatter = function($value) {
+			return $this->formatValue($value);
 		};
 
 		$formattedParameters = [];
-		foreach ( $parameters as $parameterName => $parameterValue ) {
-			$formattedParameterValues = implode( ', ',
-				$this->limitArrayLength( array_map( $valueFormatter, $parameterValue ) ) );
-			$formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues );
+		foreach ($parameters as $parameterName => $parameterValue) {
+			$formattedParameterValues = implode(', ',
+				$this->limitArrayLength(array_map($valueFormatter, $parameterValue)));
+			$formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues);
 		}
 
-		return implode( '; ', $formattedParameters );
+		return implode('; ', $formattedParameters);
 	}
 
 	/**
@@ -121,10 +121,10 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function limitArrayLength( array $array ) {
-		if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) {
-			$array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH );
-			array_push( $array, '...' );
+	private function limitArrayLength(array $array) {
+		if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) {
+			$array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH);
+			array_push($array, '...');
 		}
 
 		return $array;
@@ -134,16 +134,16 @@ 
 	 * @param DataValue $value
 	 * @return string HTML
 	 */
-	public function formatDataValue( DataValue $value ) {
-		return $this->dataValueFormatter->format( $value );
+	public function formatDataValue(DataValue $value) {
+		return $this->dataValueFormatter->format($value);
 	}
 
 	/**
 	 * @param EntityId $entityId
 	 * @return string HTML
 	 */
-	public function formatEntityId( EntityId $entityId ) {
-		return $this->entityIdLabelFormatter->formatEntityId( $entityId );
+	public function formatEntityId(EntityId $entityId) {
+		return $this->entityIdLabelFormatter->formatEntityId($entityId);
 	}
 
 	/**
@@ -152,17 +152,17 @@ 
 	 * @param ItemIdSnakValue $value
 	 * @return string HTML
 	 */
-	public function formatItemIdSnakValue( ItemIdSnakValue $value ) {
-		switch ( true ) {
+	public function formatItemIdSnakValue(ItemIdSnakValue $value) {
+		switch (true) {
 			case $value->isValue():
-				return $this->formatEntityId( $value->getItemId() );
+				return $this->formatEntityId($value->getItemId());
 			case $value->isSomeValue():
 				return $this->messageLocalizer
-					->msg( 'wikibase-snakview-snaktypeselector-somevalue' )
+					->msg('wikibase-snakview-snaktypeselector-somevalue')
 					->escaped();
 			case $value->isNoValue():
 				return $this->messageLocalizer
-					->msg( 'wikibase-snakview-snaktypeselector-novalue' )
+					->msg('wikibase-snakview-snaktypeselector-novalue')
 					->escaped();
 		}
 	}

src/Api/ExpiryLock.php

Spacing +17 added lines, -17 removed lines

@@ -26,7 +26,7 @@ 
 	/**
 	 * @param BagOStuff $cache
 	 */
-	public function __construct( BagOStuff $cache ) {
+	public function __construct(BagOStuff $cache) {
 		$this->cache = $cache;
 	}
 
@@ -37,17 +37,17 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function makeKey( $id ) {
-		if ( empty( trim( $id ) ) ) {
-			throw new ParameterTypeException( '$id', 'non-empty string' );
+	private function makeKey($id) {
+		if (empty(trim($id))) {
+			throw new ParameterTypeException('$id', 'non-empty string');
 		}
 
-		Assert::parameterType( 'string', $id, '$id' );
+		Assert::parameterType('string', $id, '$id');
 
 		return $this->cache->makeKey(
 			'WikibaseQualityConstraints',
 			'ExpiryLock',
-			(string)$id
+			(string) $id
 		);
 	}
 
@@ -59,11 +59,11 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function lock( $id, ConvertibleTimestamp $expiryTimestamp ) {
+	public function lock($id, ConvertibleTimestamp $expiryTimestamp) {
 
-		$cacheId = $this->makeKey( $id );
+		$cacheId = $this->makeKey($id);
 
-		if ( !$this->isLockedInternal( $cacheId ) ) {
+		if (!$this->isLockedInternal($cacheId)) {
 			return $this->cache->set(
 				$cacheId,
 				$expiryTimestamp->getTimestamp(),
@@ -81,20 +81,20 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	private function isLockedInternal( $cacheId ) {
-		$expiryTime = $this->cache->get( $cacheId );
-		if ( !$expiryTime ) {
+	private function isLockedInternal($cacheId) {
+		$expiryTime = $this->cache->get($cacheId);
+		if (!$expiryTime) {
 			return false;
 		}
 
 		try {
-			$lockExpiryTimeStamp = new ConvertibleTimestamp( $expiryTime );
-		} catch ( TimestampException $exception ) {
+			$lockExpiryTimeStamp = new ConvertibleTimestamp($expiryTime);
+		} catch (TimestampException $exception) {
 			return false;
 		}
 
 		$now = new ConvertibleTimestamp();
-		if ( $now->timestamp < $lockExpiryTimeStamp->timestamp ) {
+		if ($now->timestamp < $lockExpiryTimeStamp->timestamp) {
 			return true;
 		} else {
 			return false;
@@ -108,8 +108,8 @@ 
 	 *
 	 * @throws \Wikimedia\Assert\ParameterTypeException
 	 */
-	public function isLocked( $id ) {
-		return $this->isLockedInternal( $this->makeKey( $id ) );
+	public function isLocked($id) {
+		return $this->isLockedInternal($this->makeKey($id));
 	}
 
 }

src/ConstraintCheck/Helper/TooManySparqlRequestsException.php

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 class TooManySparqlRequestsException extends SparqlHelperException {
 
 	public function __construct() {
-		parent::__construct( 'The SPARQL query endpoint reports too many requests.' );
+		parent::__construct('The SPARQL query endpoint reports too many requests.');
 	}
 
 }

src/ConstraintCheck/Helper/SparqlHelperException.php

Spacing +2 added lines, -2 removed lines

@@ -9,8 +9,8 @@
  */
 class SparqlHelperException extends RuntimeException {
 
-	public function __construct( $msg = 'The SPARQL query endpoint returned an error.' ) {
-		parent::__construct( $msg );
+	public function __construct($msg = 'The SPARQL query endpoint returned an error.') {
+		parent::__construct($msg);
 	}
 
 }

src/ConstraintCheck/Helper/DummySparqlHelper.php

Spacing +8 added lines, -8 removed lines

@@ -22,15 +22,15 @@ 
 		// no parent::__construct() call
 	}
 
-	public function hasType( $id, array $classes ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function hasType($id, array $classes) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameStatement(
 		Statement $statement,
 		$ignoreDeprecatedStatements
 	) {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameQualifierOrReference(
@@ -39,15 +39,15 @@ 
 		$type,
 		$ignoreDeprecatedStatements
 	) {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function matchesRegularExpression( $text, $regex ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function matchesRegularExpression($text, $regex) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function runQuery( $query, $needsPrefixes = true ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function runQuery($query, $needsPrefixes = true) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 }

src/Html/HtmlTableBuilder.php

Spacing +33 added lines, -33 removed lines

@@ -32,9 +32,9 @@ 
 	/**
 	 * @param array $headers
 	 */
-	public function __construct( array $headers ) {
-		foreach ( $headers as $header ) {
-			$this->addHeader( $header );
+	public function __construct(array $headers) {
+		foreach ($headers as $header) {
+			$this->addHeader($header);
 		}
 	}
 
@@ -43,16 +43,16 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function addHeader( $header ) {
-		Assert::parameterType( 'string|' . HtmlTableHeaderBuilder::class, $header, '$header' );
+	private function addHeader($header) {
+		Assert::parameterType('string|'.HtmlTableHeaderBuilder::class, $header, '$header');
 
-		if ( is_string( $header ) ) {
-			$header = new HtmlTableHeaderBuilder( $header );
+		if (is_string($header)) {
+			$header = new HtmlTableHeaderBuilder($header);
 		}
 
 		$this->headers[] = $header;
 
-		if ( $header->getIsSortable() ) {
+		if ($header->getIsSortable()) {
 			$this->isSortable = true;
 		}
 	}
@@ -85,12 +85,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function appendRow( array $cells ) {
-		foreach ( $cells as $key => $cell ) {
-			if ( is_string( $cell ) ) {
-				$cells[$key] = new HtmlTableCellBuilder( $cell );
-			} elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) {
-				throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' );
+	public function appendRow(array $cells) {
+		foreach ($cells as $key => $cell) {
+			if (is_string($cell)) {
+				$cells[$key] = new HtmlTableCellBuilder($cell);
+			} elseif (!($cell instanceof HtmlTableCellBuilder)) {
+				throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.');
 			}
 		}
 
@@ -104,13 +104,13 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function appendRows( array $rows ) {
-		foreach ( $rows as $cells ) {
-			if ( !is_array( $cells ) ) {
-				throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' );
+	public function appendRows(array $rows) {
+		foreach ($rows as $cells) {
+			if (!is_array($cells)) {
+				throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.');
 			}
 
-			$this->appendRow( $cells );
+			$this->appendRow($cells);
 		}
 	}
 
@@ -122,38 +122,38 @@ 
 	public function toHtml() {
 		// Open table
 		$tableClasses = 'wikitable';
-		if ( $this->isSortable ) {
+		if ($this->isSortable) {
 			$tableClasses .= ' sortable';
 		}
-		$html = Html::openElement( 'table', [ 'class' => $tableClasses ] );
+		$html = Html::openElement('table', ['class' => $tableClasses]);
 
 		// Write headers
-		$html .= Html::openElement( 'thead' );
-		$html .= Html::openElement( 'tr' );
-		foreach ( $this->headers as $header ) {
+		$html .= Html::openElement('thead');
+		$html .= Html::openElement('tr');
+		foreach ($this->headers as $header) {
 			$html .= $header->toHtml();
 		}
-		$html .= Html::closeElement( 'tr' );
-		$html .= Html::closeElement( 'thead' );
-		$html .= Html::openElement( 'tbody' );
+		$html .= Html::closeElement('tr');
+		$html .= Html::closeElement('thead');
+		$html .= Html::openElement('tbody');
 
 		// Write rows
-		foreach ( $this->rows as $row ) {
-			$html .= Html::openElement( 'tr' );
+		foreach ($this->rows as $row) {
+			$html .= Html::openElement('tr');
 
 			/**
 			 * @var HtmlTableCellBuilder $cell
 			 */
-			foreach ( $row as $cell ) {
+			foreach ($row as $cell) {
 				$html .= $cell->toHtml();
 			}
 
-			$html .= Html::closeElement( 'tr' );
+			$html .= Html::closeElement('tr');
 		}
 
 		// Close table
-		$html .= Html::closeElement( 'tbody' );
-		$html .= Html::closeElement( 'table' );
+		$html .= Html::closeElement('tbody');
+		$html .= Html::closeElement('table');
 
 		return $html;
 	}

src/ConstraintCheck/Checker/NoneOfChecker.php

Spacing +11 added lines, -11 removed lines

@@ -60,9 +60,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -81,20 +81,20 @@ 
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-					->withItemIdSnakValueList( $items, Role::OBJECT );
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+					->withItemIdSnakValueList($items, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -104,7 +104,7 @@ 
 				$constraintTypeItemId,
 				true
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;