wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintsServices.php

Spacing +25 added lines, -25 removed lines

@@ -38,90 +38,90 @@
 	const RESULTS_SOURCE = 'WBQC_ResultsSource';
 	const EXPIRY_LOCK = 'WBQC_ExpiryLock';
 
-	private static function getService( MediaWikiServices $services = null, $name ) {
-		if ( $services === null ) {
+	private static function getService(MediaWikiServices $services = null, $name) {
+		if ($services === null) {
 			$services = MediaWikiServices::getInstance();
 		}
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
-	public static function getLoggingHelper( MediaWikiServices $services = null ): LoggingHelper {
-		return self::getService( $services, self::LOGGING_HELPER );
+	public static function getLoggingHelper(MediaWikiServices $services = null): LoggingHelper {
+		return self::getService($services, self::LOGGING_HELPER);
 	}
 
 	public static function getConstraintRepository(
 		MediaWikiServices $services = null
 	): ConstraintRepository {
-		return self::getService( $services, self::CONSTRAINT_REPOSITORY );
+		return self::getService($services, self::CONSTRAINT_REPOSITORY);
 	}
 
-	public static function getConstraintLookup( MediaWikiServices $services = null ): ConstraintLookup {
-		return self::getService( $services, self::CONSTRAINT_LOOKUP );
+	public static function getConstraintLookup(MediaWikiServices $services = null): ConstraintLookup {
+		return self::getService($services, self::CONSTRAINT_LOOKUP);
 	}
 
 	public static function getCheckResultSerializer(
 		MediaWikiServices $services = null
 	): CheckResultSerializer {
-		return self::getService( $services, self::CHECK_RESULT_SERIALIZER );
+		return self::getService($services, self::CHECK_RESULT_SERIALIZER);
 	}
 
 	public static function getCheckResultDeserializer(
 		MediaWikiServices $services = null
 	): CheckResultDeserializer {
-		return self::getService( $services, self::CHECK_RESULT_DESERIALIZER );
+		return self::getService($services, self::CHECK_RESULT_DESERIALIZER);
 	}
 
 	public static function getViolationMessageSerializer(
 		MediaWikiServices $services = null
 	): ViolationMessageSerializer {
-		return self::getService( $services, self::VIOLATION_MESSAGE_SERIALIZER );
+		return self::getService($services, self::VIOLATION_MESSAGE_SERIALIZER);
 	}
 
 	public static function getViolationMessageDeserializer(
 		MediaWikiServices $services = null
 	): ViolationMessageDeserializer {
-		return self::getService( $services, self::VIOLATION_MESSAGE_DESERIALIZER );
+		return self::getService($services, self::VIOLATION_MESSAGE_DESERIALIZER);
 	}
 
 	public static function getConstraintParameterParser(
 		MediaWikiServices $services = null
 	): ConstraintParameterParser {
-		return self::getService( $services, self::CONSTRAINT_PARAMETER_PARSER );
+		return self::getService($services, self::CONSTRAINT_PARAMETER_PARSER);
 	}
 
 	public static function getConnectionCheckerHelper(
 		MediaWikiServices $services = null
 	): ConnectionCheckerHelper {
-		return self::getService( $services, self::CONNECTION_CHECKER_HELPER );
+		return self::getService($services, self::CONNECTION_CHECKER_HELPER);
 	}
 
-	public static function getRangeCheckerHelper( MediaWikiServices $services = null ): RangeCheckerHelper {
-		return self::getService( $services, self::RANGE_CHECKER_HELPER );
+	public static function getRangeCheckerHelper(MediaWikiServices $services = null): RangeCheckerHelper {
+		return self::getService($services, self::RANGE_CHECKER_HELPER);
 	}
 
-	public static function getSparqlHelper( MediaWikiServices $services = null ): SparqlHelper {
-		return self::getService( $services, self::SPARQL_HELPER );
+	public static function getSparqlHelper(MediaWikiServices $services = null): SparqlHelper {
+		return self::getService($services, self::SPARQL_HELPER);
 	}
 
-	public static function getTypeCheckerHelper( MediaWikiServices $services = null ): TypeCheckerHelper {
-		return self::getService( $services, self::TYPE_CHECKER_HELPER );
+	public static function getTypeCheckerHelper(MediaWikiServices $services = null): TypeCheckerHelper {
+		return self::getService($services, self::TYPE_CHECKER_HELPER);
 	}
 
 	public static function getDelegatingConstraintChecker(
 		MediaWikiServices $services = null
 	): DelegatingConstraintChecker {
-		return self::getService( $services, self::DELEGATING_CONSTRAINT_CHECKER );
+		return self::getService($services, self::DELEGATING_CONSTRAINT_CHECKER);
 	}
 
-	public static function getResultsSource( MediaWikiServices $services = null ): ResultsSource {
-		return self::getService( $services, self::RESULTS_SOURCE );
+	public static function getResultsSource(MediaWikiServices $services = null): ResultsSource {
+		return self::getService($services, self::RESULTS_SOURCE);
 	}
 
 	/**
 	 * @return ExpiryLock
 	 */
-	public static function getExpiryLock( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::EXPIRY_LOCK );
+	public static function getExpiryLock(MediaWikiServices $services = null) {
+		return self::getService($services, self::EXPIRY_LOCK);
 	}
 
 }

src/ConstraintCheck/Helper/LoggingHelper.php

Doc Comments +2 added lines

@@ -65,6 +65,7 @@ 
 	 * and return it along with the associated log level.
 	 *
 	 * @param float $durationSeconds
+	 * @param double[] $limits
 	 * @return array [ $limitSeconds, $logLevel ]
 	 */
 	private function findLimit( $limits, $durationSeconds ) {
@@ -174,6 +175,7 @@ 
 	 * @param EntityId $entityId
 	 * @param CheckResult[] $checkResults
 	 * @param float $durationSeconds
+	 * @param string $method
 	 */
 	public function logConstraintCheckOnEntity(
 		EntityId $entityId,

Spacing +35 added lines, -35 removed lines

@@ -53,12 +53,12 @@ 
 		$this->dataFactory = $dataFactory;
 		$this->logger = $logger;
 		$this->constraintCheckDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'),
 		];
 		$this->constraintCheckOnEntityDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckOnEntityDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckOnEntityDurationWarningSeconds'),
 		];
 	}
 
@@ -69,23 +69,23 @@ 
 	 * @param float $durationSeconds
 	 * @return array [ $limitSeconds, $logLevel ]
 	 */
-	private function findLimit( $limits, $durationSeconds ) {
+	private function findLimit($limits, $durationSeconds) {
 		$limitSeconds = null;
 		$logLevel = null;
 
-		foreach ( $limits as $level => $limit ) {
+		foreach ($limits as $level => $limit) {
 			if (
 				// duration exceeds this limit
-				isset( $limit ) && $durationSeconds > $limit &&
+				isset($limit) && $durationSeconds > $limit &&
 				// this limit is longer than previous longest limit
-				( $limitSeconds === null || $limit > $limitSeconds )
+				($limitSeconds === null || $limit > $limitSeconds)
 			) {
 				$limitSeconds = $limit;
 				$logLevel = $level;
 			}
 		}
 
-		return [ $limitSeconds, $logLevel ];
+		return [$limitSeconds, $logLevel];
 	}
 
 	/**
@@ -110,31 +110,31 @@ 
 		$durationSeconds,
 		$method
 	) {
-		$constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 );
+		$constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1);
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
 		$this->dataFactory->timing(
-			'wikibase.quality.constraints.check.timing.' .
-				$constraintTypeItemId . '-' .
+			'wikibase.quality.constraints.check.timing.'.
+				$constraintTypeItemId.'-'.
 				$constraintCheckerClassShortName,
 			$durationSeconds * 1000
 		);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		list( $limitSeconds, $logLevel ) = $this->findLimit(
+		list($limitSeconds, $logLevel) = $this->findLimit(
 			$this->constraintCheckDurationLimits,
 			$durationSeconds
 		);
-		if ( $limitSeconds === null ) {
+		if ($limitSeconds === null) {
 			return;
 		}
-		if ( $context->getType() !== Context::TYPE_STATEMENT ) {
+		if ($context->getType() !== Context::TYPE_STATEMENT) {
 			// TODO log less details but still log something
 			return;
 		}
 
 		$resultMessage = $result->getMessage();
-		if ( $resultMessage !== null ) {
+		if ($resultMessage !== null) {
 			$resultMessageKey = $resultMessage->getMessageKey();
 		} else {
 			$resultMessageKey = null;
@@ -142,8 +142,8 @@ 
 
 		$this->logger->log(
 			$logLevel,
-			'Constraint check with {constraintCheckerClassShortName} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Constraint check with {constraintCheckerClassShortName} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -153,13 +153,13 @@ 
 				'constraintId' => $constraint->getConstraintId(),
 				'constraintPropertyId' => $constraint->getPropertyId()->getSerialization(),
 				'constraintTypeItemId' => $constraintTypeItemId,
-				'constraintParameters' => json_encode( $constraint->getConstraintParameters() ),
+				'constraintParameters' => json_encode($constraint->getConstraintParameters()),
 				'constraintCheckerClass' => $constraintCheckerClass,
 				'constraintCheckerClassShortName' => $constraintCheckerClassShortName,
 				'entityId' => $context->getEntity()->getId()->getSerialization(),
 				'statementGuid' => $context->getSnakStatement()->getGuid(),
 				'resultStatus' => $result->getStatus(),
-				'resultParameters' => json_encode( $result->getParameters() ),
+				'resultParameters' => json_encode($result->getParameters()),
 				'resultMessage' => $resultMessageKey,
 			]
 		);
@@ -189,18 +189,18 @@ 
 		);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		list( $limitSeconds, $logLevel ) = $this->findLimit(
+		list($limitSeconds, $logLevel) = $this->findLimit(
 			$this->constraintCheckOnEntityDurationLimits,
 			$durationSeconds
 		);
-		if ( $limitSeconds === null ) {
+		if ($limitSeconds === null) {
 			return;
 		}
 
 		$this->logger->log(
 			$logLevel,
-			'Full constraint check on {entityId} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Full constraint check on {entityId} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -218,7 +218,7 @@ 
 	 *
 	 * @param EntityId $entityId
 	 */
-	public function logCheckConstraintsCacheHit( EntityId $entityId ) {
+	public function logCheckConstraintsCacheHit(EntityId $entityId) {
 		$this->dataFactory->increment(
 			'wikibase.quality.constraints.cache.entity.hit'
 		);
@@ -229,10 +229,10 @@ 
 	 *
 	 * @param EntityId[] $entityIds
 	 */
-	public function logCheckConstraintsCacheMisses( array $entityIds ) {
+	public function logCheckConstraintsCacheMisses(array $entityIds) {
 		$this->dataFactory->updateCount(
 			'wikibase.quality.constraints.cache.entity.miss',
-			count( $entityIds )
+			count($entityIds)
 		);
 	}
 
@@ -259,17 +259,17 @@ 
 	 * @param EntityId[] $entityIds
 	 * @param int $maxRevisionIds
 	 */
-	public function logHugeDependencyMetadata( array $entityIds, $maxRevisionIds ) {
+	public function logHugeDependencyMetadata(array $entityIds, $maxRevisionIds) {
 		$this->logger->log(
 			'warning',
-			'Dependency metadata for constraint check result has huge set of entity IDs ' .
-			'(count ' . count( $entityIds ) . ', limit ' . $maxRevisionIds . '); ' .
+			'Dependency metadata for constraint check result has huge set of entity IDs '.
+			'(count '.count($entityIds).', limit '.$maxRevisionIds.'); '.
 			'caching disabled for this check result.',
 			[
 				'loggingMethod' => __METHOD__,
 				'entityIds' => json_encode(
 					array_map(
-						function ( EntityId $entityId ) {
+						function(EntityId $entityId) {
 							return $entityId->getSerialization();
 						},
 						$entityIds
@@ -280,22 +280,22 @@ 
 		);
 	}
 
-	public function logSparqlHelperTooManyRequestsRetryAfterPresent( ConvertibleTimestamp $retryAfterTime, MWHttpRequest $request ) {
+	public function logSparqlHelperTooManyRequestsRetryAfterPresent(ConvertibleTimestamp $retryAfterTime, MWHttpRequest $request) {
 		$this->logger->notice(
 			'Sparql API replied with status 429 and a retry-after header. Requesting to retry after {retryAfterTime}',
 			[
 				'retryAfterTime' => $retryAfterTime,
-				'responseHeaders' => json_encode( $request->getResponseHeaders() ),
+				'responseHeaders' => json_encode($request->getResponseHeaders()),
 				'responseContent' => $request->getContent(),
 			]
 		);
 	}
 
-	public function logSparqlHelperTooManyRequestsRetryAfterInvalid( MWHttpRequest $request ) {
+	public function logSparqlHelperTooManyRequestsRetryAfterInvalid(MWHttpRequest $request) {
 		$this->logger->warning(
 			'Sparql API replied with status 429 and no valid retry-after header.',
 			[
-				'responseHeaders' => json_encode( $request->getResponseHeaders() ),
+				'responseHeaders' => json_encode($request->getResponseHeaders()),
 				'responseContent' => $request->getContent(),
 			]
 		);

src/ConstraintCheck/Helper/TooManySparqlRequestsException.php

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 class TooManySparqlRequestsException extends SparqlHelperException {
 
 	public function __construct() {
-		parent::__construct( 'The SPARQL query endpoint reports too many requests.' );
+		parent::__construct('The SPARQL query endpoint reports too many requests.');
 	}
 
 }

src/ConstraintCheck/Helper/SparqlHelperException.php

Spacing +2 added lines, -2 removed lines

@@ -9,8 +9,8 @@
  */
 class SparqlHelperException extends RuntimeException {
 
-	public function __construct( $msg = 'The SPARQL query endpoint returned an error.' ) {
-		parent::__construct( $msg );
+	public function __construct($msg = 'The SPARQL query endpoint returned an error.') {
+		parent::__construct($msg);
 	}
 
 }

src/ServiceWiring.php

Spacing +103 added lines, -103 removed lines

@@ -27,28 +27,28 @@ 
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResultSerializer;
 
 return [
-	ConstraintsServices::EXPIRY_LOCK => function( MediaWikiServices $services ) {
-		return new ExpiryLock( ObjectCache::getInstance( CACHE_ANYTHING ) );
+	ConstraintsServices::EXPIRY_LOCK => function(MediaWikiServices $services) {
+		return new ExpiryLock(ObjectCache::getInstance(CACHE_ANYTHING));
 	},
 
-	ConstraintsServices::LOGGING_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::LOGGING_HELPER => function(MediaWikiServices $services) {
 		return new LoggingHelper(
 			$services->getStatsdDataFactory(),
-			LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+			LoggerFactory::getInstance('WikibaseQualityConstraints'),
 			$services->getMainConfig()
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_REPOSITORY => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONSTRAINT_REPOSITORY => function(MediaWikiServices $services) {
 		return new ConstraintRepository();
 	},
 
-	ConstraintsServices::CONSTRAINT_LOOKUP => function( MediaWikiServices $services ) {
-		$constraintRepository = ConstraintsServices::getConstraintRepository( $services );
-		return new CachingConstraintLookup( $constraintRepository );
+	ConstraintsServices::CONSTRAINT_LOOKUP => function(MediaWikiServices $services) {
+		$constraintRepository = ConstraintsServices::getConstraintRepository($services);
+		return new CachingConstraintLookup($constraintRepository);
 	},
 
-	ConstraintsServices::CHECK_RESULT_SERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CHECK_RESULT_SERIALIZER => function(MediaWikiServices $services) {
 		return new CheckResultSerializer(
 			new ConstraintSerializer(
 				false // constraint parameters are not exposed
@@ -59,7 +59,7 @@ 
 		);
 	},
 
-	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CHECK_RESULT_DESERIALIZER => function(MediaWikiServices $services) {
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$entityIdParser = $repo->getEntityIdParser();
@@ -76,11 +76,11 @@ 
 		);
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_SERIALIZER => function(MediaWikiServices $services) {
 		return new ViolationMessageSerializer();
 	},
 
-	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function( MediaWikiServices $services ) {
+	ConstraintsServices::VIOLATION_MESSAGE_DESERIALIZER => function(MediaWikiServices $services) {
 		// TODO in the future, get EntityIdParser and DataValueFactory from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$entityIdParser = $repo->getEntityIdParser();
@@ -92,7 +92,7 @@ 
 		);
 	},
 
-	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONSTRAINT_PARAMETER_PARSER => function(MediaWikiServices $services) {
 		// TODO in the future, get DeserializerFactory and concept base URIs from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$deserializerFactory = $repo->getBaseDataModelDeserializerFactory();
@@ -105,11 +105,11 @@ 
 		);
 	},
 
-	ConstraintsServices::CONNECTION_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::CONNECTION_CHECKER_HELPER => function(MediaWikiServices $services) {
 		return new ConnectionCheckerHelper();
 	},
 
-	ConstraintsServices::RANGE_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::RANGE_CHECKER_HELPER => function(MediaWikiServices $services) {
 		// TODO in the future, get UnitConverter from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$unitConverter = $repo->getUnitConverter();
@@ -120,9 +120,9 @@ 
 		);
 	},
 
-	ConstraintsServices::SPARQL_HELPER => function( MediaWikiServices $services ) {
-		$endpoint = $services->getMainConfig()->get( 'WBQualityConstraintsSparqlEndpoint' );
-		if ( $endpoint === '' ) {
+	ConstraintsServices::SPARQL_HELPER => function(MediaWikiServices $services) {
+		$endpoint = $services->getMainConfig()->get('WBQualityConstraintsSparqlEndpoint');
+		if ($endpoint === '') {
 			return new DummySparqlHelper();
 		}
 
@@ -138,117 +138,117 @@ 
 			$entityIdParser,
 			$propertyDataTypeLookup,
 			$services->getMainWANObjectCache(),
-			ConstraintsServices::getViolationMessageSerializer( $services ),
-			ConstraintsServices::getViolationMessageDeserializer( $services ),
+			ConstraintsServices::getViolationMessageSerializer($services),
+			ConstraintsServices::getViolationMessageDeserializer($services),
 			$services->getStatsdDataFactory(),
-			ConstraintsServices::getExpiryLock( $services ),
+			ConstraintsServices::getExpiryLock($services),
 			ConstraintsServices::getLoggingHelper(),
-			wfWikiID() . ' WikibaseQualityConstraints ' . Http::userAgent(),
+			wfWikiID().' WikibaseQualityConstraints '.Http::userAgent(),
 			$services->getHttpRequestFactory()
 		);
 	},
 
-	ConstraintsServices::TYPE_CHECKER_HELPER => function( MediaWikiServices $services ) {
+	ConstraintsServices::TYPE_CHECKER_HELPER => function(MediaWikiServices $services) {
 		return new TypeCheckerHelper(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$services->getMainConfig(),
-			ConstraintsServices::getSparqlHelper( $services ),
+			ConstraintsServices::getSparqlHelper($services),
 			$services->getStatsdDataFactory()
 		);
 	},
 
-	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function( MediaWikiServices $services ) {
+	ConstraintsServices::DELEGATING_CONSTRAINT_CHECKER => function(MediaWikiServices $services) {
 		// TODO in the future, get StatementGuidParser from $services?
 		$repo = WikibaseRepo::getDefaultInstance();
 		$statementGuidParser = $repo->getStatementGuidParser();
 
 		$config = $services->getMainConfig();
 		$checkerMap = [
-			$config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
-				=> ConstraintCheckerServices::getConflictsWithChecker( $services ),
-			$config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getItemChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
-				=> ConstraintCheckerServices::getTargetRequiredClaimChecker( $services ),
-			$config->get( 'WBQualityConstraintsSymmetricConstraintId' )
-				=> ConstraintCheckerServices::getSymmetricChecker( $services ),
-			$config->get( 'WBQualityConstraintsInverseConstraintId' )
-				=> ConstraintCheckerServices::getInverseChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
-				=> ConstraintCheckerServices::getQualifierChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
-				=> ConstraintCheckerServices::getQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
-				=> ConstraintCheckerServices::getMandatoryQualifiersChecker( $services ),
-			$config->get( 'WBQualityConstraintsRangeConstraintId' )
-				=> ConstraintCheckerServices::getRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
-				=> ConstraintCheckerServices::getDiffWithinRangeChecker( $services ),
-			$config->get( 'WBQualityConstraintsTypeConstraintId' )
-				=> ConstraintCheckerServices::getTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsValueTypeConstraintId' )
-				=> ConstraintCheckerServices::getValueTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsMultiValueConstraintId' )
-				=> ConstraintCheckerServices::getMultiValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
-				=> ConstraintCheckerServices::getUniqueValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsFormatConstraintId' )
-				=> ConstraintCheckerServices::getFormatChecker( $services ),
-			$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
-				=> ConstraintCheckerServices::getCommonsLinkChecker( $services ),
-			$config->get( 'WBQualityConstraintsOneOfConstraintId' )
-				=> ConstraintCheckerServices::getOneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
-				=> ConstraintCheckerServices::getValueOnlyChecker( $services ),
-			$config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
-				=> ConstraintCheckerServices::getReferenceChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
-				=> ConstraintCheckerServices::getNoBoundsChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
-				=> ConstraintCheckerServices::getAllowedUnitsChecker( $services ),
-			$config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
-				=> ConstraintCheckerServices::getSingleBestValueChecker( $services ),
-			$config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
-				=> ConstraintCheckerServices::getEntityTypeChecker( $services ),
-			$config->get( 'WBQualityConstraintsNoneOfConstraintId' )
-				=> ConstraintCheckerServices::getNoneOfChecker( $services ),
-			$config->get( 'WBQualityConstraintsIntegerConstraintId' )
-				=> ConstraintCheckerServices::getIntegerChecker( $services ),
-			$config->get( 'WBQualityConstraintsCitationNeededConstraintId' )
-				=> ConstraintCheckerServices::getCitationNeededChecker( $services ),
-			$config->get( 'WBQualityConstraintsPropertyScopeConstraintId' )
-				=> ConstraintCheckerServices::getPropertyScopeChecker( $services ),
-			$config->get( 'WBQualityConstraintsContemporaryConstraintId' )
-				=> ConstraintCheckerServices::getContemporaryChecker( $services ),
+			$config->get('WBQualityConstraintsConflictsWithConstraintId')
+				=> ConstraintCheckerServices::getConflictsWithChecker($services),
+			$config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getItemChecker($services),
+			$config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
+				=> ConstraintCheckerServices::getTargetRequiredClaimChecker($services),
+			$config->get('WBQualityConstraintsSymmetricConstraintId')
+				=> ConstraintCheckerServices::getSymmetricChecker($services),
+			$config->get('WBQualityConstraintsInverseConstraintId')
+				=> ConstraintCheckerServices::getInverseChecker($services),
+			$config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
+				=> ConstraintCheckerServices::getQualifierChecker($services),
+			$config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
+				=> ConstraintCheckerServices::getQualifiersChecker($services),
+			$config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
+				=> ConstraintCheckerServices::getMandatoryQualifiersChecker($services),
+			$config->get('WBQualityConstraintsRangeConstraintId')
+				=> ConstraintCheckerServices::getRangeChecker($services),
+			$config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
+				=> ConstraintCheckerServices::getDiffWithinRangeChecker($services),
+			$config->get('WBQualityConstraintsTypeConstraintId')
+				=> ConstraintCheckerServices::getTypeChecker($services),
+			$config->get('WBQualityConstraintsValueTypeConstraintId')
+				=> ConstraintCheckerServices::getValueTypeChecker($services),
+			$config->get('WBQualityConstraintsSingleValueConstraintId')
+				=> ConstraintCheckerServices::getSingleValueChecker($services),
+			$config->get('WBQualityConstraintsMultiValueConstraintId')
+				=> ConstraintCheckerServices::getMultiValueChecker($services),
+			$config->get('WBQualityConstraintsDistinctValuesConstraintId')
+				=> ConstraintCheckerServices::getUniqueValueChecker($services),
+			$config->get('WBQualityConstraintsFormatConstraintId')
+				=> ConstraintCheckerServices::getFormatChecker($services),
+			$config->get('WBQualityConstraintsCommonsLinkConstraintId')
+				=> ConstraintCheckerServices::getCommonsLinkChecker($services),
+			$config->get('WBQualityConstraintsOneOfConstraintId')
+				=> ConstraintCheckerServices::getOneOfChecker($services),
+			$config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
+				=> ConstraintCheckerServices::getValueOnlyChecker($services),
+			$config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
+				=> ConstraintCheckerServices::getReferenceChecker($services),
+			$config->get('WBQualityConstraintsNoBoundsConstraintId')
+				=> ConstraintCheckerServices::getNoBoundsChecker($services),
+			$config->get('WBQualityConstraintsAllowedUnitsConstraintId')
+				=> ConstraintCheckerServices::getAllowedUnitsChecker($services),
+			$config->get('WBQualityConstraintsSingleBestValueConstraintId')
+				=> ConstraintCheckerServices::getSingleBestValueChecker($services),
+			$config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
+				=> ConstraintCheckerServices::getEntityTypeChecker($services),
+			$config->get('WBQualityConstraintsNoneOfConstraintId')
+				=> ConstraintCheckerServices::getNoneOfChecker($services),
+			$config->get('WBQualityConstraintsIntegerConstraintId')
+				=> ConstraintCheckerServices::getIntegerChecker($services),
+			$config->get('WBQualityConstraintsCitationNeededConstraintId')
+				=> ConstraintCheckerServices::getCitationNeededChecker($services),
+			$config->get('WBQualityConstraintsPropertyScopeConstraintId')
+				=> ConstraintCheckerServices::getPropertyScopeChecker($services),
+			$config->get('WBQualityConstraintsContemporaryConstraintId')
+				=> ConstraintCheckerServices::getContemporaryChecker($services),
 		];
 
 		return new DelegatingConstraintChecker(
-			WikibaseServices::getEntityLookup( $services ),
+			WikibaseServices::getEntityLookup($services),
 			$checkerMap,
-			ConstraintsServices::getConstraintLookup( $services ),
-			ConstraintsServices::getConstraintParameterParser( $services ),
+			ConstraintsServices::getConstraintLookup($services),
+			ConstraintsServices::getConstraintParameterParser($services),
 			$statementGuidParser,
-			ConstraintsServices::getLoggingHelper( $services ),
-			$config->get( 'WBQualityConstraintsCheckQualifiers' ),
-			$config->get( 'WBQualityConstraintsCheckReferences' ),
-			$config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+			ConstraintsServices::getLoggingHelper($services),
+			$config->get('WBQualityConstraintsCheckQualifiers'),
+			$config->get('WBQualityConstraintsCheckReferences'),
+			$config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 		);
 	},
 
-	ConstraintsServices::RESULTS_SOURCE => function( MediaWikiServices $services ) {
+	ConstraintsServices::RESULTS_SOURCE => function(MediaWikiServices $services) {
 		$config = $services->getMainConfig();
 		$resultsSource = new CheckingResultsSource(
-			ConstraintsServices::getDelegatingConstraintChecker( $services )
+			ConstraintsServices::getDelegatingConstraintChecker($services)
 		);
 
-		if ( $config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) ) {
+		if ($config->get('WBQualityConstraintsCacheCheckConstraintsResults')) {
 			$possiblyStaleConstraintTypes = [
-				$config->get( 'WBQualityConstraintsCommonsLinkConstraintId' ),
-				$config->get( 'WBQualityConstraintsTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsValueTypeConstraintId' ),
-				$config->get( 'WBQualityConstraintsDistinctValuesConstraintId' ),
+				$config->get('WBQualityConstraintsCommonsLinkConstraintId'),
+				$config->get('WBQualityConstraintsTypeConstraintId'),
+				$config->get('WBQualityConstraintsValueTypeConstraintId'),
+				$config->get('WBQualityConstraintsDistinctValuesConstraintId'),
 			];
 			// TODO in the future, get EntityIdParser and WikiPageEntityMetaDataAccessor from $services?
 			$repo = WikibaseRepo::getDefaultInstance();
@@ -258,14 +258,14 @@ 
 			$resultsSource = new CachingResultsSource(
 				$resultsSource,
 				ResultsCache::getDefaultInstance(),
-				ConstraintsServices::getCheckResultSerializer( $services ),
-				ConstraintsServices::getCheckResultDeserializer( $services ),
+				ConstraintsServices::getCheckResultSerializer($services),
+				ConstraintsServices::getCheckResultDeserializer($services),
 				$wikiPageEntityMetaDataAccessor,
 				$entityIdParser,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsTTLSeconds' ),
+				$config->get('WBQualityConstraintsCacheCheckConstraintsTTLSeconds'),
 				$possiblyStaleConstraintTypes,
-				$config->get( 'WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds' ),
-				ConstraintsServices::getLoggingHelper( $services )
+				$config->get('WBQualityConstraintsCacheCheckConstraintsMaximumRevisionIds'),
+				ConstraintsServices::getLoggingHelper($services)
 			);
 		}
 

src/ConstraintCheck/Checker/ContemporaryChecker.php

Spacing +42 added lines, -43 removed lines

@@ -78,7 +78,7 @@ 
 	 * @codeCoverageIgnore This method is purely declarative.
 	 */
 	public function getDefaultContextTypes() {
-		return [ Context::TYPE_STATEMENT ];
+		return [Context::TYPE_STATEMENT];
 	}
 
 	/**
@@ -90,30 +90,30 @@ 
 	 * @return CheckResult
 	 * @throws \ConfigException
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 		$snak = $context->getSnak();
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 		}
-		if ( $snak->getDataValue()->getType() !== 'wikibase-entityid' ) {
+		if ($snak->getDataValue()->getType() !== 'wikibase-entityid') {
 			// wrong data type
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'wikibase-entityid' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('wikibase-entityid');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		/** @var EntityId $objectId */
 		$objectId = $snak->getDataValue()->getEntityId();
-		$objectItem = $this->entityLookup->getEntity( $objectId );
-		if ( !( $objectItem instanceof StatementListProvider ) ) {
+		$objectItem = $this->entityLookup->getEntity($objectId);
+		if (!($objectItem instanceof StatementListProvider)) {
 			// object was deleted/doesn't exist
-			$message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' );
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_VIOLATION, $message );
+			$message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist');
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_VIOLATION, $message);
 		}
 		/** @var Statement[] $objectStatements */
 		$objectStatements = $objectItem->getStatements()->toArray();
@@ -123,9 +123,9 @@ 
 		/** @var Statement[] $subjectStatements */
 		$subjectStatements = $context->getEntity()->getStatements()->toArray();
 		/** @var String[] $startPropertyIds */
-		$startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
+		$startPropertyIds = $this->config->get(self::CONFIG_VARIABLE_START_PROPERTY_IDS);
 		/** @var String[] $endPropertyIds */
-		$endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );
+		$endPropertyIds = $this->config->get(self::CONFIG_VARIABLE_END_PROPERTY_IDS);
 		$subjectStartValue = $this->getExtremeValue(
 			$startPropertyIds,
 			$subjectStatements,
@@ -147,15 +147,15 @@ 
 			'end'
 		);
 		if (
-			$this->rangeCheckerHelper->getComparison( $subjectStartValue, $subjectEndValue ) <= 0 &&
-			$this->rangeCheckerHelper->getComparison( $objectStartValue, $objectEndValue ) <= 0 && (
-				$this->rangeCheckerHelper->getComparison( $subjectEndValue, $objectStartValue ) < 0 ||
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectStartValue ) < 0
+			$this->rangeCheckerHelper->getComparison($subjectStartValue, $subjectEndValue) <= 0 &&
+			$this->rangeCheckerHelper->getComparison($objectStartValue, $objectEndValue) <= 0 && (
+				$this->rangeCheckerHelper->getComparison($subjectEndValue, $objectStartValue) < 0 ||
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectStartValue) < 0
 			)
 		) {
 			if (
 				$subjectEndValue == null ||
-				$this->rangeCheckerHelper->getComparison( $objectEndValue, $subjectEndValue ) < 0
+				$this->rangeCheckerHelper->getComparison($objectEndValue, $subjectEndValue) < 0
 			) {
 				$earlierEntityId = $objectId;
 				$minEndValue = $objectEndValue;
@@ -178,7 +178,7 @@ 
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
-		return new CheckResult( $context, $constraint, [], $status, $message );
+		return new CheckResult($context, $constraint, [], $status, $message);
 	}
 
 	/**
@@ -188,19 +188,19 @@ 
 	 *
 	 * @return DataValue|null
 	 */
-	private function getExtremeValue( $extremePropertyIds, $statements, $startOrEnd ) {
-		if ( $startOrEnd !== 'start' && $startOrEnd !== 'end' ) {
-			throw new \InvalidArgumentException( '$startOrEnd must be \'start\' or \'end\'.' );
+	private function getExtremeValue($extremePropertyIds, $statements, $startOrEnd) {
+		if ($startOrEnd !== 'start' && $startOrEnd !== 'end') {
+			throw new \InvalidArgumentException('$startOrEnd must be \'start\' or \'end\'.');
 		}
 		$extremeValue = null;
-		foreach ( $extremePropertyIds as $extremePropertyId ) {
-			$statementList = new StatementList( $statements );
-			$extremeStatements = $statementList->getByPropertyId( new PropertyId( $extremePropertyId ) );
+		foreach ($extremePropertyIds as $extremePropertyId) {
+			$statementList = new StatementList($statements);
+			$extremeStatements = $statementList->getByPropertyId(new PropertyId($extremePropertyId));
 			/** @var Statement $extremeStatement */
-			foreach ( $extremeStatements as $extremeStatement ) {
-				if ( $extremeStatement->getRank() !== Statement::RANK_DEPRECATED ) {
+			foreach ($extremeStatements as $extremeStatement) {
+				if ($extremeStatement->getRank() !== Statement::RANK_DEPRECATED) {
 					$snak = $extremeStatement->getMainSnak();
-					if ( !$snak instanceof PropertyValueSnak ) {
+					if (!$snak instanceof PropertyValueSnak) {
 						return null;
 					} else {
 						$comparison = $this->rangeCheckerHelper->getComparison(
@@ -209,8 +209,8 @@ 
 						);
 						if (
 							$extremeValue === null ||
-							( $startOrEnd === 'start' && $comparison < 0 ) ||
-							( $startOrEnd === 'end' && $comparison > 0 )
+							($startOrEnd === 'start' && $comparison < 0) ||
+							($startOrEnd === 'end' && $comparison > 0)
 						) {
 							$extremeValue = $snak->getDataValue();
 						}
@@ -240,17 +240,16 @@ 
 		DataValue $maxStartValue
 	) {
 		$messageKey = $earlierEntityId === $subjectId ?
-			'wbqc-violation-message-contemporary-subject-earlier' :
-			'wbqc-violation-message-contemporary-value-earlier';
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $subjectId, Role::SUBJECT )
-			->withEntityId( $propertyId, Role::PREDICATE )
-			->withEntityId( $objectId, Role::OBJECT )
-			->withDataValue( $minEndValue, Role::OBJECT )
-			->withDataValue( $maxStartValue, Role::OBJECT );
+			'wbqc-violation-message-contemporary-subject-earlier' : 'wbqc-violation-message-contemporary-value-earlier';
+		return (new ViolationMessage($messageKey))
+			->withEntityId($subjectId, Role::SUBJECT)
+			->withEntityId($propertyId, Role::PREDICATE)
+			->withEntityId($objectId, Role::OBJECT)
+			->withDataValue($minEndValue, Role::OBJECT)
+			->withDataValue($maxStartValue, Role::OBJECT);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/ConstraintCheck/Helper/DummySparqlHelper.php

Spacing +8 added lines, -8 removed lines

@@ -22,15 +22,15 @@ 
 		// no parent::__construct() call
 	}
 
-	public function hasType( $id, array $classes ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function hasType($id, array $classes) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameStatement(
 		Statement $statement,
 		$ignoreDeprecatedStatements
 	) {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
 	public function findEntitiesWithSameQualifierOrReference(
@@ -39,15 +39,15 @@ 
 		$type,
 		$ignoreDeprecatedStatements
 	) {
-		throw new LogicException( 'methods of this class should never be called' );
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function matchesRegularExpression( $text, $regex ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function matchesRegularExpression($text, $regex) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
-	public function runQuery( $query, $needsPrefixes = true ) {
-		throw new LogicException( 'methods of this class should never be called' );
+	public function runQuery($query, $needsPrefixes = true) {
+		throw new LogicException('methods of this class should never be called');
 	}
 
 }

src/ConstraintCheck/Helper/TypeCheckerHelper.php

Spacing +45 added lines, -45 removed lines

@@ -80,23 +80,23 @@ 
 	 * @return bool
 	 * @throws OverflowException if $entitiesChecked exceeds the configured limit
 	 */
-	private function isSubclassOf( EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0 ) {
-		$maxEntities = $this->config->get( 'WBQualityConstraintsTypeCheckMaxEntities' );
+	private function isSubclassOf(EntityId $comparativeClass, array $classesToCheck, &$entitiesChecked = 0) {
+		$maxEntities = $this->config->get('WBQualityConstraintsTypeCheckMaxEntities');
 		if ( ++$entitiesChecked > $maxEntities ) {
-			throw new OverflowException( 'Too many entities to check' );
+			throw new OverflowException('Too many entities to check');
 		}
 
-		$item = $this->entityLookup->getEntity( $comparativeClass );
-		if ( !( $item instanceof StatementListProvider ) ) {
+		$item = $this->entityLookup->getEntity($comparativeClass);
+		if (!($item instanceof StatementListProvider)) {
 			return false; // lookup failed, probably because item doesn't exist
 		}
 
-		$subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfId' );
+		$subclassId = $this->config->get('WBQualityConstraintsSubclassOfId');
 		/** @var Statement $statement */
-		foreach ( $item->getStatements()->getByPropertyId( new PropertyId( $subclassId ) ) as $statement ) {
+		foreach ($item->getStatements()->getByPropertyId(new PropertyId($subclassId)) as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !( $this->hasCorrectType( $mainSnak ) ) ) {
+			if (!($this->hasCorrectType($mainSnak))) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -105,11 +105,11 @@ 
 			$dataValue = $mainSnak->getDataValue();
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				return true;
 			}
 
-			if ( $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked ) ) {
+			if ($this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked)) {
 				return true;
 			}
 		}
@@ -130,48 +130,48 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function isSubclassOfWithSparqlFallback( EntityId $comparativeClass, array $classesToCheck ) {
+	public function isSubclassOfWithSparqlFallback(EntityId $comparativeClass, array $classesToCheck) {
 		try {
 			$entitiesChecked = 0;
-			$start1 = microtime( true );
-			$isSubclass = $this->isSubclassOf( $comparativeClass, $classesToCheck, $entitiesChecked );
-			$end1 = microtime( true );
+			$start1 = microtime(true);
+			$isSubclass = $this->isSubclassOf($comparativeClass, $classesToCheck, $entitiesChecked);
+			$end1 = microtime(true);
 			$this->dataFactory->timing(
 				'wikibase.quality.constraints.type.php.success.timing',
-				( $end1 - $start1 ) * 1000
+				($end1 - $start1) * 1000
 			);
 			$this->dataFactory->timing( // not really a timing, but works like one (we want percentiles etc.)
 				'wikibase.quality.constraints.type.php.success.entities',
 				$entitiesChecked
 			);
 
-			return new CachedBool( $isSubclass, Metadata::blank() );
-		} catch ( OverflowException $e ) {
-			$end1 = microtime( true );
+			return new CachedBool($isSubclass, Metadata::blank());
+		} catch (OverflowException $e) {
+			$end1 = microtime(true);
 			$this->dataFactory->timing(
 				'wikibase.quality.constraints.type.php.overflow.timing',
-				( $end1 - $start1 ) * 1000
+				($end1 - $start1) * 1000
 			);
 
-			if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
+			if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
 				$this->dataFactory->increment(
 					'wikibase.quality.constraints.sparql.typeFallback'
 				);
 
-				$start2 = microtime( true );
+				$start2 = microtime(true);
 				$hasType = $this->sparqlHelper->hasType(
 					$comparativeClass->getSerialization(),
 					$classesToCheck
 				);
-				$end2 = microtime( true );
+				$end2 = microtime(true);
 				$this->dataFactory->timing(
 					'wikibase.quality.constraints.type.sparql.success.timing',
-					( $end2 - $start2 ) * 1000
+					($end2 - $start2) * 1000
 				);
 
 				return $hasType;
 			} else {
-				return new CachedBool( false, Metadata::blank() );
+				return new CachedBool(false, Metadata::blank());
 			}
 		}
 	}
@@ -189,13 +189,13 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if SPARQL is used and the query times out or some other error occurs
 	 */
-	public function hasClassInRelation( StatementList $statements, array $relationIds, array $classesToCheck ) {
+	public function hasClassInRelation(StatementList $statements, array $relationIds, array $classesToCheck) {
 		$metadatas = [];
 
-		foreach ( $this->getStatementsByPropertyIds( $statements, $relationIds ) as $statement ) {
+		foreach ($this->getStatementsByPropertyIds($statements, $relationIds) as $statement) {
 			$mainSnak = $statement->getMainSnak();
 
-			if ( !$this->hasCorrectType( $mainSnak ) ) {
+			if (!$this->hasCorrectType($mainSnak)) {
 				continue;
 			}
 			/** @var PropertyValueSnak $mainSnak */
@@ -204,28 +204,28 @@ 
 			$dataValue = $mainSnak->getDataValue();
 			$comparativeClass = $dataValue->getEntityId();
 
-			if ( in_array( $comparativeClass->getSerialization(), $classesToCheck ) ) {
+			if (in_array($comparativeClass->getSerialization(), $classesToCheck)) {
 				// discard $metadatas, we know this is fresh
-				return new CachedBool( true, Metadata::blank() );
+				return new CachedBool(true, Metadata::blank());
 			}
 
-			$result = $this->isSubclassOfWithSparqlFallback( $comparativeClass, $classesToCheck );
+			$result = $this->isSubclassOfWithSparqlFallback($comparativeClass, $classesToCheck);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getBool() ) {
+			if ($result->getBool()) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
-	private function hasCorrectType( Snak $mainSnak ) {
+	private function hasCorrectType(Snak $mainSnak) {
 		return $mainSnak instanceof PropertyValueSnak
 			&& $mainSnak->getDataValue()->getType() === 'wikibase-entityid';
 	}
@@ -242,12 +242,12 @@ 
 	) {
 		$statementArrays = [];
 
-		foreach ( $propertyIdSerializations as $propertyIdSerialization ) {
-			$propertyId = new PropertyId( $propertyIdSerialization );
-			$statementArrays[] = $statements->getByPropertyId( $propertyId )->toArray();
+		foreach ($propertyIdSerializations as $propertyIdSerialization) {
+			$propertyId = new PropertyId($propertyIdSerialization);
+			$statementArrays[] = $statements->getByPropertyId($propertyId)->toArray();
 		}
 
-		return call_user_func_array( 'array_merge', $statementArrays );
+		return call_user_func_array('array_merge', $statementArrays);
 	}
 
 	/**
@@ -259,10 +259,10 @@ 
 	 *
 	 * @return ViolationMessage
 	 */
-	public function getViolationMessage( PropertyId $propertyId, EntityId $entityId, array $classes, $checker, $relation ) {
+	public function getViolationMessage(PropertyId $propertyId, EntityId $entityId, array $classes, $checker, $relation) {
 		$classes = array_map(
-			function( $itemIdSerialization ) {
-				return new ItemId( $itemIdSerialization );
+			function($itemIdSerialization) {
+				return new ItemId($itemIdSerialization);
 			},
 			$classes
 		);
@@ -274,10 +274,10 @@ 
 		// wbqc-violation-message-valueType-instance
 		// wbqc-violation-message-valueType-subclass
 		// wbqc-violation-message-valueType-instanceOrSubclass
-		return ( new ViolationMessage( 'wbqc-violation-message-' . $checker . '-' . $relation ) )
-			->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY )
-			->withEntityId( $entityId, Role::SUBJECT )
-			->withEntityIdList( $classes, Role::OBJECT );
+		return (new ViolationMessage('wbqc-violation-message-'.$checker.'-'.$relation))
+			->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY)
+			->withEntityId($entityId, Role::SUBJECT)
+			->withEntityIdList($classes, Role::OBJECT);
 	}
 
 }

src/ServiceWiring-Wikibase.php

Spacing +2 added lines, -2 removed lines

@@ -7,13 +7,13 @@
 use WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ExceptionIgnoringEntityLookup;
 
 return [
-	WikibaseServices::ENTITY_LOOKUP => function( MediaWikiServices $services ) {
+	WikibaseServices::ENTITY_LOOKUP => function(MediaWikiServices $services) {
 		return new ExceptionIgnoringEntityLookup(
 			WikibaseRepo::getDefaultInstance()->getEntityLookup()
 		);
 	},
 
-	WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function( MediaWikiServices $services ) {
+	WikibaseServices::PROPERTY_DATA_TYPE_LOOKUP => function(MediaWikiServices $services) {
 		return WikibaseRepo::getDefaultInstance()->getPropertyDataTypeLookup();
 	},
 ];