wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintParameterRenderer.php

Spacing +30 added lines, -30 removed lines

@@ -71,20 +71,20 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatValue( $value ) {
-		if ( is_string( $value ) ) {
+	public function formatValue($value) {
+		if (is_string($value)) {
 			// Cases like 'Format' 'pattern' or 'minimum'/'maximum' values, which we have stored as
 			// strings
-			return htmlspecialchars( $value );
-		} elseif ( $value instanceof EntityId ) {
+			return htmlspecialchars($value);
+		} elseif ($value instanceof EntityId) {
 			// Cases like 'Conflicts with' 'property', to which we can link
-			return $this->formatEntityId( $value );
-		} elseif ( $value instanceof ItemIdSnakValue ) {
+			return $this->formatEntityId($value);
+		} elseif ($value instanceof ItemIdSnakValue) {
 			// Cases like EntityId but can also be somevalue or novalue
-			return $this->formatItemIdSnakValue( $value );
+			return $this->formatItemIdSnakValue($value);
 		} else {
 			// Cases where we format a DataValue
-			return $this->formatDataValue( $value );
+			return $this->formatDataValue($value);
 		}
 	}
 
@@ -95,23 +95,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	public function formatParameters( $parameters ) {
-		if ( $parameters === null || $parameters === [] ) {
+	public function formatParameters($parameters) {
+		if ($parameters === null || $parameters === []) {
 			return null;
 		}
 
-		$valueFormatter = function ( $value ) {
-			return $this->formatValue( $value );
+		$valueFormatter = function($value) {
+			return $this->formatValue($value);
 		};
 
 		$formattedParameters = [];
-		foreach ( $parameters as $parameterName => $parameterValue ) {
-			$formattedParameterValues = implode( ', ',
-				$this->limitArrayLength( array_map( $valueFormatter, $parameterValue ) ) );
-			$formattedParameters[] = sprintf( '%s: %s', $parameterName, $formattedParameterValues );
+		foreach ($parameters as $parameterName => $parameterValue) {
+			$formattedParameterValues = implode(', ',
+				$this->limitArrayLength(array_map($valueFormatter, $parameterValue)));
+			$formattedParameters[] = sprintf('%s: %s', $parameterName, $formattedParameterValues);
 		}
 
-		return implode( '; ', $formattedParameters );
+		return implode('; ', $formattedParameters);
 	}
 
 	/**
@@ -121,10 +121,10 @@ 
 	 *
 	 * @return string[]
 	 */
-	private function limitArrayLength( array $array ) {
-		if ( count( $array ) > self::MAX_PARAMETER_ARRAY_LENGTH ) {
-			$array = array_slice( $array, 0, self::MAX_PARAMETER_ARRAY_LENGTH );
-			array_push( $array, '...' );
+	private function limitArrayLength(array $array) {
+		if (count($array) > self::MAX_PARAMETER_ARRAY_LENGTH) {
+			$array = array_slice($array, 0, self::MAX_PARAMETER_ARRAY_LENGTH);
+			array_push($array, '...');
 		}
 
 		return $array;
@@ -134,16 +134,16 @@ 
 	 * @param DataValue $value
 	 * @return string HTML
 	 */
-	public function formatDataValue( DataValue $value ) {
-		return $this->dataValueFormatter->format( $value );
+	public function formatDataValue(DataValue $value) {
+		return $this->dataValueFormatter->format($value);
 	}
 
 	/**
 	 * @param EntityId $entityId
 	 * @return string HTML
 	 */
-	public function formatEntityId( EntityId $entityId ) {
-		return $this->entityIdLabelFormatter->formatEntityId( $entityId );
+	public function formatEntityId(EntityId $entityId) {
+		return $this->entityIdLabelFormatter->formatEntityId($entityId);
 	}
 
 	/**
@@ -152,17 +152,17 @@ 
 	 * @param ItemIdSnakValue $value
 	 * @return string HTML
 	 */
-	public function formatItemIdSnakValue( ItemIdSnakValue $value ) {
-		switch ( true ) {
+	public function formatItemIdSnakValue(ItemIdSnakValue $value) {
+		switch (true) {
 			case $value->isValue():
-				return $this->formatEntityId( $value->getItemId() );
+				return $this->formatEntityId($value->getItemId());
 			case $value->isSomeValue():
 				return $this->messageLocalizer
-					->msg( 'wikibase-snakview-snaktypeselector-somevalue' )
+					->msg('wikibase-snakview-snaktypeselector-somevalue')
 					->escaped();
 			case $value->isNoValue():
 				return $this->messageLocalizer
-					->msg( 'wikibase-snakview-snaktypeselector-novalue' )
+					->msg('wikibase-snakview-snaktypeselector-novalue')
 					->escaped();
 		}
 	}

src/ConstraintCheck/Context/EntityContextCursor.php

Spacing +11 added lines, -11 removed lines

@@ -35,7 +35,7 @@ 
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getType() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	public function getEntityId() {
@@ -46,35 +46,35 @@ 
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getStatementPropertyId() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getStatementGuid() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getSnakPropertyId() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
 	public function getSnakHash() {
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
+		throw new LogicException('EntityContextCursor has no full associated context');
 	}
 
 	/**
 	 * @codeCoverageIgnore This method is not supported.
 	 */
-	public function &getMainArray( array &$container ) {
-		throw new LogicException( 'EntityContextCursor cannot store check results' );
+	public function &getMainArray(array &$container) {
+		throw new LogicException('EntityContextCursor cannot store check results');
 	}
 
 	/**
@@ -83,14 +83,14 @@ 
 	 * @param array|null $result must be null
 	 * @param array[] &$container
 	 */
-	public function storeCheckResultInArray( array $result = null, array &$container ) {
-		if ( $result !== null ) {
-			throw new LogicException( 'EntityContextCursor cannot store check results' );
+	public function storeCheckResultInArray(array $result = null, array &$container) {
+		if ($result !== null) {
+			throw new LogicException('EntityContextCursor cannot store check results');
 		}
 
 		// this ensures that the claims array is present in the $container,
 		// populating it if necessary, even though we ignore the return value
-		$this->getClaimsArray( $container );
+		$this->getClaimsArray($container);
 	}
 
 }

maintenance/ImportConstraintStatements.php

Spacing +18 added lines, -18 removed lines

@@ -9,10 +9,10 @@ 
 use Wikibase\Repo\WikibaseRepo;
 
 // @codeCoverageIgnoreStart
-$basePath = getenv( "MW_INSTALL_PATH" ) !== false
-	? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../..";
+$basePath = getenv("MW_INSTALL_PATH") !== false
+	? getenv("MW_INSTALL_PATH") : __DIR__."/../../..";
 
-require_once $basePath . "/maintenance/Maintenance.php";
+require_once $basePath."/maintenance/Maintenance.php";
 // @codeCoverageIgnoreEnd
 
 /**
@@ -38,39 +38,39 @@ 
 
 	public function __construct() {
 		parent::__construct();
-		$this->newUpdateConstraintsTableJob = function ( $propertyIdSerialization ) {
+		$this->newUpdateConstraintsTableJob = function($propertyIdSerialization) {
 			return UpdateConstraintsTableJob::newFromGlobalState(
 				Title::newMainPage(),
-				[ 'propertyId' => $propertyIdSerialization ]
+				['propertyId' => $propertyIdSerialization]
 			);
 		};
 
-		$this->addDescription( 'Imports property constraints from statements on properties' );
-		$this->requireExtension( 'WikibaseQualityConstraints' );
+		$this->addDescription('Imports property constraints from statements on properties');
+		$this->requireExtension('WikibaseQualityConstraints');
 
 		// Wikibase classes are not yet loaded, so setup services in a callback run in execute
 		// that can be overridden in tests.
-		$this->setupServices = function () {
+		$this->setupServices = function() {
 			$repo = WikibaseRepo::getDefaultInstance();
 			$this->propertyInfoLookup = $repo->getStore()->getPropertyInfoLookup();
 		};
 	}
 
 	public function execute() {
-		( $this->setupServices )();
-		if ( !$this->getConfig()->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) ) {
-			$this->error( 'Constraint statements are not enabled. Aborting.' );
+		($this->setupServices)();
+		if (!$this->getConfig()->get('WBQualityConstraintsEnableConstraintsImportFromStatements')) {
+			$this->error('Constraint statements are not enabled. Aborting.');
 			return;
 		}
 
-		foreach ( $this->propertyInfoLookup->getAllPropertyInfo() as $propertyIdSerialization => $info ) {
-			$this->output( sprintf( 'Importing constraint statements for % 6s... ', $propertyIdSerialization ), $propertyIdSerialization );
-			$startTime = microtime( true );
-			$job = call_user_func( $this->newUpdateConstraintsTableJob, $propertyIdSerialization );
+		foreach ($this->propertyInfoLookup->getAllPropertyInfo() as $propertyIdSerialization => $info) {
+			$this->output(sprintf('Importing constraint statements for % 6s... ', $propertyIdSerialization), $propertyIdSerialization);
+			$startTime = microtime(true);
+			$job = call_user_func($this->newUpdateConstraintsTableJob, $propertyIdSerialization);
 			$job->run();
-			$endTime = microtime( true );
-			$millis = ( $endTime - $startTime ) * 1000;
-			$this->output( sprintf( 'done in % 6.2f ms.', $millis ), $propertyIdSerialization );
+			$endTime = microtime(true);
+			$millis = ($endTime - $startTime) * 1000;
+			$this->output(sprintf('done in % 6.2f ms.', $millis), $propertyIdSerialization);
 		}
 	}
 

src/ConstraintCheck/Checker/UniqueValueChecker.php

Spacing +16 added lines, -16 removed lines

@@ -64,22 +64,22 @@ 
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 
-		if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
-			if ( $context->getType() === 'statement' ) {
+		if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
+			if ($context->getType() === 'statement') {
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
 					$context->getSnakStatement(),
 					true // ignore deprecated statements
 				);
 			} else {
-				if ( $context->getSnak()->getType() !== 'value' ) {
-					return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+				if ($context->getSnak()->getType() !== 'value') {
+					return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -92,27 +92,27 @@ 
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
-				$otherEntities = array_values( array_filter( $otherEntities ) ); // remove nulls
+				$otherEntities = array_values(array_filter($otherEntities)); // remove nulls
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/WikibaseServices.php

Spacing +7 added lines, -7 removed lines

@@ -19,27 +19,27 @@
 	const ENTITY_LOOKUP = 'WBQC_EntityLookup';
 	const PROPERTY_DATA_TYPE_LOOKUP = 'WBQC_PropertyDataTypeLookup';
 
-	private static function getService( MediaWikiServices $services = null, $name ) {
-		if ( $services === null ) {
+	private static function getService(MediaWikiServices $services = null, $name) {
+		if ($services === null) {
 			$services = MediaWikiServices::getInstance();
 		}
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return EntityLookup
 	 */
-	public static function getEntityLookup( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ENTITY_LOOKUP );
+	public static function getEntityLookup(MediaWikiServices $services = null) {
+		return self::getService($services, self::ENTITY_LOOKUP);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return PropertyDataTypeLookup
 	 */
-	public static function getPropertyDataTypeLookup( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::PROPERTY_DATA_TYPE_LOOKUP );
+	public static function getPropertyDataTypeLookup(MediaWikiServices $services = null) {
+		return self::getService($services, self::PROPERTY_DATA_TYPE_LOOKUP);
 	}
 
 }

src/ConstraintCheckerServices.php

Spacing +61 added lines, -61 removed lines

@@ -39,243 +39,243 @@
 	const PROPERTY_SCOPE_CHECKER = 'WBQC_PropertyScopeChecker';
 	const CONTEMPORARY_CHECKER = 'WBQC_ContemporaryChecker';
 
-	private static function getService( MediaWikiServices $services = null, $name ) {
-		if ( $services === null ) {
+	private static function getService(MediaWikiServices $services = null, $name) {
+		if ($services === null) {
 			$services = MediaWikiServices::getInstance();
 		}
-		return $services->getService( $name );
+		return $services->getService($name);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getConflictsWithChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONFLICTS_WITH_CHECKER );
+	public static function getConflictsWithChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::CONFLICTS_WITH_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getItemChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ITEM_CHECKER );
+	public static function getItemChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::ITEM_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getTargetRequiredClaimChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::TARGET_REQUIRED_CLAIM_CHECKER );
+	public static function getTargetRequiredClaimChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::TARGET_REQUIRED_CLAIM_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getSymmetricChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::SYMMETRIC_CHECKER );
+	public static function getSymmetricChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::SYMMETRIC_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getInverseChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::INVERSE_CHECKER );
+	public static function getInverseChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::INVERSE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getQualifierChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::QUALIFIER_CHECKER );
+	public static function getQualifierChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::QUALIFIER_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getQualifiersChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::QUALIFIERS_CHECKER );
+	public static function getQualifiersChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::QUALIFIERS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getMandatoryQualifiersChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::MANDATORY_QUALIFIERS_CHECKER );
+	public static function getMandatoryQualifiersChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::MANDATORY_QUALIFIERS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getRangeChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::RANGE_CHECKER );
+	public static function getRangeChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::RANGE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getDiffWithinRangeChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::DIFF_WITHIN_RANGE_CHECKER );
+	public static function getDiffWithinRangeChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::DIFF_WITHIN_RANGE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getTypeChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::TYPE_CHECKER );
+	public static function getTypeChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::TYPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getValueTypeChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::VALUE_TYPE_CHECKER );
+	public static function getValueTypeChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::VALUE_TYPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getSingleValueChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::SINGLE_VALUE_CHECKER );
+	public static function getSingleValueChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::SINGLE_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getMultiValueChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::MULTI_VALUE_CHECKER );
+	public static function getMultiValueChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::MULTI_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getUniqueValueChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::UNIQUE_VALUE_CHECKER );
+	public static function getUniqueValueChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::UNIQUE_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getFormatChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::FORMAT_CHECKER );
+	public static function getFormatChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::FORMAT_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getCommonsLinkChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::COMMONS_LINK_CHECKER );
+	public static function getCommonsLinkChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::COMMONS_LINK_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getOneOfChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ONE_OF_CHECKER );
+	public static function getOneOfChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::ONE_OF_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getValueOnlyChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::VALUE_ONLY_CHECKER );
+	public static function getValueOnlyChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::VALUE_ONLY_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getReferenceChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::REFERENCE_CHECKER );
+	public static function getReferenceChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::REFERENCE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getNoBoundsChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::NO_BOUNDS_CHECKER );
+	public static function getNoBoundsChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::NO_BOUNDS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getAllowedUnitsChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ALLOWED_UNITS_CHECKER );
+	public static function getAllowedUnitsChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::ALLOWED_UNITS_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getSingleBestValueChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::SINGLE_BEST_VALUE_CHECKER );
+	public static function getSingleBestValueChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::SINGLE_BEST_VALUE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getEntityTypeChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::ENTITY_TYPE_CHECKER );
+	public static function getEntityTypeChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::ENTITY_TYPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getNoneOfChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::NONE_OF_CHECKER );
+	public static function getNoneOfChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::NONE_OF_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getIntegerChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::INTEGER_CHECKER );
+	public static function getIntegerChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::INTEGER_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getCitationNeededChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CITATION_NEEDED_CHECKER );
+	public static function getCitationNeededChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::CITATION_NEEDED_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getPropertyScopeChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::PROPERTY_SCOPE_CHECKER );
+	public static function getPropertyScopeChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::PROPERTY_SCOPE_CHECKER);
 	}
 
 	/**
 	 * @param MediaWikiServices|null $services
 	 * @return ConstraintChecker
 	 */
-	public static function getContemporaryChecker( MediaWikiServices $services = null ) {
-		return self::getService( $services, self::CONTEMPORARY_CHECKER );
+	public static function getContemporaryChecker(MediaWikiServices $services = null) {
+		return self::getService($services, self::CONTEMPORARY_CHECKER);
 	}
 
 }

src/Html/HtmlTableHeaderBuilder.php

Spacing +9 added lines, -9 removed lines

@@ -40,10 +40,10 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, $isSortable = false, $isRawContent = false ) {
-		Assert::parameterType( 'string', $content, '$content' );
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
+	public function __construct($content, $isSortable = false, $isRawContent = false) {
+		Assert::parameterType('string', $content, '$content');
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
 
 		$this->content = $content;
 		$this->isSortable = $isSortable;
@@ -70,18 +70,18 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		$attributes = [ 'role' => 'columnheader button' ];
+		$attributes = ['role' => 'columnheader button'];
 
-		if ( !$this->isSortable ) {
+		if (!$this->isSortable) {
 			$attributes['class'] = 'unsortable';
 		}
 
 		$content = $this->content;
-		if ( !$this->isRawContent ) {
-			$content = htmlspecialchars( $this->content );
+		if (!$this->isRawContent) {
+			$content = htmlspecialchars($this->content);
 		}
 
-		return Html::rawElement( 'th', $attributes, $content );
+		return Html::rawElement('th', $attributes, $content);
 	}
 
 }

src/Html/HtmlTableCellBuilder.php

Spacing +6 added lines, -6 removed lines

@@ -38,9 +38,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, array $attributes = [], $isRawContent = false ) {
-		Assert::parameterType( 'string', $content, '$content' );
-		Assert::parameterType( 'boolean', $isRawContent, '$isRawContent' );
+	public function __construct($content, array $attributes = [], $isRawContent = false) {
+		Assert::parameterType('string', $content, '$content');
+		Assert::parameterType('boolean', $isRawContent, '$isRawContent');
 
 		$this->content = $content;
 		$this->attributes = $attributes;
@@ -65,10 +65,10 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		if ( $this->isRawContent ) {
-			return Html::rawElement( 'td', $this->getAttributes(), $this->content );
+		if ($this->isRawContent) {
+			return Html::rawElement('td', $this->getAttributes(), $this->content);
 		} else {
-			return Html::element( 'td', $this->getAttributes(), $this->content );
+			return Html::element('td', $this->getAttributes(), $this->content);
 		}
 	}
 

src/Job/CheckConstraintsJob.php

Spacing +13 added lines, -13 removed lines

@@ -42,25 +42,25 @@ 
 	 * @param Title $title
 	 * @param string[] $params should contain 'entityId' => 'Q1234'
 	 */
-	public function __construct( Title $title, array $params ) {
-		parent::__construct( self::COMMAND, $title, $params );
+	public function __construct(Title $title, array $params) {
+		parent::__construct(self::COMMAND, $title, $params);
 		$this->removeDuplicates = true;
 
-		Assert::parameterType( 'string', $params['entityId'], '$params[\'entityId\']' );
+		Assert::parameterType('string', $params['entityId'], '$params[\'entityId\']');
 		$this->entityId = $params['entityId'];
 
-		$resultSource = ConstraintsServices::getResultsSource( MediaWikiServices::getInstance() );
+		$resultSource = ConstraintsServices::getResultsSource(MediaWikiServices::getInstance());
 		// This job should only ever be used when caching result sources are used.
-		$this->setResultsSource( $resultSource );
+		$this->setResultsSource($resultSource);
 
-		$this->setEntityIdParser( WikibaseRepo::getDefaultInstance()->getEntityIdParser() );
+		$this->setEntityIdParser(WikibaseRepo::getDefaultInstance()->getEntityIdParser());
 	}
 
-	public function setResultsSource( CachingResultsSource $resultsSource ) {
+	public function setResultsSource(CachingResultsSource $resultsSource) {
 		$this->resultsSource = $resultsSource;
 	}
 
-	public function setEntityIdParser( EntityIdParser $parser ) {
+	public function setEntityIdParser(EntityIdParser $parser) {
 		$this->entityIdParser = $parser;
 	}
 
@@ -71,19 +71,19 @@ 
 	 */
 	public function run() {
 		try {
-			$entityId = $this->entityIdParser->parse( $this->entityId );
-		} catch ( EntityIdParsingException $e ) {
+			$entityId = $this->entityIdParser->parse($this->entityId);
+		} catch (EntityIdParsingException $e) {
 			return false;
 		}
 
-		$this->checkConstraints( $entityId );
+		$this->checkConstraints($entityId);
 
 		return true;
 	}
 
-	private function checkConstraints( EntityId $entityId ) {
+	private function checkConstraints(EntityId $entityId) {
 		$this->resultsSource->getResults(
-			[ $entityId ],
+			[$entityId],
 			[],
 			null,
 			[]