wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Helper/LoggingHelper.php

Spacing +32 added lines, -32 removed lines

@@ -53,12 +53,12 @@ 
 		$this->dataFactory = $dataFactory;
 		$this->logger = $logger;
 		$this->constraintCheckDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'),
 		];
 		$this->constraintCheckOnEntityDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckOnEntityDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckOnEntityDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckOnEntityDurationWarningSeconds'),
 		];
 	}
 
@@ -69,23 +69,23 @@ 
 	 * @param float $durationSeconds
 	 * @return array [ $limitSeconds, $logLevel ]
 	 */
-	private function findLimit( $limits, $durationSeconds ) {
+	private function findLimit($limits, $durationSeconds) {
 		$limitSeconds = null;
 		$logLevel = null;
 
-		foreach ( $limits as $level => $limit ) {
+		foreach ($limits as $level => $limit) {
 			if (
 				// duration exceeds this limit
 				$limit !== null && $durationSeconds > $limit &&
 				// this limit is longer than previous longest limit
-				( $limitSeconds === null || $limit > $limitSeconds )
+				($limitSeconds === null || $limit > $limitSeconds)
 			) {
 				$limitSeconds = $limit;
 				$logLevel = $level;
 			}
 		}
 
-		return [ $limitSeconds, $logLevel ];
+		return [$limitSeconds, $logLevel];
 	}
 
 	/**
@@ -110,31 +110,31 @@ 
 		$durationSeconds,
 		$method
 	) {
-		$constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 );
+		$constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1);
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
 		$this->dataFactory->timing(
-			'wikibase.quality.constraints.check.timing.' .
-				$constraintTypeItemId . '-' .
+			'wikibase.quality.constraints.check.timing.'.
+				$constraintTypeItemId.'-'.
 				$constraintCheckerClassShortName,
 			$durationSeconds * 1000
 		);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		[ $limitSeconds, $logLevel ] = $this->findLimit(
+		[$limitSeconds, $logLevel] = $this->findLimit(
 			$this->constraintCheckDurationLimits,
 			$durationSeconds
 		);
-		if ( $limitSeconds === null ) {
+		if ($limitSeconds === null) {
 			return;
 		}
-		if ( $context->getType() !== Context::TYPE_STATEMENT ) {
+		if ($context->getType() !== Context::TYPE_STATEMENT) {
 			// TODO log less details but still log something
 			return;
 		}
 
 		$resultMessage = $result->getMessage();
-		if ( $resultMessage !== null ) {
+		if ($resultMessage !== null) {
 			$resultMessageKey = $resultMessage->getMessageKey();
 		} else {
 			$resultMessageKey = null;
@@ -142,8 +142,8 @@ 
 
 		$this->logger->log(
 			$logLevel,
-			'Constraint check with {constraintCheckerClassShortName} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Constraint check with {constraintCheckerClassShortName} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -153,7 +153,7 @@ 
 				'constraintId' => $constraint->getConstraintId(),
 				'constraintPropertyId' => $constraint->getPropertyId()->getSerialization(),
 				'constraintTypeItemId' => $constraintTypeItemId,
-				'constraintParameters' => json_encode( $constraint->getConstraintParameters() ),
+				'constraintParameters' => json_encode($constraint->getConstraintParameters()),
 				'constraintCheckerClass' => $constraintCheckerClass,
 				'constraintCheckerClassShortName' => $constraintCheckerClassShortName,
 				'entityId' => $context->getEntity()->getId()->getSerialization(),
@@ -188,18 +188,18 @@ 
 		);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		[ $limitSeconds, $logLevel ] = $this->findLimit(
+		[$limitSeconds, $logLevel] = $this->findLimit(
 			$this->constraintCheckOnEntityDurationLimits,
 			$durationSeconds
 		);
-		if ( $limitSeconds === null ) {
+		if ($limitSeconds === null) {
 			return;
 		}
 
 		$this->logger->log(
 			$logLevel,
-			'Full constraint check on {entityId} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Full constraint check on {entityId} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,
@@ -217,7 +217,7 @@ 
 	 *
 	 * @param EntityId $entityId
 	 */
-	public function logCheckConstraintsCacheHit( EntityId $entityId ) {
+	public function logCheckConstraintsCacheHit(EntityId $entityId) {
 		$this->dataFactory->increment(
 			'wikibase.quality.constraints.cache.entity.hit'
 		);
@@ -228,10 +228,10 @@ 
 	 *
 	 * @param EntityId[] $entityIds
 	 */
-	public function logCheckConstraintsCacheMisses( array $entityIds ) {
+	public function logCheckConstraintsCacheMisses(array $entityIds) {
 		$this->dataFactory->updateCount(
 			'wikibase.quality.constraints.cache.entity.miss',
-			count( $entityIds )
+			count($entityIds)
 		);
 	}
 
@@ -258,17 +258,17 @@ 
 	 * @param EntityId[] $entityIds
 	 * @param int $maxRevisionIds
 	 */
-	public function logHugeDependencyMetadata( array $entityIds, $maxRevisionIds ) {
+	public function logHugeDependencyMetadata(array $entityIds, $maxRevisionIds) {
 		$this->logger->log(
 			'warning',
-			'Dependency metadata for constraint check result has huge set of entity IDs ' .
-			'(count ' . count( $entityIds ) . ', limit ' . $maxRevisionIds . '); ' .
+			'Dependency metadata for constraint check result has huge set of entity IDs '.
+			'(count '.count($entityIds).', limit '.$maxRevisionIds.'); '.
 			'caching disabled for this check result.',
 			[
 				'loggingMethod' => __METHOD__,
 				'entityIds' => json_encode(
 					array_map(
-						static function ( EntityId $entityId ) {
+						static function(EntityId $entityId) {
 							return $entityId->getSerialization();
 						},
 						$entityIds
@@ -287,17 +287,17 @@ 
 			'Sparql API replied with status 429 and a retry-after header. Requesting to retry after {retryAfterTime}',
 			[
 				'retryAfterTime' => $retryAfterTime,
-				'responseHeaders' => json_encode( $request->getResponseHeaders() ),
+				'responseHeaders' => json_encode($request->getResponseHeaders()),
 				'responseContent' => $request->getContent(),
 			]
 		);
 	}
 
-	public function logSparqlHelperTooManyRequestsRetryAfterInvalid( MWHttpRequest $request ) {
+	public function logSparqlHelperTooManyRequestsRetryAfterInvalid(MWHttpRequest $request) {
 		$this->logger->warning(
 			'Sparql API replied with status 429 and no valid retry-after header.',
 			[
-				'responseHeaders' => json_encode( $request->getResponseHeaders() ),
+				'responseHeaders' => json_encode($request->getResponseHeaders()),
 				'responseContent' => $request->getContent(),
 			]
 		);

src/ConstraintStore.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function insertBatch( array $constraints );
+	public function insertBatch(array $constraints);
 
 	/**
 	 * Delete all constraints for the property ID.
@@ -24,6 +24,6 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function deleteForProperty( NumericPropertyId $propertyId );
+	public function deleteForProperty(NumericPropertyId $propertyId);
 
 }

src/ConstraintRepositoryStore.php

Spacing +19 added lines, -19 removed lines

@@ -24,16 +24,16 @@ 
 	 * then using the main DBLoadBalancer service may be incorrect.
 	 * @param string|false $dbName Database name ($domain for ILoadBalancer methods).
 	 */
-	public function __construct( ILoadBalancer $lb, $dbName ) {
+	public function __construct(ILoadBalancer $lb, $dbName) {
 		$this->lb = $lb;
 		$this->dbName = $dbName;
 	}
 
-	private function encodeConstraintParameters( array $constraintParameters ) {
-		$json = json_encode( $constraintParameters, JSON_FORCE_OBJECT );
+	private function encodeConstraintParameters(array $constraintParameters) {
+		$json = json_encode($constraintParameters, JSON_FORCE_OBJECT);
 
-		if ( strlen( $json ) > 50000 ) {
-			$json = json_encode( [ '@error' => [ 'toolong' => true ] ] );
+		if (strlen($json) > 50000) {
+			$json = json_encode(['@error' => ['toolong' => true]]);
 		}
 
 		return $json;
@@ -44,28 +44,28 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function insertBatch( array $constraints ) {
-		if ( !$constraints ) {
+	public function insertBatch(array $constraints) {
+		if (!$constraints) {
 			return;
 		}
 
 		$accumulator = array_map(
-			function ( Constraint $constraint ) {
+			function(Constraint $constraint) {
 				return [
 					'constraint_guid' => $constraint->getConstraintId(),
 					'pid' => $constraint->getPropertyId()->getNumericId(),
 					'constraint_type_qid' => $constraint->getConstraintTypeItemId(),
-					'constraint_parameters' => $this->encodeConstraintParameters( $constraint->getConstraintParameters() ),
+					'constraint_parameters' => $this->encodeConstraintParameters($constraint->getConstraintParameters()),
 				];
 			},
 			$constraints
 		);
 
-		$dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName );
+		$dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName);
 		$dbw->newInsertQueryBuilder()
-			->insertInto( 'wbqc_constraints' )
-			->rows( $accumulator )
-			->caller( __METHOD__ )
+			->insertInto('wbqc_constraints')
+			->rows($accumulator)
+			->caller(__METHOD__)
 			->execute();
 	}
 
@@ -76,14 +76,14 @@ 
 	 *
 	 * @throws DBUnexpectedError
 	 */
-	public function deleteForProperty( NumericPropertyId $propertyId ) {
-		$dbw = $this->lb->getConnection( ILoadBalancer::DB_PRIMARY, [], $this->dbName );
+	public function deleteForProperty(NumericPropertyId $propertyId) {
+		$dbw = $this->lb->getConnection(ILoadBalancer::DB_PRIMARY, [], $this->dbName);
 		$dbw->newDeleteQueryBuilder()
-			->deleteFrom( 'wbqc_constraints' )
-			->where( [
+			->deleteFrom('wbqc_constraints')
+			->where([
 				'pid' => $propertyId->getNumericId(),
-			] )
-			->caller( __METHOD__ )
+			])
+			->caller(__METHOD__)
 			->execute();
 	}
 

src/ConstraintCheck/Checker/UniqueValueChecker.php

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker;
 
@@ -64,18 +64,18 @@ 
 	 *
 	 * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
-		if ( !( $this->sparqlHelper instanceof DummySparqlHelper ) ) {
+		if (!($this->sparqlHelper instanceof DummySparqlHelper)) {
 
 			$separators = $this->constraintParameterParser->parseSeparatorsParameter(
 				$constraint->getConstraintParameters()
 			);
 
-			if ( $context->getType() === 'statement' ) {
+			if ($context->getType() === 'statement') {
 				$statement = $context->getSnakStatement();
 				'@phan-var Statement $statement';
 				$result = $this->sparqlHelper->findEntitiesWithSameStatement(
@@ -84,9 +84,9 @@ 
 				);
 			} else {
 				$snak = $context->getSnak();
-				if ( !$snak instanceof PropertyValueSnak ) {
+				if (!$snak instanceof PropertyValueSnak) {
 					// nothing to check
-					return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+					return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 				}
 				$result = $this->sparqlHelper->findEntitiesWithSameQualifierOrReference(
 					$context->getEntity()->getId(),
@@ -99,31 +99,31 @@ 
 			$otherEntities = $result->getArray();
 			$metadata = $result->getMetadata();
 
-			if ( $otherEntities === [] ) {
+			if ($otherEntities === []) {
 				$status = CheckResult::STATUS_COMPLIANCE;
 				$message = null;
 			} else {
 				$status = CheckResult::STATUS_VIOLATION;
-				$message = ( new ViolationMessage( 'wbqc-violation-message-unique-value' ) )
-					->withEntityIdList( $otherEntities, Role::SUBJECT );
+				$message = (new ViolationMessage('wbqc-violation-message-unique-value'))
+					->withEntityIdList($otherEntities, Role::SUBJECT);
 			}
 		} else {
 			$status = CheckResult::STATUS_TODO;
-			$message = ( new ViolationMessage( 'wbqc-violation-message-not-yet-implemented' ) )
-				->withEntityId( new ItemId( $constraint->getConstraintTypeItemId() ), Role::CONSTRAINT_TYPE_ITEM );
+			$message = (new ViolationMessage('wbqc-violation-message-not-yet-implemented'))
+				->withEntityId(new ItemId($constraint->getConstraintTypeItemId()), Role::CONSTRAINT_TYPE_ITEM);
 			$metadata = Metadata::blank();
 		}
 
-		return ( new CheckResult( $context, $constraint, $status, $message ) )
-			->withMetadata( $metadata );
+		return (new CheckResult($context, $constraint, $status, $message))
+			->withMetadata($metadata);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Cache/CachedEntityIds.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Cache;
 

src/WikibaseQualityConstraintsSchemaHooks.php

Spacing +3 added lines, -3 removed lines

@@ -15,12 +15,12 @@
 	/**
 	 * @param DatabaseUpdater $updater
 	 */
-	public function onLoadExtensionSchemaUpdates( $updater ) {
-		$dir = dirname( __DIR__ ) . '/sql/';
+	public function onLoadExtensionSchemaUpdates($updater) {
+		$dir = dirname(__DIR__).'/sql/';
 
 		$updater->addExtensionTable(
 			'wbqc_constraints',
-			$dir . "/{$updater->getDB()->getType()}/tables-generated.sql"
+			$dir."/{$updater->getDB()->getType()}/tables-generated.sql"
 		);
 	}
 

src/ConstraintCheck/Checker/LabelInLanguageChecker.php

Spacing +14 added lines, -14 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker;
 
@@ -22,7 +22,7 @@ 
 
 	private ConstraintParameterParser $constraintParameterParser;
 
-	public function __construct( ConstraintParameterParser $constraintParameterParser ) {
+	public function __construct(ConstraintParameterParser $constraintParameterParser) {
 		$this->constraintParameterParser = $constraintParameterParser;
 	}
 
@@ -64,9 +64,9 @@ 
 	 *
 	 * @throws ConstraintParameterException
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED);
 		}
 
 		$constraintParameters = $constraint->getConstraintParameters();
@@ -77,21 +77,21 @@ 
 		);
 
 		$status = CheckResult::STATUS_VIOLATION;
-		$message = ( new ViolationMessage( 'wbqc-violation-message-label-lacking' ) )
-			->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-			->withLanguages( $languages );
+		$message = (new ViolationMessage('wbqc-violation-message-label-lacking'))
+			->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+			->withLanguages($languages);
 
 		/** @var LabelsProvider $entity */
 		$entity = $context->getEntity();
 		'@phan-var LabelsProvider $entity';
 		$labels = $entity->getLabels();
 
-		if ( $labels->hasTermForLanguage( 'mul' ) ) {
+		if ($labels->hasTermForLanguage('mul')) {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		} else {
-			foreach ( $languages as $language ) {
-				if ( $labels->hasTermForLanguage( $language ) ) {
+			foreach ($languages as $language) {
+				if ($labels->hasTermForLanguage($language)) {
 					$message = null;
 					$status = CheckResult::STATUS_COMPLIANCE;
 					break;
@@ -99,10 +99,10 @@ 
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $status, $message );
+		return new CheckResult($context, $constraint, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
@@ -110,7 +110,7 @@ 
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId()
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/Html/HtmlTableHeaderBuilder.php

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Html;
 
@@ -33,8 +33,8 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, bool $isSortable = false ) {
-		Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' );
+	public function __construct($content, bool $isSortable = false) {
+		Assert::parameterType(['string', HtmlArmor::class], $content, '$content');
 
 		$this->content = $content;
 		$this->isSortable = $isSortable;
@@ -44,7 +44,7 @@ 
 	 * @return string HTML
 	 */
 	public function getContent(): string {
-		return HtmlArmor::getHtml( $this->content );
+		return HtmlArmor::getHtml($this->content);
 	}
 
 	public function getIsSortable(): bool {
@@ -57,13 +57,13 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml(): string {
-		$attributes = [ 'role' => 'columnheader button' ];
+		$attributes = ['role' => 'columnheader button'];
 
-		if ( !$this->isSortable ) {
+		if (!$this->isSortable) {
 			$attributes['class'] = 'unsortable';
 		}
 
-		return Html::rawElement( 'th', $attributes, $this->getContent() );
+		return Html::rawElement('th', $attributes, $this->getContent());
 	}
 
 }

src/ConstraintCheck/Message/ViolationMessageSerializer.php

Spacing +30 added lines, -30 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message;
 
@@ -21,26 +21,26 @@ 
  */
 class ViolationMessageSerializer implements Serializer {
 
-	private function abbreviateViolationMessageKey( string $fullMessageKey ): string {
-		return substr( $fullMessageKey, strlen( ViolationMessage::MESSAGE_KEY_PREFIX ) );
+	private function abbreviateViolationMessageKey(string $fullMessageKey): string {
+		return substr($fullMessageKey, strlen(ViolationMessage::MESSAGE_KEY_PREFIX));
 	}
 
 	/**
 	 * @param ViolationMessage $object
 	 * @return array
 	 */
-	public function serialize( $object ): array {
+	public function serialize($object): array {
 		/** @var ViolationMessage $object */
-		Assert::parameterType( ViolationMessage::class, $object, '$object' );
+		Assert::parameterType(ViolationMessage::class, $object, '$object');
 
 		$arguments = $object->getArguments();
 		$serializedArguments = [];
-		foreach ( $arguments as $argument ) {
-			$serializedArguments[] = $this->serializeArgument( $argument );
+		foreach ($arguments as $argument) {
+			$serializedArguments[] = $this->serializeArgument($argument);
 		}
 
 		return [
-			'k' => $this->abbreviateViolationMessageKey( $object->getMessageKey() ),
+			'k' => $this->abbreviateViolationMessageKey($object->getMessageKey()),
 			'a' => $serializedArguments,
 		];
 	}
@@ -49,7 +49,7 @@ 
 	 * @param array $argument element of ViolationMessage::getArguments()
 	 * @return array [ 't' => ViolationMessage::TYPE_*, 'v' => serialized value, 'r' => $role ]
 	 */
-	private function serializeArgument( array $argument ): array {
+	private function serializeArgument(array $argument): array {
 		$methods = [
 			ViolationMessage::TYPE_ENTITY_ID => 'serializeEntityId',
 			ViolationMessage::TYPE_ENTITY_ID_LIST => 'serializeEntityIdList',
@@ -71,12 +71,12 @@ 
 		$value = $argument['value'];
 		$role = $argument['role'];
 
-		if ( array_key_exists( $type, $methods ) ) {
+		if (array_key_exists($type, $methods)) {
 			$method = $methods[$type];
-			$serializedValue = $this->$method( $value );
+			$serializedValue = $this->$method($value);
 		} else {
 			throw new InvalidArgumentException(
-				'Unknown ViolationMessage argument type ' . $type . '!'
+				'Unknown ViolationMessage argument type '.$type.'!'
 			);
 		}
 
@@ -93,7 +93,7 @@ 
 	 * @param string $string any value that shall simply be serialized to itself
 	 * @return string that same value, unchanged
 	 */
-	private function serializeStringByIdentity( string $string ): string {
+	private function serializeStringByIdentity(string $string): string {
 		return $string;
 	}
 
@@ -101,8 +101,8 @@ 
 	 * @param string[] $strings
 	 * @return string[]
 	 */
-	private function serializeStringListByIdentity( array $strings ): array {
-		Assert::parameterElementType( 'string', $strings, '$strings' );
+	private function serializeStringListByIdentity(array $strings): array {
+		Assert::parameterElementType('string', $strings, '$strings');
 		return $strings;
 	}
 
@@ -110,7 +110,7 @@ 
 	 * @param EntityId $entityId
 	 * @return string entity ID serialization
 	 */
-	private function serializeEntityId( EntityId $entityId ): string {
+	private function serializeEntityId(EntityId $entityId): string {
 		return $entityId->getSerialization();
 	}
 
@@ -118,8 +118,8 @@ 
 	 * @param EntityId[] $entityIdList
 	 * @return string[] entity ID serializations
 	 */
-	private function serializeEntityIdList( array $entityIdList ): array {
-		return array_map( [ $this, 'serializeEntityId' ], $entityIdList );
+	private function serializeEntityIdList(array $entityIdList): array {
+		return array_map([$this, 'serializeEntityId'], $entityIdList);
 	}
 
 	/**
@@ -127,10 +127,10 @@ 
 	 * @return string entity ID serialization, '::somevalue', or '::novalue'
 	 * (according to EntityId::PATTERN, entity ID serializations can never begin with two colons)
 	 */
-	private function serializeItemIdSnakValue( ItemIdSnakValue $value ): string {
-		switch ( true ) {
+	private function serializeItemIdSnakValue(ItemIdSnakValue $value): string {
+		switch (true) {
 			case $value->isValue():
-				return $this->serializeEntityId( $value->getItemId() );
+				return $this->serializeEntityId($value->getItemId());
 			case $value->isSomeValue():
 				return '::somevalue';
 			case $value->isNoValue():
@@ -148,15 +148,15 @@ 
 	 * @param ItemIdSnakValue[] $valueList
 	 * @return string[] array of entity ID serializations, '::somevalue's or '::novalue's
 	 */
-	private function serializeItemIdSnakValueList( array $valueList ): array {
-		return array_map( [ $this, 'serializeItemIdSnakValue' ], $valueList );
+	private function serializeItemIdSnakValueList(array $valueList): array {
+		return array_map([$this, 'serializeItemIdSnakValue'], $valueList);
 	}
 
 	/**
 	 * @param DataValue $dataValue
 	 * @return array the data value in array form
 	 */
-	private function serializeDataValue( DataValue $dataValue ): array {
+	private function serializeDataValue(DataValue $dataValue): array {
 		return $dataValue->toArray();
 	}
 
@@ -164,8 +164,8 @@ 
 	 * @param string $contextType one of the Context::TYPE_* constants
 	 * @return string the abbreviated context type
 	 */
-	private function serializeContextType( string $contextType ): string {
-		switch ( $contextType ) {
+	private function serializeContextType(string $contextType): string {
+		switch ($contextType) {
 			case Context::TYPE_STATEMENT:
 				return 's';
 			case Context::TYPE_QUALIFIER:
@@ -175,7 +175,7 @@ 
 			default:
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
-					'Unknown context type ' . $contextType
+					'Unknown context type '.$contextType
 				);
 				// @codeCoverageIgnoreEnd
 		}
@@ -185,15 +185,15 @@ 
 	 * @param string[] $contextTypeList Context::TYPE_* constants
 	 * @return string[] abbreviated context types
 	 */
-	private function serializeContextTypeList( array $contextTypeList ): array {
-		return array_map( [ $this, 'serializeContextType' ], $contextTypeList );
+	private function serializeContextTypeList(array $contextTypeList): array {
+		return array_map([$this, 'serializeContextType'], $contextTypeList);
 	}
 
 	/**
 	 * @param MultilingualTextValue $text
 	 * @return mixed {@see MultilingualTextValue::getArrayValue}
 	 */
-	private function serializeMultilingualText( MultilingualTextValue $text ) {
+	private function serializeMultilingualText(MultilingualTextValue $text) {
 		return $text->getArrayValue();
 	}