wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/UpdateConstraintsTableJob.php

Spacing +18 added lines, -18 removed lines

@@ -26,8 +26,8 @@ 
 
 	const BATCH_SIZE = 10;
 
-	public static function newFromGlobalState( Title $title, array $params ) {
-		Assert::parameterType( 'string', $params['propertyId'], '$params["propertyId"]' );
+	public static function newFromGlobalState(Title $title, array $params) {
+		Assert::parameterType('string', $params['propertyId'], '$params["propertyId"]');
 		$repo = WikibaseRepo::getDefaultInstance();
 		return new UpdateConstraintsTableJob(
 			$title,
@@ -83,7 +83,7 @@ 
 		EntityLookup $entityLookup,
 		Serializer $snakSerializer
 	) {
-		parent::__construct( 'constraintsTableUpdate', $title, $params );
+		parent::__construct('constraintsTableUpdate', $title, $params);
 
 		$this->propertyId = $propertyId;
 		$this->config = $config;
@@ -92,11 +92,11 @@ 
 		$this->snakSerializer = $snakSerializer;
 	}
 
-	public function extractParametersFromQualifiers( SnakList $qualifiers ) {
+	public function extractParametersFromQualifiers(SnakList $qualifiers) {
 		$parameters = [];
-		foreach ( $qualifiers as $qualifier ) {
+		foreach ($qualifiers as $qualifier) {
 			$qualifierId = $qualifier->getPropertyId()->getSerialization();
-			$paramSerialization = $this->snakSerializer->serialize( $qualifier );
+			$paramSerialization = $this->snakSerializer->serialize($qualifier);
 			$parameters[$qualifierId][] = $paramSerialization;
 		}
 		return $parameters;
@@ -108,7 +108,7 @@ 
 	) {
 		$constraintId = $constraintStatement->getGuid();
 		$constraintTypeQid = $constraintStatement->getMainSnak()->getDataValue()->getEntityId()->getSerialization();
-		$parameters = $this->extractParametersFromQualifiers( $constraintStatement->getQualifiers() );
+		$parameters = $this->extractParametersFromQualifiers($constraintStatement->getQualifiers());
 		return new Constraint(
 			$constraintId,
 			$propertyId,
@@ -123,17 +123,17 @@ 
 		PropertyId $propertyConstraintPropertyId
 	) {
 		$constraintsStatements = $property->getStatements()
-			->getByPropertyId( $propertyConstraintPropertyId )
-			->getByRank( [ Statement::RANK_PREFERRED, Statement::RANK_NORMAL ] );
+			->getByPropertyId($propertyConstraintPropertyId)
+			->getByRank([Statement::RANK_PREFERRED, Statement::RANK_NORMAL]);
 		$constraints = [];
-		foreach ( $constraintsStatements->getIterator() as $constraintStatement ) {
-			$constraints[] = $this->extractConstraintFromStatement( $property->getId(), $constraintStatement );
-			if ( count( $constraints ) >= self::BATCH_SIZE ) {
-				$constraintRepo->insertBatch( $constraints );
+		foreach ($constraintsStatements->getIterator() as $constraintStatement) {
+			$constraints[] = $this->extractConstraintFromStatement($property->getId(), $constraintStatement);
+			if (count($constraints) >= self::BATCH_SIZE) {
+				$constraintRepo->insertBatch($constraints);
 				$constraints = [];
 			}
 		}
-		$constraintRepo->insertBatch( $constraints );
+		$constraintRepo->insertBatch($constraints);
 	}
 
 	/**
@@ -144,15 +144,15 @@ 
 	public function run() {
 		// TODO in the future: only touch constraints affected by the edit (requires T163465)
 
-		$propertyId = new PropertyId( $this->propertyId );
-		$this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId( $propertyId );
+		$propertyId = new PropertyId($this->propertyId);
+		$this->constraintRepo->deleteForPropertyWhereConstraintIdIsStatementId($propertyId);
 
 		/** @var Property $property */
-		$property = $this->entityLookup->getEntity( $propertyId );
+		$property = $this->entityLookup->getEntity($propertyId);
 		$this->importConstraintsForProperty(
 			$property,
 			$this->constraintRepo,
-			new PropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) )
+			new PropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId'))
 		);
 
 		return true;

src/ConstraintCheck/Context/AbstractContext.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 	 */
 	protected $snak;
 
-	public function __construct( EntityDocument $entity, Snak $snak ) {
+	public function __construct(EntityDocument $entity, Snak $snak) {
 		$this->entity = $entity;
 		$this->snak = $snak;
 	}

src/ConstraintCheck/Context/QualifierContext.php

Spacing +9 added lines, -9 removed lines

@@ -23,7 +23,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -33,10 +33,10 @@ 
 
 	public function getSnakGroup() {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -44,25 +44,25 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'qualifiers', $statementArray ) ) {
+		if (!array_key_exists('qualifiers', $statementArray)) {
 			$statementArray['qualifiers'] = [];
 		}
 		$qualifiersArray = &$statementArray['qualifiers'];
 
 		$propertyId = $this->getSnak()->getPropertyId()->getSerialization();
-		if ( !array_key_exists( $propertyId, $qualifiersArray ) ) {
+		if (!array_key_exists($propertyId, $qualifiersArray)) {
 			$qualifiersArray[$propertyId] = [];
 		}
 		$propertyArray = &$qualifiersArray[$propertyId];
 
-		foreach ( $propertyArray as &$potentialQualifierArray ) {
-			if ( $potentialQualifierArray['hash'] === $this->getSnak()->getHash() ) {
+		foreach ($propertyArray as &$potentialQualifierArray) {
+			if ($potentialQualifierArray['hash'] === $this->getSnak()->getHash()) {
 				$qualifierArray = &$potentialQualifierArray;
 				break;
 			}
 		}
-		if ( !isset( $qualifierArray ) ) {
-			$qualifierArray = [ 'hash' => $this->getSnak()->getHash() ];
+		if (!isset($qualifierArray)) {
+			$qualifierArray = ['hash' => $this->getSnak()->getHash()];
 			$propertyArray[] = &$qualifierArray;
 		}
 

src/ConstraintCheck/Context/ReferenceContext.php

Spacing +13 added lines, -13 removed lines

@@ -30,7 +30,7 @@ 
 		Reference $reference,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 		$this->reference = $reference;
 	}
@@ -41,10 +41,10 @@ 
 
 	public function getSnakGroup() {
 		$snaks = $this->reference->getSnaks();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -52,38 +52,38 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'references', $statementArray ) ) {
+		if (!array_key_exists('references', $statementArray)) {
 			$statementArray['references'] = [];
 		}
 		$referencesArray = &$statementArray['references'];
 
-		foreach ( $referencesArray as &$potentialReferenceArray ) {
-			if ( $potentialReferenceArray['hash'] === $this->reference->getHash() ) {
+		foreach ($referencesArray as &$potentialReferenceArray) {
+			if ($potentialReferenceArray['hash'] === $this->reference->getHash()) {
 				$referenceArray = &$potentialReferenceArray;
 				break;
 			}
 		}
-		if ( !isset( $referenceArray ) ) {
-			$referenceArray = [ 'hash' => $this->reference->getHash(), 'snaks' => [] ];
+		if (!isset($referenceArray)) {
+			$referenceArray = ['hash' => $this->reference->getHash(), 'snaks' => []];
 			$referencesArray[] = &$referenceArray;
 		}
 
 		$snaksArray = &$referenceArray['snaks'];
 
 		$propertyId = $this->getSnak()->getPropertyId()->getSerialization();
-		if ( !array_key_exists( $propertyId, $snaksArray ) ) {
+		if (!array_key_exists($propertyId, $snaksArray)) {
 			$snaksArray[$propertyId] = [];
 		}
 		$propertyArray = &$snaksArray[$propertyId];
 
-		foreach ( $propertyArray as &$potentialSnakArray ) {
-			if ( $potentialSnakArray['hash'] === $this->getSnak()->getHash() ) {
+		foreach ($propertyArray as &$potentialSnakArray) {
+			if ($potentialSnakArray['hash'] === $this->getSnak()->getHash()) {
 				$snakArray = &$potentialSnakArray;
 				break;
 			}
 		}
-		if ( !isset( $snakArray ) ) {
-			$snakArray = [ 'hash' => $this->getSnak()->getHash() ];
+		if (!isset($snakArray)) {
+			$snakArray = ['hash' => $this->getSnak()->getHash()];
 			$propertyArray[] = &$snakArray;
 		}
 

src/ConstraintCheck/Context/MainSnakContext.php

Spacing +7 added lines, -7 removed lines

@@ -20,9 +20,9 @@ 
 	 */
 	private $statement;
 
-	public function __construct( EntityDocument $entity, Statement $statement ) {
-		Assert::parameterType( StatementListProvider::class, $entity, '$entity' );
-		parent::__construct( $entity, $statement->getMainSnak() );
+	public function __construct(EntityDocument $entity, Statement $statement) {
+		Assert::parameterType(StatementListProvider::class, $entity, '$entity');
+		parent::__construct($entity, $statement->getMainSnak());
 
 		$this->statement = $statement;
 	}
@@ -43,11 +43,11 @@ 
 		/** @var StatementList $statements */
 		$statements = $this->entity->getStatements();
 		return $statements
-			->getByRank( [ Statement::RANK_NORMAL, Statement::RANK_PREFERRED ] )
+			->getByRank([Statement::RANK_NORMAL, Statement::RANK_PREFERRED])
 			->getMainSnaks();
 	}
 
-	protected function &getMainArray( array &$container ) {
+	protected function &getMainArray(array &$container) {
 		$statementArray = &$this->getStatementArray(
 			$container,
 			$this->entity->getId()->getSerialization(),
@@ -55,8 +55,8 @@ 
 			$this->statement->getGuid()
 		);
 
-		if ( !array_key_exists( 'mainsnak', $statementArray ) ) {
-			$statementArray['mainsnak'] = [ 'hash' => $this->statement->getMainSnak()->getHash() ];
+		if (!array_key_exists('mainsnak', $statementArray)) {
+			$statementArray['mainsnak'] = ['hash' => $this->statement->getMainSnak()->getHash()];
 		}
 		$mainsnakArray = &$statementArray['mainsnak'];
 

src/ConstraintCheck/Helper/ValueCountCheckerHelper.php

Spacing +5 added lines, -5 removed lines

@@ -20,13 +20,13 @@
 	 * @param PropertyId $propertyId
 	 * @return int
 	 */
-	public function getPropertyCount( array $snaks, PropertyId $propertyId ) {
-		return count( array_filter(
+	public function getPropertyCount(array $snaks, PropertyId $propertyId) {
+		return count(array_filter(
 			$snaks,
-			function ( Snak $snak ) use ( $propertyId ) {
-				return $snak->getPropertyId()->equals( $propertyId );
+			function(Snak $snak) use ($propertyId) {
+				return $snak->getPropertyId()->equals($propertyId);
 			}
-		) );
+		));
 	}
 
 }

src/Api/ResultsCache.php

Spacing +13 added lines, -13 removed lines

@@ -19,10 +19,10 @@ 
 	private $cache;
 
 	public static function getDefaultInstance() {
-		return new self( MediaWikiServices::getInstance()->getMainWANObjectCache() );
+		return new self(MediaWikiServices::getInstance()->getMainWANObjectCache());
 	}
 
-	public function __construct( WANObjectCache $cache ) {
+	public function __construct(WANObjectCache $cache) {
 		$this->cache = $cache;
 	}
 
@@ -31,12 +31,12 @@ 
 	 * @param string|null $languageCode defaults to user language
 	 * @return string cache key
 	 */
-	public function makeKey( EntityId $entityId, $languageCode = null ) {
+	public function makeKey(EntityId $entityId, $languageCode = null) {
 		global $wgLang, $wgContLang;
-		if ( $languageCode === null ) {
+		if ($languageCode === null) {
 			$languageCode = $wgLang->getCode();
 		}
-		if ( !Language::isKnownLanguageTag( $languageCode ) && $languageCode !== 'qqx' ) {
+		if (!Language::isKnownLanguageTag($languageCode) && $languageCode !== 'qqx') {
 			$languageCode = $wgContLang->getCode();
 		}
 		return $this->cache->makeKey(
@@ -55,8 +55,8 @@ 
 	 * @param float &$asOf
 	 * @return mixed
 	 */
-	public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null ) {
-		return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $asOf );
+	public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null) {
+		return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $asOf);
 	}
 
 	/**
@@ -66,20 +66,20 @@ 
 	 * @param array $opts
 	 * @return bool
 	 */
-	public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) {
-		return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts );
+	public function set(EntityId $key, $value, $ttl = 0, array $opts = []) {
+		return $this->cache->set($this->makeKey($key), $value, $ttl, $opts);
 	}
 
 	/**
 	 * @param EntityId $key
 	 * @return bool
 	 */
-	public function delete( EntityId $key ) {
+	public function delete(EntityId $key) {
 		$ok = true;
-		$languageCodes = array_keys( Language::fetchLanguageNames( null, 'all' ) );
+		$languageCodes = array_keys(Language::fetchLanguageNames(null, 'all'));
 		$languageCodes[] = 'qqx';
-		foreach ( $languageCodes as $languageCode ) {
-			$ok = $this->cache->delete( $this->makeKey( $key, $languageCode ) ) && $ok;
+		foreach ($languageCodes as $languageCode) {
+			$ok = $this->cache->delete($this->makeKey($key, $languageCode)) && $ok;
 		}
 		return $ok;
 	}

maintenance/ImportConstraintStatements.php

Spacing +16 added lines, -16 removed lines

@@ -9,10 +9,10 @@ 
 use Wikibase\Repo\WikibaseRepo;
 
 // @codeCoverageIgnoreStart
-$basePath = getenv( "MW_INSTALL_PATH" ) !== false
-	? getenv( "MW_INSTALL_PATH" ) : __DIR__ . "/../../..";
+$basePath = getenv("MW_INSTALL_PATH") !== false
+	? getenv("MW_INSTALL_PATH") : __DIR__."/../../..";
 
-require_once $basePath . "/maintenance/Maintenance.php";
+require_once $basePath."/maintenance/Maintenance.php";
 // @codeCoverageIgnoreEnd
 
 /**
@@ -38,31 +38,31 @@ 
 		parent::__construct();
 		$repo = WikibaseRepo::getDefaultInstance();
 		$this->propertyInfoLookup = $repo->getStore()->getPropertyInfoLookup();
-		$this->newUpdateConstraintsTableJob = function ( $propertyIdSerialization ) {
+		$this->newUpdateConstraintsTableJob = function($propertyIdSerialization) {
 			return UpdateConstraintsTableJob::newFromGlobalState(
 				Title::newMainPage(),
-				[ 'propertyId' => $propertyIdSerialization ]
+				['propertyId' => $propertyIdSerialization]
 			);
 		};
 
-		$this->addDescription( 'Imports property constraints from statements on properties' );
-		$this->requireExtension( 'WikibaseQualityConstraints' );
+		$this->addDescription('Imports property constraints from statements on properties');
+		$this->requireExtension('WikibaseQualityConstraints');
 	}
 
 	public function execute() {
-		if ( !$this->getConfig()->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) ) {
-			$this->error( 'Constraint statements are not enabled. Aborting.' );
+		if (!$this->getConfig()->get('WBQualityConstraintsEnableConstraintsImportFromStatements')) {
+			$this->error('Constraint statements are not enabled. Aborting.');
 			return;
 		}
 
-		foreach ( $this->propertyInfoLookup->getAllPropertyInfo() as $propertyIdSerialization => $info ) {
-			$this->output( sprintf( 'Importing constraint statements for % 6s... ', $propertyIdSerialization ), $propertyIdSerialization );
-			$startTime = microtime( true );
-			$job = call_user_func( $this->newUpdateConstraintsTableJob, $propertyIdSerialization );
+		foreach ($this->propertyInfoLookup->getAllPropertyInfo() as $propertyIdSerialization => $info) {
+			$this->output(sprintf('Importing constraint statements for % 6s... ', $propertyIdSerialization), $propertyIdSerialization);
+			$startTime = microtime(true);
+			$job = call_user_func($this->newUpdateConstraintsTableJob, $propertyIdSerialization);
 			$job->run();
-			$endTime = microtime( true );
-			$millis = ( $endTime - $startTime ) * 1000;
-			$this->output( sprintf( 'done in % 6.2f ms.', $millis ), $propertyIdSerialization );
+			$endTime = microtime(true);
+			$millis = ($endTime - $startTime) * 1000;
+			$this->output(sprintf('done in % 6.2f ms.', $millis), $propertyIdSerialization);
 		}
 	}
 

src/ConstraintCheck/Helper/LoggingHelper.php

Spacing +13 added lines, -13 removed lines

@@ -46,8 +46,8 @@ 
 		$this->dataFactory = $dataFactory;
 		$this->logger = $logger;
 		$this->constraintCheckDurationLimits = [
-			'info' => $config->get( 'WBQualityConstraintsCheckDurationInfoSeconds' ),
-			'warning' => $config->get( 'WBQualityConstraintsCheckDurationWarningSeconds' ),
+			'info' => $config->get('WBQualityConstraintsCheckDurationInfoSeconds'),
+			'warning' => $config->get('WBQualityConstraintsCheckDurationWarningSeconds'),
 		];
 	}
 
@@ -73,46 +73,46 @@ 
 		$durationSeconds,
 		$method
 	) {
-		$constraintCheckerClassShortName = substr( strrchr( $constraintCheckerClass, '\\' ), 1 );
+		$constraintCheckerClassShortName = substr(strrchr($constraintCheckerClass, '\\'), 1);
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
 		$this->dataFactory->timing(
-			'wikibase.quality.constraints.check.timing.' .
-				$constraintTypeItemId . '-' .
+			'wikibase.quality.constraints.check.timing.'.
+				$constraintTypeItemId.'-'.
 				$constraintCheckerClassShortName,
 			$durationSeconds * 1000
 		);
 
 		// find the longest limit (and associated log level) that the duration exceeds
-		foreach ( $this->constraintCheckDurationLimits as $level => $limit ) {
+		foreach ($this->constraintCheckDurationLimits as $level => $limit) {
 			if (
 				// duration exceeds this limit
-				isset( $limit ) && $durationSeconds > $limit &&
+				isset($limit) && $durationSeconds > $limit &&
 				// this limit is longer than previous longest limit
-				( !isset( $limitSeconds ) || $limit > $limitSeconds )
+				(!isset($limitSeconds) || $limit > $limitSeconds)
 			) {
 				$limitSeconds = $limit;
 				$logLevel = $level;
 			}
 		}
 
-		if ( !isset( $limitSeconds ) ) {
+		if (!isset($limitSeconds)) {
 			return;
 		}
-		if ( $context->getType() !== Context::TYPE_STATEMENT ) {
+		if ($context->getType() !== Context::TYPE_STATEMENT) {
 			// TODO log less details but still log something
 			return;
 		}
 
 		$resultMessage = $result->getMessage();
-		if ( $resultMessage instanceof ViolationMessage ) {
+		if ($resultMessage instanceof ViolationMessage) {
 			$resultMessage = $resultMessage->getMessageKey();
 		}
 
 		$this->logger->log(
 			$logLevel,
-			'Constraint check with {constraintCheckerClassShortName} ' .
-			'took longer than {limitSeconds} second(s) ' .
+			'Constraint check with {constraintCheckerClassShortName} '.
+			'took longer than {limitSeconds} second(s) '.
 			'(duration: {durationSeconds} seconds).',
 			[
 				'method' => $method,