wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Context/QualifierContext.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
 		Statement $statement,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 	}
 
@@ -31,9 +31,9 @@ 
 		return self::TYPE_QUALIFIER;
 	}
 
-	public function getSnakGroup( $groupingMode, array $separators = [] ) {
+	public function getSnakGroup($groupingMode, array $separators = []) {
 		$snaks = $this->statement->getQualifiers();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor() {

src/ConstraintCheck/Context/ReferenceContext.php

Spacing +3 added lines, -3 removed lines

@@ -30,7 +30,7 @@ 
 		Reference $reference,
 		Snak $snak
 	) {
-		parent::__construct( $entity, $snak );
+		parent::__construct($entity, $snak);
 		$this->statement = $statement;
 		$this->reference = $reference;
 	}
@@ -39,9 +39,9 @@ 
 		return self::TYPE_REFERENCE;
 	}
 
-	public function getSnakGroup( $groupingMode, array $separators = [] ) {
+	public function getSnakGroup($groupingMode, array $separators = []) {
 		$snaks = $this->reference->getSnaks();
-		return array_values( $snaks->getArrayCopy() );
+		return array_values($snaks->getArrayCopy());
 	}
 
 	public function getCursor() {

src/ConstraintCheck/Context/Context.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
 	 * @return Snak[] not a SnakList because for a statement context,
 	 * the returned value might contain the same snak several times.
 	 */
-	public function getSnakGroup( $groupingMode, array $separators = [] );
+	public function getSnakGroup($groupingMode, array $separators = []);
 
 	/**
 	 * Get the cursor that can be used to address check results for this context.

src/ConstraintCheck/Checker/SingleBestValueChecker.php

Spacing +16 added lines, -16 removed lines

@@ -66,9 +66,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -80,13 +80,13 @@ 
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$bestRankCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_BEST_RANK, $separators ),
+			$context->getSnakGroup(Context::GROUP_BEST_RANK, $separators),
 			$propertyId
 		);
 
-		if ( $bestRankCount > 1 ) {
+		if ($bestRankCount > 1) {
 			$nonDeprecatedCount = $this->valueCountCheckerHelper->getPropertyCount(
-				$context->getSnakGroup( Context::GROUP_NON_DEPRECATED ),
+				$context->getSnakGroup(Context::GROUP_NON_DEPRECATED),
 				$propertyId
 			);
 			$message = $this->getViolationMessage(
@@ -101,15 +101,15 @@ 
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;
@@ -128,23 +128,23 @@ 
 		$separators,
 		$propertyId
 	) {
-		if ( $bestRankCount === $nonDeprecatedCount ) {
-			if ( $separators === [] ) {
+		if ($bestRankCount === $nonDeprecatedCount) {
+			if ($separators === []) {
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred';
 			} else {
 				$messageKey = 'wbqc-violation-message-single-best-value-no-preferred-separators';
 			}
 		} else {
-			if ( $separators === [] ) {
+			if ($separators === []) {
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred';
 			} else {
 				$messageKey = 'wbqc-violation-message-single-best-value-multi-preferred-separators';
 			}
 		}
 
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $propertyId )
-			->withEntityIdList( $separators );
+		return (new ViolationMessage($messageKey))
+			->withEntityId($propertyId)
+			->withEntityIdList($separators);
 	}
 
 }

src/ConstraintCheck/Checker/SingleValueChecker.php

Spacing +15 added lines, -16 removed lines

@@ -67,9 +67,9 @@ 
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -81,19 +81,19 @@ 
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
 			$propertyId
 		);
 
-		if ( $propertyCount > 1 ) {
-			$message = $this->getViolationMessage( $separators, $propertyId );
+		if ($propertyCount > 1) {
+			$message = $this->getViolationMessage($separators, $propertyId);
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
 	/**
@@ -101,22 +101,21 @@ 
 	 * @param PropertyId $propertyId
 	 * @return ViolationMessage
 	 */
-	private function getViolationMessage( array $separators, PropertyId $propertyId ) {
+	private function getViolationMessage(array $separators, PropertyId $propertyId) {
 		$messageKey = $separators === [] ?
-			'wbqc-violation-message-single-value' :
-			'wbqc-violation-message-single-value-separators';
+			'wbqc-violation-message-single-value' : 'wbqc-violation-message-single-value-separators';
 
-		return ( new ViolationMessage( $messageKey ) )
-			->withEntityId( $propertyId )
-			->withEntityIdList( $separators );
+		return (new ViolationMessage($messageKey))
+			->withEntityId($propertyId)
+			->withEntityIdList($separators);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/MultiValueChecker.php

Spacing +14 added lines, -15 removed lines

@@ -65,9 +65,9 @@ 
 	 *
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
@@ -79,33 +79,32 @@ 
 
 		$propertyId = $context->getSnak()->getPropertyId();
 		$propertyCount = $this->valueCountCheckerHelper->getPropertyCount(
-			$context->getSnakGroup( Context::GROUP_NON_DEPRECATED, $separators ),
+			$context->getSnakGroup(Context::GROUP_NON_DEPRECATED, $separators),
 			$propertyId
 		);
 
-		if ( $propertyCount <= 1 ) {
-			$message = ( new ViolationMessage(
+		if ($propertyCount <= 1) {
+			$message = (new ViolationMessage(
 					$separators === [] ?
-						'wbqc-violation-message-multi-value' :
-						'wbqc-violation-message-multi-value-separators'
-				) )
-				->withEntityId( $propertyId )
-				->withEntityIdList( $separators );
+						'wbqc-violation-message-multi-value' : 'wbqc-violation-message-multi-value-separators'
+				))
+				->withEntityId($propertyId)
+				->withEntityIdList($separators);
 			$status = CheckResult::STATUS_VIOLATION;
 		} else {
 			$message = null;
 			$status = CheckResult::STATUS_COMPLIANCE;
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseSeparatorsParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseSeparatorsParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

src/ConstraintCheck/Checker/CitationNeededChecker.php

Spacing +7 added lines, -7 removed lines

@@ -30,15 +30,15 @@ 
 	 * @codeCoverageIgnore This method is purely declarative.
 	 */
 	public function getDefaultContextTypes() {
-		return [ Context::TYPE_STATEMENT ];
+		return [Context::TYPE_STATEMENT];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$referenceList = $context->getSnakStatement()->getReferences();
 
-		if ( $referenceList->isEmpty() ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-citationNeeded' ) )
-				->withEntityId( $context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY );
+		if ($referenceList->isEmpty()) {
+			$message = (new ViolationMessage('wbqc-violation-message-citationNeeded'))
+				->withEntityId($context->getSnak()->getPropertyId(), Role::CONSTRAINT_PROPERTY);
 			return new CheckResult(
 				$context,
 				$constraint,
@@ -48,10 +48,10 @@ 
 			);
 		}
 
-		return new CheckResult( $context, $constraint, [], CheckResult::STATUS_COMPLIANCE );
+		return new CheckResult($context, $constraint, [], CheckResult::STATUS_COMPLIANCE);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		// no parameters
 		return [];
 	}

src/Api/ResultsCache.php

Spacing +8 added lines, -8 removed lines

@@ -36,7 +36,7 @@ 
 	 * @param WANObjectCache $cache
 	 * @param string $formatVersion The version of the API response format.
 	 */
-	public function __construct( WANObjectCache $cache, $formatVersion ) {
+	public function __construct(WANObjectCache $cache, $formatVersion) {
 		$this->cache = $cache;
 		$this->formatVersion = $formatVersion;
 	}
@@ -45,7 +45,7 @@ 
 	 * @param EntityId $entityId
 	 * @return string cache key
 	 */
-	public function makeKey( EntityId $entityId ) {
+	public function makeKey(EntityId $entityId) {
 		return $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'checkConstraints', // action
@@ -61,8 +61,8 @@ 
 	 * @param float &$asOf UNIX timestamp of cached value; null on failure [returned]
 	 * @return mixed
 	 */
-	public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null ) {
-		return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $asOf );
+	public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], &$asOf = null) {
+		return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $asOf);
 	}
 
 	/**
@@ -72,16 +72,16 @@ 
 	 * @param array $opts
 	 * @return bool
 	 */
-	public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) {
-		return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts );
+	public function set(EntityId $key, $value, $ttl = 0, array $opts = []) {
+		return $this->cache->set($this->makeKey($key), $value, $ttl, $opts);
 	}
 
 	/**
 	 * @param EntityId $key
 	 * @return bool
 	 */
-	public function delete( EntityId $key ) {
-		return $this->cache->delete( $this->makeKey( $key ) );
+	public function delete(EntityId $key) {
+		return $this->cache->delete($this->makeKey($key));
 	}
 
 }

src/ConstraintCheck/Checker/PropertyScopeChecker.php

Spacing +8 added lines, -8 removed lines

@@ -49,7 +49,7 @@ 
 		];
 	}
 
-	public function checkConstraint( Context $context, Constraint $constraint ) {
+	public function checkConstraint(Context $context, Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -58,7 +58,7 @@ 
 			$constraintTypeItemId
 		);
 
-		if ( in_array( $context->getType(), $allowedContextTypes ) ) {
+		if (in_array($context->getType(), $allowedContextTypes)) {
 			return new CheckResult(
 				$context->getCursor(),
 				$constraint,
@@ -71,15 +71,15 @@ 
 				$constraint,
 				[],
 				CheckResult::STATUS_VIOLATION,
-				( new ViolationMessage( 'wbqc-violation-message-property-scope' ) )
-					->withEntityId( $context->getSnak()->getPropertyId() )
-					->withPropertyScope( $context->getType() )
-					->withPropertyScopeList( $allowedContextTypes )
+				(new ViolationMessage('wbqc-violation-message-property-scope'))
+					->withEntityId($context->getSnak()->getPropertyId())
+					->withPropertyScope($context->getType())
+					->withPropertyScopeList($allowedContextTypes)
 			);
 		}
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -88,7 +88,7 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;