Completed
Push — master ( 9f6ed0...b13dcc )
by
unknown
39s
created
src/ConstraintCheck/Context/ContextCursorSerializer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@  discard block
 block discarded – undo
13 13
 	 * @param ContextCursor $cursor
14 14
 	 * @return array
15 15
 	 */
16
-	public function serialize( ContextCursor $cursor ) {
17
-		if ( $cursor instanceof EntityContextCursor ) {
16
+	public function serialize(ContextCursor $cursor) {
17
+		if ($cursor instanceof EntityContextCursor) {
18 18
 			return [
19 19
 				't' => '\entity',
20 20
 				'i' => $cursor->getEntityId(),
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 			'h' => $cursor->getSnakHash(),
31 31
 		];
32 32
 
33
-		if ( $type === Context::TYPE_QUALIFIER || $type === Context::TYPE_REFERENCE ) {
33
+		if ($type === Context::TYPE_QUALIFIER || $type === Context::TYPE_REFERENCE) {
34 34
 			$serialization['P'] = $cursor->getSnakPropertyId();
35
-			if ( $type === Context::TYPE_REFERENCE ) {
35
+			if ($type === Context::TYPE_REFERENCE) {
36 36
 				/** @var ReferenceContextCursor $cursor */
37 37
 				'@phan-var ReferenceContextCursor $cursor';
38 38
 				$serialization['r'] = $cursor->getReferenceHash();
Please login to merge, or discard this patch.
src/ConstraintCheck/Checker/RangeChecker.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
 	 * @throws ConstraintParameterException
85 85
 	 * @return CheckResult
86 86
 	 */
87
-	public function checkConstraint( Context $context, Constraint $constraint ) {
88
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
89
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
87
+	public function checkConstraint(Context $context, Constraint $constraint) {
88
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
89
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
90 90
 		}
91 91
 
92 92
 		$parameters = [];
@@ -94,28 +94,28 @@  discard block
 block discarded – undo
94 94
 
95 95
 		$snak = $context->getSnak();
96 96
 
97
-		if ( !$snak instanceof PropertyValueSnak ) {
97
+		if (!$snak instanceof PropertyValueSnak) {
98 98
 			// nothing to check
99
-			return new CheckResult( $context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE );
99
+			return new CheckResult($context, $constraint, $parameters, CheckResult::STATUS_COMPLIANCE);
100 100
 		}
101 101
 
102 102
 		$dataValue = $snak->getDataValue();
103 103
 
104
-		list( $min, $max ) = $this->parseRangeParameter(
104
+		list($min, $max) = $this->parseRangeParameter(
105 105
 			$constraintParameters,
106 106
 			$constraint->getConstraintTypeItemId(),
107 107
 			$dataValue->getType()
108 108
 		);
109 109
 		$parameterKey = $dataValue->getType() === 'quantity' ? 'quantity' : 'date';
110
-		if ( $min !== null ) {
111
-			$parameters['minimum_' . $parameterKey] = [ $min ];
110
+		if ($min !== null) {
111
+			$parameters['minimum_'.$parameterKey] = [$min];
112 112
 		}
113
-		if ( $max !== null ) {
114
-			$parameters['maximum_' . $parameterKey] = [ $max ];
113
+		if ($max !== null) {
114
+			$parameters['maximum_'.$parameterKey] = [$max];
115 115
 		}
116 116
 
117
-		if ( $this->rangeCheckerHelper->getComparison( $min, $dataValue ) > 0 ||
118
-			 $this->rangeCheckerHelper->getComparison( $dataValue, $max ) > 0
117
+		if ($this->rangeCheckerHelper->getComparison($min, $dataValue) > 0 ||
118
+			 $this->rangeCheckerHelper->getComparison($dataValue, $max) > 0
119 119
 		) {
120 120
 			$message = $this->getViolationMessage(
121 121
 				$context->getSnak()->getPropertyId(),
@@ -131,16 +131,16 @@  discard block
 block discarded – undo
131 131
 
132 132
 		if (
133 133
 			$dataValue instanceof TimeValue &&
134
-			( $min instanceof NowValue || $max instanceof NowValue ) &&
135
-			$this->rangeCheckerHelper->isFutureTime( $dataValue )
134
+			($min instanceof NowValue || $max instanceof NowValue) &&
135
+			$this->rangeCheckerHelper->isFutureTime($dataValue)
136 136
 		) {
137
-			$dependencyMetadata = DependencyMetadata::ofFutureTime( $dataValue );
137
+			$dependencyMetadata = DependencyMetadata::ofFutureTime($dataValue);
138 138
 		} else {
139 139
 			$dependencyMetadata = DependencyMetadata::blank();
140 140
 		}
141 141
 
142
-		return ( new CheckResult( $context, $constraint, $parameters, $status, $message ) )
143
-			->withMetadata( Metadata::ofDependencyMetadata( $dependencyMetadata ) );
142
+		return (new CheckResult($context, $constraint, $parameters, $status, $message))
143
+			->withMetadata(Metadata::ofDependencyMetadata($dependencyMetadata));
144 144
 	}
145 145
 
146 146
 	/**
@@ -151,8 +151,8 @@  discard block
 block discarded – undo
151 151
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
152 152
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
153 153
 	 */
154
-	private function parseRangeParameter( array $constraintParameters, $constraintTypeItemId, $type ) {
155
-		switch ( $type ) {
154
+	private function parseRangeParameter(array $constraintParameters, $constraintTypeItemId, $type) {
155
+		switch ($type) {
156 156
 			case 'quantity':
157 157
 				return $this->constraintParameterParser->parseQuantityRangeParameter(
158 158
 					$constraintParameters,
@@ -166,10 +166,10 @@  discard block
 block discarded – undo
166 166
 		}
167 167
 
168 168
 		throw new ConstraintParameterException(
169
-			( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) )
170
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
171
-				->withDataValueType( 'quantity' )
172
-				->withDataValueType( 'time' )
169
+			(new ViolationMessage('wbqc-violation-message-value-needed-of-types-2'))
170
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
171
+				->withDataValueType('quantity')
172
+				->withDataValueType('time')
173 173
 		);
174 174
 	}
175 175
 
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 	 *
182 182
 	 * @return ViolationMessage
183 183
 	 */
184
-	private function getViolationMessage( PropertyId $predicate, DataValue $value, $min, $max ) {
184
+	private function getViolationMessage(PropertyId $predicate, DataValue $value, $min, $max) {
185 185
 		// possible message keys:
186 186
 		// wbqc-violation-message-range-quantity-closed
187 187
 		// wbqc-violation-message-range-quantity-leftopen
@@ -194,39 +194,39 @@  discard block
 block discarded – undo
194 194
 		// wbqc-violation-message-range-time-rightopen
195 195
 		// wbqc-violation-message-range-time-rightopen-leftnow
196 196
 		$messageKey = 'wbqc-violation-message-range';
197
-		$messageKey .= '-' . $value->getType();
197
+		$messageKey .= '-'.$value->getType();
198 198
 		// at least one of $min, $max is set, otherwise there could be no violation
199
-		$messageKey .= '-' . ( $min !== null ? ( $max !== null ? 'closed' : 'rightopen' ) : 'leftopen' );
200
-		if ( $min instanceof NowValue ) {
199
+		$messageKey .= '-'.($min !== null ? ($max !== null ? 'closed' : 'rightopen') : 'leftopen');
200
+		if ($min instanceof NowValue) {
201 201
 			$messageKey .= '-leftnow';
202
-		} elseif ( $max instanceof NowValue ) {
202
+		} elseif ($max instanceof NowValue) {
203 203
 			$messageKey .= '-rightnow';
204 204
 		}
205
-		$message = ( new ViolationMessage( $messageKey ) )
206
-			->withEntityId( $predicate, Role::PREDICATE )
207
-			->withDataValue( $value, Role::OBJECT );
208
-		if ( $min !== null && !( $min instanceof NowValue ) ) {
209
-			$message = $message->withDataValue( $min, Role::OBJECT );
205
+		$message = (new ViolationMessage($messageKey))
206
+			->withEntityId($predicate, Role::PREDICATE)
207
+			->withDataValue($value, Role::OBJECT);
208
+		if ($min !== null && !($min instanceof NowValue)) {
209
+			$message = $message->withDataValue($min, Role::OBJECT);
210 210
 		}
211
-		if ( $max !== null && !( $max instanceof NowValue ) ) {
212
-			$message = $message->withDataValue( $max, Role::OBJECT );
211
+		if ($max !== null && !($max instanceof NowValue)) {
212
+			$message = $message->withDataValue($max, Role::OBJECT);
213 213
 		}
214 214
 		return $message;
215 215
 	}
216 216
 
217
-	public function checkConstraintParameters( Constraint $constraint ) {
217
+	public function checkConstraintParameters(Constraint $constraint) {
218 218
 		$constraintParameters = $constraint->getConstraintParameters();
219 219
 		$exceptions = [];
220 220
 		try {
221 221
 			// we don’t have a data value here, so get the type from the property instead
222 222
 			// (the distinction between data type and data value type is irrelevant for 'quantity' and 'time')
223
-			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty( $constraint->getPropertyId() );
223
+			$type = $this->propertyDataTypeLookup->getDataTypeIdForProperty($constraint->getPropertyId());
224 224
 			$this->parseRangeParameter(
225 225
 				$constraintParameters,
226 226
 				$constraint->getConstraintTypeItemId(),
227 227
 				$type
228 228
 			);
229
-		} catch ( ConstraintParameterException $e ) {
229
+		} catch (ConstraintParameterException $e) {
230 230
 			$exceptions[] = $e;
231 231
 		}
232 232
 		return $exceptions;
Please login to merge, or discard this patch.
src/CachingConstraintLookup.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 	/**
27 27
 	 * @param ConstraintLookup $lookup The lookup to which all queries are delegated.
28 28
 	 */
29
-	public function __construct( ConstraintLookup $lookup ) {
29
+	public function __construct(ConstraintLookup $lookup) {
30 30
 		$this->lookup = $lookup;
31 31
 	}
32 32
 
@@ -35,10 +35,10 @@  discard block
 block discarded – undo
35 35
 	 *
36 36
 	 * @return Constraint[]
37 37
 	 */
38
-	public function queryConstraintsForProperty( PropertyId $propertyId ) {
38
+	public function queryConstraintsForProperty(PropertyId $propertyId) {
39 39
 		$id = $propertyId->getSerialization();
40
-		if ( !array_key_exists( $id, $this->cache ) ) {
41
-			$this->cache[$id] = $this->lookup->queryConstraintsForProperty( $propertyId );
40
+		if (!array_key_exists($id, $this->cache)) {
41
+			$this->cache[$id] = $this->lookup->queryConstraintsForProperty($propertyId);
42 42
 		}
43 43
 		return $this->cache[$id];
44 44
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Context/ContextCursor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,6 +65,6 @@
 block discarded – undo
65 65
 	 * @param ?array $result
66 66
 	 * @param array[] &$container
67 67
 	 */
68
-	public function storeCheckResultInArray( ?array $result, array &$container );
68
+	public function storeCheckResultInArray(?array $result, array &$container);
69 69
 
70 70
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Context/EntityContextCursor.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 * @codeCoverageIgnore This method is not supported.
36 36
 	 */
37 37
 	public function getType() {
38
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
38
+		throw new LogicException('EntityContextCursor has no full associated context');
39 39
 	}
40 40
 
41 41
 	public function getEntityId() {
@@ -46,35 +46,35 @@  discard block
 block discarded – undo
46 46
 	 * @codeCoverageIgnore This method is not supported.
47 47
 	 */
48 48
 	public function getStatementPropertyId() {
49
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
49
+		throw new LogicException('EntityContextCursor has no full associated context');
50 50
 	}
51 51
 
52 52
 	/**
53 53
 	 * @codeCoverageIgnore This method is not supported.
54 54
 	 */
55 55
 	public function getStatementGuid() {
56
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
56
+		throw new LogicException('EntityContextCursor has no full associated context');
57 57
 	}
58 58
 
59 59
 	/**
60 60
 	 * @codeCoverageIgnore This method is not supported.
61 61
 	 */
62 62
 	public function getSnakPropertyId() {
63
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
63
+		throw new LogicException('EntityContextCursor has no full associated context');
64 64
 	}
65 65
 
66 66
 	/**
67 67
 	 * @codeCoverageIgnore This method is not supported.
68 68
 	 */
69 69
 	public function getSnakHash() {
70
-		throw new LogicException( 'EntityContextCursor has no full associated context' );
70
+		throw new LogicException('EntityContextCursor has no full associated context');
71 71
 	}
72 72
 
73 73
 	/**
74 74
 	 * @codeCoverageIgnore This method is not supported.
75 75
 	 */
76
-	public function &getMainArray( array &$container ) {
77
-		throw new LogicException( 'EntityContextCursor cannot store check results' );
76
+	public function &getMainArray(array &$container) {
77
+		throw new LogicException('EntityContextCursor cannot store check results');
78 78
 	}
79 79
 
80 80
 	/**
@@ -83,14 +83,14 @@  discard block
 block discarded – undo
83 83
 	 * @param ?array $result must be null
84 84
 	 * @param array[] &$container
85 85
 	 */
86
-	public function storeCheckResultInArray( ?array $result, array &$container ) {
87
-		if ( $result !== null ) {
88
-			throw new LogicException( 'EntityContextCursor cannot store check results' );
86
+	public function storeCheckResultInArray(?array $result, array &$container) {
87
+		if ($result !== null) {
88
+			throw new LogicException('EntityContextCursor cannot store check results');
89 89
 		}
90 90
 
91 91
 		// this ensures that the claims array is present in the $container,
92 92
 		// populating it if necessary, even though we ignore the return value
93
-		$this->getClaimsArray( $container );
93
+		$this->getClaimsArray($container);
94 94
 	}
95 95
 
96 96
 }
Please login to merge, or discard this patch.
src/ConstraintCheck/Context/ApiV2ContextCursor.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -27,15 +27,15 @@  discard block
 block discarded – undo
27 27
 	 * @param array[] &$container
28 28
 	 * @return array
29 29
 	 */
30
-	protected function &getClaimsArray( array &$container ) {
30
+	protected function &getClaimsArray(array &$container) {
31 31
 		$entityId = $this->getEntityId();
32 32
 
33
-		if ( !array_key_exists( $entityId, $container ) ) {
33
+		if (!array_key_exists($entityId, $container)) {
34 34
 			$container[$entityId] = [];
35 35
 		}
36 36
 		$entityContainer = &$container[$entityId];
37 37
 
38
-		if ( !array_key_exists( 'claims', $entityContainer ) ) {
38
+		if (!array_key_exists('claims', $entityContainer)) {
39 39
 			$entityContainer['claims'] = [];
40 40
 		}
41 41
 		$claimsArray = &$entityContainer['claims'];
@@ -49,25 +49,25 @@  discard block
 block discarded – undo
49 49
 	 * @param array[] &$container
50 50
 	 * @return array
51 51
 	 */
52
-	protected function &getStatementArray( array &$container ) {
52
+	protected function &getStatementArray(array &$container) {
53 53
 		$statementPropertyId = $this->getStatementPropertyId();
54 54
 		$statementGuid = $this->getStatementGuid();
55 55
 
56
-		$claimsContainer = &$this->getClaimsArray( $container );
56
+		$claimsContainer = &$this->getClaimsArray($container);
57 57
 
58
-		if ( !array_key_exists( $statementPropertyId, $claimsContainer ) ) {
58
+		if (!array_key_exists($statementPropertyId, $claimsContainer)) {
59 59
 			$claimsContainer[$statementPropertyId] = [];
60 60
 		}
61 61
 		$propertyContainer = &$claimsContainer[$statementPropertyId];
62 62
 
63
-		foreach ( $propertyContainer as &$statement ) {
64
-			if ( $statement['id'] === $statementGuid ) {
63
+		foreach ($propertyContainer as &$statement) {
64
+			if ($statement['id'] === $statementGuid) {
65 65
 				$statementArray = &$statement;
66 66
 				break;
67 67
 			}
68 68
 		}
69
-		if ( !isset( $statementArray ) ) {
70
-			$statementArray = [ 'id' => $statementGuid ];
69
+		if (!isset($statementArray)) {
70
+			$statementArray = ['id' => $statementGuid];
71 71
 			$propertyContainer[] = &$statementArray;
72 72
 		}
73 73
 
@@ -82,19 +82,19 @@  discard block
 block discarded – undo
82 82
 	 * @param array[] &$container
83 83
 	 * @return array
84 84
 	 */
85
-	abstract protected function &getMainArray( array &$container );
85
+	abstract protected function &getMainArray(array &$container);
86 86
 
87 87
 	/**
88 88
 	 * @param ?array $result
89 89
 	 * @param array[] &$container
90 90
 	 */
91
-	public function storeCheckResultInArray( ?array $result, array &$container ) {
92
-		$mainArray = &$this->getMainArray( $container );
93
-		if ( !array_key_exists( 'results', $mainArray ) ) {
91
+	public function storeCheckResultInArray(?array $result, array &$container) {
92
+		$mainArray = &$this->getMainArray($container);
93
+		if (!array_key_exists('results', $mainArray)) {
94 94
 			$mainArray['results'] = [];
95 95
 		}
96 96
 
97
-		if ( $result !== null ) {
97
+		if ($result !== null) {
98 98
 			$mainArray['results'][] = $result;
99 99
 		}
100 100
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/ItemIdSnakValue.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * @param ItemId $itemId
45 45
 	 * @return self
46 46
 	 */
47
-	public static function fromItemId( ItemId $itemId ) {
47
+	public static function fromItemId(ItemId $itemId) {
48 48
 		$ret = new self;
49 49
 		$ret->itemId = $itemId;
50 50
 		return $ret;
@@ -80,14 +80,14 @@  discard block
 block discarded – undo
80 80
 	 * @throws InvalidArgumentException
81 81
 	 * @return self
82 82
 	 */
83
-	public static function fromSnak( Snak $snak ) {
84
-		switch ( true ) {
83
+	public static function fromSnak(Snak $snak) {
84
+		switch (true) {
85 85
 			case $snak instanceof PropertyValueSnak:
86 86
 				$dataValue = $snak->getDataValue();
87
-				if ( $dataValue instanceof EntityIdValue ) {
87
+				if ($dataValue instanceof EntityIdValue) {
88 88
 					$itemId = $dataValue->getEntityId();
89
-					if ( $itemId instanceof ItemId ) {
90
-						return self::fromItemId( $itemId );
89
+					if ($itemId instanceof ItemId) {
90
+						return self::fromItemId($itemId);
91 91
 					}
92 92
 				}
93 93
 				break;
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 				return self::noValue();
98 98
 		}
99 99
 
100
-		throw new InvalidArgumentException( 'Snak must contain item ID value or be a somevalue / novalue snak' );
100
+		throw new InvalidArgumentException('Snak must contain item ID value or be a somevalue / novalue snak');
101 101
 	}
102 102
 
103 103
 	/**
@@ -135,8 +135,8 @@  discard block
 block discarded – undo
135 135
 	 * @return ItemId
136 136
 	 */
137 137
 	public function getItemId() {
138
-		if ( !$this->isValue() ) {
139
-			throw new DomainException( 'This value does not contain an item ID.' );
138
+		if (!$this->isValue()) {
139
+			throw new DomainException('This value does not contain an item ID.');
140 140
 		}
141 141
 		return $this->itemId;
142 142
 	}
@@ -148,14 +148,14 @@  discard block
 block discarded – undo
148 148
 	 * @param Snak $snak
149 149
 	 * @return bool
150 150
 	 */
151
-	public function matchesSnak( Snak $snak ) {
152
-		switch ( true ) {
151
+	public function matchesSnak(Snak $snak) {
152
+		switch (true) {
153 153
 			case $snak instanceof PropertyValueSnak:
154 154
 				$dataValue = $snak->getDataValue();
155 155
 				return $this->isValue() &&
156 156
 					$dataValue instanceof EntityIdValue &&
157 157
 					$dataValue->getEntityId() instanceof ItemId &&
158
-					$dataValue->getEntityId()->equals( $this->getItemId() );
158
+					$dataValue->getEntityId()->equals($this->getItemId());
159 159
 			case $snak instanceof PropertySomeValueSnak:
160 160
 				return $this->isSomeValue();
161 161
 			case $snak instanceof PropertyNoValueSnak:
Please login to merge, or discard this patch.
src/Api/CheckConstraintsRdf.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 		EntityIdLookup $entityIdLookup,
48 48
 		RdfVocabulary $rdfVocabulary
49 49
 	) {
50
-		parent::__construct( $page, $context );
50
+		parent::__construct($page, $context);
51 51
 		$this->resultsSource = $resultsSource;
52 52
 		$this->entityIdLookup = $entityIdLookup;
53 53
 		$this->rdfVocabulary = $rdfVocabulary;
@@ -108,8 +108,8 @@  discard block
 block discarded – undo
108 108
 	 * @param string $guid
109 109
 	 * @return string
110 110
 	 */
111
-	private function cleanupGuid( $guid ) {
112
-		return preg_replace( '/[^\w-]/', '-', $guid );
111
+	private function cleanupGuid($guid) {
112
+		return preg_replace('/[^\w-]/', '-', $guid);
113 113
 	}
114 114
 
115 115
 	/**
@@ -121,60 +121,60 @@  discard block
 block discarded – undo
121 121
 		$response = $this->getRequest()->response();
122 122
 		$this->getOutput()->disable();
123 123
 
124
-		if ( !$this->resultsSource instanceof CachingResultsSource ) {
124
+		if (!$this->resultsSource instanceof CachingResultsSource) {
125 125
 			// TODO: make configurable whether only cached results are returned
126
-			$response->statusHeader( 501 ); // Not Implemented
126
+			$response->statusHeader(501); // Not Implemented
127 127
 			return null;
128 128
 		}
129 129
 
130
-		$entityId = $this->entityIdLookup->getEntityIdForTitle( $this->getTitle() );
131
-		if ( $entityId === null ) {
132
-			$response->statusHeader( 404 ); // Not Found
130
+		$entityId = $this->entityIdLookup->getEntityIdForTitle($this->getTitle());
131
+		if ($entityId === null) {
132
+			$response->statusHeader(404); // Not Found
133 133
 			return null;
134 134
 		}
135
-		$revId = $this->getRequest()->getInt( 'revision' );
135
+		$revId = $this->getRequest()->getInt('revision');
136 136
 
137
-		$results = $this->resultsSource->getStoredResults( $entityId, $revId );
138
-		if ( $results === null ) {
139
-			$response->statusHeader( 204 ); // No Content
137
+		$results = $this->resultsSource->getStoredResults($entityId, $revId);
138
+		if ($results === null) {
139
+			$response->statusHeader(204); // No Content
140 140
 			return null;
141 141
 		}
142 142
 
143 143
 		$format = 'ttl'; // TODO: make format an option
144 144
 
145 145
 		$writerFactory = new RdfWriterFactory();
146
-		$formatName = $writerFactory->getFormatName( $format );
147
-		$contentType = $writerFactory->getMimeTypes( $formatName )[0];
146
+		$formatName = $writerFactory->getFormatName($format);
147
+		$contentType = $writerFactory->getMimeTypes($formatName)[0];
148 148
 
149
-		$writer = $writerFactory->getWriter( $formatName );
150
-		foreach ( [ RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY ] as $ns ) {
151
-			$writer->prefix( $ns, $this->rdfVocabulary->getNamespaceURI( $ns ) );
149
+		$writer = $writerFactory->getWriter($formatName);
150
+		foreach ([RdfVocabulary::NS_STATEMENT, RdfVocabulary::NS_ONTOLOGY] as $ns) {
151
+			$writer->prefix($ns, $this->rdfVocabulary->getNamespaceURI($ns));
152 152
 		}
153 153
 		$writer->start();
154 154
 		$writtenAny = false;
155 155
 
156
-		foreach ( $results->getArray() as $checkResult ) {
157
-			if ( $checkResult instanceof NullResult ) {
156
+		foreach ($results->getArray() as $checkResult) {
157
+			if ($checkResult instanceof NullResult) {
158 158
 				continue;
159 159
 			}
160
-			if ( $checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS ) {
160
+			if ($checkResult->getStatus() === CheckResult::STATUS_BAD_PARAMETERS) {
161 161
 				continue;
162 162
 			}
163 163
 			$writtenAny = true;
164
-			$writer->about( RdfVocabulary::NS_STATEMENT,
165
-				$this->cleanupGuid( $checkResult->getContextCursor()->getStatementGuid() ) )
166
-				->say( RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint' )
167
-				->is( RdfVocabulary::NS_STATEMENT,
168
-					$this->cleanupGuid( $checkResult->getConstraint()->getConstraintId() ) );
164
+			$writer->about(RdfVocabulary::NS_STATEMENT,
165
+				$this->cleanupGuid($checkResult->getContextCursor()->getStatementGuid()))
166
+				->say(RdfVocabulary::NS_ONTOLOGY, 'hasViolationForConstraint')
167
+				->is(RdfVocabulary::NS_STATEMENT,
168
+					$this->cleanupGuid($checkResult->getConstraint()->getConstraintId()));
169 169
 		}
170 170
 		$writer->finish();
171
-		if ( $writtenAny ) {
172
-			$response->header( "Content-Type: $contentType; charset=UTF-8" );
171
+		if ($writtenAny) {
172
+			$response->header("Content-Type: $contentType; charset=UTF-8");
173 173
 			echo $writer->drain();
174 174
 		} else {
175 175
 			// Do not output RDF if we haven't written any actual statements. Output 204 instead
176 176
 			$writer->drain();
177
-			$response->statusHeader( 204 ); // No Content
177
+			$response->statusHeader(204); // No Content
178 178
 		}
179 179
 		return null;
180 180
 	}
Please login to merge, or discard this patch.
src/Api/CheckResultsRenderer.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -51,11 +51,11 @@  discard block
 block discarded – undo
51 51
 	 * @param CachedCheckResults $checkResults
52 52
 	 * @return CachedCheckConstraintsResponse
53 53
 	 */
54
-	public function render( CachedCheckResults $checkResults ) {
54
+	public function render(CachedCheckResults $checkResults) {
55 55
 		$response = [];
56
-		foreach ( $checkResults->getArray() as $checkResult ) {
57
-			$resultArray = $this->checkResultToArray( $checkResult );
58
-			$checkResult->getContextCursor()->storeCheckResultInArray( $resultArray, $response );
56
+		foreach ($checkResults->getArray() as $checkResult) {
57
+			$resultArray = $this->checkResultToArray($checkResult);
58
+			$checkResult->getContextCursor()->storeCheckResultInArray($resultArray, $response);
59 59
 		}
60 60
 		return new CachedCheckConstraintsResponse(
61 61
 			$response,
@@ -63,19 +63,19 @@  discard block
 block discarded – undo
63 63
 		);
64 64
 	}
65 65
 
66
-	public function checkResultToArray( CheckResult $checkResult ) {
67
-		if ( $checkResult instanceof NullResult ) {
66
+	public function checkResultToArray(CheckResult $checkResult) {
67
+		if ($checkResult instanceof NullResult) {
68 68
 			return null;
69 69
 		}
70 70
 
71 71
 		$constraintId = $checkResult->getConstraint()->getConstraintId();
72 72
 		$typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId();
73
-		$constraintPropertyId = new PropertyId( $checkResult->getContextCursor()->getSnakPropertyId() );
73
+		$constraintPropertyId = new PropertyId($checkResult->getContextCursor()->getSnakPropertyId());
74 74
 
75
-		$title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId );
75
+		$title = $this->entityTitleLookup->getTitleForId($constraintPropertyId);
76 76
 		$talkTitle = $title->getTalkPageIfDefined();
77
-		$typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) );
78
-		$link = $title->getFullURL() . '#' . $constraintId;
77
+		$typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId));
78
+		$link = $title->getFullURL().'#'.$constraintId;
79 79
 
80 80
 		$constraint = [
81 81
 			'id' => $constraintId,
@@ -91,14 +91,14 @@  discard block
 block discarded – undo
91 91
 			'constraint' => $constraint
92 92
 		];
93 93
 		$message = $checkResult->getMessage();
94
-		if ( $message ) {
95
-			$result['message-html'] = $this->violationMessageRenderer->render( $message );
94
+		if ($message) {
95
+			$result['message-html'] = $this->violationMessageRenderer->render($message);
96 96
 		}
97
-		if ( $checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT ) {
97
+		if ($checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT) {
98 98
 			$result['claim'] = $checkResult->getContextCursor()->getStatementGuid();
99 99
 		}
100 100
 		$cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray();
101
-		if ( $cachingMetadataArray !== null ) {
101
+		if ($cachingMetadataArray !== null) {
102 102
 			$result['cached'] = $cachingMetadataArray;
103 103
 		}
104 104
 
Please login to merge, or discard this patch.