@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport; |
6 | 6 | |
@@ -33,55 +33,55 @@ discard block |
||
33 | 33 | } |
34 | 34 | |
35 | 35 | /** @inheritDoc */ |
36 | - public function onWikibaseChangeNotification( Change $change ): void { |
|
37 | - if ( !( $change instanceof EntityChange ) ) { |
|
36 | + public function onWikibaseChangeNotification(Change $change): void { |
|
37 | + if (!($change instanceof EntityChange)) { |
|
38 | 38 | return; |
39 | 39 | } |
40 | 40 | /** @var EntityChange $change */ |
41 | 41 | |
42 | 42 | // If jobs are enabled and the results would be stored in some way run a job. |
43 | 43 | if ( |
44 | - $this->config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) && |
|
45 | - $this->config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) && |
|
44 | + $this->config->get('WBQualityConstraintsEnableConstraintsCheckJobs') && |
|
45 | + $this->config->get('WBQualityConstraintsCacheCheckConstraintsResults') && |
|
46 | 46 | $this->isSelectedForJobRunBasedOnPercentage() |
47 | 47 | ) { |
48 | - $params = [ 'entityId' => $change->getEntityId()->getSerialization() ]; |
|
48 | + $params = ['entityId' => $change->getEntityId()->getSerialization()]; |
|
49 | 49 | $this->jobQueueGroup->lazyPush( |
50 | - new JobSpecification( CheckConstraintsJob::COMMAND, $params ) |
|
50 | + new JobSpecification(CheckConstraintsJob::COMMAND, $params) |
|
51 | 51 | ); |
52 | 52 | } |
53 | 53 | |
54 | - if ( $this->config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) && |
|
55 | - $this->isConstraintStatementsChange( $change ) |
|
54 | + if ($this->config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') && |
|
55 | + $this->isConstraintStatementsChange($change) |
|
56 | 56 | ) { |
57 | - $params = [ 'propertyId' => $change->getEntityId()->getSerialization() ]; |
|
57 | + $params = ['propertyId' => $change->getEntityId()->getSerialization()]; |
|
58 | 58 | $metadata = $change->getMetadata(); |
59 | - if ( array_key_exists( 'rev_id', $metadata ) ) { |
|
59 | + if (array_key_exists('rev_id', $metadata)) { |
|
60 | 60 | $params['revisionId'] = $metadata['rev_id']; |
61 | 61 | } |
62 | 62 | $this->jobQueueGroup->push( |
63 | - new JobSpecification( 'constraintsTableUpdate', $params ) |
|
63 | + new JobSpecification('constraintsTableUpdate', $params) |
|
64 | 64 | ); |
65 | 65 | } |
66 | 66 | } |
67 | 67 | |
68 | 68 | private function isSelectedForJobRunBasedOnPercentage(): bool { |
69 | - $percentage = $this->config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' ); |
|
69 | + $percentage = $this->config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio'); |
|
70 | 70 | |
71 | - return mt_rand( 1, 100 ) <= $percentage; |
|
71 | + return mt_rand(1, 100) <= $percentage; |
|
72 | 72 | } |
73 | 73 | |
74 | - private function isConstraintStatementsChange( Change $change ): bool { |
|
75 | - if ( !( $change instanceof EntityChange ) || |
|
74 | + private function isConstraintStatementsChange(Change $change): bool { |
|
75 | + if (!($change instanceof EntityChange) || |
|
76 | 76 | $change->getAction() !== EntityChange::UPDATE || |
77 | - !( $change->getEntityId() instanceof NumericPropertyId ) |
|
77 | + !($change->getEntityId() instanceof NumericPropertyId) |
|
78 | 78 | ) { |
79 | 79 | return false; |
80 | 80 | } |
81 | 81 | |
82 | 82 | $info = $change->getInfo(); |
83 | 83 | |
84 | - if ( !array_key_exists( 'compactDiff', $info ) ) { |
|
84 | + if (!array_key_exists('compactDiff', $info)) { |
|
85 | 85 | // the non-compact diff ($info['diff']) does not contain statement diffs (T110996), |
86 | 86 | // so we only know that the change *might* affect the constraint statements |
87 | 87 | return true; |
@@ -90,8 +90,8 @@ discard block |
||
90 | 90 | /** @var EntityDiffChangedAspects $aspects */ |
91 | 91 | $aspects = $info['compactDiff']; |
92 | 92 | |
93 | - $propertyConstraintId = $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ); |
|
94 | - return in_array( $propertyConstraintId, $aspects->getStatementChanges() ); |
|
93 | + $propertyConstraintId = $this->config->get('WBQualityConstraintsPropertyConstraintId'); |
|
94 | + return in_array($propertyConstraintId, $aspects->getStatementChanges()); |
|
95 | 95 | } |
96 | 96 | |
97 | 97 | } |
@@ -29,9 +29,9 @@ discard block |
||
29 | 29 | */ |
30 | 30 | private $isSortable; |
31 | 31 | |
32 | - public function __construct( array $headers ) { |
|
33 | - foreach ( $headers as $header ) { |
|
34 | - $this->addHeader( $header ); |
|
32 | + public function __construct(array $headers) { |
|
33 | + foreach ($headers as $header) { |
|
34 | + $this->addHeader($header); |
|
35 | 35 | } |
36 | 36 | } |
37 | 37 | |
@@ -40,16 +40,16 @@ discard block |
||
40 | 40 | * |
41 | 41 | * @throws InvalidArgumentException |
42 | 42 | */ |
43 | - private function addHeader( $header ) { |
|
44 | - Assert::parameterType( [ 'string', HtmlTableHeaderBuilder::class ], $header, '$header' ); |
|
43 | + private function addHeader($header) { |
|
44 | + Assert::parameterType(['string', HtmlTableHeaderBuilder::class], $header, '$header'); |
|
45 | 45 | |
46 | - if ( is_string( $header ) ) { |
|
47 | - $header = new HtmlTableHeaderBuilder( $header ); |
|
46 | + if (is_string($header)) { |
|
47 | + $header = new HtmlTableHeaderBuilder($header); |
|
48 | 48 | } |
49 | 49 | |
50 | 50 | $this->headers[] = $header; |
51 | 51 | |
52 | - if ( $header->getIsSortable() ) { |
|
52 | + if ($header->getIsSortable()) { |
|
53 | 53 | $this->isSortable = true; |
54 | 54 | } |
55 | 55 | } |
@@ -82,12 +82,12 @@ discard block |
||
82 | 82 | * |
83 | 83 | * @throws InvalidArgumentException |
84 | 84 | */ |
85 | - public function appendRow( array $cells ) { |
|
86 | - foreach ( $cells as $key => $cell ) { |
|
87 | - if ( is_string( $cell ) ) { |
|
88 | - $cells[$key] = new HtmlTableCellBuilder( $cell ); |
|
89 | - } elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) { |
|
90 | - throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' ); |
|
85 | + public function appendRow(array $cells) { |
|
86 | + foreach ($cells as $key => $cell) { |
|
87 | + if (is_string($cell)) { |
|
88 | + $cells[$key] = new HtmlTableCellBuilder($cell); |
|
89 | + } elseif (!($cell instanceof HtmlTableCellBuilder)) { |
|
90 | + throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.'); |
|
91 | 91 | } |
92 | 92 | } |
93 | 93 | |
@@ -101,13 +101,13 @@ discard block |
||
101 | 101 | * |
102 | 102 | * @throws InvalidArgumentException |
103 | 103 | */ |
104 | - public function appendRows( array $rows ) { |
|
105 | - foreach ( $rows as $cells ) { |
|
106 | - if ( !is_array( $cells ) ) { |
|
107 | - throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' ); |
|
104 | + public function appendRows(array $rows) { |
|
105 | + foreach ($rows as $cells) { |
|
106 | + if (!is_array($cells)) { |
|
107 | + throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.'); |
|
108 | 108 | } |
109 | 109 | |
110 | - $this->appendRow( $cells ); |
|
110 | + $this->appendRow($cells); |
|
111 | 111 | } |
112 | 112 | } |
113 | 113 | |
@@ -119,38 +119,38 @@ discard block |
||
119 | 119 | public function toHtml() { |
120 | 120 | // Open table |
121 | 121 | $tableClasses = 'wikitable'; |
122 | - if ( $this->isSortable ) { |
|
122 | + if ($this->isSortable) { |
|
123 | 123 | $tableClasses .= ' sortable'; |
124 | 124 | } |
125 | - $html = Html::openElement( 'table', [ 'class' => $tableClasses ] ); |
|
125 | + $html = Html::openElement('table', ['class' => $tableClasses]); |
|
126 | 126 | |
127 | 127 | // Write headers |
128 | - $html .= Html::openElement( 'thead' ); |
|
129 | - $html .= Html::openElement( 'tr' ); |
|
130 | - foreach ( $this->headers as $header ) { |
|
128 | + $html .= Html::openElement('thead'); |
|
129 | + $html .= Html::openElement('tr'); |
|
130 | + foreach ($this->headers as $header) { |
|
131 | 131 | $html .= $header->toHtml(); |
132 | 132 | } |
133 | - $html .= Html::closeElement( 'tr' ); |
|
134 | - $html .= Html::closeElement( 'thead' ); |
|
135 | - $html .= Html::openElement( 'tbody' ); |
|
133 | + $html .= Html::closeElement('tr'); |
|
134 | + $html .= Html::closeElement('thead'); |
|
135 | + $html .= Html::openElement('tbody'); |
|
136 | 136 | |
137 | 137 | // Write rows |
138 | - foreach ( $this->rows as $row ) { |
|
139 | - $html .= Html::openElement( 'tr' ); |
|
138 | + foreach ($this->rows as $row) { |
|
139 | + $html .= Html::openElement('tr'); |
|
140 | 140 | |
141 | 141 | /** |
142 | 142 | * @var HtmlTableCellBuilder $cell |
143 | 143 | */ |
144 | - foreach ( $row as $cell ) { |
|
144 | + foreach ($row as $cell) { |
|
145 | 145 | $html .= $cell->toHtml(); |
146 | 146 | } |
147 | 147 | |
148 | - $html .= Html::closeElement( 'tr' ); |
|
148 | + $html .= Html::closeElement('tr'); |
|
149 | 149 | } |
150 | 150 | |
151 | 151 | // Close table |
152 | - $html .= Html::closeElement( 'tbody' ); |
|
153 | - $html .= Html::closeElement( 'table' ); |
|
152 | + $html .= Html::closeElement('tbody'); |
|
153 | + $html .= Html::closeElement('table'); |
|
154 | 154 | |
155 | 155 | return $html; |
156 | 156 | } |
@@ -128,17 +128,17 @@ discard block |
||
128 | 128 | public function __construct( |
129 | 129 | $messageKey |
130 | 130 | ) { |
131 | - if ( strpos( $messageKey, self::MESSAGE_KEY_PREFIX ) !== 0 ) { |
|
131 | + if (strpos($messageKey, self::MESSAGE_KEY_PREFIX) !== 0) { |
|
132 | 132 | throw new InvalidArgumentException( |
133 | - 'ViolationMessage key ⧼' . |
|
134 | - $messageKey . |
|
135 | - '⧽ should start with "' . |
|
136 | - self::MESSAGE_KEY_PREFIX . |
|
133 | + 'ViolationMessage key ⧼'. |
|
134 | + $messageKey. |
|
135 | + '⧽ should start with "'. |
|
136 | + self::MESSAGE_KEY_PREFIX. |
|
137 | 137 | '".' |
138 | 138 | ); |
139 | 139 | } |
140 | 140 | |
141 | - $this->messageKeySuffix = substr( $messageKey, strlen( self::MESSAGE_KEY_PREFIX ) ); |
|
141 | + $this->messageKeySuffix = substr($messageKey, strlen(self::MESSAGE_KEY_PREFIX)); |
|
142 | 142 | $this->arguments = []; |
143 | 143 | } |
144 | 144 | |
@@ -147,7 +147,7 @@ discard block |
||
147 | 147 | * @return string |
148 | 148 | */ |
149 | 149 | public function getMessageKey() { |
150 | - return self::MESSAGE_KEY_PREFIX . $this->messageKeySuffix; |
|
150 | + return self::MESSAGE_KEY_PREFIX.$this->messageKeySuffix; |
|
151 | 151 | } |
152 | 152 | |
153 | 153 | /** |
@@ -167,9 +167,9 @@ discard block |
||
167 | 167 | * @param mixed $value the value, which should match the $type |
168 | 168 | * @return self |
169 | 169 | */ |
170 | - public function withArgument( $type, $role, $value ) { |
|
170 | + public function withArgument($type, $role, $value) { |
|
171 | 171 | $ret = clone $this; |
172 | - $ret->arguments[] = [ 'type' => $type, 'role' => $role, 'value' => $value ]; |
|
172 | + $ret->arguments[] = ['type' => $type, 'role' => $role, 'value' => $value]; |
|
173 | 173 | return $ret; |
174 | 174 | } |
175 | 175 | |
@@ -181,8 +181,8 @@ discard block |
||
181 | 181 | * @param string|null $role one of the Role::* constants |
182 | 182 | * @return self |
183 | 183 | */ |
184 | - public function withEntityId( EntityId $entityId, $role = null ) { |
|
185 | - return $this->withArgument( self::TYPE_ENTITY_ID, $role, $entityId ); |
|
184 | + public function withEntityId(EntityId $entityId, $role = null) { |
|
185 | + return $this->withArgument(self::TYPE_ENTITY_ID, $role, $entityId); |
|
186 | 186 | } |
187 | 187 | |
188 | 188 | /** |
@@ -199,8 +199,8 @@ discard block |
||
199 | 199 | * @param string|null $role one of the Role::* constants |
200 | 200 | * @return self |
201 | 201 | */ |
202 | - public function withEntityIdList( array $entityIdList, $role = null ) { |
|
203 | - return $this->withArgument( self::TYPE_ENTITY_ID_LIST, $role, $entityIdList ); |
|
202 | + public function withEntityIdList(array $entityIdList, $role = null) { |
|
203 | + return $this->withArgument(self::TYPE_ENTITY_ID_LIST, $role, $entityIdList); |
|
204 | 204 | } |
205 | 205 | |
206 | 206 | /** |
@@ -211,8 +211,8 @@ discard block |
||
211 | 211 | * @param string|null $role one of the Role::* constants |
212 | 212 | * @return self |
213 | 213 | */ |
214 | - public function withItemIdSnakValue( ItemIdSnakValue $value, $role = null ) { |
|
215 | - return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value ); |
|
214 | + public function withItemIdSnakValue(ItemIdSnakValue $value, $role = null) { |
|
215 | + return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE, $role, $value); |
|
216 | 216 | } |
217 | 217 | |
218 | 218 | /** |
@@ -229,8 +229,8 @@ discard block |
||
229 | 229 | * @param string|null $role one of the Role::* constants |
230 | 230 | * @return self |
231 | 231 | */ |
232 | - public function withItemIdSnakValueList( array $valueList, $role = null ) { |
|
233 | - return $this->withArgument( self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList ); |
|
232 | + public function withItemIdSnakValueList(array $valueList, $role = null) { |
|
233 | + return $this->withArgument(self::TYPE_ITEM_ID_SNAK_VALUE_LIST, $role, $valueList); |
|
234 | 234 | } |
235 | 235 | |
236 | 236 | /** |
@@ -241,8 +241,8 @@ discard block |
||
241 | 241 | * @param string|null $role one of the Role::* constants |
242 | 242 | * @return self |
243 | 243 | */ |
244 | - public function withDataValue( DataValue $dataValue, $role = null ) { |
|
245 | - return $this->withArgument( self::TYPE_DATA_VALUE, $role, $dataValue ); |
|
244 | + public function withDataValue(DataValue $dataValue, $role = null) { |
|
245 | + return $this->withArgument(self::TYPE_DATA_VALUE, $role, $dataValue); |
|
246 | 246 | } |
247 | 247 | |
248 | 248 | /** |
@@ -257,8 +257,8 @@ discard block |
||
257 | 257 | * @param string|null $role one of the Role::* constants |
258 | 258 | * @return self |
259 | 259 | */ |
260 | - public function withDataValueType( $dataValueType, $role = null ) { |
|
261 | - return $this->withArgument( self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType ); |
|
260 | + public function withDataValueType($dataValueType, $role = null) { |
|
261 | + return $this->withArgument(self::TYPE_DATA_VALUE_TYPE, $role, $dataValueType); |
|
262 | 262 | } |
263 | 263 | |
264 | 264 | /** |
@@ -269,8 +269,8 @@ discard block |
||
269 | 269 | * @param string|null $role one of the Role::* constants |
270 | 270 | * @return self |
271 | 271 | */ |
272 | - public function withInlineCode( $code, $role = null ) { |
|
273 | - return $this->withArgument( self::TYPE_INLINE_CODE, $role, $code ); |
|
272 | + public function withInlineCode($code, $role = null) { |
|
273 | + return $this->withArgument(self::TYPE_INLINE_CODE, $role, $code); |
|
274 | 274 | } |
275 | 275 | |
276 | 276 | /** |
@@ -281,8 +281,8 @@ discard block |
||
281 | 281 | * @param string|null $role one of the Role::* constants |
282 | 282 | * @return self |
283 | 283 | */ |
284 | - public function withConstraintScope( $scope, $role = null ) { |
|
285 | - return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE, $role, $scope ); |
|
284 | + public function withConstraintScope($scope, $role = null) { |
|
285 | + return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE, $role, $scope); |
|
286 | 286 | } |
287 | 287 | |
288 | 288 | /** |
@@ -293,8 +293,8 @@ discard block |
||
293 | 293 | * @param string|null $role one of the Role::* constants |
294 | 294 | * @return self |
295 | 295 | */ |
296 | - public function withConstraintScopeList( array $scopeList, $role = null ) { |
|
297 | - return $this->withArgument( self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList ); |
|
296 | + public function withConstraintScopeList(array $scopeList, $role = null) { |
|
297 | + return $this->withArgument(self::TYPE_CONSTRAINT_SCOPE_LIST, $role, $scopeList); |
|
298 | 298 | } |
299 | 299 | |
300 | 300 | /** |
@@ -305,8 +305,8 @@ discard block |
||
305 | 305 | * @param string|null $role one of the Role::* constants |
306 | 306 | * @return self |
307 | 307 | */ |
308 | - public function withPropertyScope( $scope, $role = null ) { |
|
309 | - return $this->withArgument( self::TYPE_PROPERTY_SCOPE, $role, $scope ); |
|
308 | + public function withPropertyScope($scope, $role = null) { |
|
309 | + return $this->withArgument(self::TYPE_PROPERTY_SCOPE, $role, $scope); |
|
310 | 310 | } |
311 | 311 | |
312 | 312 | /** |
@@ -317,8 +317,8 @@ discard block |
||
317 | 317 | * @param string|null $role one of the Role::* constants |
318 | 318 | * @return self |
319 | 319 | */ |
320 | - public function withPropertyScopeList( array $scopeList, $role = null ) { |
|
321 | - return $this->withArgument( self::TYPE_PROPERTY_SCOPE_LIST, $role, $scopeList ); |
|
320 | + public function withPropertyScopeList(array $scopeList, $role = null) { |
|
321 | + return $this->withArgument(self::TYPE_PROPERTY_SCOPE_LIST, $role, $scopeList); |
|
322 | 322 | } |
323 | 323 | |
324 | 324 | /** |
@@ -333,8 +333,8 @@ discard block |
||
333 | 333 | * @param string $languageCode |
334 | 334 | * @return self |
335 | 335 | */ |
336 | - public function withLanguage( $languageCode ) { |
|
337 | - return $this->withArgument( self::TYPE_LANGUAGE, null, $languageCode ); |
|
336 | + public function withLanguage($languageCode) { |
|
337 | + return $this->withArgument(self::TYPE_LANGUAGE, null, $languageCode); |
|
338 | 338 | } |
339 | 339 | |
340 | 340 | /** |
@@ -349,8 +349,8 @@ discard block |
||
349 | 349 | * @param string[] $languageCodes |
350 | 350 | * @return self |
351 | 351 | */ |
352 | - public function withLanguages( $languageCodes ) { |
|
353 | - return $this->withArgument( self::TYPE_LANGUAGE_LIST, null, $languageCodes ); |
|
352 | + public function withLanguages($languageCodes) { |
|
353 | + return $this->withArgument(self::TYPE_LANGUAGE_LIST, null, $languageCodes); |
|
354 | 354 | } |
355 | 355 | |
356 | 356 | /** |
@@ -365,8 +365,8 @@ discard block |
||
365 | 365 | * @param string|null $role one of the Role::* constants |
366 | 366 | * @return self |
367 | 367 | */ |
368 | - public function withMultilingualText( MultilingualTextValue $text, $role = null ) { |
|
369 | - return $this->withArgument( self::TYPE_MULTILINGUAL_TEXT, $role, $text ); |
|
368 | + public function withMultilingualText(MultilingualTextValue $text, $role = null) { |
|
369 | + return $this->withArgument(self::TYPE_MULTILINGUAL_TEXT, $role, $text); |
|
370 | 370 | } |
371 | 371 | |
372 | 372 | } |
@@ -18,9 +18,9 @@ |
||
18 | 18 | */ |
19 | 19 | private $violationMessage; |
20 | 20 | |
21 | - public function __construct( ViolationMessage $violationMessage ) { |
|
22 | - $message = '⧼' . $violationMessage->getMessageKey() . '⧽'; |
|
23 | - parent::__construct( $message ); |
|
21 | + public function __construct(ViolationMessage $violationMessage) { |
|
22 | + $message = '⧼'.$violationMessage->getMessageKey().'⧽'; |
|
23 | + parent::__construct($message); |
|
24 | 24 | |
25 | 25 | $this->violationMessage = $violationMessage; |
26 | 26 | } |
@@ -37,25 +37,25 @@ discard block |
||
37 | 37 | * @param Title $title |
38 | 38 | * @param string[] $params should contain 'entityId' => 'Q1234' |
39 | 39 | */ |
40 | - public function __construct( Title $title, array $params ) { |
|
41 | - parent::__construct( self::COMMAND, $title, $params ); |
|
40 | + public function __construct(Title $title, array $params) { |
|
41 | + parent::__construct(self::COMMAND, $title, $params); |
|
42 | 42 | $this->removeDuplicates = true; |
43 | 43 | |
44 | - Assert::parameterType( 'string', $params['entityId'], '$params[\'entityId\']' ); |
|
44 | + Assert::parameterType('string', $params['entityId'], '$params[\'entityId\']'); |
|
45 | 45 | |
46 | - $resultSource = ConstraintsServices::getResultsSource( MediaWikiServices::getInstance() ); |
|
46 | + $resultSource = ConstraintsServices::getResultsSource(MediaWikiServices::getInstance()); |
|
47 | 47 | '@phan-var CachingResultsSource $resultSource'; |
48 | 48 | // This job should only ever be used when caching result sources are used. |
49 | - $this->setResultsSource( $resultSource ); |
|
49 | + $this->setResultsSource($resultSource); |
|
50 | 50 | |
51 | - $this->setEntityIdParser( WikibaseRepo::getEntityIdParser() ); |
|
51 | + $this->setEntityIdParser(WikibaseRepo::getEntityIdParser()); |
|
52 | 52 | } |
53 | 53 | |
54 | - public function setResultsSource( CachingResultsSource $resultsSource ) { |
|
54 | + public function setResultsSource(CachingResultsSource $resultsSource) { |
|
55 | 55 | $this->resultsSource = $resultsSource; |
56 | 56 | } |
57 | 57 | |
58 | - public function setEntityIdParser( EntityIdParser $parser ) { |
|
58 | + public function setEntityIdParser(EntityIdParser $parser) { |
|
59 | 59 | $this->entityIdParser = $parser; |
60 | 60 | } |
61 | 61 | |
@@ -66,19 +66,19 @@ discard block |
||
66 | 66 | */ |
67 | 67 | public function run() { |
68 | 68 | try { |
69 | - $entityId = $this->entityIdParser->parse( $this->params['entityId'] ); |
|
70 | - } catch ( EntityIdParsingException ) { |
|
69 | + $entityId = $this->entityIdParser->parse($this->params['entityId']); |
|
70 | + } catch (EntityIdParsingException) { |
|
71 | 71 | return false; |
72 | 72 | } |
73 | 73 | |
74 | - $this->checkConstraints( $entityId ); |
|
74 | + $this->checkConstraints($entityId); |
|
75 | 75 | |
76 | 76 | return true; |
77 | 77 | } |
78 | 78 | |
79 | - private function checkConstraints( EntityId $entityId ) { |
|
79 | + private function checkConstraints(EntityId $entityId) { |
|
80 | 80 | $this->resultsSource->getResults( |
81 | - [ $entityId ], |
|
81 | + [$entityId], |
|
82 | 82 | [], |
83 | 83 | null, |
84 | 84 | [] |
@@ -74,7 +74,7 @@ discard block |
||
74 | 74 | $this->sparqlHelper = $sparqlHelper; |
75 | 75 | $this->shellboxClientFactory = $shellboxClientFactory; |
76 | 76 | $this->knownGoodPatternsAsKeys = array_fill_keys( |
77 | - $this->config->get( 'WBQualityConstraintsFormatCheckerKnownGoodRegexPatterns' ), |
|
77 | + $this->config->get('WBQualityConstraintsFormatCheckerKnownGoodRegexPatterns'), |
|
78 | 78 | null |
79 | 79 | ); |
80 | 80 | $this->logger = $logger ?? new NullLogger(); |
@@ -108,7 +108,7 @@ discard block |
||
108 | 108 | * @throws ConstraintParameterException |
109 | 109 | * @return CheckResult |
110 | 110 | */ |
111 | - public function checkConstraint( Context $context, Constraint $constraint ): CheckResult { |
|
111 | + public function checkConstraint(Context $context, Constraint $constraint): CheckResult { |
|
112 | 112 | $constraintParameters = $constraint->getConstraintParameters(); |
113 | 113 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
114 | 114 | |
@@ -123,9 +123,9 @@ discard block |
||
123 | 123 | |
124 | 124 | $snak = $context->getSnak(); |
125 | 125 | |
126 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
126 | + if (!$snak instanceof PropertyValueSnak) { |
|
127 | 127 | // nothing to check |
128 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE ); |
|
128 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE); |
|
129 | 129 | } |
130 | 130 | |
131 | 131 | $dataValue = $snak->getDataValue(); |
@@ -134,7 +134,7 @@ discard block |
||
134 | 134 | * error handling: |
135 | 135 | * type of $dataValue for properties with 'Format' constraint has to be 'string' or 'monolingualtext' |
136 | 136 | */ |
137 | - switch ( $dataValue->getType() ) { |
|
137 | + switch ($dataValue->getType()) { |
|
138 | 138 | case 'string': |
139 | 139 | $text = $dataValue->getValue(); |
140 | 140 | break; |
@@ -144,13 +144,13 @@ discard block |
||
144 | 144 | $text = $dataValue->getText(); |
145 | 145 | break; |
146 | 146 | default: |
147 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-types-2' ) ) |
|
148 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
149 | - ->withDataValueType( 'string' ) |
|
150 | - ->withDataValueType( 'monolingualtext' ); |
|
151 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
147 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-types-2')) |
|
148 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
149 | + ->withDataValueType('string') |
|
150 | + ->withDataValueType('monolingualtext'); |
|
151 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
152 | 152 | } |
153 | - $status = $this->runRegexCheck( $text, $format ); |
|
153 | + $status = $this->runRegexCheck($text, $format); |
|
154 | 154 | $message = $this->formatMessage( |
155 | 155 | $status, |
156 | 156 | $text, |
@@ -159,7 +159,7 @@ discard block |
||
159 | 159 | $syntaxClarifications, |
160 | 160 | $constraintTypeItemId |
161 | 161 | ); |
162 | - return new CheckResult( $context, $constraint, $status, $message ); |
|
162 | + return new CheckResult($context, $constraint, $status, $message); |
|
163 | 163 | } |
164 | 164 | |
165 | 165 | private function formatMessage( |
@@ -171,43 +171,43 @@ discard block |
||
171 | 171 | string $constraintTypeItemId |
172 | 172 | ): ?ViolationMessage { |
173 | 173 | $message = null; |
174 | - if ( $status === CheckResult::STATUS_VIOLATION ) { |
|
175 | - $message = ( new ViolationMessage( 'wbqc-violation-message-format-clarification' ) ) |
|
176 | - ->withEntityId( $propertyId, Role::CONSTRAINT_PROPERTY ) |
|
177 | - ->withDataValue( new StringValue( $text ), Role::OBJECT ) |
|
178 | - ->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
179 | - ->withMultilingualText( $syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE ); |
|
180 | - } elseif ( $status === CheckResult::STATUS_TODO ) { |
|
181 | - $message = ( new ViolationMessage( 'wbqc-violation-message-security-reason' ) ) |
|
182 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ); |
|
174 | + if ($status === CheckResult::STATUS_VIOLATION) { |
|
175 | + $message = (new ViolationMessage('wbqc-violation-message-format-clarification')) |
|
176 | + ->withEntityId($propertyId, Role::CONSTRAINT_PROPERTY) |
|
177 | + ->withDataValue(new StringValue($text), Role::OBJECT) |
|
178 | + ->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE) |
|
179 | + ->withMultilingualText($syntaxClarifications, Role::CONSTRAINT_PARAMETER_VALUE); |
|
180 | + } elseif ($status === CheckResult::STATUS_TODO) { |
|
181 | + $message = (new ViolationMessage('wbqc-violation-message-security-reason')) |
|
182 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM); |
|
183 | 183 | } |
184 | 184 | |
185 | 185 | return $message; |
186 | 186 | } |
187 | 187 | |
188 | 188 | /** @throws ConstraintParameterException */ |
189 | - private function runRegexCheck( string $text, string $format ): string { |
|
190 | - if ( !$this->config->get( 'WBQualityConstraintsCheckFormatConstraint' ) ) { |
|
189 | + private function runRegexCheck(string $text, string $format): string { |
|
190 | + if (!$this->config->get('WBQualityConstraintsCheckFormatConstraint')) { |
|
191 | 191 | return CheckResult::STATUS_TODO; |
192 | 192 | } |
193 | - if ( \array_key_exists( $format, $this->knownGoodPatternsAsKeys ) ) { |
|
194 | - $checkResult = FormatCheckerHelper::runRegexCheck( $format, $text ); |
|
193 | + if (\array_key_exists($format, $this->knownGoodPatternsAsKeys)) { |
|
194 | + $checkResult = FormatCheckerHelper::runRegexCheck($format, $text); |
|
195 | 195 | } elseif ( |
196 | - $this->config->get( 'WBQualityConstraintsFormatCheckerShellboxRatio' ) > (float)wfRandom() |
|
196 | + $this->config->get('WBQualityConstraintsFormatCheckerShellboxRatio') > (float) wfRandom() |
|
197 | 197 | ) { |
198 | - $checkResult = $this->runRegexCheckUsingShellbox( $text, $format ); |
|
198 | + $checkResult = $this->runRegexCheckUsingShellbox($text, $format); |
|
199 | 199 | } else { |
200 | - return $this->runRegexCheckUsingSparql( $text, $format ); |
|
200 | + return $this->runRegexCheckUsingSparql($text, $format); |
|
201 | 201 | } |
202 | 202 | |
203 | - if ( $checkResult === 1 ) { |
|
203 | + if ($checkResult === 1) { |
|
204 | 204 | return CheckResult::STATUS_COMPLIANCE; |
205 | - } elseif ( $checkResult === 0 ) { |
|
205 | + } elseif ($checkResult === 0) { |
|
206 | 206 | return CheckResult::STATUS_VIOLATION; |
207 | - } elseif ( $checkResult === false ) { |
|
207 | + } elseif ($checkResult === false) { |
|
208 | 208 | throw new ConstraintParameterException( |
209 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) ) |
|
210 | - ->withInlineCode( $format, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
209 | + (new ViolationMessage('wbqc-violation-message-parameter-regex')) |
|
210 | + ->withInlineCode($format, Role::CONSTRAINT_PARAMETER_VALUE) |
|
211 | 211 | ); |
212 | 212 | } else { |
213 | 213 | return $checkResult; |
@@ -221,51 +221,51 @@ discard block |
||
221 | 221 | * - FALSE if $format is invalid regex |
222 | 222 | * - CheckResult::STATUS_TODO if Shellbox is not enabled |
223 | 223 | */ |
224 | - private function runRegexCheckUsingShellbox( string $text, string $format ) { |
|
225 | - if ( !$this->shellboxClientFactory->isEnabled( 'constraint-regex-checker' ) ) { |
|
224 | + private function runRegexCheckUsingShellbox(string $text, string $format) { |
|
225 | + if (!$this->shellboxClientFactory->isEnabled('constraint-regex-checker')) { |
|
226 | 226 | return CheckResult::STATUS_TODO; |
227 | 227 | } |
228 | 228 | |
229 | 229 | try { |
230 | - return $this->shellboxClientFactory->getClient( [ |
|
231 | - 'timeout' => $this->config->get( 'WBQualityConstraintsSparqlMaxMillis' ) / 1000, |
|
230 | + return $this->shellboxClientFactory->getClient([ |
|
231 | + 'timeout' => $this->config->get('WBQualityConstraintsSparqlMaxMillis') / 1000, |
|
232 | 232 | 'service' => 'constraint-regex-checker', |
233 | - ] )->call( |
|
233 | + ])->call( |
|
234 | 234 | 'constraint-regex-checker', |
235 | - [ FormatCheckerHelper::class, 'runRegexCheck' ], |
|
236 | - [ $format, $text ], |
|
237 | - [ 'classes' => [ FormatCheckerHelper::class ] ], |
|
235 | + [FormatCheckerHelper::class, 'runRegexCheck'], |
|
236 | + [$format, $text], |
|
237 | + ['classes' => [FormatCheckerHelper::class]], |
|
238 | 238 | ); |
239 | - } catch ( ClientExceptionInterface $ce ) { |
|
240 | - $this->logger->notice( __METHOD__ . ': Network error, skipping check: {exception}', [ |
|
239 | + } catch (ClientExceptionInterface $ce) { |
|
240 | + $this->logger->notice(__METHOD__.': Network error, skipping check: {exception}', [ |
|
241 | 241 | 'exception' => $ce, |
242 | 242 | 'text' => $text, |
243 | 243 | 'format' => $format, |
244 | - ] ); |
|
244 | + ]); |
|
245 | 245 | return CheckResult::STATUS_TODO; |
246 | - } catch ( ShellboxError $e ) { |
|
247 | - $this->logger->error( __METHOD__ . ': Shellbox error, skipping check: {exception}', [ |
|
246 | + } catch (ShellboxError $e) { |
|
247 | + $this->logger->error(__METHOD__.': Shellbox error, skipping check: {exception}', [ |
|
248 | 248 | 'exception' => $e, |
249 | 249 | 'text' => $text, |
250 | 250 | 'format' => $format, |
251 | - ] ); |
|
251 | + ]); |
|
252 | 252 | return CheckResult::STATUS_TODO; |
253 | 253 | } |
254 | 254 | } |
255 | 255 | |
256 | - private function runRegexCheckUsingSparql( string $text, string $format ): string { |
|
257 | - if ( $this->sparqlHelper instanceof DummySparqlHelper ) { |
|
256 | + private function runRegexCheckUsingSparql(string $text, string $format): string { |
|
257 | + if ($this->sparqlHelper instanceof DummySparqlHelper) { |
|
258 | 258 | return CheckResult::STATUS_TODO; |
259 | 259 | } |
260 | 260 | |
261 | - if ( $this->sparqlHelper->matchesRegularExpression( $text, $format ) ) { |
|
261 | + if ($this->sparqlHelper->matchesRegularExpression($text, $format)) { |
|
262 | 262 | return CheckResult::STATUS_COMPLIANCE; |
263 | 263 | } else { |
264 | 264 | return CheckResult::STATUS_VIOLATION; |
265 | 265 | } |
266 | 266 | } |
267 | 267 | |
268 | - public function checkConstraintParameters( Constraint $constraint ): array { |
|
268 | + public function checkConstraintParameters(Constraint $constraint): array { |
|
269 | 269 | $constraintParameters = $constraint->getConstraintParameters(); |
270 | 270 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
271 | 271 | $exceptions = []; |
@@ -274,14 +274,14 @@ discard block |
||
274 | 274 | $constraintParameters, |
275 | 275 | $constraintTypeItemId |
276 | 276 | ); |
277 | - } catch ( ConstraintParameterException $e ) { |
|
277 | + } catch (ConstraintParameterException $e) { |
|
278 | 278 | $exceptions[] = $e; |
279 | 279 | } |
280 | 280 | try { |
281 | 281 | $this->constraintParameterParser->parseSyntaxClarificationParameter( |
282 | 282 | $constraintParameters |
283 | 283 | ); |
284 | - } catch ( ConstraintParameterException $e ) { |
|
284 | + } catch (ConstraintParameterException $e) { |
|
285 | 285 | $exceptions[] = $e; |
286 | 286 | } |
287 | 287 | return $exceptions; |
@@ -88,9 +88,9 @@ discard block |
||
88 | 88 | * @throws SparqlHelperException if the checker uses SPARQL and the query times out or some other error occurs |
89 | 89 | * @return CheckResult |
90 | 90 | */ |
91 | - public function checkConstraint( Context $context, Constraint $constraint ): CheckResult { |
|
92 | - if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) { |
|
93 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_DEPRECATED ); |
|
91 | + public function checkConstraint(Context $context, Constraint $constraint): CheckResult { |
|
92 | + if ($context->getSnakRank() === Statement::RANK_DEPRECATED) { |
|
93 | + return new CheckResult($context, $constraint, CheckResult::STATUS_DEPRECATED); |
|
94 | 94 | } |
95 | 95 | |
96 | 96 | $constraintParameters = $constraint->getConstraintParameters(); |
@@ -106,18 +106,18 @@ discard block |
||
106 | 106 | $constraintTypeItemId |
107 | 107 | ); |
108 | 108 | $relationIds = []; |
109 | - if ( $relation === 'instance' || $relation === 'instanceOrSubclass' ) { |
|
110 | - $relationIds[] = $this->config->get( 'WBQualityConstraintsInstanceOfId' ); |
|
109 | + if ($relation === 'instance' || $relation === 'instanceOrSubclass') { |
|
110 | + $relationIds[] = $this->config->get('WBQualityConstraintsInstanceOfId'); |
|
111 | 111 | } |
112 | - if ( $relation === 'subclass' || $relation === 'instanceOrSubclass' ) { |
|
113 | - $relationIds[] = $this->config->get( 'WBQualityConstraintsSubclassOfId' ); |
|
112 | + if ($relation === 'subclass' || $relation === 'instanceOrSubclass') { |
|
113 | + $relationIds[] = $this->config->get('WBQualityConstraintsSubclassOfId'); |
|
114 | 114 | } |
115 | 115 | |
116 | 116 | $snak = $context->getSnak(); |
117 | 117 | |
118 | - if ( !$snak instanceof PropertyValueSnak ) { |
|
118 | + if (!$snak instanceof PropertyValueSnak) { |
|
119 | 119 | // nothing to check |
120 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE ); |
|
120 | + return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE); |
|
121 | 121 | } |
122 | 122 | |
123 | 123 | $dataValue = $snak->getDataValue(); |
@@ -126,23 +126,23 @@ discard block |
||
126 | 126 | * error handling: |
127 | 127 | * type of $dataValue for properties with 'Value type' constraint has to be 'wikibase-entityid' |
128 | 128 | */ |
129 | - if ( !$dataValue instanceof EntityIdValue ) { |
|
130 | - $message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) ) |
|
131 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
132 | - ->withDataValueType( 'wikibase-entityid' ); |
|
133 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
129 | + if (!$dataValue instanceof EntityIdValue) { |
|
130 | + $message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type')) |
|
131 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
132 | + ->withDataValueType('wikibase-entityid'); |
|
133 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
134 | 134 | } |
135 | 135 | |
136 | 136 | try { |
137 | - $item = $this->entityLookup->getEntity( $dataValue->getEntityId() ); |
|
138 | - } catch ( UnresolvedEntityRedirectException ) { |
|
137 | + $item = $this->entityLookup->getEntity($dataValue->getEntityId()); |
|
138 | + } catch (UnresolvedEntityRedirectException) { |
|
139 | 139 | // Edge case (double redirect): Pretend the entity doesn't exist |
140 | 140 | $item = null; |
141 | 141 | } |
142 | 142 | |
143 | - if ( !( $item instanceof StatementListProvidingEntity ) ) { |
|
144 | - $message = new ViolationMessage( 'wbqc-violation-message-value-entity-must-exist' ); |
|
145 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message ); |
|
143 | + if (!($item instanceof StatementListProvidingEntity)) { |
|
144 | + $message = new ViolationMessage('wbqc-violation-message-value-entity-must-exist'); |
|
145 | + return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message); |
|
146 | 146 | } |
147 | 147 | |
148 | 148 | $statements = $item->getStatements(); |
@@ -153,7 +153,7 @@ discard block |
||
153 | 153 | $classes |
154 | 154 | ); |
155 | 155 | |
156 | - if ( $result->getBool() ) { |
|
156 | + if ($result->getBool()) { |
|
157 | 157 | $message = null; |
158 | 158 | $status = CheckResult::STATUS_COMPLIANCE; |
159 | 159 | } else { |
@@ -167,11 +167,11 @@ discard block |
||
167 | 167 | $status = CheckResult::STATUS_VIOLATION; |
168 | 168 | } |
169 | 169 | |
170 | - return ( new CheckResult( $context, $constraint, $status, $message ) ) |
|
171 | - ->withMetadata( $result->getMetadata() ); |
|
170 | + return (new CheckResult($context, $constraint, $status, $message)) |
|
171 | + ->withMetadata($result->getMetadata()); |
|
172 | 172 | } |
173 | 173 | |
174 | - public function checkConstraintParameters( Constraint $constraint ): array { |
|
174 | + public function checkConstraintParameters(Constraint $constraint): array { |
|
175 | 175 | $constraintParameters = $constraint->getConstraintParameters(); |
176 | 176 | $constraintTypeItemId = $constraint->getConstraintTypeItemId(); |
177 | 177 | $exceptions = []; |
@@ -180,7 +180,7 @@ discard block |
||
180 | 180 | $constraintParameters, |
181 | 181 | $constraintTypeItemId |
182 | 182 | ); |
183 | - } catch ( ConstraintParameterException $e ) { |
|
183 | + } catch (ConstraintParameterException $e) { |
|
184 | 184 | $exceptions[] = $e; |
185 | 185 | } |
186 | 186 | try { |
@@ -188,7 +188,7 @@ discard block |
||
188 | 188 | $constraintParameters, |
189 | 189 | $constraintTypeItemId |
190 | 190 | ); |
191 | - } catch ( ConstraintParameterException $e ) { |
|
191 | + } catch (ConstraintParameterException $e) { |
|
192 | 192 | $exceptions[] = $e; |
193 | 193 | } |
194 | 194 | return $exceptions; |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck; |
6 | 6 | |
@@ -123,10 +123,10 @@ discard block |
||
123 | 123 | ?callable $defaultResultsPerEntity = null |
124 | 124 | ): array { |
125 | 125 | $checkResults = []; |
126 | - $entity = $this->entityLookup->getEntity( $entityId ); |
|
126 | + $entity = $this->entityLookup->getEntity($entityId); |
|
127 | 127 | |
128 | - if ( $entity instanceof StatementListProvidingEntity ) { |
|
129 | - $startTime = microtime( true ); |
|
128 | + if ($entity instanceof StatementListProvidingEntity) { |
|
129 | + $startTime = microtime(true); |
|
130 | 130 | |
131 | 131 | $checkResults = $this->checkEveryStatement( |
132 | 132 | $entity, |
@@ -134,9 +134,9 @@ discard block |
||
134 | 134 | $defaultResultsPerContext |
135 | 135 | ); |
136 | 136 | |
137 | - $endTime = microtime( true ); |
|
137 | + $endTime = microtime(true); |
|
138 | 138 | |
139 | - if ( $constraintIds === null ) { // only log full constraint checks |
|
139 | + if ($constraintIds === null) { // only log full constraint checks |
|
140 | 140 | $this->loggingHelper->logConstraintCheckOnEntity( |
141 | 141 | $entityId, |
142 | 142 | $checkResults, |
@@ -146,11 +146,11 @@ discard block |
||
146 | 146 | } |
147 | 147 | } |
148 | 148 | |
149 | - if ( $defaultResultsPerEntity !== null ) { |
|
150 | - $checkResults = array_merge( $defaultResultsPerEntity( $entityId ), $checkResults ); |
|
149 | + if ($defaultResultsPerEntity !== null) { |
|
150 | + $checkResults = array_merge($defaultResultsPerEntity($entityId), $checkResults); |
|
151 | 151 | } |
152 | 152 | |
153 | - return $this->sortResult( $checkResults ); |
|
153 | + return $this->sortResult($checkResults); |
|
154 | 154 | } |
155 | 155 | |
156 | 156 | /** |
@@ -172,19 +172,19 @@ discard block |
||
172 | 172 | ?callable $defaultResults = null |
173 | 173 | ): array { |
174 | 174 | |
175 | - $parsedGuid = $this->statementGuidParser->parse( $guid ); |
|
175 | + $parsedGuid = $this->statementGuidParser->parse($guid); |
|
176 | 176 | $entityId = $parsedGuid->getEntityId(); |
177 | - $entity = $this->entityLookup->getEntity( $entityId ); |
|
178 | - if ( $entity instanceof StatementListProvidingEntity ) { |
|
179 | - $statement = $entity->getStatements()->getFirstStatementWithGuid( $guid ); |
|
180 | - if ( $statement ) { |
|
177 | + $entity = $this->entityLookup->getEntity($entityId); |
|
178 | + if ($entity instanceof StatementListProvidingEntity) { |
|
179 | + $statement = $entity->getStatements()->getFirstStatementWithGuid($guid); |
|
180 | + if ($statement) { |
|
181 | 181 | $result = $this->checkStatement( |
182 | 182 | $entity, |
183 | 183 | $statement, |
184 | 184 | $constraintIds, |
185 | 185 | $defaultResults |
186 | 186 | ); |
187 | - $output = $this->sortResult( $result ); |
|
187 | + $output = $this->sortResult($result); |
|
188 | 188 | return $output; |
189 | 189 | } |
190 | 190 | } |
@@ -192,8 +192,8 @@ discard block |
||
192 | 192 | return []; |
193 | 193 | } |
194 | 194 | |
195 | - private function getValidContextTypes( Constraint $constraint ): array { |
|
196 | - if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
195 | + private function getValidContextTypes(Constraint $constraint): array { |
|
196 | + if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
197 | 197 | return [ |
198 | 198 | Context::TYPE_STATEMENT, |
199 | 199 | Context::TYPE_QUALIFIER, |
@@ -201,21 +201,21 @@ discard block |
||
201 | 201 | ]; |
202 | 202 | } |
203 | 203 | |
204 | - return array_keys( array_filter( |
|
204 | + return array_keys(array_filter( |
|
205 | 205 | $this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedContextTypes(), |
206 | - static fn ( $status ) => $status !== CheckResult::STATUS_NOT_IN_SCOPE |
|
207 | - ) ); |
|
206 | + static fn ($status) => $status !== CheckResult::STATUS_NOT_IN_SCOPE |
|
207 | + )); |
|
208 | 208 | } |
209 | 209 | |
210 | - private function getValidEntityTypes( Constraint $constraint ): array { |
|
211 | - if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
212 | - return array_keys( ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED ); |
|
210 | + private function getValidEntityTypes(Constraint $constraint): array { |
|
211 | + if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
212 | + return array_keys(ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED); |
|
213 | 213 | } |
214 | 214 | |
215 | - return array_keys( array_filter( |
|
215 | + return array_keys(array_filter( |
|
216 | 216 | $this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedEntityTypes(), |
217 | - static fn ( $status ) => $status !== CheckResult::STATUS_NOT_IN_SCOPE |
|
218 | - ) ); |
|
217 | + static fn ($status) => $status !== CheckResult::STATUS_NOT_IN_SCOPE |
|
218 | + )); |
|
219 | 219 | } |
220 | 220 | |
221 | 221 | /** |
@@ -226,38 +226,38 @@ discard block |
||
226 | 226 | * |
227 | 227 | * @return ConstraintParameterException[] |
228 | 228 | */ |
229 | - private function checkCommonConstraintParameters( Constraint $constraint ): array { |
|
229 | + private function checkCommonConstraintParameters(Constraint $constraint): array { |
|
230 | 230 | $constraintParameters = $constraint->getConstraintParameters(); |
231 | 231 | try { |
232 | - $this->constraintParameterParser->checkError( $constraintParameters ); |
|
233 | - } catch ( ConstraintParameterException $e ) { |
|
234 | - return [ $e ]; |
|
232 | + $this->constraintParameterParser->checkError($constraintParameters); |
|
233 | + } catch (ConstraintParameterException $e) { |
|
234 | + return [$e]; |
|
235 | 235 | } |
236 | 236 | |
237 | 237 | $problems = []; |
238 | 238 | try { |
239 | - $this->constraintParameterParser->parseExceptionParameter( $constraintParameters ); |
|
240 | - } catch ( ConstraintParameterException $e ) { |
|
239 | + $this->constraintParameterParser->parseExceptionParameter($constraintParameters); |
|
240 | + } catch (ConstraintParameterException $e) { |
|
241 | 241 | $problems[] = $e; |
242 | 242 | } |
243 | 243 | try { |
244 | - $this->constraintParameterParser->parseConstraintClarificationParameter( $constraintParameters ); |
|
245 | - } catch ( ConstraintParameterException $e ) { |
|
244 | + $this->constraintParameterParser->parseConstraintClarificationParameter($constraintParameters); |
|
245 | + } catch (ConstraintParameterException $e) { |
|
246 | 246 | $problems[] = $e; |
247 | 247 | } |
248 | 248 | try { |
249 | - $this->constraintParameterParser->parseConstraintStatusParameter( $constraintParameters ); |
|
250 | - } catch ( ConstraintParameterException $e ) { |
|
249 | + $this->constraintParameterParser->parseConstraintStatusParameter($constraintParameters); |
|
250 | + } catch (ConstraintParameterException $e) { |
|
251 | 251 | $problems[] = $e; |
252 | 252 | } |
253 | 253 | try { |
254 | 254 | $this->constraintParameterParser->parseConstraintScopeParameters( |
255 | 255 | $constraintParameters, |
256 | 256 | $constraint->getConstraintTypeItemId(), |
257 | - $this->getValidContextTypes( $constraint ), |
|
258 | - $this->getValidEntityTypes( $constraint ) |
|
257 | + $this->getValidContextTypes($constraint), |
|
258 | + $this->getValidEntityTypes($constraint) |
|
259 | 259 | ); |
260 | - } catch ( ConstraintParameterException $e ) { |
|
260 | + } catch (ConstraintParameterException $e) { |
|
261 | 261 | $problems[] = $e; |
262 | 262 | } |
263 | 263 | return $problems; |
@@ -270,16 +270,16 @@ discard block |
||
270 | 270 | * @return ConstraintParameterException[][] first level indexed by constraint ID, |
271 | 271 | * second level like checkConstraintParametersOnConstraintId (but without possibility of null) |
272 | 272 | */ |
273 | - public function checkConstraintParametersOnPropertyId( NumericPropertyId $propertyId ): array { |
|
274 | - $constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId ); |
|
273 | + public function checkConstraintParametersOnPropertyId(NumericPropertyId $propertyId): array { |
|
274 | + $constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId); |
|
275 | 275 | $result = []; |
276 | 276 | |
277 | - foreach ( $constraints as $constraint ) { |
|
278 | - $problems = $this->checkCommonConstraintParameters( $constraint ); |
|
277 | + foreach ($constraints as $constraint) { |
|
278 | + $problems = $this->checkCommonConstraintParameters($constraint); |
|
279 | 279 | |
280 | - if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
280 | + if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
281 | 281 | $checker = $this->checkerMap[$constraint->getConstraintTypeItemId()]; |
282 | - $problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) ); |
|
282 | + $problems = array_merge($problems, $checker->checkConstraintParameters($constraint)); |
|
283 | 283 | } |
284 | 284 | |
285 | 285 | $result[$constraint->getConstraintId()] = $problems; |
@@ -296,18 +296,18 @@ discard block |
||
296 | 296 | * @return ConstraintParameterException[]|null list of constraint parameter exceptions |
297 | 297 | * (empty means all parameters okay), or null if constraint is not found |
298 | 298 | */ |
299 | - public function checkConstraintParametersOnConstraintId( string $constraintId ): ?array { |
|
300 | - $propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId(); |
|
299 | + public function checkConstraintParametersOnConstraintId(string $constraintId): ?array { |
|
300 | + $propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId(); |
|
301 | 301 | '@phan-var NumericPropertyId $propertyId'; |
302 | - $constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId ); |
|
302 | + $constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId); |
|
303 | 303 | |
304 | - foreach ( $constraints as $constraint ) { |
|
305 | - if ( $constraint->getConstraintId() === $constraintId ) { |
|
306 | - $problems = $this->checkCommonConstraintParameters( $constraint ); |
|
304 | + foreach ($constraints as $constraint) { |
|
305 | + if ($constraint->getConstraintId() === $constraintId) { |
|
306 | + $problems = $this->checkCommonConstraintParameters($constraint); |
|
307 | 307 | |
308 | - if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
308 | + if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
309 | 309 | $checker = $this->checkerMap[$constraint->getConstraintTypeItemId()]; |
310 | - $problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) ); |
|
310 | + $problems = array_merge($problems, $checker->checkConstraintParameters($constraint)); |
|
311 | 311 | } |
312 | 312 | |
313 | 313 | return $problems; |
@@ -332,14 +332,14 @@ discard block |
||
332 | 332 | $result = []; |
333 | 333 | |
334 | 334 | /** @var Statement $statement */ |
335 | - foreach ( $entity->getStatements() as $statement ) { |
|
336 | - $result = array_merge( $result, |
|
335 | + foreach ($entity->getStatements() as $statement) { |
|
336 | + $result = array_merge($result, |
|
337 | 337 | $this->checkStatement( |
338 | 338 | $entity, |
339 | 339 | $statement, |
340 | 340 | $constraintIds, |
341 | 341 | $defaultResultsPerContext |
342 | - ) ); |
|
342 | + )); |
|
343 | 343 | } |
344 | 344 | |
345 | 345 | return $result; |
@@ -361,32 +361,32 @@ discard block |
||
361 | 361 | ): array { |
362 | 362 | $result = []; |
363 | 363 | |
364 | - $result = array_merge( $result, |
|
364 | + $result = array_merge($result, |
|
365 | 365 | $this->checkConstraintsForMainSnak( |
366 | 366 | $entity, |
367 | 367 | $statement, |
368 | 368 | $constraintIds, |
369 | 369 | $defaultResultsPerContext |
370 | - ) ); |
|
370 | + )); |
|
371 | 371 | |
372 | - if ( $this->checkQualifiers ) { |
|
373 | - $result = array_merge( $result, |
|
372 | + if ($this->checkQualifiers) { |
|
373 | + $result = array_merge($result, |
|
374 | 374 | $this->checkConstraintsForQualifiers( |
375 | 375 | $entity, |
376 | 376 | $statement, |
377 | 377 | $constraintIds, |
378 | 378 | $defaultResultsPerContext |
379 | - ) ); |
|
379 | + )); |
|
380 | 380 | } |
381 | 381 | |
382 | - if ( $this->checkReferences ) { |
|
383 | - $result = array_merge( $result, |
|
382 | + if ($this->checkReferences) { |
|
383 | + $result = array_merge($result, |
|
384 | 384 | $this->checkConstraintsForReferences( |
385 | 385 | $entity, |
386 | 386 | $statement, |
387 | 387 | $constraintIds, |
388 | 388 | $defaultResultsPerContext |
389 | - ) ); |
|
389 | + )); |
|
390 | 390 | } |
391 | 391 | |
392 | 392 | return $result; |
@@ -401,17 +401,17 @@ discard block |
||
401 | 401 | * @param string[]|null $constraintIds |
402 | 402 | * @return Constraint[] |
403 | 403 | */ |
404 | - private function getConstraintsToUse( PropertyId $propertyId, ?array $constraintIds ): array { |
|
405 | - if ( !( $propertyId instanceof NumericPropertyId ) ) { |
|
404 | + private function getConstraintsToUse(PropertyId $propertyId, ?array $constraintIds): array { |
|
405 | + if (!($propertyId instanceof NumericPropertyId)) { |
|
406 | 406 | throw new InvalidArgumentException( |
407 | - 'Non-numeric property ID not supported:' . $propertyId->getSerialization() |
|
407 | + 'Non-numeric property ID not supported:'.$propertyId->getSerialization() |
|
408 | 408 | ); |
409 | 409 | } |
410 | - $constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId ); |
|
411 | - if ( $constraintIds !== null ) { |
|
410 | + $constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId); |
|
411 | + if ($constraintIds !== null) { |
|
412 | 412 | $constraintsToUse = []; |
413 | - foreach ( $constraints as $constraint ) { |
|
414 | - if ( in_array( $constraint->getConstraintId(), $constraintIds ) ) { |
|
413 | + foreach ($constraints as $constraint) { |
|
414 | + if (in_array($constraint->getConstraintId(), $constraintIds)) { |
|
415 | 415 | $constraintsToUse[] = $constraint; |
416 | 416 | } |
417 | 417 | } |
@@ -435,18 +435,18 @@ discard block |
||
435 | 435 | ?array $constraintIds, |
436 | 436 | ?callable $defaultResults |
437 | 437 | ): array { |
438 | - $context = new MainSnakContext( $entity, $statement ); |
|
438 | + $context = new MainSnakContext($entity, $statement); |
|
439 | 439 | $constraints = $this->getConstraintsToUse( |
440 | 440 | $statement->getPropertyId(), |
441 | 441 | $constraintIds |
442 | 442 | ); |
443 | - $result = $defaultResults !== null ? $defaultResults( $context ) : []; |
|
443 | + $result = $defaultResults !== null ? $defaultResults($context) : []; |
|
444 | 444 | |
445 | - foreach ( $constraints as $constraint ) { |
|
445 | + foreach ($constraints as $constraint) { |
|
446 | 446 | $parameters = $constraint->getConstraintParameters(); |
447 | 447 | try { |
448 | - $exceptions = $this->constraintParameterParser->parseExceptionParameter( $parameters ); |
|
449 | - } catch ( ConstraintParameterException $e ) { |
|
448 | + $exceptions = $this->constraintParameterParser->parseExceptionParameter($parameters); |
|
449 | + } catch (ConstraintParameterException $e) { |
|
450 | 450 | $result[] = new CheckResult( |
451 | 451 | $context, |
452 | 452 | $constraint, |
@@ -456,13 +456,13 @@ discard block |
||
456 | 456 | continue; |
457 | 457 | } |
458 | 458 | |
459 | - if ( in_array( $entity->getId(), $exceptions ) ) { |
|
460 | - $message = new ViolationMessage( 'wbqc-violation-message-exception' ); |
|
461 | - $result[] = new CheckResult( $context, $constraint, CheckResult::STATUS_EXCEPTION, $message ); |
|
459 | + if (in_array($entity->getId(), $exceptions)) { |
|
460 | + $message = new ViolationMessage('wbqc-violation-message-exception'); |
|
461 | + $result[] = new CheckResult($context, $constraint, CheckResult::STATUS_EXCEPTION, $message); |
|
462 | 462 | continue; |
463 | 463 | } |
464 | 464 | |
465 | - $result[] = $this->getCheckResultFor( $context, $constraint ); |
|
465 | + $result[] = $this->getCheckResultFor($context, $constraint); |
|
466 | 466 | } |
467 | 467 | |
468 | 468 | return $result; |
@@ -484,24 +484,24 @@ discard block |
||
484 | 484 | ): array { |
485 | 485 | $result = []; |
486 | 486 | |
487 | - if ( in_array( |
|
487 | + if (in_array( |
|
488 | 488 | $statement->getPropertyId()->getSerialization(), |
489 | 489 | $this->propertiesWithViolatingQualifiers |
490 | - ) ) { |
|
490 | + )) { |
|
491 | 491 | return $result; |
492 | 492 | } |
493 | 493 | |
494 | - foreach ( $statement->getQualifiers() as $qualifier ) { |
|
495 | - $qualifierContext = new QualifierContext( $entity, $statement, $qualifier ); |
|
496 | - if ( $defaultResultsPerContext !== null ) { |
|
497 | - $result = array_merge( $result, $defaultResultsPerContext( $qualifierContext ) ); |
|
494 | + foreach ($statement->getQualifiers() as $qualifier) { |
|
495 | + $qualifierContext = new QualifierContext($entity, $statement, $qualifier); |
|
496 | + if ($defaultResultsPerContext !== null) { |
|
497 | + $result = array_merge($result, $defaultResultsPerContext($qualifierContext)); |
|
498 | 498 | } |
499 | 499 | $qualifierConstraints = $this->getConstraintsToUse( |
500 | 500 | $qualifierContext->getSnak()->getPropertyId(), |
501 | 501 | $constraintIds |
502 | 502 | ); |
503 | - foreach ( $qualifierConstraints as $qualifierConstraint ) { |
|
504 | - $result[] = $this->getCheckResultFor( $qualifierContext, $qualifierConstraint ); |
|
503 | + foreach ($qualifierConstraints as $qualifierConstraint) { |
|
504 | + $result[] = $this->getCheckResultFor($qualifierContext, $qualifierConstraint); |
|
505 | 505 | } |
506 | 506 | } |
507 | 507 | |
@@ -525,19 +525,19 @@ discard block |
||
525 | 525 | $result = []; |
526 | 526 | |
527 | 527 | /** @var Reference $reference */ |
528 | - foreach ( $statement->getReferences() as $reference ) { |
|
529 | - foreach ( $reference->getSnaks() as $snak ) { |
|
528 | + foreach ($statement->getReferences() as $reference) { |
|
529 | + foreach ($reference->getSnaks() as $snak) { |
|
530 | 530 | $referenceContext = new ReferenceContext( |
531 | 531 | $entity, $statement, $reference, $snak |
532 | 532 | ); |
533 | - if ( $defaultResultsPerContext !== null ) { |
|
534 | - $result = array_merge( $result, $defaultResultsPerContext( $referenceContext ) ); |
|
533 | + if ($defaultResultsPerContext !== null) { |
|
534 | + $result = array_merge($result, $defaultResultsPerContext($referenceContext)); |
|
535 | 535 | } |
536 | 536 | $referenceConstraints = $this->getConstraintsToUse( |
537 | 537 | $referenceContext->getSnak()->getPropertyId(), |
538 | 538 | $constraintIds |
539 | 539 | ); |
540 | - foreach ( $referenceConstraints as $referenceConstraint ) { |
|
540 | + foreach ($referenceConstraints as $referenceConstraint) { |
|
541 | 541 | $result[] = $this->getCheckResultFor( |
542 | 542 | $referenceContext, |
543 | 543 | $referenceConstraint |
@@ -549,50 +549,50 @@ discard block |
||
549 | 549 | return $result; |
550 | 550 | } |
551 | 551 | |
552 | - private function getCheckResultFor( Context $context, Constraint $constraint ): CheckResult { |
|
553 | - if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) { |
|
552 | + private function getCheckResultFor(Context $context, Constraint $constraint): CheckResult { |
|
553 | + if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) { |
|
554 | 554 | $checker = $this->checkerMap[$constraint->getConstraintTypeItemId()]; |
555 | - $result = $this->handleScope( $checker, $context, $constraint ); |
|
555 | + $result = $this->handleScope($checker, $context, $constraint); |
|
556 | 556 | |
557 | - if ( $result !== null ) { |
|
558 | - $this->addMetadata( $context, $result ); |
|
557 | + if ($result !== null) { |
|
558 | + $this->addMetadata($context, $result); |
|
559 | 559 | return $result; |
560 | 560 | } |
561 | 561 | |
562 | - $startTime = microtime( true ); |
|
562 | + $startTime = microtime(true); |
|
563 | 563 | try { |
564 | - $result = $checker->checkConstraint( $context, $constraint ); |
|
565 | - } catch ( ConstraintParameterException $e ) { |
|
564 | + $result = $checker->checkConstraint($context, $constraint); |
|
565 | + } catch (ConstraintParameterException $e) { |
|
566 | 566 | $result = new CheckResult( |
567 | 567 | $context, |
568 | 568 | $constraint, |
569 | 569 | CheckResult::STATUS_BAD_PARAMETERS, |
570 | 570 | $e->getViolationMessage() |
571 | 571 | ); |
572 | - } catch ( SparqlHelperException ) { |
|
573 | - $message = new ViolationMessage( 'wbqc-violation-message-sparql-error' ); |
|
574 | - $result = new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, $message ); |
|
572 | + } catch (SparqlHelperException) { |
|
573 | + $message = new ViolationMessage('wbqc-violation-message-sparql-error'); |
|
574 | + $result = new CheckResult($context, $constraint, CheckResult::STATUS_TODO, $message); |
|
575 | 575 | } |
576 | - $endTime = microtime( true ); |
|
576 | + $endTime = microtime(true); |
|
577 | 577 | |
578 | - $this->addMetadata( $context, $result ); |
|
578 | + $this->addMetadata($context, $result); |
|
579 | 579 | |
580 | - $this->addConstraintClarification( $result ); |
|
580 | + $this->addConstraintClarification($result); |
|
581 | 581 | |
582 | - $this->downgradeResultStatus( $result ); |
|
582 | + $this->downgradeResultStatus($result); |
|
583 | 583 | |
584 | 584 | $this->loggingHelper->logConstraintCheck( |
585 | 585 | $context, |
586 | 586 | $constraint, |
587 | 587 | $result, |
588 | - get_class( $checker ), |
|
588 | + get_class($checker), |
|
589 | 589 | $endTime - $startTime, |
590 | 590 | __METHOD__ |
591 | 591 | ); |
592 | 592 | |
593 | 593 | return $result; |
594 | 594 | } else { |
595 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null ); |
|
595 | + return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null); |
|
596 | 596 | } |
597 | 597 | } |
598 | 598 | |
@@ -601,87 +601,87 @@ discard block |
||
601 | 601 | Context $context, |
602 | 602 | Constraint $constraint |
603 | 603 | ): ?CheckResult { |
604 | - $validContextTypes = $this->getValidContextTypes( $constraint ); |
|
605 | - $validEntityTypes = $this->getValidEntityTypes( $constraint ); |
|
604 | + $validContextTypes = $this->getValidContextTypes($constraint); |
|
605 | + $validEntityTypes = $this->getValidEntityTypes($constraint); |
|
606 | 606 | try { |
607 | - [ $checkedContextTypes, $checkedEntityTypes ] = $this->constraintParameterParser->parseConstraintScopeParameters( |
|
607 | + [$checkedContextTypes, $checkedEntityTypes] = $this->constraintParameterParser->parseConstraintScopeParameters( |
|
608 | 608 | $constraint->getConstraintParameters(), |
609 | 609 | $constraint->getConstraintTypeItemId(), |
610 | 610 | $validContextTypes, |
611 | 611 | $validEntityTypes |
612 | 612 | ); |
613 | - } catch ( ConstraintParameterException $e ) { |
|
614 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() ); |
|
613 | + } catch (ConstraintParameterException $e) { |
|
614 | + return new CheckResult($context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage()); |
|
615 | 615 | } |
616 | 616 | |
617 | 617 | $checkedContextTypes ??= $checker->getDefaultContextTypes(); |
618 | 618 | $contextType = $context->getType(); |
619 | - if ( !in_array( $contextType, $checkedContextTypes ) ) { |
|
620 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null ); |
|
619 | + if (!in_array($contextType, $checkedContextTypes)) { |
|
620 | + return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null); |
|
621 | 621 | } |
622 | - if ( $checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO ) { |
|
623 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null ); |
|
622 | + if ($checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO) { |
|
623 | + return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null); |
|
624 | 624 | } |
625 | 625 | |
626 | 626 | $checkedEntityTypes ??= $validEntityTypes; |
627 | 627 | $entityType = $context->getEntity()->getType(); |
628 | - if ( !in_array( $entityType, $checkedEntityTypes ) ) { |
|
629 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null ); |
|
628 | + if (!in_array($entityType, $checkedEntityTypes)) { |
|
629 | + return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null); |
|
630 | 630 | } |
631 | - if ( $checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO ) { |
|
632 | - return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null ); |
|
631 | + if ($checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO) { |
|
632 | + return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null); |
|
633 | 633 | } |
634 | 634 | |
635 | 635 | return null; |
636 | 636 | } |
637 | 637 | |
638 | - private function addMetadata( Context $context, CheckResult $result ): void { |
|
639 | - $result->withMetadata( Metadata::merge( [ |
|
638 | + private function addMetadata(Context $context, CheckResult $result): void { |
|
639 | + $result->withMetadata(Metadata::merge([ |
|
640 | 640 | $result->getMetadata(), |
641 | - Metadata::ofDependencyMetadata( DependencyMetadata::merge( [ |
|
642 | - DependencyMetadata::ofEntityId( $context->getEntity()->getId() ), |
|
643 | - DependencyMetadata::ofEntityId( $result->getConstraint()->getPropertyId() ), |
|
644 | - ] ) ), |
|
645 | - ] ) ); |
|
641 | + Metadata::ofDependencyMetadata(DependencyMetadata::merge([ |
|
642 | + DependencyMetadata::ofEntityId($context->getEntity()->getId()), |
|
643 | + DependencyMetadata::ofEntityId($result->getConstraint()->getPropertyId()), |
|
644 | + ])), |
|
645 | + ])); |
|
646 | 646 | } |
647 | 647 | |
648 | - private function addConstraintClarification( CheckResult $result ): void { |
|
648 | + private function addConstraintClarification(CheckResult $result): void { |
|
649 | 649 | $constraint = $result->getConstraint(); |
650 | 650 | try { |
651 | 651 | $constraintClarification = $this->constraintParameterParser |
652 | - ->parseConstraintClarificationParameter( $constraint->getConstraintParameters() ); |
|
653 | - $result->setConstraintClarification( $constraintClarification ); |
|
654 | - } catch ( ConstraintParameterException $e ) { |
|
655 | - $result->setStatus( CheckResult::STATUS_BAD_PARAMETERS ); |
|
656 | - $result->setMessage( $e->getViolationMessage() ); |
|
652 | + ->parseConstraintClarificationParameter($constraint->getConstraintParameters()); |
|
653 | + $result->setConstraintClarification($constraintClarification); |
|
654 | + } catch (ConstraintParameterException $e) { |
|
655 | + $result->setStatus(CheckResult::STATUS_BAD_PARAMETERS); |
|
656 | + $result->setMessage($e->getViolationMessage()); |
|
657 | 657 | } |
658 | 658 | } |
659 | 659 | |
660 | - private function downgradeResultStatus( CheckResult $result ): void { |
|
660 | + private function downgradeResultStatus(CheckResult $result): void { |
|
661 | 661 | $constraint = $result->getConstraint(); |
662 | 662 | try { |
663 | 663 | $constraintStatus = $this->constraintParameterParser |
664 | - ->parseConstraintStatusParameter( $constraint->getConstraintParameters() ); |
|
665 | - } catch ( ConstraintParameterException $e ) { |
|
666 | - $result->setStatus( CheckResult::STATUS_BAD_PARAMETERS ); |
|
667 | - $result->setMessage( $e->getViolationMessage() ); |
|
664 | + ->parseConstraintStatusParameter($constraint->getConstraintParameters()); |
|
665 | + } catch (ConstraintParameterException $e) { |
|
666 | + $result->setStatus(CheckResult::STATUS_BAD_PARAMETERS); |
|
667 | + $result->setMessage($e->getViolationMessage()); |
|
668 | 668 | return; |
669 | 669 | } |
670 | - if ( $constraintStatus === null ) { |
|
670 | + if ($constraintStatus === null) { |
|
671 | 671 | // downgrade violation to warning |
672 | - if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) { |
|
673 | - $result->setStatus( CheckResult::STATUS_WARNING ); |
|
672 | + if ($result->getStatus() === CheckResult::STATUS_VIOLATION) { |
|
673 | + $result->setStatus(CheckResult::STATUS_WARNING); |
|
674 | 674 | } |
675 | - } elseif ( $constraintStatus === 'suggestion' ) { |
|
675 | + } elseif ($constraintStatus === 'suggestion') { |
|
676 | 676 | // downgrade violation to suggestion |
677 | - if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) { |
|
678 | - $result->setStatus( CheckResult::STATUS_SUGGESTION ); |
|
677 | + if ($result->getStatus() === CheckResult::STATUS_VIOLATION) { |
|
678 | + $result->setStatus(CheckResult::STATUS_SUGGESTION); |
|
679 | 679 | } |
680 | 680 | } else { |
681 | - if ( $constraintStatus !== 'mandatory' ) { |
|
681 | + if ($constraintStatus !== 'mandatory') { |
|
682 | 682 | // @codeCoverageIgnoreStart |
683 | 683 | throw new LogicException( |
684 | - "Unknown constraint status '$constraintStatus', " . |
|
684 | + "Unknown constraint status '$constraintStatus', ". |
|
685 | 685 | "only known statuses are 'mandatory' and 'suggestion'" |
686 | 686 | ); |
687 | 687 | // @codeCoverageIgnoreEnd |
@@ -694,12 +694,12 @@ discard block |
||
694 | 694 | * |
695 | 695 | * @return CheckResult[] |
696 | 696 | */ |
697 | - private function sortResult( array $result ): array { |
|
698 | - if ( count( $result ) < 2 ) { |
|
697 | + private function sortResult(array $result): array { |
|
698 | + if (count($result) < 2) { |
|
699 | 699 | return $result; |
700 | 700 | } |
701 | 701 | |
702 | - $sortFunction = static function ( CheckResult $a, CheckResult $b ) { |
|
702 | + $sortFunction = static function(CheckResult $a, CheckResult $b) { |
|
703 | 703 | $orderNum = 0; |
704 | 704 | $order = [ |
705 | 705 | CheckResult::STATUS_BAD_PARAMETERS => $orderNum++, |
@@ -716,55 +716,55 @@ discard block |
||
716 | 716 | $statusA = $a->getStatus(); |
717 | 717 | $statusB = $b->getStatus(); |
718 | 718 | |
719 | - $orderA = array_key_exists( $statusA, $order ) ? $order[ $statusA ] : $order[ 'other' ]; |
|
720 | - $orderB = array_key_exists( $statusB, $order ) ? $order[ $statusB ] : $order[ 'other' ]; |
|
719 | + $orderA = array_key_exists($statusA, $order) ? $order[$statusA] : $order['other']; |
|
720 | + $orderB = array_key_exists($statusB, $order) ? $order[$statusB] : $order['other']; |
|
721 | 721 | |
722 | - if ( $orderA === $orderB ) { |
|
722 | + if ($orderA === $orderB) { |
|
723 | 723 | $cursorA = $a->getContextCursor(); |
724 | 724 | $cursorB = $b->getContextCursor(); |
725 | 725 | |
726 | - if ( $cursorA instanceof EntityContextCursor ) { |
|
726 | + if ($cursorA instanceof EntityContextCursor) { |
|
727 | 727 | return $cursorB instanceof EntityContextCursor ? 0 : -1; |
728 | 728 | } |
729 | - if ( $cursorB instanceof EntityContextCursor ) { |
|
729 | + if ($cursorB instanceof EntityContextCursor) { |
|
730 | 730 | return $cursorA instanceof EntityContextCursor ? 0 : 1; |
731 | 731 | } |
732 | 732 | |
733 | 733 | $pidA = $cursorA->getSnakPropertyId(); |
734 | 734 | $pidB = $cursorB->getSnakPropertyId(); |
735 | 735 | |
736 | - if ( $pidA === $pidB ) { |
|
736 | + if ($pidA === $pidB) { |
|
737 | 737 | $hashA = $cursorA->getSnakHash(); |
738 | 738 | $hashB = $cursorB->getSnakHash(); |
739 | 739 | |
740 | - if ( $hashA === $hashB ) { |
|
741 | - if ( $a instanceof NullResult ) { |
|
740 | + if ($hashA === $hashB) { |
|
741 | + if ($a instanceof NullResult) { |
|
742 | 742 | return $b instanceof NullResult ? 0 : -1; |
743 | 743 | } |
744 | - if ( $b instanceof NullResult ) { |
|
744 | + if ($b instanceof NullResult) { |
|
745 | 745 | return $a instanceof NullResult ? 0 : 1; |
746 | 746 | } |
747 | 747 | |
748 | 748 | $typeA = $a->getConstraint()->getConstraintTypeItemId(); |
749 | 749 | $typeB = $b->getConstraint()->getConstraintTypeItemId(); |
750 | 750 | |
751 | - if ( $typeA == $typeB ) { |
|
751 | + if ($typeA == $typeB) { |
|
752 | 752 | return 0; |
753 | 753 | } else { |
754 | - return ( $typeA > $typeB ) ? 1 : -1; |
|
754 | + return ($typeA > $typeB) ? 1 : -1; |
|
755 | 755 | } |
756 | 756 | } else { |
757 | - return ( $hashA > $hashB ) ? 1 : -1; |
|
757 | + return ($hashA > $hashB) ? 1 : -1; |
|
758 | 758 | } |
759 | 759 | } else { |
760 | - return ( $pidA > $pidB ) ? 1 : -1; |
|
760 | + return ($pidA > $pidB) ? 1 : -1; |
|
761 | 761 | } |
762 | 762 | } else { |
763 | - return ( $orderA > $orderB ) ? 1 : -1; |
|
763 | + return ($orderA > $orderB) ? 1 : -1; |
|
764 | 764 | } |
765 | 765 | }; |
766 | 766 | |
767 | - uasort( $result, $sortFunction ); |
|
767 | + uasort($result, $sortFunction); |
|
768 | 768 | |
769 | 769 | return $result; |
770 | 770 | } |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -declare( strict_types = 1 ); |
|
3 | +declare(strict_types=1); |
|
4 | 4 | |
5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Helper; |
6 | 6 | |
@@ -68,15 +68,15 @@ discard block |
||
68 | 68 | * Check if any errors are recorded in the constraint parameters. |
69 | 69 | * @throws ConstraintParameterException |
70 | 70 | */ |
71 | - public function checkError( array $parameters ): void { |
|
72 | - if ( array_key_exists( '@error', $parameters ) ) { |
|
71 | + public function checkError(array $parameters): void { |
|
72 | + if (array_key_exists('@error', $parameters)) { |
|
73 | 73 | $error = $parameters['@error']; |
74 | - if ( array_key_exists( 'toolong', $error ) && $error['toolong'] ) { |
|
74 | + if (array_key_exists('toolong', $error) && $error['toolong']) { |
|
75 | 75 | $msg = 'wbqc-violation-message-parameters-error-toolong'; |
76 | 76 | } else { |
77 | 77 | $msg = 'wbqc-violation-message-parameters-error-unknown'; |
78 | 78 | } |
79 | - throw new ConstraintParameterException( new ViolationMessage( $msg ) ); |
|
79 | + throw new ConstraintParameterException(new ViolationMessage($msg)); |
|
80 | 80 | } |
81 | 81 | } |
82 | 82 | |
@@ -84,11 +84,11 @@ discard block |
||
84 | 84 | * Require that $parameters contains exactly one $parameterId parameter. |
85 | 85 | * @throws ConstraintParameterException |
86 | 86 | */ |
87 | - private function requireSingleParameter( array $parameters, string $parameterId ): void { |
|
88 | - if ( count( $parameters[$parameterId] ) !== 1 ) { |
|
87 | + private function requireSingleParameter(array $parameters, string $parameterId): void { |
|
88 | + if (count($parameters[$parameterId]) !== 1) { |
|
89 | 89 | throw new ConstraintParameterException( |
90 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-single' ) ) |
|
91 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
90 | + (new ViolationMessage('wbqc-violation-message-parameter-single')) |
|
91 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
92 | 92 | ); |
93 | 93 | } |
94 | 94 | } |
@@ -97,11 +97,11 @@ discard block |
||
97 | 97 | * Require that $snak is a {@link PropertyValueSnak}. |
98 | 98 | * @throws ConstraintParameterException |
99 | 99 | */ |
100 | - private function requireValueParameter( Snak $snak, string $parameterId ): void { |
|
101 | - if ( !( $snak instanceof PropertyValueSnak ) ) { |
|
100 | + private function requireValueParameter(Snak $snak, string $parameterId): void { |
|
101 | + if (!($snak instanceof PropertyValueSnak)) { |
|
102 | 102 | throw new ConstraintParameterException( |
103 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
104 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
103 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
104 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
105 | 105 | ); |
106 | 106 | } |
107 | 107 | } |
@@ -110,17 +110,17 @@ discard block |
||
110 | 110 | * Parse a single entity ID parameter. |
111 | 111 | * @throws ConstraintParameterException |
112 | 112 | */ |
113 | - private function parseEntityIdParameter( array $snakSerialization, string $parameterId ): EntityId { |
|
114 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
115 | - $this->requireValueParameter( $snak, $parameterId ); |
|
113 | + private function parseEntityIdParameter(array $snakSerialization, string $parameterId): EntityId { |
|
114 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
115 | + $this->requireValueParameter($snak, $parameterId); |
|
116 | 116 | $value = $snak->getDataValue(); |
117 | - if ( $value instanceof EntityIdValue ) { |
|
117 | + if ($value instanceof EntityIdValue) { |
|
118 | 118 | return $value->getEntityId(); |
119 | 119 | } else { |
120 | 120 | throw new ConstraintParameterException( |
121 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-entity' ) ) |
|
122 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
123 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
121 | + (new ViolationMessage('wbqc-violation-message-parameter-entity')) |
|
122 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
123 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
124 | 124 | ); |
125 | 125 | } |
126 | 126 | } |
@@ -131,20 +131,20 @@ discard block |
||
131 | 131 | * @throws ConstraintParameterException if the parameter is invalid or missing |
132 | 132 | * @return string[] class entity ID serializations |
133 | 133 | */ |
134 | - public function parseClassParameter( array $constraintParameters, string $constraintTypeItemId ): array { |
|
135 | - $this->checkError( $constraintParameters ); |
|
136 | - $classId = $this->config->get( 'WBQualityConstraintsClassId' ); |
|
137 | - if ( !array_key_exists( $classId, $constraintParameters ) ) { |
|
134 | + public function parseClassParameter(array $constraintParameters, string $constraintTypeItemId): array { |
|
135 | + $this->checkError($constraintParameters); |
|
136 | + $classId = $this->config->get('WBQualityConstraintsClassId'); |
|
137 | + if (!array_key_exists($classId, $constraintParameters)) { |
|
138 | 138 | throw new ConstraintParameterException( |
139 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
140 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
141 | - ->withEntityId( new NumericPropertyId( $classId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
139 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
140 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
141 | + ->withEntityId(new NumericPropertyId($classId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
142 | 142 | ); |
143 | 143 | } |
144 | 144 | |
145 | 145 | $classes = []; |
146 | - foreach ( $constraintParameters[$classId] as $class ) { |
|
147 | - $classes[] = $this->parseEntityIdParameter( $class, $classId )->getSerialization(); |
|
146 | + foreach ($constraintParameters[$classId] as $class) { |
|
147 | + $classes[] = $this->parseEntityIdParameter($class, $classId)->getSerialization(); |
|
148 | 148 | } |
149 | 149 | return $classes; |
150 | 150 | } |
@@ -155,31 +155,31 @@ discard block |
||
155 | 155 | * @throws ConstraintParameterException if the parameter is invalid or missing |
156 | 156 | * @return string 'instance', 'subclass', or 'instanceOrSubclass' |
157 | 157 | */ |
158 | - public function parseRelationParameter( array $constraintParameters, string $constraintTypeItemId ): string { |
|
159 | - $this->checkError( $constraintParameters ); |
|
160 | - $relationId = $this->config->get( 'WBQualityConstraintsRelationId' ); |
|
161 | - if ( !array_key_exists( $relationId, $constraintParameters ) ) { |
|
158 | + public function parseRelationParameter(array $constraintParameters, string $constraintTypeItemId): string { |
|
159 | + $this->checkError($constraintParameters); |
|
160 | + $relationId = $this->config->get('WBQualityConstraintsRelationId'); |
|
161 | + if (!array_key_exists($relationId, $constraintParameters)) { |
|
162 | 162 | throw new ConstraintParameterException( |
163 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
164 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
165 | - ->withEntityId( new NumericPropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
163 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
164 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
165 | + ->withEntityId(new NumericPropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
166 | 166 | ); |
167 | 167 | } |
168 | 168 | |
169 | - $this->requireSingleParameter( $constraintParameters, $relationId ); |
|
170 | - $relationEntityId = $this->parseEntityIdParameter( $constraintParameters[$relationId][0], $relationId ); |
|
171 | - if ( !( $relationEntityId instanceof ItemId ) ) { |
|
169 | + $this->requireSingleParameter($constraintParameters, $relationId); |
|
170 | + $relationEntityId = $this->parseEntityIdParameter($constraintParameters[$relationId][0], $relationId); |
|
171 | + if (!($relationEntityId instanceof ItemId)) { |
|
172 | 172 | throw new ConstraintParameterException( |
173 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-item' ) ) |
|
174 | - ->withEntityId( new NumericPropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
175 | - ->withDataValue( new EntityIdValue( $relationEntityId ), Role::CONSTRAINT_PARAMETER_VALUE ) |
|
173 | + (new ViolationMessage('wbqc-violation-message-parameter-item')) |
|
174 | + ->withEntityId(new NumericPropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
175 | + ->withDataValue(new EntityIdValue($relationEntityId), Role::CONSTRAINT_PARAMETER_VALUE) |
|
176 | 176 | ); |
177 | 177 | } |
178 | - return $this->mapItemId( $relationEntityId, [ |
|
179 | - $this->config->get( 'WBQualityConstraintsInstanceOfRelationId' ) => 'instance', |
|
180 | - $this->config->get( 'WBQualityConstraintsSubclassOfRelationId' ) => 'subclass', |
|
181 | - $this->config->get( 'WBQualityConstraintsInstanceOrSubclassOfRelationId' ) => 'instanceOrSubclass', |
|
182 | - ], $relationId ); |
|
178 | + return $this->mapItemId($relationEntityId, [ |
|
179 | + $this->config->get('WBQualityConstraintsInstanceOfRelationId') => 'instance', |
|
180 | + $this->config->get('WBQualityConstraintsSubclassOfRelationId') => 'subclass', |
|
181 | + $this->config->get('WBQualityConstraintsInstanceOrSubclassOfRelationId') => 'instanceOrSubclass', |
|
182 | + ], $relationId); |
|
183 | 183 | } |
184 | 184 | |
185 | 185 | /** |
@@ -189,20 +189,20 @@ discard block |
||
189 | 189 | * @throws ConstraintParameterException |
190 | 190 | * @return PropertyId |
191 | 191 | */ |
192 | - private function parsePropertyIdParameter( array $snakSerialization, string $parameterId ): PropertyId { |
|
193 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
194 | - $this->requireValueParameter( $snak, $parameterId ); |
|
192 | + private function parsePropertyIdParameter(array $snakSerialization, string $parameterId): PropertyId { |
|
193 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
194 | + $this->requireValueParameter($snak, $parameterId); |
|
195 | 195 | $value = $snak->getDataValue(); |
196 | - if ( $value instanceof EntityIdValue ) { |
|
196 | + if ($value instanceof EntityIdValue) { |
|
197 | 197 | $id = $value->getEntityId(); |
198 | - if ( $id instanceof PropertyId ) { |
|
198 | + if ($id instanceof PropertyId) { |
|
199 | 199 | return $id; |
200 | 200 | } |
201 | 201 | } |
202 | 202 | throw new ConstraintParameterException( |
203 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-property' ) ) |
|
204 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
205 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
203 | + (new ViolationMessage('wbqc-violation-message-parameter-property')) |
|
204 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
205 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
206 | 206 | ); |
207 | 207 | } |
208 | 208 | |
@@ -213,34 +213,34 @@ discard block |
||
213 | 213 | * @throws ConstraintParameterException if the parameter is invalid or missing |
214 | 214 | * @return PropertyId |
215 | 215 | */ |
216 | - public function parsePropertyParameter( array $constraintParameters, string $constraintTypeItemId ): PropertyId { |
|
217 | - $this->checkError( $constraintParameters ); |
|
218 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
219 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
216 | + public function parsePropertyParameter(array $constraintParameters, string $constraintTypeItemId): PropertyId { |
|
217 | + $this->checkError($constraintParameters); |
|
218 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
219 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
220 | 220 | throw new ConstraintParameterException( |
221 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
222 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
223 | - ->withEntityId( new NumericPropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
221 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
222 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
223 | + ->withEntityId(new NumericPropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
224 | 224 | ); |
225 | 225 | } |
226 | 226 | |
227 | - $this->requireSingleParameter( $constraintParameters, $propertyId ); |
|
228 | - return $this->parsePropertyIdParameter( $constraintParameters[$propertyId][0], $propertyId ); |
|
227 | + $this->requireSingleParameter($constraintParameters, $propertyId); |
|
228 | + return $this->parsePropertyIdParameter($constraintParameters[$propertyId][0], $propertyId); |
|
229 | 229 | } |
230 | 230 | |
231 | 231 | /** @throws ConstraintParameterException */ |
232 | - private function parseItemIdParameter( PropertyValueSnak $snak, string $parameterId ): ItemIdSnakValue { |
|
232 | + private function parseItemIdParameter(PropertyValueSnak $snak, string $parameterId): ItemIdSnakValue { |
|
233 | 233 | $dataValue = $snak->getDataValue(); |
234 | - if ( $dataValue instanceof EntityIdValue ) { |
|
234 | + if ($dataValue instanceof EntityIdValue) { |
|
235 | 235 | $entityId = $dataValue->getEntityId(); |
236 | - if ( $entityId instanceof ItemId ) { |
|
237 | - return ItemIdSnakValue::fromItemId( $entityId ); |
|
236 | + if ($entityId instanceof ItemId) { |
|
237 | + return ItemIdSnakValue::fromItemId($entityId); |
|
238 | 238 | } |
239 | 239 | } |
240 | 240 | throw new ConstraintParameterException( |
241 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-item' ) ) |
|
242 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
243 | - ->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
241 | + (new ViolationMessage('wbqc-violation-message-parameter-item')) |
|
242 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
243 | + ->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
244 | 244 | ); |
245 | 245 | } |
246 | 246 | |
@@ -258,14 +258,14 @@ discard block |
||
258 | 258 | bool $required, |
259 | 259 | ?string $parameterId = null |
260 | 260 | ): array { |
261 | - $this->checkError( $constraintParameters ); |
|
262 | - $parameterId ??= $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
263 | - if ( !array_key_exists( $parameterId, $constraintParameters ) ) { |
|
264 | - if ( $required ) { |
|
261 | + $this->checkError($constraintParameters); |
|
262 | + $parameterId ??= $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
263 | + if (!array_key_exists($parameterId, $constraintParameters)) { |
|
264 | + if ($required) { |
|
265 | 265 | throw new ConstraintParameterException( |
266 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
267 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
268 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
266 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
267 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
268 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
269 | 269 | ); |
270 | 270 | } else { |
271 | 271 | return []; |
@@ -273,11 +273,11 @@ discard block |
||
273 | 273 | } |
274 | 274 | |
275 | 275 | $values = []; |
276 | - foreach ( $constraintParameters[$parameterId] as $parameter ) { |
|
277 | - $snak = $this->snakDeserializer->deserialize( $parameter ); |
|
278 | - switch ( true ) { |
|
276 | + foreach ($constraintParameters[$parameterId] as $parameter) { |
|
277 | + $snak = $this->snakDeserializer->deserialize($parameter); |
|
278 | + switch (true) { |
|
279 | 279 | case $snak instanceof PropertyValueSnak: |
280 | - $values[] = $this->parseItemIdParameter( $snak, $parameterId ); |
|
280 | + $values[] = $this->parseItemIdParameter($snak, $parameterId); |
|
281 | 281 | break; |
282 | 282 | case $snak instanceof PropertySomeValueSnak: |
283 | 283 | $values[] = ItemIdSnakValue::someValue(); |
@@ -306,13 +306,13 @@ discard block |
||
306 | 306 | string $parameterId |
307 | 307 | ): array { |
308 | 308 | /** @throws ConstraintParameterException */ |
309 | - return array_map( static function ( ItemIdSnakValue $value ) use ( $parameterId ): ItemId { |
|
310 | - if ( $value->isValue() ) { |
|
309 | + return array_map(static function(ItemIdSnakValue $value) use ($parameterId): ItemId { |
|
310 | + if ($value->isValue()) { |
|
311 | 311 | return $value->getItemId(); |
312 | 312 | } else { |
313 | 313 | throw new ConstraintParameterException( |
314 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) ) |
|
315 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
314 | + (new ViolationMessage('wbqc-violation-message-parameter-value')) |
|
315 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
316 | 316 | ); |
317 | 317 | } |
318 | 318 | }, $this->parseItemsParameter( |
@@ -320,7 +320,7 @@ discard block |
||
320 | 320 | $constraintTypeItemId, |
321 | 321 | $required, |
322 | 322 | $parameterId |
323 | - ) ); |
|
323 | + )); |
|
324 | 324 | } |
325 | 325 | |
326 | 326 | /** |
@@ -328,18 +328,18 @@ discard block |
||
328 | 328 | * @throws ConstraintParameterException |
329 | 329 | * @return mixed elements of $mapping |
330 | 330 | */ |
331 | - private function mapItemId( ItemId $itemId, array $mapping, string $parameterId ) { |
|
331 | + private function mapItemId(ItemId $itemId, array $mapping, string $parameterId) { |
|
332 | 332 | $serialization = $itemId->getSerialization(); |
333 | - if ( array_key_exists( $serialization, $mapping ) ) { |
|
333 | + if (array_key_exists($serialization, $mapping)) { |
|
334 | 334 | return $mapping[$serialization]; |
335 | 335 | } else { |
336 | - $allowed = array_map( static function ( $id ) { |
|
337 | - return new ItemId( $id ); |
|
338 | - }, array_keys( $mapping ) ); |
|
336 | + $allowed = array_map(static function($id) { |
|
337 | + return new ItemId($id); |
|
338 | + }, array_keys($mapping)); |
|
339 | 339 | throw new ConstraintParameterException( |
340 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
341 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
342 | - ->withEntityIdList( $allowed, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
340 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
341 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
342 | + ->withEntityIdList($allowed, Role::CONSTRAINT_PARAMETER_VALUE) |
|
343 | 343 | ); |
344 | 344 | } |
345 | 345 | } |
@@ -350,27 +350,27 @@ discard block |
||
350 | 350 | * @throws ConstraintParameterException if the parameter is invalid or missing |
351 | 351 | * @return PropertyId[] |
352 | 352 | */ |
353 | - public function parsePropertiesParameter( array $constraintParameters, string $constraintTypeItemId ): array { |
|
354 | - $this->checkError( $constraintParameters ); |
|
355 | - $propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' ); |
|
356 | - if ( !array_key_exists( $propertyId, $constraintParameters ) ) { |
|
353 | + public function parsePropertiesParameter(array $constraintParameters, string $constraintTypeItemId): array { |
|
354 | + $this->checkError($constraintParameters); |
|
355 | + $propertyId = $this->config->get('WBQualityConstraintsPropertyId'); |
|
356 | + if (!array_key_exists($propertyId, $constraintParameters)) { |
|
357 | 357 | throw new ConstraintParameterException( |
358 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
359 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
360 | - ->withEntityId( new NumericPropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
358 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
359 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
360 | + ->withEntityId(new NumericPropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
361 | 361 | ); |
362 | 362 | } |
363 | 363 | |
364 | 364 | $parameters = $constraintParameters[$propertyId]; |
365 | - if ( count( $parameters ) === 1 && |
|
366 | - $this->snakDeserializer->deserialize( $parameters[0] ) instanceof PropertyNoValueSnak |
|
365 | + if (count($parameters) === 1 && |
|
366 | + $this->snakDeserializer->deserialize($parameters[0]) instanceof PropertyNoValueSnak |
|
367 | 367 | ) { |
368 | 368 | return []; |
369 | 369 | } |
370 | 370 | |
371 | 371 | $properties = []; |
372 | - foreach ( $parameters as $parameter ) { |
|
373 | - $properties[] = $this->parsePropertyIdParameter( $parameter, $propertyId ); |
|
372 | + foreach ($parameters as $parameter) { |
|
373 | + $properties[] = $this->parsePropertyIdParameter($parameter, $propertyId); |
|
374 | 374 | } |
375 | 375 | return $properties; |
376 | 376 | } |
@@ -378,24 +378,24 @@ discard block |
||
378 | 378 | /** |
379 | 379 | * @throws ConstraintParameterException |
380 | 380 | */ |
381 | - private function parseValueOrNoValueParameter( array $snakSerialization, string $parameterId ): ?DataValue { |
|
382 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
383 | - if ( $snak instanceof PropertyValueSnak ) { |
|
381 | + private function parseValueOrNoValueParameter(array $snakSerialization, string $parameterId): ?DataValue { |
|
382 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
383 | + if ($snak instanceof PropertyValueSnak) { |
|
384 | 384 | return $snak->getDataValue(); |
385 | - } elseif ( $snak instanceof PropertyNoValueSnak ) { |
|
385 | + } elseif ($snak instanceof PropertyNoValueSnak) { |
|
386 | 386 | return null; |
387 | 387 | } else { |
388 | 388 | throw new ConstraintParameterException( |
389 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) ) |
|
390 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
389 | + (new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue')) |
|
390 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
391 | 391 | ); |
392 | 392 | } |
393 | 393 | } |
394 | 394 | |
395 | - private function parseValueOrNoValueOrNowParameter( array $snakSerialization, string $parameterId ): ?DataValue { |
|
395 | + private function parseValueOrNoValueOrNowParameter(array $snakSerialization, string $parameterId): ?DataValue { |
|
396 | 396 | try { |
397 | - return $this->parseValueOrNoValueParameter( $snakSerialization, $parameterId ); |
|
398 | - } catch ( ConstraintParameterException ) { |
|
397 | + return $this->parseValueOrNoValueParameter($snakSerialization, $parameterId); |
|
398 | + } catch (ConstraintParameterException) { |
|
399 | 399 | // unknown value means “now” |
400 | 400 | return new NowValue(); |
401 | 401 | } |
@@ -404,14 +404,14 @@ discard block |
||
404 | 404 | /** |
405 | 405 | * Checks whether there is exactly one non-null quantity with the given unit. |
406 | 406 | */ |
407 | - private function exactlyOneQuantityWithUnit( ?DataValue $min, ?DataValue $max, string $unit ): bool { |
|
408 | - if ( !( $min instanceof UnboundedQuantityValue ) || |
|
409 | - !( $max instanceof UnboundedQuantityValue ) |
|
407 | + private function exactlyOneQuantityWithUnit(?DataValue $min, ?DataValue $max, string $unit): bool { |
|
408 | + if (!($min instanceof UnboundedQuantityValue) || |
|
409 | + !($max instanceof UnboundedQuantityValue) |
|
410 | 410 | ) { |
411 | 411 | return false; |
412 | 412 | } |
413 | 413 | |
414 | - return ( $min->getUnit() === $unit ) !== ( $max->getUnit() === $unit ); |
|
414 | + return ($min->getUnit() === $unit) !== ($max->getUnit() === $unit); |
|
415 | 415 | } |
416 | 416 | |
417 | 417 | /** |
@@ -431,42 +431,42 @@ discard block |
||
431 | 431 | string $constraintTypeItemId, |
432 | 432 | string $type |
433 | 433 | ): array { |
434 | - $this->checkError( $constraintParameters ); |
|
435 | - if ( !array_key_exists( $minimumId, $constraintParameters ) || |
|
436 | - !array_key_exists( $maximumId, $constraintParameters ) |
|
434 | + $this->checkError($constraintParameters); |
|
435 | + if (!array_key_exists($minimumId, $constraintParameters) || |
|
436 | + !array_key_exists($maximumId, $constraintParameters) |
|
437 | 437 | ) { |
438 | 438 | throw new ConstraintParameterException( |
439 | - ( new ViolationMessage( 'wbqc-violation-message-range-parameters-needed' ) ) |
|
440 | - ->withDataValueType( $type ) |
|
441 | - ->withEntityId( new NumericPropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
442 | - ->withEntityId( new NumericPropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
443 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
439 | + (new ViolationMessage('wbqc-violation-message-range-parameters-needed')) |
|
440 | + ->withDataValueType($type) |
|
441 | + ->withEntityId(new NumericPropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
442 | + ->withEntityId(new NumericPropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
443 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
444 | 444 | ); |
445 | 445 | } |
446 | 446 | |
447 | - $this->requireSingleParameter( $constraintParameters, $minimumId ); |
|
448 | - $this->requireSingleParameter( $constraintParameters, $maximumId ); |
|
447 | + $this->requireSingleParameter($constraintParameters, $minimumId); |
|
448 | + $this->requireSingleParameter($constraintParameters, $maximumId); |
|
449 | 449 | $parseFunction = $type === 'time' ? 'parseValueOrNoValueOrNowParameter' : 'parseValueOrNoValueParameter'; |
450 | - $min = $this->$parseFunction( $constraintParameters[$minimumId][0], $minimumId ); |
|
451 | - $max = $this->$parseFunction( $constraintParameters[$maximumId][0], $maximumId ); |
|
450 | + $min = $this->$parseFunction($constraintParameters[$minimumId][0], $minimumId); |
|
451 | + $max = $this->$parseFunction($constraintParameters[$maximumId][0], $maximumId); |
|
452 | 452 | |
453 | - $yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' ); |
|
454 | - if ( $this->exactlyOneQuantityWithUnit( $min, $max, $yearUnit ) ) { |
|
453 | + $yearUnit = $this->config->get('WBQualityConstraintsYearUnit'); |
|
454 | + if ($this->exactlyOneQuantityWithUnit($min, $max, $yearUnit)) { |
|
455 | 455 | throw new ConstraintParameterException( |
456 | - new ViolationMessage( 'wbqc-violation-message-range-parameters-one-year' ) |
|
456 | + new ViolationMessage('wbqc-violation-message-range-parameters-one-year') |
|
457 | 457 | ); |
458 | 458 | } |
459 | - if ( ( $min === null && $max === null ) || |
|
460 | - ( $min !== null && $max !== null && $min->equals( $max ) ) |
|
459 | + if (($min === null && $max === null) || |
|
460 | + ($min !== null && $max !== null && $min->equals($max)) |
|
461 | 461 | ) { |
462 | 462 | throw new ConstraintParameterException( |
463 | - ( new ViolationMessage( 'wbqc-violation-message-range-parameters-same' ) ) |
|
464 | - ->withEntityId( new NumericPropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
465 | - ->withEntityId( new NumericPropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
463 | + (new ViolationMessage('wbqc-violation-message-range-parameters-same')) |
|
464 | + ->withEntityId(new NumericPropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
465 | + ->withEntityId(new NumericPropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
466 | 466 | ); |
467 | 467 | } |
468 | 468 | |
469 | - return [ $min, $max ]; |
|
469 | + return [$min, $max]; |
|
470 | 470 | } |
471 | 471 | |
472 | 472 | /** |
@@ -476,11 +476,11 @@ discard block |
||
476 | 476 | * @throws ConstraintParameterException if the parameter is invalid or missing |
477 | 477 | * @return DataValue[] a pair of two data values, either of which may be null to signify an open range |
478 | 478 | */ |
479 | - public function parseQuantityRangeParameter( array $constraintParameters, string $constraintTypeItemId ): array { |
|
479 | + public function parseQuantityRangeParameter(array $constraintParameters, string $constraintTypeItemId): array { |
|
480 | 480 | return $this->parseRangeParameter( |
481 | 481 | $constraintParameters, |
482 | - $this->config->get( 'WBQualityConstraintsMinimumQuantityId' ), |
|
483 | - $this->config->get( 'WBQualityConstraintsMaximumQuantityId' ), |
|
482 | + $this->config->get('WBQualityConstraintsMinimumQuantityId'), |
|
483 | + $this->config->get('WBQualityConstraintsMaximumQuantityId'), |
|
484 | 484 | $constraintTypeItemId, |
485 | 485 | 'quantity' |
486 | 486 | ); |
@@ -493,11 +493,11 @@ discard block |
||
493 | 493 | * @throws ConstraintParameterException if the parameter is invalid or missing |
494 | 494 | * @return DataValue[] a pair of two data values, either of which may be null to signify an open range |
495 | 495 | */ |
496 | - public function parseTimeRangeParameter( array $constraintParameters, string $constraintTypeItemId ): array { |
|
496 | + public function parseTimeRangeParameter(array $constraintParameters, string $constraintTypeItemId): array { |
|
497 | 497 | return $this->parseRangeParameter( |
498 | 498 | $constraintParameters, |
499 | - $this->config->get( 'WBQualityConstraintsMinimumDateId' ), |
|
500 | - $this->config->get( 'WBQualityConstraintsMaximumDateId' ), |
|
499 | + $this->config->get('WBQualityConstraintsMinimumDateId'), |
|
500 | + $this->config->get('WBQualityConstraintsMaximumDateId'), |
|
501 | 501 | $constraintTypeItemId, |
502 | 502 | 'time' |
503 | 503 | ); |
@@ -510,20 +510,20 @@ discard block |
||
510 | 510 | * @throws ConstraintParameterException |
511 | 511 | * @return string[] |
512 | 512 | */ |
513 | - public function parseLanguageParameter( array $constraintParameters, string $constraintTypeItemId ): array { |
|
514 | - $this->checkError( $constraintParameters ); |
|
515 | - $languagePropertyId = $this->config->get( 'WBQualityConstraintsLanguagePropertyId' ); |
|
516 | - if ( !array_key_exists( $languagePropertyId, $constraintParameters ) ) { |
|
513 | + public function parseLanguageParameter(array $constraintParameters, string $constraintTypeItemId): array { |
|
514 | + $this->checkError($constraintParameters); |
|
515 | + $languagePropertyId = $this->config->get('WBQualityConstraintsLanguagePropertyId'); |
|
516 | + if (!array_key_exists($languagePropertyId, $constraintParameters)) { |
|
517 | 517 | throw new ConstraintParameterException( |
518 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
519 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
520 | - ->withEntityId( new NumericPropertyId( $languagePropertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
518 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
519 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
520 | + ->withEntityId(new NumericPropertyId($languagePropertyId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
521 | 521 | ); |
522 | 522 | } |
523 | 523 | |
524 | 524 | $languages = []; |
525 | - foreach ( $constraintParameters[$languagePropertyId] as $snak ) { |
|
526 | - $languages[] = $this->parseStringParameter( $snak, $languagePropertyId ); |
|
525 | + foreach ($constraintParameters[$languagePropertyId] as $snak) { |
|
526 | + $languages[] = $this->parseStringParameter($snak, $languagePropertyId); |
|
527 | 527 | } |
528 | 528 | return $languages; |
529 | 529 | } |
@@ -532,17 +532,17 @@ discard block |
||
532 | 532 | * Parse a single string parameter. |
533 | 533 | * @throws ConstraintParameterException |
534 | 534 | */ |
535 | - private function parseStringParameter( array $snakSerialization, string $parameterId ): string { |
|
536 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
537 | - $this->requireValueParameter( $snak, $parameterId ); |
|
535 | + private function parseStringParameter(array $snakSerialization, string $parameterId): string { |
|
536 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
537 | + $this->requireValueParameter($snak, $parameterId); |
|
538 | 538 | $value = $snak->getDataValue(); |
539 | - if ( $value instanceof StringValue ) { |
|
539 | + if ($value instanceof StringValue) { |
|
540 | 540 | return $value->getValue(); |
541 | 541 | } else { |
542 | 542 | throw new ConstraintParameterException( |
543 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-string' ) ) |
|
544 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
545 | - ->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
543 | + (new ViolationMessage('wbqc-violation-message-parameter-string')) |
|
544 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
545 | + ->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE) |
|
546 | 546 | ); |
547 | 547 | } |
548 | 548 | } |
@@ -553,15 +553,15 @@ discard block |
||
553 | 553 | * @throws ConstraintParameterException if the parameter is invalid or missing |
554 | 554 | * @return string |
555 | 555 | */ |
556 | - public function parseNamespaceParameter( array $constraintParameters, string $constraintTypeItemId ): string { |
|
557 | - $this->checkError( $constraintParameters ); |
|
558 | - $namespaceId = $this->config->get( 'WBQualityConstraintsNamespaceId' ); |
|
559 | - if ( !array_key_exists( $namespaceId, $constraintParameters ) ) { |
|
556 | + public function parseNamespaceParameter(array $constraintParameters, string $constraintTypeItemId): string { |
|
557 | + $this->checkError($constraintParameters); |
|
558 | + $namespaceId = $this->config->get('WBQualityConstraintsNamespaceId'); |
|
559 | + if (!array_key_exists($namespaceId, $constraintParameters)) { |
|
560 | 560 | return ''; |
561 | 561 | } |
562 | 562 | |
563 | - $this->requireSingleParameter( $constraintParameters, $namespaceId ); |
|
564 | - return $this->parseStringParameter( $constraintParameters[$namespaceId][0], $namespaceId ); |
|
563 | + $this->requireSingleParameter($constraintParameters, $namespaceId); |
|
564 | + return $this->parseStringParameter($constraintParameters[$namespaceId][0], $namespaceId); |
|
565 | 565 | } |
566 | 566 | |
567 | 567 | /** |
@@ -570,19 +570,19 @@ discard block |
||
570 | 570 | * @throws ConstraintParameterException if the parameter is invalid or missing |
571 | 571 | * @return string |
572 | 572 | */ |
573 | - public function parseFormatParameter( array $constraintParameters, string $constraintTypeItemId ): string { |
|
574 | - $this->checkError( $constraintParameters ); |
|
575 | - $formatId = $this->config->get( 'WBQualityConstraintsFormatAsARegularExpressionId' ); |
|
576 | - if ( !array_key_exists( $formatId, $constraintParameters ) ) { |
|
573 | + public function parseFormatParameter(array $constraintParameters, string $constraintTypeItemId): string { |
|
574 | + $this->checkError($constraintParameters); |
|
575 | + $formatId = $this->config->get('WBQualityConstraintsFormatAsARegularExpressionId'); |
|
576 | + if (!array_key_exists($formatId, $constraintParameters)) { |
|
577 | 577 | throw new ConstraintParameterException( |
578 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) ) |
|
579 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
580 | - ->withEntityId( new NumericPropertyId( $formatId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
578 | + (new ViolationMessage('wbqc-violation-message-parameter-needed')) |
|
579 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
580 | + ->withEntityId(new NumericPropertyId($formatId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
581 | 581 | ); |
582 | 582 | } |
583 | 583 | |
584 | - $this->requireSingleParameter( $constraintParameters, $formatId ); |
|
585 | - return $this->parseStringParameter( $constraintParameters[$formatId][0], $formatId ); |
|
584 | + $this->requireSingleParameter($constraintParameters, $formatId); |
|
585 | + return $this->parseStringParameter($constraintParameters[$formatId][0], $formatId); |
|
586 | 586 | } |
587 | 587 | |
588 | 588 | /** |
@@ -590,16 +590,16 @@ discard block |
||
590 | 590 | * @throws ConstraintParameterException if the parameter is invalid |
591 | 591 | * @return EntityId[] |
592 | 592 | */ |
593 | - public function parseExceptionParameter( array $constraintParameters ): array { |
|
594 | - $this->checkError( $constraintParameters ); |
|
595 | - $exceptionId = $this->config->get( 'WBQualityConstraintsExceptionToConstraintId' ); |
|
596 | - if ( !array_key_exists( $exceptionId, $constraintParameters ) ) { |
|
593 | + public function parseExceptionParameter(array $constraintParameters): array { |
|
594 | + $this->checkError($constraintParameters); |
|
595 | + $exceptionId = $this->config->get('WBQualityConstraintsExceptionToConstraintId'); |
|
596 | + if (!array_key_exists($exceptionId, $constraintParameters)) { |
|
597 | 597 | return []; |
598 | 598 | } |
599 | 599 | |
600 | 600 | return array_map( |
601 | - function ( $snakSerialization ) use ( $exceptionId ) { |
|
602 | - return $this->parseEntityIdParameter( $snakSerialization, $exceptionId ); |
|
601 | + function($snakSerialization) use ($exceptionId) { |
|
602 | + return $this->parseEntityIdParameter($snakSerialization, $exceptionId); |
|
603 | 603 | }, |
604 | 604 | $constraintParameters[$exceptionId] |
605 | 605 | ); |
@@ -610,39 +610,39 @@ discard block |
||
610 | 610 | * @throws ConstraintParameterException if the parameter is invalid |
611 | 611 | * @return string|null 'mandatory', 'suggestion' or null |
612 | 612 | */ |
613 | - public function parseConstraintStatusParameter( array $constraintParameters ): ?string { |
|
614 | - $this->checkError( $constraintParameters ); |
|
615 | - $constraintStatusId = $this->config->get( 'WBQualityConstraintsConstraintStatusId' ); |
|
616 | - if ( !array_key_exists( $constraintStatusId, $constraintParameters ) ) { |
|
613 | + public function parseConstraintStatusParameter(array $constraintParameters): ?string { |
|
614 | + $this->checkError($constraintParameters); |
|
615 | + $constraintStatusId = $this->config->get('WBQualityConstraintsConstraintStatusId'); |
|
616 | + if (!array_key_exists($constraintStatusId, $constraintParameters)) { |
|
617 | 617 | return null; |
618 | 618 | } |
619 | 619 | |
620 | - $mandatoryId = $this->config->get( 'WBQualityConstraintsMandatoryConstraintId' ); |
|
621 | - $supportedStatuses = [ new ItemId( $mandatoryId ) ]; |
|
622 | - if ( $this->config->get( 'WBQualityConstraintsEnableSuggestionConstraintStatus' ) ) { |
|
623 | - $suggestionId = $this->config->get( 'WBQualityConstraintsSuggestionConstraintId' ); |
|
624 | - $supportedStatuses[] = new ItemId( $suggestionId ); |
|
620 | + $mandatoryId = $this->config->get('WBQualityConstraintsMandatoryConstraintId'); |
|
621 | + $supportedStatuses = [new ItemId($mandatoryId)]; |
|
622 | + if ($this->config->get('WBQualityConstraintsEnableSuggestionConstraintStatus')) { |
|
623 | + $suggestionId = $this->config->get('WBQualityConstraintsSuggestionConstraintId'); |
|
624 | + $supportedStatuses[] = new ItemId($suggestionId); |
|
625 | 625 | } else { |
626 | 626 | $suggestionId = null; |
627 | 627 | } |
628 | 628 | |
629 | - $this->requireSingleParameter( $constraintParameters, $constraintStatusId ); |
|
630 | - $snak = $this->snakDeserializer->deserialize( $constraintParameters[$constraintStatusId][0] ); |
|
631 | - $this->requireValueParameter( $snak, $constraintStatusId ); |
|
629 | + $this->requireSingleParameter($constraintParameters, $constraintStatusId); |
|
630 | + $snak = $this->snakDeserializer->deserialize($constraintParameters[$constraintStatusId][0]); |
|
631 | + $this->requireValueParameter($snak, $constraintStatusId); |
|
632 | 632 | '@phan-var \Wikibase\DataModel\Snak\PropertyValueSnak $snak'; |
633 | 633 | $dataValue = $snak->getDataValue(); |
634 | 634 | '@phan-var EntityIdValue $dataValue'; |
635 | 635 | $entityId = $dataValue->getEntityId(); |
636 | 636 | $statusId = $entityId->getSerialization(); |
637 | 637 | |
638 | - if ( $statusId === $mandatoryId ) { |
|
638 | + if ($statusId === $mandatoryId) { |
|
639 | 639 | return 'mandatory'; |
640 | - } elseif ( $statusId === $suggestionId ) { |
|
640 | + } elseif ($statusId === $suggestionId) { |
|
641 | 641 | return 'suggestion'; |
642 | 642 | } else { |
643 | 643 | throw new ConstraintParameterException( |
644 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) ) |
|
645 | - ->withEntityId( new NumericPropertyId( $constraintStatusId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
644 | + (new ViolationMessage('wbqc-violation-message-parameter-oneof')) |
|
645 | + ->withEntityId(new NumericPropertyId($constraintStatusId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
646 | 646 | ->withEntityIdList( |
647 | 647 | $supportedStatuses, |
648 | 648 | Role::CONSTRAINT_PARAMETER_VALUE |
@@ -655,12 +655,12 @@ discard block |
||
655 | 655 | * Require that $dataValue is a {@link MonolingualTextValue}. |
656 | 656 | * @throws ConstraintParameterException |
657 | 657 | */ |
658 | - private function requireMonolingualTextParameter( DataValue $dataValue, string $parameterId ): void { |
|
659 | - if ( !( $dataValue instanceof MonolingualTextValue ) ) { |
|
658 | + private function requireMonolingualTextParameter(DataValue $dataValue, string $parameterId): void { |
|
659 | + if (!($dataValue instanceof MonolingualTextValue)) { |
|
660 | 660 | throw new ConstraintParameterException( |
661 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-monolingualtext' ) ) |
|
662 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
663 | - ->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
661 | + (new ViolationMessage('wbqc-violation-message-parameter-monolingualtext')) |
|
662 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
663 | + ->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE) |
|
664 | 664 | ); |
665 | 665 | } |
666 | 666 | } |
@@ -670,31 +670,31 @@ discard block |
||
670 | 670 | * |
671 | 671 | * @throws ConstraintParameterException if invalid snaks are found or a language has multiple texts |
672 | 672 | */ |
673 | - private function parseMultilingualTextParameter( array $snakSerializations, string $parameterId ): MultilingualTextValue { |
|
673 | + private function parseMultilingualTextParameter(array $snakSerializations, string $parameterId): MultilingualTextValue { |
|
674 | 674 | $result = []; |
675 | 675 | |
676 | - foreach ( $snakSerializations as $snakSerialization ) { |
|
677 | - $snak = $this->snakDeserializer->deserialize( $snakSerialization ); |
|
678 | - $this->requireValueParameter( $snak, $parameterId ); |
|
676 | + foreach ($snakSerializations as $snakSerialization) { |
|
677 | + $snak = $this->snakDeserializer->deserialize($snakSerialization); |
|
678 | + $this->requireValueParameter($snak, $parameterId); |
|
679 | 679 | |
680 | 680 | $value = $snak->getDataValue(); |
681 | - $this->requireMonolingualTextParameter( $value, $parameterId ); |
|
681 | + $this->requireMonolingualTextParameter($value, $parameterId); |
|
682 | 682 | /** @var MonolingualTextValue $value */ |
683 | 683 | '@phan-var MonolingualTextValue $value'; |
684 | 684 | |
685 | 685 | $code = $value->getLanguageCode(); |
686 | - if ( array_key_exists( $code, $result ) ) { |
|
686 | + if (array_key_exists($code, $result)) { |
|
687 | 687 | throw new ConstraintParameterException( |
688 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-single-per-language' ) ) |
|
689 | - ->withEntityId( new NumericPropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
690 | - ->withLanguage( $code ) |
|
688 | + (new ViolationMessage('wbqc-violation-message-parameter-single-per-language')) |
|
689 | + ->withEntityId(new NumericPropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
690 | + ->withLanguage($code) |
|
691 | 691 | ); |
692 | 692 | } |
693 | 693 | |
694 | 694 | $result[$code] = $value; |
695 | 695 | } |
696 | 696 | |
697 | - return new MultilingualTextValue( $result ); |
|
697 | + return new MultilingualTextValue($result); |
|
698 | 698 | } |
699 | 699 | |
700 | 700 | /** |
@@ -702,11 +702,11 @@ discard block |
||
702 | 702 | * @throws ConstraintParameterException if the parameter is invalid |
703 | 703 | * @return MultilingualTextValue |
704 | 704 | */ |
705 | - public function parseSyntaxClarificationParameter( array $constraintParameters ): MultilingualTextValue { |
|
706 | - $syntaxClarificationId = $this->config->get( 'WBQualityConstraintsSyntaxClarificationId' ); |
|
705 | + public function parseSyntaxClarificationParameter(array $constraintParameters): MultilingualTextValue { |
|
706 | + $syntaxClarificationId = $this->config->get('WBQualityConstraintsSyntaxClarificationId'); |
|
707 | 707 | |
708 | - if ( !array_key_exists( $syntaxClarificationId, $constraintParameters ) ) { |
|
709 | - return new MultilingualTextValue( [] ); |
|
708 | + if (!array_key_exists($syntaxClarificationId, $constraintParameters)) { |
|
709 | + return new MultilingualTextValue([]); |
|
710 | 710 | } |
711 | 711 | |
712 | 712 | $syntaxClarifications = $this->parseMultilingualTextParameter( |
@@ -722,11 +722,11 @@ discard block |
||
722 | 722 | * @throws ConstraintParameterException if the parameter is invalid |
723 | 723 | * @return MultilingualTextValue |
724 | 724 | */ |
725 | - public function parseConstraintClarificationParameter( array $constraintParameters ): MultilingualTextValue { |
|
726 | - $constraintClarificationId = $this->config->get( 'WBQualityConstraintsConstraintClarificationId' ); |
|
725 | + public function parseConstraintClarificationParameter(array $constraintParameters): MultilingualTextValue { |
|
726 | + $constraintClarificationId = $this->config->get('WBQualityConstraintsConstraintClarificationId'); |
|
727 | 727 | |
728 | - if ( !array_key_exists( $constraintClarificationId, $constraintParameters ) ) { |
|
729 | - return new MultilingualTextValue( [] ); |
|
728 | + if (!array_key_exists($constraintClarificationId, $constraintParameters)) { |
|
729 | + return new MultilingualTextValue([]); |
|
730 | 730 | } |
731 | 731 | |
732 | 732 | $constraintClarifications = $this->parseMultilingualTextParameter( |
@@ -759,14 +759,14 @@ discard block |
||
759 | 759 | array $validContextTypes, |
760 | 760 | array $validEntityTypes |
761 | 761 | ): array { |
762 | - $contextTypeParameterId = $this->config->get( 'WBQualityConstraintsConstraintScopeId' ); |
|
762 | + $contextTypeParameterId = $this->config->get('WBQualityConstraintsConstraintScopeId'); |
|
763 | 763 | $contextTypeItemIds = $this->parseItemIdsParameter( |
764 | 764 | $constraintParameters, |
765 | 765 | $constraintTypeItemId, |
766 | 766 | false, |
767 | 767 | $contextTypeParameterId |
768 | 768 | ); |
769 | - $entityTypeParameterId = $this->config->get( 'WBQualityConstraintsConstraintEntityTypesId' ); |
|
769 | + $entityTypeParameterId = $this->config->get('WBQualityConstraintsConstraintEntityTypesId'); |
|
770 | 770 | $entityTypeItemIds = $this->parseItemIdsParameter( |
771 | 771 | $constraintParameters, |
772 | 772 | $constraintTypeItemId, |
@@ -782,26 +782,26 @@ discard block |
||
782 | 782 | $contextTypes = null; |
783 | 783 | $entityTypes = null; |
784 | 784 | |
785 | - if ( $contextTypeParameterId === $entityTypeParameterId ) { |
|
785 | + if ($contextTypeParameterId === $entityTypeParameterId) { |
|
786 | 786 | $itemIds = $contextTypeItemIds; |
787 | 787 | $mapping = $contextTypeMapping + $entityTypeMapping; |
788 | - foreach ( $itemIds as $itemId ) { |
|
789 | - $mapped = $this->mapItemId( $itemId, $mapping, $contextTypeParameterId ); |
|
790 | - if ( in_array( $mapped, $contextTypeMapping, true ) ) { |
|
788 | + foreach ($itemIds as $itemId) { |
|
789 | + $mapped = $this->mapItemId($itemId, $mapping, $contextTypeParameterId); |
|
790 | + if (in_array($mapped, $contextTypeMapping, true)) { |
|
791 | 791 | $contextTypes[] = $mapped; |
792 | 792 | } else { |
793 | 793 | $entityTypes[] = $mapped; |
794 | 794 | } |
795 | 795 | } |
796 | 796 | } else { |
797 | - foreach ( $contextTypeItemIds as $contextTypeItemId ) { |
|
797 | + foreach ($contextTypeItemIds as $contextTypeItemId) { |
|
798 | 798 | $contextTypes[] = $this->mapItemId( |
799 | 799 | $contextTypeItemId, |
800 | 800 | $contextTypeMapping, |
801 | 801 | $contextTypeParameterId |
802 | 802 | ); |
803 | 803 | } |
804 | - foreach ( $entityTypeItemIds as $entityTypeItemId ) { |
|
804 | + foreach ($entityTypeItemIds as $entityTypeItemId) { |
|
805 | 805 | $entityTypes[] = $this->mapItemId( |
806 | 806 | $entityTypeItemId, |
807 | 807 | $entityTypeMapping, |
@@ -810,22 +810,22 @@ discard block |
||
810 | 810 | } |
811 | 811 | } |
812 | 812 | |
813 | - $this->checkValidScope( $constraintTypeItemId, $contextTypes, $validContextTypes ); |
|
814 | - $this->checkValidScope( $constraintTypeItemId, $entityTypes, $validEntityTypes ); |
|
813 | + $this->checkValidScope($constraintTypeItemId, $contextTypes, $validContextTypes); |
|
814 | + $this->checkValidScope($constraintTypeItemId, $entityTypes, $validEntityTypes); |
|
815 | 815 | |
816 | - return [ $contextTypes, $entityTypes ]; |
|
816 | + return [$contextTypes, $entityTypes]; |
|
817 | 817 | } |
818 | 818 | |
819 | 819 | /** @throws ConstraintParameterException */ |
820 | - private function checkValidScope( string $constraintTypeItemId, ?array $types, array $validTypes ): void { |
|
821 | - $invalidTypes = array_diff( $types ?: [], $validTypes ); |
|
822 | - if ( $invalidTypes !== [] ) { |
|
823 | - $invalidType = array_pop( $invalidTypes ); |
|
820 | + private function checkValidScope(string $constraintTypeItemId, ?array $types, array $validTypes): void { |
|
821 | + $invalidTypes = array_diff($types ?: [], $validTypes); |
|
822 | + if ($invalidTypes !== []) { |
|
823 | + $invalidType = array_pop($invalidTypes); |
|
824 | 824 | throw new ConstraintParameterException( |
825 | - ( new ViolationMessage( 'wbqc-violation-message-invalid-scope' ) ) |
|
826 | - ->withConstraintScope( $invalidType, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
827 | - ->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM ) |
|
828 | - ->withConstraintScopeList( $validTypes, Role::CONSTRAINT_PARAMETER_VALUE ) |
|
825 | + (new ViolationMessage('wbqc-violation-message-invalid-scope')) |
|
826 | + ->withConstraintScope($invalidType, Role::CONSTRAINT_PARAMETER_VALUE) |
|
827 | + ->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM) |
|
828 | + ->withConstraintScopeList($validTypes, Role::CONSTRAINT_PARAMETER_VALUE) |
|
829 | 829 | ); |
830 | 830 | } |
831 | 831 | } |
@@ -833,8 +833,8 @@ discard block |
||
833 | 833 | /** |
834 | 834 | * Turn an item ID into a full unit string (using the concept URI). |
835 | 835 | */ |
836 | - private function parseUnitParameter( ItemId $unitId ): string { |
|
837 | - return $this->unitItemConceptBaseUri . $unitId->getSerialization(); |
|
836 | + private function parseUnitParameter(ItemId $unitId): string { |
|
837 | + return $this->unitItemConceptBaseUri.$unitId->getSerialization(); |
|
838 | 838 | } |
839 | 839 | |
840 | 840 | /** |
@@ -842,23 +842,23 @@ discard block |
||
842 | 842 | * |
843 | 843 | * @throws ConstraintParameterException |
844 | 844 | */ |
845 | - private function parseUnitItem( ItemIdSnakValue $item ): UnitsParameter { |
|
846 | - switch ( true ) { |
|
845 | + private function parseUnitItem(ItemIdSnakValue $item): UnitsParameter { |
|
846 | + switch (true) { |
|
847 | 847 | case $item->isValue(): |
848 | - $unit = $this->parseUnitParameter( $item->getItemId() ); |
|
848 | + $unit = $this->parseUnitParameter($item->getItemId()); |
|
849 | 849 | return new UnitsParameter( |
850 | - [ $item->getItemId() ], |
|
851 | - [ UnboundedQuantityValue::newFromNumber( 1, $unit ) ], |
|
850 | + [$item->getItemId()], |
|
851 | + [UnboundedQuantityValue::newFromNumber(1, $unit)], |
|
852 | 852 | false |
853 | 853 | ); |
854 | 854 | case $item->isSomeValue(): |
855 | - $qualifierId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
855 | + $qualifierId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
856 | 856 | throw new ConstraintParameterException( |
857 | - ( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) ) |
|
858 | - ->withEntityId( new NumericPropertyId( $qualifierId ), Role::CONSTRAINT_PARAMETER_PROPERTY ) |
|
857 | + (new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue')) |
|
858 | + ->withEntityId(new NumericPropertyId($qualifierId), Role::CONSTRAINT_PARAMETER_PROPERTY) |
|
859 | 859 | ); |
860 | 860 | case $item->isNoValue(): |
861 | - return new UnitsParameter( [], [], true ); |
|
861 | + return new UnitsParameter([], [], true); |
|
862 | 862 | } |
863 | 863 | } |
864 | 864 | |
@@ -868,36 +868,36 @@ discard block |
||
868 | 868 | * @throws ConstraintParameterException if the parameter is invalid or missing |
869 | 869 | * @return UnitsParameter |
870 | 870 | */ |
871 | - public function parseUnitsParameter( array $constraintParameters, string $constraintTypeItemId ): UnitsParameter { |
|
872 | - $items = $this->parseItemsParameter( $constraintParameters, $constraintTypeItemId, true ); |
|
871 | + public function parseUnitsParameter(array $constraintParameters, string $constraintTypeItemId): UnitsParameter { |
|
872 | + $items = $this->parseItemsParameter($constraintParameters, $constraintTypeItemId, true); |
|
873 | 873 | $unitItems = []; |
874 | 874 | $unitQuantities = []; |
875 | 875 | $unitlessAllowed = false; |
876 | 876 | |
877 | - foreach ( $items as $item ) { |
|
878 | - $unit = $this->parseUnitItem( $item ); |
|
879 | - $unitItems = array_merge( $unitItems, $unit->getUnitItemIds() ); |
|
880 | - $unitQuantities = array_merge( $unitQuantities, $unit->getUnitQuantities() ); |
|
877 | + foreach ($items as $item) { |
|
878 | + $unit = $this->parseUnitItem($item); |
|
879 | + $unitItems = array_merge($unitItems, $unit->getUnitItemIds()); |
|
880 | + $unitQuantities = array_merge($unitQuantities, $unit->getUnitQuantities()); |
|
881 | 881 | $unitlessAllowed = $unitlessAllowed || $unit->getUnitlessAllowed(); |
882 | 882 | } |
883 | 883 | |
884 | - if ( $unitQuantities === [] && !$unitlessAllowed ) { |
|
884 | + if ($unitQuantities === [] && !$unitlessAllowed) { |
|
885 | 885 | throw new LogicException( |
886 | 886 | 'The "units" parameter is required, and yet we seem to be missing any allowed unit' |
887 | 887 | ); |
888 | 888 | } |
889 | 889 | |
890 | - return new UnitsParameter( $unitItems, $unitQuantities, $unitlessAllowed ); |
|
890 | + return new UnitsParameter($unitItems, $unitQuantities, $unitlessAllowed); |
|
891 | 891 | } |
892 | 892 | |
893 | 893 | private function getEntityTypeMapping(): array { |
894 | 894 | return [ |
895 | - $this->config->get( 'WBQualityConstraintsWikibaseItemId' ) => 'item', |
|
896 | - $this->config->get( 'WBQualityConstraintsWikibasePropertyId' ) => 'property', |
|
897 | - $this->config->get( 'WBQualityConstraintsWikibaseLexemeId' ) => 'lexeme', |
|
898 | - $this->config->get( 'WBQualityConstraintsWikibaseFormId' ) => 'form', |
|
899 | - $this->config->get( 'WBQualityConstraintsWikibaseSenseId' ) => 'sense', |
|
900 | - $this->config->get( 'WBQualityConstraintsWikibaseMediaInfoId' ) => 'mediainfo', |
|
895 | + $this->config->get('WBQualityConstraintsWikibaseItemId') => 'item', |
|
896 | + $this->config->get('WBQualityConstraintsWikibasePropertyId') => 'property', |
|
897 | + $this->config->get('WBQualityConstraintsWikibaseLexemeId') => 'lexeme', |
|
898 | + $this->config->get('WBQualityConstraintsWikibaseFormId') => 'form', |
|
899 | + $this->config->get('WBQualityConstraintsWikibaseSenseId') => 'sense', |
|
900 | + $this->config->get('WBQualityConstraintsWikibaseMediaInfoId') => 'mediainfo', |
|
901 | 901 | ]; |
902 | 902 | } |
903 | 903 | |
@@ -907,10 +907,10 @@ discard block |
||
907 | 907 | * @throws ConstraintParameterException if the parameter is invalid or missing |
908 | 908 | * @return EntityTypesParameter |
909 | 909 | */ |
910 | - public function parseEntityTypesParameter( array $constraintParameters, string $constraintTypeItemId ): EntityTypesParameter { |
|
910 | + public function parseEntityTypesParameter(array $constraintParameters, string $constraintTypeItemId): EntityTypesParameter { |
|
911 | 911 | $entityTypes = []; |
912 | 912 | $entityTypeItemIds = []; |
913 | - $parameterId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' ); |
|
913 | + $parameterId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId'); |
|
914 | 914 | $itemIds = $this->parseItemIdsParameter( |
915 | 915 | $constraintParameters, |
916 | 916 | $constraintTypeItemId, |
@@ -919,22 +919,22 @@ discard block |
||
919 | 919 | ); |
920 | 920 | |
921 | 921 | $mapping = $this->getEntityTypeMapping(); |
922 | - foreach ( $itemIds as $itemId ) { |
|
923 | - $entityType = $this->mapItemId( $itemId, $mapping, $parameterId ); |
|
922 | + foreach ($itemIds as $itemId) { |
|
923 | + $entityType = $this->mapItemId($itemId, $mapping, $parameterId); |
|
924 | 924 | $entityTypes[] = $entityType; |
925 | 925 | $entityTypeItemIds[] = $itemId; |
926 | 926 | } |
927 | 927 | |
928 | - if ( $entityTypes === [] ) { |
|
928 | + if ($entityTypes === []) { |
|
929 | 929 | // @codeCoverageIgnoreStart |
930 | 930 | throw new LogicException( |
931 | - 'The "entity types" parameter is required, ' . |
|
931 | + 'The "entity types" parameter is required, '. |
|
932 | 932 | 'and yet we seem to be missing any allowed entity type' |
933 | 933 | ); |
934 | 934 | // @codeCoverageIgnoreEnd |
935 | 935 | } |
936 | 936 | |
937 | - return new EntityTypesParameter( $entityTypes, $entityTypeItemIds ); |
|
937 | + return new EntityTypesParameter($entityTypes, $entityTypeItemIds); |
|
938 | 938 | } |
939 | 939 | |
940 | 940 | /** |
@@ -942,18 +942,18 @@ discard block |
||
942 | 942 | * @throws ConstraintParameterException if the parameter is invalid |
943 | 943 | * @return PropertyId[] |
944 | 944 | */ |
945 | - public function parseSeparatorsParameter( array $constraintParameters ): array { |
|
946 | - $separatorId = $this->config->get( 'WBQualityConstraintsSeparatorId' ); |
|
945 | + public function parseSeparatorsParameter(array $constraintParameters): array { |
|
946 | + $separatorId = $this->config->get('WBQualityConstraintsSeparatorId'); |
|
947 | 947 | |
948 | - if ( !array_key_exists( $separatorId, $constraintParameters ) ) { |
|
948 | + if (!array_key_exists($separatorId, $constraintParameters)) { |
|
949 | 949 | return []; |
950 | 950 | } |
951 | 951 | |
952 | 952 | $parameters = $constraintParameters[$separatorId]; |
953 | 953 | $separators = []; |
954 | 954 | |
955 | - foreach ( $parameters as $parameter ) { |
|
956 | - $separators[] = $this->parsePropertyIdParameter( $parameter, $separatorId ); |
|
955 | + foreach ($parameters as $parameter) { |
|
956 | + $separators[] = $this->parsePropertyIdParameter($parameter, $separatorId); |
|
957 | 957 | } |
958 | 958 | |
959 | 959 | return $separators; |
@@ -961,17 +961,17 @@ discard block |
||
961 | 961 | |
962 | 962 | private function getConstraintScopeContextTypeMapping(): array { |
963 | 963 | return [ |
964 | - $this->config->get( 'WBQualityConstraintsConstraintCheckedOnMainValueId' ) => Context::TYPE_STATEMENT, |
|
965 | - $this->config->get( 'WBQualityConstraintsConstraintCheckedOnQualifiersId' ) => Context::TYPE_QUALIFIER, |
|
966 | - $this->config->get( 'WBQualityConstraintsConstraintCheckedOnReferencesId' ) => Context::TYPE_REFERENCE, |
|
964 | + $this->config->get('WBQualityConstraintsConstraintCheckedOnMainValueId') => Context::TYPE_STATEMENT, |
|
965 | + $this->config->get('WBQualityConstraintsConstraintCheckedOnQualifiersId') => Context::TYPE_QUALIFIER, |
|
966 | + $this->config->get('WBQualityConstraintsConstraintCheckedOnReferencesId') => Context::TYPE_REFERENCE, |
|
967 | 967 | ]; |
968 | 968 | } |
969 | 969 | |
970 | 970 | private function getPropertyScopeContextTypeMapping(): array { |
971 | 971 | return [ |
972 | - $this->config->get( 'WBQualityConstraintsAsMainValueId' ) => Context::TYPE_STATEMENT, |
|
973 | - $this->config->get( 'WBQualityConstraintsAsQualifiersId' ) => Context::TYPE_QUALIFIER, |
|
974 | - $this->config->get( 'WBQualityConstraintsAsReferencesId' ) => Context::TYPE_REFERENCE, |
|
972 | + $this->config->get('WBQualityConstraintsAsMainValueId') => Context::TYPE_STATEMENT, |
|
973 | + $this->config->get('WBQualityConstraintsAsQualifiersId') => Context::TYPE_QUALIFIER, |
|
974 | + $this->config->get('WBQualityConstraintsAsReferencesId') => Context::TYPE_REFERENCE, |
|
975 | 975 | ]; |
976 | 976 | } |
977 | 977 | |
@@ -981,9 +981,9 @@ discard block |
||
981 | 981 | * @throws ConstraintParameterException if the parameter is invalid or missing |
982 | 982 | * @return string[] list of Context::TYPE_* constants |
983 | 983 | */ |
984 | - public function parsePropertyScopeParameter( array $constraintParameters, string $constraintTypeItemId ): array { |
|
984 | + public function parsePropertyScopeParameter(array $constraintParameters, string $constraintTypeItemId): array { |
|
985 | 985 | $contextTypes = []; |
986 | - $parameterId = $this->config->get( 'WBQualityConstraintsPropertyScopeId' ); |
|
986 | + $parameterId = $this->config->get('WBQualityConstraintsPropertyScopeId'); |
|
987 | 987 | $itemIds = $this->parseItemIdsParameter( |
988 | 988 | $constraintParameters, |
989 | 989 | $constraintTypeItemId, |
@@ -992,14 +992,14 @@ discard block |
||
992 | 992 | ); |
993 | 993 | |
994 | 994 | $mapping = $this->getPropertyScopeContextTypeMapping(); |
995 | - foreach ( $itemIds as $itemId ) { |
|
996 | - $contextTypes[] = $this->mapItemId( $itemId, $mapping, $parameterId ); |
|
995 | + foreach ($itemIds as $itemId) { |
|
996 | + $contextTypes[] = $this->mapItemId($itemId, $mapping, $parameterId); |
|
997 | 997 | } |
998 | 998 | |
999 | - if ( $contextTypes === [] ) { |
|
999 | + if ($contextTypes === []) { |
|
1000 | 1000 | // @codeCoverageIgnoreStart |
1001 | 1001 | throw new LogicException( |
1002 | - 'The "property scope" parameter is required, ' . |
|
1002 | + 'The "property scope" parameter is required, '. |
|
1003 | 1003 | 'and yet we seem to be missing any allowed scope' |
1004 | 1004 | ); |
1005 | 1005 | // @codeCoverageIgnoreEnd |