Completed
Push — master ( 0d2cf6...bbacaa )
by
unknown
01:59
created
src/ConstraintCheck/DelegatingConstraintChecker.php 1 patch
Spacing   +137 added lines, -137 removed lines patch added patch discarded remove patch
@@ -144,21 +144,21 @@  discard block
 block discarded – undo
144 144
 		callable $defaultResultsPerEntity = null
145 145
 	) {
146 146
 		$checkResults = [];
147
-		$entity = $this->entityLookup->getEntity( $entityId );
147
+		$entity = $this->entityLookup->getEntity($entityId);
148 148
 
149
-		if ( $entity instanceof StatementListProvider ) {
149
+		if ($entity instanceof StatementListProvider) {
150 150
 			$checkResults = $this->checkEveryStatement(
151
-				$this->entityLookup->getEntity( $entityId ),
151
+				$this->entityLookup->getEntity($entityId),
152 152
 				$constraintIds,
153 153
 				$defaultResultsPerContext
154 154
 			);
155 155
 		}
156 156
 
157
-		if ( $defaultResultsPerEntity !== null ) {
158
-			$checkResults = array_merge( $defaultResultsPerEntity( $entityId ), $checkResults );
157
+		if ($defaultResultsPerEntity !== null) {
158
+			$checkResults = array_merge($defaultResultsPerEntity($entityId), $checkResults);
159 159
 		}
160 160
 
161
-		return $this->sortResult( $checkResults );
161
+		return $this->sortResult($checkResults);
162 162
 	}
163 163
 
164 164
 	/**
@@ -180,19 +180,19 @@  discard block
 block discarded – undo
180 180
 		callable $defaultResults = null
181 181
 	) {
182 182
 
183
-		$parsedGuid = $this->statementGuidParser->parse( $guid );
183
+		$parsedGuid = $this->statementGuidParser->parse($guid);
184 184
 		$entityId = $parsedGuid->getEntityId();
185
-		$entity = $this->entityLookup->getEntity( $entityId );
186
-		if ( $entity instanceof StatementListProvider ) {
187
-			$statement = $entity->getStatements()->getFirstStatementWithGuid( $guid );
188
-			if ( $statement ) {
185
+		$entity = $this->entityLookup->getEntity($entityId);
186
+		if ($entity instanceof StatementListProvider) {
187
+			$statement = $entity->getStatements()->getFirstStatementWithGuid($guid);
188
+			if ($statement) {
189 189
 				$result = $this->checkStatement(
190 190
 					$entity,
191 191
 					$statement,
192 192
 					$constraintIds,
193 193
 					$defaultResults
194 194
 				);
195
-				$output = $this->sortResult( $result );
195
+				$output = $this->sortResult($result);
196 196
 				return $output;
197 197
 			}
198 198
 		}
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
 		return [];
201 201
 	}
202 202
 
203
-	private function getAllowedContextTypes( Constraint $constraint ) {
204
-		if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
203
+	private function getAllowedContextTypes(Constraint $constraint) {
204
+		if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
205 205
 			return [
206 206
 				Context::TYPE_STATEMENT,
207 207
 				Context::TYPE_QUALIFIER,
@@ -209,12 +209,12 @@  discard block
 block discarded – undo
209 209
 			];
210 210
 		}
211 211
 
212
-		return array_keys( array_filter(
212
+		return array_keys(array_filter(
213 213
 			$this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedContextTypes(),
214
-			function ( $resultStatus ) {
214
+			function($resultStatus) {
215 215
 				return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE;
216 216
 			}
217
-		) );
217
+		));
218 218
 	}
219 219
 
220 220
 	/**
@@ -225,32 +225,32 @@  discard block
 block discarded – undo
225 225
 	 *
226 226
 	 * @return ConstraintParameterException[]
227 227
 	 */
228
-	private function checkCommonConstraintParameters( Constraint $constraint ) {
228
+	private function checkCommonConstraintParameters(Constraint $constraint) {
229 229
 		$constraintParameters = $constraint->getConstraintParameters();
230 230
 		try {
231
-			$this->constraintParameterParser->checkError( $constraintParameters );
232
-		} catch ( ConstraintParameterException $e ) {
233
-			return [ $e ];
231
+			$this->constraintParameterParser->checkError($constraintParameters);
232
+		} catch (ConstraintParameterException $e) {
233
+			return [$e];
234 234
 		}
235 235
 
236 236
 		$problems = [];
237 237
 		try {
238
-			$this->constraintParameterParser->parseExceptionParameter( $constraintParameters );
239
-		} catch ( ConstraintParameterException $e ) {
238
+			$this->constraintParameterParser->parseExceptionParameter($constraintParameters);
239
+		} catch (ConstraintParameterException $e) {
240 240
 			$problems[] = $e;
241 241
 		}
242 242
 		try {
243
-			$this->constraintParameterParser->parseConstraintStatusParameter( $constraintParameters );
244
-		} catch ( ConstraintParameterException $e ) {
243
+			$this->constraintParameterParser->parseConstraintStatusParameter($constraintParameters);
244
+		} catch (ConstraintParameterException $e) {
245 245
 			$problems[] = $e;
246 246
 		}
247 247
 		try {
248 248
 			$this->constraintParameterParser->parseConstraintScopeParameter(
249 249
 				$constraintParameters,
250 250
 				$constraint->getConstraintTypeItemId(),
251
-				$this->getAllowedContextTypes( $constraint )
251
+				$this->getAllowedContextTypes($constraint)
252 252
 			);
253
-		} catch ( ConstraintParameterException $e ) {
253
+		} catch (ConstraintParameterException $e) {
254 254
 			$problems[] = $e;
255 255
 		}
256 256
 		return $problems;
@@ -263,16 +263,16 @@  discard block
 block discarded – undo
263 263
 	 * @return ConstraintParameterException[][] first level indexed by constraint ID,
264 264
 	 * second level like checkConstraintParametersOnConstraintId (but without possibility of null)
265 265
 	 */
266
-	public function checkConstraintParametersOnPropertyId( PropertyId $propertyId ) {
267
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
266
+	public function checkConstraintParametersOnPropertyId(PropertyId $propertyId) {
267
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
268 268
 		$result = [];
269 269
 
270
-		foreach ( $constraints as $constraint ) {
271
-			$problems = $this->checkCommonConstraintParameters( $constraint );
270
+		foreach ($constraints as $constraint) {
271
+			$problems = $this->checkCommonConstraintParameters($constraint);
272 272
 
273
-			if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
273
+			if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
274 274
 				$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
275
-				$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
275
+				$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
276 276
 			}
277 277
 
278 278
 			$result[$constraint->getConstraintId()] = $problems;
@@ -289,17 +289,17 @@  discard block
 block discarded – undo
289 289
 	 * @return ConstraintParameterException[]|null list of constraint parameter exceptions
290 290
 	 * (empty means all parameters okay), or null if constraint is not found
291 291
 	 */
292
-	public function checkConstraintParametersOnConstraintId( $constraintId ) {
293
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
294
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
292
+	public function checkConstraintParametersOnConstraintId($constraintId) {
293
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
294
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
295 295
 
296
-		foreach ( $constraints as $constraint ) {
297
-			if ( $constraint->getConstraintId() === $constraintId ) {
298
-				$problems = $this->checkCommonConstraintParameters( $constraint );
296
+		foreach ($constraints as $constraint) {
297
+			if ($constraint->getConstraintId() === $constraintId) {
298
+				$problems = $this->checkCommonConstraintParameters($constraint);
299 299
 
300
-				if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
300
+				if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
301 301
 					$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
302
-					$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
302
+					$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
303 303
 				}
304 304
 
305 305
 				return $problems;
@@ -324,14 +324,14 @@  discard block
 block discarded – undo
324 324
 		$result = [];
325 325
 
326 326
 		/** @var Statement $statement */
327
-		foreach ( $entity->getStatements() as $statement ) {
328
-			$result = array_merge( $result,
327
+		foreach ($entity->getStatements() as $statement) {
328
+			$result = array_merge($result,
329 329
 				$this->checkStatement(
330 330
 					$entity,
331 331
 					$statement,
332 332
 					$constraintIds,
333 333
 					$defaultResultsPerContext
334
-				) );
334
+				));
335 335
 		}
336 336
 
337 337
 		return $result;
@@ -353,32 +353,32 @@  discard block
 block discarded – undo
353 353
 	) {
354 354
 		$result = [];
355 355
 
356
-		$result = array_merge( $result,
356
+		$result = array_merge($result,
357 357
 			$this->checkConstraintsForMainSnak(
358 358
 				$entity,
359 359
 				$statement,
360 360
 				$constraintIds,
361 361
 				$defaultResultsPerContext
362
-			) );
362
+			));
363 363
 
364
-		if ( $this->checkQualifiers ) {
365
-			$result = array_merge( $result,
364
+		if ($this->checkQualifiers) {
365
+			$result = array_merge($result,
366 366
 				$this->checkConstraintsForQualifiers(
367 367
 					$entity,
368 368
 					$statement,
369 369
 					$constraintIds,
370 370
 					$defaultResultsPerContext
371
-				) );
371
+				));
372 372
 		}
373 373
 
374
-		if ( $this->checkReferences ) {
375
-			$result = array_merge( $result,
374
+		if ($this->checkReferences) {
375
+			$result = array_merge($result,
376 376
 				$this->checkConstraintsForReferences(
377 377
 					$entity,
378 378
 					$statement,
379 379
 					$constraintIds,
380 380
 					$defaultResultsPerContext
381
-				) );
381
+				));
382 382
 		}
383 383
 
384 384
 		return $result;
@@ -393,12 +393,12 @@  discard block
 block discarded – undo
393 393
 	 * @param string[]|null $constraintIds
394 394
 	 * @return Constraint[]
395 395
 	 */
396
-	private function getConstraintsToUse( PropertyId $propertyId, array $constraintIds = null ) {
397
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
398
-		if ( $constraintIds !== null ) {
396
+	private function getConstraintsToUse(PropertyId $propertyId, array $constraintIds = null) {
397
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
398
+		if ($constraintIds !== null) {
399 399
 			$constraintsToUse = [];
400
-			foreach ( $constraints as $constraint ) {
401
-				if ( in_array( $constraint->getConstraintId(), $constraintIds ) ) {
400
+			foreach ($constraints as $constraint) {
401
+				if (in_array($constraint->getConstraintId(), $constraintIds)) {
402 402
 					$constraintsToUse[] = $constraint;
403 403
 				}
404 404
 			}
@@ -422,29 +422,29 @@  discard block
 block discarded – undo
422 422
 		array $constraintIds = null,
423 423
 		callable $defaultResults = null
424 424
 	) {
425
-		$context = new MainSnakContext( $entity, $statement );
425
+		$context = new MainSnakContext($entity, $statement);
426 426
 		$constraints = $this->getConstraintsToUse(
427 427
 			$statement->getPropertyId(),
428 428
 			$constraintIds
429 429
 		);
430
-		$result = $defaultResults !== null ? $defaultResults( $context ) : [];
430
+		$result = $defaultResults !== null ? $defaultResults($context) : [];
431 431
 
432
-		foreach ( $constraints as $constraint ) {
432
+		foreach ($constraints as $constraint) {
433 433
 			$parameters = $constraint->getConstraintParameters();
434 434
 			try {
435
-				$exceptions = $this->constraintParameterParser->parseExceptionParameter( $parameters );
436
-			} catch ( ConstraintParameterException $e ) {
437
-				$result[] = new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
435
+				$exceptions = $this->constraintParameterParser->parseExceptionParameter($parameters);
436
+			} catch (ConstraintParameterException $e) {
437
+				$result[] = new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
438 438
 				continue;
439 439
 			}
440 440
 
441
-			if ( in_array( $entity->getId(), $exceptions ) ) {
442
-				$message = new ViolationMessage( 'wbqc-violation-message-exception' );
443
-				$result[] = new CheckResult( $context, $constraint, [], CheckResult::STATUS_EXCEPTION, $message );
441
+			if (in_array($entity->getId(), $exceptions)) {
442
+				$message = new ViolationMessage('wbqc-violation-message-exception');
443
+				$result[] = new CheckResult($context, $constraint, [], CheckResult::STATUS_EXCEPTION, $message);
444 444
 				continue;
445 445
 			}
446 446
 
447
-			$result[] = $this->getCheckResultFor( $context, $constraint );
447
+			$result[] = $this->getCheckResultFor($context, $constraint);
448 448
 		}
449 449
 
450 450
 		return $result;
@@ -466,24 +466,24 @@  discard block
 block discarded – undo
466 466
 	) {
467 467
 		$result = [];
468 468
 
469
-		if ( in_array(
469
+		if (in_array(
470 470
 			$statement->getPropertyId()->getSerialization(),
471 471
 			$this->propertiesWithViolatingQualifiers
472
-		) ) {
472
+		)) {
473 473
 			return $result;
474 474
 		}
475 475
 
476
-		foreach ( $statement->getQualifiers() as $qualifier ) {
477
-			$qualifierContext = new QualifierContext( $entity, $statement, $qualifier );
478
-			if ( $defaultResultsPerContext !== null ) {
479
-				$result = array_merge( $result, $defaultResultsPerContext( $qualifierContext ) );
476
+		foreach ($statement->getQualifiers() as $qualifier) {
477
+			$qualifierContext = new QualifierContext($entity, $statement, $qualifier);
478
+			if ($defaultResultsPerContext !== null) {
479
+				$result = array_merge($result, $defaultResultsPerContext($qualifierContext));
480 480
 			}
481 481
 			$qualifierConstraints = $this->getConstraintsToUse(
482 482
 				$qualifierContext->getSnak()->getPropertyId(),
483 483
 				$constraintIds
484 484
 			);
485
-			foreach ( $qualifierConstraints as $qualifierConstraint ) {
486
-				$result[] = $this->getCheckResultFor( $qualifierContext, $qualifierConstraint );
485
+			foreach ($qualifierConstraints as $qualifierConstraint) {
486
+				$result[] = $this->getCheckResultFor($qualifierContext, $qualifierConstraint);
487 487
 			}
488 488
 		}
489 489
 
@@ -507,19 +507,19 @@  discard block
 block discarded – undo
507 507
 		$result = [];
508 508
 
509 509
 		/** @var Reference $reference */
510
-		foreach ( $statement->getReferences() as $reference ) {
511
-			foreach ( $reference->getSnaks() as $snak ) {
510
+		foreach ($statement->getReferences() as $reference) {
511
+			foreach ($reference->getSnaks() as $snak) {
512 512
 				$referenceContext = new ReferenceContext(
513 513
 					$entity, $statement, $reference, $snak
514 514
 				);
515
-				if ( $defaultResultsPerContext !== null ) {
516
-					$result = array_merge( $result, $defaultResultsPerContext( $referenceContext ) );
515
+				if ($defaultResultsPerContext !== null) {
516
+					$result = array_merge($result, $defaultResultsPerContext($referenceContext));
517 517
 				}
518 518
 				$referenceConstraints = $this->getConstraintsToUse(
519 519
 					$referenceContext->getSnak()->getPropertyId(),
520 520
 					$constraintIds
521 521
 				);
522
-				foreach ( $referenceConstraints as $referenceConstraint ) {
522
+				foreach ($referenceConstraints as $referenceConstraint) {
523 523
 					$result[] = $this->getCheckResultFor(
524 524
 						$referenceContext,
525 525
 						$referenceConstraint
@@ -538,65 +538,65 @@  discard block
 block discarded – undo
538 538
 	 * @throws InvalidArgumentException
539 539
 	 * @return CheckResult
540 540
 	 */
541
-	private function getCheckResultFor( Context $context, Constraint $constraint ) {
542
-		if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
541
+	private function getCheckResultFor(Context $context, Constraint $constraint) {
542
+		if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
543 543
 			$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
544
-			$result = $this->handleScope( $checker, $context, $constraint );
544
+			$result = $this->handleScope($checker, $context, $constraint);
545 545
 
546
-			if ( $result !== null ) {
547
-				$this->addMetadata( $context, $result );
546
+			if ($result !== null) {
547
+				$this->addMetadata($context, $result);
548 548
 				return $result;
549 549
 			}
550 550
 
551
-			$startTime = microtime( true );
551
+			$startTime = microtime(true);
552 552
 			try {
553
-				$result = $checker->checkConstraint( $context, $constraint );
554
-			} catch ( ConstraintParameterException $e ) {
555
-				$result = new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
556
-			} catch ( SparqlHelperException $e ) {
557
-				$message = new ViolationMessage( 'wbqc-violation-message-sparql-error' );
558
-				$result = new CheckResult( $context, $constraint, [], CheckResult::STATUS_TODO, $message );
553
+				$result = $checker->checkConstraint($context, $constraint);
554
+			} catch (ConstraintParameterException $e) {
555
+				$result = new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
556
+			} catch (SparqlHelperException $e) {
557
+				$message = new ViolationMessage('wbqc-violation-message-sparql-error');
558
+				$result = new CheckResult($context, $constraint, [], CheckResult::STATUS_TODO, $message);
559 559
 			}
560
-			$endTime = microtime( true );
560
+			$endTime = microtime(true);
561 561
 
562
-			$this->addMetadata( $context, $result );
562
+			$this->addMetadata($context, $result);
563 563
 
564 564
 			try {
565 565
 				$constraintStatus = $this->constraintParameterParser
566
-					->parseConstraintStatusParameter( $constraint->getConstraintParameters() );
567
-			} catch ( ConstraintParameterException $e ) {
568
-				$result = new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
566
+					->parseConstraintStatusParameter($constraint->getConstraintParameters());
567
+			} catch (ConstraintParameterException $e) {
568
+				$result = new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
569 569
 				$constraintStatus = null;
570 570
 			}
571
-			if ( $constraintStatus === null ) {
571
+			if ($constraintStatus === null) {
572 572
 				// downgrade violation to warning
573
-				if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) {
574
-					$result->setStatus( CheckResult::STATUS_WARNING );
573
+				if ($result->getStatus() === CheckResult::STATUS_VIOLATION) {
574
+					$result->setStatus(CheckResult::STATUS_WARNING);
575 575
 				}
576 576
 			} else {
577
-				if ( $constraintStatus !== 'mandatory' ) {
577
+				if ($constraintStatus !== 'mandatory') {
578 578
 					// @codeCoverageIgnoreStart
579 579
 					throw new LogicException(
580
-						"Unknown constraint status '$constraintStatus', " .
580
+						"Unknown constraint status '$constraintStatus', ".
581 581
 						"only known status is 'mandatory'"
582 582
 					);
583 583
 					// @codeCoverageIgnoreEnd
584 584
 				}
585
-				$result->addParameter( 'constraint_status', $constraintStatus );
585
+				$result->addParameter('constraint_status', $constraintStatus);
586 586
 			}
587 587
 
588 588
 			$this->loggingHelper->logConstraintCheck(
589 589
 				$context,
590 590
 				$constraint,
591 591
 				$result,
592
-				get_class( $checker ),
592
+				get_class($checker),
593 593
 				$endTime - $startTime,
594 594
 				__METHOD__
595 595
 			);
596 596
 
597 597
 			return $result;
598 598
 		} else {
599
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_TODO, null );
599
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_TODO, null);
600 600
 		}
601 601
 	}
602 602
 
@@ -610,29 +610,29 @@  discard block
 block discarded – undo
610 610
 				$constraint->getConstraintParameters(),
611 611
 				$constraint->getConstraintTypeItemId()
612 612
 			);
613
-		} catch ( ConstraintParameterException $e ) {
614
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
613
+		} catch (ConstraintParameterException $e) {
614
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
615 615
 		}
616
-		if ( $checkedContextTypes === null ) {
616
+		if ($checkedContextTypes === null) {
617 617
 			$checkedContextTypes = $checker->getDefaultContextTypes();
618 618
 		}
619
-		if ( !in_array( $context->getType(), $checkedContextTypes ) ) {
620
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE, null );
619
+		if (!in_array($context->getType(), $checkedContextTypes)) {
620
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE, null);
621 621
 		}
622
-		if ( $checker->getSupportedContextTypes()[$context->getType()] === CheckResult::STATUS_TODO ) {
623
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_TODO, null );
622
+		if ($checker->getSupportedContextTypes()[$context->getType()] === CheckResult::STATUS_TODO) {
623
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_TODO, null);
624 624
 		}
625 625
 		return null;
626 626
 	}
627 627
 
628
-	private function addMetadata( Context $context, CheckResult $result ) {
629
-		$result->withMetadata( Metadata::merge( [
628
+	private function addMetadata(Context $context, CheckResult $result) {
629
+		$result->withMetadata(Metadata::merge([
630 630
 			$result->getMetadata(),
631
-			Metadata::ofDependencyMetadata( DependencyMetadata::merge( [
632
-				DependencyMetadata::ofEntityId( $context->getEntity()->getId() ),
633
-				DependencyMetadata::ofEntityId( $result->getConstraint()->getPropertyId() ),
634
-			] ) ),
635
-		] ) );
631
+			Metadata::ofDependencyMetadata(DependencyMetadata::merge([
632
+				DependencyMetadata::ofEntityId($context->getEntity()->getId()),
633
+				DependencyMetadata::ofEntityId($result->getConstraint()->getPropertyId()),
634
+			])),
635
+		]));
636 636
 	}
637 637
 
638 638
 	/**
@@ -640,12 +640,12 @@  discard block
 block discarded – undo
640 640
 	 *
641 641
 	 * @return CheckResult[]
642 642
 	 */
643
-	private function sortResult( array $result ) {
644
-		if ( count( $result ) < 2 ) {
643
+	private function sortResult(array $result) {
644
+		if (count($result) < 2) {
645 645
 			return $result;
646 646
 		}
647 647
 
648
-		$sortFunction = function ( CheckResult $a, CheckResult $b ) {
648
+		$sortFunction = function(CheckResult $a, CheckResult $b) {
649 649
 			$orderNum = 0;
650 650
 			$order = [
651 651
 				CheckResult::STATUS_BAD_PARAMETERS => $orderNum++,
@@ -661,55 +661,55 @@  discard block
 block discarded – undo
661 661
 			$statusA = $a->getStatus();
662 662
 			$statusB = $b->getStatus();
663 663
 
664
-			$orderA = array_key_exists( $statusA, $order ) ? $order[ $statusA ] : $order[ 'other' ];
665
-			$orderB = array_key_exists( $statusB, $order ) ? $order[ $statusB ] : $order[ 'other' ];
664
+			$orderA = array_key_exists($statusA, $order) ? $order[$statusA] : $order['other'];
665
+			$orderB = array_key_exists($statusB, $order) ? $order[$statusB] : $order['other'];
666 666
 
667
-			if ( $orderA === $orderB ) {
667
+			if ($orderA === $orderB) {
668 668
 				$cursorA = $a->getContextCursor();
669 669
 				$cursorB = $b->getContextCursor();
670 670
 
671
-				if ( $cursorA instanceof EntityContextCursor ) {
671
+				if ($cursorA instanceof EntityContextCursor) {
672 672
 					return $cursorB instanceof EntityContextCursor ? 0 : -1;
673 673
 				}
674
-				if ( $cursorB instanceof EntityContextCursor ) {
674
+				if ($cursorB instanceof EntityContextCursor) {
675 675
 					return $cursorA instanceof EntityContextCursor ? 0 : 1;
676 676
 				}
677 677
 
678 678
 				$pidA = $cursorA->getSnakPropertyId();
679 679
 				$pidB = $cursorB->getSnakPropertyId();
680 680
 
681
-				if ( $pidA === $pidB ) {
681
+				if ($pidA === $pidB) {
682 682
 					$hashA = $cursorA->getSnakHash();
683 683
 					$hashB = $cursorB->getSnakHash();
684 684
 
685
-					if ( $hashA === $hashB ) {
686
-						if ( $a instanceof NullResult ) {
685
+					if ($hashA === $hashB) {
686
+						if ($a instanceof NullResult) {
687 687
 							return $b instanceof NullResult ? 0 : -1;
688 688
 						}
689
-						if ( $b instanceof NullResult ) {
689
+						if ($b instanceof NullResult) {
690 690
 							return $a instanceof NullResult ? 0 : 1;
691 691
 						}
692 692
 
693 693
 						$typeA = $a->getConstraint()->getConstraintTypeItemId();
694 694
 						$typeB = $b->getConstraint()->getConstraintTypeItemId();
695 695
 
696
-						if ( $typeA == $typeB ) {
696
+						if ($typeA == $typeB) {
697 697
 							return 0;
698 698
 						} else {
699
-							return ( $typeA > $typeB ) ? 1 : -1;
699
+							return ($typeA > $typeB) ? 1 : -1;
700 700
 						}
701 701
 					} else {
702
-						return ( $hashA > $hashB ) ? 1 : -1;
702
+						return ($hashA > $hashB) ? 1 : -1;
703 703
 					}
704 704
 				} else {
705
-					return ( $pidA > $pidB ) ? 1 : -1;
705
+					return ($pidA > $pidB) ? 1 : -1;
706 706
 				}
707 707
 			} else {
708
-				return ( $orderA > $orderB ) ? 1 : -1;
708
+				return ($orderA > $orderB) ? 1 : -1;
709 709
 			}
710 710
 		};
711 711
 
712
-		uasort( $result, $sortFunction );
712
+		uasort($result, $sortFunction);
713 713
 
714 714
 		return $result;
715 715
 	}
Please login to merge, or discard this patch.
src/ConstraintCheck/Helper/ConstraintParameterParser.php 1 patch
Spacing   +282 added lines, -282 removed lines patch added patch discarded remove patch
@@ -78,15 +78,15 @@  discard block
 block discarded – undo
78 78
 	 * @param array $parameters
79 79
 	 * @throws ConstraintParameterException
80 80
 	 */
81
-	public function checkError( array $parameters ) {
82
-		if ( array_key_exists( '@error', $parameters ) ) {
81
+	public function checkError(array $parameters) {
82
+		if (array_key_exists('@error', $parameters)) {
83 83
 			$error = $parameters['@error'];
84
-			if ( array_key_exists( 'toolong', $error ) && $error['toolong'] ) {
84
+			if (array_key_exists('toolong', $error) && $error['toolong']) {
85 85
 				$msg = 'wbqc-violation-message-parameters-error-toolong';
86 86
 			} else {
87 87
 				$msg = 'wbqc-violation-message-parameters-error-unknown';
88 88
 			}
89
-			throw new ConstraintParameterException( new ViolationMessage( $msg ) );
89
+			throw new ConstraintParameterException(new ViolationMessage($msg));
90 90
 		}
91 91
 	}
92 92
 
@@ -96,11 +96,11 @@  discard block
 block discarded – undo
96 96
 	 * @param string $parameterId
97 97
 	 * @throws ConstraintParameterException
98 98
 	 */
99
-	private function requireSingleParameter( array $parameters, $parameterId ) {
100
-		if ( count( $parameters[$parameterId] ) !== 1 ) {
99
+	private function requireSingleParameter(array $parameters, $parameterId) {
100
+		if (count($parameters[$parameterId]) !== 1) {
101 101
 			throw new ConstraintParameterException(
102
-				( new ViolationMessage( 'wbqc-violation-message-parameter-single' ) )
103
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
102
+				(new ViolationMessage('wbqc-violation-message-parameter-single'))
103
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
104 104
 			);
105 105
 		}
106 106
 	}
@@ -112,11 +112,11 @@  discard block
 block discarded – undo
112 112
 	 * @return void
113 113
 	 * @throws ConstraintParameterException
114 114
 	 */
115
-	private function requireValueParameter( Snak $snak, $parameterId ) {
116
-		if ( !( $snak instanceof PropertyValueSnak ) ) {
115
+	private function requireValueParameter(Snak $snak, $parameterId) {
116
+		if (!($snak instanceof PropertyValueSnak)) {
117 117
 			throw new ConstraintParameterException(
118
-				( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) )
119
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
118
+				(new ViolationMessage('wbqc-violation-message-parameter-value'))
119
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
120 120
 			);
121 121
 		}
122 122
 	}
@@ -128,17 +128,17 @@  discard block
 block discarded – undo
128 128
 	 * @throws ConstraintParameterException
129 129
 	 * @return EntityId
130 130
 	 */
131
-	private function parseEntityIdParameter( array $snakSerialization, $parameterId ) {
132
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
133
-		$this->requireValueParameter( $snak, $parameterId );
131
+	private function parseEntityIdParameter(array $snakSerialization, $parameterId) {
132
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
133
+		$this->requireValueParameter($snak, $parameterId);
134 134
 		$value = $snak->getDataValue();
135
-		if ( $value instanceof EntityIdValue ) {
135
+		if ($value instanceof EntityIdValue) {
136 136
 			return $value->getEntityId();
137 137
 		} else {
138 138
 			throw new ConstraintParameterException(
139
-				( new ViolationMessage( 'wbqc-violation-message-parameter-entity' ) )
140
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
141
-					->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE )
139
+				(new ViolationMessage('wbqc-violation-message-parameter-entity'))
140
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
141
+					->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE)
142 142
 			);
143 143
 		}
144 144
 	}
@@ -149,20 +149,20 @@  discard block
 block discarded – undo
149 149
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
150 150
 	 * @return string[] class entity ID serializations
151 151
 	 */
152
-	public function parseClassParameter( array $constraintParameters, $constraintTypeItemId ) {
153
-		$this->checkError( $constraintParameters );
154
-		$classId = $this->config->get( 'WBQualityConstraintsClassId' );
155
-		if ( !array_key_exists( $classId, $constraintParameters ) ) {
152
+	public function parseClassParameter(array $constraintParameters, $constraintTypeItemId) {
153
+		$this->checkError($constraintParameters);
154
+		$classId = $this->config->get('WBQualityConstraintsClassId');
155
+		if (!array_key_exists($classId, $constraintParameters)) {
156 156
 			throw new ConstraintParameterException(
157
-				( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) )
158
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
159
-					->withEntityId( new PropertyId( $classId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
157
+				(new ViolationMessage('wbqc-violation-message-parameter-needed'))
158
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
159
+					->withEntityId(new PropertyId($classId), Role::CONSTRAINT_PARAMETER_PROPERTY)
160 160
 			);
161 161
 		}
162 162
 
163 163
 		$classes = [];
164
-		foreach ( $constraintParameters[$classId] as $class ) {
165
-			$classes[] = $this->parseEntityIdParameter( $class, $classId )->getSerialization();
164
+		foreach ($constraintParameters[$classId] as $class) {
165
+			$classes[] = $this->parseEntityIdParameter($class, $classId)->getSerialization();
166 166
 		}
167 167
 		return $classes;
168 168
 	}
@@ -173,23 +173,23 @@  discard block
 block discarded – undo
173 173
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
174 174
 	 * @return string 'instance', 'subclass', or 'instanceOrSubclass'
175 175
 	 */
176
-	public function parseRelationParameter( array $constraintParameters, $constraintTypeItemId ) {
177
-		$this->checkError( $constraintParameters );
178
-		$relationId = $this->config->get( 'WBQualityConstraintsRelationId' );
179
-		if ( !array_key_exists( $relationId, $constraintParameters ) ) {
176
+	public function parseRelationParameter(array $constraintParameters, $constraintTypeItemId) {
177
+		$this->checkError($constraintParameters);
178
+		$relationId = $this->config->get('WBQualityConstraintsRelationId');
179
+		if (!array_key_exists($relationId, $constraintParameters)) {
180 180
 			throw new ConstraintParameterException(
181
-				( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) )
182
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
183
-					->withEntityId( new PropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
181
+				(new ViolationMessage('wbqc-violation-message-parameter-needed'))
182
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
183
+					->withEntityId(new PropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY)
184 184
 			);
185 185
 		}
186 186
 
187
-		$this->requireSingleParameter( $constraintParameters, $relationId );
188
-		$relationEntityId = $this->parseEntityIdParameter( $constraintParameters[$relationId][0], $relationId );
189
-		$instanceId = $this->config->get( 'WBQualityConstraintsInstanceOfRelationId' );
190
-		$subclassId = $this->config->get( 'WBQualityConstraintsSubclassOfRelationId' );
191
-		$instanceOrSubclassId = $this->config->get( 'WBQualityConstraintsInstanceOrSubclassOfRelationId' );
192
-		switch ( $relationEntityId ) {
187
+		$this->requireSingleParameter($constraintParameters, $relationId);
188
+		$relationEntityId = $this->parseEntityIdParameter($constraintParameters[$relationId][0], $relationId);
189
+		$instanceId = $this->config->get('WBQualityConstraintsInstanceOfRelationId');
190
+		$subclassId = $this->config->get('WBQualityConstraintsSubclassOfRelationId');
191
+		$instanceOrSubclassId = $this->config->get('WBQualityConstraintsInstanceOrSubclassOfRelationId');
192
+		switch ($relationEntityId) {
193 193
 			case $instanceId:
194 194
 				return 'instance';
195 195
 			case $subclassId:
@@ -198,13 +198,13 @@  discard block
 block discarded – undo
198 198
 				return 'instanceOrSubclass';
199 199
 			default:
200 200
 				throw new ConstraintParameterException(
201
-					( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) )
202
-						->withEntityId( new PropertyId( $relationId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
201
+					(new ViolationMessage('wbqc-violation-message-parameter-oneof'))
202
+						->withEntityId(new PropertyId($relationId), Role::CONSTRAINT_PARAMETER_PROPERTY)
203 203
 						->withEntityIdList(
204 204
 							[
205
-								new ItemId( $instanceId ),
206
-								new ItemId( $subclassId ),
207
-								new ItemId( $instanceOrSubclassId ),
205
+								new ItemId($instanceId),
206
+								new ItemId($subclassId),
207
+								new ItemId($instanceOrSubclassId),
208 208
 							],
209 209
 							Role::CONSTRAINT_PARAMETER_VALUE
210 210
 						)
@@ -219,20 +219,20 @@  discard block
 block discarded – undo
219 219
 	 * @throws ConstraintParameterException
220 220
 	 * @return PropertyId
221 221
 	 */
222
-	private function parsePropertyIdParameter( array $snakSerialization, $parameterId ) {
223
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
224
-		$this->requireValueParameter( $snak, $parameterId );
222
+	private function parsePropertyIdParameter(array $snakSerialization, $parameterId) {
223
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
224
+		$this->requireValueParameter($snak, $parameterId);
225 225
 		$value = $snak->getDataValue();
226
-		if ( $value instanceof EntityIdValue ) {
226
+		if ($value instanceof EntityIdValue) {
227 227
 			$id = $value->getEntityId();
228
-			if ( $id instanceof PropertyId ) {
228
+			if ($id instanceof PropertyId) {
229 229
 				return $id;
230 230
 			}
231 231
 		}
232 232
 		throw new ConstraintParameterException(
233
-			( new ViolationMessage( 'wbqc-violation-message-parameter-property' ) )
234
-				->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
235
-				->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE )
233
+			(new ViolationMessage('wbqc-violation-message-parameter-property'))
234
+				->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
235
+				->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE)
236 236
 		);
237 237
 	}
238 238
 
@@ -243,32 +243,32 @@  discard block
 block discarded – undo
243 243
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
244 244
 	 * @return PropertyId
245 245
 	 */
246
-	public function parsePropertyParameter( array $constraintParameters, $constraintTypeItemId ) {
247
-		$this->checkError( $constraintParameters );
248
-		$propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' );
249
-		if ( !array_key_exists( $propertyId, $constraintParameters ) ) {
246
+	public function parsePropertyParameter(array $constraintParameters, $constraintTypeItemId) {
247
+		$this->checkError($constraintParameters);
248
+		$propertyId = $this->config->get('WBQualityConstraintsPropertyId');
249
+		if (!array_key_exists($propertyId, $constraintParameters)) {
250 250
 			throw new ConstraintParameterException(
251
-				( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) )
252
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
253
-					->withEntityId( new PropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
251
+				(new ViolationMessage('wbqc-violation-message-parameter-needed'))
252
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
253
+					->withEntityId(new PropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY)
254 254
 			);
255 255
 		}
256 256
 
257
-		$this->requireSingleParameter( $constraintParameters, $propertyId );
258
-		return $this->parsePropertyIdParameter( $constraintParameters[$propertyId][0], $propertyId );
257
+		$this->requireSingleParameter($constraintParameters, $propertyId);
258
+		return $this->parsePropertyIdParameter($constraintParameters[$propertyId][0], $propertyId);
259 259
 	}
260 260
 
261
-	private function parseItemIdParameter( PropertyValueSnak $snak, $parameterId ) {
261
+	private function parseItemIdParameter(PropertyValueSnak $snak, $parameterId) {
262 262
 		$dataValue = $snak->getDataValue();
263
-		if ( $dataValue instanceof EntityIdValue &&
263
+		if ($dataValue instanceof EntityIdValue &&
264 264
 			$dataValue->getEntityId() instanceof ItemId
265 265
 		) {
266
-			return ItemIdSnakValue::fromItemId( $dataValue->getEntityId() );
266
+			return ItemIdSnakValue::fromItemId($dataValue->getEntityId());
267 267
 		} else {
268 268
 			throw new ConstraintParameterException(
269
-				( new ViolationMessage( 'wbqc-violation-message-parameter-item' ) )
270
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
271
-					->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE )
269
+				(new ViolationMessage('wbqc-violation-message-parameter-item'))
270
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
271
+					->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE)
272 272
 			);
273 273
 		}
274 274
 	}
@@ -287,16 +287,16 @@  discard block
 block discarded – undo
287 287
 		$required,
288 288
 		$parameterId = null
289 289
 	) {
290
-		$this->checkError( $constraintParameters );
291
-		if ( $parameterId === null ) {
292
-			$parameterId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' );
290
+		$this->checkError($constraintParameters);
291
+		if ($parameterId === null) {
292
+			$parameterId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId');
293 293
 		}
294
-		if ( !array_key_exists( $parameterId, $constraintParameters ) ) {
295
-			if ( $required ) {
294
+		if (!array_key_exists($parameterId, $constraintParameters)) {
295
+			if ($required) {
296 296
 				throw new ConstraintParameterException(
297
-					( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) )
298
-						->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
299
-						->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
297
+					(new ViolationMessage('wbqc-violation-message-parameter-needed'))
298
+						->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
299
+						->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
300 300
 				);
301 301
 			} else {
302 302
 				return [];
@@ -304,11 +304,11 @@  discard block
 block discarded – undo
304 304
 		}
305 305
 
306 306
 		$values = [];
307
-		foreach ( $constraintParameters[$parameterId] as $parameter ) {
308
-			$snak = $this->snakDeserializer->deserialize( $parameter );
309
-			switch ( true ) {
307
+		foreach ($constraintParameters[$parameterId] as $parameter) {
308
+			$snak = $this->snakDeserializer->deserialize($parameter);
309
+			switch (true) {
310 310
 				case $snak instanceof PropertyValueSnak:
311
-					$values[] = $this->parseItemIdParameter( $snak, $parameterId );
311
+					$values[] = $this->parseItemIdParameter($snak, $parameterId);
312 312
 					break;
313 313
 				case $snak instanceof PropertySomeValueSnak:
314 314
 					$values[] = ItemIdSnakValue::someValue();
@@ -327,27 +327,27 @@  discard block
 block discarded – undo
327 327
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
328 328
 	 * @return PropertyId[]
329 329
 	 */
330
-	public function parsePropertiesParameter( array $constraintParameters, $constraintTypeItemId ) {
331
-		$this->checkError( $constraintParameters );
332
-		$propertyId = $this->config->get( 'WBQualityConstraintsPropertyId' );
333
-		if ( !array_key_exists( $propertyId, $constraintParameters ) ) {
330
+	public function parsePropertiesParameter(array $constraintParameters, $constraintTypeItemId) {
331
+		$this->checkError($constraintParameters);
332
+		$propertyId = $this->config->get('WBQualityConstraintsPropertyId');
333
+		if (!array_key_exists($propertyId, $constraintParameters)) {
334 334
 			throw new ConstraintParameterException(
335
-				( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) )
336
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
337
-					->withEntityId( new PropertyId( $propertyId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
335
+				(new ViolationMessage('wbqc-violation-message-parameter-needed'))
336
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
337
+					->withEntityId(new PropertyId($propertyId), Role::CONSTRAINT_PARAMETER_PROPERTY)
338 338
 			);
339 339
 		}
340 340
 
341 341
 		$parameters = $constraintParameters[$propertyId];
342
-		if ( count( $parameters ) === 1 &&
343
-			$this->snakDeserializer->deserialize( $parameters[0] ) instanceof PropertyNoValueSnak
342
+		if (count($parameters) === 1 &&
343
+			$this->snakDeserializer->deserialize($parameters[0]) instanceof PropertyNoValueSnak
344 344
 		) {
345 345
 			return [];
346 346
 		}
347 347
 
348 348
 		$properties = [];
349
-		foreach ( $parameters as $parameter ) {
350
-			$properties[] = $this->parsePropertyIdParameter( $parameter, $propertyId );
349
+		foreach ($parameters as $parameter) {
350
+			$properties[] = $this->parsePropertyIdParameter($parameter, $propertyId);
351 351
 		}
352 352
 		return $properties;
353 353
 	}
@@ -358,16 +358,16 @@  discard block
 block discarded – undo
358 358
 	 * @throws ConstraintParameterException
359 359
 	 * @return DataValue|null
360 360
 	 */
361
-	private function parseValueOrNoValueParameter( array $snakSerialization, $parameterId ) {
362
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
363
-		if ( $snak instanceof PropertyValueSnak ) {
361
+	private function parseValueOrNoValueParameter(array $snakSerialization, $parameterId) {
362
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
363
+		if ($snak instanceof PropertyValueSnak) {
364 364
 			return $snak->getDataValue();
365
-		} elseif ( $snak instanceof PropertyNoValueSnak ) {
365
+		} elseif ($snak instanceof PropertyNoValueSnak) {
366 366
 			return null;
367 367
 		} else {
368 368
 			throw new ConstraintParameterException(
369
-				( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) )
370
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
369
+				(new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue'))
370
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
371 371
 			);
372 372
 		}
373 373
 	}
@@ -377,10 +377,10 @@  discard block
 block discarded – undo
377 377
 	 * @param string $parameterId
378 378
 	 * @return DataValue|null
379 379
 	 */
380
-	private function parseValueOrNoValueOrNowParameter( array $snakSerialization, $parameterId ) {
380
+	private function parseValueOrNoValueOrNowParameter(array $snakSerialization, $parameterId) {
381 381
 		try {
382
-			return $this->parseValueOrNoValueParameter( $snakSerialization, $parameterId );
383
-		} catch ( ConstraintParameterException $e ) {
382
+			return $this->parseValueOrNoValueParameter($snakSerialization, $parameterId);
383
+		} catch (ConstraintParameterException $e) {
384 384
 			// unknown value means “now”
385 385
 			return new NowValue();
386 386
 		}
@@ -393,14 +393,14 @@  discard block
 block discarded – undo
393 393
 	 * @param string $unit
394 394
 	 * @return bool
395 395
 	 */
396
-	private function exactlyOneQuantityWithUnit( DataValue $min = null, DataValue $max = null, $unit ) {
397
-		if ( !( $min instanceof UnboundedQuantityValue ) ||
398
-			!( $max instanceof UnboundedQuantityValue )
396
+	private function exactlyOneQuantityWithUnit(DataValue $min = null, DataValue $max = null, $unit) {
397
+		if (!($min instanceof UnboundedQuantityValue) ||
398
+			!($max instanceof UnboundedQuantityValue)
399 399
 		) {
400 400
 			return false;
401 401
 		}
402 402
 
403
-		return ( $min->getUnit() === $unit ) !== ( $max->getUnit() === $unit );
403
+		return ($min->getUnit() === $unit) !== ($max->getUnit() === $unit);
404 404
 	}
405 405
 
406 406
 	/**
@@ -413,42 +413,42 @@  discard block
 block discarded – undo
413 413
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
414 414
 	 * @return DataValue[] if the parameter is invalid or missing
415 415
 	 */
416
-	private function parseRangeParameter( array $constraintParameters, $minimumId, $maximumId, $constraintTypeItemId, $type ) {
417
-		$this->checkError( $constraintParameters );
418
-		if ( !array_key_exists( $minimumId, $constraintParameters ) ||
419
-			!array_key_exists( $maximumId, $constraintParameters )
416
+	private function parseRangeParameter(array $constraintParameters, $minimumId, $maximumId, $constraintTypeItemId, $type) {
417
+		$this->checkError($constraintParameters);
418
+		if (!array_key_exists($minimumId, $constraintParameters) ||
419
+			!array_key_exists($maximumId, $constraintParameters)
420 420
 		) {
421 421
 			throw new ConstraintParameterException(
422
-				( new ViolationMessage( 'wbqc-violation-message-range-parameters-needed' ) )
423
-					->withDataValueType( $type )
424
-					->withEntityId( new PropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
425
-					->withEntityId( new PropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
426
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
422
+				(new ViolationMessage('wbqc-violation-message-range-parameters-needed'))
423
+					->withDataValueType($type)
424
+					->withEntityId(new PropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY)
425
+					->withEntityId(new PropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY)
426
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
427 427
 			);
428 428
 		}
429 429
 
430
-		$this->requireSingleParameter( $constraintParameters, $minimumId );
431
-		$this->requireSingleParameter( $constraintParameters, $maximumId );
430
+		$this->requireSingleParameter($constraintParameters, $minimumId);
431
+		$this->requireSingleParameter($constraintParameters, $maximumId);
432 432
 		$parseFunction = $type === 'time' ? 'parseValueOrNoValueOrNowParameter' : 'parseValueOrNoValueParameter';
433
-		$min = $this->$parseFunction( $constraintParameters[$minimumId][0], $minimumId );
434
-		$max = $this->$parseFunction( $constraintParameters[$maximumId][0], $maximumId );
433
+		$min = $this->$parseFunction($constraintParameters[$minimumId][0], $minimumId);
434
+		$max = $this->$parseFunction($constraintParameters[$maximumId][0], $maximumId);
435 435
 
436
-		$yearUnit = $this->config->get( 'WBQualityConstraintsYearUnit' );
437
-		if ( $this->exactlyOneQuantityWithUnit( $min, $max, $yearUnit ) ) {
436
+		$yearUnit = $this->config->get('WBQualityConstraintsYearUnit');
437
+		if ($this->exactlyOneQuantityWithUnit($min, $max, $yearUnit)) {
438 438
 			throw new ConstraintParameterException(
439
-				new ViolationMessage( 'wbqc-violation-message-range-parameters-one-year' )
439
+				new ViolationMessage('wbqc-violation-message-range-parameters-one-year')
440 440
 			);
441 441
 		}
442
-		if ( $min === null && $max === null ||
443
-			$min !== null && $max !== null && $min->equals( $max ) ) {
442
+		if ($min === null && $max === null ||
443
+			$min !== null && $max !== null && $min->equals($max)) {
444 444
 			throw new ConstraintParameterException(
445
-				( new ViolationMessage( 'wbqc-violation-message-range-parameters-same' ) )
446
-					->withEntityId( new PropertyId( $minimumId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
447
-					->withEntityId( new PropertyId( $maximumId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
445
+				(new ViolationMessage('wbqc-violation-message-range-parameters-same'))
446
+					->withEntityId(new PropertyId($minimumId), Role::CONSTRAINT_PARAMETER_PROPERTY)
447
+					->withEntityId(new PropertyId($maximumId), Role::CONSTRAINT_PARAMETER_PROPERTY)
448 448
 			);
449 449
 		}
450 450
 
451
-		return [ $min, $max ];
451
+		return [$min, $max];
452 452
 	}
453 453
 
454 454
 	/**
@@ -458,11 +458,11 @@  discard block
 block discarded – undo
458 458
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
459 459
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
460 460
 	 */
461
-	public function parseQuantityRangeParameter( array $constraintParameters, $constraintTypeItemId ) {
461
+	public function parseQuantityRangeParameter(array $constraintParameters, $constraintTypeItemId) {
462 462
 		return $this->parseRangeParameter(
463 463
 			$constraintParameters,
464
-			$this->config->get( 'WBQualityConstraintsMinimumQuantityId' ),
465
-			$this->config->get( 'WBQualityConstraintsMaximumQuantityId' ),
464
+			$this->config->get('WBQualityConstraintsMinimumQuantityId'),
465
+			$this->config->get('WBQualityConstraintsMaximumQuantityId'),
466 466
 			$constraintTypeItemId,
467 467
 			'quantity'
468 468
 		);
@@ -475,11 +475,11 @@  discard block
 block discarded – undo
475 475
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
476 476
 	 * @return DataValue[] a pair of two data values, either of which may be null to signify an open range
477 477
 	 */
478
-	public function parseTimeRangeParameter( array $constraintParameters, $constraintTypeItemId ) {
478
+	public function parseTimeRangeParameter(array $constraintParameters, $constraintTypeItemId) {
479 479
 		return $this->parseRangeParameter(
480 480
 			$constraintParameters,
481
-			$this->config->get( 'WBQualityConstraintsMinimumDateId' ),
482
-			$this->config->get( 'WBQualityConstraintsMaximumDateId' ),
481
+			$this->config->get('WBQualityConstraintsMinimumDateId'),
482
+			$this->config->get('WBQualityConstraintsMaximumDateId'),
483 483
 			$constraintTypeItemId,
484 484
 			'time'
485 485
 		);
@@ -492,17 +492,17 @@  discard block
 block discarded – undo
492 492
 	 * @throws ConstraintParameterException
493 493
 	 * @return string
494 494
 	 */
495
-	private function parseStringParameter( array $snakSerialization, $parameterId ) {
496
-		$snak = $this->snakDeserializer->deserialize( $snakSerialization );
497
-		$this->requireValueParameter( $snak, $parameterId );
495
+	private function parseStringParameter(array $snakSerialization, $parameterId) {
496
+		$snak = $this->snakDeserializer->deserialize($snakSerialization);
497
+		$this->requireValueParameter($snak, $parameterId);
498 498
 		$value = $snak->getDataValue();
499
-		if ( $value instanceof StringValue ) {
499
+		if ($value instanceof StringValue) {
500 500
 			return $value->getValue();
501 501
 		} else {
502 502
 			throw new ConstraintParameterException(
503
-				( new ViolationMessage( 'wbqc-violation-message-parameter-string' ) )
504
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
505
-					->withDataValue( $value, Role::CONSTRAINT_PARAMETER_VALUE )
503
+				(new ViolationMessage('wbqc-violation-message-parameter-string'))
504
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
505
+					->withDataValue($value, Role::CONSTRAINT_PARAMETER_VALUE)
506 506
 			);
507 507
 		}
508 508
 	}
@@ -513,15 +513,15 @@  discard block
 block discarded – undo
513 513
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
514 514
 	 * @return string
515 515
 	 */
516
-	public function parseNamespaceParameter( array $constraintParameters, $constraintTypeItemId ) {
517
-		$this->checkError( $constraintParameters );
518
-		$namespaceId = $this->config->get( 'WBQualityConstraintsNamespaceId' );
519
-		if ( !array_key_exists( $namespaceId, $constraintParameters ) ) {
516
+	public function parseNamespaceParameter(array $constraintParameters, $constraintTypeItemId) {
517
+		$this->checkError($constraintParameters);
518
+		$namespaceId = $this->config->get('WBQualityConstraintsNamespaceId');
519
+		if (!array_key_exists($namespaceId, $constraintParameters)) {
520 520
 			return '';
521 521
 		}
522 522
 
523
-		$this->requireSingleParameter( $constraintParameters, $namespaceId );
524
-		return $this->parseStringParameter( $constraintParameters[$namespaceId][0], $namespaceId );
523
+		$this->requireSingleParameter($constraintParameters, $namespaceId);
524
+		return $this->parseStringParameter($constraintParameters[$namespaceId][0], $namespaceId);
525 525
 	}
526 526
 
527 527
 	/**
@@ -530,19 +530,19 @@  discard block
 block discarded – undo
530 530
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
531 531
 	 * @return string
532 532
 	 */
533
-	public function parseFormatParameter( array $constraintParameters, $constraintTypeItemId ) {
534
-		$this->checkError( $constraintParameters );
535
-		$formatId = $this->config->get( 'WBQualityConstraintsFormatAsARegularExpressionId' );
536
-		if ( !array_key_exists( $formatId, $constraintParameters ) ) {
533
+	public function parseFormatParameter(array $constraintParameters, $constraintTypeItemId) {
534
+		$this->checkError($constraintParameters);
535
+		$formatId = $this->config->get('WBQualityConstraintsFormatAsARegularExpressionId');
536
+		if (!array_key_exists($formatId, $constraintParameters)) {
537 537
 			throw new ConstraintParameterException(
538
-				( new ViolationMessage( 'wbqc-violation-message-parameter-needed' ) )
539
-					->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
540
-					->withEntityId( new PropertyId( $formatId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
538
+				(new ViolationMessage('wbqc-violation-message-parameter-needed'))
539
+					->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
540
+					->withEntityId(new PropertyId($formatId), Role::CONSTRAINT_PARAMETER_PROPERTY)
541 541
 			);
542 542
 		}
543 543
 
544
-		$this->requireSingleParameter( $constraintParameters, $formatId );
545
-		return $this->parseStringParameter( $constraintParameters[$formatId][0], $formatId );
544
+		$this->requireSingleParameter($constraintParameters, $formatId);
545
+		return $this->parseStringParameter($constraintParameters[$formatId][0], $formatId);
546 546
 	}
547 547
 
548 548
 	/**
@@ -550,16 +550,16 @@  discard block
 block discarded – undo
550 550
 	 * @throws ConstraintParameterException if the parameter is invalid
551 551
 	 * @return EntityId[]
552 552
 	 */
553
-	public function parseExceptionParameter( array $constraintParameters ) {
554
-		$this->checkError( $constraintParameters );
555
-		$exceptionId = $this->config->get( 'WBQualityConstraintsExceptionToConstraintId' );
556
-		if ( !array_key_exists( $exceptionId, $constraintParameters ) ) {
553
+	public function parseExceptionParameter(array $constraintParameters) {
554
+		$this->checkError($constraintParameters);
555
+		$exceptionId = $this->config->get('WBQualityConstraintsExceptionToConstraintId');
556
+		if (!array_key_exists($exceptionId, $constraintParameters)) {
557 557
 			return [];
558 558
 		}
559 559
 
560 560
 		return array_map(
561
-			function( $snakSerialization ) use ( $exceptionId ) {
562
-				return $this->parseEntityIdParameter( $snakSerialization, $exceptionId );
561
+			function($snakSerialization) use ($exceptionId) {
562
+				return $this->parseEntityIdParameter($snakSerialization, $exceptionId);
563 563
 			},
564 564
 			$constraintParameters[$exceptionId]
565 565
 		);
@@ -570,26 +570,26 @@  discard block
 block discarded – undo
570 570
 	 * @throws ConstraintParameterException if the parameter is invalid
571 571
 	 * @return string|null 'mandatory' or null
572 572
 	 */
573
-	public function parseConstraintStatusParameter( array $constraintParameters ) {
574
-		$this->checkError( $constraintParameters );
575
-		$constraintStatusId = $this->config->get( 'WBQualityConstraintsConstraintStatusId' );
576
-		if ( !array_key_exists( $constraintStatusId, $constraintParameters ) ) {
573
+	public function parseConstraintStatusParameter(array $constraintParameters) {
574
+		$this->checkError($constraintParameters);
575
+		$constraintStatusId = $this->config->get('WBQualityConstraintsConstraintStatusId');
576
+		if (!array_key_exists($constraintStatusId, $constraintParameters)) {
577 577
 			return null;
578 578
 		}
579 579
 
580
-		$mandatoryId = $this->config->get( 'WBQualityConstraintsMandatoryConstraintId' );
581
-		$this->requireSingleParameter( $constraintParameters, $constraintStatusId );
582
-		$snak = $this->snakDeserializer->deserialize( $constraintParameters[$constraintStatusId][0] );
583
-		$this->requireValueParameter( $snak, $constraintStatusId );
580
+		$mandatoryId = $this->config->get('WBQualityConstraintsMandatoryConstraintId');
581
+		$this->requireSingleParameter($constraintParameters, $constraintStatusId);
582
+		$snak = $this->snakDeserializer->deserialize($constraintParameters[$constraintStatusId][0]);
583
+		$this->requireValueParameter($snak, $constraintStatusId);
584 584
 		$statusId = $snak->getDataValue()->getEntityId()->getSerialization();
585 585
 
586
-		if ( $statusId === $mandatoryId ) {
586
+		if ($statusId === $mandatoryId) {
587 587
 			return 'mandatory';
588 588
 		} else {
589 589
 			throw new ConstraintParameterException(
590
-				( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) )
591
-					->withEntityId( new PropertyId( $constraintStatusId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
592
-					->withEntityIdList( [ new ItemId( $mandatoryId ) ], Role::CONSTRAINT_PARAMETER_VALUE )
590
+				(new ViolationMessage('wbqc-violation-message-parameter-oneof'))
591
+					->withEntityId(new PropertyId($constraintStatusId), Role::CONSTRAINT_PARAMETER_PROPERTY)
592
+					->withEntityIdList([new ItemId($mandatoryId)], Role::CONSTRAINT_PARAMETER_VALUE)
593 593
 			);
594 594
 		}
595 595
 	}
@@ -601,12 +601,12 @@  discard block
 block discarded – undo
601 601
 	 * @return void
602 602
 	 * @throws ConstraintParameterException
603 603
 	 */
604
-	private function requireMonolingualTextParameter( DataValue $dataValue, $parameterId ) {
605
-		if ( !( $dataValue instanceof MonolingualTextValue ) ) {
604
+	private function requireMonolingualTextParameter(DataValue $dataValue, $parameterId) {
605
+		if (!($dataValue instanceof MonolingualTextValue)) {
606 606
 			throw new ConstraintParameterException(
607
-				( new ViolationMessage( 'wbqc-violation-message-parameter-monolingualtext' ) )
608
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
609
-					->withDataValue( $dataValue, Role::CONSTRAINT_PARAMETER_VALUE )
607
+				(new ViolationMessage('wbqc-violation-message-parameter-monolingualtext'))
608
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
609
+					->withDataValue($dataValue, Role::CONSTRAINT_PARAMETER_VALUE)
610 610
 			);
611 611
 		}
612 612
 	}
@@ -619,30 +619,30 @@  discard block
 block discarded – undo
619 619
 	 * @throws ConstraintParameterException if invalid snaks are found or a language has multiple texts
620 620
 	 * @return MultilingualTextValue
621 621
 	 */
622
-	private function parseMultilingualTextParameter( array $snakSerializations, $parameterId ) {
622
+	private function parseMultilingualTextParameter(array $snakSerializations, $parameterId) {
623 623
 		$result = [];
624 624
 
625
-		foreach ( $snakSerializations as $snakSerialization ) {
626
-			$snak = $this->snakDeserializer->deserialize( $snakSerialization );
627
-			$this->requireValueParameter( $snak, $parameterId );
625
+		foreach ($snakSerializations as $snakSerialization) {
626
+			$snak = $this->snakDeserializer->deserialize($snakSerialization);
627
+			$this->requireValueParameter($snak, $parameterId);
628 628
 
629 629
 			$value = $snak->getDataValue();
630
-			$this->requireMonolingualTextParameter( $value, $parameterId );
630
+			$this->requireMonolingualTextParameter($value, $parameterId);
631 631
 			/** @var MonolingualTextValue $value */
632 632
 
633 633
 			$code = $value->getLanguageCode();
634
-			if ( array_key_exists( $code, $result ) ) {
634
+			if (array_key_exists($code, $result)) {
635 635
 				throw new ConstraintParameterException(
636
-					( new ViolationMessage( 'wbqc-violation-message-parameter-single-per-language' ) )
637
-						->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
638
-						->withLanguage( $code )
636
+					(new ViolationMessage('wbqc-violation-message-parameter-single-per-language'))
637
+						->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
638
+						->withLanguage($code)
639 639
 				);
640 640
 			}
641 641
 
642 642
 			$result[$code] = $value;
643 643
 		}
644 644
 
645
-		return new MultilingualTextValue( $result );
645
+		return new MultilingualTextValue($result);
646 646
 	}
647 647
 
648 648
 	/**
@@ -650,11 +650,11 @@  discard block
 block discarded – undo
650 650
 	 * @throws ConstraintParameterException if the parameter is invalid
651 651
 	 * @return MultilingualTextValue
652 652
 	 */
653
-	public function parseSyntaxClarificationParameter( array $constraintParameters ) {
654
-		$syntaxClarificationId = $this->config->get( 'WBQualityConstraintsSyntaxClarificationId' );
653
+	public function parseSyntaxClarificationParameter(array $constraintParameters) {
654
+		$syntaxClarificationId = $this->config->get('WBQualityConstraintsSyntaxClarificationId');
655 655
 
656
-		if ( !array_key_exists( $syntaxClarificationId, $constraintParameters ) ) {
657
-			return new MultilingualTextValue( [] );
656
+		if (!array_key_exists($syntaxClarificationId, $constraintParameters)) {
657
+			return new MultilingualTextValue([]);
658 658
 		}
659 659
 
660 660
 		$syntaxClarifications = $this->parseMultilingualTextParameter(
@@ -673,9 +673,9 @@  discard block
 block discarded – undo
673 673
 	 * @throws ConstraintParameterException if the parameter is invalid
674 674
 	 * @return string[]|null Context::TYPE_* constants
675 675
 	 */
676
-	public function parseConstraintScopeParameter( array $constraintParameters, $constraintTypeItemId, array $validScopes = null ) {
676
+	public function parseConstraintScopeParameter(array $constraintParameters, $constraintTypeItemId, array $validScopes = null) {
677 677
 		$contextTypes = [];
678
-		$parameterId = $this->config->get( 'WBQualityConstraintsConstraintScopeId' );
678
+		$parameterId = $this->config->get('WBQualityConstraintsConstraintScopeId');
679 679
 		$items = $this->parseItemsParameter(
680 680
 			$constraintParameters,
681 681
 			$constraintTypeItemId,
@@ -683,23 +683,23 @@  discard block
 block discarded – undo
683 683
 			$parameterId
684 684
 		);
685 685
 
686
-		if ( $items === [] ) {
686
+		if ($items === []) {
687 687
 			return null;
688 688
 		}
689 689
 
690
-		foreach ( $items as $item ) {
691
-			$contextTypes[] = $this->parseContextTypeItem( $item, 'constraint scope', $parameterId );
690
+		foreach ($items as $item) {
691
+			$contextTypes[] = $this->parseContextTypeItem($item, 'constraint scope', $parameterId);
692 692
 		}
693 693
 
694
-		if ( $validScopes !== null ) {
695
-			$invalidScopes = array_diff( $contextTypes, $validScopes );
696
-			if ( $invalidScopes !== [] ) {
697
-				$invalidScope = array_pop( $invalidScopes );
694
+		if ($validScopes !== null) {
695
+			$invalidScopes = array_diff($contextTypes, $validScopes);
696
+			if ($invalidScopes !== []) {
697
+				$invalidScope = array_pop($invalidScopes);
698 698
 				throw new ConstraintParameterException(
699
-					( new ViolationMessage( 'wbqc-violation-message-invalid-scope' ) )
700
-						->withConstraintScope( $invalidScope, Role::CONSTRAINT_PARAMETER_VALUE )
701
-						->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
702
-						->withConstraintScopeList( $validScopes, Role::CONSTRAINT_PARAMETER_VALUE )
699
+					(new ViolationMessage('wbqc-violation-message-invalid-scope'))
700
+						->withConstraintScope($invalidScope, Role::CONSTRAINT_PARAMETER_VALUE)
701
+						->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
702
+						->withConstraintScopeList($validScopes, Role::CONSTRAINT_PARAMETER_VALUE)
703 703
 				);
704 704
 			}
705 705
 		}
@@ -713,15 +713,15 @@  discard block
 block discarded – undo
713 713
 	 * @param ItemId $unitId
714 714
 	 * @return string unit
715 715
 	 */
716
-	private function parseUnitParameter( ItemId $unitId ) {
716
+	private function parseUnitParameter(ItemId $unitId) {
717 717
 		$unitRepositoryName = $unitId->getRepositoryName();
718
-		if ( !array_key_exists( $unitRepositoryName, $this->conceptBaseUris ) ) {
718
+		if (!array_key_exists($unitRepositoryName, $this->conceptBaseUris)) {
719 719
 			throw new LogicException(
720
-				'No base URI for concept URI for repository: ' . $unitRepositoryName
720
+				'No base URI for concept URI for repository: '.$unitRepositoryName
721 721
 			);
722 722
 		}
723 723
 		$baseUri = $this->conceptBaseUris[$unitRepositoryName];
724
-		return $baseUri . $unitId->getSerialization();
724
+		return $baseUri.$unitId->getSerialization();
725 725
 	}
726 726
 
727 727
 	/**
@@ -731,23 +731,23 @@  discard block
 block discarded – undo
731 731
 	 * @return UnitsParameter
732 732
 	 * @throws ConstraintParameterException
733 733
 	 */
734
-	private function parseUnitItem( ItemIdSnakValue $item ) {
735
-		switch ( true ) {
734
+	private function parseUnitItem(ItemIdSnakValue $item) {
735
+		switch (true) {
736 736
 			case $item->isValue():
737
-				$unit = $this->parseUnitParameter( $item->getItemId() );
737
+				$unit = $this->parseUnitParameter($item->getItemId());
738 738
 				return new UnitsParameter(
739
-					[ $item->getItemId() ],
740
-					[ UnboundedQuantityValue::newFromNumber( 1, $unit ) ],
739
+					[$item->getItemId()],
740
+					[UnboundedQuantityValue::newFromNumber(1, $unit)],
741 741
 					false
742 742
 				);
743 743
 			case $item->isSomeValue():
744
-				$qualifierId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' );
744
+				$qualifierId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId');
745 745
 				throw new ConstraintParameterException(
746
-					( new ViolationMessage( 'wbqc-violation-message-parameter-value-or-novalue' ) )
747
-						->withEntityId( new PropertyId( $qualifierId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
746
+					(new ViolationMessage('wbqc-violation-message-parameter-value-or-novalue'))
747
+						->withEntityId(new PropertyId($qualifierId), Role::CONSTRAINT_PARAMETER_PROPERTY)
748 748
 				);
749 749
 			case $item->isNoValue():
750
-				return new UnitsParameter( [], [], true );
750
+				return new UnitsParameter([], [], true);
751 751
 		}
752 752
 	}
753 753
 
@@ -757,26 +757,26 @@  discard block
 block discarded – undo
757 757
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
758 758
 	 * @return UnitsParameter
759 759
 	 */
760
-	public function parseUnitsParameter( array $constraintParameters, $constraintTypeItemId ) {
761
-		$items = $this->parseItemsParameter( $constraintParameters, $constraintTypeItemId, true );
760
+	public function parseUnitsParameter(array $constraintParameters, $constraintTypeItemId) {
761
+		$items = $this->parseItemsParameter($constraintParameters, $constraintTypeItemId, true);
762 762
 		$unitItems = [];
763 763
 		$unitQuantities = [];
764 764
 		$unitlessAllowed = false;
765 765
 
766
-		foreach ( $items as $item ) {
767
-			$unit = $this->parseUnitItem( $item );
768
-			$unitItems = array_merge( $unitItems, $unit->getUnitItemIds() );
769
-			$unitQuantities = array_merge( $unitQuantities, $unit->getUnitQuantities() );
766
+		foreach ($items as $item) {
767
+			$unit = $this->parseUnitItem($item);
768
+			$unitItems = array_merge($unitItems, $unit->getUnitItemIds());
769
+			$unitQuantities = array_merge($unitQuantities, $unit->getUnitQuantities());
770 770
 			$unitlessAllowed = $unitlessAllowed || $unit->getUnitlessAllowed();
771 771
 		}
772 772
 
773
-		if ( $unitQuantities === [] && !$unitlessAllowed ) {
773
+		if ($unitQuantities === [] && !$unitlessAllowed) {
774 774
 			throw new LogicException(
775 775
 				'The "units" parameter is required, and yet we seem to be missing any allowed unit'
776 776
 			);
777 777
 		}
778 778
 
779
-		return new UnitsParameter( $unitItems, $unitQuantities, $unitlessAllowed );
779
+		return new UnitsParameter($unitItems, $unitQuantities, $unitlessAllowed);
780 780
 	}
781 781
 
782 782
 	/**
@@ -786,49 +786,49 @@  discard block
 block discarded – undo
786 786
 	 * @return EntityTypesParameter
787 787
 	 * @throws ConstraintParameterException
788 788
 	 */
789
-	private function parseEntityTypeItem( ItemIdSnakValue $item ) {
790
-		$parameterId = $this->config->get( 'WBQualityConstraintsQualifierOfPropertyConstraintId' );
789
+	private function parseEntityTypeItem(ItemIdSnakValue $item) {
790
+		$parameterId = $this->config->get('WBQualityConstraintsQualifierOfPropertyConstraintId');
791 791
 
792
-		if ( !$item->isValue() ) {
792
+		if (!$item->isValue()) {
793 793
 			throw new ConstraintParameterException(
794
-				( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) )
795
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
794
+				(new ViolationMessage('wbqc-violation-message-parameter-value'))
795
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
796 796
 			);
797 797
 		}
798 798
 
799 799
 		$itemId = $item->getItemId();
800
-		switch ( $itemId->getSerialization() ) {
801
-			case $this->config->get( 'WBQualityConstraintsWikibaseItemId' ):
800
+		switch ($itemId->getSerialization()) {
801
+			case $this->config->get('WBQualityConstraintsWikibaseItemId'):
802 802
 				$entityType = 'item';
803 803
 				break;
804
-			case $this->config->get( 'WBQualityConstraintsWikibasePropertyId' ):
804
+			case $this->config->get('WBQualityConstraintsWikibasePropertyId'):
805 805
 				$entityType = 'property';
806 806
 				break;
807
-			case $this->config->get( 'WBQualityConstraintsWikibaseLexemeId' ):
807
+			case $this->config->get('WBQualityConstraintsWikibaseLexemeId'):
808 808
 				$entityType = 'lexeme';
809 809
 				break;
810
-			case $this->config->get( 'WBQualityConstraintsWikibaseFormId' ):
810
+			case $this->config->get('WBQualityConstraintsWikibaseFormId'):
811 811
 				$entityType = 'form';
812 812
 				break;
813
-			case $this->config->get( 'WBQualityConstraintsWikibaseSenseId' ):
813
+			case $this->config->get('WBQualityConstraintsWikibaseSenseId'):
814 814
 				$entityType = 'sense';
815 815
 				break;
816 816
 			default:
817 817
 				$allowed = [
818
-					new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseItemId' ) ),
819
-					new ItemId( $this->config->get( 'WBQualityConstraintsWikibasePropertyId' ) ),
820
-					new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseLexemeId' ) ),
821
-					new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseFormId' ) ),
822
-					new ItemId( $this->config->get( 'WBQualityConstraintsWikibaseSenseId' ) ),
818
+					new ItemId($this->config->get('WBQualityConstraintsWikibaseItemId')),
819
+					new ItemId($this->config->get('WBQualityConstraintsWikibasePropertyId')),
820
+					new ItemId($this->config->get('WBQualityConstraintsWikibaseLexemeId')),
821
+					new ItemId($this->config->get('WBQualityConstraintsWikibaseFormId')),
822
+					new ItemId($this->config->get('WBQualityConstraintsWikibaseSenseId')),
823 823
 				];
824 824
 				throw new ConstraintParameterException(
825
-					( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) )
826
-						->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
827
-						->withEntityIdList( $allowed, Role::CONSTRAINT_PARAMETER_VALUE )
825
+					(new ViolationMessage('wbqc-violation-message-parameter-oneof'))
826
+						->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
827
+						->withEntityIdList($allowed, Role::CONSTRAINT_PARAMETER_VALUE)
828 828
 				);
829 829
 		}
830 830
 
831
-		return new EntityTypesParameter( [ $entityType ], [ $itemId ] );
831
+		return new EntityTypesParameter([$entityType], [$itemId]);
832 832
 	}
833 833
 
834 834
 	/**
@@ -837,27 +837,27 @@  discard block
 block discarded – undo
837 837
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
838 838
 	 * @return EntityTypesParameter
839 839
 	 */
840
-	public function parseEntityTypesParameter( array $constraintParameters, $constraintTypeItemId ) {
840
+	public function parseEntityTypesParameter(array $constraintParameters, $constraintTypeItemId) {
841 841
 		$entityTypes = [];
842 842
 		$entityTypeItemIds = [];
843
-		$items = $this->parseItemsParameter( $constraintParameters, $constraintTypeItemId, true );
843
+		$items = $this->parseItemsParameter($constraintParameters, $constraintTypeItemId, true);
844 844
 
845
-		foreach ( $items as $item ) {
846
-			$entityType = $this->parseEntityTypeItem( $item );
847
-			$entityTypes = array_merge( $entityTypes, $entityType->getEntityTypes() );
848
-			$entityTypeItemIds = array_merge( $entityTypeItemIds, $entityType->getEntityTypeItemIds() );
845
+		foreach ($items as $item) {
846
+			$entityType = $this->parseEntityTypeItem($item);
847
+			$entityTypes = array_merge($entityTypes, $entityType->getEntityTypes());
848
+			$entityTypeItemIds = array_merge($entityTypeItemIds, $entityType->getEntityTypeItemIds());
849 849
 		}
850 850
 
851
-		if ( empty( $entityTypes ) ) {
851
+		if (empty($entityTypes)) {
852 852
 			// @codeCoverageIgnoreStart
853 853
 			throw new LogicException(
854
-				'The "entity types" parameter is required, ' .
854
+				'The "entity types" parameter is required, '.
855 855
 				'and yet we seem to be missing any allowed entity type'
856 856
 			);
857 857
 			// @codeCoverageIgnoreEnd
858 858
 		}
859 859
 
860
-		return new EntityTypesParameter( $entityTypes, $entityTypeItemIds );
860
+		return new EntityTypesParameter($entityTypes, $entityTypeItemIds);
861 861
 	}
862 862
 
863 863
 	/**
@@ -865,18 +865,18 @@  discard block
 block discarded – undo
865 865
 	 * @throws ConstraintParameterException if the parameter is invalid
866 866
 	 * @return PropertyId[]
867 867
 	 */
868
-	public function parseSeparatorsParameter( array $constraintParameters ) {
869
-		$separatorId = $this->config->get( 'WBQualityConstraintsSeparatorId' );
868
+	public function parseSeparatorsParameter(array $constraintParameters) {
869
+		$separatorId = $this->config->get('WBQualityConstraintsSeparatorId');
870 870
 
871
-		if ( !array_key_exists( $separatorId, $constraintParameters ) ) {
871
+		if (!array_key_exists($separatorId, $constraintParameters)) {
872 872
 			return [];
873 873
 		}
874 874
 
875 875
 		$parameters = $constraintParameters[$separatorId];
876 876
 		$separators = [];
877 877
 
878
-		foreach ( $parameters as $parameter ) {
879
-			$separators[] = $this->parsePropertyIdParameter( $parameter, $separatorId );
878
+		foreach ($parameters as $parameter) {
879
+			$separators[] = $this->parsePropertyIdParameter($parameter, $separatorId);
880 880
 		}
881 881
 
882 882
 		return $separators;
@@ -891,26 +891,26 @@  discard block
 block discarded – undo
891 891
 	 * @return string one of the Context::TYPE_* constants
892 892
 	 * @throws ConstraintParameterException
893 893
 	 */
894
-	private function parseContextTypeItem( ItemIdSnakValue $item, $use, $parameterId ) {
895
-		if ( !$item->isValue() ) {
894
+	private function parseContextTypeItem(ItemIdSnakValue $item, $use, $parameterId) {
895
+		if (!$item->isValue()) {
896 896
 			throw new ConstraintParameterException(
897
-				( new ViolationMessage( 'wbqc-violation-message-parameter-value' ) )
898
-					->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
897
+				(new ViolationMessage('wbqc-violation-message-parameter-value'))
898
+					->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
899 899
 			);
900 900
 		}
901 901
 
902
-		if ( $use === 'constraint scope' ) {
903
-			$mainSnakId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnMainValueId' );
904
-			$qualifiersId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnQualifiersId' );
905
-			$referencesId = $this->config->get( 'WBQualityConstraintsConstraintCheckedOnReferencesId' );
902
+		if ($use === 'constraint scope') {
903
+			$mainSnakId = $this->config->get('WBQualityConstraintsConstraintCheckedOnMainValueId');
904
+			$qualifiersId = $this->config->get('WBQualityConstraintsConstraintCheckedOnQualifiersId');
905
+			$referencesId = $this->config->get('WBQualityConstraintsConstraintCheckedOnReferencesId');
906 906
 		} else {
907
-			$mainSnakId = $this->config->get( 'WBQualityConstraintsAsMainValueId' );
908
-			$qualifiersId = $this->config->get( 'WBQualityConstraintsAsQualifiersId' );
909
-			$referencesId = $this->config->get( 'WBQualityConstraintsAsReferencesId' );
907
+			$mainSnakId = $this->config->get('WBQualityConstraintsAsMainValueId');
908
+			$qualifiersId = $this->config->get('WBQualityConstraintsAsQualifiersId');
909
+			$referencesId = $this->config->get('WBQualityConstraintsAsReferencesId');
910 910
 		}
911 911
 
912 912
 		$itemId = $item->getItemId();
913
-		switch ( $itemId->getSerialization() ) {
913
+		switch ($itemId->getSerialization()) {
914 914
 			case $mainSnakId:
915 915
 				return Context::TYPE_STATEMENT;
916 916
 			case $qualifiersId:
@@ -918,11 +918,11 @@  discard block
 block discarded – undo
918 918
 			case $referencesId:
919 919
 				return Context::TYPE_REFERENCE;
920 920
 			default:
921
-				$allowed = [ $mainSnakId, $qualifiersId, $referencesId ];
921
+				$allowed = [$mainSnakId, $qualifiersId, $referencesId];
922 922
 				throw new ConstraintParameterException(
923
-					( new ViolationMessage( 'wbqc-violation-message-parameter-oneof' ) )
924
-						->withEntityId( new PropertyId( $parameterId ), Role::CONSTRAINT_PARAMETER_PROPERTY )
925
-						->withEntityIdList( $allowed, Role::CONSTRAINT_PARAMETER_VALUE )
923
+					(new ViolationMessage('wbqc-violation-message-parameter-oneof'))
924
+						->withEntityId(new PropertyId($parameterId), Role::CONSTRAINT_PARAMETER_PROPERTY)
925
+						->withEntityIdList($allowed, Role::CONSTRAINT_PARAMETER_VALUE)
926 926
 				);
927 927
 		}
928 928
 	}
@@ -933,9 +933,9 @@  discard block
 block discarded – undo
933 933
 	 * @throws ConstraintParameterException if the parameter is invalid or missing
934 934
 	 * @return string[] list of Context::TYPE_* constants
935 935
 	 */
936
-	public function parsePropertyScopeParameter( array $constraintParameters, $constraintTypeItemId ) {
936
+	public function parsePropertyScopeParameter(array $constraintParameters, $constraintTypeItemId) {
937 937
 		$contextTypes = [];
938
-		$parameterId = $this->config->get( 'WBQualityConstraintsPropertyScopeId' );
938
+		$parameterId = $this->config->get('WBQualityConstraintsPropertyScopeId');
939 939
 		$items = $this->parseItemsParameter(
940 940
 			$constraintParameters,
941 941
 			$constraintTypeItemId,
@@ -943,14 +943,14 @@  discard block
 block discarded – undo
943 943
 			$parameterId
944 944
 		);
945 945
 
946
-		foreach ( $items as $item ) {
947
-			$contextTypes[] = $this->parseContextTypeItem( $item, 'property scope', $parameterId );
946
+		foreach ($items as $item) {
947
+			$contextTypes[] = $this->parseContextTypeItem($item, 'property scope', $parameterId);
948 948
 		}
949 949
 
950
-		if ( empty( $contextTypes ) ) {
950
+		if (empty($contextTypes)) {
951 951
 			// @codeCoverageIgnoreStart
952 952
 			throw new LogicException(
953
-				'The "property scope" parameter is required, ' .
953
+				'The "property scope" parameter is required, '.
954 954
 				'and yet we seem to be missing any allowed scope'
955 955
 			);
956 956
 			// @codeCoverageIgnoreEnd
Please login to merge, or discard this patch.