wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Helper/SparqlHelper.php

Spacing +232 added lines, -236 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Helper;
 
@@ -166,143 +166,143 @@ 
 		$this->defaultUserAgent = $defaultUserAgent;
 		$this->requestFactory = $requestFactory;
 		$this->entityPrefixes = [];
-		foreach ( $rdfVocabulary->entityNamespaceNames as $namespaceName ) {
-			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI( $namespaceName );
+		foreach ($rdfVocabulary->entityNamespaceNames as $namespaceName) {
+			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI($namespaceName);
 		}
 
-		$this->primaryEndpoint = $config->get( 'WBQualityConstraintsSparqlEndpoint' );
-		$this->additionalEndpoints = $config->get( 'WBQualityConstraintsAdditionalSparqlEndpoints' ) ?: [];
-		$this->maxQueryTimeMillis = $config->get( 'WBQualityConstraintsSparqlMaxMillis' );
-		$this->subclassOfId = new NumericPropertyId( $config->get( 'WBQualityConstraintsSubclassOfId' ) );
-		$this->cacheMapSize = $config->get( 'WBQualityConstraintsFormatCacheMapSize' );
+		$this->primaryEndpoint = $config->get('WBQualityConstraintsSparqlEndpoint');
+		$this->additionalEndpoints = $config->get('WBQualityConstraintsAdditionalSparqlEndpoints') ?: [];
+		$this->maxQueryTimeMillis = $config->get('WBQualityConstraintsSparqlMaxMillis');
+		$this->subclassOfId = new NumericPropertyId($config->get('WBQualityConstraintsSubclassOfId'));
+		$this->cacheMapSize = $config->get('WBQualityConstraintsFormatCacheMapSize');
 		$this->timeoutExceptionClasses = $config->get(
 			'WBQualityConstraintsSparqlTimeoutExceptionClasses'
 		);
 		$this->sparqlHasWikibaseSupport = $config->get(
 			'WBQualityConstraintsSparqlHasWikibaseSupport'
 		);
-		$this->sparqlThrottlingFallbackDuration = (int)$config->get(
+		$this->sparqlThrottlingFallbackDuration = (int) $config->get(
 			'WBQualityConstraintsSparqlThrottlingFallbackDuration'
 		);
 
-		$this->prefixes = $this->getQueryPrefixes( $rdfVocabulary );
+		$this->prefixes = $this->getQueryPrefixes($rdfVocabulary);
 
 		$this->rdfVocabularyWithoutNormalization = clone $rdfVocabulary;
 		// @phan-suppress-next-line PhanTypeMismatchProperty
 		$this->rdfVocabularyWithoutNormalization->normalizedPropertyValueNamespace = array_fill_keys(
-			array_keys( $rdfVocabulary->normalizedPropertyValueNamespace ),
+			array_keys($rdfVocabulary->normalizedPropertyValueNamespace),
 			null
 		);
 	}
 
-	private function getQueryPrefixes( RdfVocabulary $rdfVocabulary ): string {
+	private function getQueryPrefixes(RdfVocabulary $rdfVocabulary): string {
 		// TODO: it would probably be smarter that RdfVocabulary exposed these prefixes somehow
 		$prefixes = '';
-		foreach ( $rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName ) {
+		foreach ($rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName) {
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 
-		foreach ( $rdfVocabulary->statementNamespaceNames as $sourceName => $sourceNamespaces ) {
+		foreach ($rdfVocabulary->statementNamespaceNames as $sourceName => $sourceNamespaces) {
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NS_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 
-		foreach ( $rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces ) {
+		foreach ($rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces) {
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_DIRECT_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_STATEMENT];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 		$namespaceName = RdfVocabulary::NS_ONTOLOGY;
 		$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		return $prefixes;
 	}
 
 	/** Return a SPARQL term like `wd:Q123` for the given ID. */
-	private function wd( EntityId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wd(EntityId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->entityNamespaceNames[$repository];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `wdt:P123` for the given ID. */
-	private function wdt( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wdt(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_DIRECT_CLAIM];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `p:P123` for the given ID. */
-	private function p( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function p(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_CLAIM];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `pq:P123` for the given ID. */
-	private function pq( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function pq(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_QUALIFIER];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `wdno:P123` for the given ID. */
-	private function wdno( PropertyId $id ): string {
-		$repository = $this->rdfVocabulary->getEntityRepositoryName( $id );
+	private function wdno(PropertyId $id): string {
+		$repository = $this->rdfVocabulary->getEntityRepositoryName($id);
 		$prefix = $this->rdfVocabulary->propertyNamespaceNames[$repository][RdfVocabulary::NSP_NOVALUE];
 		return "$prefix:{$id->getSerialization()}";
 	}
 
 	/** Return a SPARQL term like `prov:NAME` for the given name. */
-	private function prov( string $name ): string {
+	private function prov(string $name): string {
 		$prefix = RdfVocabulary::NS_PROV;
 		return "$prefix:$name";
 	}
 
 	/** Return a SPARQL term like `wikibase:NAME` for the given name. */
-	private function wikibase( string $name ): string {
+	private function wikibase(string $name): string {
 		$prefix = RdfVocabulary::NS_ONTOLOGY;
 		return "$prefix:$name";
 	}
 
 	/** Return a SPARQL snippet like `MINUS { ?var wikibase:rank wikibase:DeprecatedRank. }`. */
-	private function minusDeprecatedRank( string $varName ): string {
+	private function minusDeprecatedRank(string $varName): string {
 		$deprecatedRank = RdfVocabulary::RANK_MAP[Statement::RANK_DEPRECATED];
-		return "MINUS { $varName {$this->wikibase( 'rank' )} {$this->wikibase( $deprecatedRank )}. }";
+		return "MINUS { $varName {$this->wikibase('rank')} {$this->wikibase($deprecatedRank)}. }";
 	}
 
 	/**
@@ -312,43 +312,42 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	public function hasType( EntityId $id, array $classes ): CachedBool {
+	public function hasType(EntityId $id, array $classes): CachedBool {
 		// TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually
 		$gearingHint = $this->sparqlHasWikibaseSupport ?
-			' hint:Prior hint:gearing "forward".' :
-			'';
+			' hint:Prior hint:gearing "forward".' : '';
 
 		$metadatas = [];
 
-		foreach ( array_chunk( $classes, 20 ) as $classesChunk ) {
-			$classesValues = implode( ' ', array_map(
-				function ( string $class ) {
-					return $this->wd( new ItemId( $class ) );
+		foreach (array_chunk($classes, 20) as $classesChunk) {
+			$classesValues = implode(' ', array_map(
+				function(string $class) {
+					return $this->wd(new ItemId($class));
 				},
 				$classesChunk
-			) );
+			));
 
 			$query = <<<EOF
 ASK {
-  BIND({$this->wd( $id )} AS ?item)
+  BIND({$this->wd($id)} AS ?item)
   VALUES ?class { $classesValues }
-  ?item {$this->wdt( $this->subclassOfId )}* ?class.$gearingHint
+  ?item {$this->wdt($this->subclassOfId)}* ?class.$gearingHint
 }
 EOF;
 
-			$result = $this->runQuery( $query, $this->primaryEndpoint );
+			$result = $this->runQuery($query, $this->primaryEndpoint);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getArray()['boolean'] ) {
+			if ($result->getArray()['boolean']) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -366,12 +365,12 @@ 
 		array $separators
 	): CachedEntityIds {
 		$mainSnak = $statement->getMainSnak();
-		if ( !( $mainSnak instanceof PropertyValueSnak ) ) {
-			return new CachedEntityIds( [], Metadata::blank() );
+		if (!($mainSnak instanceof PropertyValueSnak)) {
+			return new CachedEntityIds([], Metadata::blank());
 		}
 
 		$propertyId = $statement->getPropertyId();
-		$pPredicateAndObject = "{$this->p( $propertyId )} ?otherStatement."; // p:P123 ?otherStatement.
+		$pPredicateAndObject = "{$this->p($propertyId)} ?otherStatement."; // p:P123 ?otherStatement.
 		$otherStatementPredicateAndObject = $this->getSnakPredicateAndObject(
 			$entityId,
 			$mainSnak,
@@ -380,57 +379,57 @@ 
 
 		$isSeparator = [];
 		$unusedSeparators = [];
-		foreach ( $separators as $separator ) {
+		foreach ($separators as $separator) {
 			$isSeparator[$separator->getSerialization()] = true;
 			$unusedSeparators[$separator->getSerialization()] = $separator;
 		}
 		$separatorFilters = '';
-		foreach ( $statement->getQualifiers() as $qualifier ) {
+		foreach ($statement->getQualifiers() as $qualifier) {
 			$qualPropertyId = $qualifier->getPropertyId();
-			if ( !( $isSeparator[$qualPropertyId->getSerialization()] ?? false ) ) {
+			if (!($isSeparator[$qualPropertyId->getSerialization()] ?? false)) {
 				continue;
 			}
-			unset( $unusedSeparators[$qualPropertyId->getSerialization()] );
+			unset($unusedSeparators[$qualPropertyId->getSerialization()]);
 			// only look for other statements with the same qualifier
-			if ( $qualifier instanceof PropertyValueSnak ) {
+			if ($qualifier instanceof PropertyValueSnak) {
 				$sepPredicateAndObject = $this->getSnakPredicateAndObject(
 					$entityId,
 					$qualifier,
 					RdfVocabulary::NSP_QUALIFIER
 				);
 				$separatorFilters .= "  ?otherStatement $sepPredicateAndObject\n";
-			} elseif ( $qualifier instanceof PropertyNoValueSnak ) {
-				$sepPredicateAndObject = "a {$this->wdno( $qualPropertyId )}."; // a wdno:P123.
+			} elseif ($qualifier instanceof PropertyNoValueSnak) {
+				$sepPredicateAndObject = "a {$this->wdno($qualPropertyId)}."; // a wdno:P123.
 				$separatorFilters .= "  ?otherStatement $sepPredicateAndObject\n";
 			} else {
 				// "some value" / "unknown value" is always different from everything else,
 				// therefore the whole statement has no duplicates and we can return immediately
-				return new CachedEntityIds( [], Metadata::blank() );
+				return new CachedEntityIds([], Metadata::blank());
 			}
 		}
-		foreach ( $unusedSeparators as $unusedSeparator ) {
+		foreach ($unusedSeparators as $unusedSeparator) {
 			// exclude other statements which have a separator that this one lacks
-			$separatorFilters .= "  MINUS { ?otherStatement {$this->pq( $unusedSeparator )} []. }\n";
-			$separatorFilters .= "  MINUS { ?otherStatement a {$this->wdno( $unusedSeparator )}. }\n";
+			$separatorFilters .= "  MINUS { ?otherStatement {$this->pq($unusedSeparator)} []. }\n";
+			$separatorFilters .= "  MINUS { ?otherStatement a {$this->wdno($unusedSeparator)}. }\n";
 		}
 
 		$query = <<<SPARQL
 SELECT DISTINCT ?otherEntity WHERE {
   ?otherEntity $pPredicateAndObject
   ?otherStatement $otherStatementPredicateAndObject
-  {$this->minusDeprecatedRank( '?otherStatement' )}
-  FILTER(?otherEntity != {$this->wd( $entityId )})
+  {$this->minusDeprecatedRank('?otherStatement')}
+  FILTER(?otherEntity != {$this->wd($entityId)})
 $separatorFilters
 }
 LIMIT 10
 SPARQL;
 
-		$results = [ $this->runQuery( $query, $this->primaryEndpoint ) ];
-		foreach ( $this->additionalEndpoints as $endpoint ) {
-			$results[] = $this->runQuery( $query, $endpoint );
+		$results = [$this->runQuery($query, $this->primaryEndpoint)];
+		foreach ($this->additionalEndpoints as $endpoint) {
+			$results[] = $this->runQuery($query, $endpoint);
 		}
 
-		return $this->getOtherEntities( $results );
+		return $this->getOtherEntities($results);
 	}
 
 	/**
@@ -449,40 +448,38 @@ 
 		bool $ignoreDeprecatedStatements
 	): CachedEntityIds {
 		$propertyId = $snak->getPropertyId();
-		$pPredicateAndObject = "{$this->p( $propertyId )} ?otherStatement."; // p:P123 ?otherStatement.
+		$pPredicateAndObject = "{$this->p($propertyId)} ?otherStatement."; // p:P123 ?otherStatement.
 
 		$otherSubject = $type === Context::TYPE_QUALIFIER ?
-			'?otherStatement' :
-			"?otherStatement {$this->prov( 'wasDerivedFrom' )} ?reference.\n  ?reference";
+			'?otherStatement' : "?otherStatement {$this->prov('wasDerivedFrom')} ?reference.\n  ?reference";
 		$otherPredicateAndObject = $this->getSnakPredicateAndObject(
 			$entityId,
 			$snak,
 			$type === Context::TYPE_QUALIFIER ?
-				RdfVocabulary::NSP_QUALIFIER :
-				RdfVocabulary::NSP_REFERENCE
+				RdfVocabulary::NSP_QUALIFIER : RdfVocabulary::NSP_REFERENCE
 		);
 
 		$deprecatedFilter = '';
-		if ( $ignoreDeprecatedStatements ) {
-			$deprecatedFilter = '  ' . $this->minusDeprecatedRank( '?otherStatement' );
+		if ($ignoreDeprecatedStatements) {
+			$deprecatedFilter = '  '.$this->minusDeprecatedRank('?otherStatement');
 		}
 
 		$query = <<<SPARQL
 SELECT DISTINCT ?otherEntity WHERE {
   ?otherEntity $pPredicateAndObject
   $otherSubject $otherPredicateAndObject
-  FILTER(?otherEntity != {$this->wd( $entityId )})
+  FILTER(?otherEntity != {$this->wd($entityId)})
 $deprecatedFilter
 }
 LIMIT 10
 SPARQL;
 
-		$results = [ $this->runQuery( $query, $this->primaryEndpoint ) ];
-		foreach ( $this->additionalEndpoints as $endpoint ) {
-			$results[] = $this->runQuery( $query, $endpoint );
+		$results = [$this->runQuery($query, $this->primaryEndpoint)];
+		foreach ($this->additionalEndpoints as $endpoint) {
+			$results[] = $this->runQuery($query, $endpoint);
 		}
 
-		return $this->getOtherEntities( $results );
+		return $this->getOtherEntities($results);
 	}
 
 	/**
@@ -513,13 +510,13 @@ 
 		$writer->start();
 		$writer->drain();
 		$placeholder1 = 'wbqc';
-		$placeholder2 = 'x' . wfRandomString( 32 );
-		$writer->about( $placeholder1, $placeholder2 );
+		$placeholder2 = 'x'.wfRandomString(32);
+		$writer->about($placeholder1, $placeholder2);
 
 		$propertyId = $snak->getPropertyId();
 		$pid = $propertyId->getSerialization();
-		$propertyRepository = $this->rdfVocabulary->getEntityRepositoryName( $propertyId );
-		$entityRepository = $this->rdfVocabulary->getEntityRepositoryName( $entityId );
+		$propertyRepository = $this->rdfVocabulary->getEntityRepositoryName($propertyId);
+		$entityRepository = $this->rdfVocabulary->getEntityRepositoryName($entityId);
 		$propertyNamespace = $this->rdfVocabulary->propertyNamespaceNames[$propertyRepository][$namespace];
 		$value = $snak->getDataValue();
 		if (
@@ -550,21 +547,21 @@ 
 				$writer,
 				$propertyNamespace,
 				$pid,
-				$this->propertyDataTypeLookup->getDataTypeIdForProperty( $propertyId ),
+				$this->propertyDataTypeLookup->getDataTypeIdForProperty($propertyId),
 				$this->rdfVocabulary->statementNamespaceNames[$entityRepository][RdfVocabulary::NS_VALUE], // should be unused
 				$snak
 			);
 		}
 
 		$triple = $writer->drain(); // wbqc:xRANDOM ps:PID "value". or similar
-		return trim( str_replace( "$placeholder1:$placeholder2", '', $triple ) );
+		return trim(str_replace("$placeholder1:$placeholder2", '', $triple));
 	}
 
 	/**
 	 * Return SPARQL code for a string literal with $text as content.
 	 */
-	private function stringLiteral( string $text ): string {
-		return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"';
+	private function stringLiteral(string $text): string {
+		return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"';
 	}
 
 	/**
@@ -574,26 +571,26 @@ 
 	 *
 	 * @return CachedEntityIds
 	 */
-	private function getOtherEntities( array $results ): CachedEntityIds {
+	private function getOtherEntities(array $results): CachedEntityIds {
 		$allResultBindings = [];
 		$metadatas = [];
 
-		foreach ( $results as $result ) {
+		foreach ($results as $result) {
 			$metadatas[] = $result->getMetadata();
-			$allResultBindings = array_merge( $allResultBindings, $result->getArray()['results']['bindings'] );
+			$allResultBindings = array_merge($allResultBindings, $result->getArray()['results']['bindings']);
 		}
 
 		$entityIds = array_map(
-			function ( $resultBindings ) {
+			function($resultBindings) {
 				$entityIRI = $resultBindings['otherEntity']['value'];
-				foreach ( $this->entityPrefixes as $entityPrefix ) {
-					$entityPrefixLength = strlen( $entityPrefix );
-					if ( substr( $entityIRI, 0, $entityPrefixLength ) === $entityPrefix ) {
+				foreach ($this->entityPrefixes as $entityPrefix) {
+					$entityPrefixLength = strlen($entityPrefix);
+					if (substr($entityIRI, 0, $entityPrefixLength) === $entityPrefix) {
 						try {
 							return $this->entityIdParser->parse(
-								substr( $entityIRI, $entityPrefixLength )
+								substr($entityIRI, $entityPrefixLength)
 							);
-						} catch ( EntityIdParsingException ) {
+						} catch (EntityIdParsingException) {
 							// fall through
 						}
 					}
@@ -607,8 +604,8 @@ 
 		);
 
 		return new CachedEntityIds(
-			array_values( array_filter( array_unique( $entityIds ) ) ),
-			Metadata::merge( $metadatas )
+			array_values(array_filter(array_unique($entityIds))),
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -616,63 +613,63 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpression( string $text, string $regex ): bool {
+	public function matchesRegularExpression(string $text, string $regex): bool {
 		// caching wrapper around matchesRegularExpressionWithSparql
 
-		$textHash = hash( 'sha256', $text );
+		$textHash = hash('sha256', $text);
 		$cacheKey = $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'regex', // action
 			'WDQS-Java', // regex flavor
-			hash( 'sha256', $regex )
+			hash('sha256', $regex)
 		);
 
 		$baseRegexCacheKey = 'wikibase.quality.constraints.regex.cache';
-		$metric = $this->statsFactory->getCounter( 'regex_cache_total' );
+		$metric = $this->statsFactory->getCounter('regex_cache_total');
 
 		$cacheMapArray = $this->cache->getWithSetCallback(
 			$cacheKey,
 			WANObjectCache::TTL_DAY,
-			function ( $cacheMapArray ) use ( $text, $regex, $textHash, $metric, $baseRegexCacheKey ) {
+			function($cacheMapArray) use ($text, $regex, $textHash, $metric, $baseRegexCacheKey) {
 				// Initialize the cache map if not set
-				if ( $cacheMapArray === false ) {
+				if ($cacheMapArray === false) {
 					$metric
-						->setLabel( 'operation', 'refresh' )
-						->setLabel( 'status', 'init' )
-						->copyToStatsdAt( [
+						->setLabel('operation', 'refresh')
+						->setLabel('status', 'init')
+						->copyToStatsdAt([
 							"$baseRegexCacheKey.refresh.init",
-						] )->increment();
+						])->increment();
 
 					return [];
 				}
 
-				$cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $this->cacheMapSize );
-				if ( $cacheMap->has( $textHash ) ) {
+				$cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $this->cacheMapSize);
+				if ($cacheMap->has($textHash)) {
 					$metric
-						->setLabel( 'operation', 'refresh' )
-						->setLabel( 'status', 'hit' )
-						->copyToStatsdAt( [
+						->setLabel('operation', 'refresh')
+						->setLabel('status', 'hit')
+						->copyToStatsdAt([
 							"$baseRegexCacheKey.refresh",
 							"$baseRegexCacheKey.refresh.hit",
-						] )
+						])
 						->increment();
 
-					$cacheMap->get( $textHash ); // ping cache
+					$cacheMap->get($textHash); // ping cache
 				} else {
 					$metric
-						->setLabel( 'operation', 'refresh' )
-						->setLabel( 'status', 'miss' )
-						->copyToStatsdAt( [
+						->setLabel('operation', 'refresh')
+						->setLabel('status', 'miss')
+						->copyToStatsdAt([
 							"$baseRegexCacheKey.refresh",
 							"$baseRegexCacheKey.refresh.miss",
-						] )
+						])
 						->increment();
 
 					try {
-						$matches = $this->matchesRegularExpressionWithSparql( $text, $regex );
-					} catch ( ConstraintParameterException $e ) {
-						$matches = $this->serializeConstraintParameterException( $e );
-					} catch ( SparqlHelperException ) {
+						$matches = $this->matchesRegularExpressionWithSparql($text, $regex);
+					} catch (ConstraintParameterException $e) {
+						$matches = $this->serializeConstraintParameterException($e);
+					} catch (SparqlHelperException) {
 						// don’t cache this
 						return $cacheMap->toArray();
 					}
@@ -696,54 +693,54 @@ 
 			]
 		);
 
-		if ( isset( $cacheMapArray[$textHash] ) ) {
+		if (isset($cacheMapArray[$textHash])) {
 			$metric
-				->setLabel( 'operation', 'none' )
-				->setLabel( 'status', 'hit' )
-				->copyToStatsdAt( [
+				->setLabel('operation', 'none')
+				->setLabel('status', 'hit')
+				->copyToStatsdAt([
 					"$baseRegexCacheKey.hit",
-				] )
+				])
 				->increment();
 
 			$matches = $cacheMapArray[$textHash];
-			if ( is_bool( $matches ) ) {
+			if (is_bool($matches)) {
 				return $matches;
-			} elseif ( is_array( $matches ) &&
-				$matches['type'] == ConstraintParameterException::class ) {
-				throw $this->deserializeConstraintParameterException( $matches );
+			} elseif (is_array($matches) &&
+				$matches['type'] == ConstraintParameterException::class) {
+				throw $this->deserializeConstraintParameterException($matches);
 			} else {
 				throw new UnexpectedValueException(
-					'Value of unknown type in object cache (' .
-					'cache key: ' . $cacheKey . ', ' .
-					'cache map key: ' . $textHash . ', ' .
-					'value type: ' . get_debug_type( $matches ) . ')'
+					'Value of unknown type in object cache ('.
+					'cache key: '.$cacheKey.', '.
+					'cache map key: '.$textHash.', '.
+					'value type: '.get_debug_type($matches).')'
 				);
 			}
 		} else {
 			$metric
-				->setLabel( 'operation', 'none' )
-				->setLabel( 'status', 'miss' )
-				->copyToStatsdAt( [
+				->setLabel('operation', 'none')
+				->setLabel('status', 'miss')
+				->copyToStatsdAt([
 					"$baseRegexCacheKey.miss",
-				] )
+				])
 				->increment();
 
-			return $this->matchesRegularExpressionWithSparql( $text, $regex );
+			return $this->matchesRegularExpressionWithSparql($text, $regex);
 		}
 	}
 
-	private function serializeConstraintParameterException( ConstraintParameterException $cpe ): array {
+	private function serializeConstraintParameterException(ConstraintParameterException $cpe): array {
 		return [
 			'type' => ConstraintParameterException::class,
-			'violationMessage' => $this->violationMessageSerializer->serialize( $cpe->getViolationMessage() ),
+			'violationMessage' => $this->violationMessageSerializer->serialize($cpe->getViolationMessage()),
 		];
 	}
 
-	private function deserializeConstraintParameterException( array $serialization ): ConstraintParameterException {
+	private function deserializeConstraintParameterException(array $serialization): ConstraintParameterException {
 		$message = $this->violationMessageDeserializer->deserialize(
 			$serialization['violationMessage']
 		);
-		return new ConstraintParameterException( $message );
+		return new ConstraintParameterException($message);
 	}
 
 	/**
@@ -753,25 +750,25 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpressionWithSparql( string $text, string $regex ): bool {
-		$textStringLiteral = $this->stringLiteral( $text );
-		$regexStringLiteral = $this->stringLiteral( '^(?:' . $regex . ')$' );
+	public function matchesRegularExpressionWithSparql(string $text, string $regex): bool {
+		$textStringLiteral = $this->stringLiteral($text);
+		$regexStringLiteral = $this->stringLiteral('^(?:'.$regex.')$');
 
 		$query = <<<EOF
 SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {}
 EOF;
 
-		$result = $this->runQuery( $query, $this->primaryEndpoint, false );
+		$result = $this->runQuery($query, $this->primaryEndpoint, false);
 
 		$vars = $result->getArray()['results']['bindings'][0];
-		if ( array_key_exists( 'matches', $vars ) ) {
+		if (array_key_exists('matches', $vars)) {
 			// true or false ⇒ regex okay, text matches or not
 			return $vars['matches']['value'] === 'true';
 		} else {
 			// empty result: regex broken
 			throw new ConstraintParameterException(
-				( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) )
-					->withInlineCode( $regex, Role::CONSTRAINT_PARAMETER_VALUE )
+				(new ViolationMessage('wbqc-violation-message-parameter-regex'))
+					->withInlineCode($regex, Role::CONSTRAINT_PARAMETER_VALUE)
 			);
 		}
 	}
@@ -779,14 +776,14 @@ 
 	/**
 	 * Check whether the text content of an error response indicates a query timeout.
 	 */
-	public function isTimeout( string $responseContent ): bool {
-		$timeoutRegex = implode( '|', array_map(
-			static function ( $fqn ) {
-				return preg_quote( $fqn, '/' );
+	public function isTimeout(string $responseContent): bool {
+		$timeoutRegex = implode('|', array_map(
+			static function($fqn) {
+				return preg_quote($fqn, '/');
 			},
 			$this->timeoutExceptionClasses
-		) );
-		return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent );
+		));
+		return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent);
 	}
 
 	/**
@@ -798,17 +795,17 @@ 
 	 * @return int|bool the max-age (in seconds)
 	 * or a plain boolean if no max-age can be determined
 	 */
-	public function getCacheMaxAge( array $responseHeaders ) {
+	public function getCacheMaxAge(array $responseHeaders) {
 		if (
-			array_key_exists( 'x-cache-status', $responseHeaders ) &&
-			preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] )
+			array_key_exists('x-cache-status', $responseHeaders) &&
+			preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0])
 		) {
 			$maxage = [];
 			if (
-				array_key_exists( 'cache-control', $responseHeaders ) &&
-				preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage )
+				array_key_exists('cache-control', $responseHeaders) &&
+				preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage)
 			) {
-				return intval( $maxage[1] );
+				return intval($maxage[1]);
 			} else {
 				return true;
 			}
@@ -829,34 +826,34 @@ 
 	 * or SparlHelper::EMPTY_RETRY_AFTER if there is an empty Retry-After
 	 * or SparlHelper::INVALID_RETRY_AFTER if there is something wrong with the format
 	 */
-	public function getThrottling( MWHttpRequest $request ) {
-		$retryAfterValue = $request->getResponseHeader( 'Retry-After' );
-		if ( $retryAfterValue === null ) {
+	public function getThrottling(MWHttpRequest $request) {
+		$retryAfterValue = $request->getResponseHeader('Retry-After');
+		if ($retryAfterValue === null) {
 			return self::NO_RETRY_AFTER;
 		}
 
-		$trimmedRetryAfterValue = trim( $retryAfterValue );
-		if ( $trimmedRetryAfterValue === '' ) {
+		$trimmedRetryAfterValue = trim($retryAfterValue);
+		if ($trimmedRetryAfterValue === '') {
 			return self::EMPTY_RETRY_AFTER;
 		}
 
-		if ( is_numeric( $trimmedRetryAfterValue ) ) {
-			$delaySeconds = (int)$trimmedRetryAfterValue;
-			if ( $delaySeconds >= 0 ) {
-				return $this->getTimestampInFuture( new DateInterval( 'PT' . $delaySeconds . 'S' ) );
+		if (is_numeric($trimmedRetryAfterValue)) {
+			$delaySeconds = (int) $trimmedRetryAfterValue;
+			if ($delaySeconds >= 0) {
+				return $this->getTimestampInFuture(new DateInterval('PT'.$delaySeconds.'S'));
 			}
 		} else {
-			$return = strtotime( $trimmedRetryAfterValue );
-			if ( $return !== false ) {
-				return new ConvertibleTimestamp( $return );
+			$return = strtotime($trimmedRetryAfterValue);
+			if ($return !== false) {
+				return new ConvertibleTimestamp($return);
 			}
 		}
 		return self::INVALID_RETRY_AFTER;
 	}
 
-	private function getTimestampInFuture( DateInterval $delta ): ConvertibleTimestamp {
+	private function getTimestampInFuture(DateInterval $delta): ConvertibleTimestamp {
 		$now = new ConvertibleTimestamp();
-		return new ConvertibleTimestamp( $now->timestamp->add( $delta ) );
+		return new ConvertibleTimestamp($now->timestamp->add($delta));
 	}
 
 	/**
@@ -871,110 +868,109 @@ 
 	 *
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	protected function runQuery( string $query, string $endpoint, bool $needsPrefixes = true ): CachedQueryResults {
+	protected function runQuery(string $query, string $endpoint, bool $needsPrefixes = true): CachedQueryResults {
 		$baseSPARQLKey = 'wikibase.quality.constraints.sparql';
 
-		if ( $this->throttlingLock->isLocked( self::EXPIRY_LOCK_ID ) ) {
+		if ($this->throttlingLock->isLocked(self::EXPIRY_LOCK_ID)) {
 			$this->statsFactory
-				->getCounter( 'sparql_throttling_total' )
-				->copyToStatsdAt( "$baseSPARQLKey.throttling" )
+				->getCounter('sparql_throttling_total')
+				->copyToStatsdAt("$baseSPARQLKey.throttling")
 				->increment();
 
 			throw new TooManySparqlRequestsException();
 		}
 
-		if ( $this->sparqlHasWikibaseSupport ) {
+		if ($this->sparqlHasWikibaseSupport) {
 			$needsPrefixes = false;
 		}
 
-		if ( $needsPrefixes ) {
-			$query = $this->prefixes . $query;
+		if ($needsPrefixes) {
+			$query = $this->prefixes.$query;
 		}
-		$query = "#wbqc\n" . $query;
+		$query = "#wbqc\n".$query;
 
-		$url = $endpoint . '?' . http_build_query(
+		$url = $endpoint.'?'.http_build_query(
 			[
 				'query' => $query,
 				'format' => 'json',
 				'maxQueryTimeMillis' => $this->maxQueryTimeMillis,
 			],
-			'', ini_get( 'arg_separator.output' ),
+			'', ini_get('arg_separator.output'),
 			// encode spaces with %20, not +
 			PHP_QUERY_RFC3986
 		);
 
 		$options = [
 			'method' => 'GET',
-			'timeout' => (int)round( ( $this->maxQueryTimeMillis + 1000 ) / 1000 ),
+			'timeout' => (int) round(($this->maxQueryTimeMillis + 1000) / 1000),
 			'connectTimeout' => 'default',
 			'userAgent' => $this->defaultUserAgent,
 		];
-		$request = $this->requestFactory->create( $url, $options, __METHOD__ );
+		$request = $this->requestFactory->create($url, $options, __METHOD__);
 
 		$timing = $this->statsFactory
-			->getTiming( 'sparql_runQuery_duration_seconds' )
-			->copyToStatsdAt( "$baseSPARQLKey.timing" );
+			->getTiming('sparql_runQuery_duration_seconds')
+			->copyToStatsdAt("$baseSPARQLKey.timing");
 
 		$timing->start();
 		$requestStatus = $request->execute();
 		$timing->stop();
 
-		$this->guardAgainstTooManyRequestsError( $request );
+		$this->guardAgainstTooManyRequestsError($request);
 
-		$maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() );
-		if ( $maxAge ) {
-			$this->statsFactory->getCounter( 'sparql_cached_total' )
-				->copyToStatsdAt( "$baseSPARQLKey.cached" )
+		$maxAge = $this->getCacheMaxAge($request->getResponseHeaders());
+		if ($maxAge) {
+			$this->statsFactory->getCounter('sparql_cached_total')
+				->copyToStatsdAt("$baseSPARQLKey.cached")
 				->increment();
 		}
 
 		$sparqlErrorKey = "$baseSPARQLKey.error";
-		$metric = $this->statsFactory->getCounter( 'sparql_error_total' );
-		if ( $requestStatus->isOK() ) {
+		$metric = $this->statsFactory->getCounter('sparql_error_total');
+		if ($requestStatus->isOK()) {
 			$json = $request->getContent();
-			$jsonStatus = FormatJson::parse( $json, FormatJson::FORCE_ASSOC );
+			$jsonStatus = FormatJson::parse($json, FormatJson::FORCE_ASSOC);
 			'@phan-var \MediaWiki\Status\Status<array> $jsonStatus';
-			if ( $jsonStatus->isOK() ) {
+			if ($jsonStatus->isOK()) {
 				return new CachedQueryResults(
 					$jsonStatus->getValue(),
 					Metadata::ofCachingMetadata(
 						$maxAge ?
-							CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) :
-							CachingMetadata::fresh()
+							CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh()
 					)
 				);
 			} else {
 				$jsonErrorCode = $jsonStatus->getErrors()[0]['message'];
 				$metric
-					->setLabel( 'type', 'json' )
-					->setLabel( 'code', "$jsonErrorCode" )
-					->copyToStatsdAt( [
+					->setLabel('type', 'json')
+					->setLabel('code', "$jsonErrorCode")
+					->copyToStatsdAt([
 						"$sparqlErrorKey",
 						"$sparqlErrorKey.json.$jsonErrorCode",
-					] )
+					])
 					->increment();
 				// fall through to general error handling
 			}
 		} else {
 			$metric
-				->setLabel( 'type', 'http' )
-				->setLabel( 'code', "{$request->getStatus()}" )
-				->copyToStatsdAt( [
+				->setLabel('type', 'http')
+				->setLabel('code', "{$request->getStatus()}")
+				->copyToStatsdAt([
 					"$sparqlErrorKey",
 					"$sparqlErrorKey.http.{$request->getStatus()}",
-				] )
+				])
 				->increment();
 			// fall through to general error handling
 		}
 
-		if ( $this->isTimeout( $request->getContent() ) ) {
+		if ($this->isTimeout($request->getContent())) {
 			$metric
-				->setLabel( 'type', 'timeout' )
-				->setLabel( 'code', 'none' )
-				->copyToStatsdAt( [
+				->setLabel('type', 'timeout')
+				->setLabel('code', 'none')
+				->copyToStatsdAt([
 					"$sparqlErrorKey",
 					"$sparqlErrorKey.timeout",
-				] )
+				])
 				->increment();
 		}
 
@@ -987,33 +983,33 @@ 
 	 * @param MWHttpRequest $request
 	 * @throws TooManySparqlRequestsException
 	 */
-	private function guardAgainstTooManyRequestsError( MWHttpRequest $request ): void {
-		if ( $request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS ) {
+	private function guardAgainstTooManyRequestsError(MWHttpRequest $request): void {
+		if ($request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS) {
 			return;
 		}
 
 		$fallbackBlockDuration = $this->sparqlThrottlingFallbackDuration;
 
-		if ( $fallbackBlockDuration < 0 ) {
-			throw new InvalidArgumentException( 'Fallback duration must be positive int but is: ' .
-				$fallbackBlockDuration );
+		if ($fallbackBlockDuration < 0) {
+			throw new InvalidArgumentException('Fallback duration must be positive int but is: '.
+				$fallbackBlockDuration);
 		}
 
 		$throttlingKey = "wikibase.quality.constraints.sparql.throttling";
-		$this->statsFactory->getCounter( 'sparql_throttling_total' )
-			->copyToStatsdAt( $throttlingKey )
+		$this->statsFactory->getCounter('sparql_throttling_total')
+			->copyToStatsdAt($throttlingKey)
 			->increment();
 
-		$throttlingUntil = $this->getThrottling( $request );
-		if ( !( $throttlingUntil instanceof ConvertibleTimestamp ) ) {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid( $request );
+		$throttlingUntil = $this->getThrottling($request);
+		if (!($throttlingUntil instanceof ConvertibleTimestamp)) {
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid($request);
 			$this->throttlingLock->lock(
 				self::EXPIRY_LOCK_ID,
-				$this->getTimestampInFuture( new DateInterval( 'PT' . $fallbackBlockDuration . 'S' ) )
+				$this->getTimestampInFuture(new DateInterval('PT'.$fallbackBlockDuration.'S'))
 			);
 		} else {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent( $throttlingUntil, $request );
-			$this->throttlingLock->lock( self::EXPIRY_LOCK_ID, $throttlingUntil );
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent($throttlingUntil, $request);
+			$this->throttlingLock->lock(self::EXPIRY_LOCK_ID, $throttlingUntil);
 		}
 		throw new TooManySparqlRequestsException();
 	}

src/Api/CheckConstraintParameters.php

Spacing +49 added lines, -49 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Api;
 
@@ -65,7 +65,7 @@ 
 			$delegatingConstraintChecker,
 			$violationMessageRendererFactory,
 			$statementGuidParser,
-			$statsFactory->withComponent( 'WikibaseQualityConstraints' )
+			$statsFactory->withComponent('WikibaseQualityConstraints')
 		);
 	}
 
@@ -79,9 +79,9 @@ 
 		StatementGuidParser $statementGuidParser,
 		StatsFactory $statsFactory
 	) {
-		parent::__construct( $main, $name );
+		parent::__construct($main, $name);
 
-		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter( $this );
+		$this->apiErrorReporter = $apiHelperFactory->getErrorReporter($this);
 		$this->languageFallbackChainFactory = $languageFallbackChainFactory;
 		$this->delegatingConstraintChecker = $delegatingConstraintChecker;
 		$this->violationMessageRendererFactory = $violationMessageRendererFactory;
@@ -90,45 +90,45 @@ 
 	}
 
 	public function execute() {
-		$this->statsFactory->getCounter( 'check_constraint_parameters_execute_total' )
+		$this->statsFactory->getCounter('check_constraint_parameters_execute_total')
 			->increment();
 
 		$params = $this->extractRequestParams();
 		$result = $this->getResult();
 
-		$propertyIds = $this->parsePropertyIds( $params[self::PARAM_PROPERTY_ID] );
-		$constraintIds = $this->parseConstraintIds( $params[self::PARAM_CONSTRAINT_ID] );
+		$propertyIds = $this->parsePropertyIds($params[self::PARAM_PROPERTY_ID]);
+		$constraintIds = $this->parseConstraintIds($params[self::PARAM_CONSTRAINT_ID]);
 
-		$this->checkPropertyIds( $propertyIds, $result );
-		$this->checkConstraintIds( $constraintIds, $result );
+		$this->checkPropertyIds($propertyIds, $result);
+		$this->checkConstraintIds($constraintIds, $result);
 
-		$result->addValue( null, 'success', 1 );
+		$result->addValue(null, 'success', 1);
 	}
 
 	/**
 	 * @param array|null $propertyIdSerializations
 	 * @return NumericPropertyId[]
 	 */
-	private function parsePropertyIds( ?array $propertyIdSerializations ): array {
-		if ( $propertyIdSerializations === null ) {
+	private function parsePropertyIds(?array $propertyIdSerializations): array {
+		if ($propertyIdSerializations === null) {
 			return [];
-		} elseif ( $propertyIdSerializations === [] ) {
+		} elseif ($propertyIdSerializations === []) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_PROPERTY_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_PROPERTY_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $propertyIdSerialization ) {
+			function($propertyIdSerialization) {
 				try {
-					return new NumericPropertyId( $propertyIdSerialization );
-				} catch ( InvalidArgumentException ) {
+					return new NumericPropertyId($propertyIdSerialization);
+				} catch (InvalidArgumentException) {
 					$this->apiErrorReporter->dieError(
 						"Invalid id: $propertyIdSerialization",
 						'invalid-property-id',
 						0, // default argument
-						[ self::PARAM_PROPERTY_ID => $propertyIdSerialization ]
+						[self::PARAM_PROPERTY_ID => $propertyIdSerialization]
 					);
 				}
 			},
@@ -140,35 +140,35 @@ 
 	 * @param array|null $constraintIds
 	 * @return string[]
 	 */
-	private function parseConstraintIds( ?array $constraintIds ): array {
-		if ( $constraintIds === null ) {
+	private function parseConstraintIds(?array $constraintIds): array {
+		if ($constraintIds === null) {
 			return [];
-		} elseif ( $constraintIds === [] ) {
+		} elseif ($constraintIds === []) {
 			$this->apiErrorReporter->dieError(
-				'If ' . self::PARAM_CONSTRAINT_ID . ' is specified, it must be nonempty.',
+				'If '.self::PARAM_CONSTRAINT_ID.' is specified, it must be nonempty.',
 				'no-data'
 			);
 		}
 
 		return array_map(
-			function ( $constraintId ) {
+			function($constraintId) {
 				try {
-					$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
-					if ( !$propertyId instanceof NumericPropertyId ) {
+					$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
+					if (!$propertyId instanceof NumericPropertyId) {
 						$this->apiErrorReporter->dieError(
 							"Invalid property ID: {$propertyId->getSerialization()}",
 							'invalid-property-id',
 							0, // default argument
-							[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+							[self::PARAM_CONSTRAINT_ID => $constraintId]
 						);
 					}
 					return $constraintId;
-				} catch ( StatementGuidParsingException ) {
+				} catch (StatementGuidParsingException) {
 					$this->apiErrorReporter->dieError(
 						"Invalid statement GUID: $constraintId",
 						'invalid-guid',
 						0, // default argument
-						[ self::PARAM_CONSTRAINT_ID => $constraintId ]
+						[self::PARAM_CONSTRAINT_ID => $constraintId]
 					);
 				}
 			},
@@ -180,12 +180,12 @@ 
 	 * @param NumericPropertyId[] $propertyIds
 	 * @param ApiResult $result
 	 */
-	private function checkPropertyIds( array $propertyIds, ApiResult $result ): void {
-		foreach ( $propertyIds as $propertyId ) {
-			$result->addArrayType( $this->getResultPathForPropertyId( $propertyId ), 'assoc' );
+	private function checkPropertyIds(array $propertyIds, ApiResult $result): void {
+		foreach ($propertyIds as $propertyId) {
+			$result->addArrayType($this->getResultPathForPropertyId($propertyId), 'assoc');
 			$allConstraintExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnPropertyId( $propertyId );
-			foreach ( $allConstraintExceptions as $constraintId => $constraintParameterExceptions ) {
+				->checkConstraintParametersOnPropertyId($propertyId);
+			foreach ($allConstraintExceptions as $constraintId => $constraintParameterExceptions) {
 				$this->addConstraintParameterExceptionsToResult(
 					$constraintId,
 					$constraintParameterExceptions,
@@ -199,15 +199,15 @@ 
 	 * @param string[] $constraintIds
 	 * @param ApiResult $result
 	 */
-	private function checkConstraintIds( array $constraintIds, ApiResult $result ): void {
-		foreach ( $constraintIds as $constraintId ) {
-			if ( $result->getResultData( $this->getResultPathForConstraintId( $constraintId ) ) ) {
+	private function checkConstraintIds(array $constraintIds, ApiResult $result): void {
+		foreach ($constraintIds as $constraintId) {
+			if ($result->getResultData($this->getResultPathForConstraintId($constraintId))) {
 				// already checked as part of checkPropertyIds()
 				continue;
 			}
 			$constraintParameterExceptions = $this->delegatingConstraintChecker
-				->checkConstraintParametersOnConstraintId( $constraintId );
-			$this->addConstraintParameterExceptionsToResult( $constraintId, $constraintParameterExceptions, $result );
+				->checkConstraintParametersOnConstraintId($constraintId);
+			$this->addConstraintParameterExceptionsToResult($constraintId, $constraintParameterExceptions, $result);
 		}
 	}
 
@@ -215,18 +215,18 @@ 
 	 * @param NumericPropertyId $propertyId
 	 * @return string[]
 	 */
-	private function getResultPathForPropertyId( NumericPropertyId $propertyId ): array {
-		return [ $this->getModuleName(), $propertyId->getSerialization() ];
+	private function getResultPathForPropertyId(NumericPropertyId $propertyId): array {
+		return [$this->getModuleName(), $propertyId->getSerialization()];
 	}
 
 	/**
 	 * @param string $constraintId
 	 * @return string[]
 	 */
-	private function getResultPathForConstraintId( string $constraintId ): array {
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
+	private function getResultPathForConstraintId(string $constraintId): array {
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
 		'@phan-var NumericPropertyId $propertyId';
-		return array_merge( $this->getResultPathForPropertyId( $propertyId ), [ $constraintId ] );
+		return array_merge($this->getResultPathForPropertyId($propertyId), [$constraintId]);
 	}
 
 	/**
@@ -241,8 +241,8 @@ 
 		?array $constraintParameterExceptions,
 		ApiResult $result
 	): void {
-		$path = $this->getResultPathForConstraintId( $constraintId );
-		if ( $constraintParameterExceptions === null ) {
+		$path = $this->getResultPathForConstraintId($constraintId);
+		if ($constraintParameterExceptions === null) {
 			$result->addValue(
 				$path,
 				self::KEY_STATUS,
@@ -259,11 +259,11 @@ 
 			$violationMessageRenderer = $this->violationMessageRendererFactory
 				->getViolationMessageRenderer(
 					$language,
-					$this->languageFallbackChainFactory->newFromLanguage( $language ),
+					$this->languageFallbackChainFactory->newFromLanguage($language),
 					$this
 				);
 			$problems = [];
-			foreach ( $constraintParameterExceptions as $constraintParameterException ) {
+			foreach ($constraintParameterExceptions as $constraintParameterException) {
 				$problems[] = [
 					self::KEY_MESSAGE_HTML => $violationMessageRenderer->render(
 						$constraintParameterException->getViolationMessage() ),
@@ -302,8 +302,8 @@ 
 		return [
 			'action=wbcheckconstraintparameters&propertyid=P247'
 				=> 'apihelp-wbcheckconstraintparameters-example-propertyid-1',
-			'action=wbcheckconstraintparameters&' .
-			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|' .
+			'action=wbcheckconstraintparameters&'.
+			'constraintid=P247$0fe1711e-4c0f-82ce-3af0-830b721d0fba|'.
 			'P225$cdc71e4a-47a0-12c5-dfb3-3f6fc0b6613f'
 				=> 'apihelp-wbcheckconstraintparameters-example-constraintid-2',
 		];