@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context; |
| 6 | 6 | |
@@ -21,7 +21,7 @@ discard block |
||
| 21 | 21 | |
| 22 | 22 | protected Snak $snak; |
| 23 | 23 | |
| 24 | - public function __construct( StatementListProvidingEntity $entity, Snak $snak ) { |
|
| 24 | + public function __construct(StatementListProvidingEntity $entity, Snak $snak) { |
|
| 25 | 25 | $this->entity = $entity; |
| 26 | 26 | $this->snak = $snak; |
| 27 | 27 | } |
@@ -47,15 +47,15 @@ discard block |
||
| 47 | 47 | // unimplemented: getCursor |
| 48 | 48 | |
| 49 | 49 | /** Helper function for {@link getCursor()} implementations. */ |
| 50 | - protected function getStatementGuid( Statement $statement ): string { |
|
| 50 | + protected function getStatementGuid(Statement $statement): string { |
|
| 51 | 51 | $guid = $statement->getGuid(); |
| 52 | - if ( $guid === null ) { |
|
| 53 | - if ( defined( 'MW_PHPUNIT_TEST' ) ) { |
|
| 52 | + if ($guid === null) { |
|
| 53 | + if (defined('MW_PHPUNIT_TEST')) { |
|
| 54 | 54 | // let unit tests get away with not specifying a statement GUID: |
| 55 | 55 | // much more convenient to fake it here than to add one to all tests |
| 56 | 56 | return 'Q0$DEADBEEF-DEAD-BEEF-DEAD-BEEFDEADBEEF'; |
| 57 | 57 | } else { |
| 58 | - throw new InvalidArgumentException( 'Statement for Context must have a GUID' ); |
|
| 58 | + throw new InvalidArgumentException('Statement for Context must have a GUID'); |
|
| 59 | 59 | } |
| 60 | 60 | } |
| 61 | 61 | return $guid; |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context; |
| 6 | 6 | |
@@ -21,8 +21,8 @@ discard block |
||
| 21 | 21 | |
| 22 | 22 | private Statement $statement; |
| 23 | 23 | |
| 24 | - public function __construct( StatementListProvidingEntity $entity, Statement $statement ) { |
|
| 25 | - parent::__construct( $entity, $statement->getMainSnak() ); |
|
| 24 | + public function __construct(StatementListProvidingEntity $entity, Statement $statement) { |
|
| 25 | + parent::__construct($entity, $statement->getMainSnak()); |
|
| 26 | 26 | |
| 27 | 27 | $this->statement = $statement; |
| 28 | 28 | } |
@@ -39,21 +39,21 @@ discard block |
||
| 39 | 39 | return $this->statement; |
| 40 | 40 | } |
| 41 | 41 | |
| 42 | - public function getSnakGroup( string $groupingMode, array $separators = [] ): array { |
|
| 42 | + public function getSnakGroup(string $groupingMode, array $separators = []): array { |
|
| 43 | 43 | /** @var StatementList $statements */ |
| 44 | 44 | $statements = $this->entity->getStatements(); |
| 45 | - switch ( $groupingMode ) { |
|
| 45 | + switch ($groupingMode) { |
|
| 46 | 46 | case Context::GROUP_NON_DEPRECATED: |
| 47 | - $statements = $statements->getByRank( [ |
|
| 47 | + $statements = $statements->getByRank([ |
|
| 48 | 48 | Statement::RANK_NORMAL, |
| 49 | 49 | Statement::RANK_PREFERRED, |
| 50 | - ] ); |
|
| 50 | + ]); |
|
| 51 | 51 | break; |
| 52 | 52 | case Context::GROUP_BEST_RANK: |
| 53 | - $statements = $this->getBestStatementsPerPropertyId( $statements ); |
|
| 53 | + $statements = $this->getBestStatementsPerPropertyId($statements); |
|
| 54 | 54 | break; |
| 55 | 55 | default: |
| 56 | - throw new LogicException( 'Unknown $groupingMode ' . $groupingMode ); |
|
| 56 | + throw new LogicException('Unknown $groupingMode '.$groupingMode); |
|
| 57 | 57 | } |
| 58 | 58 | return $this->getStatementsWithSameQualifiersForProperties( |
| 59 | 59 | $this->statement, |
@@ -62,13 +62,13 @@ discard block |
||
| 62 | 62 | )->getMainSnaks(); |
| 63 | 63 | } |
| 64 | 64 | |
| 65 | - private function getBestStatementsPerPropertyId( StatementList $statements ): StatementList { |
|
| 65 | + private function getBestStatementsPerPropertyId(StatementList $statements): StatementList { |
|
| 66 | 66 | $allBestStatements = new StatementList(); |
| 67 | - foreach ( $statements->getPropertyIds() as $propertyId ) { |
|
| 68 | - $bestStatements = $statements->getByPropertyId( $propertyId ) |
|
| 67 | + foreach ($statements->getPropertyIds() as $propertyId) { |
|
| 68 | + $bestStatements = $statements->getByPropertyId($propertyId) |
|
| 69 | 69 | ->getBestStatements(); |
| 70 | - foreach ( $bestStatements as $bestStatement ) { |
|
| 71 | - $allBestStatements->addStatement( $bestStatement ); |
|
| 70 | + foreach ($bestStatements as $bestStatement) { |
|
| 71 | + $allBestStatements->addStatement($bestStatement); |
|
| 72 | 72 | } |
| 73 | 73 | } |
| 74 | 74 | return $allBestStatements; |
@@ -90,20 +90,20 @@ discard block |
||
| 90 | 90 | array $qualifierPropertyIds |
| 91 | 91 | ): StatementList { |
| 92 | 92 | $similarStatements = new StatementList(); |
| 93 | - foreach ( $allStatements as $statement ) { |
|
| 94 | - if ( $statement === $currentStatement ) { |
|
| 93 | + foreach ($allStatements as $statement) { |
|
| 94 | + if ($statement === $currentStatement) { |
|
| 95 | 95 | // if the statement has an “unknown value” qualifier, |
| 96 | 96 | // it might be considered different from itself, |
| 97 | 97 | // so add it explicitly to ensure it’s always included |
| 98 | - $similarStatements->addStatement( $statement ); |
|
| 98 | + $similarStatements->addStatement($statement); |
|
| 99 | 99 | continue; |
| 100 | 100 | } |
| 101 | - foreach ( $qualifierPropertyIds as $qualifierPropertyId ) { |
|
| 102 | - if ( !$this->haveSameQualifiers( $currentStatement, $statement, $qualifierPropertyId ) ) { |
|
| 101 | + foreach ($qualifierPropertyIds as $qualifierPropertyId) { |
|
| 102 | + if (!$this->haveSameQualifiers($currentStatement, $statement, $qualifierPropertyId)) { |
|
| 103 | 103 | continue 2; |
| 104 | 104 | } |
| 105 | 105 | } |
| 106 | - $similarStatements->addStatement( $statement ); |
|
| 106 | + $similarStatements->addStatement($statement); |
|
| 107 | 107 | } |
| 108 | 108 | return $similarStatements; |
| 109 | 109 | } |
@@ -112,19 +112,19 @@ discard block |
||
| 112 | 112 | * Tests whether two statements have the same qualifiers with a certain property ID. |
| 113 | 113 | * “unknown value” qualifiers are considered different from each other. |
| 114 | 114 | */ |
| 115 | - private function haveSameQualifiers( Statement $s1, Statement $s2, PropertyId $propertyId ): bool { |
|
| 116 | - $q1 = $this->getSnaksWithPropertyId( $s1->getQualifiers(), $propertyId ); |
|
| 117 | - $q2 = $this->getSnaksWithPropertyId( $s2->getQualifiers(), $propertyId ); |
|
| 115 | + private function haveSameQualifiers(Statement $s1, Statement $s2, PropertyId $propertyId): bool { |
|
| 116 | + $q1 = $this->getSnaksWithPropertyId($s1->getQualifiers(), $propertyId); |
|
| 117 | + $q2 = $this->getSnaksWithPropertyId($s2->getQualifiers(), $propertyId); |
|
| 118 | 118 | |
| 119 | - if ( $q1->count() !== $q2->count() ) { |
|
| 119 | + if ($q1->count() !== $q2->count()) { |
|
| 120 | 120 | return false; |
| 121 | 121 | } |
| 122 | 122 | |
| 123 | - foreach ( $q1 as $qualifier ) { |
|
| 124 | - switch ( $qualifier->getType() ) { |
|
| 123 | + foreach ($q1 as $qualifier) { |
|
| 124 | + switch ($qualifier->getType()) { |
|
| 125 | 125 | case 'value': |
| 126 | 126 | case 'novalue': |
| 127 | - if ( !$q2->hasSnak( $qualifier ) ) { |
|
| 127 | + if (!$q2->hasSnak($qualifier)) { |
|
| 128 | 128 | return false; |
| 129 | 129 | } |
| 130 | 130 | break; |
@@ -142,12 +142,12 @@ discard block |
||
| 142 | 142 | /** |
| 143 | 143 | * Returns the snaks of the given snak list with the specified property ID. |
| 144 | 144 | */ |
| 145 | - private function getSnaksWithPropertyId( SnakList $allSnaks, PropertyId $propertyId ): SnakList { |
|
| 145 | + private function getSnaksWithPropertyId(SnakList $allSnaks, PropertyId $propertyId): SnakList { |
|
| 146 | 146 | $snaks = new SnakList(); |
| 147 | 147 | /** @var Snak $snak */ |
| 148 | - foreach ( $allSnaks as $snak ) { |
|
| 149 | - if ( $snak->getPropertyId()->equals( $propertyId ) ) { |
|
| 150 | - $snaks->addSnak( $snak ); |
|
| 148 | + foreach ($allSnaks as $snak) { |
|
| 149 | + if ($snak->getPropertyId()->equals($propertyId)) { |
|
| 150 | + $snaks->addSnak($snak); |
|
| 151 | 151 | } |
| 152 | 152 | } |
| 153 | 153 | return $snaks; |
@@ -157,7 +157,7 @@ discard block |
||
| 157 | 157 | return new MainSnakContextCursor( |
| 158 | 158 | $this->entity->getId()->getSerialization(), |
| 159 | 159 | $this->statement->getPropertyId()->getSerialization(), |
| 160 | - $this->getStatementGuid( $this->statement ), |
|
| 160 | + $this->getStatementGuid($this->statement), |
|
| 161 | 161 | $this->statement->getMainSnak()->getHash() |
| 162 | 162 | ); |
| 163 | 163 | } |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result; |
| 6 | 6 | |
@@ -27,22 +27,22 @@ discard block |
||
| 27 | 27 | */ |
| 28 | 28 | private const NULL_PROPERTY_ID = 'P2147483647'; |
| 29 | 29 | |
| 30 | - public function __construct( ContextCursor $contextCursor ) { |
|
| 30 | + public function __construct(ContextCursor $contextCursor) { |
|
| 31 | 31 | $constraint = new Constraint( |
| 32 | 32 | 'null', |
| 33 | - new NumericPropertyId( self::NULL_PROPERTY_ID ), |
|
| 33 | + new NumericPropertyId(self::NULL_PROPERTY_ID), |
|
| 34 | 34 | 'none', |
| 35 | 35 | [] |
| 36 | 36 | ); |
| 37 | - parent::__construct( $contextCursor, $constraint ); |
|
| 37 | + parent::__construct($contextCursor, $constraint); |
|
| 38 | 38 | } |
| 39 | 39 | |
| 40 | 40 | public function getConstraint(): Constraint { |
| 41 | - throw new DomainException( 'NullResult holds no constraint' ); |
|
| 41 | + throw new DomainException('NullResult holds no constraint'); |
|
| 42 | 42 | } |
| 43 | 43 | |
| 44 | 44 | public function getConstraintId(): string { |
| 45 | - throw new DomainException( 'NullResult holds no constraint' ); |
|
| 45 | + throw new DomainException('NullResult holds no constraint'); |
|
| 46 | 46 | } |
| 47 | 47 | |
| 48 | 48 | } |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\Api; |
| 6 | 6 | |
@@ -81,11 +81,11 @@ discard block |
||
| 81 | 81 | CheckResultsRendererFactory $checkResultsRendererFactory, |
| 82 | 82 | IBufferingStatsdDataFactory $dataFactory |
| 83 | 83 | ) { |
| 84 | - parent::__construct( $main, $name ); |
|
| 84 | + parent::__construct($main, $name); |
|
| 85 | 85 | $this->entityIdParser = $entityIdParser; |
| 86 | 86 | $this->statementGuidValidator = $statementGuidValidator; |
| 87 | - $this->resultBuilder = $apiHelperFactory->getResultBuilder( $this ); |
|
| 88 | - $this->errorReporter = $apiHelperFactory->getErrorReporter( $this ); |
|
| 87 | + $this->resultBuilder = $apiHelperFactory->getResultBuilder($this); |
|
| 88 | + $this->errorReporter = $apiHelperFactory->getErrorReporter($this); |
|
| 89 | 89 | $this->resultsSource = $resultsSource; |
| 90 | 90 | $this->checkResultsRendererFactory = $checkResultsRendererFactory; |
| 91 | 91 | $this->dataFactory = $dataFactory; |
@@ -101,14 +101,14 @@ discard block |
||
| 101 | 101 | |
| 102 | 102 | $params = $this->extractRequestParams(); |
| 103 | 103 | |
| 104 | - $this->validateParameters( $params ); |
|
| 105 | - $entityIds = $this->parseEntityIds( $params ); |
|
| 106 | - $claimIds = $this->parseClaimIds( $params ); |
|
| 104 | + $this->validateParameters($params); |
|
| 105 | + $entityIds = $this->parseEntityIds($params); |
|
| 106 | + $claimIds = $this->parseClaimIds($params); |
|
| 107 | 107 | $constraintIDs = $params[self::PARAM_CONSTRAINT_ID]; |
| 108 | 108 | $statuses = $params[self::PARAM_STATUS]; |
| 109 | 109 | |
| 110 | 110 | $checkResultsRenderer = $this->checkResultsRendererFactory |
| 111 | - ->getCheckResultsRenderer( $this->getLanguage(), $this ); |
|
| 111 | + ->getCheckResultsRenderer($this->getLanguage(), $this); |
|
| 112 | 112 | |
| 113 | 113 | $this->getResult()->addValue( |
| 114 | 114 | null, |
@@ -122,7 +122,7 @@ discard block |
||
| 122 | 122 | ) |
| 123 | 123 | )->getArray() |
| 124 | 124 | ); |
| 125 | - $this->resultBuilder->markSuccess( 1 ); |
|
| 125 | + $this->resultBuilder->markSuccess(1); |
|
| 126 | 126 | } |
| 127 | 127 | |
| 128 | 128 | /** |
@@ -130,24 +130,24 @@ discard block |
||
| 130 | 130 | * |
| 131 | 131 | * @return EntityId[] |
| 132 | 132 | */ |
| 133 | - private function parseEntityIds( array $params ): array { |
|
| 133 | + private function parseEntityIds(array $params): array { |
|
| 134 | 134 | $ids = $params[self::PARAM_ID]; |
| 135 | 135 | |
| 136 | - if ( $ids === null ) { |
|
| 136 | + if ($ids === null) { |
|
| 137 | 137 | return []; |
| 138 | - } elseif ( $ids === [] ) { |
|
| 138 | + } elseif ($ids === []) { |
|
| 139 | 139 | $this->errorReporter->dieError( |
| 140 | - 'If ' . self::PARAM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
| 140 | + 'If '.self::PARAM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
| 141 | 141 | } |
| 142 | 142 | |
| 143 | - return array_map( function ( $id ) { |
|
| 143 | + return array_map(function($id) { |
|
| 144 | 144 | try { |
| 145 | - return $this->entityIdParser->parse( $id ); |
|
| 146 | - } catch ( EntityIdParsingException $e ) { |
|
| 145 | + return $this->entityIdParser->parse($id); |
|
| 146 | + } catch (EntityIdParsingException $e) { |
|
| 147 | 147 | $this->errorReporter->dieError( |
| 148 | - "Invalid id: $id", 'invalid-entity-id', 0, [ self::PARAM_ID => $id ] ); |
|
| 148 | + "Invalid id: $id", 'invalid-entity-id', 0, [self::PARAM_ID => $id] ); |
|
| 149 | 149 | } |
| 150 | - }, $ids ); |
|
| 150 | + }, $ids); |
|
| 151 | 151 | } |
| 152 | 152 | |
| 153 | 153 | /** |
@@ -155,35 +155,35 @@ discard block |
||
| 155 | 155 | * |
| 156 | 156 | * @return string[] |
| 157 | 157 | */ |
| 158 | - private function parseClaimIds( array $params ): array { |
|
| 158 | + private function parseClaimIds(array $params): array { |
|
| 159 | 159 | $ids = $params[self::PARAM_CLAIM_ID]; |
| 160 | 160 | |
| 161 | - if ( $ids === null ) { |
|
| 161 | + if ($ids === null) { |
|
| 162 | 162 | return []; |
| 163 | - } elseif ( $ids === [] ) { |
|
| 163 | + } elseif ($ids === []) { |
|
| 164 | 164 | $this->errorReporter->dieError( |
| 165 | - 'If ' . self::PARAM_CLAIM_ID . ' is specified, it must be nonempty.', 'no-data' ); |
|
| 165 | + 'If '.self::PARAM_CLAIM_ID.' is specified, it must be nonempty.', 'no-data' ); |
|
| 166 | 166 | } |
| 167 | 167 | |
| 168 | - foreach ( $ids as $id ) { |
|
| 169 | - if ( !$this->statementGuidValidator->validate( $id ) ) { |
|
| 168 | + foreach ($ids as $id) { |
|
| 169 | + if (!$this->statementGuidValidator->validate($id)) { |
|
| 170 | 170 | $this->errorReporter->dieError( |
| 171 | - "Invalid claim id: $id", 'invalid-guid', 0, [ self::PARAM_CLAIM_ID => $id ] ); |
|
| 171 | + "Invalid claim id: $id", 'invalid-guid', 0, [self::PARAM_CLAIM_ID => $id] ); |
|
| 172 | 172 | } |
| 173 | 173 | } |
| 174 | 174 | |
| 175 | 175 | return $ids; |
| 176 | 176 | } |
| 177 | 177 | |
| 178 | - private function validateParameters( array $params ): void { |
|
| 179 | - if ( $params[self::PARAM_CONSTRAINT_ID] !== null |
|
| 180 | - && empty( $params[self::PARAM_CONSTRAINT_ID] ) |
|
| 178 | + private function validateParameters(array $params): void { |
|
| 179 | + if ($params[self::PARAM_CONSTRAINT_ID] !== null |
|
| 180 | + && empty($params[self::PARAM_CONSTRAINT_ID]) |
|
| 181 | 181 | ) { |
| 182 | 182 | $paramConstraintId = self::PARAM_CONSTRAINT_ID; |
| 183 | 183 | $this->errorReporter->dieError( |
| 184 | 184 | "If $paramConstraintId is specified, it must be nonempty.", 'no-data' ); |
| 185 | 185 | } |
| 186 | - if ( $params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null ) { |
|
| 186 | + if ($params[self::PARAM_ID] === null && $params[self::PARAM_CLAIM_ID] === null) { |
|
| 187 | 187 | $paramId = self::PARAM_ID; |
| 188 | 188 | $paramClaimId = self::PARAM_CLAIM_ID; |
| 189 | 189 | $this->errorReporter->dieError( |
@@ -224,7 +224,7 @@ discard block |
||
| 224 | 224 | ], |
| 225 | 225 | ParamValidator::PARAM_ISMULTI => true, |
| 226 | 226 | ParamValidator::PARAM_ALL => true, |
| 227 | - ParamValidator::PARAM_DEFAULT => implode( '|', CachingResultsSource::CACHED_STATUSES ), |
|
| 227 | + ParamValidator::PARAM_DEFAULT => implode('|', CachingResultsSource::CACHED_STATUSES), |
|
| 228 | 228 | ApiBase::PARAM_HELP_MSG_PER_VALUE => [], |
| 229 | 229 | ], |
| 230 | 230 | ]; |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Message; |
| 6 | 6 | |
@@ -43,12 +43,12 @@ discard block |
||
| 43 | 43 | ): ViolationMessageRenderer { |
| 44 | 44 | $userLanguageCode = $userLanguage->getCode(); |
| 45 | 45 | $formatterOptions = new FormatterOptions(); |
| 46 | - $formatterOptions->setOption( SnakFormatter::OPT_LANG, $userLanguageCode ); |
|
| 46 | + $formatterOptions->setOption(SnakFormatter::OPT_LANG, $userLanguageCode); |
|
| 47 | 47 | return new MultilingualTextViolationMessageRenderer( |
| 48 | 48 | $this->entityIdHtmlLinkFormatterFactory |
| 49 | - ->getEntityIdFormatter( $userLanguage ), |
|
| 49 | + ->getEntityIdFormatter($userLanguage), |
|
| 50 | 50 | $this->valueFormatterFactory |
| 51 | - ->getValueFormatter( SnakFormatter::FORMAT_HTML, $formatterOptions ), |
|
| 51 | + ->getValueFormatter(SnakFormatter::FORMAT_HTML, $formatterOptions), |
|
| 52 | 52 | $this->languageNameUtils, |
| 53 | 53 | $userLanguageCode, |
| 54 | 54 | $languageFallbackChain, |
@@ -36,7 +36,7 @@ discard block |
||
| 36 | 36 | * @param WANObjectCache $cache |
| 37 | 37 | * @param string $formatVersion The version of the API response format. |
| 38 | 38 | */ |
| 39 | - public function __construct( WANObjectCache $cache, $formatVersion ) { |
|
| 39 | + public function __construct(WANObjectCache $cache, $formatVersion) { |
|
| 40 | 40 | $this->cache = $cache; |
| 41 | 41 | $this->formatVersion = $formatVersion; |
| 42 | 42 | } |
@@ -45,7 +45,7 @@ discard block |
||
| 45 | 45 | * @param EntityId $entityId |
| 46 | 46 | * @return string cache key |
| 47 | 47 | */ |
| 48 | - public function makeKey( EntityId $entityId ) { |
|
| 48 | + public function makeKey(EntityId $entityId) { |
|
| 49 | 49 | return $this->cache->makeKey( |
| 50 | 50 | 'WikibaseQualityConstraints', // extension |
| 51 | 51 | 'checkConstraints', // action |
@@ -61,8 +61,8 @@ discard block |
||
| 61 | 61 | * @param array &$info |
| 62 | 62 | * @return mixed |
| 63 | 63 | */ |
| 64 | - public function get( EntityId $key, &$curTTL = null, array $checkKeys = [], array &$info = [] ) { |
|
| 65 | - return $this->cache->get( $this->makeKey( $key ), $curTTL, $checkKeys, $info ); |
|
| 64 | + public function get(EntityId $key, &$curTTL = null, array $checkKeys = [], array &$info = []) { |
|
| 65 | + return $this->cache->get($this->makeKey($key), $curTTL, $checkKeys, $info); |
|
| 66 | 66 | } |
| 67 | 67 | |
| 68 | 68 | /** |
@@ -72,16 +72,16 @@ discard block |
||
| 72 | 72 | * @param array $opts |
| 73 | 73 | * @return bool |
| 74 | 74 | */ |
| 75 | - public function set( EntityId $key, $value, $ttl = 0, array $opts = [] ) { |
|
| 76 | - return $this->cache->set( $this->makeKey( $key ), $value, $ttl, $opts ); |
|
| 75 | + public function set(EntityId $key, $value, $ttl = 0, array $opts = []) { |
|
| 76 | + return $this->cache->set($this->makeKey($key), $value, $ttl, $opts); |
|
| 77 | 77 | } |
| 78 | 78 | |
| 79 | 79 | /** |
| 80 | 80 | * @param EntityId $key |
| 81 | 81 | * @return bool |
| 82 | 82 | */ |
| 83 | - public function delete( EntityId $key ) { |
|
| 84 | - return $this->cache->delete( $this->makeKey( $key ) ); |
|
| 83 | + public function delete(EntityId $key) { |
|
| 84 | + return $this->cache->delete($this->makeKey($key)); |
|
| 85 | 85 | } |
| 86 | 86 | |
| 87 | 87 | } |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\Api; |
| 6 | 6 | |
@@ -37,12 +37,12 @@ discard block |
||
| 37 | 37 | Language $userLanguage, |
| 38 | 38 | MessageLocalizer $messageLocalizer |
| 39 | 39 | ): CheckResultsRenderer { |
| 40 | - $languageFallbackChain = $this->languageFallbackChainFactory->newFromLanguage( $userLanguage ); |
|
| 40 | + $languageFallbackChain = $this->languageFallbackChainFactory->newFromLanguage($userLanguage); |
|
| 41 | 41 | |
| 42 | 42 | return new CheckResultsRenderer( |
| 43 | 43 | $this->entityTitleLookup, |
| 44 | 44 | $this->entityIdLabelFormatterFactory |
| 45 | - ->getEntityIdFormatter( $userLanguage ), |
|
| 45 | + ->getEntityIdFormatter($userLanguage), |
|
| 46 | 46 | $languageFallbackChain, |
| 47 | 47 | $this->violationMessageRendererFactory |
| 48 | 48 | ->getViolationMessageRenderer( |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Result; |
| 6 | 6 | |
@@ -60,14 +60,14 @@ discard block |
||
| 60 | 60 | $this->serializeDependencyMetadata = $serializeDependencyMetadata; |
| 61 | 61 | } |
| 62 | 62 | |
| 63 | - public function serialize( CheckResult $checkResult ): array { |
|
| 63 | + public function serialize(CheckResult $checkResult): array { |
|
| 64 | 64 | $contextCursor = $checkResult->getContextCursor(); |
| 65 | 65 | |
| 66 | 66 | $serialization = [ |
| 67 | - self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize( $contextCursor ), |
|
| 67 | + self::KEY_CONTEXT_CURSOR => $this->contextCursorSerializer->serialize($contextCursor), |
|
| 68 | 68 | ]; |
| 69 | 69 | |
| 70 | - if ( $checkResult instanceof NullResult ) { |
|
| 70 | + if ($checkResult instanceof NullResult) { |
|
| 71 | 71 | $serialization[self::KEY_NULL_RESULT] = 1; |
| 72 | 72 | } else { |
| 73 | 73 | $constraint = $checkResult->getConstraint(); |
@@ -76,57 +76,57 @@ discard block |
||
| 76 | 76 | $clarification = $checkResult->getConstraintClarification(); |
| 77 | 77 | |
| 78 | 78 | $serialization[self::KEY_CONSTRAINT] = |
| 79 | - $this->constraintSerializer->serialize( $constraint ); |
|
| 79 | + $this->constraintSerializer->serialize($constraint); |
|
| 80 | 80 | $serialization[self::KEY_CHECK_RESULT_STATUS] = |
| 81 | 81 | $checkResult->getStatus(); |
| 82 | 82 | $serialization[self::KEY_CACHING_METADATA] = |
| 83 | - $this->serializeCachingMetadata( $cachingMetadata ); |
|
| 83 | + $this->serializeCachingMetadata($cachingMetadata); |
|
| 84 | 84 | |
| 85 | - if ( $violationMessage !== null ) { |
|
| 85 | + if ($violationMessage !== null) { |
|
| 86 | 86 | $serialization[self::KEY_VIOLATION_MESSAGE] = |
| 87 | - $this->violationMessageSerializer->serialize( $violationMessage ); |
|
| 87 | + $this->violationMessageSerializer->serialize($violationMessage); |
|
| 88 | 88 | } |
| 89 | - if ( $clarification->getTexts() !== [] ) { |
|
| 89 | + if ($clarification->getTexts() !== []) { |
|
| 90 | 90 | $serialization[self::KEY_CONSTRAINT_CLARIFICATION] = |
| 91 | 91 | $clarification->getArrayValue(); |
| 92 | 92 | } |
| 93 | 93 | } |
| 94 | 94 | |
| 95 | - if ( $this->serializeDependencyMetadata ) { |
|
| 95 | + if ($this->serializeDependencyMetadata) { |
|
| 96 | 96 | $serialization[self::KEY_DEPENDENCY_METADATA] = |
| 97 | - $this->serializeDependencyMetadata( $checkResult ); |
|
| 97 | + $this->serializeDependencyMetadata($checkResult); |
|
| 98 | 98 | } |
| 99 | 99 | |
| 100 | 100 | return $serialization; |
| 101 | 101 | } |
| 102 | 102 | |
| 103 | - private function serializeCachingMetadata( CachingMetadata $cachingMetadata ): array { |
|
| 103 | + private function serializeCachingMetadata(CachingMetadata $cachingMetadata): array { |
|
| 104 | 104 | $maximumAge = $cachingMetadata->getMaximumAgeInSeconds(); |
| 105 | 105 | |
| 106 | 106 | $serialization = []; |
| 107 | 107 | |
| 108 | - if ( $maximumAge > 0 ) { |
|
| 108 | + if ($maximumAge > 0) { |
|
| 109 | 109 | $serialization[self::KEY_CACHING_METADATA_MAX_AGE] = $maximumAge; |
| 110 | 110 | } |
| 111 | 111 | |
| 112 | 112 | return $serialization; |
| 113 | 113 | } |
| 114 | 114 | |
| 115 | - private function serializeDependencyMetadata( CheckResult $checkResult ): array { |
|
| 115 | + private function serializeDependencyMetadata(CheckResult $checkResult): array { |
|
| 116 | 116 | $dependencyMetadata = $checkResult->getMetadata()->getDependencyMetadata(); |
| 117 | 117 | $entityIds = $dependencyMetadata->getEntityIds(); |
| 118 | 118 | $futureTime = $dependencyMetadata->getFutureTime(); |
| 119 | 119 | |
| 120 | 120 | $serialization = [ |
| 121 | 121 | self::KEY_DEPENDENCY_METADATA_ENTITY_IDS => array_map( |
| 122 | - static function ( EntityId $entityId ) { |
|
| 122 | + static function(EntityId $entityId) { |
|
| 123 | 123 | return $entityId->getSerialization(); |
| 124 | 124 | }, |
| 125 | 125 | $entityIds |
| 126 | 126 | ), |
| 127 | 127 | ]; |
| 128 | 128 | |
| 129 | - if ( $futureTime !== null ) { |
|
| 129 | + if ($futureTime !== null) { |
|
| 130 | 130 | $serialization[self::KEY_DEPENDENCY_METADATA_FUTURE_TIME] = |
| 131 | 131 | $futureTime->getArrayValue(); |
| 132 | 132 | } |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -declare( strict_types = 1 ); |
|
| 3 | +declare(strict_types=1); |
|
| 4 | 4 | |
| 5 | 5 | namespace WikibaseQuality\ConstraintReport\Api; |
| 6 | 6 | |
@@ -41,11 +41,11 @@ discard block |
||
| 41 | 41 | $this->violationMessageRenderer = $violationMessageRenderer; |
| 42 | 42 | } |
| 43 | 43 | |
| 44 | - public function render( CachedCheckResults $checkResults ): CachedCheckConstraintsResponse { |
|
| 44 | + public function render(CachedCheckResults $checkResults): CachedCheckConstraintsResponse { |
|
| 45 | 45 | $response = []; |
| 46 | - foreach ( $checkResults->getArray() as $checkResult ) { |
|
| 47 | - $resultArray = $this->checkResultToArray( $checkResult ); |
|
| 48 | - $checkResult->getContextCursor()->storeCheckResultInArray( $resultArray, $response ); |
|
| 46 | + foreach ($checkResults->getArray() as $checkResult) { |
|
| 47 | + $resultArray = $this->checkResultToArray($checkResult); |
|
| 48 | + $checkResult->getContextCursor()->storeCheckResultInArray($resultArray, $response); |
|
| 49 | 49 | } |
| 50 | 50 | return new CachedCheckConstraintsResponse( |
| 51 | 51 | $response, |
@@ -53,19 +53,19 @@ discard block |
||
| 53 | 53 | ); |
| 54 | 54 | } |
| 55 | 55 | |
| 56 | - public function checkResultToArray( CheckResult $checkResult ): ?array { |
|
| 57 | - if ( $checkResult instanceof NullResult ) { |
|
| 56 | + public function checkResultToArray(CheckResult $checkResult): ?array { |
|
| 57 | + if ($checkResult instanceof NullResult) { |
|
| 58 | 58 | return null; |
| 59 | 59 | } |
| 60 | 60 | |
| 61 | 61 | $constraintId = $checkResult->getConstraint()->getConstraintId(); |
| 62 | 62 | $typeItemId = $checkResult->getConstraint()->getConstraintTypeItemId(); |
| 63 | - $constraintPropertyId = new NumericPropertyId( $checkResult->getContextCursor()->getSnakPropertyId() ); |
|
| 63 | + $constraintPropertyId = new NumericPropertyId($checkResult->getContextCursor()->getSnakPropertyId()); |
|
| 64 | 64 | |
| 65 | - $title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId ); |
|
| 65 | + $title = $this->entityTitleLookup->getTitleForId($constraintPropertyId); |
|
| 66 | 66 | $talkTitle = $title->getTalkPageIfDefined(); |
| 67 | - $typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) ); |
|
| 68 | - $link = $title->getFullURL() . '#' . $constraintId; |
|
| 67 | + $typeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($typeItemId)); |
|
| 68 | + $link = $title->getFullURL().'#'.$constraintId; |
|
| 69 | 69 | |
| 70 | 70 | $constraint = [ |
| 71 | 71 | 'id' => $constraintId, |
@@ -81,28 +81,28 @@ discard block |
||
| 81 | 81 | 'constraint' => $constraint, |
| 82 | 82 | ]; |
| 83 | 83 | $message = $checkResult->getMessage(); |
| 84 | - if ( $message ) { |
|
| 85 | - $result['message-html'] = $this->violationMessageRenderer->render( $message ); |
|
| 84 | + if ($message) { |
|
| 85 | + $result['message-html'] = $this->violationMessageRenderer->render($message); |
|
| 86 | 86 | } |
| 87 | - $constraintClarification = $this->renderConstraintClarification( $checkResult ); |
|
| 88 | - if ( $constraintClarification !== null ) { |
|
| 87 | + $constraintClarification = $this->renderConstraintClarification($checkResult); |
|
| 88 | + if ($constraintClarification !== null) { |
|
| 89 | 89 | $result['constraint-clarification'] = $constraintClarification; |
| 90 | 90 | } |
| 91 | - if ( $checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT ) { |
|
| 91 | + if ($checkResult->getContextCursor()->getType() === Context::TYPE_STATEMENT) { |
|
| 92 | 92 | $result['claim'] = $checkResult->getContextCursor()->getStatementGuid(); |
| 93 | 93 | } |
| 94 | 94 | $cachingMetadataArray = $checkResult->getMetadata()->getCachingMetadata()->toArray(); |
| 95 | - if ( $cachingMetadataArray !== null ) { |
|
| 95 | + if ($cachingMetadataArray !== null) { |
|
| 96 | 96 | $result['cached'] = $cachingMetadataArray; |
| 97 | 97 | } |
| 98 | 98 | |
| 99 | 99 | return $result; |
| 100 | 100 | } |
| 101 | 101 | |
| 102 | - private function renderConstraintClarification( CheckResult $result ): ?string { |
|
| 102 | + private function renderConstraintClarification(CheckResult $result): ?string { |
|
| 103 | 103 | $texts = $result->getConstraintClarification()->getTexts(); |
| 104 | - foreach ( $this->languageFallbackChain->getFetchLanguageCodes() as $languageCode ) { |
|
| 105 | - if ( array_key_exists( $languageCode, $texts ) ) { |
|
| 104 | + foreach ($this->languageFallbackChain->getFetchLanguageCodes() as $languageCode) { |
|
| 105 | + if (array_key_exists($languageCode, $texts)) { |
|
| 106 | 106 | return $texts[$languageCode]->getText(); |
| 107 | 107 | } |
| 108 | 108 | } |