wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/ConstraintCheck/Checker/CommonsLinkChecker.php

Spacing +42 added lines, -42 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Checker;
 
@@ -74,26 +74,26 @@ 
 	 * @return array first element is the namespace number (default namespace for TitleParser),
 	 * second element is a string to prepend to the title before giving it to the TitleParser
 	 */
-	private function getCommonsNamespace( string $namespace ): array {
-		switch ( $namespace ) {
+	private function getCommonsNamespace(string $namespace): array {
+		switch ($namespace) {
 			case '':
-				return [ NS_MAIN, '' ];
+				return [NS_MAIN, ''];
 			// extra namespaces, see operations/mediawiki-config.git,
 			// wmf-config/InitialiseSettings.php, 'wgExtraNamespaces' key, 'commonswiki' subkey
 			case 'Creator':
-				return [ 100, '' ];
+				return [100, ''];
 			case 'TimedText':
-				return [ 102, '' ];
+				return [102, ''];
 			case 'Sequence':
-				return [ 104, '' ];
+				return [104, ''];
 			case 'Institution':
-				return [ 106, '' ];
+				return [106, ''];
 			// extension namespace, see mediawiki/extensions/JsonConfig.git,
 			// extension.json, 'namespaces' key, third element
 			case 'Data':
-				return [ 486, '' ];
+				return [486, ''];
 			default:
-				return [ NS_MAIN, $namespace . ':' ];
+				return [NS_MAIN, $namespace.':'];
 		}
 	}
 
@@ -102,7 +102,7 @@ 
 	 *
 	 * @throws ConstraintParameterException
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ): CheckResult {
+	public function checkConstraint(Context $context, Constraint $constraint): CheckResult {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 
@@ -113,9 +113,9 @@ 
 
 		$snak = $context->getSnak();
 
-		if ( !$snak instanceof PropertyValueSnak ) {
+		if (!$snak instanceof PropertyValueSnak) {
 			// nothing to check
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE);
 		}
 
 		$dataValue = $snak->getDataValue();
@@ -125,52 +125,52 @@ 
 		 *   type of $dataValue for properties with 'Commons link' constraint has to be 'string'
 		 *   parameter $namespace can be null, works for commons galleries
 		 */
-		if ( $dataValue->getType() !== 'string' ) {
-			$message = ( new ViolationMessage( 'wbqc-violation-message-value-needed-of-type' ) )
-				->withEntityId( new ItemId( $constraintTypeItemId ), Role::CONSTRAINT_TYPE_ITEM )
-				->withDataValueType( 'string' );
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION, $message );
+		if ($dataValue->getType() !== 'string') {
+			$message = (new ViolationMessage('wbqc-violation-message-value-needed-of-type'))
+				->withEntityId(new ItemId($constraintTypeItemId), Role::CONSTRAINT_TYPE_ITEM)
+				->withDataValueType('string');
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION, $message);
 		}
 
 		$commonsLink = $dataValue->getValue();
-		if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-				new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
+		if (!$this->commonsLinkIsWellFormed($commonsLink)) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+				new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
 		}
 
-		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty( $snak->getPropertyId() );
-		switch ( $dataType ) {
+		$dataType = $this->propertyDatatypeLookup->getDataTypeIdForProperty($snak->getPropertyId());
+		switch ($dataType) {
 			case 'geo-shape':
 			case 'tabular-data':
-				if ( strpos( $commonsLink, $namespace . ':' ) !== 0 ) {
-					return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-						new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
+				if (strpos($commonsLink, $namespace.':') !== 0) {
+					return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+						new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
 				}
 				$pageName = $commonsLink;
 				break;
 			default:
-				$pageName = $namespace ? $namespace . ':' . $commonsLink : $commonsLink;
+				$pageName = $namespace ? $namespace.':'.$commonsLink : $commonsLink;
 				break;
 		}
 
-		$prefix = $this->getCommonsNamespace( $namespace )[1];
+		$prefix = $this->getCommonsNamespace($namespace)[1];
 		$normalizedTitle = $this->pageNameNormalizer->normalizePageName(
 			$pageName,
 			'https://commons.wikimedia.org/w/api.php'
 		);
-		if ( $normalizedTitle === false ) {
-			if ( $this->valueIncludesNamespace( $commonsLink, $namespace ) ) {
-				return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-					new ViolationMessage( 'wbqc-violation-message-commons-link-not-well-formed' ) );
+		if ($normalizedTitle === false) {
+			if ($this->valueIncludesNamespace($commonsLink, $namespace)) {
+				return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+					new ViolationMessage('wbqc-violation-message-commons-link-not-well-formed'));
 			}
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_VIOLATION,
-				new ViolationMessage( 'wbqc-violation-message-commons-link-no-existent' ) );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_VIOLATION,
+				new ViolationMessage('wbqc-violation-message-commons-link-no-existent'));
 		}
 
-		return new CheckResult( $context, $constraint, CheckResult::STATUS_COMPLIANCE, null );
+		return new CheckResult($context, $constraint, CheckResult::STATUS_COMPLIANCE, null);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ): array {
+	public function checkConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$constraintTypeItemId = $constraint->getConstraintTypeItemId();
 		$exceptions = [];
@@ -179,15 +179,15 @@ 
 				$constraintParameters,
 				$constraintTypeItemId
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;
 	}
 
-	private function commonsLinkIsWellFormed( string $commonsLink ): bool {
-		$toReplace = [ "_", "%20" ];
-		$compareString = trim( str_replace( $toReplace, '', $commonsLink ) );
+	private function commonsLinkIsWellFormed(string $commonsLink): bool {
+		$toReplace = ["_", "%20"];
+		$compareString = trim(str_replace($toReplace, '', $commonsLink));
 
 		return $commonsLink === $compareString;
 	}
@@ -196,9 +196,9 @@ 
 	 * Checks whether the value of the statement already includes the namespace.
 	 * This special case should be reported as “malformed title” instead of “title does not exist”.
 	 */
-	private function valueIncludesNamespace( string $value, string $namespace ): bool {
+	private function valueIncludesNamespace(string $value, string $namespace): bool {
 		return $namespace !== '' &&
-			strncasecmp( $value, $namespace . ':', strlen( $namespace ) + 1 ) === 0;
+			strncasecmp($value, $namespace.':', strlen($namespace) + 1) === 0;
 	}
 
 }

src/ConstraintCheck/DelegatingConstraintChecker.php

Spacing +169 added lines, -169 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\ConstraintCheck;
 
@@ -123,10 +123,10 @@ 
 		callable $defaultResultsPerEntity = null
 	): array {
 		$checkResults = [];
-		$entity = $this->entityLookup->getEntity( $entityId );
+		$entity = $this->entityLookup->getEntity($entityId);
 
-		if ( $entity instanceof StatementListProvidingEntity ) {
-			$startTime = microtime( true );
+		if ($entity instanceof StatementListProvidingEntity) {
+			$startTime = microtime(true);
 
 			$checkResults = $this->checkEveryStatement(
 				$entity,
@@ -134,9 +134,9 @@ 
 				$defaultResultsPerContext
 			);
 
-			$endTime = microtime( true );
+			$endTime = microtime(true);
 
-			if ( $constraintIds === null ) { // only log full constraint checks
+			if ($constraintIds === null) { // only log full constraint checks
 				$this->loggingHelper->logConstraintCheckOnEntity(
 					$entityId,
 					$checkResults,
@@ -146,11 +146,11 @@ 
 			}
 		}
 
-		if ( $defaultResultsPerEntity !== null ) {
-			$checkResults = array_merge( $defaultResultsPerEntity( $entityId ), $checkResults );
+		if ($defaultResultsPerEntity !== null) {
+			$checkResults = array_merge($defaultResultsPerEntity($entityId), $checkResults);
 		}
 
-		return $this->sortResult( $checkResults );
+		return $this->sortResult($checkResults);
 	}
 
 	/**
@@ -172,19 +172,19 @@ 
 		callable $defaultResults = null
 	): array {
 
-		$parsedGuid = $this->statementGuidParser->parse( $guid );
+		$parsedGuid = $this->statementGuidParser->parse($guid);
 		$entityId = $parsedGuid->getEntityId();
-		$entity = $this->entityLookup->getEntity( $entityId );
-		if ( $entity instanceof StatementListProvidingEntity ) {
-			$statement = $entity->getStatements()->getFirstStatementWithGuid( $guid );
-			if ( $statement ) {
+		$entity = $this->entityLookup->getEntity($entityId);
+		if ($entity instanceof StatementListProvidingEntity) {
+			$statement = $entity->getStatements()->getFirstStatementWithGuid($guid);
+			if ($statement) {
 				$result = $this->checkStatement(
 					$entity,
 					$statement,
 					$constraintIds,
 					$defaultResults
 				);
-				$output = $this->sortResult( $result );
+				$output = $this->sortResult($result);
 				return $output;
 			}
 		}
@@ -192,8 +192,8 @@ 
 		return [];
 	}
 
-	private function getValidContextTypes( Constraint $constraint ): array {
-		if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
+	private function getValidContextTypes(Constraint $constraint): array {
+		if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
 			return [
 				Context::TYPE_STATEMENT,
 				Context::TYPE_QUALIFIER,
@@ -201,25 +201,25 @@ 
 			];
 		}
 
-		return array_keys( array_filter(
+		return array_keys(array_filter(
 			$this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedContextTypes(),
-			static function ( $resultStatus ) {
+			static function($resultStatus) {
 				return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE;
 			}
-		) );
+		));
 	}
 
-	private function getValidEntityTypes( Constraint $constraint ): array {
-		if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
-			return array_keys( ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED );
+	private function getValidEntityTypes(Constraint $constraint): array {
+		if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
+			return array_keys(ConstraintChecker::ALL_ENTITY_TYPES_SUPPORTED);
 		}
 
-		return array_keys( array_filter(
+		return array_keys(array_filter(
 			$this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedEntityTypes(),
-			static function ( $resultStatus ) {
+			static function($resultStatus) {
 				return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE;
 			}
-		) );
+		));
 	}
 
 	/**
@@ -230,38 +230,38 @@ 
 	 *
 	 * @return ConstraintParameterException[]
 	 */
-	private function checkCommonConstraintParameters( Constraint $constraint ): array {
+	private function checkCommonConstraintParameters(Constraint $constraint): array {
 		$constraintParameters = $constraint->getConstraintParameters();
 		try {
-			$this->constraintParameterParser->checkError( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
-			return [ $e ];
+			$this->constraintParameterParser->checkError($constraintParameters);
+		} catch (ConstraintParameterException $e) {
+			return [$e];
 		}
 
 		$problems = [];
 		try {
-			$this->constraintParameterParser->parseExceptionParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseExceptionParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$problems[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseConstraintClarificationParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseConstraintClarificationParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$problems[] = $e;
 		}
 		try {
-			$this->constraintParameterParser->parseConstraintStatusParameter( $constraintParameters );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseConstraintStatusParameter($constraintParameters);
+		} catch (ConstraintParameterException $e) {
 			$problems[] = $e;
 		}
 		try {
 			$this->constraintParameterParser->parseConstraintScopeParameters(
 				$constraintParameters,
 				$constraint->getConstraintTypeItemId(),
-				$this->getValidContextTypes( $constraint ),
-				$this->getValidEntityTypes( $constraint )
+				$this->getValidContextTypes($constraint),
+				$this->getValidEntityTypes($constraint)
 			);
-		} catch ( ConstraintParameterException $e ) {
+		} catch (ConstraintParameterException $e) {
 			$problems[] = $e;
 		}
 		return $problems;
@@ -274,16 +274,16 @@ 
 	 * @return ConstraintParameterException[][] first level indexed by constraint ID,
 	 * second level like checkConstraintParametersOnConstraintId (but without possibility of null)
 	 */
-	public function checkConstraintParametersOnPropertyId( NumericPropertyId $propertyId ): array {
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
+	public function checkConstraintParametersOnPropertyId(NumericPropertyId $propertyId): array {
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
 		$result = [];
 
-		foreach ( $constraints as $constraint ) {
-			$problems = $this->checkCommonConstraintParameters( $constraint );
+		foreach ($constraints as $constraint) {
+			$problems = $this->checkCommonConstraintParameters($constraint);
 
-			if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
+			if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
 				$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
-				$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
+				$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
 			}
 
 			$result[$constraint->getConstraintId()] = $problems;
@@ -300,18 +300,18 @@ 
 	 * @return ConstraintParameterException[]|null list of constraint parameter exceptions
 	 * (empty means all parameters okay), or null if constraint is not found
 	 */
-	public function checkConstraintParametersOnConstraintId( string $constraintId ): ?array {
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
+	public function checkConstraintParametersOnConstraintId(string $constraintId): ?array {
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
 		'@phan-var NumericPropertyId $propertyId';
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
 
-		foreach ( $constraints as $constraint ) {
-			if ( $constraint->getConstraintId() === $constraintId ) {
-				$problems = $this->checkCommonConstraintParameters( $constraint );
+		foreach ($constraints as $constraint) {
+			if ($constraint->getConstraintId() === $constraintId) {
+				$problems = $this->checkCommonConstraintParameters($constraint);
 
-				if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
+				if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
 					$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
-					$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
+					$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
 				}
 
 				return $problems;
@@ -336,14 +336,14 @@ 
 		$result = [];
 
 		/** @var Statement $statement */
-		foreach ( $entity->getStatements() as $statement ) {
-			$result = array_merge( $result,
+		foreach ($entity->getStatements() as $statement) {
+			$result = array_merge($result,
 				$this->checkStatement(
 					$entity,
 					$statement,
 					$constraintIds,
 					$defaultResultsPerContext
-				) );
+				));
 		}
 
 		return $result;
@@ -365,32 +365,32 @@ 
 	): array {
 		$result = [];
 
-		$result = array_merge( $result,
+		$result = array_merge($result,
 			$this->checkConstraintsForMainSnak(
 				$entity,
 				$statement,
 				$constraintIds,
 				$defaultResultsPerContext
-			) );
+			));
 
-		if ( $this->checkQualifiers ) {
-			$result = array_merge( $result,
+		if ($this->checkQualifiers) {
+			$result = array_merge($result,
 				$this->checkConstraintsForQualifiers(
 					$entity,
 					$statement,
 					$constraintIds,
 					$defaultResultsPerContext
-				) );
+				));
 		}
 
-		if ( $this->checkReferences ) {
-			$result = array_merge( $result,
+		if ($this->checkReferences) {
+			$result = array_merge($result,
 				$this->checkConstraintsForReferences(
 					$entity,
 					$statement,
 					$constraintIds,
 					$defaultResultsPerContext
-				) );
+				));
 		}
 
 		return $result;
@@ -405,17 +405,17 @@ 
 	 * @param string[]|null $constraintIds
 	 * @return Constraint[]
 	 */
-	private function getConstraintsToUse( PropertyId $propertyId, ?array $constraintIds ): array {
-		if ( !( $propertyId instanceof NumericPropertyId ) ) {
+	private function getConstraintsToUse(PropertyId $propertyId, ?array $constraintIds): array {
+		if (!($propertyId instanceof NumericPropertyId)) {
 			throw new InvalidArgumentException(
-				'Non-numeric property ID not supported:' . $propertyId->getSerialization()
+				'Non-numeric property ID not supported:'.$propertyId->getSerialization()
 			);
 		}
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
-		if ( $constraintIds !== null ) {
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
+		if ($constraintIds !== null) {
 			$constraintsToUse = [];
-			foreach ( $constraints as $constraint ) {
-				if ( in_array( $constraint->getConstraintId(), $constraintIds ) ) {
+			foreach ($constraints as $constraint) {
+				if (in_array($constraint->getConstraintId(), $constraintIds)) {
 					$constraintsToUse[] = $constraint;
 				}
 			}
@@ -439,18 +439,18 @@ 
 		?array $constraintIds,
 		?callable $defaultResults
 	): array {
-		$context = new MainSnakContext( $entity, $statement );
+		$context = new MainSnakContext($entity, $statement);
 		$constraints = $this->getConstraintsToUse(
 			$statement->getPropertyId(),
 			$constraintIds
 		);
-		$result = $defaultResults !== null ? $defaultResults( $context ) : [];
+		$result = $defaultResults !== null ? $defaultResults($context) : [];
 
-		foreach ( $constraints as $constraint ) {
+		foreach ($constraints as $constraint) {
 			$parameters = $constraint->getConstraintParameters();
 			try {
-				$exceptions = $this->constraintParameterParser->parseExceptionParameter( $parameters );
-			} catch ( ConstraintParameterException $e ) {
+				$exceptions = $this->constraintParameterParser->parseExceptionParameter($parameters);
+			} catch (ConstraintParameterException $e) {
 				$result[] = new CheckResult(
 					$context,
 					$constraint,
@@ -460,13 +460,13 @@ 
 				continue;
 			}
 
-			if ( in_array( $entity->getId(), $exceptions ) ) {
-				$message = new ViolationMessage( 'wbqc-violation-message-exception' );
-				$result[] = new CheckResult( $context, $constraint, CheckResult::STATUS_EXCEPTION, $message );
+			if (in_array($entity->getId(), $exceptions)) {
+				$message = new ViolationMessage('wbqc-violation-message-exception');
+				$result[] = new CheckResult($context, $constraint, CheckResult::STATUS_EXCEPTION, $message);
 				continue;
 			}
 
-			$result[] = $this->getCheckResultFor( $context, $constraint );
+			$result[] = $this->getCheckResultFor($context, $constraint);
 		}
 
 		return $result;
@@ -488,24 +488,24 @@ 
 	): array {
 		$result = [];
 
-		if ( in_array(
+		if (in_array(
 			$statement->getPropertyId()->getSerialization(),
 			$this->propertiesWithViolatingQualifiers
-		) ) {
+		)) {
 			return $result;
 		}
 
-		foreach ( $statement->getQualifiers() as $qualifier ) {
-			$qualifierContext = new QualifierContext( $entity, $statement, $qualifier );
-			if ( $defaultResultsPerContext !== null ) {
-				$result = array_merge( $result, $defaultResultsPerContext( $qualifierContext ) );
+		foreach ($statement->getQualifiers() as $qualifier) {
+			$qualifierContext = new QualifierContext($entity, $statement, $qualifier);
+			if ($defaultResultsPerContext !== null) {
+				$result = array_merge($result, $defaultResultsPerContext($qualifierContext));
 			}
 			$qualifierConstraints = $this->getConstraintsToUse(
 				$qualifierContext->getSnak()->getPropertyId(),
 				$constraintIds
 			);
-			foreach ( $qualifierConstraints as $qualifierConstraint ) {
-				$result[] = $this->getCheckResultFor( $qualifierContext, $qualifierConstraint );
+			foreach ($qualifierConstraints as $qualifierConstraint) {
+				$result[] = $this->getCheckResultFor($qualifierContext, $qualifierConstraint);
 			}
 		}
 
@@ -529,19 +529,19 @@ 
 		$result = [];
 
 		/** @var Reference $reference */
-		foreach ( $statement->getReferences() as $reference ) {
-			foreach ( $reference->getSnaks() as $snak ) {
+		foreach ($statement->getReferences() as $reference) {
+			foreach ($reference->getSnaks() as $snak) {
 				$referenceContext = new ReferenceContext(
 					$entity, $statement, $reference, $snak
 				);
-				if ( $defaultResultsPerContext !== null ) {
-					$result = array_merge( $result, $defaultResultsPerContext( $referenceContext ) );
+				if ($defaultResultsPerContext !== null) {
+					$result = array_merge($result, $defaultResultsPerContext($referenceContext));
 				}
 				$referenceConstraints = $this->getConstraintsToUse(
 					$referenceContext->getSnak()->getPropertyId(),
 					$constraintIds
 				);
-				foreach ( $referenceConstraints as $referenceConstraint ) {
+				foreach ($referenceConstraints as $referenceConstraint) {
 					$result[] = $this->getCheckResultFor(
 						$referenceContext,
 						$referenceConstraint
@@ -553,50 +553,50 @@ 
 		return $result;
 	}
 
-	private function getCheckResultFor( Context $context, Constraint $constraint ): CheckResult {
-		if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
+	private function getCheckResultFor(Context $context, Constraint $constraint): CheckResult {
+		if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
 			$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
-			$result = $this->handleScope( $checker, $context, $constraint );
+			$result = $this->handleScope($checker, $context, $constraint);
 
-			if ( $result !== null ) {
-				$this->addMetadata( $context, $result );
+			if ($result !== null) {
+				$this->addMetadata($context, $result);
 				return $result;
 			}
 
-			$startTime = microtime( true );
+			$startTime = microtime(true);
 			try {
-				$result = $checker->checkConstraint( $context, $constraint );
-			} catch ( ConstraintParameterException $e ) {
+				$result = $checker->checkConstraint($context, $constraint);
+			} catch (ConstraintParameterException $e) {
 				$result = new CheckResult(
 					$context,
 					$constraint,
 					CheckResult::STATUS_BAD_PARAMETERS,
 					$e->getViolationMessage()
 				);
-			} catch ( SparqlHelperException $e ) {
-				$message = new ViolationMessage( 'wbqc-violation-message-sparql-error' );
-				$result = new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, $message );
+			} catch (SparqlHelperException $e) {
+				$message = new ViolationMessage('wbqc-violation-message-sparql-error');
+				$result = new CheckResult($context, $constraint, CheckResult::STATUS_TODO, $message);
 			}
-			$endTime = microtime( true );
+			$endTime = microtime(true);
 
-			$this->addMetadata( $context, $result );
+			$this->addMetadata($context, $result);
 
-			$this->addConstraintClarification( $result );
+			$this->addConstraintClarification($result);
 
-			$this->downgradeResultStatus( $result );
+			$this->downgradeResultStatus($result);
 
 			$this->loggingHelper->logConstraintCheck(
 				$context,
 				$constraint,
 				$result,
-				get_class( $checker ),
+				get_class($checker),
 				$endTime - $startTime,
 				__METHOD__
 			);
 
 			return $result;
 		} else {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null );
+			return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null);
 		}
 	}
 
@@ -605,91 +605,91 @@ 
 		Context $context,
 		Constraint $constraint
 	): ?CheckResult {
-		$validContextTypes = $this->getValidContextTypes( $constraint );
-		$validEntityTypes = $this->getValidEntityTypes( $constraint );
+		$validContextTypes = $this->getValidContextTypes($constraint);
+		$validEntityTypes = $this->getValidEntityTypes($constraint);
 		try {
-			[ $checkedContextTypes, $checkedEntityTypes ] = $this->constraintParameterParser->parseConstraintScopeParameters(
+			[$checkedContextTypes, $checkedEntityTypes] = $this->constraintParameterParser->parseConstraintScopeParameters(
 				$constraint->getConstraintParameters(),
 				$constraint->getConstraintTypeItemId(),
 				$validContextTypes,
 				$validEntityTypes
 			);
-		} catch ( ConstraintParameterException $e ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
+		} catch (ConstraintParameterException $e) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
 		}
 
-		if ( $checkedContextTypes === null ) {
+		if ($checkedContextTypes === null) {
 			$checkedContextTypes = $checker->getDefaultContextTypes();
 		}
 		$contextType = $context->getType();
-		if ( !in_array( $contextType, $checkedContextTypes ) ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null );
+		if (!in_array($contextType, $checkedContextTypes)) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null);
 		}
-		if ( $checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null );
+		if ($checker->getSupportedContextTypes()[$contextType] === CheckResult::STATUS_TODO) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null);
 		}
 
-		if ( $checkedEntityTypes === null ) {
+		if ($checkedEntityTypes === null) {
 			$checkedEntityTypes = $validEntityTypes;
 		}
 		$entityType = $context->getEntity()->getType();
-		if ( !in_array( $entityType, $checkedEntityTypes ) ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null );
+		if (!in_array($entityType, $checkedEntityTypes)) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_NOT_IN_SCOPE, null);
 		}
-		if ( $checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO ) {
-			return new CheckResult( $context, $constraint, CheckResult::STATUS_TODO, null );
+		if ($checker->getSupportedEntityTypes()[$entityType] === CheckResult::STATUS_TODO) {
+			return new CheckResult($context, $constraint, CheckResult::STATUS_TODO, null);
 		}
 
 		return null;
 	}
 
-	private function addMetadata( Context $context, CheckResult $result ): void {
-		$result->withMetadata( Metadata::merge( [
+	private function addMetadata(Context $context, CheckResult $result): void {
+		$result->withMetadata(Metadata::merge([
 			$result->getMetadata(),
-			Metadata::ofDependencyMetadata( DependencyMetadata::merge( [
-				DependencyMetadata::ofEntityId( $context->getEntity()->getId() ),
-				DependencyMetadata::ofEntityId( $result->getConstraint()->getPropertyId() ),
-			] ) ),
-		] ) );
+			Metadata::ofDependencyMetadata(DependencyMetadata::merge([
+				DependencyMetadata::ofEntityId($context->getEntity()->getId()),
+				DependencyMetadata::ofEntityId($result->getConstraint()->getPropertyId()),
+			])),
+		]));
 	}
 
-	private function addConstraintClarification( CheckResult $result ): void {
+	private function addConstraintClarification(CheckResult $result): void {
 		$constraint = $result->getConstraint();
 		try {
 			$constraintClarification = $this->constraintParameterParser
-				->parseConstraintClarificationParameter( $constraint->getConstraintParameters() );
-			$result->setConstraintClarification( $constraintClarification );
-		} catch ( ConstraintParameterException $e ) {
-			$result->setStatus( CheckResult::STATUS_BAD_PARAMETERS );
-			$result->setMessage( $e->getViolationMessage() );
+				->parseConstraintClarificationParameter($constraint->getConstraintParameters());
+			$result->setConstraintClarification($constraintClarification);
+		} catch (ConstraintParameterException $e) {
+			$result->setStatus(CheckResult::STATUS_BAD_PARAMETERS);
+			$result->setMessage($e->getViolationMessage());
 		}
 	}
 
-	private function downgradeResultStatus( CheckResult $result ): void {
+	private function downgradeResultStatus(CheckResult $result): void {
 		$constraint = $result->getConstraint();
 		try {
 			$constraintStatus = $this->constraintParameterParser
-				->parseConstraintStatusParameter( $constraint->getConstraintParameters() );
-		} catch ( ConstraintParameterException $e ) {
-			$result->setStatus( CheckResult::STATUS_BAD_PARAMETERS );
-			$result->setMessage( $e->getViolationMessage() );
+				->parseConstraintStatusParameter($constraint->getConstraintParameters());
+		} catch (ConstraintParameterException $e) {
+			$result->setStatus(CheckResult::STATUS_BAD_PARAMETERS);
+			$result->setMessage($e->getViolationMessage());
 			return;
 		}
-		if ( $constraintStatus === null ) {
+		if ($constraintStatus === null) {
 			// downgrade violation to warning
-			if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) {
-				$result->setStatus( CheckResult::STATUS_WARNING );
+			if ($result->getStatus() === CheckResult::STATUS_VIOLATION) {
+				$result->setStatus(CheckResult::STATUS_WARNING);
 			}
-		} elseif ( $constraintStatus === 'suggestion' ) {
+		} elseif ($constraintStatus === 'suggestion') {
 			// downgrade violation to suggestion
-			if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) {
-				$result->setStatus( CheckResult::STATUS_SUGGESTION );
+			if ($result->getStatus() === CheckResult::STATUS_VIOLATION) {
+				$result->setStatus(CheckResult::STATUS_SUGGESTION);
 			}
 		} else {
-			if ( $constraintStatus !== 'mandatory' ) {
+			if ($constraintStatus !== 'mandatory') {
 				// @codeCoverageIgnoreStart
 				throw new LogicException(
-					"Unknown constraint status '$constraintStatus', " .
+					"Unknown constraint status '$constraintStatus', ".
 					"only known statuses are 'mandatory' and 'suggestion'"
 				);
 				// @codeCoverageIgnoreEnd
@@ -702,12 +702,12 @@ 
 	 *
 	 * @return CheckResult[]
 	 */
-	private function sortResult( array $result ): array {
-		if ( count( $result ) < 2 ) {
+	private function sortResult(array $result): array {
+		if (count($result) < 2) {
 			return $result;
 		}
 
-		$sortFunction = static function ( CheckResult $a, CheckResult $b ) {
+		$sortFunction = static function(CheckResult $a, CheckResult $b) {
 			$orderNum = 0;
 			$order = [
 				CheckResult::STATUS_BAD_PARAMETERS => $orderNum++,
@@ -724,55 +724,55 @@ 
 			$statusA = $a->getStatus();
 			$statusB = $b->getStatus();
 
-			$orderA = array_key_exists( $statusA, $order ) ? $order[ $statusA ] : $order[ 'other' ];
-			$orderB = array_key_exists( $statusB, $order ) ? $order[ $statusB ] : $order[ 'other' ];
+			$orderA = array_key_exists($statusA, $order) ? $order[$statusA] : $order['other'];
+			$orderB = array_key_exists($statusB, $order) ? $order[$statusB] : $order['other'];
 
-			if ( $orderA === $orderB ) {
+			if ($orderA === $orderB) {
 				$cursorA = $a->getContextCursor();
 				$cursorB = $b->getContextCursor();
 
-				if ( $cursorA instanceof EntityContextCursor ) {
+				if ($cursorA instanceof EntityContextCursor) {
 					return $cursorB instanceof EntityContextCursor ? 0 : -1;
 				}
-				if ( $cursorB instanceof EntityContextCursor ) {
+				if ($cursorB instanceof EntityContextCursor) {
 					return $cursorA instanceof EntityContextCursor ? 0 : 1;
 				}
 
 				$pidA = $cursorA->getSnakPropertyId();
 				$pidB = $cursorB->getSnakPropertyId();
 
-				if ( $pidA === $pidB ) {
+				if ($pidA === $pidB) {
 					$hashA = $cursorA->getSnakHash();
 					$hashB = $cursorB->getSnakHash();
 
-					if ( $hashA === $hashB ) {
-						if ( $a instanceof NullResult ) {
+					if ($hashA === $hashB) {
+						if ($a instanceof NullResult) {
 							return $b instanceof NullResult ? 0 : -1;
 						}
-						if ( $b instanceof NullResult ) {
+						if ($b instanceof NullResult) {
 							return $a instanceof NullResult ? 0 : 1;
 						}
 
 						$typeA = $a->getConstraint()->getConstraintTypeItemId();
 						$typeB = $b->getConstraint()->getConstraintTypeItemId();
 
-						if ( $typeA == $typeB ) {
+						if ($typeA == $typeB) {
 							return 0;
 						} else {
-							return ( $typeA > $typeB ) ? 1 : -1;
+							return ($typeA > $typeB) ? 1 : -1;
 						}
 					} else {
-						return ( $hashA > $hashB ) ? 1 : -1;
+						return ($hashA > $hashB) ? 1 : -1;
 					}
 				} else {
-					return ( $pidA > $pidB ) ? 1 : -1;
+					return ($pidA > $pidB) ? 1 : -1;
 				}
 			} else {
-				return ( $orderA > $orderB ) ? 1 : -1;
+				return ($orderA > $orderB) ? 1 : -1;
 			}
 		};
 
-		uasort( $result, $sortFunction );
+		uasort($result, $sortFunction);
 
 		return $result;
 	}

src/ConstraintCheck/Helper/SparqlHelper.php

Spacing +176 added lines, -179 removed lines

@@ -200,73 +200,73 @@ 
 		$this->defaultUserAgent = $defaultUserAgent;
 		$this->requestFactory = $requestFactory;
 		$this->entityPrefixes = [];
-		foreach ( $rdfVocabulary->entityNamespaceNames as $namespaceName ) {
-			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI( $namespaceName );
+		foreach ($rdfVocabulary->entityNamespaceNames as $namespaceName) {
+			$this->entityPrefixes[] = $rdfVocabulary->getNamespaceURI($namespaceName);
 		}
 
-		$this->endpoint = $config->get( 'WBQualityConstraintsSparqlEndpoint' );
-		$this->maxQueryTimeMillis = $config->get( 'WBQualityConstraintsSparqlMaxMillis' );
-		$this->instanceOfId = $config->get( 'WBQualityConstraintsInstanceOfId' );
-		$this->subclassOfId = $config->get( 'WBQualityConstraintsSubclassOfId' );
-		$this->cacheMapSize = $config->get( 'WBQualityConstraintsFormatCacheMapSize' );
+		$this->endpoint = $config->get('WBQualityConstraintsSparqlEndpoint');
+		$this->maxQueryTimeMillis = $config->get('WBQualityConstraintsSparqlMaxMillis');
+		$this->instanceOfId = $config->get('WBQualityConstraintsInstanceOfId');
+		$this->subclassOfId = $config->get('WBQualityConstraintsSubclassOfId');
+		$this->cacheMapSize = $config->get('WBQualityConstraintsFormatCacheMapSize');
 		$this->timeoutExceptionClasses = $config->get(
 			'WBQualityConstraintsSparqlTimeoutExceptionClasses'
 		);
 		$this->sparqlHasWikibaseSupport = $config->get(
 			'WBQualityConstraintsSparqlHasWikibaseSupport'
 		);
-		$this->sparqlThrottlingFallbackDuration = (int)$config->get(
+		$this->sparqlThrottlingFallbackDuration = (int) $config->get(
 			'WBQualityConstraintsSparqlThrottlingFallbackDuration'
 		);
 
-		$this->prefixes = $this->getQueryPrefixes( $rdfVocabulary );
+		$this->prefixes = $this->getQueryPrefixes($rdfVocabulary);
 	}
 
-	private function getQueryPrefixes( RdfVocabulary $rdfVocabulary ) {
+	private function getQueryPrefixes(RdfVocabulary $rdfVocabulary) {
 		// TODO: it would probably be smarter that RdfVocubulary exposed these prefixes somehow
 		$prefixes = '';
-		foreach ( $rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName ) {
+		foreach ($rdfVocabulary->entityNamespaceNames as $sourceName => $namespaceName) {
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 		$prefixes .= <<<END
-PREFIX wds: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_STATEMENT )}>
-PREFIX wdv: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_VALUE )}>\n
+PREFIX wds: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_STATEMENT)}>
+PREFIX wdv: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_VALUE)}>\n
 END;
 
-		foreach ( $rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces ) {
+		foreach ($rdfVocabulary->propertyNamespaceNames as $sourceName => $sourceNamespaces) {
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_DIRECT_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_CLAIM_STATEMENT];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_QUALIFIER_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 			$namespaceName = $sourceNamespaces[RdfVocabulary::NSP_REFERENCE_VALUE];
 			$prefixes .= <<<END
-PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI( $namespaceName )}>\n
+PREFIX {$namespaceName}: <{$rdfVocabulary->getNamespaceURI($namespaceName)}>\n
 END;
 		}
 		$prefixes .= <<<END
-PREFIX wikibase: <{$rdfVocabulary->getNamespaceURI( RdfVocabulary::NS_ONTOLOGY )}>\n
+PREFIX wikibase: <{$rdfVocabulary->getNamespaceURI(RdfVocabulary::NS_ONTOLOGY)}>\n
 END;
 		return $prefixes;
 	}
@@ -278,21 +278,20 @@ 
 	 * @return CachedBool
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	public function hasType( $id, array $classes ) {
+	public function hasType($id, array $classes) {
 		// TODO hint:gearing is a workaround for T168973 and can hopefully be removed eventually
 		$gearingHint = $this->sparqlHasWikibaseSupport ?
-			' hint:Prior hint:gearing "forward".' :
-			'';
+			' hint:Prior hint:gearing "forward".' : '';
 
 		$metadatas = [];
 
-		foreach ( array_chunk( $classes, 20 ) as $classesChunk ) {
-			$classesValues = implode( ' ', array_map(
-				static function ( $class ) {
-					return 'wd:' . $class;
+		foreach (array_chunk($classes, 20) as $classesChunk) {
+			$classesValues = implode(' ', array_map(
+				static function($class) {
+					return 'wd:'.$class;
 				},
 				$classesChunk
-			) );
+			));
 
 			$query = <<<EOF
 ASK {
@@ -302,19 +301,19 @@ 
 }
 EOF;
 
-			$result = $this->runQuery( $query );
+			$result = $this->runQuery($query);
 			$metadatas[] = $result->getMetadata();
-			if ( $result->getArray()['boolean'] ) {
+			if ($result->getArray()['boolean']) {
 				return new CachedBool(
 					true,
-					Metadata::merge( $metadatas )
+					Metadata::merge($metadatas)
 				);
 			}
 		}
 
 		return new CachedBool(
 			false,
-			Metadata::merge( $metadatas )
+			Metadata::merge($metadatas)
 		);
 	}
 
@@ -325,7 +324,7 @@ 
 	 * @param PropertyId $separator
 	 * @return string
 	 */
-	private function nestedSeparatorFilter( PropertyId $separator ) {
+	private function nestedSeparatorFilter(PropertyId $separator) {
 		$filter = <<<EOF
   MINUS {
     ?statement pq:$separator ?qualifier.
@@ -369,10 +368,10 @@ 
 		$pid = $statement->getPropertyId()->getSerialization();
 		$guid = $statement->getGuid();
 		'@phan-var string $guid'; // statement must have a non-null GUID
-		$guidForRdf = str_replace( '$', '-', $guid );
+		$guidForRdf = str_replace('$', '-', $guid);
 
-		$separatorFilters = array_map( [ $this, 'nestedSeparatorFilter' ], $separators );
-		$finalSeparatorFilter = implode( "\n", $separatorFilters );
+		$separatorFilters = array_map([$this, 'nestedSeparatorFilter'], $separators);
+		$finalSeparatorFilter = implode("\n", $separatorFilters);
 
 		$query = <<<EOF
 SELECT DISTINCT ?otherEntity WHERE {
@@ -390,9 +389,9 @@ 
 LIMIT 10
 EOF;
 
-		$result = $this->runQuery( $query );
+		$result = $this->runQuery($query);
 
-		return $this->getOtherEntities( $result );
+		return $this->getOtherEntities($result);
 	}
 
 	/**
@@ -417,16 +416,15 @@ 
 		$dataType = $this->propertyDataTypeLookup->getDataTypeIdForProperty(
 			$snak->getPropertyId()
 		);
-		list( $value, $isFullValue ) = $this->getRdfLiteral( $dataType, $dataValue );
-		if ( $isFullValue ) {
+		list($value, $isFullValue) = $this->getRdfLiteral($dataType, $dataValue);
+		if ($isFullValue) {
 			$prefix .= 'v';
 		}
 		$path = $type === Context::TYPE_QUALIFIER ?
-			"$prefix:$pid" :
-			"prov:wasDerivedFrom/$prefix:$pid";
+			"$prefix:$pid" : "prov:wasDerivedFrom/$prefix:$pid";
 
 		$deprecatedFilter = '';
-		if ( $ignoreDeprecatedStatements ) {
+		if ($ignoreDeprecatedStatements) {
 			$deprecatedFilter = <<< EOF
   MINUS { ?otherStatement wikibase:rank wikibase:DeprecatedRank. }
 EOF;
@@ -446,9 +444,9 @@ 
 LIMIT 10
 EOF;
 
-		$result = $this->runQuery( $query );
+		$result = $this->runQuery($query);
 
-		return $this->getOtherEntities( $result );
+		return $this->getOtherEntities($result);
 	}
 
 	/**
@@ -458,8 +456,8 @@ 
 	 *
 	 * @return string
 	 */
-	private function stringLiteral( $text ) {
-		return '"' . strtr( $text, [ '"' => '\\"', '\\' => '\\\\' ] ) . '"';
+	private function stringLiteral($text) {
+		return '"'.strtr($text, ['"' => '\\"', '\\' => '\\\\']).'"';
 	}
 
 	/**
@@ -469,18 +467,18 @@ 
 	 *
 	 * @return CachedEntityIds
 	 */
-	private function getOtherEntities( CachedQueryResults $results ) {
-		return new CachedEntityIds( array_map(
-			function ( $resultBindings ) {
+	private function getOtherEntities(CachedQueryResults $results) {
+		return new CachedEntityIds(array_map(
+			function($resultBindings) {
 				$entityIRI = $resultBindings['otherEntity']['value'];
-				foreach ( $this->entityPrefixes as $entityPrefix ) {
-					$entityPrefixLength = strlen( $entityPrefix );
-					if ( substr( $entityIRI, 0, $entityPrefixLength ) === $entityPrefix ) {
+				foreach ($this->entityPrefixes as $entityPrefix) {
+					$entityPrefixLength = strlen($entityPrefix);
+					if (substr($entityIRI, 0, $entityPrefixLength) === $entityPrefix) {
 						try {
 							return $this->entityIdParser->parse(
-								substr( $entityIRI, $entityPrefixLength )
+								substr($entityIRI, $entityPrefixLength)
 							);
-						} catch ( EntityIdParsingException $e ) {
+						} catch (EntityIdParsingException $e) {
 							// fall through
 						}
 					}
@@ -491,7 +489,7 @@ 
 				return null;
 			},
 			$results->getArray()['results']['bindings']
-		), $results->getMetadata() );
+		), $results->getMetadata());
 	}
 
 	// phpcs:disable Generic.Metrics.CyclomaticComplexity,Squiz.WhiteSpace.FunctionSpacing
@@ -504,50 +502,50 @@ 
 	 * @return array the literal or IRI as a string in SPARQL syntax,
 	 * and a boolean indicating whether it refers to a full value node or not
 	 */
-	private function getRdfLiteral( $dataType, DataValue $dataValue ) {
-		switch ( $dataType ) {
+	private function getRdfLiteral($dataType, DataValue $dataValue) {
+		switch ($dataType) {
 			case 'string':
 			case 'external-id':
-				return [ $this->stringLiteral( $dataValue->getValue() ), false ];
+				return [$this->stringLiteral($dataValue->getValue()), false];
 			case 'commonsMedia':
-				$url = $this->rdfVocabulary->getMediaFileURI( $dataValue->getValue() );
-				return [ '<' . $url . '>', false ];
+				$url = $this->rdfVocabulary->getMediaFileURI($dataValue->getValue());
+				return ['<'.$url.'>', false];
 			case 'geo-shape':
-				$url = $this->rdfVocabulary->getGeoShapeURI( $dataValue->getValue() );
-				return [ '<' . $url . '>', false ];
+				$url = $this->rdfVocabulary->getGeoShapeURI($dataValue->getValue());
+				return ['<'.$url.'>', false];
 			case 'tabular-data':
-				$url = $this->rdfVocabulary->getTabularDataURI( $dataValue->getValue() );
-				return [ '<' . $url . '>', false ];
+				$url = $this->rdfVocabulary->getTabularDataURI($dataValue->getValue());
+				return ['<'.$url.'>', false];
 			case 'url':
 				$url = $dataValue->getValue();
-				if ( !preg_match( '/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url ) ) {
+				if (!preg_match('/^[^<>"{}\\\\|^`\\x00-\\x20]*$/D', $url)) {
 					// not a valid URL for SPARQL (see SPARQL spec, production 139 IRIREF)
 					// such an URL should never reach us, so just throw
-					throw new InvalidArgumentException( 'invalid URL: ' . $url );
+					throw new InvalidArgumentException('invalid URL: '.$url);
 				}
-				return [ '<' . $url . '>', false ];
+				return ['<'.$url.'>', false];
 			case 'wikibase-item':
 			case 'wikibase-property':
 				/** @var EntityIdValue $dataValue */
 				'@phan-var EntityIdValue $dataValue';
-				return [ 'wd:' . $dataValue->getEntityId()->getSerialization(), false ];
+				return ['wd:'.$dataValue->getEntityId()->getSerialization(), false];
 			case 'monolingualtext':
 				/** @var MonolingualTextValue $dataValue */
 				'@phan-var MonolingualTextValue $dataValue';
 				$lang = $dataValue->getLanguageCode();
-				if ( !preg_match( '/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang ) ) {
+				if (!preg_match('/^[a-zA-Z]+(-[a-zA-Z0-9]+)*$/D', $lang)) {
 					// not a valid language tag for SPARQL (see SPARQL spec, production 145 LANGTAG)
 					// such a language tag should never reach us, so just throw
-					throw new InvalidArgumentException( 'invalid language tag: ' . $lang );
+					throw new InvalidArgumentException('invalid language tag: '.$lang);
 				}
-				return [ $this->stringLiteral( $dataValue->getText() ) . '@' . $lang, false ];
+				return [$this->stringLiteral($dataValue->getText()).'@'.$lang, false];
 			case 'globe-coordinate':
 			case 'quantity':
 			case 'time':
 				// @phan-suppress-next-line PhanUndeclaredMethod
-				return [ 'wdv:' . $dataValue->getHash(), true ];
+				return ['wdv:'.$dataValue->getHash(), true];
 			default:
-				throw new InvalidArgumentException( 'unknown data type: ' . $dataType );
+				throw new InvalidArgumentException('unknown data type: '.$dataType);
 		}
 	}
 	// phpcs:enable
@@ -560,43 +558,43 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpression( $text, $regex ) {
+	public function matchesRegularExpression($text, $regex) {
 		// caching wrapper around matchesRegularExpressionWithSparql
 
-		$textHash = hash( 'sha256', $text );
+		$textHash = hash('sha256', $text);
 		$cacheKey = $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'regex', // action
 			'WDQS-Java', // regex flavor
-			hash( 'sha256', $regex )
+			hash('sha256', $regex)
 		);
 
 		$cacheMapArray = $this->cache->getWithSetCallback(
 			$cacheKey,
 			WANObjectCache::TTL_DAY,
-			function ( $cacheMapArray ) use ( $text, $regex, $textHash ) {
+			function($cacheMapArray) use ($text, $regex, $textHash) {
 				// Initialize the cache map if not set
-				if ( $cacheMapArray === false ) {
+				if ($cacheMapArray === false) {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.init';
-					$this->dataFactory->increment( $key );
+					$this->dataFactory->increment($key);
 					return [];
 				}
 
 				$key = 'wikibase.quality.constraints.regex.cache.refresh';
-				$this->dataFactory->increment( $key );
-				$cacheMap = MapCacheLRU::newFromArray( $cacheMapArray, $this->cacheMapSize );
-				if ( $cacheMap->has( $textHash ) ) {
+				$this->dataFactory->increment($key);
+				$cacheMap = MapCacheLRU::newFromArray($cacheMapArray, $this->cacheMapSize);
+				if ($cacheMap->has($textHash)) {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.hit';
-					$this->dataFactory->increment( $key );
-					$cacheMap->get( $textHash ); // ping cache
+					$this->dataFactory->increment($key);
+					$cacheMap->get($textHash); // ping cache
 				} else {
 					$key = 'wikibase.quality.constraints.regex.cache.refresh.miss';
-					$this->dataFactory->increment( $key );
+					$this->dataFactory->increment($key);
 					try {
-						$matches = $this->matchesRegularExpressionWithSparql( $text, $regex );
-					} catch ( ConstraintParameterException $e ) {
-						$matches = $this->serializeConstraintParameterException( $e );
-					} catch ( SparqlHelperException $e ) {
+						$matches = $this->matchesRegularExpressionWithSparql($text, $regex);
+					} catch (ConstraintParameterException $e) {
+						$matches = $this->serializeConstraintParameterException($e);
+					} catch (SparqlHelperException $e) {
 						// don’t cache this
 						return $cacheMap->toArray();
 					}
@@ -620,42 +618,42 @@ 
 			]
 		);
 
-		if ( isset( $cacheMapArray[$textHash] ) ) {
+		if (isset($cacheMapArray[$textHash])) {
 			$key = 'wikibase.quality.constraints.regex.cache.hit';
-			$this->dataFactory->increment( $key );
+			$this->dataFactory->increment($key);
 			$matches = $cacheMapArray[$textHash];
-			if ( is_bool( $matches ) ) {
+			if (is_bool($matches)) {
 				return $matches;
-			} elseif ( is_array( $matches ) &&
-				$matches['type'] == ConstraintParameterException::class ) {
-				throw $this->deserializeConstraintParameterException( $matches );
+			} elseif (is_array($matches) &&
+				$matches['type'] == ConstraintParameterException::class) {
+				throw $this->deserializeConstraintParameterException($matches);
 			} else {
 				throw new UnexpectedValueException(
-					'Value of unknown type in object cache (' .
-					'cache key: ' . $cacheKey . ', ' .
-					'cache map key: ' . $textHash . ', ' .
-					'value type: ' . gettype( $matches ) . ')'
+					'Value of unknown type in object cache ('.
+					'cache key: '.$cacheKey.', '.
+					'cache map key: '.$textHash.', '.
+					'value type: '.gettype($matches).')'
 				);
 			}
 		} else {
 			$key = 'wikibase.quality.constraints.regex.cache.miss';
-			$this->dataFactory->increment( $key );
-			return $this->matchesRegularExpressionWithSparql( $text, $regex );
+			$this->dataFactory->increment($key);
+			return $this->matchesRegularExpressionWithSparql($text, $regex);
 		}
 	}
 
-	private function serializeConstraintParameterException( ConstraintParameterException $cpe ) {
+	private function serializeConstraintParameterException(ConstraintParameterException $cpe) {
 		return [
 			'type' => ConstraintParameterException::class,
-			'violationMessage' => $this->violationMessageSerializer->serialize( $cpe->getViolationMessage() ),
+			'violationMessage' => $this->violationMessageSerializer->serialize($cpe->getViolationMessage()),
 		];
 	}
 
-	private function deserializeConstraintParameterException( array $serialization ) {
+	private function deserializeConstraintParameterException(array $serialization) {
 		$message = $this->violationMessageDeserializer->deserialize(
 			$serialization['violationMessage']
 		);
-		return new ConstraintParameterException( $message );
+		return new ConstraintParameterException($message);
 	}
 
 	/**
@@ -669,25 +667,25 @@ 
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 * @throws ConstraintParameterException if the $regex is invalid
 	 */
-	public function matchesRegularExpressionWithSparql( $text, $regex ) {
-		$textStringLiteral = $this->stringLiteral( $text );
-		$regexStringLiteral = $this->stringLiteral( '^(?:' . $regex . ')$' );
+	public function matchesRegularExpressionWithSparql($text, $regex) {
+		$textStringLiteral = $this->stringLiteral($text);
+		$regexStringLiteral = $this->stringLiteral('^(?:'.$regex.')$');
 
 		$query = <<<EOF
 SELECT (REGEX($textStringLiteral, $regexStringLiteral) AS ?matches) {}
 EOF;
 
-		$result = $this->runQuery( $query, false );
+		$result = $this->runQuery($query, false);
 
 		$vars = $result->getArray()['results']['bindings'][0];
-		if ( array_key_exists( 'matches', $vars ) ) {
+		if (array_key_exists('matches', $vars)) {
 			// true or false ⇒ regex okay, text matches or not
 			return $vars['matches']['value'] === 'true';
 		} else {
 			// empty result: regex broken
 			throw new ConstraintParameterException(
-				( new ViolationMessage( 'wbqc-violation-message-parameter-regex' ) )
-					->withInlineCode( $regex, Role::CONSTRAINT_PARAMETER_VALUE )
+				(new ViolationMessage('wbqc-violation-message-parameter-regex'))
+					->withInlineCode($regex, Role::CONSTRAINT_PARAMETER_VALUE)
 			);
 		}
 	}
@@ -699,14 +697,14 @@ 
 	 *
 	 * @return boolean
 	 */
-	public function isTimeout( $responseContent ) {
-		$timeoutRegex = implode( '|', array_map(
-			static function ( $fqn ) {
-				return preg_quote( $fqn, '/' );
+	public function isTimeout($responseContent) {
+		$timeoutRegex = implode('|', array_map(
+			static function($fqn) {
+				return preg_quote($fqn, '/');
 			},
 			$this->timeoutExceptionClasses
-		) );
-		return (bool)preg_match( '/' . $timeoutRegex . '/', $responseContent );
+		));
+		return (bool) preg_match('/'.$timeoutRegex.'/', $responseContent);
 	}
 
 	/**
@@ -718,17 +716,17 @@ 
 	 * @return int|boolean the max-age (in seconds)
 	 * or a plain boolean if no max-age can be determined
 	 */
-	public function getCacheMaxAge( $responseHeaders ) {
+	public function getCacheMaxAge($responseHeaders) {
 		if (
-			array_key_exists( 'x-cache-status', $responseHeaders ) &&
-			preg_match( '/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0] )
+			array_key_exists('x-cache-status', $responseHeaders) &&
+			preg_match('/^hit(?:-.*)?$/', $responseHeaders['x-cache-status'][0])
 		) {
 			$maxage = [];
 			if (
-				array_key_exists( 'cache-control', $responseHeaders ) &&
-				preg_match( '/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage )
+				array_key_exists('cache-control', $responseHeaders) &&
+				preg_match('/\bmax-age=(\d+)\b/', $responseHeaders['cache-control'][0], $maxage)
 			) {
-				return intval( $maxage[1] );
+				return intval($maxage[1]);
 			} else {
 				return true;
 			}
@@ -749,34 +747,34 @@ 
 	 * or SparlHelper::EMPTY_RETRY_AFTER if there is an empty Retry-After
 	 * or SparlHelper::INVALID_RETRY_AFTER if there is something wrong with the format
 	 */
-	public function getThrottling( MWHttpRequest $request ) {
-		$retryAfterValue = $request->getResponseHeader( 'Retry-After' );
-		if ( $retryAfterValue === null ) {
+	public function getThrottling(MWHttpRequest $request) {
+		$retryAfterValue = $request->getResponseHeader('Retry-After');
+		if ($retryAfterValue === null) {
 			return self::NO_RETRY_AFTER;
 		}
 
-		$trimmedRetryAfterValue = trim( $retryAfterValue );
-		if ( empty( $trimmedRetryAfterValue ) ) {
+		$trimmedRetryAfterValue = trim($retryAfterValue);
+		if (empty($trimmedRetryAfterValue)) {
 			return self::EMPTY_RETRY_AFTER;
 		}
 
-		if ( is_numeric( $trimmedRetryAfterValue ) ) {
-			$delaySeconds = (int)$trimmedRetryAfterValue;
-			if ( $delaySeconds >= 0 ) {
-				return $this->getTimestampInFuture( new DateInterval( 'PT' . $delaySeconds . 'S' ) );
+		if (is_numeric($trimmedRetryAfterValue)) {
+			$delaySeconds = (int) $trimmedRetryAfterValue;
+			if ($delaySeconds >= 0) {
+				return $this->getTimestampInFuture(new DateInterval('PT'.$delaySeconds.'S'));
 			}
 		} else {
-			$return = strtotime( $trimmedRetryAfterValue );
-			if ( !empty( $return ) ) {
-				return new ConvertibleTimestamp( $return );
+			$return = strtotime($trimmedRetryAfterValue);
+			if (!empty($return)) {
+				return new ConvertibleTimestamp($return);
 			}
 		}
 		return self::INVALID_RETRY_AFTER;
 	}
 
-	private function getTimestampInFuture( DateInterval $delta ) {
+	private function getTimestampInFuture(DateInterval $delta) {
 		$now = new ConvertibleTimestamp();
-		return new ConvertibleTimestamp( $now->timestamp->add( $delta ) );
+		return new ConvertibleTimestamp($now->timestamp->add($delta));
 	}
 
 	/**
@@ -790,65 +788,64 @@ 
 	 *
 	 * @throws SparqlHelperException if the query times out or some other error occurs
 	 */
-	public function runQuery( $query, $needsPrefixes = true ) {
+	public function runQuery($query, $needsPrefixes = true) {
 
-		if ( $this->throttlingLock->isLocked( self::EXPIRY_LOCK_ID ) ) {
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' );
+		if ($this->throttlingLock->isLocked(self::EXPIRY_LOCK_ID)) {
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling');
 			throw new TooManySparqlRequestsException();
 		}
 
-		if ( $this->sparqlHasWikibaseSupport ) {
+		if ($this->sparqlHasWikibaseSupport) {
 			$needsPrefixes = false;
 		}
 
-		if ( $needsPrefixes ) {
-			$query = $this->prefixes . $query;
+		if ($needsPrefixes) {
+			$query = $this->prefixes.$query;
 		}
-		$query = "#wbqc\n" . $query;
+		$query = "#wbqc\n".$query;
 
-		$url = $this->endpoint . '?' . http_build_query(
+		$url = $this->endpoint.'?'.http_build_query(
 			[
 				'query' => $query,
 				'format' => 'json',
 				'maxQueryTimeMillis' => $this->maxQueryTimeMillis,
 			],
-			'', ini_get( 'arg_separator.output' ),
+			'', ini_get('arg_separator.output'),
 			// encode spaces with %20, not +
 			PHP_QUERY_RFC3986
 		);
 
 		$options = [
 			'method' => 'GET',
-			'timeout' => (int)round( ( $this->maxQueryTimeMillis + 1000 ) / 1000 ),
+			'timeout' => (int) round(($this->maxQueryTimeMillis + 1000) / 1000),
 			'connectTimeout' => 'default',
 			'userAgent' => $this->defaultUserAgent,
 		];
-		$request = $this->requestFactory->create( $url, $options, __METHOD__ );
-		$startTime = microtime( true );
+		$request = $this->requestFactory->create($url, $options, __METHOD__);
+		$startTime = microtime(true);
 		$requestStatus = $request->execute();
-		$endTime = microtime( true );
+		$endTime = microtime(true);
 		$this->dataFactory->timing(
 			'wikibase.quality.constraints.sparql.timing',
-			( $endTime - $startTime ) * 1000
+			($endTime - $startTime) * 1000
 		);
 
-		$this->guardAgainstTooManyRequestsError( $request );
+		$this->guardAgainstTooManyRequestsError($request);
 
-		$maxAge = $this->getCacheMaxAge( $request->getResponseHeaders() );
-		if ( $maxAge ) {
-			$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.cached' );
+		$maxAge = $this->getCacheMaxAge($request->getResponseHeaders());
+		if ($maxAge) {
+			$this->dataFactory->increment('wikibase.quality.constraints.sparql.cached');
 		}
 
-		if ( $requestStatus->isOK() ) {
+		if ($requestStatus->isOK()) {
 			$json = $request->getContent();
-			$jsonStatus = FormatJson::parse( $json, FormatJson::FORCE_ASSOC );
-			if ( $jsonStatus->isOK() ) {
+			$jsonStatus = FormatJson::parse($json, FormatJson::FORCE_ASSOC);
+			if ($jsonStatus->isOK()) {
 				return new CachedQueryResults(
 					$jsonStatus->getValue(),
 					Metadata::ofCachingMetadata(
 						$maxAge ?
-							CachingMetadata::ofMaximumAgeInSeconds( $maxAge ) :
-							CachingMetadata::fresh()
+							CachingMetadata::ofMaximumAgeInSeconds($maxAge) : CachingMetadata::fresh()
 					)
 				);
 			} else {
@@ -865,9 +862,9 @@ 
 			// fall through to general error handling
 		}
 
-		$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.error' );
+		$this->dataFactory->increment('wikibase.quality.constraints.sparql.error');
 
-		if ( $this->isTimeout( $request->getContent() ) ) {
+		if ($this->isTimeout($request->getContent())) {
 			$this->dataFactory->increment(
 				'wikibase.quality.constraints.sparql.error.timeout'
 			);
@@ -882,29 +879,29 @@ 
 	 * @param MWHttpRequest $request
 	 * @throws TooManySparqlRequestsException
 	 */
-	private function guardAgainstTooManyRequestsError( MWHttpRequest $request ): void {
-		if ( $request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS ) {
+	private function guardAgainstTooManyRequestsError(MWHttpRequest $request): void {
+		if ($request->getStatus() !== self::HTTP_TOO_MANY_REQUESTS) {
 			return;
 		}
 
 		$fallbackBlockDuration = $this->sparqlThrottlingFallbackDuration;
 
-		if ( $fallbackBlockDuration < 0 ) {
-			throw new InvalidArgumentException( 'Fallback duration must be positive int but is: ' .
-				$fallbackBlockDuration );
+		if ($fallbackBlockDuration < 0) {
+			throw new InvalidArgumentException('Fallback duration must be positive int but is: '.
+				$fallbackBlockDuration);
 		}
 
-		$this->dataFactory->increment( 'wikibase.quality.constraints.sparql.throttling' );
-		$throttlingUntil = $this->getThrottling( $request );
-		if ( !( $throttlingUntil instanceof ConvertibleTimestamp ) ) {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid( $request );
+		$this->dataFactory->increment('wikibase.quality.constraints.sparql.throttling');
+		$throttlingUntil = $this->getThrottling($request);
+		if (!($throttlingUntil instanceof ConvertibleTimestamp)) {
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterInvalid($request);
 			$this->throttlingLock->lock(
 				self::EXPIRY_LOCK_ID,
-				$this->getTimestampInFuture( new DateInterval( 'PT' . $fallbackBlockDuration . 'S' ) )
+				$this->getTimestampInFuture(new DateInterval('PT'.$fallbackBlockDuration.'S'))
 			);
 		} else {
-			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent( $throttlingUntil, $request );
-			$this->throttlingLock->lock( self::EXPIRY_LOCK_ID, $throttlingUntil );
+			$this->loggingHelper->logSparqlHelperTooManyRequestsRetryAfterPresent($throttlingUntil, $request);
+			$this->throttlingLock->lock(self::EXPIRY_LOCK_ID, $throttlingUntil);
 		}
 		throw new TooManySparqlRequestsException();
 	}

src/Specials/SpecialConstraintReport.php

Spacing +82 added lines, -82 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Specials;
 
@@ -90,7 +90,7 @@ 
 		Config $config,
 		IBufferingStatsdDataFactory $dataFactory
 	) {
-		parent::__construct( 'ConstraintReport' );
+		parent::__construct('ConstraintReport');
 
 		$this->entityLookup = $entityLookup;
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -110,7 +110,7 @@ 
 
 		$this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer(
 			$language,
-			$languageFallbackChainFactory->newFromLanguage( $language ),
+			$languageFallbackChainFactory->newFromLanguage($language),
 			$this->getContext()
 		);
 
@@ -144,7 +144,7 @@ 
 	 * @inheritDoc
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqc-constraintreport' );
+		return $this->msg('wbqc-constraintreport');
 	}
 
 	/**
@@ -156,43 +156,43 @@ 
 	 * @throws EntityIdParsingException
 	 * @throws UnexpectedValueException
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
-		if ( $postRequest ) {
-			$out->redirect( $this->getPageTitle( strtoupper( $postRequest ) )->getLocalURL() );
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
+		if ($postRequest) {
+			$out->redirect($this->getPageTitle(strtoupper($postRequest))->getLocalURL());
 			return;
 		}
 
 		$out->enableOOUI();
-		$out->addModules( $this->getModules() );
+		$out->addModules($this->getModules());
 
 		$this->setHeaders();
 
-		$out->addHTML( $this->getExplanationText() );
+		$out->addHTML($this->getExplanationText());
 		$this->buildEntityIdForm();
 
-		if ( !$subPage ) {
+		if (!$subPage) {
 			return;
 		}
 
-		if ( !is_string( $subPage ) ) {
-			throw new InvalidArgumentException( '$subPage must be string.' );
+		if (!is_string($subPage)) {
+			throw new InvalidArgumentException('$subPage must be string.');
 		}
 
 		try {
-			$entityId = $this->entityIdParser->parse( $subPage );
-		} catch ( EntityIdParsingException $e ) {
+			$entityId = $this->entityIdParser->parse($subPage);
+		} catch (EntityIdParsingException $e) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
+		if (!$this->entityLookup->hasEntity($entityId)) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
 			);
 			return;
 		}
@@ -200,18 +200,18 @@ 
 		$this->dataFactory->increment(
 			'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck'
 		);
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
 
-		if ( $results !== [] ) {
+		if ($results !== []) {
 			$out->addHTML(
-				$this->buildResultHeader( $entityId )
-				. $this->buildSummary( $results )
-				. $this->buildResultTable( $entityId, $results )
+				$this->buildResultHeader($entityId)
+				. $this->buildSummary($results)
+				. $this->buildResultTable($entityId, $results)
 			);
 		} else {
 			$out->addHTML(
-				$this->buildResultHeader( $entityId )
-				. $this->buildNotice( 'wbqc-constraintreport-empty-result' )
+				$this->buildResultHeader($entityId)
+				. $this->buildNotice('wbqc-constraintreport-empty-result')
 			);
 		}
 	}
@@ -227,15 +227,15 @@ 
 				'name' => 'entityid',
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->escaped(),
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->escaped(),
 			],
 		];
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form' );
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->escaped() );
-		$htmlForm->setSubmitCallback( static function () {
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(), 'wbqc-constraintreport-form');
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->escaped());
+		$htmlForm->setSubmitCallback(static function() {
 			return false;
 		} );
-		$htmlForm->setMethod( 'post' );
+		$htmlForm->setMethod('post');
 		$htmlForm->show();
 	}
 
@@ -249,9 +249,9 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildNotice( string $messageKey, bool $error = false ): string {
+	private function buildNotice(string $messageKey, bool $error = false): string {
 		$cssClasses = 'wbqc-constraintreport-notice';
-		if ( $error ) {
+		if ($error) {
 			$cssClasses .= ' wbqc-constraintreport-notice-error';
 		}
 
@@ -260,7 +260,7 @@ 
 				[
 					'class' => $cssClasses,
 				],
-				$this->msg( $messageKey )->escaped()
+				$this->msg($messageKey)->escaped()
 			);
 	}
 
@@ -270,16 +270,16 @@ 
 	private function getExplanationText(): string {
 		return Html::rawElement(
 			'div',
-			[ 'class' => 'wbqc-explanation' ],
+			['class' => 'wbqc-explanation'],
 			Html::rawElement(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->escaped()
+				$this->msg('wbqc-constraintreport-explanation-part-one')->escaped()
 			)
 			. Html::rawElement(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->escaped()
+				$this->msg('wbqc-constraintreport-explanation-part-two')->escaped()
 			)
 		);
 	}
@@ -290,31 +290,31 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildResultTable( EntityId $entityId, array $results ): string {
+	private function buildResultTable(EntityId $entityId, array $results): string {
 		// Set table headers
 		$table = new HtmlTableBuilder(
 			[
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-status')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-property')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-message')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->text(),
 					true
 				),
 			]
 		);
 
-		foreach ( $results as $result ) {
-			$table = $this->appendToResultTable( $table, $entityId, $result );
+		foreach ($results as $result) {
+			$table = $this->appendToResultTable($table, $entityId, $result);
 		}
 
 		return $table->toHtml();
@@ -326,35 +326,35 @@ 
 		CheckResult $result
 	): HtmlTableBuilder {
 		$message = $result->getMessage();
-		if ( $message === null ) {
+		if ($message === null) {
 			// no row for this result
 			return $table;
 		}
 
 		// Status column
-		$statusColumn = $this->formatStatus( $result->getStatus() );
+		$statusColumn = $this->formatStatus($result->getStatus());
 
 		// Property column
-		$propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() );
+		$propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId());
 		$propertyColumn = $this->getClaimLink(
 			$entityId,
 			$propertyId,
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
 		);
 
 		// Message column
-		$messageColumn = $this->violationMessageRenderer->render( $message );
+		$messageColumn = $this->violationMessageRenderer->render($message);
 
 		// Constraint column
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
 		try {
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
-		} catch ( InvalidArgumentException $e ) {
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
+		} catch (InvalidArgumentException $e) {
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
 		}
 		$constraintColumn = $this->getClaimLink(
 			$propertyId,
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
 			$constraintTypeLabel
 		);
 
@@ -362,16 +362,16 @@ 
 		$table->appendRow(
 			[
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $statusColumn )
+					new HtmlArmor($statusColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $propertyColumn )
+					new HtmlArmor($propertyColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $messageColumn )
+					new HtmlArmor($messageColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $constraintColumn )
+					new HtmlArmor($constraintColumn)
 				),
 			]
 		);
@@ -386,15 +386,15 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildResultHeader( EntityId $entityId ): string {
-		$entityLink = sprintf( '%s (%s)',
-							   $this->entityIdLinkFormatter->formatEntityId( $entityId ),
-							   htmlspecialchars( $entityId->getSerialization() ) );
+	protected function buildResultHeader(EntityId $entityId): string {
+		$entityLink = sprintf('%s (%s)',
+							   $this->entityIdLinkFormatter->formatEntityId($entityId),
+							   htmlspecialchars($entityId->getSerialization()));
 
 		return Html::rawElement(
 			'h3',
 			[],
-			sprintf( '%s %s', $this->msg( 'wbqc-constraintreport-result-headline' )->escaped(), $entityLink )
+			sprintf('%s %s', $this->msg('wbqc-constraintreport-result-headline')->escaped(), $entityLink)
 		);
 	}
 
@@ -405,24 +405,24 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildSummary( array $results ): string {
+	protected function buildSummary(array $results): string {
 		$statuses = [];
-		foreach ( $results as $result ) {
-			$status = strtolower( $result->getStatus() );
-			$statuses[$status] = isset( $statuses[$status] ) ? $statuses[$status] + 1 : 1;
+		foreach ($results as $result) {
+			$status = strtolower($result->getStatus());
+			$statuses[$status] = isset($statuses[$status]) ? $statuses[$status] + 1 : 1;
 		}
 
 		$statusElements = [];
-		foreach ( $statuses as $status => $count ) {
-			if ( $count > 0 ) {
+		foreach ($statuses as $status => $count) {
+			if ($count > 0) {
 				$statusElements[] =
-					$this->formatStatus( $status )
+					$this->formatStatus($status)
 					. ': '
 					. $count;
 			}
 		}
 
-		return Html::rawElement( 'p', [], implode( ', ', $statusElements ) );
+		return Html::rawElement('p', [], implode(', ', $statusElements));
 	}
 
 	/**
@@ -434,8 +434,8 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatStatus( string $status ): string {
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
+	private function formatStatus(string $status): string {
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
 		$statusIcons = [
 			CheckResult::STATUS_SUGGESTION => [
 				'icon' => 'suggestion-constraint-violation',
@@ -452,25 +452,25 @@ 
 			],
 		];
 
-		if ( array_key_exists( $status, $statusIcons ) ) {
-			$iconWidget = new IconWidget( $statusIcons[$status] );
-			$iconHtml = $iconWidget->toString() . ' ';
+		if (array_key_exists($status, $statusIcons)) {
+			$iconWidget = new IconWidget($statusIcons[$status]);
+			$iconHtml = $iconWidget->toString().' ';
 		} else {
 			$iconHtml = '';
 		}
 
-		$labelWidget = new LabelWidget( [
-			'label' => $this->msg( $messageName )->text(),
-		] );
+		$labelWidget = new LabelWidget([
+			'label' => $this->msg($messageName)->text(),
+		]);
 		$labelHtml = $labelWidget->toString();
 
 		$formattedStatus =
 			Html::rawElement(
 				'span',
 				[
-					'class' => 'wbqc-status wbqc-status-' . $status,
+					'class' => 'wbqc-status wbqc-status-'.$status,
 				],
-				$iconHtml . $labelHtml
+				$iconHtml.$labelHtml
 			);
 
 		return $formattedStatus;
@@ -493,7 +493,7 @@ 
 		return Html::rawElement(
 			'a',
 			[
-				'href' => $this->getClaimUrl( $entityId, $propertyId ),
+				'href' => $this->getClaimUrl($entityId, $propertyId),
 				'target' => '_blank',
 			],
 			$text
@@ -507,8 +507,8 @@ 
 		EntityId $entityId,
 		NumericPropertyId $propertyId
 	): string {
-		$title = $this->entityTitleLookup->getTitleForId( $entityId );
-		$entityUrl = sprintf( '%s#%s', $title->getLocalURL(), $propertyId->getSerialization() );
+		$title = $this->entityTitleLookup->getTitleForId($entityId);
+		$entityUrl = sprintf('%s#%s', $title->getLocalURL(), $propertyId->getSerialization());
 
 		return $entityUrl;
 	}

src/Html/HtmlTableHeaderBuilder.php

Spacing +7 added lines, -7 removed lines

@@ -33,9 +33,9 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, $isSortable = false ) {
-		Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' );
-		Assert::parameterType( 'boolean', $isSortable, '$isSortable' );
+	public function __construct($content, $isSortable = false) {
+		Assert::parameterType(['string', HtmlArmor::class], $content, '$content');
+		Assert::parameterType('boolean', $isSortable, '$isSortable');
 
 		$this->content = $content;
 		$this->isSortable = $isSortable;
@@ -45,7 +45,7 @@ 
 	 * @return string HTML
 	 */
 	public function getContent() {
-		return HtmlArmor::getHtml( $this->content );
+		return HtmlArmor::getHtml($this->content);
 	}
 
 	/**
@@ -61,13 +61,13 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		$attributes = [ 'role' => 'columnheader button' ];
+		$attributes = ['role' => 'columnheader button'];
 
-		if ( !$this->isSortable ) {
+		if (!$this->isSortable) {
 			$attributes['class'] = 'unsortable';
 		}
 
-		return Html::rawElement( 'th', $attributes, $this->getContent() );
+		return Html::rawElement('th', $attributes, $this->getContent());
 	}
 
 }

src/Html/HtmlTableBuilder.php

Spacing +33 added lines, -33 removed lines

@@ -32,9 +32,9 @@ 
 	/**
 	 * @param array $headers
 	 */
-	public function __construct( array $headers ) {
-		foreach ( $headers as $header ) {
-			$this->addHeader( $header );
+	public function __construct(array $headers) {
+		foreach ($headers as $header) {
+			$this->addHeader($header);
 		}
 	}
 
@@ -43,16 +43,16 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	private function addHeader( $header ) {
-		Assert::parameterType( [ 'string', HtmlTableHeaderBuilder::class ], $header, '$header' );
+	private function addHeader($header) {
+		Assert::parameterType(['string', HtmlTableHeaderBuilder::class], $header, '$header');
 
-		if ( is_string( $header ) ) {
-			$header = new HtmlTableHeaderBuilder( $header );
+		if (is_string($header)) {
+			$header = new HtmlTableHeaderBuilder($header);
 		}
 
 		$this->headers[] = $header;
 
-		if ( $header->getIsSortable() ) {
+		if ($header->getIsSortable()) {
 			$this->isSortable = true;
 		}
 	}
@@ -85,12 +85,12 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function appendRow( array $cells ) {
-		foreach ( $cells as $key => $cell ) {
-			if ( is_string( $cell ) ) {
-				$cells[$key] = new HtmlTableCellBuilder( $cell );
-			} elseif ( !( $cell instanceof HtmlTableCellBuilder ) ) {
-				throw new InvalidArgumentException( '$cells must be array of HtmlTableCell objects.' );
+	public function appendRow(array $cells) {
+		foreach ($cells as $key => $cell) {
+			if (is_string($cell)) {
+				$cells[$key] = new HtmlTableCellBuilder($cell);
+			} elseif (!($cell instanceof HtmlTableCellBuilder)) {
+				throw new InvalidArgumentException('$cells must be array of HtmlTableCell objects.');
 			}
 		}
 
@@ -104,13 +104,13 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function appendRows( array $rows ) {
-		foreach ( $rows as $cells ) {
-			if ( !is_array( $cells ) ) {
-				throw new InvalidArgumentException( '$rows must be array of arrays of HtmlTableCell objects.' );
+	public function appendRows(array $rows) {
+		foreach ($rows as $cells) {
+			if (!is_array($cells)) {
+				throw new InvalidArgumentException('$rows must be array of arrays of HtmlTableCell objects.');
 			}
 
-			$this->appendRow( $cells );
+			$this->appendRow($cells);
 		}
 	}
 
@@ -122,38 +122,38 @@ 
 	public function toHtml() {
 		// Open table
 		$tableClasses = 'wikitable';
-		if ( $this->isSortable ) {
+		if ($this->isSortable) {
 			$tableClasses .= ' sortable';
 		}
-		$html = Html::openElement( 'table', [ 'class' => $tableClasses ] );
+		$html = Html::openElement('table', ['class' => $tableClasses]);
 
 		// Write headers
-		$html .= Html::openElement( 'thead' );
-		$html .= Html::openElement( 'tr' );
-		foreach ( $this->headers as $header ) {
+		$html .= Html::openElement('thead');
+		$html .= Html::openElement('tr');
+		foreach ($this->headers as $header) {
 			$html .= $header->toHtml();
 		}
-		$html .= Html::closeElement( 'tr' );
-		$html .= Html::closeElement( 'thead' );
-		$html .= Html::openElement( 'tbody' );
+		$html .= Html::closeElement('tr');
+		$html .= Html::closeElement('thead');
+		$html .= Html::openElement('tbody');
 
 		// Write rows
-		foreach ( $this->rows as $row ) {
-			$html .= Html::openElement( 'tr' );
+		foreach ($this->rows as $row) {
+			$html .= Html::openElement('tr');
 
 			/**
 			 * @var HtmlTableCellBuilder $cell
 			 */
-			foreach ( $row as $cell ) {
+			foreach ($row as $cell) {
 				$html .= $cell->toHtml();
 			}
 
-			$html .= Html::closeElement( 'tr' );
+			$html .= Html::closeElement('tr');
 		}
 
 		// Close table
-		$html .= Html::closeElement( 'tbody' );
-		$html .= Html::closeElement( 'table' );
+		$html .= Html::closeElement('tbody');
+		$html .= Html::closeElement('table');
 
 		return $html;
 	}

src/Html/HtmlTableCellBuilder.php

Spacing +4 added lines, -4 removed lines

@@ -31,8 +31,8 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $content, array $attributes = [] ) {
-		Assert::parameterType( [ 'string', HtmlArmor::class ], $content, '$content' );
+	public function __construct($content, array $attributes = []) {
+		Assert::parameterType(['string', HtmlArmor::class], $content, '$content');
 
 		$this->content = $content;
 		$this->attributes = $attributes;
@@ -42,7 +42,7 @@ 
 	 * @return string HTML
 	 */
 	public function getContent() {
-		return HtmlArmor::getHtml( $this->content );
+		return HtmlArmor::getHtml($this->content);
 	}
 
 	/**
@@ -56,7 +56,7 @@ 
 	 * @return string HTML
 	 */
 	public function toHtml() {
-		return Html::rawElement( 'td', $this->getAttributes(), $this->getContent() );
+		return Html::rawElement('td', $this->getAttributes(), $this->getContent());
 	}
 
 }

src/WikibaseQualityConstraintsHooks.php

Spacing +35 added lines, -35 removed lines

@@ -26,8 +26,8 @@ 
 	BeforePageDisplayHook
 {
 
-	public static function onWikibaseChange( Change $change ) {
-		if ( !( $change instanceof EntityChange ) ) {
+	public static function onWikibaseChange(Change $change) {
+		if (!($change instanceof EntityChange)) {
 			return;
 		}
 		/** @var EntityChange $change */
@@ -38,48 +38,48 @@ 
 
 		// If jobs are enabled and the results would be stored in some way run a job.
 		if (
-			$config->get( 'WBQualityConstraintsEnableConstraintsCheckJobs' ) &&
-			$config->get( 'WBQualityConstraintsCacheCheckConstraintsResults' ) &&
+			$config->get('WBQualityConstraintsEnableConstraintsCheckJobs') &&
+			$config->get('WBQualityConstraintsCacheCheckConstraintsResults') &&
 			self::isSelectedForJobRunBasedOnPercentage()
 		) {
-			$params = [ 'entityId' => $change->getEntityId()->getSerialization() ];
+			$params = ['entityId' => $change->getEntityId()->getSerialization()];
 			$jobQueueGroup->lazyPush(
-				new JobSpecification( CheckConstraintsJob::COMMAND, $params )
+				new JobSpecification(CheckConstraintsJob::COMMAND, $params)
 			);
 		}
 
-		if ( $config->get( 'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-			self::isConstraintStatementsChange( $config, $change )
+		if ($config->get('WBQualityConstraintsEnableConstraintsImportFromStatements') &&
+			self::isConstraintStatementsChange($config, $change)
 		) {
-			$params = [ 'propertyId' => $change->getEntityId()->getSerialization() ];
+			$params = ['propertyId' => $change->getEntityId()->getSerialization()];
 			$metadata = $change->getMetadata();
-			if ( array_key_exists( 'rev_id', $metadata ) ) {
+			if (array_key_exists('rev_id', $metadata)) {
 				$params['revisionId'] = $metadata['rev_id'];
 			}
 			$jobQueueGroup->push(
-				new JobSpecification( 'constraintsTableUpdate', $params )
+				new JobSpecification('constraintsTableUpdate', $params)
 			);
 		}
 	}
 
 	private static function isSelectedForJobRunBasedOnPercentage() {
 		$config = MediaWikiServices::getInstance()->getMainConfig();
-		$percentage = $config->get( 'WBQualityConstraintsEnableConstraintsCheckJobsRatio' );
+		$percentage = $config->get('WBQualityConstraintsEnableConstraintsCheckJobsRatio');
 
-		return mt_rand( 1, 100 ) <= $percentage;
+		return mt_rand(1, 100) <= $percentage;
 	}
 
-	public static function isConstraintStatementsChange( Config $config, Change $change ) {
-		if ( !( $change instanceof EntityChange ) ||
+	public static function isConstraintStatementsChange(Config $config, Change $change) {
+		if (!($change instanceof EntityChange) ||
 			 $change->getAction() !== EntityChange::UPDATE ||
-			 !( $change->getEntityId() instanceof NumericPropertyId )
+			 !($change->getEntityId() instanceof NumericPropertyId)
 		) {
 			return false;
 		}
 
 		$info = $change->getInfo();
 
-		if ( !array_key_exists( 'compactDiff', $info ) ) {
+		if (!array_key_exists('compactDiff', $info)) {
 			// the non-compact diff ($info['diff']) does not contain statement diffs (T110996),
 			// so we only know that the change *might* affect the constraint statements
 			return true;
@@ -88,50 +88,50 @@ 
 		/** @var EntityDiffChangedAspects $aspects */
 		$aspects = $info['compactDiff'];
 
-		$propertyConstraintId = $config->get( 'WBQualityConstraintsPropertyConstraintId' );
-		return in_array( $propertyConstraintId, $aspects->getStatementChanges() );
+		$propertyConstraintId = $config->get('WBQualityConstraintsPropertyConstraintId');
+		return in_array($propertyConstraintId, $aspects->getStatementChanges());
 	}
 
-	public function onArticlePurge( $wikiPage ) {
+	public function onArticlePurge($wikiPage) {
 		$entityContentFactory = WikibaseRepo::getEntityContentFactory();
-		if ( $entityContentFactory->isEntityContentModel( $wikiPage->getContentModel() ) ) {
+		if ($entityContentFactory->isEntityContentModel($wikiPage->getContentModel())) {
 			$entityIdLookup = WikibaseRepo::getEntityIdLookup();
-			$entityId = $entityIdLookup->getEntityIdForTitle( $wikiPage->getTitle() );
-			if ( $entityId !== null ) {
+			$entityId = $entityIdLookup->getEntityIdForTitle($wikiPage->getTitle());
+			if ($entityId !== null) {
 				$resultsCache = ResultsCache::getDefaultInstance();
-				$resultsCache->delete( $entityId );
+				$resultsCache->delete($entityId);
 			}
 		}
 	}
 
-	public function onBeforePageDisplay( $out, $skin ): void {
+	public function onBeforePageDisplay($out, $skin): void {
 		$lookup = WikibaseRepo::getEntityNamespaceLookup();
 		$title = $out->getTitle();
-		if ( $title === null ) {
+		if ($title === null) {
 			return;
 		}
 
-		if ( !$lookup->isNamespaceWithEntities( $title->getNamespace() ) ) {
+		if (!$lookup->isNamespaceWithEntities($title->getNamespace())) {
 			return;
 		}
-		if ( empty( $out->getJsConfigVars()['wbIsEditView'] ) ) {
+		if (empty($out->getJsConfigVars()['wbIsEditView'])) {
 			return;
 		}
 
 		$services = MediaWikiServices::getInstance();
 		$config = $services->getMainConfig();
 
-		$isMobileView = ExtensionRegistry::getInstance()->isLoaded( 'MobileFrontend' ) &&
-			$services->getService( 'MobileFrontend.Context' )->shouldDisplayMobileView();
-		if ( $isMobileView ) {
+		$isMobileView = ExtensionRegistry::getInstance()->isLoaded('MobileFrontend') &&
+			$services->getService('MobileFrontend.Context')->shouldDisplayMobileView();
+		if ($isMobileView) {
 			return;
 		}
 
-		$out->addModules( 'wikibase.quality.constraints.suggestions' );
+		$out->addModules('wikibase.quality.constraints.suggestions');
 
-		if ( $config->get( 'WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers' )
-			|| $out->getUser()->isRegistered() ) {
-				$out->addModules( 'wikibase.quality.constraints.gadget' );
+		if ($config->get('WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers')
+			|| $out->getUser()->isRegistered()) {
+				$out->addModules('wikibase.quality.constraints.gadget');
 		}
 	}
 

src/WikibaseQualityConstraintsSchemaHooks.php

Spacing +5 added lines, -5 removed lines

@@ -15,22 +15,22 @@
 	/**
 	 * @param DatabaseUpdater $updater
 	 */
-	public function onLoadExtensionSchemaUpdates( $updater ) {
-		$dir = dirname( __DIR__ ) . '/sql/';
+	public function onLoadExtensionSchemaUpdates($updater) {
+		$dir = dirname(__DIR__).'/sql/';
 
 		$updater->addExtensionTable(
 			'wbqc_constraints',
-			$dir . "/{$updater->getDB()->getType()}/tables-generated.sql"
+			$dir."/{$updater->getDB()->getType()}/tables-generated.sql"
 		);
 		$updater->addExtensionField(
 			'wbqc_constraints',
 			'constraint_id',
-			$dir . '/patch-wbqc_constraints-constraint_id.sql'
+			$dir.'/patch-wbqc_constraints-constraint_id.sql'
 		);
 		$updater->addExtensionIndex(
 			'wbqc_constraints',
 			'wbqc_constraints_guid_uniq',
-			$dir . '/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
+			$dir.'/patch-wbqc_constraints-wbqc_constraints_guid_uniq.sql'
 		);
 	}